[GitHub] felix pull request #97: [FELIX-5589] Optimize Memory usage of empty bundle r...

2017-03-13 Thread CodingFabian 
GitHub user CodingFabian opened a pull request:

https://github.com/apache/felix/pull/97

[FELIX-5589] Optimize Memory usage of empty bundle requirements/capab…

…ilities

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/CodingFabian/felix FELIX-5589

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/felix/pull/97.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #97


commit 640428095b73c3c92831c0ec7a486482cef01286
Author: Fabian Lange 
Date:   2017-03-13T18:55:08Z

[FELIX-5589] Optimize Memory usage of empty bundle requirements/capabilities




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[jira] [Commented] (FELIX-5589) reduce memory usage of BundleRequirementImpl / BundleCapabilityImpl

2017-03-13 Thread Fabian Lange (JIRA) 

[ 
https://issues.apache.org/jira/browse/FELIX-5589?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15922737#comment-15922737
 ] 

Fabian Lange commented on FELIX-5589:
-

of course this is not a big improvement, but your milage might vary depending 
on installed bundles. but since the change is trivial, I would love to see it 
picked up.

> reduce memory usage of BundleRequirementImpl / BundleCapabilityImpl
> ---
>
> Key: FELIX-5589
> URL: https://issues.apache.org/jira/browse/FELIX-5589
> Project: Felix
>  Issue Type: Improvement
>  Components: Framework
>Reporter: Fabian Lange
>Priority: Minor
> Attachments: Screen Shot 2017-03-13 at 19.52.55.png
>
>
> Currently BundleRequirementImpl and BundleCapabilityImpl might allocate new 
> immutable maps when params are empty. This was pointed out by a profiling 
> session.
> the fix is easy: use Collections.EMPTY_MAP
> (pr coming)



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Commented] (FELIX-5589) reduce memory usage of BundleRequirementImpl / BundleCapabilityImpl

2017-03-13 Thread ASF GitHub Bot (JIRA) 

[ 
https://issues.apache.org/jira/browse/FELIX-5589?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15922731#comment-15922731
 ] 

ASF GitHub Bot commented on FELIX-5589:
---

GitHub user CodingFabian opened a pull request:

https://github.com/apache/felix/pull/97

[FELIX-5589] Optimize Memory usage of empty bundle requirements/capab…

…ilities

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/CodingFabian/felix FELIX-5589

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/felix/pull/97.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #97


commit 640428095b73c3c92831c0ec7a486482cef01286
Author: Fabian Lange 
Date:   2017-03-13T18:55:08Z

[FELIX-5589] Optimize Memory usage of empty bundle requirements/capabilities




> reduce memory usage of BundleRequirementImpl / BundleCapabilityImpl
> ---
>
> Key: FELIX-5589
> URL: https://issues.apache.org/jira/browse/FELIX-5589
> Project: Felix
>  Issue Type: Improvement
>  Components: Framework
>Reporter: Fabian Lange
>Priority: Minor
> Attachments: Screen Shot 2017-03-13 at 19.52.55.png
>
>
> Currently BundleRequirementImpl and BundleCapabilityImpl might allocate new 
> immutable maps when params are empty. This was pointed out by a profiling 
> session.
> the fix is easy: use Collections.EMPTY_MAP
> (pr coming)



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Created] (FELIX-5589) reduce memory usage of BundleRequirementImpl / BundleCapabilityImpl

2017-03-13 Thread Fabian Lange (JIRA) 
Fabian Lange created FELIX-5589:
---

 Summary: reduce memory usage of BundleRequirementImpl / 
BundleCapabilityImpl
 Key: FELIX-5589
 URL: https://issues.apache.org/jira/browse/FELIX-5589
 Project: Felix
  Issue Type: Improvement
  Components: Framework
Reporter: Fabian Lange
Priority: Minor
 Attachments: Screen Shot 2017-03-13 at 19.52.55.png

Currently BundleRequirementImpl and BundleCapabilityImpl might allocate new 
immutable maps when params are empty. This was pointed out by a profiling 
session.
the fix is easy: use Collections.EMPTY_MAP

(pr coming)



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

Re: [VOTE] Release Gogo Runtime / JLine 1.0.4

2017-03-13 Thread Guillaume Nodet 
+1

2017-03-08 17:51 GMT+01:00 Guillaume Nodet :

> I've staged the following bundles to release in the following repository:
>   https://repository.apache.org/content/repositories/orgapachefelix-1173
>
> Gogo Runtime 1.0.4
>
>- [FELIX-5462 ] -
>[gogo][runtime] Unable to add a converter using reflection
>- [FELIX-5465 ] -
>[gogo][runtime] No way to concatenate arrays
>- [FELIX-5486 ] -
>[gogo][runtime] Avoid unnecessary conversions from strings to
>booleans/integers
>- [FELIX-5541 ] -
>ArrayIndexOutOfBoundsException in the parser
>
>
> Gogo JLine 1.0.4
>
>- [FELIX-5463 ] -
>[gogo][jline] The Main class should add a default
>Function->FunctionInterface converter
>- [FELIX-5498 ] -
>[gogo][jline] The shell should display exception thrown from commands
>- [FELIX-5584 ] -
>[gogo][jline] Remove dependency on LineReaderImpl
>
>
> Tags:
>org.apache.felix.gogo.jline-1.0.4/
> 
>org.apache.felix.gogo.runtime-1.0.4/
> 
>
>
> Please review and vote !
>
>
> 
> Guillaume Nodet
>
>


-- 

Guillaume Nodet

[RESULT] [VOTE] Release Gogo Runtime / JLine 1.0.4

2017-03-13 Thread Guillaume Nodet 
Closing this vote with 6 +1s and no other votes.
Thx to everyone !

Cheers,
Guillaume

2017-03-08 17:51 GMT+01:00 Guillaume Nodet :

> I've staged the following bundles to release in the following repository:
>   https://repository.apache.org/content/repositories/orgapachefelix-1173
>
> Gogo Runtime 1.0.4
>
>- [FELIX-5462 ] -
>[gogo][runtime] Unable to add a converter using reflection
>- [FELIX-5465 ] -
>[gogo][runtime] No way to concatenate arrays
>- [FELIX-5486 ] -
>[gogo][runtime] Avoid unnecessary conversions from strings to
>booleans/integers
>- [FELIX-5541 ] -
>ArrayIndexOutOfBoundsException in the parser
>
>
> Gogo JLine 1.0.4
>
>- [FELIX-5463 ] -
>[gogo][jline] The Main class should add a default
>Function->FunctionInterface converter
>- [FELIX-5498 ] -
>[gogo][jline] The shell should display exception thrown from commands
>- [FELIX-5584 ] -
>[gogo][jline] Remove dependency on LineReaderImpl
>
>
> Tags:
>org.apache.felix.gogo.jline-1.0.4/
> 
>org.apache.felix.gogo.runtime-1.0.4/
> 
>
>
> Please review and vote !
>
>
> 
> Guillaume Nodet
>
>


-- 

Guillaume Nodet

[jira] [Closed] (FELIX-5582) maven-bundle-plugin: Make sure Closeable resources are closed

2017-03-13 Thread Stefan Seifert (JIRA) 

 [ 
https://issues.apache.org/jira/browse/FELIX-5582?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Stefan Seifert closed FELIX-5582.
-

> maven-bundle-plugin: Make sure Closeable resources are closed
> -
>
> Key: FELIX-5582
> URL: https://issues.apache.org/jira/browse/FELIX-5582
> Project: Felix
>  Issue Type: Bug
>  Components: Maven Bundle Plugin
>Affects Versions: maven-bundle-plugin-3.2.0
>Reporter: Stefan Seifert
>Assignee: Stefan Seifert
>Priority: Minor
> Fix For: maven-bundle-plugin-3.3.0
>
>
> some resources that implement the Closeable interface are not closed properly 
> in maven-bundle-plugin.
> this affects bnd Analyzer and Verifier objects.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Closed] (FELIX-5424) Augment exported service metadata

2017-03-13 Thread Stefan Seifert (JIRA) 

 [ 
https://issues.apache.org/jira/browse/FELIX-5424?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Stefan Seifert closed FELIX-5424.
-

> Augment exported service metadata
> -
>
> Key: FELIX-5424
> URL: https://issues.apache.org/jira/browse/FELIX-5424
> Project: Felix
>  Issue Type: Improvement
>  Components: Maven Bundle Plugin
>Reporter: Paolo Antinori
>Assignee: Guillaume Nodet
> Fix For: maven-bundle-plugin-3.3.0
>
>
> When Apache Aries Blueprint installs a service that points to a {{[bean]}} 
> node that has its {{id}} attribute specified, it adds an additional metadata 
> entry to the service registry:
> {code}
> osgi.service.blueprint.compname = myBeanId
> {code}
> That information is not automatically added to the Headers section of a 
> generated bundle though, thus preventing some kind of validation offline.
> The proposed patch adds the additional metadata at build time.
> This is a snippet of a use case that requires this:
> {code:xml}
>   
>
>   
>  interface="javax.sql.DataSource">
> 
>   
> {code}
> And, in another file:
> {code:xml}
>  availability="mandatory" component-name="mysql-ds" />
> {code}



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Closed] (FELIX-5579) Bundle Plugin uses insecure maven-archiver 2.5

2017-03-13 Thread Stefan Seifert (JIRA) 

 [ 
https://issues.apache.org/jira/browse/FELIX-5579?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Stefan Seifert closed FELIX-5579.
-

> Bundle Plugin uses insecure maven-archiver 2.5
> --
>
> Key: FELIX-5579
> URL: https://issues.apache.org/jira/browse/FELIX-5579
> Project: Felix
>  Issue Type: Bug
>  Components: Maven Bundle Plugin
>Affects Versions: maven-bundle-plugin-3.2.0
>Reporter: Mark Symons
>Assignee: Stefan Seifert
> Fix For: maven-bundle-plugin-3.3.0
>
>
> maven-bundle-plugin includes {{org.apache.maven:maven-archiver}} 2.5 as a 
> compile dependency.
> This version of maven-archiver uses {{org.codehaus.plexus:plexus-archiver}}  
> v2.1. which has level 5 threat 
> [CVE-2012-2098|https://web.nvd.nist.gov/view/vuln/detail?vulnId=CVE-2012-2098].
> The CVE mentions "sorting algorithms in bzip2 compressing stream" in context 
> of Apache Commons Compress,  but here is [one defect 
> reference|https://bugzilla.redhat.com/show_bug.cgi?id=951522] that confirms 
> that the threat applies to plexus-archiver versions prior to 2.3.1
> Thus, upgrade Bundle Plugin usage of maven-archiver to 2.6 (which uses 
> plexus-archiver 2.8.1) or later in order to mitigate the threat,
> Current release of maven-archiver is 3.1.1



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Closed] (FELIX-5581) Update to bndlib 3.3.0

2017-03-13 Thread Stefan Seifert (JIRA) 

 [ 
https://issues.apache.org/jira/browse/FELIX-5581?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Stefan Seifert closed FELIX-5581.
-

> Update to bndlib 3.3.0
> --
>
> Key: FELIX-5581
> URL: https://issues.apache.org/jira/browse/FELIX-5581
> Project: Felix
>  Issue Type: Improvement
>  Components: Maven Bundle Plugin
>Affects Versions: maven-bundle-plugin-3.2.0
>Reporter: Stefan Seifert
>Assignee: Stefan Seifert
> Fix For: maven-bundle-plugin-3.3.0
>
>
> version 3.3.0 of bndlib was published in sept. 2016.
> changelog: https://github.com/bndtools/bnd/wiki/Changes-in-3.3.0



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[RESULT] [VOTE] Release Apache Felix Maven Bundle Plugin 3.3.0

2017-03-13 Thread Stefan Seifert 
Hi,

The vote has passed with the following result :

  +1 (binding): David Bosschaert, Jean-Baptiste Onofré, Carsten Ziegeler,
  +1 (non binding): Raymond Auge, Stefan Seifert

I will promote the artifacts to the central Maven repository and update the 
felix site.

=> @any PMC member: please copy this release to the Felix dist directory.

stefan

RE: [VOTE] Release Apache Felix Maven Bundle Plugin 3.3.0

2017-03-13 Thread Stefan Seifert 
+1 (non-binding)

[jira] [Commented] (FELIX-5479) Serializer should be more lenient with trailing commas

2017-03-13 Thread David Leangen (JIRA) 

[ 
https://issues.apache.org/jira/browse/FELIX-5479?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15906980#comment-15906980
 ] 

David Leangen commented on FELIX-5479:
--

E, yes :-(

> Serializer should be more lenient with trailing commas
> --
>
> Key: FELIX-5479
> URL: https://issues.apache.org/jira/browse/FELIX-5479
> Project: Felix
>  Issue Type: Improvement
>  Components: Converter
>Reporter: David Leangen
>Assignee: David Leangen
>
> I believe that well-formed JSON does not permit a trailing comma, but 
> currently error reporting is not very good, so it is extremely tedious to 
> find parsing problems. Until we have better error reporting, the parser 
> should be more lenient. Allowing for trailing commas is one area where 
> leniency would be very beneficial to productivity.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Comment Edited] (FELIX-5479) Serializer should be more lenient with trailing commas

2017-03-13 Thread David Leangen (JIRA) 

[ 
https://issues.apache.org/jira/browse/FELIX-5479?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15906921#comment-15906921
 ] 

David Leangen edited comment on FELIX-5479 at 3/13/17 8:02 AM:
---

The request is invalid, as the JSON spec does not permit trailing commas.


was (Author: dleangen):
The request is invalid, as the JSON spec does not permit trailing spaces.

> Serializer should be more lenient with trailing commas
> --
>
> Key: FELIX-5479
> URL: https://issues.apache.org/jira/browse/FELIX-5479
> Project: Felix
>  Issue Type: Improvement
>  Components: Converter
>Reporter: David Leangen
>Assignee: David Leangen
>
> I believe that well-formed JSON does not permit a trailing comma, but 
> currently error reporting is not very good, so it is extremely tedious to 
> find parsing problems. Until we have better error reporting, the parser 
> should be more lenient. Allowing for trailing commas is one area where 
> leniency would be very beneficial to productivity.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Commented] (FELIX-5479) Serializer should be more lenient with trailing commas

2017-03-13 Thread David Bosschaert (JIRA) 

[ 
https://issues.apache.org/jira/browse/FELIX-5479?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15906977#comment-15906977
 ] 

David Bosschaert commented on FELIX-5479:
-

bq. the JSON spec does not permit trailing spaces

I guess you mean trailing commas? ;)

> Serializer should be more lenient with trailing commas
> --
>
> Key: FELIX-5479
> URL: https://issues.apache.org/jira/browse/FELIX-5479
> Project: Felix
>  Issue Type: Improvement
>  Components: Converter
>Reporter: David Leangen
>Assignee: David Leangen
>
> I believe that well-formed JSON does not permit a trailing comma, but 
> currently error reporting is not very good, so it is extremely tedious to 
> find parsing problems. Until we have better error reporting, the parser 
> should be more lenient. Allowing for trailing commas is one area where 
> leniency would be very beneficial to productivity.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

Re: [VOTE] Release Apache Felix Maven Bundle Plugin 3.3.0

2017-03-13 Thread Carsten Ziegeler 
+1

 

-- 
Carsten Ziegeler
Adobe Research Switzerland
cziege...@apache.org

Re: [VOTE] Release Gogo Runtime / JLine 1.0.4

2017-03-13 Thread Carsten Ziegeler 
+1
-- 
Carsten Ziegeler
Adobe Research Switzerland
cziege...@apache.org

[jira] [Resolved] (FELIX-5588) Schematizer causes classCastException when framework is updated

2017-03-13 Thread David Leangen (JIRA) 

 [ 
https://issues.apache.org/jira/browse/FELIX-5588?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

David Leangen resolved FELIX-5588.
--
Resolution: Fixed

Using ServiceFactory solves the problem.

> Schematizer causes classCastException when framework is updated
> ---
>
> Key: FELIX-5588
> URL: https://issues.apache.org/jira/browse/FELIX-5588
> Project: Felix
>  Issue Type: Bug
>  Components: Converter
>Reporter: David Leangen
>Assignee: David Leangen
>
> As discussed 
> [here|https://groups.google.com/forum/#!topic/bndtools-users/m1n739Hhi-A].



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Created] (FELIX-5588) Schematizer causes classCastException when framework is updated

2017-03-13 Thread David Leangen (JIRA) 
David Leangen created FELIX-5588:


 Summary: Schematizer causes classCastException when framework is 
updated
 Key: FELIX-5588
 URL: https://issues.apache.org/jira/browse/FELIX-5588
 Project: Felix
  Issue Type: Bug
  Components: Converter
Reporter: David Leangen
Assignee: David Leangen


As discussed 
[here|https://groups.google.com/forum/#!topic/bndtools-users/m1n739Hhi-A].



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Commented] (FELIX-5583) org.apache.felix.utils.json should be private

2017-03-13 Thread David Leangen (JIRA) 

[ 
https://issues.apache.org/jira/browse/FELIX-5583?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15906928#comment-15906928
 ] 

David Leangen commented on FELIX-5583:
--

Made package private.

Will keep issue around a little to see if there are any objections. If not, 
will close in about a week or so. :-)

> org.apache.felix.utils.json should be private
> -
>
> Key: FELIX-5583
> URL: https://issues.apache.org/jira/browse/FELIX-5583
> Project: Felix
>  Issue Type: Bug
>  Components: Converter
>Reporter: David Leangen
>Assignee: David Leangen
>
> I believe that, as a "library", this package ought to be marked as private.
> If there are no objections, I will make the update.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Commented] (FELIX-5587) Broken test

2017-03-13 Thread David Leangen (JIRA) 

[ 
https://issues.apache.org/jira/browse/FELIX-5587?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15906925#comment-15906925
 ] 

David Leangen commented on FELIX-5587:
--

Commited @Ignore in rev r1786630

> Broken test
> ---
>
> Key: FELIX-5587
> URL: https://issues.apache.org/jira/browse/FELIX-5587
> Project: Felix
>  Issue Type: Bug
>  Components: Converter
>Reporter: David Leangen
>
> [A 
> test|https://github.com/apache/felix/blob/trunk/converter/converter/src/test/java/org/apache/felix/converter/impl/ConverterMapTest.java#L120-L133]
>  is broken due to recent changes.
> @Ignoring this test so I can make a commit against a different issue. :-)



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Created] (FELIX-5587) Broken test

2017-03-13 Thread David Leangen (JIRA) 
David Leangen created FELIX-5587:


 Summary: Broken test
 Key: FELIX-5587
 URL: https://issues.apache.org/jira/browse/FELIX-5587
 Project: Felix
  Issue Type: Bug
  Components: Converter
Reporter: David Leangen


[A 
test|https://github.com/apache/felix/blob/trunk/converter/converter/src/test/java/org/apache/felix/converter/impl/ConverterMapTest.java#L120-L133]
 is broken due to recent changes.

@Ignoring this test so I can make a commit against a different issue. :-)




--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Resolved] (FELIX-5479) Serializer should be more lenient with trailing commas

2017-03-13 Thread David Leangen (JIRA) 

 [ 
https://issues.apache.org/jira/browse/FELIX-5479?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

David Leangen resolved FELIX-5479.
--
Resolution: Invalid
  Assignee: David Leangen

The request is invalid, as the JSON spec does not permit trailing spaces.

> Serializer should be more lenient with trailing commas
> --
>
> Key: FELIX-5479
> URL: https://issues.apache.org/jira/browse/FELIX-5479
> Project: Felix
>  Issue Type: Improvement
>  Components: Converter
>Reporter: David Leangen
>Assignee: David Leangen
>
> I believe that well-formed JSON does not permit a trailing comma, but 
> currently error reporting is not very good, so it is extremely tedious to 
> find parsing problems. Until we have better error reporting, the parser 
> should be more lenient. Allowing for trailing commas is one area where 
> leniency would be very beneficial to productivity.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)