[jira] [Commented] (FELIX-5641) Add getRepository() to Resource
[
https://issues.apache.org/jira/browse/FELIX-5641?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16032496#comment-16032496
]
Jens Offenbach commented on FELIX-5641:
---
Thank you very much for your quick response.
The pull request has been updated and now contains the proposed version of the
API-package export statement.
Isn't it also advisable to increase the major version fo the OBR implementation
to {{2.1.0-SNAPSHOT}}?
> Add getRepository() to Resource
> ---
>
> Key: FELIX-5641
> URL: https://issues.apache.org/jira/browse/FELIX-5641
> Project: Felix
> Issue Type: Bug
> Components: Bundle Repository (OBR)
>Reporter: Jens Offenbach
>
> The method {{RepositoryAdmin#discoverResources}} returns a list of filtered
> resources, but it is currently not efficiently possible to get the
> corresponding repository for a resource. The information is available in
> {{ResourceImpl}}, but not accessible through the API.
> Is it possible to add this?
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
[GitHub] felix pull request #109: FELIX-5644 Fix regression caused by solving FELIX-5...
Github user asfgit closed the pull request at: https://github.com/apache/felix/pull/109 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[jira] [Commented] (FELIX-5641) Add getRepository() to Resource
[
https://issues.apache.org/jira/browse/FELIX-5641?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16031518#comment-16031518
]
David Bosschaert commented on FELIX-5641:
-
The pull request contains a change to exported API. I think we can assume that
the Resource is a provider type here - I don't think users ever need to
implement this resource.
Therefore the pull request should be updated to include an update of the
Export-Package definition to:
{code}org.apache.felix.bundlerepository;version="2.2"
{code}
Does anyone see an issue with this?
Note that the https://osgi.org/javadoc/r6/core/org/osgi/resource/Resource.html
(which is a different resource) is a consumer type - any API changes to a
consumer type require a major version update.
> Add getRepository() to Resource
> ---
>
> Key: FELIX-5641
> URL: https://issues.apache.org/jira/browse/FELIX-5641
> Project: Felix
> Issue Type: Bug
> Components: Bundle Repository (OBR)
>Reporter: Jens Offenbach
>
> The method {{RepositoryAdmin#discoverResources}} returns a list of filtered
> resources, but it is currently not efficiently possible to get the
> corresponding repository for a resource. The information is available in
> {{ResourceImpl}}, but not accessible through the API.
> Is it possible to add this?
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
[jira] [Commented] (FELIX-5644) Repository#getURI() is no longer unique in case of XML-based repositories
[
https://issues.apache.org/jira/browse/FELIX-5644?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16031492#comment-16031492
]
ASF GitHub Bot commented on FELIX-5644:
---
Github user asfgit closed the pull request at:
https://github.com/apache/felix/pull/109
> Repository#getURI() is no longer unique in case of XML-based repositories
> -
>
> Key: FELIX-5644
> URL: https://issues.apache.org/jira/browse/FELIX-5644
> Project: Felix
> Issue Type: Bug
> Components: Bundle Repository (OBR)
>Reporter: Jens Offenbach
>Assignee: David Bosschaert
> Fix For: bundlerepository-2.0.12
>
>
> Because of a regression introduced by fixing FELIX-5611, the URI returned by
> {{Repository#getURI()}} is no longer unique in case of xml-based repository
> URIs. You cannot delete a repository using
> {{RepositoryAdmin#removeRepository(Repository#getURI()))}} when you use xml
> documents.
> {code}
> Repository firstRepository =
> repositoryAdmin.addRepository("file:///C:/Users/myuser/repo_for_optional_resources.xml");
> System.out.println(firstRepository.getURI());
> Repository secondRepository =
> repositoryAdmin.addRepository("file:///C:/Users/myuser/repo_for_mandatory.xml")
> System.out.println(secondRepository.getURI());
> {code}
> Result:
> {code}
> file:/C:/Users/myuser/
> file:/C:/Users/myuser/
> {code}
> The repositories are registered in the repository map with the original URIs,
> so that there is now way to remove a repository without knowing the initial
> URI under which it was registered.
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
[jira] [Resolved] (FELIX-5644) Repository#getURI() is no longer unique in case of XML-based repositories
[
https://issues.apache.org/jira/browse/FELIX-5644?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
David Bosschaert resolved FELIX-5644.
-
Resolution: Fixed
Fix Version/s: bundlerepository-2.0.12
The associated pull request https://github.com/apache/felix/pull/109 was
applied in https://svn.apache.org/viewvc?view=revision=1797072 with
many thanks!
> Repository#getURI() is no longer unique in case of XML-based repositories
> -
>
> Key: FELIX-5644
> URL: https://issues.apache.org/jira/browse/FELIX-5644
> Project: Felix
> Issue Type: Bug
> Components: Bundle Repository (OBR)
>Reporter: Jens Offenbach
>Assignee: David Bosschaert
> Fix For: bundlerepository-2.0.12
>
>
> Because of a regression introduced by fixing FELIX-5611, the URI returned by
> {{Repository#getURI()}} is no longer unique in case of xml-based repository
> URIs. You cannot delete a repository using
> {{RepositoryAdmin#removeRepository(Repository#getURI()))}} when you use xml
> documents.
> {code}
> Repository firstRepository =
> repositoryAdmin.addRepository("file:///C:/Users/myuser/repo_for_optional_resources.xml");
> System.out.println(firstRepository.getURI());
> Repository secondRepository =
> repositoryAdmin.addRepository("file:///C:/Users/myuser/repo_for_mandatory.xml")
> System.out.println(secondRepository.getURI());
> {code}
> Result:
> {code}
> file:/C:/Users/myuser/
> file:/C:/Users/myuser/
> {code}
> The repositories are registered in the repository map with the original URIs,
> so that there is now way to remove a repository without knowing the initial
> URI under which it was registered.
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
Contributing to Felix
Hello. Any chance anyone could look at PR #103? https://github.com/apache/felix/pull/103 Do I need to sign some sort of contributor agreement? M pgpPS15zhU5v8.pgp Description: OpenPGP digital signature
[jira] [Assigned] (FELIX-5644) Repository#getURI() is no longer unique in case of XML-based repositories
[
https://issues.apache.org/jira/browse/FELIX-5644?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
David Bosschaert reassigned FELIX-5644:
---
Assignee: David Bosschaert
> Repository#getURI() is no longer unique in case of XML-based repositories
> -
>
> Key: FELIX-5644
> URL: https://issues.apache.org/jira/browse/FELIX-5644
> Project: Felix
> Issue Type: Bug
> Components: Bundle Repository (OBR)
>Reporter: Jens Offenbach
>Assignee: David Bosschaert
>
> Because of a regression introduced by fixing FELIX-5611, the URI returned by
> {{Repository#getURI()}} is no longer unique in case of xml-based repository
> URIs. You cannot delete a repository using
> {{RepositoryAdmin#removeRepository(Repository#getURI()))}} when you use xml
> documents.
> {code}
> Repository firstRepository =
> repositoryAdmin.addRepository("file:///C:/Users/myuser/repo_for_optional_resources.xml");
> System.out.println(firstRepository.getURI());
> Repository secondRepository =
> repositoryAdmin.addRepository("file:///C:/Users/myuser/repo_for_mandatory.xml")
> System.out.println(secondRepository.getURI());
> {code}
> Result:
> {code}
> file:/C:/Users/myuser/
> file:/C:/Users/myuser/
> {code}
> The repositories are registered in the repository map with the original URIs,
> so that there is now way to remove a repository without knowing the initial
> URI under which it was registered.
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
