Re: FELIX-5699: baseline check behaves weirdly for jackrabbit-webdav under Java 9

2017-10-03 Thread Konrad Windszus 
Some more thoughts:
Even if the original org.apache.jackrabbit.webdav.lock.Scope did not have a 
hashCode() it implicitly inherited the one from Object. Therefore overwriting 
the hashCode() with a better implementation should not change anything about 
compatibility and therefore not require any version change.
I am pretty convinced that bnd should in fact just ignore the 
@HotSpotIntrinsicCandidate annotation.

> On 3. Oct 2017, at 16:41, Konrad Windszus  wrote:
> 
> If I understand the output of https://issues.apache.org/jira/browse/JCR-4191 
> correctly it means, it detected that hashCode() has modified after version 
> 1.0.0 (not added).
> In this case the addition of the annotations has been the modification (which 
> is actually an annotation being added by javac and only with Java9, 
> https://bugs.openjdk.java.net/browse/JDK-8076112).
> 
> I guess this is worth a bug report at bnd, because those annotations should 
> IMHO clearly be ignored by the baselining since it depends on the compile 
> time options, whether the annotation is there or not.
> 
> I am still wondering why this cannot be reproduced with bnd alone...
> Are you sure that both the maven-bundle-plugin and bnd are looking at exactly 
> the same classes (being produced by the same compiler run?)
> Also to me it is not clear whether only the Java compiler can add that 
> annotation or whether it could also be added at runtime by the JIT...
> 
> Konrad
> 
>> On 3. Oct 2017, at 15:53, Julian Reschke  wrote:
>> 
>> Hi there,
>> 
>> I'm looking for help in understanding the above issue.
>> 
>> Short summary: the baseline check asks for a version increase for a class 
>> where "hashCode()" was added, but only when run with jdk9.
>> 
>> So should I trust the diagnostics, or is this jdk9-related issue?
>> 
>> Best regards, Julian
>

Re: FELIX-5699: baseline check behaves weirdly for jackrabbit-webdav under Java 9

2017-10-03 Thread Konrad Windszus 
If I understand the output of https://issues.apache.org/jira/browse/JCR-4191 
correctly it means, it detected that hashCode() has modified after version 
1.0.0 (not added).
In this case the addition of the annotations has been the modification (which 
is actually an annotation being added by javac and only with Java9, 
https://bugs.openjdk.java.net/browse/JDK-8076112).

I guess this is worth a bug report at bnd, because those annotations should 
IMHO clearly be ignored by the baselining since it depends on the compile time 
options, whether the annotation is there or not.

I am still wondering why this cannot be reproduced with bnd alone...
Are you sure that both the maven-bundle-plugin and bnd are looking at exactly 
the same classes (being produced by the same compiler run?)
Also to me it is not clear whether only the Java compiler can add that 
annotation or whether it could also be added at runtime by the JIT...

Konrad

> On 3. Oct 2017, at 15:53, Julian Reschke  wrote:
> 
> Hi there,
> 
> I'm looking for help in understanding the above issue.
> 
> Short summary: the baseline check asks for a version increase for a class 
> where "hashCode()" was added, but only when run with jdk9.
> 
> So should I trust the diagnostics, or is this jdk9-related issue?
> 
> Best regards, Julian

[GitHub] felix pull request #123: Initial contribution of BAR Installer

2017-10-03 Thread njbartlett 
GitHub user njbartlett opened a pull request:

https://github.com/apache/felix/pull/123

Initial contribution of BAR Installer

This contribution is offered to Apache Felix on behalf of Intel Corporation 
who funded its development.

This is a plugin for File Install that implements an ArtifactInstaller for 
Bunder ARchive (BAR) files. A BAR is a format representing units of 
functionality implemented as a collection of OSGi bundles. It includes use of 
the OSGi resolver API to check consistency and permits overlapping resources 
from multiple installable units.

For full documentation and motivation see the [installer 
README](fileinstall-plugins/installer/README.md).

Note that we are still working on some testing issues but I wanted to raise 
this PR early while these issues are being resolved, in order to open 
discussion with Felix committers about the contribution and to address any 
large-scale changes that may be required before acceptance. Thank you!

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/njbartlett/felix nbartlett/fileinstall-plugins

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/felix/pull/123.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #123


commit b26396061d67811b33e080fae667424b36d634c3
Author: Neil Bartlett 
Date:   2017-10-03T12:45:22Z

[fileinstall-plugins] Initial contribution of BAR Installer

Signed-off-by: Neil Bartlett 




---

FELIX-5699: baseline check behaves weirdly for jackrabbit-webdav under Java 9

2017-10-03 Thread Julian Reschke 

Hi there,

I'm looking for help in understanding the above issue.

Short summary: the baseline check asks for a version increase for a 
class where "hashCode()" was added, but only when run with jdk9.


So should I trust the diagnostics, or is this jdk9-related issue?

Best regards, Julian

[GitHub] felix pull request #122: [FELIX-5698] Upgrade biz.aQute.bndlib to 3.5.0 for ...

2017-10-03 Thread johnpoth 
GitHub user johnpoth opened a pull request:

https://github.com/apache/felix/pull/122

[FELIX-5698] Upgrade biz.aQute.bndlib to 3.5.0 for Java 9 GA support

https://issues.apache.org/jira/browse/FELIX-5698

Thanks!

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/johnpoth/felix FELIX-5698

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/felix/pull/122.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #122


commit 17dd7598750e33cd93854aa1bf5b1d647dc86c5a
Author: jpoth 
Date:   2017-10-03T10:21:18Z

[FELIX-5698] Upgrade biz.aQute.bndlib to 3.5.0 for Java 9 GA support




---

[jira] [Commented] (FELIX-5698) Bundle plugin cannot cope with Java 9 module-info.java

2017-10-03 Thread Mark Raynsford (JIRA) 

[ 
https://issues.apache.org/jira/browse/FELIX-5698?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16189532#comment-16189532
 ] 

Mark Raynsford commented on FELIX-5698:
---

Thanks very much for this!

I'll override the bndlib dependency until the next release.

> Bundle plugin cannot cope with Java 9 module-info.java
> --
>
> Key: FELIX-5698
> URL: https://issues.apache.org/jira/browse/FELIX-5698
> Project: Felix
>  Issue Type: Bug
>  Components: Maven Bundle Plugin
>Affects Versions: maven-bundle-plugin-3.3.0
> Environment: java version "9"
> Java(TM) SE Runtime Environment (build 9+181)
> Java HotSpot(TM) 64-Bit Server VM (build 9+181, mixed mode)
>Reporter: Mark Raynsford
>
> Please see the trivial repro case at:
> [maven-bundle-plugin-20170923|https://github.com/io7m/maven-bundle-plugin-20170923]
> The plugin fails with:
> {noformat}
> [ERROR] Bundle com.io7m.bugs:maven-bundle-plugin-20170923:bundle:0.1.0 : 
> Exception: java.lang.ArrayIndexOutOfBoundsException: 19
> [ERROR] Bundle com.io7m.bugs:maven-bundle-plugin-20170923:bundle:0.1.0 : 
> Invalid class file module-info.class 
> (java.lang.ArrayIndexOutOfBoundsException: 19)
> {noformat}
> There doesn't appear to be a way to exclude the module-info.java files from 
> BND's class file analysis. An easy fix for this bug would be to simple ignore 
> module-info.java files as they're irrelevant for OSGi (but will be present in 
> projects that aim to support both OSGi and Jigsaw).



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (FELIX-5698) Bundle plugin cannot cope with Java 9 module-info.java

2017-10-03 Thread John Poth (JIRA) 

[ 
https://issues.apache.org/jira/browse/FELIX-5698?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16189526#comment-16189526
 ] 

John Poth commented on FELIX-5698:
--

As per the PR, upgrading biz.aQute.bndlib to 3.5.0 seems to resolve the issue. 
While waiting for a fix to be release one can force the upgrade in the pom.xml 

{code}

org.apache.felix
maven-bundle-plugin
${maven-bundle-plugin-version}
// configuration  & execution

  
biz.aQute.bnd
biz.aQute.bndlib
3.5.0
  

  
{code}

HTH,

John.

> Bundle plugin cannot cope with Java 9 module-info.java
> --
>
> Key: FELIX-5698
> URL: https://issues.apache.org/jira/browse/FELIX-5698
> Project: Felix
>  Issue Type: Bug
>  Components: Maven Bundle Plugin
>Affects Versions: maven-bundle-plugin-3.3.0
> Environment: java version "9"
> Java(TM) SE Runtime Environment (build 9+181)
> Java HotSpot(TM) 64-Bit Server VM (build 9+181, mixed mode)
>Reporter: Mark Raynsford
>
> Please see the trivial repro case at:
> [maven-bundle-plugin-20170923|https://github.com/io7m/maven-bundle-plugin-20170923]
> The plugin fails with:
> {noformat}
> [ERROR] Bundle com.io7m.bugs:maven-bundle-plugin-20170923:bundle:0.1.0 : 
> Exception: java.lang.ArrayIndexOutOfBoundsException: 19
> [ERROR] Bundle com.io7m.bugs:maven-bundle-plugin-20170923:bundle:0.1.0 : 
> Invalid class file module-info.class 
> (java.lang.ArrayIndexOutOfBoundsException: 19)
> {noformat}
> There doesn't appear to be a way to exclude the module-info.java files from 
> BND's class file analysis. An easy fix for this bug would be to simple ignore 
> module-info.java files as they're irrelevant for OSGi (but will be present in 
> projects that aim to support both OSGi and Jigsaw).



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (FELIX-5698) Bundle plugin cannot cope with Java 9 module-info.java

2017-10-03 Thread ASF GitHub Bot (JIRA) 

[ 
https://issues.apache.org/jira/browse/FELIX-5698?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16189518#comment-16189518
 ] 

ASF GitHub Bot commented on FELIX-5698:
---

GitHub user johnpoth opened a pull request:

https://github.com/apache/felix/pull/122

[FELIX-5698] Upgrade biz.aQute.bndlib to 3.5.0 for Java 9 GA support

https://issues.apache.org/jira/browse/FELIX-5698

Thanks!

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/johnpoth/felix FELIX-5698

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/felix/pull/122.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #122


commit 17dd7598750e33cd93854aa1bf5b1d647dc86c5a
Author: jpoth 
Date:   2017-10-03T10:21:18Z

[FELIX-5698] Upgrade biz.aQute.bndlib to 3.5.0 for Java 9 GA support




> Bundle plugin cannot cope with Java 9 module-info.java
> --
>
> Key: FELIX-5698
> URL: https://issues.apache.org/jira/browse/FELIX-5698
> Project: Felix
>  Issue Type: Bug
>  Components: Maven Bundle Plugin
>Affects Versions: maven-bundle-plugin-3.3.0
> Environment: java version "9"
> Java(TM) SE Runtime Environment (build 9+181)
> Java HotSpot(TM) 64-Bit Server VM (build 9+181, mixed mode)
>Reporter: Mark Raynsford
>
> Please see the trivial repro case at:
> [maven-bundle-plugin-20170923|https://github.com/io7m/maven-bundle-plugin-20170923]
> The plugin fails with:
> {noformat}
> [ERROR] Bundle com.io7m.bugs:maven-bundle-plugin-20170923:bundle:0.1.0 : 
> Exception: java.lang.ArrayIndexOutOfBoundsException: 19
> [ERROR] Bundle com.io7m.bugs:maven-bundle-plugin-20170923:bundle:0.1.0 : 
> Invalid class file module-info.class 
> (java.lang.ArrayIndexOutOfBoundsException: 19)
> {noformat}
> There doesn't appear to be a way to exclude the module-info.java files from 
> BND's class file analysis. An easy fix for this bug would be to simple ignore 
> module-info.java files as they're irrelevant for OSGi (but will be present in 
> projects that aim to support both OSGi and Jigsaw).



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Resolved] (FELIX-5705) Provide completion for SCR commands

2017-10-03 Thread Guillaume Nodet (JIRA) 

 [ 
https://issues.apache.org/jira/browse/FELIX-5705?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Guillaume Nodet resolved FELIX-5705.

Resolution: Fixed

Committing to https://svn.apache.org/repos/asf/felix/trunk ...
M   gogo/jline/src/main/resources/gosh_profile
Committed r1810826


> Provide completion for SCR commands
> ---
>
> Key: FELIX-5705
> URL: https://issues.apache.org/jira/browse/FELIX-5705
> Project: Felix
>  Issue Type: Improvement
>  Components: Gogo JLine
>Reporter: Guillaume Nodet
>Assignee: Guillaume Nodet
>Priority: Minor
> Fix For: gogo.jline-1.0.10
>
>




--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Resolved] (FELIX-5706) Unable to access DTO fields using reflection

2017-10-03 Thread Guillaume Nodet (JIRA) 

 [ 
https://issues.apache.org/jira/browse/FELIX-5706?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Guillaume Nodet resolved FELIX-5706.

Resolution: Fixed

Committing to https://svn.apache.org/repos/asf/felix/trunk ...
M   
gogo/runtime/src/main/java/org/apache/felix/gogo/runtime/Reflective.java
M   
gogo/runtime/src/test/java/org/apache/felix/gogo/runtime/ReflectiveTest.java
Committed r1810825


> Unable to access DTO fields using reflection
> 
>
> Key: FELIX-5706
> URL: https://issues.apache.org/jira/browse/FELIX-5706
> Project: Felix
>  Issue Type: Bug
>  Components: Gogo Runtime
>Reporter: Guillaume Nodet
>Assignee: Guillaume Nodet
> Fix For: gogo.runtime-1.0.10
>
>




--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Created] (FELIX-5706) Unable to access DTO fields using reflection

2017-10-03 Thread Guillaume Nodet (JIRA) 
Guillaume Nodet created FELIX-5706:
--

 Summary: Unable to access DTO fields using reflection
 Key: FELIX-5706
 URL: https://issues.apache.org/jira/browse/FELIX-5706
 Project: Felix
  Issue Type: Bug
  Components: Gogo Runtime
Reporter: Guillaume Nodet
Assignee: Guillaume Nodet
 Fix For: gogo.runtime-1.0.10






--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Created] (FELIX-5705) Provide completion for SCR commands

2017-10-03 Thread Guillaume Nodet (JIRA) 
Guillaume Nodet created FELIX-5705:
--

 Summary: Provide completion for SCR commands
 Key: FELIX-5705
 URL: https://issues.apache.org/jira/browse/FELIX-5705
 Project: Felix
  Issue Type: Improvement
  Components: Gogo JLine
Reporter: Guillaume Nodet
Assignee: Guillaume Nodet
Priority: Minor
 Fix For: gogo.jline-1.0.10






--
This message was sent by Atlassian JIRA
(v6.4.14#64029)