[GitHub] felix pull request #128: Update PrimitiveComponentType.java

[yangqiju]

GitHub user yangqiju opened a pull request:

https://github.com/apache/felix/pull/128

Update PrimitiveComponentType.java

fix bug.
Read bundle class file, read incomplete.

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/yangqiju/felix patch-1

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/felix/pull/128.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #128


commit 4166789ca5930ed8fdb415d8d4f2f5f1b8534002
Author: yang qiju <362991...@qq.com>
Date:   2017-12-14T08:48:21Z

Update PrimitiveComponentType.java

fix bug.
Read bundle class file, read incomplete.




---

[jira] [Resolved] (FELIX-5760) Update to bnd version 3.4

[Karl Pauls (JIRA)]

 [ 
https://issues.apache.org/jira/browse/FELIX-5760?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Karl Pauls resolved FELIX-5760.
---
Resolution: Fixed

Looks good now. I'm resolving this issue. Thanks a lot!

> Update to bnd version 3.4
> -
>
> Key: FELIX-5760
> URL: https://issues.apache.org/jira/browse/FELIX-5760
> Project: Felix
>  Issue Type: Improvement
>  Components: Maven Bundle Plugin
>Affects Versions: maven-bundle-plugin-3.3.0
>Reporter: Karl Pauls
>Assignee: Neil Bartlett
> Fix For: maven-bundle-plugin-3.4.0
>
>
> We should update to the latest bnd to support module-info.class files inside 
> a bundle and we should consider adding a _fixupmessage clause into the 
> instructions by default that turns errors about classes inside META-INF into 
> warnings (to at least allow processing multi-release jars without errors).  



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Resolved] (FELIX-5527) Bundle plugin Embed-Dependency complains about class files in META-INF

[Karl Pauls (JIRA)]

 [ 
https://issues.apache.org/jira/browse/FELIX-5527?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Karl Pauls resolved FELIX-5527.
---
Resolution: Fixed

I tested the project in question with the upcomming maven-bundle-plugin 
3.4.0-SNAPSHOT and it works - hence, I'm resolving this issue.

> Bundle plugin Embed-Dependency complains about class files in META-INF
> --
>
> Key: FELIX-5527
> URL: https://issues.apache.org/jira/browse/FELIX-5527
> Project: Felix
>  Issue Type: Bug
>  Components: Maven Bundle Plugin
>Affects Versions: maven-bundle-plugin-3.2.0
> Environment: Linux copperhead 4.8.13-1-ARCH #1 SMP PREEMPT Fri Dec 9 
> 07:24:34 CET 2016 x86_64 GNU/Linux
> openjdk version "1.8.0_121"
> OpenJDK Runtime Environment (build 1.8.0_121-b13)
> OpenJDK 64-Bit Server VM (build 25.121-b13, mixed mode)
> Apache Maven 3.3.9 (NON-CANONICAL_2015-11-23T13:17:27+03:00_root; 
> 2015-11-23T10:17:27+00:00)
> Maven home: /opt/maven
> Java version: 1.8.0_121, vendor: Oracle Corporation
> Java home: /usr/lib/jvm/java-8-openjdk/jre
> Default locale: en_GB, platform encoding: UTF-8
> OS name: "linux", version: "4.8.13-1-arch", arch: "amd64", family: "unix"
>Reporter: Mark Raynsford
>Assignee: Neil Bartlett
>  Labels: maven
> Fix For: maven-bundle-plugin-3.4.0
>
>
> As of Java 9, it's no longer a mistake to have included class files in the 
> META-INF directory of a bundle. However, if the Embed-Dependency instruction 
> is used to pack the contents of a jar file into a bundle, and the original 
> jar file happened to have class files in META-INF, the execution fails with 
> an error.
> A repro case is included in the following repository:
> https://github.com/io7m/maven-bundle-plugin-bug-20170207
> Just "mvn clean package".



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Resolved] (FELIX-5592) Maven bundle plugin does not support Java 9 Multi-Release jars

[Karl Pauls (JIRA)]

 [ 
https://issues.apache.org/jira/browse/FELIX-5592?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Karl Pauls resolved FELIX-5592.
---
Resolution: Fixed

This should be fixed with the upcomming maven-bundle-plugin 3.4.0 release - 
where by "fixed" I mean it should at least allow to build with multi-release 
jars. Ultimately, we will need some spec level support to fully support 
multi-release jars (see the bnd issues mentioned) but that might be in the 
works.

I'm resolving this issue as fixed for now as the problem should have gone away. 
When we know how spec level support might look like we need to open a new issue 
to implement the changes. 

> Maven bundle plugin does not support Java 9 Multi-Release jars
> --
>
> Key: FELIX-5592
> URL: https://issues.apache.org/jira/browse/FELIX-5592
> Project: Felix
>  Issue Type: Bug
>  Components: Maven Bundle Plugin
>Affects Versions: maven-bundle-plugin-3.2.0
>Reporter: Ralph Goers
>Assignee: Neil Bartlett
> Fix For: maven-bundle-plugin-3.4.0
>
>
> Log4j 2 currently packages its jars with the maven-bundle-plugin. To support 
> Java 9 we are moving towards using Multi-Release jars to pick up the Java 9 
> features.  However, when the Maven bundle plugin encouters classes in 
> META-INF/versions/9 it emits an error message saying "Classes found in the 
> wrong directory:", which is incorrect for a Multi-Release jar in Java 9.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Created] (FELIX-5764) Update to bnd version 3.5

[Neil Bartlett (JIRA)]

Neil Bartlett created FELIX-5764:


 Summary: Update to bnd version 3.5
 Key: FELIX-5764
 URL: https://issues.apache.org/jira/browse/FELIX-5764
 Project: Felix
  Issue Type: Improvement
  Components: Maven Bundle Plugin
Affects Versions: maven-bundle-plugin-3.4.0
Reporter: Neil Bartlett


We just updated the plugin to bnd 3.4 but it is still behind the latest release 
of bnd which is 3.5.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[VOTE] Release Apache Felix Maven Bundle Plugin 3.4.0

[Karl Pauls]

I would like to call a vote on the following subproject release:

Apache Felix Maven Bundle Plugin 3.4.0

We solved 5 issues in this release
https://issues.apache.org/jira/projects/FELIX/versions/12339958

Staging repository:
https://repository.apache.org/content/repositories/orgapachefelix-1211/

You can use this UNIX script to download the release and verify the
signatures:
http://svn.apache.org/repos/asf/felix/trunk/check_staged_release.sh

Usage:
sh check_staged_release.sh 1211 /tmp/felix-staging

Please vote to approve this release:

[ ] +1 Approve the release
[ ] -1 Veto the release (please provide specific comments)

[jira] [Updated] (FELIX-5764) Update to bnd version 3.5

[Karl Pauls (JIRA)]

 [ 
https://issues.apache.org/jira/browse/FELIX-5764?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Karl Pauls updated FELIX-5764:
--
Fix Version/s: maven-bundle-plugin-future
   maven-bundle-plugin-3.5.0

> Update to bnd version 3.5
> -
>
> Key: FELIX-5764
> URL: https://issues.apache.org/jira/browse/FELIX-5764
> Project: Felix
>  Issue Type: Improvement
>  Components: Maven Bundle Plugin
>Affects Versions: maven-bundle-plugin-3.4.0
>Reporter: Neil Bartlett
> Fix For: maven-bundle-plugin-future, maven-bundle-plugin-3.5.0
>
>
> We just updated the plugin to bnd 3.4 but it is still behind the latest 
> release of bnd which is 3.5.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Updated] (FELIX-5764) Update to bnd version 3.5

[Karl Pauls (JIRA)]

 [ 
https://issues.apache.org/jira/browse/FELIX-5764?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Karl Pauls updated FELIX-5764:
--
Fix Version/s: (was: maven-bundle-plugin-future)

> Update to bnd version 3.5
> -
>
> Key: FELIX-5764
> URL: https://issues.apache.org/jira/browse/FELIX-5764
> Project: Felix
>  Issue Type: Improvement
>  Components: Maven Bundle Plugin
>Affects Versions: maven-bundle-plugin-3.4.0
>Reporter: Neil Bartlett
> Fix For: maven-bundle-plugin-3.5.0
>
>
> We just updated the plugin to bnd 3.4 but it is still behind the latest 
> release of bnd which is 3.5.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (FELIX-5764) Update to bnd version 3.5

[Karl Pauls (JIRA)]

[ 
https://issues.apache.org/jira/browse/FELIX-5764?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16291143#comment-16291143
 ] 

Karl Pauls commented on FELIX-5764:
---

I'm not against releasing a maven-bundle-plugin-3.5.0 with bnd 3.5 reasonable 
quickly. [~nbartlett], feel free to assign this issue to you and do the update 
:-)

> Update to bnd version 3.5
> -
>
> Key: FELIX-5764
> URL: https://issues.apache.org/jira/browse/FELIX-5764
> Project: Felix
>  Issue Type: Improvement
>  Components: Maven Bundle Plugin
>Affects Versions: maven-bundle-plugin-3.4.0
>Reporter: Neil Bartlett
> Fix For: maven-bundle-plugin-3.5.0
>
>
> We just updated the plugin to bnd 3.4 but it is still behind the latest 
> release of bnd which is 3.5.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

Re: [VOTE] Release Apache Felix Maven Bundle Plugin 3.4.0

[David Bosschaert]

+1

David

On 14 December 2017 at 16:30, Karl Pauls  wrote:

> I would like to call a vote on the following subproject release:
>
> Apache Felix Maven Bundle Plugin 3.4.0
>
> We solved 5 issues in this release
> https://issues.apache.org/jira/projects/FELIX/versions/12339958
>
> Staging repository:
> https://repository.apache.org/content/repositories/orgapachefelix-1211/
>
> You can use this UNIX script to download the release and verify the
> signatures:
> http://svn.apache.org/repos/asf/felix/trunk/check_staged_release.sh
>
> Usage:
> sh check_staged_release.sh 1211 /tmp/felix-staging
>
> Please vote to approve this release:
>
> [ ] +1 Approve the release
> [ ] -1 Veto the release (please provide specific comments)
>

[jira] [Commented] (FELIX-5527) Bundle plugin Embed-Dependency complains about class files in META-INF

[Mark Raynsford (JIRA)]

[ 
https://issues.apache.org/jira/browse/FELIX-5527?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16291173#comment-16291173
 ] 

Mark Raynsford commented on FELIX-5527:
---

Sounds good to me. Thanks.

> Bundle plugin Embed-Dependency complains about class files in META-INF
> --
>
> Key: FELIX-5527
> URL: https://issues.apache.org/jira/browse/FELIX-5527
> Project: Felix
>  Issue Type: Bug
>  Components: Maven Bundle Plugin
>Affects Versions: maven-bundle-plugin-3.2.0
> Environment: Linux copperhead 4.8.13-1-ARCH #1 SMP PREEMPT Fri Dec 9 
> 07:24:34 CET 2016 x86_64 GNU/Linux
> openjdk version "1.8.0_121"
> OpenJDK Runtime Environment (build 1.8.0_121-b13)
> OpenJDK 64-Bit Server VM (build 25.121-b13, mixed mode)
> Apache Maven 3.3.9 (NON-CANONICAL_2015-11-23T13:17:27+03:00_root; 
> 2015-11-23T10:17:27+00:00)
> Maven home: /opt/maven
> Java version: 1.8.0_121, vendor: Oracle Corporation
> Java home: /usr/lib/jvm/java-8-openjdk/jre
> Default locale: en_GB, platform encoding: UTF-8
> OS name: "linux", version: "4.8.13-1-arch", arch: "amd64", family: "unix"
>Reporter: Mark Raynsford
>Assignee: Neil Bartlett
>  Labels: maven
> Fix For: maven-bundle-plugin-3.4.0
>
>
> As of Java 9, it's no longer a mistake to have included class files in the 
> META-INF directory of a bundle. However, if the Embed-Dependency instruction 
> is used to pack the contents of a jar file into a bundle, and the original 
> jar file happened to have class files in META-INF, the execution fails with 
> an error.
> A repro case is included in the following repository:
> https://github.com/io7m/maven-bundle-plugin-bug-20170207
> Just "mvn clean package".



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

Re: [VOTE] Release Apache Felix Maven Bundle Plugin 3.4.0

[Francois Papon]

+1 (non-binding)


Le 14/12/2017 à 20:30, Karl Pauls a écrit :
> I would like to call a vote on the following subproject release:
>
> Apache Felix Maven Bundle Plugin 3.4.0
>
> We solved 5 issues in this release
> https://issues.apache.org/jira/projects/FELIX/versions/12339958
>
> Staging repository:
> https://repository.apache.org/content/repositories/orgapachefelix-1211/
>
> You can use this UNIX script to download the release and verify the
> signatures:
> http://svn.apache.org/repos/asf/felix/trunk/check_staged_release.sh
>
> Usage:
> sh check_staged_release.sh 1211 /tmp/felix-staging
>
> Please vote to approve this release:
>
> [ ] +1 Approve the release
> [ ] -1 Veto the release (please provide specific comments)

Re: [VOTE] Release Apache Felix Maven Bundle Plugin 3.4.0

[Clement Escoffier]

+1,

Regards,

Clement

> On 14 Dec 2017, at 17:30, Karl Pauls  wrote:
> 
> I would like to call a vote on the following subproject release:
> 
> Apache Felix Maven Bundle Plugin 3.4.0
> 
> We solved 5 issues in this release
> https://issues.apache.org/jira/projects/FELIX/versions/12339958
> 
> Staging repository:
> https://repository.apache.org/content/repositories/orgapachefelix-1211/
> 
> You can use this UNIX script to download the release and verify the
> signatures:
> http://svn.apache.org/repos/asf/felix/trunk/check_staged_release.sh
> 
> Usage:
> sh check_staged_release.sh 1211 /tmp/felix-staging
> 
> Please vote to approve this release:
> 
> [ ] +1 Approve the release
> [ ] -1 Veto the release (please provide specific comments)

[jira] [Assigned] (FELIX-5758) metatype.properties file must not be in OSGI-INF/metatype directory

[Chetan Mehrotra (JIRA)]

 [ 
https://issues.apache.org/jira/browse/FELIX-5758?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Chetan Mehrotra reassigned FELIX-5758:
--

Assignee: Chetan Mehrotra

> metatype.properties file must not be in OSGI-INF/metatype directory
> ---
>
> Key: FELIX-5758
> URL: https://issues.apache.org/jira/browse/FELIX-5758
> Project: Felix
>  Issue Type: Bug
>  Components: JAAS
>Reporter: Daniele Pirola
>Assignee: Chetan Mehrotra
>
> According to the spec all files inside OSGI-INF/metatype directory must be 
> valid meta type documents. See bug FELIX-5701



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

RE: [VOTE] Release Apache Felix Maven Bundle Plugin 3.4.0

[Stefan Seifert]

+1 (non-binding)

Re: [VOTE] Release Apache Felix Maven Bundle Plugin 3.4.0

[Raymond Auge]

Is there any reason this shouldn't be released with bnd 3.5.0 which is the
latest release?

BND 3.5.0 solves several pretty critical issues over 3.4.0.

I would recommend skipping bnd 3.4.0

Sincerely,
- Ray

On Thu, Dec 14, 2017 at 1:23 PM, Stefan Seifert 
wrote:

> +1 (non-binding)
>
>


-- 
*Raymond Augé* 
 (@rotty3000)
Senior Software Architect *Liferay, Inc.* 
 (@Liferay)
Board Member & EEG Co-Chair, OSGi Alliance  (@OSGiAlliance)

Re: [VOTE] Release Apache Felix Maven Bundle Plugin 3.4.0

[Karl Pauls]

Well, we have an issue for updating to 3.5.0 and do a new release. The
idea to first do one with 3.4 was as far as I understood it, that
otherwise, there wouldn't be any with 3.4.

regards,

Karl

On Thu, Dec 14, 2017 at 8:49 PM, Raymond Auge  wrote:
> Is there any reason this shouldn't be released with bnd 3.5.0 which is the
> latest release?
>
> BND 3.5.0 solves several pretty critical issues over 3.4.0.
>
> I would recommend skipping bnd 3.4.0
>
> Sincerely,
> - Ray
>
> On Thu, Dec 14, 2017 at 1:23 PM, Stefan Seifert 
> wrote:
>
>> +1 (non-binding)
>>
>>
>
>
> --
> *Raymond Augé* 
>  (@rotty3000)
> Senior Software Architect *Liferay, Inc.* 
>  (@Liferay)
> Board Member & EEG Co-Chair, OSGi Alliance  (@OSGiAlliance)



-- 
Karl Pauls
karlpa...@gmail.com

Re: [VOTE] Release Apache Felix Maven Bundle Plugin 3.4.0

[Neil Bartlett (Paremus)]

I discussed this with Karl. The latest plugin release was 3.3, so in order to 
go straight to bnd 3.5 we would have to do one of the following:

* Release version 3.4 of the plugin pointing at version 3.5 of bnd; or
* Skip version 3.4 of the plugin entirely.

We felt that either option would be confusing for users. So we are releasing 
3.4 with bnd 3.4 and will then very shortly release 3.5.

Regards,
Neil

> On 14 Dec 2017, at 19:49, Raymond Auge  wrote:
> 
> Is there any reason this shouldn't be released with bnd 3.5.0 which is the
> latest release?
> 
> BND 3.5.0 solves several pretty critical issues over 3.4.0.
> 
> I would recommend skipping bnd 3.4.0
> 
> Sincerely,
> - Ray
> 
> On Thu, Dec 14, 2017 at 1:23 PM, Stefan Seifert 
> wrote:
> 
>> +1 (non-binding)
>> 
>> 
> 
> 
> -- 
> *Raymond Augé* 
> (@rotty3000)
> Senior Software Architect *Liferay, Inc.* 
> (@Liferay)
> Board Member & EEG Co-Chair, OSGi Alliance  (@OSGiAlliance)

Re: [VOTE] Release Apache Felix Maven Bundle Plugin 3.4.0

[Raymond Auge]

+1 (non-binding)

On Dec 14, 2017 3:00 PM, "Neil Bartlett (Paremus)" <
neil.bartl...@paremus.com> wrote:

> I discussed this with Karl. The latest plugin release was 3.3, so in order
> to go straight to bnd 3.5 we would have to do one of the following:
>
> * Release version 3.4 of the plugin pointing at version 3.5 of bnd; or
> * Skip version 3.4 of the plugin entirely.
>
> We felt that either option would be confusing for users. So we are
> releasing 3.4 with bnd 3.4 and will then very shortly release 3.5.
>
> Regards,
> Neil
>
> > On 14 Dec 2017, at 19:49, Raymond Auge  wrote:
> >
> > Is there any reason this shouldn't be released with bnd 3.5.0 which is
> the
> > latest release?
> >
> > BND 3.5.0 solves several pretty critical issues over 3.4.0.
> >
> > I would recommend skipping bnd 3.4.0
> >
> > Sincerely,
> > - Ray
> >
> > On Thu, Dec 14, 2017 at 1:23 PM, Stefan Seifert 
> > wrote:
> >
> >> +1 (non-binding)
> >>
> >>
> >
> >
> > --
> > *Raymond Augé* 
> > (@rotty3000)
> > Senior Software Architect *Liferay, Inc.* 
> > (@Liferay)
> > Board Member & EEG Co-Chair, OSGi Alliance 
> (@OSGiAlliance)
>
>

Re: [VOTE] Release Apache Felix Maven Bundle Plugin 3.4.0

[Pierre De Rop]

Hi,

+1

thanks;
Pierre

On Thu, Dec 14, 2017 at 11:57 PM, Raymond Auge 
wrote:

> +1 (non-binding)
>
> On Dec 14, 2017 3:00 PM, "Neil Bartlett (Paremus)" <
> neil.bartl...@paremus.com> wrote:
>
> > I discussed this with Karl. The latest plugin release was 3.3, so in
> order
> > to go straight to bnd 3.5 we would have to do one of the following:
> >
> > * Release version 3.4 of the plugin pointing at version 3.5 of bnd; or
> > * Skip version 3.4 of the plugin entirely.
> >
> > We felt that either option would be confusing for users. So we are
> > releasing 3.4 with bnd 3.4 and will then very shortly release 3.5.
> >
> > Regards,
> > Neil
> >
> > > On 14 Dec 2017, at 19:49, Raymond Auge 
> wrote:
> > >
> > > Is there any reason this shouldn't be released with bnd 3.5.0 which is
> > the
> > > latest release?
> > >
> > > BND 3.5.0 solves several pretty critical issues over 3.4.0.
> > >
> > > I would recommend skipping bnd 3.4.0
> > >
> > > Sincerely,
> > > - Ray
> > >
> > > On Thu, Dec 14, 2017 at 1:23 PM, Stefan Seifert <
> sseif...@pro-vision.de>
> > > wrote:
> > >
> > >> +1 (non-binding)
> > >>
> > >>
> > >
> > >
> > > --
> > > *Raymond Augé* 
> > > (@rotty3000)
> > > Senior Software Architect *Liferay, Inc.* 
> > > (@Liferay)
> > > Board Member & EEG Co-Chair, OSGi Alliance 
> > (@OSGiAlliance)
> >
> >
>