[jira] [Commented] (FELIX-5980) Maven Bundle Plugin Regression: incorrect filtering
[
https://issues.apache.org/jira/browse/FELIX-5980?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16684475#comment-16684475
]
Florian Brunner commented on FELIX-5980:
I attached a small sample project: [^bundle-plugin-filtering-issue.tar.gz]
> Maven Bundle Plugin Regression: incorrect filtering
> ---
>
> Key: FELIX-5980
> URL: https://issues.apache.org/jira/browse/FELIX-5980
> Project: Felix
> Issue Type: Bug
> Components: Maven Bundle Plugin
>Affects Versions: maven-bundle-plugin-4.1.0
>Reporter: Florian Brunner
>Priority: Critical
> Attachments: bundle-plugin-filtering-issue.tar.gz
>
>
> With Maven resource filtering enabled, the following Maven Bunde Plugin
> configuration
> {code:java}
>
> org.apache.felix
> maven-bundle-plugin
> true
>
>
>
> ${project.version}
>
>
>
>
> generate-sources
>
> cleanVersions
>
>
>
>
> {code}
> filters the following file:
> {code:java}
> org.osgi.framework.system.packages.extra=${module-a.packages}
> module-a.packages=${module-b.packages}, \
> issue.bundleplugin.filtering;version="${module-a.osgi.version.clean}", \
> ${foo-${foo.specification.version}}
> foo-1=org.foo
> {code}
> correctly to target/classes:
> {code:java}
> org.osgi.framework.system.packages.extra=${module-a.packages}
> module-a.packages=${module-b.packages}, \
> issue.bundleplugin.filtering;version="0.1.0.SNAPSHOT", \
> ${foo-${foo.specification.version}}
> foo-1=org.foo{code}
> but the bundle goal then adds the following properties file to the bundle JAR:
> {code:java}
> org.osgi.framework.system.packages.extra=${module-a.packages}
> module-a.packages=${module-b.packages}, \
> issue.bundleplugin.filtering;version="0.1.0.SNAPSHOT", \
> foo-1=org.foo
> {code}
> ${foo-${foo.specification.version}} got stripped to empty string!
> Affected version: 4.1.0
> It used to work with version 3.5.0 -> regression
> I see two issues:
> # ${foo-${foo.specification.version}} got stripped to empty string
> # The bunde goal should just be about packaging. It should not change files
> from target/classes at all.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Created] (FELIX-5980) Maven Bundle Plugin Regression: incorrect filtering
Florian Brunner created FELIX-5980:
--
Summary: Maven Bundle Plugin Regression: incorrect filtering
Key: FELIX-5980
URL: https://issues.apache.org/jira/browse/FELIX-5980
Project: Felix
Issue Type: Bug
Components: Maven Bundle Plugin
Affects Versions: maven-bundle-plugin-4.1.0
Reporter: Florian Brunner
Attachments: bundle-plugin-filtering-issue.tar.gz
With Maven resource filtering enabled, the following Maven Bunde Plugin
configuration
{code:java}
org.apache.felix
maven-bundle-plugin
true
${project.version}
generate-sources
cleanVersions
{code}
filters the following file:
{code:java}
org.osgi.framework.system.packages.extra=${module-a.packages}
module-a.packages=${module-b.packages}, \
issue.bundleplugin.filtering;version="${module-a.osgi.version.clean}", \
${foo-${foo.specification.version}}
foo-1=org.foo
{code}
correctly to target/classes:
{code:java}
org.osgi.framework.system.packages.extra=${module-a.packages}
module-a.packages=${module-b.packages}, \
issue.bundleplugin.filtering;version="0.1.0.SNAPSHOT", \
${foo-${foo.specification.version}}
foo-1=org.foo{code}
but the bundle goal then adds the following properties file to the bundle JAR:
{code:java}
org.osgi.framework.system.packages.extra=${module-a.packages}
module-a.packages=${module-b.packages}, \
issue.bundleplugin.filtering;version="0.1.0.SNAPSHOT", \
foo-1=org.foo
{code}
${foo-${foo.specification.version}} got stripped to empty string!
Affected version: 4.1.0
It used to work with version 3.5.0 -> regression
I see two issues:
# ${foo-${foo.specification.version}} got stripped to empty string
# The bunde goal should just be about packaging. It should not change files
from target/classes at all.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
Re: [VOTE] Release Apache Felix SCR 2.1.14, Take II
+1 David On Sat, 10 Nov 2018 at 10:18, Carsten Ziegeler wrote: > We solved two issues in this release: > > > http://svn.apache.org/repos/asf/felix/releases/org.apache.felix.scr-2.1.14/changelog.txt > > Staging repositories: > https://repository.apache.org/content/repositories/orgapachefelix-1270/ > > You can use this UNIX script to download the release and verify the > signatures: > http://svn.apache.org/repos/asf/felix/trunk/check_staged_release.sh > > Usage: > sh check_staged_release.sh 1270 /tmp/felix-staging > > Please vote to approve this release: > > [ ] +1 Approve the release > [ ] -1 Veto the release (please provide specific comments) > > Regards > Carsten > -- > Carsten Ziegeler > Adobe Research Switzerland > cziege...@apache.org >
Re: [VOTE] Release Apache Felix SCR 2.1.14, Take II
+1 (non binding) The signatures now check out, and the published sources build cleanly. Tim > On 11 Nov 2018, at 20:03, Christian Schneider wrote: > > +1 (non binding) > > Christian > > Am Sa., 10. Nov. 2018 um 11:18 Uhr schrieb Carsten Ziegeler < > cziege...@apache.org>: > >> We solved two issues in this release: >> >> >> http://svn.apache.org/repos/asf/felix/releases/org.apache.felix.scr-2.1.14/changelog.txt >> >> Staging repositories: >> https://repository.apache.org/content/repositories/orgapachefelix-1270/ >> >> You can use this UNIX script to download the release and verify the >> signatures: >> http://svn.apache.org/repos/asf/felix/trunk/check_staged_release.sh >> >> Usage: >> sh check_staged_release.sh 1270 /tmp/felix-staging >> >> Please vote to approve this release: >> >> [ ] +1 Approve the release >> [ ] -1 Veto the release (please provide specific comments) >> >> Regards >> Carsten >> -- >> Carsten Ziegeler >> Adobe Research Switzerland >> cziege...@apache.org >> > > > -- > -- > Christian Schneider > http://www.liquid-reality.de > > Computer Scientist > http://www.adobe.com
