[RESULT][VOTE] Release Apache Felix OSGi Feature Model RC1
Hi all, With +1s from Carsten, JB, Pierre, Karl, Thomas, Raymond, Francois and me this vote is successful. I've promoted the artifacts. Kind regards, David On Fri, 3 Sept 2021 at 11:58, wrote: > Hi all, > > I would like to call for an RC1 release of the Felix implementation of the > OSGi Feature Model API. > This is not yet a final release, but an RC1 which uses the > org.osgi:org.osgi.service.feature:1.0.0-RC1 API, as discussed here: > https://www.mail-archive.com/dev%40felix.apache.org/msg52289.html > > Staging repository: > https://repository.apache.org/content/repositories/orgapachefelix-1398 > > You can use this UNIX script to download the release and verify the > signatures: > https://github.com/apache/felix-dev/blob/master/check_staged_release.sh > > Usage: > sh check_staged_release.sh 1398 /tmp/felix-staging > > Please vote to approve this release: > > [ ] +1 Approve the release > [ ] -1 Veto the release (please provide specific comments) > > Best regards, > > David Bosschaert >
[jira] [Commented] (FELIX-6455) configadmin.plugin.interpolation: default Value with "]" is interpreted wrong
[
https://issues.apache.org/jira/browse/FELIX-6455?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17410528#comment-17410528
]
guiquan weng commented on FELIX-6455:
-
tested on localhost with 1.2.1-SNAPSHOT. The special characters e.g.
[,],^,$,\,(,) are escaped correctly.
> configadmin.plugin.interpolation: default Value with "]" is interpreted wrong
> -
>
> Key: FELIX-6455
> URL: https://issues.apache.org/jira/browse/FELIX-6455
> Project: Felix
> Issue Type: Bug
> Components: Configuration Admin
>Affects Versions: configadmin-interpolation-plugin-1.2.0
>Reporter: guiquan weng
>Assignee: Carsten Ziegeler
>Priority: Major
> Fix For: configadmin-interpolation-plugin-1.2.2
>
>
> configadmin.plugin.interpolation interpreted the default value with "]" wrong:
> * $[env:notset;default=[8080]] => [8080](/)
> * $[env:notset;default=[aabb]cc] => [aabbcc] (x)
> To show the bug I have created a branch with a unit test:
> [https://github.com/apache/felix-dev/compare/master...orangeven:bugfix/configadmin-plugins-interpolation-default-value-with-special-chars?expand=1]
> Line 162 failed with message:
> {noformat}
> org.junit.ComparisonFailure:
> Expected :[aabb]cc
> Actual :[aabbcc]{noformat}
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
adaptTo() 2021 - Only 3 weeks left: get your ticket!
Hello everyone, We're excited to see some of the best Adobe experts and AEM developers and the best attendees at adaptTo() 2021. We expect you from 27.-29. Sept. to Europe's leading AEM developer conference. Top-class speakers and the most exciting topics are guaranteed. If you don't have a ticket yet, you can order a ticket here: https://adapt.to/tickets adaptTo() 2021 | 27.-29. Sept. Europe's leading AEM Developer Conference We will shortly be updating our agenda with the panel discussions and meet-the-expert sessions. Follow us on https://adapt.to/linkedin or https://twitter.com/adaptto @adaptto to keep up to date. Kind regards from the adaptTo() Team, Stefan
[jira] [Comment Edited] (FELIX-6429) IllegalArgumentException that should not happen
[
https://issues.apache.org/jira/browse/FELIX-6429?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17410420#comment-17410420
]
Karl Pauls edited comment on FELIX-6429 at 9/6/21, 7:13 AM:
Yes, this seems to be a bug.
{{ServiceObjects.ungetService}} will throw an IllegalArgumentException when the
usage count would drop below 0 which is not what the java doc is saying from
several angles.
was (Author: karlpauls):
Yes, this seems to be a bug.
> IllegalArgumentException that should not happen
> ---
>
> Key: FELIX-6429
> URL: https://issues.apache.org/jira/browse/FELIX-6429
> Project: Felix
> Issue Type: Bug
> Components: Framework
>Affects Versions: framework-7.0.0
>Reporter: Jürgen Albert
>Assignee: Karl Pauls
>Priority: Major
> Fix For: framework-7.0.2
>
>
> We recently stumbled a couple of times over an IllegalArgumentException when
> calling ServiceObjects.ungetService. In our case we are always in an async
> process and the service we are calling unget for ist already unregistered.
> According to the org.osgi.framework.ServiceObjects Spec the Exception will be
> thrown under the following circumstances:
> {code:java}
> @throws IllegalArgumentException If the specified service object is
>{@code null} or was not provided by a {@code ServiceObjects}
>object for the associated service.
> {code}
> I can guarantee that both conditions are not meet in our case. It is simply
> that the service is already unregistered.
> If I read the javadoc correctly it should simply do nothing in such a case. I
> haven't checked with the Spec though.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Updated] (FELIX-6429) IllegalArgumentException that should not happen
[
https://issues.apache.org/jira/browse/FELIX-6429?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Karl Pauls updated FELIX-6429:
--
Fix Version/s: framework-7.0.2
> IllegalArgumentException that should not happen
> ---
>
> Key: FELIX-6429
> URL: https://issues.apache.org/jira/browse/FELIX-6429
> Project: Felix
> Issue Type: Bug
> Components: Framework
>Affects Versions: framework-7.0.0
>Reporter: Jürgen Albert
>Assignee: Karl Pauls
>Priority: Major
> Fix For: framework-7.0.2
>
>
> We recently stumbled a couple of times over an IllegalArgumentException when
> calling ServiceObjects.ungetService. In our case we are always in an async
> process and the service we are calling unget for ist already unregistered.
> According to the org.osgi.framework.ServiceObjects Spec the Exception will be
> thrown under the following circumstances:
> {code:java}
> @throws IllegalArgumentException If the specified service object is
>{@code null} or was not provided by a {@code ServiceObjects}
>object for the associated service.
> {code}
> I can guarantee that both conditions are not meet in our case. It is simply
> that the service is already unregistered.
> If I read the javadoc correctly it should simply do nothing in such a case. I
> haven't checked with the Spec though.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Commented] (FELIX-6429) IllegalArgumentException that should not happen
[
https://issues.apache.org/jira/browse/FELIX-6429?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17410420#comment-17410420
]
Karl Pauls commented on FELIX-6429:
---
Yes, this seems to be a bug.
> IllegalArgumentException that should not happen
> ---
>
> Key: FELIX-6429
> URL: https://issues.apache.org/jira/browse/FELIX-6429
> Project: Felix
> Issue Type: Bug
> Components: Framework
>Affects Versions: framework-7.0.0
>Reporter: Jürgen Albert
>Priority: Major
>
> We recently stumbled a couple of times over an IllegalArgumentException when
> calling ServiceObjects.ungetService. In our case we are always in an async
> process and the service we are calling unget for ist already unregistered.
> According to the org.osgi.framework.ServiceObjects Spec the Exception will be
> thrown under the following circumstances:
> {code:java}
> @throws IllegalArgumentException If the specified service object is
>{@code null} or was not provided by a {@code ServiceObjects}
>object for the associated service.
> {code}
> I can guarantee that both conditions are not meet in our case. It is simply
> that the service is already unregistered.
> If I read the javadoc correctly it should simply do nothing in such a case. I
> haven't checked with the Spec though.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Assigned] (FELIX-6429) IllegalArgumentException that should not happen
[
https://issues.apache.org/jira/browse/FELIX-6429?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Karl Pauls reassigned FELIX-6429:
-
Assignee: Karl Pauls
> IllegalArgumentException that should not happen
> ---
>
> Key: FELIX-6429
> URL: https://issues.apache.org/jira/browse/FELIX-6429
> Project: Felix
> Issue Type: Bug
> Components: Framework
>Affects Versions: framework-7.0.0
>Reporter: Jürgen Albert
>Assignee: Karl Pauls
>Priority: Major
>
> We recently stumbled a couple of times over an IllegalArgumentException when
> calling ServiceObjects.ungetService. In our case we are always in an async
> process and the service we are calling unget for ist already unregistered.
> According to the org.osgi.framework.ServiceObjects Spec the Exception will be
> thrown under the following circumstances:
> {code:java}
> @throws IllegalArgumentException If the specified service object is
>{@code null} or was not provided by a {@code ServiceObjects}
>object for the associated service.
> {code}
> I can guarantee that both conditions are not meet in our case. It is simply
> that the service is already unregistered.
> If I read the javadoc correctly it should simply do nothing in such a case. I
> haven't checked with the Spec though.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Resolved] (FELIX-6273) Improve behaviour when delimiter is set but the type is not
[
https://issues.apache.org/jira/browse/FELIX-6273?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Carsten Ziegeler resolved FELIX-6273.
-
Resolution: Fixed
Improved in [1] by automatically assuming type is String[] if a delimiter is
specified
[1]
https://github.com/apache/felix-dev/commit/b236c6b45af211e43eda05289467505efcd904ce
> Improve behaviour when delimiter is set but the type is not
> ---
>
> Key: FELIX-6273
> URL: https://issues.apache.org/jira/browse/FELIX-6273
> Project: Felix
> Issue Type: Improvement
> Components: Configuration Admin
>Affects Versions: configadmin-interpolation-plugin-1.1.0
>Reporter: Robert Munteanu
>Assignee: Carsten Ziegeler
>Priority: Major
> Fix For: configadmin-interpolation-plugin-1.2.2
>
>
> When configuring property values with a delimiter, it is expected that the
> property is an array. Otherwise, the delimited does not make sense IMO.
> Assuming I have exporter {{PROP=foo,bar}}.
> If I configure interpolation for a property value as
> prop="$[env:PROP;delimiter=,]"
> At runtime it get interpolated to {{prop = foo,bar}}, which is
> clearly not what I expected. The correct syntax is
> prop="$[env:PROP;type=String[];delimiter=,]"
> after which the interpolation result is indeed {{ prop = [foo, bar]
> }}.
> There are a number of ways this could be improved
> - fail interpolation with an exception
> - log a WARN/ERROR message
> - assume that if a delimiter is present but the type is not, the type is
> {{String[]}}, and not {{String}}.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Assigned] (FELIX-6273) Improve behaviour when delimiter is set but the type is not
[
https://issues.apache.org/jira/browse/FELIX-6273?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Carsten Ziegeler reassigned FELIX-6273:
---
Assignee: Carsten Ziegeler
> Improve behaviour when delimiter is set but the type is not
> ---
>
> Key: FELIX-6273
> URL: https://issues.apache.org/jira/browse/FELIX-6273
> Project: Felix
> Issue Type: Improvement
> Components: Configuration Admin
>Affects Versions: configadmin-interpolation-plugin-1.1.0
>Reporter: Robert Munteanu
>Assignee: Carsten Ziegeler
>Priority: Major
> Fix For: configadmin-interpolation-plugin-1.2.2
>
>
> When configuring property values with a delimiter, it is expected that the
> property is an array. Otherwise, the delimited does not make sense IMO.
> Assuming I have exporter {{PROP=foo,bar}}.
> If I configure interpolation for a property value as
> prop="$[env:PROP;delimiter=,]"
> At runtime it get interpolated to {{prop = foo,bar}}, which is
> clearly not what I expected. The correct syntax is
> prop="$[env:PROP;type=String[];delimiter=,]"
> after which the interpolation result is indeed {{ prop = [foo, bar]
> }}.
> There are a number of ways this could be improved
> - fail interpolation with an exception
> - log a WARN/ERROR message
> - assume that if a delimiter is present but the type is not, the type is
> {{String[]}}, and not {{String}}.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Commented] (FELIX-6429) IllegalArgumentException that should not happen
[
https://issues.apache.org/jira/browse/FELIX-6429?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17410387#comment-17410387
]
Carsten Ziegeler commented on FELIX-6429:
-
It would help to get a stack trace for the exception to better understand why
/where it is thrown
> IllegalArgumentException that should not happen
> ---
>
> Key: FELIX-6429
> URL: https://issues.apache.org/jira/browse/FELIX-6429
> Project: Felix
> Issue Type: Bug
> Components: Framework
>Affects Versions: framework-7.0.0
>Reporter: Jürgen Albert
>Priority: Major
>
> We recently stumbled a couple of times over an IllegalArgumentException when
> calling ServiceObjects.ungetService. In our case we are always in an async
> process and the service we are calling unget for ist already unregistered.
> According to the org.osgi.framework.ServiceObjects Spec the Exception will be
> thrown under the following circumstances:
> {code:java}
> @throws IllegalArgumentException If the specified service object is
>{@code null} or was not provided by a {@code ServiceObjects}
>object for the associated service.
> {code}
> I can guarantee that both conditions are not meet in our case. It is simply
> that the service is already unregistered.
> If I read the javadoc correctly it should simply do nothing in such a case. I
> haven't checked with the Spec though.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
