[jira] [Assigned] (FELIX-6531) Web Console 4.8.0 does not generate metatype configurations for services
[ https://issues.apache.org/jira/browse/FELIX-6531?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Carsten Ziegeler reassigned FELIX-6531: --- Assignee: Carsten Ziegeler > Web Console 4.8.0 does not generate metatype configurations for services > > > Key: FELIX-6531 > URL: https://issues.apache.org/jira/browse/FELIX-6531 > Project: Felix > Issue Type: Bug > Components: Web Console >Affects Versions: webconsole-4.8.0 >Reporter: Rakesh Kumar >Assignee: Carsten Ziegeler >Priority: Critical > Attachments: image-2022-05-19-08-48-29-506.png, > image-2022-05-19-08-51-08-927.png > > > WebConsole 4.8.0 does not generate metatype configurations for services while > it generates for service factories. > This works perfectly with v4.7.2, not sure if this was intentional in v4.8.0 > to not generate the configurations. > Here is the screenshot with v4.7.2 deployed. > !image-2022-05-19-08-48-29-506.png|width=578,height=258! > > And here is with v4.8.0 > !image-2022-05-19-08-51-08-927.png|width=528,height=227! > You could see none of the configurations available here which were there in > v4.7.2. -- This message was sent by Atlassian Jira (v8.20.7#820007)
[jira] [Updated] (FELIX-6531) Web Console 4.8.0 does not generate metatype configurations for services
[ https://issues.apache.org/jira/browse/FELIX-6531?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Carsten Ziegeler updated FELIX-6531: Priority: Blocker (was: Critical) > Web Console 4.8.0 does not generate metatype configurations for services > > > Key: FELIX-6531 > URL: https://issues.apache.org/jira/browse/FELIX-6531 > Project: Felix > Issue Type: Bug > Components: Web Console >Affects Versions: webconsole-4.8.0 >Reporter: Rakesh Kumar >Assignee: Carsten Ziegeler >Priority: Blocker > Attachments: image-2022-05-19-08-48-29-506.png, > image-2022-05-19-08-51-08-927.png > > > WebConsole 4.8.0 does not generate metatype configurations for services while > it generates for service factories. > This works perfectly with v4.7.2, not sure if this was intentional in v4.8.0 > to not generate the configurations. > Here is the screenshot with v4.7.2 deployed. > !image-2022-05-19-08-48-29-506.png|width=578,height=258! > > And here is with v4.8.0 > !image-2022-05-19-08-51-08-927.png|width=528,height=227! > You could see none of the configurations available here which were there in > v4.7.2. -- This message was sent by Atlassian Jira (v8.20.7#820007)
[jira] [Updated] (FELIX-6531) Web Console 4.8.0 does not generate metatype configurations for services
[ https://issues.apache.org/jira/browse/FELIX-6531?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Carsten Ziegeler updated FELIX-6531: Fix Version/s: webconsole-4.8.2 > Web Console 4.8.0 does not generate metatype configurations for services > > > Key: FELIX-6531 > URL: https://issues.apache.org/jira/browse/FELIX-6531 > Project: Felix > Issue Type: Bug > Components: Web Console >Affects Versions: webconsole-4.8.0 >Reporter: Rakesh Kumar >Assignee: Carsten Ziegeler >Priority: Blocker > Fix For: webconsole-4.8.2 > > Attachments: image-2022-05-19-08-48-29-506.png, > image-2022-05-19-08-51-08-927.png > > > WebConsole 4.8.0 does not generate metatype configurations for services while > it generates for service factories. > This works perfectly with v4.7.2, not sure if this was intentional in v4.8.0 > to not generate the configurations. > Here is the screenshot with v4.7.2 deployed. > !image-2022-05-19-08-48-29-506.png|width=578,height=258! > > And here is with v4.8.0 > !image-2022-05-19-08-51-08-927.png|width=528,height=227! > You could see none of the configurations available here which were there in > v4.7.2. -- This message was sent by Atlassian Jira (v8.20.7#820007)
[jira] [Work started] (FELIX-6531) Web Console 4.8.0 does not generate metatype configurations for services
[ https://issues.apache.org/jira/browse/FELIX-6531?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Work on FELIX-6531 started by Carsten Ziegeler. --- > Web Console 4.8.0 does not generate metatype configurations for services > > > Key: FELIX-6531 > URL: https://issues.apache.org/jira/browse/FELIX-6531 > Project: Felix > Issue Type: Bug > Components: Web Console >Affects Versions: webconsole-4.8.0 >Reporter: Rakesh Kumar >Assignee: Carsten Ziegeler >Priority: Blocker > Fix For: webconsole-4.8.2 > > Attachments: image-2022-05-19-08-48-29-506.png, > image-2022-05-19-08-51-08-927.png > > > WebConsole 4.8.0 does not generate metatype configurations for services while > it generates for service factories. > This works perfectly with v4.7.2, not sure if this was intentional in v4.8.0 > to not generate the configurations. > Here is the screenshot with v4.7.2 deployed. > !image-2022-05-19-08-48-29-506.png|width=578,height=258! > > And here is with v4.8.0 > !image-2022-05-19-08-51-08-927.png|width=528,height=227! > You could see none of the configurations available here which were there in > v4.7.2. -- This message was sent by Atlassian Jira (v8.20.7#820007)
[jira] [Commented] (FELIX-6531) Web Console 4.8.0 does not generate metatype configurations for services
[ https://issues.apache.org/jira/browse/FELIX-6531?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17539413#comment-17539413 ] Carsten Ziegeler commented on FELIX-6531: - [~rakeshk15] Thanks for reporting. It seems there were severl problems introduced with the last release. I think I have fixed those in https://github.com/apache/felix-dev/commit/cc3b0125c20e9f8c2a8b0b2685d0aafa2eca02af Could you please give that a try? > Web Console 4.8.0 does not generate metatype configurations for services > > > Key: FELIX-6531 > URL: https://issues.apache.org/jira/browse/FELIX-6531 > Project: Felix > Issue Type: Bug > Components: Web Console >Affects Versions: webconsole-4.8.0 >Reporter: Rakesh Kumar >Assignee: Carsten Ziegeler >Priority: Blocker > Fix For: webconsole-4.8.2 > > Attachments: image-2022-05-19-08-48-29-506.png, > image-2022-05-19-08-51-08-927.png > > > WebConsole 4.8.0 does not generate metatype configurations for services while > it generates for service factories. > This works perfectly with v4.7.2, not sure if this was intentional in v4.8.0 > to not generate the configurations. > Here is the screenshot with v4.7.2 deployed. > !image-2022-05-19-08-48-29-506.png|width=578,height=258! > > And here is with v4.8.0 > !image-2022-05-19-08-51-08-927.png|width=528,height=227! > You could see none of the configurations available here which were there in > v4.7.2. -- This message was sent by Atlassian Jira (v8.20.7#820007)
Final reminder: ApacheCon North America call for presentations closing soon
[Note: You're receiving this because you are subscribed to one or more Apache Software Foundation project mailing lists.] This is your final reminder that the Call for Presetations for ApacheCon North America 2022 will close at 00:01 GMT on Monday, May 23rd, 2022. Please don't wait! Get your talk proposals in now! Details here: https://apachecon.com/acna2022/cfp.html --Rich, for the ApacheCon Planners
[jira] [Created] (FELIX-6532) Remove dependency to commons-io
Carsten Ziegeler created FELIX-6532: --- Summary: Remove dependency to commons-io Key: FELIX-6532 URL: https://issues.apache.org/jira/browse/FELIX-6532 Project: Felix Issue Type: Improvement Components: Web Console Reporter: Carsten Ziegeler Assignee: Carsten Ziegeler Fix For: webconsole-4.8.2 The webconsole only uses a few methods from commons-io where some of them can today be replaced with newer JDK functionality. Therefore we should remove the dependency. -- This message was sent by Atlassian Jira (v8.20.7#820007)
[jira] [Commented] (FELIX-6531) Web Console 4.8.0 does not generate metatype configurations for services
[ https://issues.apache.org/jira/browse/FELIX-6531?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17539454#comment-17539454 ] Rakesh Kumar commented on FELIX-6531: - Hi [~cziegeler] I just tested 4.8.1-SNAPSHOT and found it working like v4.7.2, thanks for the fix. Best Regards, Rakesh > Web Console 4.8.0 does not generate metatype configurations for services > > > Key: FELIX-6531 > URL: https://issues.apache.org/jira/browse/FELIX-6531 > Project: Felix > Issue Type: Bug > Components: Web Console >Affects Versions: webconsole-4.8.0 >Reporter: Rakesh Kumar >Assignee: Carsten Ziegeler >Priority: Blocker > Fix For: webconsole-4.8.2 > > Attachments: image-2022-05-19-08-48-29-506.png, > image-2022-05-19-08-51-08-927.png > > > WebConsole 4.8.0 does not generate metatype configurations for services while > it generates for service factories. > This works perfectly with v4.7.2, not sure if this was intentional in v4.8.0 > to not generate the configurations. > Here is the screenshot with v4.7.2 deployed. > !image-2022-05-19-08-48-29-506.png|width=578,height=258! > > And here is with v4.8.0 > !image-2022-05-19-08-51-08-927.png|width=528,height=227! > You could see none of the configurations available here which were there in > v4.7.2. -- This message was sent by Atlassian Jira (v8.20.7#820007)
[jira] [Resolved] (FELIX-6531) Web Console 4.8.0 does not generate metatype configurations for services
[ https://issues.apache.org/jira/browse/FELIX-6531?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Carsten Ziegeler resolved FELIX-6531. - Resolution: Fixed Thanks for confirming > Web Console 4.8.0 does not generate metatype configurations for services > > > Key: FELIX-6531 > URL: https://issues.apache.org/jira/browse/FELIX-6531 > Project: Felix > Issue Type: Bug > Components: Web Console >Affects Versions: webconsole-4.8.0 >Reporter: Rakesh Kumar >Assignee: Carsten Ziegeler >Priority: Blocker > Fix For: webconsole-4.8.2 > > Attachments: image-2022-05-19-08-48-29-506.png, > image-2022-05-19-08-51-08-927.png > > > WebConsole 4.8.0 does not generate metatype configurations for services while > it generates for service factories. > This works perfectly with v4.7.2, not sure if this was intentional in v4.8.0 > to not generate the configurations. > Here is the screenshot with v4.7.2 deployed. > !image-2022-05-19-08-48-29-506.png|width=578,height=258! > > And here is with v4.8.0 > !image-2022-05-19-08-51-08-927.png|width=528,height=227! > You could see none of the configurations available here which were there in > v4.7.2. -- This message was sent by Atlassian Jira (v8.20.7#820007)
[jira] [Created] (FELIX-6533) Felix released as milestone version cannot parse it's own version id
David Matějček created FELIX-6533: - Summary: Felix released as milestone version cannot parse it's own version id Key: FELIX-6533 URL: https://issues.apache.org/jira/browse/FELIX-6533 Project: Felix Issue Type: Bug Components: Framework Affects Versions: framework-7.0.3 Reporter: David Matějček Fix For: framework-7.0.4 We tried to prerelease a custom built version for GlassFish, but it it not able to start now. h3. Cause I found that it tries to "cleanup" the Maven version, but does it wrong and then tries to parse the result again which fails. *Solution* I am creating PR right after this issue. Felix already has the correct implementation usable for this, so I just moved it to the Version class (which seems to be a natural place for this), updated all references and also extended tests. It is backward compatible despite the bit of refactoring. -- This message was sent by Atlassian Jira (v8.20.7#820007)
[GitHub] [felix-dev] dmatej opened a new pull request, #152: FELIX-6533 Fixed processing maven version from Felix.properties
dmatej opened a new pull request, #152: URL: https://github.com/apache/felix-dev/pull/152 - fixed by refactoring: - impl for processing system versions incl. classifier moved to Version - Version used for both OS and Felix version - to stay compatible with previous versions the original method was just marked as deprecated, can be removed later (public static) - NativeLibraryClauseTest was incorrect for mac os (spaces) - FrameworkVersionTest was changed to VersionTest -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@felix.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Resolved] (FELIX-6532) Remove dependency to commons-io
[ https://issues.apache.org/jira/browse/FELIX-6532?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Carsten Ziegeler resolved FELIX-6532. - Resolution: Fixed Fixed in https://github.com/apache/felix-dev/commit/39f09f7f1f813794d5448bf8deece40b23a245b2 Now, while there is no code reference to commons-io anymore, it is still needed, as commons-fileupload depends on it > Remove dependency to commons-io > --- > > Key: FELIX-6532 > URL: https://issues.apache.org/jira/browse/FELIX-6532 > Project: Felix > Issue Type: Improvement > Components: Web Console >Reporter: Carsten Ziegeler >Assignee: Carsten Ziegeler >Priority: Major > Fix For: webconsole-4.8.2 > > > The webconsole only uses a few methods from commons-io where some of them can > today be replaced with newer JDK functionality. > Therefore we should remove the dependency. -- This message was sent by Atlassian Jira (v8.20.7#820007)
[jira] [Created] (FELIX-6534) System bundle findEntries returns entries in case of fragments
Carsten Ziegeler created FELIX-6534: --- Summary: System bundle findEntries returns entries in case of fragments Key: FELIX-6534 URL: https://issues.apache.org/jira/browse/FELIX-6534 Project: Felix Issue Type: Bug Components: Framework Affects Versions: framework-7.0.3 Reporter: Carsten Ziegeler According to http://docs.osgi.org/specification/osgi.core/7.0.0/framework.api.html#org.osgi.framework.launch.Framework.findEntries-String-String-boolean- findEntries on the system bundle should not return entries. However, currently the implementation returns matching entries from extension fragments. But then trying to get such an entry via getEntry returns null (which seems to be correct) So findEntries should be changed to not return entries from extension fragments -- This message was sent by Atlassian Jira (v8.20.7#820007)
[jira] [Updated] (FELIX-6534) System bundle findEntries returns entries in case of fragments
[ https://issues.apache.org/jira/browse/FELIX-6534?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Carsten Ziegeler updated FELIX-6534: Fix Version/s: framework-7.0.4 > System bundle findEntries returns entries in case of fragments > -- > > Key: FELIX-6534 > URL: https://issues.apache.org/jira/browse/FELIX-6534 > Project: Felix > Issue Type: Bug > Components: Framework >Affects Versions: framework-7.0.3 >Reporter: Carsten Ziegeler >Priority: Major > Fix For: framework-7.0.4 > > > According to > http://docs.osgi.org/specification/osgi.core/7.0.0/framework.api.html#org.osgi.framework.launch.Framework.findEntries-String-String-boolean- > findEntries on the system bundle should not return entries. > However, currently the implementation returns matching entries from extension > fragments. > But then trying to get such an entry via getEntry returns null (which seems > to be correct) > So findEntries should be changed to not return entries from extension > fragments -- This message was sent by Atlassian Jira (v8.20.7#820007)
[GitHub] [felix-dev] karlpauls commented on pull request #152: FELIX-6533 Fixed processing maven version from Felix.properties
karlpauls commented on PR #152: URL: https://github.com/apache/felix-dev/pull/152#issuecomment-1131679645 Hi @dmatej, unfortunately, we can't move this into the osgi Version class as that is spec'ed api. So you'd have to move that back into the felix namespace. Furthermore, with all the changes, it is very hard to see what the actual fix you did is (and I'm not sure I found a description of what exactly is going wrong). Could you please create a PR that does the minimal change needed and then maybe a follow-up with refactorings? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@felix.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Assigned] (FELIX-6533) Felix released as milestone version cannot parse it's own version id
[ https://issues.apache.org/jira/browse/FELIX-6533?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Karl Pauls reassigned FELIX-6533: - Assignee: Karl Pauls > Felix released as milestone version cannot parse it's own version id > > > Key: FELIX-6533 > URL: https://issues.apache.org/jira/browse/FELIX-6533 > Project: Felix > Issue Type: Bug > Components: Framework >Affects Versions: framework-7.0.3 >Reporter: David Matějček >Assignee: Karl Pauls >Priority: Blocker > Labels: patch-available, patch-with-test > Fix For: framework-7.0.4 > > Original Estimate: 4h > Remaining Estimate: 4h > > We tried to prerelease a custom built version for GlassFish, but it it not > able to start now. > h3. Cause > I found that it tries to "cleanup" the Maven version, but does it wrong and > then tries to parse the result again which fails. > *Solution* > I am creating PR right after this issue. Felix already has the correct > implementation usable for this, so I just moved it to the Version class > (which seems to be a natural place for this), updated all references and also > extended tests. It is backward compatible despite the bit of refactoring. -- This message was sent by Atlassian Jira (v8.20.7#820007)
[jira] [Commented] (FELIX-6533) Felix released as milestone version cannot parse it's own version id
[ https://issues.apache.org/jira/browse/FELIX-6533?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17539548#comment-17539548 ] Karl Pauls commented on FELIX-6533: --- [~dmatej], I commented on the PR as well - however, could you maybe describe what the version is you have and how it goes wrong (just so that we have that covered in this issue). > Felix released as milestone version cannot parse it's own version id > > > Key: FELIX-6533 > URL: https://issues.apache.org/jira/browse/FELIX-6533 > Project: Felix > Issue Type: Bug > Components: Framework >Affects Versions: framework-7.0.3 >Reporter: David Matějček >Assignee: Karl Pauls >Priority: Blocker > Labels: patch-available, patch-with-test > Fix For: framework-7.0.4 > > Original Estimate: 4h > Remaining Estimate: 4h > > We tried to prerelease a custom built version for GlassFish, but it it not > able to start now. > h3. Cause > I found that it tries to "cleanup" the Maven version, but does it wrong and > then tries to parse the result again which fails. > *Solution* > I am creating PR right after this issue. Felix already has the correct > implementation usable for this, so I just moved it to the Version class > (which seems to be a natural place for this), updated all references and also > extended tests. It is backward compatible despite the bit of refactoring. -- This message was sent by Atlassian Jira (v8.20.7#820007)
[jira] [Assigned] (FELIX-6534) System bundle findEntries returns entries in case of fragments
[ https://issues.apache.org/jira/browse/FELIX-6534?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Karl Pauls reassigned FELIX-6534: - Assignee: Karl Pauls > System bundle findEntries returns entries in case of fragments > -- > > Key: FELIX-6534 > URL: https://issues.apache.org/jira/browse/FELIX-6534 > Project: Felix > Issue Type: Bug > Components: Framework >Affects Versions: framework-7.0.3 >Reporter: Carsten Ziegeler >Assignee: Karl Pauls >Priority: Major > Fix For: framework-7.0.4 > > > According to > http://docs.osgi.org/specification/osgi.core/7.0.0/framework.api.html#org.osgi.framework.launch.Framework.findEntries-String-String-boolean- > findEntries on the system bundle should not return entries. > However, currently the implementation returns matching entries from extension > fragments. > But then trying to get such an entry via getEntry returns null (which seems > to be correct) > So findEntries should be changed to not return entries from extension > fragments -- This message was sent by Atlassian Jira (v8.20.7#820007)
[jira] [Commented] (FELIX-6534) System bundle findEntries returns entries in case of fragments
[ https://issues.apache.org/jira/browse/FELIX-6534?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17539549#comment-17539549 ] Karl Pauls commented on FELIX-6534: --- Yup, looks like a bug that got introduced when extensions started to have real fragment wires. > System bundle findEntries returns entries in case of fragments > -- > > Key: FELIX-6534 > URL: https://issues.apache.org/jira/browse/FELIX-6534 > Project: Felix > Issue Type: Bug > Components: Framework >Affects Versions: framework-7.0.3 >Reporter: Carsten Ziegeler >Assignee: Karl Pauls >Priority: Major > Fix For: framework-7.0.4 > > > According to > http://docs.osgi.org/specification/osgi.core/7.0.0/framework.api.html#org.osgi.framework.launch.Framework.findEntries-String-String-boolean- > findEntries on the system bundle should not return entries. > However, currently the implementation returns matching entries from extension > fragments. > But then trying to get such an entry via getEntry returns null (which seems > to be correct) > So findEntries should be changed to not return entries from extension > fragments -- This message was sent by Atlassian Jira (v8.20.7#820007)
[GitHub] [felix-dev] dmatej commented on pull request #152: FELIX-6533 Fixed processing maven version from Felix.properties
dmatej commented on PR #152: URL: https://github.com/apache/felix-dev/pull/152#issuecomment-1131719330 The fix is this cleanup, result of it, fixed state, not some "fixed if condition". This is a minimized change, except some generics I left in one smaller class (NativeLibraryClause) and autoremoved whitespaces in Version (can be disabled in review). I can remove them too, but then it will take more of my time and we are just going back to swamps. I don't understand why the specified API is included directly into the Felix framework module, but ok, I will move it somewhere else, despite it will reduce readability for developers. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@felix.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [felix-dev] dmatej commented on pull request #152: FELIX-6533 Fixed processing maven version from Felix.properties
dmatej commented on PR #152: URL: https://github.com/apache/felix-dev/pull/152#issuecomment-1131758622 Is it better now? I removed changes in generics and one for cycle, whitespaces, and moved the code out of the osgi packages to own class. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@felix.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Updated] (FELIX-6533) Felix released as milestone version cannot parse it's own version id
[ https://issues.apache.org/jira/browse/FELIX-6533?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] David Matějček updated FELIX-6533: -- Description: We tried to prerelease a custom built version for GlassFish, but it it not able to start now. The version id was 7.0.4-omnifish-M1; Felix changed it to 7.0.4.omnifish.M1 on startup and then crashed, because dots are not allowed in classifier. h3. Cause I found that it tries to "cleanup" the Maven version, but does it wrong and then tries to parse the result again which fails. *Solution* I am creating PR right after this issue. Felix already has the correct implementation usable for this, so I just moved it to the Version class (which seems to be a natural place for this), updated all references and also extended tests. It is backward compatible despite the bit of refactoring. was: We tried to prerelease a custom built version for GlassFish, but it it not able to start now. h3. Cause I found that it tries to "cleanup" the Maven version, but does it wrong and then tries to parse the result again which fails. *Solution* I am creating PR right after this issue. Felix already has the correct implementation usable for this, so I just moved it to the Version class (which seems to be a natural place for this), updated all references and also extended tests. It is backward compatible despite the bit of refactoring. > Felix released as milestone version cannot parse it's own version id > > > Key: FELIX-6533 > URL: https://issues.apache.org/jira/browse/FELIX-6533 > Project: Felix > Issue Type: Bug > Components: Framework >Affects Versions: framework-7.0.3 >Reporter: David Matějček >Assignee: Karl Pauls >Priority: Blocker > Labels: patch-available, patch-with-test > Fix For: framework-7.0.4 > > Original Estimate: 4h > Remaining Estimate: 4h > > We tried to prerelease a custom built version for GlassFish, but it it not > able to start now. The version id was 7.0.4-omnifish-M1; Felix changed it to > 7.0.4.omnifish.M1 on startup and then crashed, because dots are not allowed > in classifier. > h3. Cause > I found that it tries to "cleanup" the Maven version, but does it wrong and > then tries to parse the result again which fails. > *Solution* > I am creating PR right after this issue. Felix already has the correct > implementation usable for this, so I just moved it to the Version class > (which seems to be a natural place for this), updated all references and also > extended tests. It is backward compatible despite the bit of refactoring. -- This message was sent by Atlassian Jira (v8.20.7#820007)
[jira] [Commented] (FELIX-6533) Felix released as milestone version cannot parse it's own version id
[ https://issues.apache.org/jira/browse/FELIX-6533?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17539578#comment-17539578 ] David Matějček commented on FELIX-6533: --- I updated the description; in the PR I extended the existing test (and moved that to appropriated place in relation to the new class) to cover this variant. > Felix released as milestone version cannot parse it's own version id > > > Key: FELIX-6533 > URL: https://issues.apache.org/jira/browse/FELIX-6533 > Project: Felix > Issue Type: Bug > Components: Framework >Affects Versions: framework-7.0.3 >Reporter: David Matějček >Assignee: Karl Pauls >Priority: Blocker > Labels: patch-available, patch-with-test > Fix For: framework-7.0.4 > > Original Estimate: 4h > Remaining Estimate: 4h > > We tried to prerelease a custom built version for GlassFish, but it it not > able to start now. The version id was 7.0.4-omnifish-M1; Felix changed it to > 7.0.4.omnifish.M1 on startup and then crashed, because dots are not allowed > in classifier. > h3. Cause > I found that it tries to "cleanup" the Maven version, but does it wrong and > then tries to parse the result again which fails. > *Solution* > I am creating PR right after this issue. Felix already has the correct > implementation usable for this, so I just moved it to the Version class > (which seems to be a natural place for this), updated all references and also > extended tests. It is backward compatible despite the bit of refactoring. -- This message was sent by Atlassian Jira (v8.20.7#820007)
[jira] [Commented] (FELIX-6517) Felix startup time is increased considerably after upgrading the ConfigAdmin to v1.9.24
[ https://issues.apache.org/jira/browse/FELIX-6517?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17539579#comment-17539579 ] Rakesh Kumar commented on FELIX-6517: - [~rotty3000] did you get a chance to investigate the delay? > Felix startup time is increased considerably after upgrading the ConfigAdmin > to v1.9.24 > --- > > Key: FELIX-6517 > URL: https://issues.apache.org/jira/browse/FELIX-6517 > Project: Felix > Issue Type: Bug > Components: Configuration Admin >Affects Versions: configadmin-1.9.24 >Reporter: Rakesh Kumar >Priority: Major > > I have just upgraded the ConfigAdmin to v1.9.24 and noticed that the Felix is > taking more than a minute to boot up, it is way faster with v1.9.22. > Here are the startup logs with v1.9.24. > {code:java} > 2022-04-05 05:40:10.668 [AdeptJ Launcher] INFO > com.adeptj.runtime.osgi.FrameworkManager - Starting the OSGi Framework!! > 2022-04-05 05:40:10.812 [AdeptJ Launcher] INFO > com.adeptj.runtime.osgi.BundleProvisioner - Starting provisioning of bundles > on OSGi framework's first bootstrap!! > 2022-04-05 05:40:12.306 [AdeptJ Launcher] INFO > com.adeptj.runtime.osgi.BundleProvisioner - Started Bundle > [adeptj-modules-data-mybatis [1], v1.0.0] > 2022-04-05 05:40:12.309 [AdeptJ Launcher] INFO > com.adeptj.runtime.osgi.BundleProvisioner - Started Bundle > [org.osgi.util.function [2], v1.2.0.202109301733] > 2022-04-05 05:40:12.312 [AdeptJ Launcher] INFO > com.adeptj.runtime.osgi.BundleProvisioner - Started Bundle > [org.eclipse.persistence.jpa.jpql [3], v2.7.10.v20211216-fe64cd39c3] > 2022-04-05 05:40:12.315 [AdeptJ Launcher] INFO > com.adeptj.runtime.osgi.BundleProvisioner - Started Bundle > [org.osgi.util.pushstream [4], v1.0.2.202109301733] > 2022-04-05 05:40:12.318 [AdeptJ Launcher] INFO > com.adeptj.runtime.osgi.BundleProvisioner - Started Bundle > [org.mongodb.driver-core [5], v4.5.0] > 2022-04-05 05:40:12.321 [AdeptJ Launcher] INFO > com.adeptj.runtime.osgi.BundleProvisioner - Started Bundle > [adeptj-modules-commons-cache [6], v1.0.0] > 2022-04-05 05:40:12.324 [AdeptJ Launcher] INFO > com.adeptj.runtime.osgi.BundleProvisioner - Started Bundle > [org.apache.felix.inventory [7], v1.1.0] > 2022-04-05 05:40:12.326 [AdeptJ Launcher] INFO > com.adeptj.runtime.osgi.BundleProvisioner - Started Bundle > [org.osgi.service.jdbc [8], v1.0.1.202109301733] > 2022-04-05 05:40:12.329 [AdeptJ Launcher] INFO > com.adeptj.runtime.osgi.BundleProvisioner - Started Bundle > [org.apache.felix.log [9], v1.2.6] > 2022-04-05 05:40:12.331 [AdeptJ Launcher] INFO > com.adeptj.runtime.osgi.BundleProvisioner - Started Bundle > [com.sun.mail.jakarta.mail [10], v1.6.7] > 2022-04-05 05:40:12.334 [AdeptJ Launcher] INFO > com.adeptj.runtime.osgi.BundleProvisioner - Started Bundle > [adeptj-modules-commons-validator [11], v1.0.3] > 2022-04-05 05:40:12.336 [AdeptJ Launcher] INFO > com.adeptj.runtime.osgi.BundleProvisioner - Started Bundle > [org.postgresql.jdbc [12], v42.3.3] > 2022-04-05 05:40:12.338 [AdeptJ Launcher] INFO > com.adeptj.runtime.osgi.BundleProvisioner - Started Bundle > [org.apache.felix.org.apache.felix.threaddump [13], v1.0.0] > 2022-04-05 05:40:12.341 [AdeptJ Launcher] INFO > com.adeptj.runtime.osgi.BundleProvisioner - Started Bundle > [org.apache.felix.cm.json [14], v1.0.6] > 2022-04-05 05:40:12.344 [AdeptJ Launcher] INFO > com.adeptj.runtime.osgi.BundleProvisioner - Started Bundle > [org.eclipse.persistence.core [15], v2.7.10.v20211216-fe64cd39c3] > 2022-04-05 05:40:12.347 [AdeptJ Launcher] INFO > com.adeptj.runtime.osgi.BundleProvisioner - Started Bundle > [adeptj-modules-commons-crypto [16], v1.0.0] > 2022-04-05 05:40:12.350 [AdeptJ Launcher] INFO > com.adeptj.runtime.osgi.BundleProvisioner - Started Bundle [org.mongojack > [17], v4.3.0] > 2022-04-05 05:40:12.353 [AdeptJ Launcher] INFO > com.adeptj.runtime.osgi.BundleProvisioner - Started Bundle > [adeptj-modules-commons-utils [18], v1.1.0] > 2022-04-05 05:40:12.356 [AdeptJ Launcher] INFO > com.adeptj.runtime.osgi.BundleProvisioner - Started Bundle > [adeptj-modules-websecurity-jwt [19], v1.1.0] > 2022-04-05 05:40:12.360 [AdeptJ Launcher] INFO > com.adeptj.runtime.osgi.BundleProvisioner - Started Bundle > [org.apache.commons.commons-io [20], v2.11.0] > 2022-04-05 05:40:12.363 [AdeptJ Launcher] INFO > com.adeptj.runtime.osgi.BundleProvisioner - Started Bundle > [org.eclipse.persistence.jpa [21], v2.7.10.v20211216-fe64cd39c3] > 2022-04-05 05:40:12.367 [AdeptJ Launcher] INFO > com.adeptj.runtime.osgi.BundleProvisioner - Started Bundle > [adeptj-modules-commons-jdbc [22], v1.0.0] > 2022-04-05 05:40:12.369 [AdeptJ Launcher] INFO > com.adeptj.runtime.osgi.BundleProvisioner - Started Bundle > [org.apa
[VOTE] Release Apache Felix Webconsole 4.8.2
Hi, We solved three issues https://issues.apache.org/jira/browse/FELIX-6531?jql=project%20%3D%20FELIX%20AND%20fixVersion%20%3D%20webconsole-4.8.2 Staging repository: https://repository.apache.org/content/repositories/orgapachefelix-1427 You can use this UNIX script to download the release and verify the signatures: https://github.com/apache/felix-dev/blob/master/check_staged_release.sh Usage: sh check_staged_release.sh 1427 /tmp/felix-staging Please vote to approve this release: [ ] +1 Approve the release [ ] -1 Veto the release (please provide specific comments) This vote will be open for 72 hours. Regards Carsten -- Carsten Ziegeler Adobe cziege...@apache.org
Re: [VOTE] Release Apache Felix Webconsole 4.8.2
+1 Ray On Thu, May 19, 2022 at 12:22 PM Carsten Ziegeler wrote: > Hi, > > We solved three issues > > https://issues.apache.org/jira/browse/FELIX-6531?jql=project%20%3D%20FELIX%20AND%20fixVersion%20%3D%20webconsole-4.8.2 > > Staging repository: > https://repository.apache.org/content/repositories/orgapachefelix-1427 > > You can use this UNIX script to download the release and verify the > signatures: > https://github.com/apache/felix-dev/blob/master/check_staged_release.sh > > Usage: > sh check_staged_release.sh 1427 /tmp/felix-staging > > Please vote to approve this release: > > [ ] +1 Approve the release > [ ] -1 Veto the release (please provide specific comments) > > This vote will be open for 72 hours. > > Regards > Carsten > -- > Carsten Ziegeler > Adobe > cziege...@apache.org > -- *Raymond Augé* (@rotty3000) Senior Software Architect *Liferay, Inc.* (@Liferay) OSGi Fellow, Java Champion
Re: [VOTE] Release Apache Felix Webconsole 4.8.2
+1 regards, Karl On Thursday, May 19, 2022, Raymond Augé wrote: > +1 > > Ray > > On Thu, May 19, 2022 at 12:22 PM Carsten Ziegeler > wrote: > > > Hi, > > > > We solved three issues > > > > https://issues.apache.org/jira/browse/FELIX-6531?jql= > project%20%3D%20FELIX%20AND%20fixVersion%20%3D%20webconsole-4.8.2 > > > > Staging repository: > > https://repository.apache.org/content/repositories/orgapachefelix-1427 > > > > You can use this UNIX script to download the release and verify the > > signatures: > > https://github.com/apache/felix-dev/blob/master/check_staged_release.sh > > > > Usage: > > sh check_staged_release.sh 1427 /tmp/felix-staging > > > > Please vote to approve this release: > > > > [ ] +1 Approve the release > > [ ] -1 Veto the release (please provide specific comments) > > > > This vote will be open for 72 hours. > > > > Regards > > Carsten > > -- > > Carsten Ziegeler > > Adobe > > cziege...@apache.org > > > > > -- > *Raymond Augé* (@rotty3000) > Senior Software Architect *Liferay, Inc.* (@Liferay) > OSGi Fellow, Java Champion > -- Karl Pauls karlpa...@gmail.com
[GitHub] [felix-dev] karlpauls merged pull request #153: FELIX-6534: system bundle findEntries should return null
karlpauls merged PR #153: URL: https://github.com/apache/felix-dev/pull/153 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@felix.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Resolved] (FELIX-6534) System bundle findEntries returns entries in case of fragments
[ https://issues.apache.org/jira/browse/FELIX-6534?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Karl Pauls resolved FELIX-6534. --- Resolution: Fixed Fixed in https://github.com/apache/felix-dev/pull/153 > System bundle findEntries returns entries in case of fragments > -- > > Key: FELIX-6534 > URL: https://issues.apache.org/jira/browse/FELIX-6534 > Project: Felix > Issue Type: Bug > Components: Framework >Affects Versions: framework-7.0.3 >Reporter: Carsten Ziegeler >Assignee: Karl Pauls >Priority: Major > Fix For: framework-7.0.4 > > > According to > http://docs.osgi.org/specification/osgi.core/7.0.0/framework.api.html#org.osgi.framework.launch.Framework.findEntries-String-String-boolean- > findEntries on the system bundle should not return entries. > However, currently the implementation returns matching entries from extension > fragments. > But then trying to get such an entry via getEntry returns null (which seems > to be correct) > So findEntries should be changed to not return entries from extension > fragments -- This message was sent by Atlassian Jira (v8.20.7#820007)
[jira] [Resolved] (FELIX-6533) Felix released as milestone version cannot parse it's own version id
[ https://issues.apache.org/jira/browse/FELIX-6533?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Karl Pauls resolved FELIX-6533. --- Resolution: Fixed Thanks, I merged the PR > Felix released as milestone version cannot parse it's own version id > > > Key: FELIX-6533 > URL: https://issues.apache.org/jira/browse/FELIX-6533 > Project: Felix > Issue Type: Bug > Components: Framework >Affects Versions: framework-7.0.3 >Reporter: David Matějček >Assignee: Karl Pauls >Priority: Blocker > Labels: patch-available, patch-with-test > Fix For: framework-7.0.4 > > Original Estimate: 4h > Remaining Estimate: 4h > > We tried to prerelease a custom built version for GlassFish, but it it not > able to start now. The version id was 7.0.4-omnifish-M1; Felix changed it to > 7.0.4.omnifish.M1 on startup and then crashed, because dots are not allowed > in classifier. > h3. Cause > I found that it tries to "cleanup" the Maven version, but does it wrong and > then tries to parse the result again which fails. > *Solution* > I am creating PR right after this issue. Felix already has the correct > implementation usable for this, so I just moved it to the Version class > (which seems to be a natural place for this), updated all references and also > extended tests. It is backward compatible despite the bit of refactoring. -- This message was sent by Atlassian Jira (v8.20.7#820007)
[GitHub] [felix-dev] karlpauls merged pull request #152: FELIX-6533 Fixed processing maven version from Felix.properties
karlpauls merged PR #152: URL: https://github.com/apache/felix-dev/pull/152 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@felix.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [felix-dev] karlpauls commented on pull request #152: FELIX-6533 Fixed processing maven version from Felix.properties
karlpauls commented on PR #152: URL: https://github.com/apache/felix-dev/pull/152#issuecomment-1132246494 Looks good, thanks -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@felix.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Updated] (FELIX-6488) Optimize ServiceReference.isAssignableTo
[ https://issues.apache.org/jira/browse/FELIX-6488?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Karl Pauls updated FELIX-6488: -- Fix Version/s: framework-7.0.5 (was: framework-7.0.4) > Optimize ServiceReference.isAssignableTo > > > Key: FELIX-6488 > URL: https://issues.apache.org/jira/browse/FELIX-6488 > Project: Felix > Issue Type: Improvement > Components: Framework >Affects Versions: framework-7.0.3 >Reporter: Karl Pauls >Assignee: Karl Pauls >Priority: Major > Fix For: framework-7.0.5 > > > The ServiceReference.isAssignableTo(Bundle bundle, String className) does > some complicated check to see if the service is assignable. This includes > trying to load classes and catching CNFE to see if providers and/or > requesters have access to the given class. > As that is done quite a bit (it is used in service event dispatching and > service lookup) it would be good to optimize this to either not throw CNFE > during the lookup or maybe at least cache the results to not have them be > done all the time. -- This message was sent by Atlassian Jira (v8.20.7#820007)
[GitHub] [felix-dev] karlpauls merged pull request #151: FELIX-6529: deduplicate strings and dirs/attrs of reqs and caps
karlpauls merged PR #151: URL: https://github.com/apache/felix-dev/pull/151 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@felix.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Resolved] (FELIX-6529) Improve memory usage ManifestParser using String deduplication
[ https://issues.apache.org/jira/browse/FELIX-6529?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Karl Pauls resolved FELIX-6529. --- Resolution: Fixed I merged my PR - [~amitmondal], I hope it helps in your case too (it does reduce memory usage for at least one example case I did). > Improve memory usage ManifestParser using String deduplication > -- > > Key: FELIX-6529 > URL: https://issues.apache.org/jira/browse/FELIX-6529 > Project: Felix > Issue Type: Improvement >Reporter: Johannes Edmeier >Assignee: Karl Pauls >Priority: Major > Fix For: framework-7.0.4 > > Attachments: ManifestParser.patch, image-2022-05-13-14-16-39-509.png, > image-2022-05-13-14-17-55-965.png > > > In my heap dump I've seen a lot of duplicate Strings produced by the > ManifestParser. > It creates a lot of equal strings for the keys in the manifest but doesn't > deduplicate them and they're hold forever producing a lot on retained heap. > I've patched the ManifestParser to deduplicate just the keys and could save > ~8 Megs of heap. > Total usage before: 38MB after: 30MB > Duplicated Strings before: > !image-2022-05-13-14-16-39-509.png|width=658,height=203! > Duplicated Strings after: > !image-2022-05-13-14-17-55-965.png|width=793,height=200! > See patch attached. -- This message was sent by Atlassian Jira (v8.20.7#820007)
[jira] [Assigned] (FELIX-6516) Remove synchronization on Integer in Felix Framework
[ https://issues.apache.org/jira/browse/FELIX-6516?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Karl Pauls reassigned FELIX-6516: - Assignee: Karl Pauls (was: Jean-Baptiste Onofré) > Remove synchronization on Integer in Felix Framework > > > Key: FELIX-6516 > URL: https://issues.apache.org/jira/browse/FELIX-6516 > Project: Felix > Issue Type: Improvement > Components: Framework >Reporter: Antoine DESSAIGNE >Assignee: Karl Pauls >Priority: Major > Fix For: framework-7.0.4 > > > Hello, > In Java 16 was release [JEP 390|https://openjdk.java.net/jeps/390] which > issues warning when trying to synchronize on value-based class such as Integer > I've found and fixed such usage in {{FrameworkStartLevelImpl}}. > Can you have a look? Thank you -- This message was sent by Atlassian Jira (v8.20.7#820007)
[GitHub] [felix-dev] karlpauls commented on pull request #134: FELIX-6516 - Remove synchronization on Integer
karlpauls commented on PR #134: URL: https://github.com/apache/felix-dev/pull/134#issuecomment-1132254967 Thanks for the PR - looks good to me -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@felix.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [felix-dev] karlpauls merged pull request #134: FELIX-6516 - Remove synchronization on Integer
karlpauls merged PR #134: URL: https://github.com/apache/felix-dev/pull/134 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@felix.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Resolved] (FELIX-6516) Remove synchronization on Integer in Felix Framework
[ https://issues.apache.org/jira/browse/FELIX-6516?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Karl Pauls resolved FELIX-6516. --- Resolution: Fixed I applied the PR - thanks! > Remove synchronization on Integer in Felix Framework > > > Key: FELIX-6516 > URL: https://issues.apache.org/jira/browse/FELIX-6516 > Project: Felix > Issue Type: Improvement > Components: Framework >Reporter: Antoine DESSAIGNE >Assignee: Karl Pauls >Priority: Major > Fix For: framework-7.0.4 > > > Hello, > In Java 16 was release [JEP 390|https://openjdk.java.net/jeps/390] which > issues warning when trying to synchronize on value-based class such as Integer > I've found and fixed such usage in {{FrameworkStartLevelImpl}}. > Can you have a look? Thank you -- This message was sent by Atlassian Jira (v8.20.7#820007)
[jira] [Commented] (FELIX-6529) Improve memory usage ManifestParser using String deduplication
[ https://issues.apache.org/jira/browse/FELIX-6529?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17539828#comment-17539828 ] Amit Mondal commented on FELIX-6529: [~karlpauls] I just noticed your PR and it surely is very promising. Thanks a ton for fixing this issue with the duplicate strings. If possible, could you kindly also build a framework release? I would certainly give it a thorough test and let you know. > Improve memory usage ManifestParser using String deduplication > -- > > Key: FELIX-6529 > URL: https://issues.apache.org/jira/browse/FELIX-6529 > Project: Felix > Issue Type: Improvement >Reporter: Johannes Edmeier >Assignee: Karl Pauls >Priority: Major > Fix For: framework-7.0.4 > > Attachments: ManifestParser.patch, image-2022-05-13-14-16-39-509.png, > image-2022-05-13-14-17-55-965.png > > > In my heap dump I've seen a lot of duplicate Strings produced by the > ManifestParser. > It creates a lot of equal strings for the keys in the manifest but doesn't > deduplicate them and they're hold forever producing a lot on retained heap. > I've patched the ManifestParser to deduplicate just the keys and could save > ~8 Megs of heap. > Total usage before: 38MB after: 30MB > Duplicated Strings before: > !image-2022-05-13-14-16-39-509.png|width=658,height=203! > Duplicated Strings after: > !image-2022-05-13-14-17-55-965.png|width=793,height=200! > See patch attached. -- This message was sent by Atlassian Jira (v8.20.7#820007)
[jira] [Created] (FELIX-6535) Cleanup path handling in DirectoryContent
Karl Pauls created FELIX-6535: - Summary: Cleanup path handling in DirectoryContent Key: FELIX-6535 URL: https://issues.apache.org/jira/browse/FELIX-6535 Project: Felix Issue Type: Improvement Components: Framework Affects Versions: framework-7.0.3 Reporter: Karl Pauls Assignee: Karl Pauls Fix For: framework-7.0.4 The DirectoryContent path handling could be improved by using the canonical path. -- This message was sent by Atlassian Jira (v8.20.7#820007)
[jira] [Updated] (FELIX-6535) Cleanup path handling in DirectoryContent
[ https://issues.apache.org/jira/browse/FELIX-6535?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Karl Pauls updated FELIX-6535: -- Description: The DirectoryContent path handling could be improved by using the canonical path and cleaning up the exception handling. (was: The DirectoryContent path handling could be improved by using the canonical path.) > Cleanup path handling in DirectoryContent > - > > Key: FELIX-6535 > URL: https://issues.apache.org/jira/browse/FELIX-6535 > Project: Felix > Issue Type: Improvement > Components: Framework >Affects Versions: framework-7.0.3 >Reporter: Karl Pauls >Assignee: Karl Pauls >Priority: Major > Fix For: framework-7.0.4 > > > The DirectoryContent path handling could be improved by using the canonical > path and cleaning up the exception handling. -- This message was sent by Atlassian Jira (v8.20.7#820007)
[GitHub] [felix-dev] karlpauls merged pull request #154: Felix-6535: Cleanup directory revision exception handling
karlpauls merged PR #154: URL: https://github.com/apache/felix-dev/pull/154 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@felix.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Commented] (FELIX-6529) Improve memory usage ManifestParser using String deduplication
[ https://issues.apache.org/jira/browse/FELIX-6529?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17539837#comment-17539837 ] Karl Pauls commented on FELIX-6529: --- [~amitmondal] - thanks, I deployed a new 7.1.0-SNAPSHOT for now so maybe you could test that one already. Otherwise, I'm planning to cut 7.0.4 soon as well. > Improve memory usage ManifestParser using String deduplication > -- > > Key: FELIX-6529 > URL: https://issues.apache.org/jira/browse/FELIX-6529 > Project: Felix > Issue Type: Improvement >Reporter: Johannes Edmeier >Assignee: Karl Pauls >Priority: Major > Fix For: framework-7.0.4 > > Attachments: ManifestParser.patch, image-2022-05-13-14-16-39-509.png, > image-2022-05-13-14-17-55-965.png > > > In my heap dump I've seen a lot of duplicate Strings produced by the > ManifestParser. > It creates a lot of equal strings for the keys in the manifest but doesn't > deduplicate them and they're hold forever producing a lot on retained heap. > I've patched the ManifestParser to deduplicate just the keys and could save > ~8 Megs of heap. > Total usage before: 38MB after: 30MB > Duplicated Strings before: > !image-2022-05-13-14-16-39-509.png|width=658,height=203! > Duplicated Strings after: > !image-2022-05-13-14-17-55-965.png|width=793,height=200! > See patch attached. -- This message was sent by Atlassian Jira (v8.20.7#820007)
[jira] [Commented] (FELIX-6529) Improve memory usage ManifestParser using String deduplication
[ https://issues.apache.org/jira/browse/FELIX-6529?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17539838#comment-17539838 ] Amit Mondal commented on FELIX-6529: [~karlpauls] I can surely test the snapshot version as well. I am just wondering where I can get the snapshot version from. I can only find the latest 7.0.3 release. > Improve memory usage ManifestParser using String deduplication > -- > > Key: FELIX-6529 > URL: https://issues.apache.org/jira/browse/FELIX-6529 > Project: Felix > Issue Type: Improvement >Reporter: Johannes Edmeier >Assignee: Karl Pauls >Priority: Major > Fix For: framework-7.0.4 > > Attachments: ManifestParser.patch, image-2022-05-13-14-16-39-509.png, > image-2022-05-13-14-17-55-965.png > > > In my heap dump I've seen a lot of duplicate Strings produced by the > ManifestParser. > It creates a lot of equal strings for the keys in the manifest but doesn't > deduplicate them and they're hold forever producing a lot on retained heap. > I've patched the ManifestParser to deduplicate just the keys and could save > ~8 Megs of heap. > Total usage before: 38MB after: 30MB > Duplicated Strings before: > !image-2022-05-13-14-16-39-509.png|width=658,height=203! > Duplicated Strings after: > !image-2022-05-13-14-17-55-965.png|width=793,height=200! > See patch attached. -- This message was sent by Atlassian Jira (v8.20.7#820007)
[jira] [Commented] (FELIX-6529) Improve memory usage ManifestParser using String deduplication
[ https://issues.apache.org/jira/browse/FELIX-6529?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17539842#comment-17539842 ] Karl Pauls commented on FELIX-6529: --- [~amitmondal]: I think you can just add it to your settings, something like: {noformat} apache.snapshots Apache Development Snapshot Repository https://repository.apache.org/content/repositories/snapshots/ false true {noformat} > Improve memory usage ManifestParser using String deduplication > -- > > Key: FELIX-6529 > URL: https://issues.apache.org/jira/browse/FELIX-6529 > Project: Felix > Issue Type: Improvement >Reporter: Johannes Edmeier >Assignee: Karl Pauls >Priority: Major > Fix For: framework-7.0.4 > > Attachments: ManifestParser.patch, image-2022-05-13-14-16-39-509.png, > image-2022-05-13-14-17-55-965.png > > > In my heap dump I've seen a lot of duplicate Strings produced by the > ManifestParser. > It creates a lot of equal strings for the keys in the manifest but doesn't > deduplicate them and they're hold forever producing a lot on retained heap. > I've patched the ManifestParser to deduplicate just the keys and could save > ~8 Megs of heap. > Total usage before: 38MB after: 30MB > Duplicated Strings before: > !image-2022-05-13-14-16-39-509.png|width=658,height=203! > Duplicated Strings after: > !image-2022-05-13-14-17-55-965.png|width=793,height=200! > See patch attached. -- This message was sent by Atlassian Jira (v8.20.7#820007)
[jira] [Commented] (FELIX-6529) Improve memory usage ManifestParser using String deduplication
[ https://issues.apache.org/jira/browse/FELIX-6529?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17539843#comment-17539843 ] Amit Mondal commented on FELIX-6529: [~karlpauls] Thanks a lot for your quick response (y) I didn't know about this remote repo URL where snapshots are deployed. Since I am using Bndtools, I will configure it accordingly to consume the snapshot version of the framework and give it a thorough test. I will keep you updated. > Improve memory usage ManifestParser using String deduplication > -- > > Key: FELIX-6529 > URL: https://issues.apache.org/jira/browse/FELIX-6529 > Project: Felix > Issue Type: Improvement >Reporter: Johannes Edmeier >Assignee: Karl Pauls >Priority: Major > Fix For: framework-7.0.4 > > Attachments: ManifestParser.patch, image-2022-05-13-14-16-39-509.png, > image-2022-05-13-14-17-55-965.png > > > In my heap dump I've seen a lot of duplicate Strings produced by the > ManifestParser. > It creates a lot of equal strings for the keys in the manifest but doesn't > deduplicate them and they're hold forever producing a lot on retained heap. > I've patched the ManifestParser to deduplicate just the keys and could save > ~8 Megs of heap. > Total usage before: 38MB after: 30MB > Duplicated Strings before: > !image-2022-05-13-14-16-39-509.png|width=658,height=203! > Duplicated Strings after: > !image-2022-05-13-14-17-55-965.png|width=793,height=200! > See patch attached. -- This message was sent by Atlassian Jira (v8.20.7#820007)
Re: [VOTE] Release Apache Felix Webconsole 4.8.2
+1 Carsten Am 19.05.2022 um 18:22 schrieb Carsten Ziegeler: Hi, We solved three issues https://issues.apache.org/jira/browse/FELIX-6531?jql=project%20%3D%20FELIX%20AND%20fixVersion%20%3D%20webconsole-4.8.2 Staging repository: https://repository.apache.org/content/repositories/orgapachefelix-1427 You can use this UNIX script to download the release and verify the signatures: https://github.com/apache/felix-dev/blob/master/check_staged_release.sh Usage: sh check_staged_release.sh 1427 /tmp/felix-staging Please vote to approve this release: [ ] +1 Approve the release [ ] -1 Veto the release (please provide specific comments) This vote will be open for 72 hours. Regards Carsten -- Carsten Ziegeler Adobe cziege...@apache.org