Re: [VOTE] Apache Felix Framework 7.0.4 and related subproject releases
+1 regards, Karl On Sat, May 21, 2022 at 2:29 PM Carsten Ziegeler wrote: > > +1 > > Carsten > > Am 20.05.2022 um 16:01 schrieb Karl Pauls: > > I would like to call a vote on the following subproject releases: > > > > framework 7.0.4 > > main 7.0.4 > > main.distribution 7.0.4 > > > > The main changelogs are in jira and at: > > https://github.com/apache/felix-dev/blob/org.apache.felix.framework-7.0.4/framework/doc/changelog.txt > > > > Staging repositories: > > https://repository.apache.org/content/repositories/orgapachefelix-1428/ > > https://repository.apache.org/content/repositories/orgapachefelix-1429/ > > > > You can use this UNIX script to download the release and verify the > > signatures: > > https://github.com/apache/felix-dev/blob/master/check_staged_release.sh > > > > Usage: > > sh check_staged_release.sh 1428 /tmp/felix-staging > > sh check_staged_release.sh 1429 /tmp/felix-staging > > > > Please vote to approve this release: > > > > [ ] +1 Approve the release > > [ ] -1 Veto the release (please provide specific comments) > > -- > Carsten Ziegeler > Adobe > cziege...@apache.org -- Karl Pauls karlpa...@gmail.com
Re: [VOTE] Release Apache Felix OSGi Feature Model 1.0.0
+1 Tom On Mon, May 23, 2022 at 10:12 AM wrote: > Hi all, > > I would like to call the release of the Felix implementation of the OSGi > Feature Model API. > This release was earlier released as RC-3 and now I would like to release > it as a proper 1.0.0 release. No changes have been made since. > > Staging repository: > https://repository.apache.org/content/repositories/orgapachefelix-1430 > > You can use this UNIX script to download the release and verify the > signatures: > https://github.com/apache/felix-dev/blob/master/check_staged_release.sh > > Usage: > sh check_staged_release.sh 1430 /tmp/felix-staging > > Please vote to approve this release: > > [ ] +1 Approve the release > [ ] -1 Veto the release (please provide specific comments) > > Best regards, > > David Bosschaert >
Re: [VOTE] Release Apache Felix OSGi Feature Model 1.0.0
+1 Carsten Am 23.05.2022 um 17:11 schrieb dav...@apache.org: Hi all, I would like to call the release of the Felix implementation of the OSGi Feature Model API. This release was earlier released as RC-3 and now I would like to release it as a proper 1.0.0 release. No changes have been made since. Staging repository: https://repository.apache.org/content/repositories/orgapachefelix-1430 You can use this UNIX script to download the release and verify the signatures: https://github.com/apache/felix-dev/blob/master/check_staged_release.sh Usage: sh check_staged_release.sh 1430 /tmp/felix-staging Please vote to approve this release: [ ] +1 Approve the release [ ] -1 Veto the release (please provide specific comments) Best regards, David Bosschaert -- Carsten Ziegeler Adobe cziege...@apache.org
Re: [VOTE] Release Apache Felix OSGi Feature Model 1.0.0
+1 On Mon., May 23, 2022, 11:12 a.m. , wrote: > Hi all, > > I would like to call the release of the Felix implementation of the OSGi > Feature Model API. > This release was earlier released as RC-3 and now I would like to release > it as a proper 1.0.0 release. No changes have been made since. > > Staging repository: > https://repository.apache.org/content/repositories/orgapachefelix-1430 > > You can use this UNIX script to download the release and verify the > signatures: > https://github.com/apache/felix-dev/blob/master/check_staged_release.sh > > Usage: > sh check_staged_release.sh 1430 /tmp/felix-staging > > Please vote to approve this release: > > [ ] +1 Approve the release > [ ] -1 Veto the release (please provide specific comments) > > Best regards, > > David Bosschaert >
[VOTE] Release Apache Felix OSGi Feature Model 1.0.0
Hi all, I would like to call the release of the Felix implementation of the OSGi Feature Model API. This release was earlier released as RC-3 and now I would like to release it as a proper 1.0.0 release. No changes have been made since. Staging repository: https://repository.apache.org/content/repositories/orgapachefelix-1430 You can use this UNIX script to download the release and verify the signatures: https://github.com/apache/felix-dev/blob/master/check_staged_release.sh Usage: sh check_staged_release.sh 1430 /tmp/felix-staging Please vote to approve this release: [ ] +1 Approve the release [ ] -1 Veto the release (please provide specific comments) Best regards, David Bosschaert
[jira] [Commented] (FELIX-6529) Improve memory usage ManifestParser using String deduplication
[ https://issues.apache.org/jira/browse/FELIX-6529?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17540913#comment-17540913 ] Amit Mondal commented on FELIX-6529: [~karlpauls] The duplicate strings I encountered earlier were scattered in different places in framework. With this change, a bit over few KBs are spared which I feel is a really good improvement. I will, therefore, try to look into the other places in the framework that can be improved as well by removing the duplicate strings. Hence, there is nothing to be done as of now in reference to this ticket. Thanks a lot for your cooperation (y) > Improve memory usage ManifestParser using String deduplication > -- > > Key: FELIX-6529 > URL: https://issues.apache.org/jira/browse/FELIX-6529 > Project: Felix > Issue Type: Improvement >Reporter: Johannes Edmeier >Assignee: Karl Pauls >Priority: Major > Fix For: framework-7.0.4 > > Attachments: ManifestParser.patch, image-2022-05-13-14-16-39-509.png, > image-2022-05-13-14-17-55-965.png > > > In my heap dump I've seen a lot of duplicate Strings produced by the > ManifestParser. > It creates a lot of equal strings for the keys in the manifest but doesn't > deduplicate them and they're hold forever producing a lot on retained heap. > I've patched the ManifestParser to deduplicate just the keys and could save > ~8 Megs of heap. > Total usage before: 38MB after: 30MB > Duplicated Strings before: > !image-2022-05-13-14-16-39-509.png|width=658,height=203! > Duplicated Strings after: > !image-2022-05-13-14-17-55-965.png|width=793,height=200! > See patch attached. -- This message was sent by Atlassian Jira (v8.20.7#820007)
[jira] [Commented] (FELIX-6529) Improve memory usage ManifestParser using String deduplication
[ https://issues.apache.org/jira/browse/FELIX-6529?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17540889#comment-17540889 ] Karl Pauls commented on FELIX-6529: --- [~amitmondal], I might be wrong, but I don't see these being related to keys anymore. Maybe you could help in finding out where they come from (looks like at a minimum quite some are parsed filters) and open a new issue(s) for further optimizations. Additionally, for this issue, I would still be interested in the overall impact. You said that just interning the keys did save you 8mb in your use-case. What did you save with this fix? > Improve memory usage ManifestParser using String deduplication > -- > > Key: FELIX-6529 > URL: https://issues.apache.org/jira/browse/FELIX-6529 > Project: Felix > Issue Type: Improvement >Reporter: Johannes Edmeier >Assignee: Karl Pauls >Priority: Major > Fix For: framework-7.0.4 > > Attachments: ManifestParser.patch, image-2022-05-13-14-16-39-509.png, > image-2022-05-13-14-17-55-965.png > > > In my heap dump I've seen a lot of duplicate Strings produced by the > ManifestParser. > It creates a lot of equal strings for the keys in the manifest but doesn't > deduplicate them and they're hold forever producing a lot on retained heap. > I've patched the ManifestParser to deduplicate just the keys and could save > ~8 Megs of heap. > Total usage before: 38MB after: 30MB > Duplicated Strings before: > !image-2022-05-13-14-16-39-509.png|width=658,height=203! > Duplicated Strings after: > !image-2022-05-13-14-17-55-965.png|width=793,height=200! > See patch attached. -- This message was sent by Atlassian Jira (v8.20.7#820007)
[jira] [Comment Edited] (FELIX-6529) Improve memory usage ManifestParser using String deduplication
[ https://issues.apache.org/jira/browse/FELIX-6529?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17540869#comment-17540869 ] Amit Mondal edited comment on FELIX-6529 at 5/23/22 9:59 AM: - [~karlpauls] I have just tested and analyzed the Framework 7.1.0-SNASHOT. Unfortunately, there still exist lots of different duplicate strings that originate from the Felix FW. For your further analysis, I have extracted the dominant ones in CSV files that include only the GC roots for the instances created in the FW. Here is the [link|https://amitinside-my.sharepoint.com/:u:/p/admin/EQ5xg7SFlgVNnVdFZUExOt8Bxxk1WCJl9AZMeirU-XMcTQ?e=6jXNBx] to download the ZIP file comprising the CSV files with the GC roots to the dominators. was (Author: amitmondal): [~karlpauls] I have just tested and analyzed the Framework 7.1.0-SNASHOT. Unfortunately, there exist still lots of different duplicate strings that originate from the Felix FW. For your further analysis, I have extracted the dominant ones in CSV files that include only the GC roots for the instances created in the FW. Here is the [link|https://amitinside-my.sharepoint.com/:u:/p/admin/EQ5xg7SFlgVNnVdFZUExOt8Bxxk1WCJl9AZMeirU-XMcTQ?e=6jXNBx] to download the ZIP file comprising the CSV files with the GC roots to the dominators. > Improve memory usage ManifestParser using String deduplication > -- > > Key: FELIX-6529 > URL: https://issues.apache.org/jira/browse/FELIX-6529 > Project: Felix > Issue Type: Improvement >Reporter: Johannes Edmeier >Assignee: Karl Pauls >Priority: Major > Fix For: framework-7.0.4 > > Attachments: ManifestParser.patch, image-2022-05-13-14-16-39-509.png, > image-2022-05-13-14-17-55-965.png > > > In my heap dump I've seen a lot of duplicate Strings produced by the > ManifestParser. > It creates a lot of equal strings for the keys in the manifest but doesn't > deduplicate them and they're hold forever producing a lot on retained heap. > I've patched the ManifestParser to deduplicate just the keys and could save > ~8 Megs of heap. > Total usage before: 38MB after: 30MB > Duplicated Strings before: > !image-2022-05-13-14-16-39-509.png|width=658,height=203! > Duplicated Strings after: > !image-2022-05-13-14-17-55-965.png|width=793,height=200! > See patch attached. -- This message was sent by Atlassian Jira (v8.20.7#820007)
[jira] [Comment Edited] (FELIX-6529) Improve memory usage ManifestParser using String deduplication
[ https://issues.apache.org/jira/browse/FELIX-6529?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17540869#comment-17540869 ] Amit Mondal edited comment on FELIX-6529 at 5/23/22 9:58 AM: - [~karlpauls] I have just tested and analyzed the Framework 7.1.0-SNASHOT. Unfortunately, there exist still lots of different duplicate strings that originate from the Felix FW. For your further analysis, I have extracted the dominant ones in CSV files that include only the GC roots for the instances created in the FW. Here is the [link|https://amitinside-my.sharepoint.com/:u:/p/admin/EQ5xg7SFlgVNnVdFZUExOt8Bxxk1WCJl9AZMeirU-XMcTQ?e=6jXNBx] to download the ZIP file comprising the CSV files with the GC roots to the dominators. was (Author: amitmondal): [~karlpauls] I have just tested and analyzed the Framework 7.1.0-SNASHOT. Unfortunately, there exist still lots of different duplicate strings that originate from the Felix FW. For your further analysis, I have extracted the dominant ones in CSV files that include only the GC roots for the instances created in the FW. Here is the [link|https://amitinside-my.sharepoint.com/:u:/p/admin/EQ5xg7SFlgVNnVdFZUExOt8Bxxk1WCJl9AZMeirU-XMcTQ?e=6jXNBx] to download the ZIP file comprising the CSV files with the GC roots to the dominators. > Improve memory usage ManifestParser using String deduplication > -- > > Key: FELIX-6529 > URL: https://issues.apache.org/jira/browse/FELIX-6529 > Project: Felix > Issue Type: Improvement >Reporter: Johannes Edmeier >Assignee: Karl Pauls >Priority: Major > Fix For: framework-7.0.4 > > Attachments: ManifestParser.patch, image-2022-05-13-14-16-39-509.png, > image-2022-05-13-14-17-55-965.png > > > In my heap dump I've seen a lot of duplicate Strings produced by the > ManifestParser. > It creates a lot of equal strings for the keys in the manifest but doesn't > deduplicate them and they're hold forever producing a lot on retained heap. > I've patched the ManifestParser to deduplicate just the keys and could save > ~8 Megs of heap. > Total usage before: 38MB after: 30MB > Duplicated Strings before: > !image-2022-05-13-14-16-39-509.png|width=658,height=203! > Duplicated Strings after: > !image-2022-05-13-14-17-55-965.png|width=793,height=200! > See patch attached. -- This message was sent by Atlassian Jira (v8.20.7#820007)
[jira] [Comment Edited] (FELIX-6529) Improve memory usage ManifestParser using String deduplication
[ https://issues.apache.org/jira/browse/FELIX-6529?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17540869#comment-17540869 ] Amit Mondal edited comment on FELIX-6529 at 5/23/22 9:58 AM: - [~karlpauls] I have just tested and analyzed the Framework 7.1.0-SNASHOT. Unfortunately, there exist still lots of different duplicate strings that originate from the Felix FW. For your further analysis, I have extracted the dominant ones in CSV files that include only the GC roots for the instances created in the FW. Here is the [link|https://amitinside-my.sharepoint.com/:u:/p/admin/EQ5xg7SFlgVNnVdFZUExOt8Bxxk1WCJl9AZMeirU-XMcTQ?e=6jXNBx] to download the ZIP file comprising the CSV files with the GC roots to the dominators. was (Author: amitmondal): [~karlpauls] I have just tested and analyzed the Framework 7.1.0-SNASHOT. Unfortunately, there exist still lots of different duplicate strings that originate from the Felix FW. For your further analysis, I have extracted the dominant ones in CSV files that include only the GC roots for the instances created in the FW. Here is the [link|https://amitinside-my.sharepoint.com/:u:/p/admin/EQ5xg7SFlgVNnVdFZUExOt8Bxxk1WCJl9AZMeirU-XMcTQ?e=6jXNBx] to download the ZIP file comprising the CSV files with the GC roots to the dominators. > Improve memory usage ManifestParser using String deduplication > -- > > Key: FELIX-6529 > URL: https://issues.apache.org/jira/browse/FELIX-6529 > Project: Felix > Issue Type: Improvement >Reporter: Johannes Edmeier >Assignee: Karl Pauls >Priority: Major > Fix For: framework-7.0.4 > > Attachments: ManifestParser.patch, image-2022-05-13-14-16-39-509.png, > image-2022-05-13-14-17-55-965.png > > > In my heap dump I've seen a lot of duplicate Strings produced by the > ManifestParser. > It creates a lot of equal strings for the keys in the manifest but doesn't > deduplicate them and they're hold forever producing a lot on retained heap. > I've patched the ManifestParser to deduplicate just the keys and could save > ~8 Megs of heap. > Total usage before: 38MB after: 30MB > Duplicated Strings before: > !image-2022-05-13-14-16-39-509.png|width=658,height=203! > Duplicated Strings after: > !image-2022-05-13-14-17-55-965.png|width=793,height=200! > See patch attached. -- This message was sent by Atlassian Jira (v8.20.7#820007)
[jira] [Commented] (FELIX-6529) Improve memory usage ManifestParser using String deduplication
[ https://issues.apache.org/jira/browse/FELIX-6529?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17540869#comment-17540869 ] Amit Mondal commented on FELIX-6529: [~karlpauls] I have just tested and analyzed the Framework 7.1.0-SNASHOT. Unfortunately, there exist still lots of different duplicate strings that originate from the Felix FW. For your further analysis, I have extracted the dominant ones in CSV files that include only the GC roots for the instances created in the FW. Here is the [link|https://amitinside-my.sharepoint.com/:u:/p/admin/EQ5xg7SFlgVNnVdFZUExOt8Bxxk1WCJl9AZMeirU-XMcTQ?e=6jXNBx] to download the ZIP file comprising the CSV files with the GC roots to the dominators. > Improve memory usage ManifestParser using String deduplication > -- > > Key: FELIX-6529 > URL: https://issues.apache.org/jira/browse/FELIX-6529 > Project: Felix > Issue Type: Improvement >Reporter: Johannes Edmeier >Assignee: Karl Pauls >Priority: Major > Fix For: framework-7.0.4 > > Attachments: ManifestParser.patch, image-2022-05-13-14-16-39-509.png, > image-2022-05-13-14-17-55-965.png > > > In my heap dump I've seen a lot of duplicate Strings produced by the > ManifestParser. > It creates a lot of equal strings for the keys in the manifest but doesn't > deduplicate them and they're hold forever producing a lot on retained heap. > I've patched the ManifestParser to deduplicate just the keys and could save > ~8 Megs of heap. > Total usage before: 38MB after: 30MB > Duplicated Strings before: > !image-2022-05-13-14-16-39-509.png|width=658,height=203! > Duplicated Strings after: > !image-2022-05-13-14-17-55-965.png|width=793,height=200! > See patch attached. -- This message was sent by Atlassian Jira (v8.20.7#820007)
[jira] [Updated] (FELIX-6533) Felix released as milestone version cannot parse it's own version id
[ https://issues.apache.org/jira/browse/FELIX-6533?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] David Matějček updated FELIX-6533: -- Description: We tried to prerelease a custom built version for GlassFish, but it it not able to start now. The version id was 7.0.4-omnifish-M1; Felix changed it to 7.0.4.omnifish.M1 on startup and then crashed, because dots are not allowed in classifier. h3. Cause I found that it tries to "cleanup" the Maven version, but does it wrong and then tries to parse the result again which fails. *Solution* I am creating PR right after this issue. Felix already has the correct implementation usable for this, so I just moved it to the new VersionConverter class, updated all references and also extended tests. It is backward compatible despite the bit of refactoring. was: We tried to prerelease a custom built version for GlassFish, but it it not able to start now. The version id was 7.0.4-omnifish-M1; Felix changed it to 7.0.4.omnifish.M1 on startup and then crashed, because dots are not allowed in classifier. h3. Cause I found that it tries to "cleanup" the Maven version, but does it wrong and then tries to parse the result again which fails. *Solution* I am creating PR right after this issue. Felix already has the correct implementation usable for this, so I just moved it to the Version class (which seems to be a natural place for this), updated all references and also extended tests. It is backward compatible despite the bit of refactoring. > Felix released as milestone version cannot parse it's own version id > > > Key: FELIX-6533 > URL: https://issues.apache.org/jira/browse/FELIX-6533 > Project: Felix > Issue Type: Bug > Components: Framework >Affects Versions: framework-7.0.3 >Reporter: David Matějček >Assignee: Karl Pauls >Priority: Blocker > Labels: patch-available, patch-with-test > Fix For: framework-7.0.4 > > Original Estimate: 4h > Remaining Estimate: 4h > > We tried to prerelease a custom built version for GlassFish, but it it not > able to start now. The version id was 7.0.4-omnifish-M1; Felix changed it to > 7.0.4.omnifish.M1 on startup and then crashed, because dots are not allowed > in classifier. > h3. Cause > I found that it tries to "cleanup" the Maven version, but does it wrong and > then tries to parse the result again which fails. > *Solution* > I am creating PR right after this issue. Felix already has the correct > implementation usable for this, so I just moved it to the new > VersionConverter class, updated all references and also extended tests. It is > backward compatible despite the bit of refactoring. -- This message was sent by Atlassian Jira (v8.20.7#820007)
