[GitHub] [felix-atomos] tjwatson commented on pull request #70: add handling for running build on Windows

2022-09-22 Thread GitBox


tjwatson commented on PR #70:
URL: https://github.com/apache/felix-atomos/pull/70#issuecomment-1255393639

   One thing we are missing in our actions flow is to run native builds.  We 
used to have that bug Apache stopped us from running the 3rd party action.  I 
think there is now a more official one available to running substrate native 
builds.  Probably would be good to try and see if we can add that back.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@felix.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



[GitHub] [felix-atomos] fipro78 opened a new pull request, #70: add handling for running build on Windows

2022-09-22 Thread GitBox


fipro78 opened a new pull request, #70:
URL: https://github.com/apache/felix-atomos/pull/70

   fixes #69 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@felix.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



[GitHub] [felix-atomos] tjwatson commented on issue #67: Error and Exception in log with substrate and Equinox

2022-09-22 Thread GitBox


tjwatson commented on issue #67:
URL: https://github.com/apache/felix-atomos/issues/67#issuecomment-1255230015

   ```
   com.oracle.svm.core.jdk.UnsupportedFeatureError: Setting a custom 
URLStreamHandlerFactory.
   ```
   This I think is expected because native substrate does not support custom 
URL handlers.  I'm not sure what the second exception is about with SCR
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@felix.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



[GitHub] [felix-atomos] tjwatson commented on issue #68: Different behavior on building a substrate from commandline or via maven

2022-09-22 Thread GitBox


tjwatson commented on issue #68:
URL: https://github.com/apache/felix-atomos/issues/68#issuecomment-1255219884

   That line withthe NPE is:
   
   ```java
byte[] bytes = 
StorageUtil.getBytes(MultiplexingFactory.class.getResource("SetAccessible.bytes").openStream(),
 -1, 4000); //$NON-NLS-1$
   ```
   
   It appears the `SetAccessible.bytes` resource isn't included.  The 
`org.eclipse.osgi` JAR should have a file 
`META-INF/native-image/resource-config.json`.  This file 
`{"pattern":"org/eclipse/osgi/internal/url/SetAccessible.bytes"}` which should 
cause the resource to be included.  Regardless, IIRC URL handlers in substrate 
are not supportable because they do not let any other protocols be enabled 
besides what they build into the executable.  So this error is benign.  It is a 
print stacktrace from where we catch all exceptions in 
`MultiplexingFactory.`


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@felix.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



[GitHub] [felix-atomos] tjwatson commented on issue #66: Build fails with Java 17

2022-09-22 Thread GitBox


tjwatson commented on issue #66:
URL: https://github.com/apache/felix-atomos/issues/66#issuecomment-1255210292

   I believe this is because of the felix-dev parent pom we use that has:
   
   ```
   
   org.codehaus.mojo
   ianal-maven-plugin
   1.0-alpha-1
   
   ```
   
   That plugin looks completely unmantained.  No real release, only this 
alpha-1 from 2008!  @karlpauls Why does the felix parent pom use this 
unmaintained plugin?  
https://github.com/apache/felix-dev/blob/master/pom/pom.xml


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@felix.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



[jira] [Commented] (FELIX-6470) ConfigAdmin/Coordinator handling not Spec-complient

2022-09-22 Thread A. J. David Bosschaert (Jira)


[ 
https://issues.apache.org/jira/browse/FELIX-6470?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17608315#comment-17608315
 ] 

A. J. David Bosschaert commented on FELIX-6470:
---

Thanks [~bisch...@jena.de] I added the failing test here: 
https://github.com/apache/felix-dev/pull/174

> ConfigAdmin/Coordinator handling not Spec-complient
> ---
>
> Key: FELIX-6470
> URL: https://issues.apache.org/jira/browse/FELIX-6470
> Project: Felix
>  Issue Type: Bug
>  Components: Configuration Admin
>Affects Versions: configadmin-1.9.22
>Reporter: Stefan Bischof
>Priority: Major
>
> The ConfigAdmin in combination with the Coordinator does not correctly 
> deliver existing Configuration to later registered ManagedService.
> A Test could be found here.
> https://github.com/osgi/osgi/pull/343



--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[jira] [Commented] (FELIX-6470) ConfigAdmin/Coordinator handling not Spec-complient

2022-09-22 Thread Stefan Bischof (Jira)


[ 
https://issues.apache.org/jira/browse/FELIX-6470?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17608294#comment-17608294
 ] 

Stefan Bischof commented on FELIX-6470:
---

Please feel free to copy the test to apache felix

 

> ConfigAdmin/Coordinator handling not Spec-complient
> ---
>
> Key: FELIX-6470
> URL: https://issues.apache.org/jira/browse/FELIX-6470
> Project: Felix
>  Issue Type: Bug
>  Components: Configuration Admin
>Affects Versions: configadmin-1.9.22
>Reporter: Stefan Bischof
>Priority: Major
>
> The ConfigAdmin in combination with the Coordinator does not correctly 
> deliver existing Configuration to later registered ManagedService.
> A Test could be found here.
> https://github.com/osgi/osgi/pull/343



--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[GitHub] [felix-atomos] fipro78 opened a new issue, #69: atomos-maven-plugin fails when building on Windows

2022-09-22 Thread GitBox


fipro78 opened a new issue, #69:
URL: https://github.com/apache/felix-atomos/issues/69

   I tried to run the atomos build on Windows. This is not possible because of 
several reasons:
   
   1. the native-image executable file is native-image.cmd. As it is tried to 
check if the native-image feature is installed by checking for the file, the 
check fails because the filename is not complete
   2. the filename issue also exists for checking the result, which is an .exe 
file
   3. the classpath delimiter on Windows is a ";" while on Linux it is a ":"
   
   I will provide a patch for this.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@felix.apache.org.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



[GitHub] [felix-atomos] fipro78 opened a new issue, #68: Different behavior on building a substrate from commandline or via maven

2022-09-22 Thread GitBox


fipro78 opened a new issue, #68:
URL: https://github.com/apache/felix-atomos/issues/68

   I am trying to create a Graal Substrate for deployment in a Docker 
container. As the result matches the host system, I suppose I have to create 
the substrate in a container with the target OS. So I would like to create the 
substrate image via command line. If I build via commandline with the same 
instuction as with the maven plugin, starting the application shows the 
following error:
   
   ```
   java.lang.NullPointerException
   at 
org.eclipse.osgi.internal.url.MultiplexingFactory.(MultiplexingFactory.java:69)
   at 
org.eclipse.osgi.storage.FrameworkExtensionInstaller.findAddURLMethod(FrameworkExtensionInstaller.java:62)
   at 
org.eclipse.osgi.storage.FrameworkExtensionInstaller.(FrameworkExtensionInstaller.java:55)
   at org.eclipse.osgi.storage.Storage.(Storage.java:222)
   at org.eclipse.osgi.storage.Storage.createStorage(Storage.java:184)
   at 
org.eclipse.osgi.internal.framework.EquinoxContainer.(EquinoxContainer.java:108)
   at org.eclipse.osgi.launch.Equinox.(Equinox.java:53)
   at 
org.eclipse.osgi.launch.EquinoxFactory.newFramework(EquinoxFactory.java:35)
   at 
org.apache.felix.atomos.impl.base.AtomosBase.newFramework(AtomosBase.java:442)
   at org.apache.felix.atomos.Atomos.main(Atomos.java:236)
   g! Warning: NLS missing message: EVENT_ASYNC_THREAD_NAME in: 
org.eclipse.equinox.internal.event.ExternalMessages
   Warning: NLS missing message: EVENT_NULL_EVENT in: 
org.eclipse.equinox.internal.event.ExternalMessages
   Warning: NLS missing message: EVENT_NO_TOPICPERMISSION_PUBLISH in: 
org.eclipse.equinox.internal.event.ExternalMessages
   Warning: NLS missing message: EVENT_DISPATCH_HANDLER_EXCEPTION in: 
org.eclipse.equinox.internal.event.ExternalMessages
   Warning: NLS missing message: EVENT_INVALID_HANDLER_FILTER in: 
org.eclipse.equinox.internal.event.ExternalMessages
   Warning: NLS missing message: EVENT_INVALID_HANDLER_TOPICS in: 
org.eclipse.equinox.internal.event.ExternalMessages
   ```
   
   Apart from that everything seems to work.
   
   Building with the maven plugin like the substrate.lib example, this error 
does not show up.
   Do you know by any chance what needs to be added to the build to get rid of 
this error on commandline build?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@felix.apache.org.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



[GitHub] [felix-atomos] fipro78 opened a new issue, #67: Error and Exception in log with substrate and Equinox

2022-09-22 Thread GitBox


fipro78 opened a new issue, #67:
URL: https://github.com/apache/felix-atomos/issues/67

   I am trying to build an executable using GraalVM from an OSGi application, 
similar to the Atomos examples. But starting the application I see errors and 
exceptions in the log. The application works, but I wonder if the errors could 
make problems later.
   At least the "exit" command is not known, so it is not possible to exit the 
application via command.
   
   ```
   !ENTRY org.eclipse.osgi 4 0 2022-09-22 15:17:12.666
   !MESSAGE Setting a custom URLStreamHandlerFactory.
   !STACK 0
   com.oracle.svm.core.jdk.UnsupportedFeatureError: Setting a custom 
URLStreamHandlerFactory.
at com.oracle.svm.core.util.VMError.unsupportedFeature(VMError.java:89)
at java.net.URL.setURLStreamHandlerFactory(URL.java:85)
at 
org.eclipse.osgi.internal.url.EquinoxFactoryManager.forceURLStreamHandlerFactory(EquinoxFactoryManager.java:90)
at 
org.eclipse.osgi.internal.url.EquinoxFactoryManager.installURLStreamHandlerFactory(EquinoxFactoryManager.java:52)
at 
org.eclipse.osgi.internal.url.EquinoxFactoryManager.installHandlerFactories(EquinoxFactoryManager.java:40)
at 
org.eclipse.osgi.internal.framework.SystemBundleActivator.start(SystemBundleActivator.java:75)
at 
org.eclipse.osgi.internal.framework.BundleContextImpl$2.run(BundleContextImpl.java:813)
at 
org.eclipse.osgi.internal.framework.BundleContextImpl$2.run(BundleContextImpl.java:1)
at 
java.security.AccessController.executePrivileged(AccessController.java:145)
at java.security.AccessController.doPrivileged(AccessController.java:98)
at 
org.eclipse.osgi.internal.framework.BundleContextImpl.startActivator(BundleContextImpl.java:805)
at 
org.eclipse.osgi.internal.framework.BundleContextImpl.start(BundleContextImpl.java:762)
at 
org.eclipse.osgi.internal.framework.EquinoxBundle.startWorker0(EquinoxBundle.java:1032)
at 
org.eclipse.osgi.internal.framework.EquinoxBundle$SystemBundle$EquinoxSystemModule.initWorker(EquinoxBundle.java:203)
at org.eclipse.osgi.container.SystemModule.init(SystemModule.java:99)
at org.eclipse.osgi.container.SystemModule.start(SystemModule.java:191)
at 
org.eclipse.osgi.internal.framework.EquinoxBundle.start(EquinoxBundle.java:445)
at 
org.eclipse.osgi.internal.framework.EquinoxBundle.start(EquinoxBundle.java:464)
at org.eclipse.osgi.launch.Equinox.start(Equinox.java:139)
at org.apache.felix.atomos.Atomos.main(Atomos.java:237)
   ```
   
   ```
   !ENTRY org.apache.felix.scr 4 0 2022-09-22 15:17:12.690
   !MESSAGE bundle org.apache.felix.scr:2.1.26 (14) Exception starting during 
restart
   !STACK 0
   java.lang.IllegalArgumentException: Interface(s) not visible to the provided 
class loader: 
org.eclipse.osgi.internal.connect.DelegatingConnectClassLoader@71c1e19f[org.apache.felix.gogo.runtime:1.1.2(id=8)],
 child of jdk.internal.loader.ClassLoaders$PlatformClassLoader@7c804f13, child 
of null; interface org.apache.felix.service.command.Converter loaded by 
jdk.internal.loader.ClassLoaders$AppClassLoader@233c0b17, child of 
jdk.internal.loader.ClassLoaders$PlatformClassLoader@7c804f13, child of null
at 
com.oracle.svm.reflect.proxy.DynamicProxySupport.incompatibleClassLoaders(DynamicProxySupport.java:210)
at 
com.oracle.svm.reflect.proxy.DynamicProxySupport.getProxyClass(DynamicProxySupport.java:191)
at java.lang.reflect.Proxy.getProxyConstructor(Proxy.java:48)
at java.lang.reflect.Proxy.newProxyInstance(Proxy.java:1006)
at 
org.apache.felix.scr.impl.ComponentCommands.createConverter(ComponentCommands.java:619)
at 
org.apache.felix.scr.impl.ComponentCommands.addingService(ComponentCommands.java:596)
at 
org.apache.felix.scr.impl.ComponentCommands.addingService(ComponentCommands.java:65)
at 
org.osgi.util.tracker.ServiceTracker$Tracked.customizerAdding(ServiceTracker.java:943)
at 
org.osgi.util.tracker.ServiceTracker$Tracked.customizerAdding(ServiceTracker.java:1)
at 
org.osgi.util.tracker.AbstractTracked.trackAdding(AbstractTracked.java:256)
at 
org.osgi.util.tracker.AbstractTracked.trackInitial(AbstractTracked.java:183)
at org.osgi.util.tracker.ServiceTracker.open(ServiceTracker.java:321)
at 
org.apache.felix.scr.impl.ComponentCommands.register(ComponentCommands.java:113)
at org.apache.felix.scr.impl.Activator.doStart(Activator.java:200)
at 
org.apache.felix.scr.impl.AbstractExtender.start(AbstractExtender.java:72)
at org.apache.felix.scr.impl.Activator.restart(Activator.java:164)
at 
org.apache.felix.scr.impl.config.ScrConfigurationImpl.configure(ScrConfigurationImpl.java:228)
at 
org.apache.felix.scr.impl.config.ScrConfigurationImpl.start(ScrConfigurationImpl.java:123)
at org.apache.felix.scr.impl.Activator.start(Activator.java:121)
at 

[GitHub] [felix-atomos] fipro78 opened a new issue, #66: Build fails with Java 17

2022-09-22 Thread GitBox


fipro78 opened a new issue, #66:
URL: https://github.com/apache/felix-atomos/issues/66

   If I try to build atomos locally using a Java 17, the build fails with this 
error:
   
   `[ERROR] Failed to execute goal 
org.codehaus.mojo:ianal-maven-plugin:1.0-alpha-1:verify-legal-files (default) 
on project osgi.core: Execution default of goal 
org.codehaus.mojo:ianal-maven-plugin:1.0-alpha-1:verify-legal-files failed: 
Unable to make private java.io.File(java.lang.String,java.io.File) accessible: 
module java.base does not "opens java.io" to unnamed module @627d5f99`
   
   Not sure if and how this can be fixed. Running the build using Java 11 works.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@felix.apache.org.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org