Re: Retiring http/cometd and http/bundle
+1 Regards JB On Thu, Oct 13, 2022 at 9:37 AM Carsten Ziegeler wrote: > > Hi, > > both modules http/cometd and http/bundle haven't been updated or > released for years. > > I think its time to retire them and remove from the main branch. > If interest picks up again we can easily restore it from history > > Regards > Carsten > -- > Carsten Ziegeler > Adobe > cziege...@apache.org
Re: Retiring http/cometd and http/bundle
+1 On Thu, Oct 13, 2022 at 4:44 AM Rob Walker wrote: > +1 > > We've long since moved on to the newer/current bundle > > --- > Rob Walker > > -Original Message- > From: Karl Pauls > Sent: 13 October 2022 09:20 > To: dev@felix.apache.org > Subject: Re: Retiring http/cometd and http/bundle > > +1 > > regards, > > Karl > > On Thu, Oct 13, 2022 at 9:38 AM Carsten Ziegeler > wrote: > > > Hi, > > > > both modules http/cometd and http/bundle haven't been updated or > > released for years. > > > > I think its time to retire them and remove from the main branch. > > If interest picks up again we can easily restore it from history > > > > Regards > > Carsten > > -- > > Carsten Ziegeler > > Adobe > > cziege...@apache.org > > > > > -- > Karl Pauls > karlpa...@gmail.com > -- *Raymond Augé* (@rotty3000) Senior Software Architect *Liferay, Inc.* (@Liferay) OSGi Fellow, Java Champion
RE: Retiring http/cometd and http/bundle
+1 We've long since moved on to the newer/current bundle --- Rob Walker -Original Message- From: Karl Pauls Sent: 13 October 2022 09:20 To: dev@felix.apache.org Subject: Re: Retiring http/cometd and http/bundle +1 regards, Karl On Thu, Oct 13, 2022 at 9:38 AM Carsten Ziegeler wrote: > Hi, > > both modules http/cometd and http/bundle haven't been updated or > released for years. > > I think its time to retire them and remove from the main branch. > If interest picks up again we can easily restore it from history > > Regards > Carsten > -- > Carsten Ziegeler > Adobe > cziege...@apache.org > -- Karl Pauls karlpa...@gmail.com
Re: Retiring http/cometd and http/bundle
+1 regards, Karl On Thu, Oct 13, 2022 at 9:38 AM Carsten Ziegeler wrote: > Hi, > > both modules http/cometd and http/bundle haven't been updated or > released for years. > > I think its time to retire them and remove from the main branch. > If interest picks up again we can easily restore it from history > > Regards > Carsten > -- > Carsten Ziegeler > Adobe > cziege...@apache.org > -- Karl Pauls karlpa...@gmail.com
Retiring http/cometd and http/bundle
Hi, both modules http/cometd and http/bundle haven't been updated or released for years. I think its time to retire them and remove from the main branch. If interest picks up again we can easily restore it from history Regards Carsten -- Carsten Ziegeler Adobe cziege...@apache.org
[GitHub] [felix-dev] dependabot[bot] commented on pull request #141: Bump commons-io from 2.6 to 2.7 in /http/bridge-4.x
dependabot[bot] commented on PR #141: URL: https://github.com/apache/felix-dev/pull/141#issuecomment-1277161551 OK, I won't notify you again about this release, but will get in touch when a new version is available. If you'd rather skip all updates until the next major or minor version, let me know by commenting `@dependabot ignore this major version` or `@dependabot ignore this minor version`. If you change your mind, just re-open this PR and I'll resolve any conflicts on it. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@felix.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [felix-dev] cziegeler closed pull request #141: Bump commons-io from 2.6 to 2.7 in /http/bridge-4.x
cziegeler closed pull request #141: Bump commons-io from 2.6 to 2.7 in /http/bridge-4.x URL: https://github.com/apache/felix-dev/pull/141 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@felix.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [felix-dev] dependabot[bot] commented on pull request #141: Bump commons-io from 2.6 to 2.7 in /http/bridge-4.x
dependabot[bot] commented on PR #141: URL: https://github.com/apache/felix-dev/pull/141#issuecomment-1277160354 Dependabot tried to update this pull request, but something went wrong. We're looking into it, but in the meantime you can retry the update by commenting `@dependabot rebase`. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@felix.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [felix-dev] sagarmiglani commented on a diff in pull request #177: FELIX-6570 - Components webconsole-plugin shows password in clear text
sagarmiglani commented on code in PR #177:
URL: https://github.com/apache/felix-dev/pull/177#discussion_r994247150
##
webconsole-plugins/ds/src/main/java/org/apache/felix/webconsole/plugins/ds/internal/ConfigurationSupport.java:
##
@@ -73,4 +75,16 @@ public boolean isConfigurable(final Bundle providingBundle,
final String pid)
}
return false;
}
+
+/**
+ * Returns a Collection of IDs of Password Attributes Definitions for
given bundle and configuration PIDs
+ * @param bundle The Bundle providing the component
+ * @param configurationPids A non-null configuration pid
+ * @return Collection
+ */
+public Collection getPasswordAttributeDefinitionIds(final Bundle
bundle, final String[] configurationPids) {
+Object metaTypeService = this.metatypeTracker.getService();
+return new
MetatypeSupport().getPasswordAttributeDefinitionIds(metaTypeService, bundle,
configurationPids);
Review Comment:
Thanks Carsten, added the new commit, please review the latest state.
##
webconsole-plugins/ds/src/main/java/org/apache/felix/webconsole/plugins/ds/internal/ConfigurationSupport.java:
##
@@ -73,4 +75,16 @@ public boolean isConfigurable(final Bundle providingBundle,
final String pid)
}
return false;
}
+
+/**
+ * Returns a Collection of IDs of Password Attributes Definitions for
given bundle and configuration PIDs
+ * @param bundle The Bundle providing the component
+ * @param configurationPids A non-null configuration pid
+ * @return Collection
+ */
+public Collection getPasswordAttributeDefinitionIds(final Bundle
bundle, final String[] configurationPids) {
+Object metaTypeService = this.metatypeTracker.getService();
+return new
MetatypeSupport().getPasswordAttributeDefinitionIds(metaTypeService, bundle,
configurationPids);
Review Comment:
Thanks @cziegeler, added the new commit, please review the latest state.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscr...@felix.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [felix-dev] cziegeler merged pull request #177: FELIX-6570 - Components webconsole-plugin shows password in clear text
cziegeler merged PR #177: URL: https://github.com/apache/felix-dev/pull/177 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@felix.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [felix-dev] cziegeler commented on a diff in pull request #177: FELIX-6570 - Components webconsole-plugin shows password in clear text
cziegeler commented on code in PR #177:
URL: https://github.com/apache/felix-dev/pull/177#discussion_r994232080
##
webconsole-plugins/ds/src/main/java/org/apache/felix/webconsole/plugins/ds/internal/ConfigurationSupport.java:
##
@@ -73,4 +75,16 @@ public boolean isConfigurable(final Bundle providingBundle,
final String pid)
}
return false;
}
+
+/**
+ * Returns a Collection of IDs of Password Attributes Definitions for
given bundle and configuration PIDs
+ * @param bundle The Bundle providing the component
+ * @param configurationPids A non-null configuration pid
+ * @return Collection
+ */
+public Collection getPasswordAttributeDefinitionIds(final Bundle
bundle, final String[] configurationPids) {
+Object metaTypeService = this.metatypeTracker.getService();
+return new
MetatypeSupport().getPasswordAttributeDefinitionIds(metaTypeService, bundle,
configurationPids);
Review Comment:
I think its better to first check metaTypeService for null and only if not
null call MetatypeSupport
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscr...@felix.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[jira] [Commented] (FELIX-6570) Components webconsole-plugin shows password in clear text
[
https://issues.apache.org/jira/browse/FELIX-6570?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17616801#comment-17616801
]
Sagar Miglani commented on FELIX-6570:
--
[~cziegeler] [~laeubi] Thanks for the suggestions.
Even if we use a private property (name starting with a '.'), webconsole is
showing that property with its value in clear text.
Created a PR: [https://github.com/apache/felix-dev/pull/177] (attempted to
incorporate Carsten's suggestions) which *uses metatype hint* and *hides the
value* of Password properties. Should I also hide the private property?
> Components webconsole-plugin shows password in clear text
> -
>
> Key: FELIX-6570
> URL: https://issues.apache.org/jira/browse/FELIX-6570
> Project: Felix
> Issue Type: Bug
> Components: Web Console
>Affects Versions: webconsole-ds-plugin-2.1.0
>Reporter: Sagar Miglani
>Priority: Major
> Attachments: Screenshot 2022-05-09 at 4.48.42 PM.png,
> webconsole-plugins.patch
>
>
> Open a component details page (eg:
> localhost:8080/system/console/components/${componentId}) for a component with
> a Password Property.
> Passwords are shown in clear text. [^Screenshot 2022-05-09 at 4.48.42 PM.png]
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
