[GitHub] [felix-dev] cziegeler commented on pull request #212: FELIX-6614 WebConsole configMgr saves an empty value in list properites
cziegeler commented on PR #212: URL: https://github.com/apache/felix-dev/pull/212#issuecomment-1623091773 Let's not put too many changes into this single issue. The most important part is to avoid saving the empty value. So I suggest, we keep the add/delete buttons after each field. And if there is no value yet, only display the add button -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@felix.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [felix-dev] kwin commented on pull request #212: FELIX-6614 WebConsole configMgr saves an empty value in list properites
kwin commented on PR #212: URL: https://github.com/apache/felix-dev/pull/212#issuecomment-1623038983 I think the best UX would be - one delete button per item - one add button per list - possibility to reorder (maybe leveraging https://jqueryui.com/draggable/#sortable) The "+" per item is very uncommon and is IMHO not needed if there is a possibility to reorder. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@felix.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [felix-dev] kwin commented on pull request #212: FELIX-6614 WebConsole configMgr saves an empty value in list properites
kwin commented on PR #212: URL: https://github.com/apache/felix-dev/pull/212#issuecomment-1623035491 @cziegeler Can you have a look? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@felix.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [felix-dev] cziegeler commented on pull request #212: FELIX-6614 WebConsole configMgr saves an empty value in list properites
cziegeler commented on PR #212: URL: https://github.com/apache/felix-dev/pull/212#issuecomment-1623035482 The new "add" button is now displayed for every list property. Shouldn't it only be displayed if there is no value yet?  -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@felix.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [felix-dev] kwin commented on a diff in pull request #212: FELIX-6614 WebConsole configMgr saves an empty value in list properites
kwin commented on code in PR #212:
URL: https://github.com/apache/felix-dev/pull/212#discussion_r1253967553
##
webconsole/src/main/resources/res/ui/config.js:
##
@@ -348,6 +349,25 @@ function printConfigurationInfo( /* Element */ parent, obj
)
var spanCounter = 0;
+/* Element */ function createAddButton(prop) {
+spanCounter++;
+var newId = prop + spanCounter;
+
+var addButton = createElement("input", null,
Review Comment:
maybe one could reuse the same code here and in createSpan(...) to reduce
duplication.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscr...@felix.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Re: [VOTE] Release Apache Felix HC Generalchecks 3.0.6
+1 regards, Karl On Wed, Jul 5, 2023 at 9:31 PM arnoud wrote: > > +1 > > Thanks Carsten! > > Best regards, > > Arnoud Glimmerveen > > > On 5 Jul 2023, at 11:21, Carsten Ziegeler wrote: > > > > Hi, > > > > We solved one issue > > https://issues.apache.org/jira/browse/FELIX-6613 > > > > Staging repository: > > https://repository.apache.org/content/repositories/orgapachefelix-1461/ > > > > You can use this UNIX script to download the release and verify the > > signatures: > > https://github.com/apache/felix-dev/blob/master/check_staged_release.sh > > > > Usage: > > sh check_staged_release.sh 1461 /tmp/felix-staging > > > > Please vote to approve this release: > > > > [ ] +1 Approve the release > > [ ] -1 Veto the release (please provide specific comments) > > > > This vote will be open for 72 hours. > > > > Regards > > Carsten > > -- > > Carsten Ziegeler > > Adobe > > cziege...@apache.org > -- Karl Pauls karlpa...@gmail.com
Re: [VOTE] Release Apache Felix HC Generalchecks 3.0.6
+1 Thanks Carsten! Best regards, Arnoud Glimmerveen > On 5 Jul 2023, at 11:21, Carsten Ziegeler wrote: > > Hi, > > We solved one issue > https://issues.apache.org/jira/browse/FELIX-6613 > > Staging repository: > https://repository.apache.org/content/repositories/orgapachefelix-1461/ > > You can use this UNIX script to download the release and verify the > signatures: > https://github.com/apache/felix-dev/blob/master/check_staged_release.sh > > Usage: > sh check_staged_release.sh 1461 /tmp/felix-staging > > Please vote to approve this release: > > [ ] +1 Approve the release > [ ] -1 Veto the release (please provide specific comments) > > This vote will be open for 72 hours. > > Regards > Carsten > -- > Carsten Ziegeler > Adobe > cziege...@apache.org
[jira] [Created] (FELIX-6615) org.osgi.framework.ServiceException: Service factory returned null.
XIAOMING ZHAO created FELIX-6615:
Summary: org.osgi.framework.ServiceException: Service factory
returned null.
Key: FELIX-6615
URL: https://issues.apache.org/jira/browse/FELIX-6615
Project: Felix
Issue Type: Bug
Components: Felix Commons
Reporter: XIAOMING ZHAO
We just upgraded the ASR to a recent new version, but get the following errors.
the same application code in previous version, we didn't see the following
exception in felix.log, Would you please help?
@Component(property =
{"jmx.objectname=" + PrometheusMetricsService.SERVICE_NAME,
OSGI_TYPE_PROPERTY + "=" + METRICS_SERVICE_PROMETHEUS},
immediate = true)
public final class PrometheusMetricsService extends ServiceMBeanSupport
implements MetricsService
Exception in felix.log during starting:
ERROR - 2023-07-05 11:30:54,475 - FelixDispatchQueue - Got Framework error
event: bundle=.common
org.osgi.framework.ServiceException: Service factory returned null. (Component:
##.prometheus.services.PrometheusMetricsService (101))
at
org.apache.felix.framework.ServiceRegistrationImpl.getFactoryUnchecked(ServiceRegistrationImpl.java:385)
at
org.apache.felix.framework.ServiceRegistrationImpl.getService(ServiceRegistrationImpl.java:249)
at
org.apache.felix.framework.ServiceRegistry.getService(ServiceRegistry.java:362)
at org.apache.felix.framework.Felix.getService(Felix.java:3984)
at
org.apache.felix.framework.BundleContextImpl.getService(BundleContextImpl.java:450)
at
org.apache.felix.scr.impl.manager.SingleRefPair.getServiceObject(SingleRefPair.java:88)
at
org.apache.felix.scr.impl.inject.methods.BindMethod.getServiceObject(BindMethod.java:675)
at
org.apache.felix.scr.impl.manager.DependencyManager.getServiceObject(DependencyManager.java:2556)
at
org.apache.felix.scr.impl.manager.DependencyManager$SingleStaticCustomizer.prebind(DependencyManager.java:1398)
at
org.apache.felix.scr.impl.manager.DependencyManager.prebind(DependencyManager.java:1827)
at
org.apache.felix.scr.impl.manager.AbstractComponentManager.collectDependencies(AbstractComponentManager.java:1057)
at
org.apache.felix.scr.impl.manager.SingleComponentManager.getServiceInternal(SingleComponentManager.java:953)
at
org.apache.felix.scr.impl.manager.AbstractComponentManager.activateInternal(AbstractComponentManager.java:776)
at
org.apache.felix.scr.impl.manager.AbstractComponentManager.enableInternal(AbstractComponentManager.java:674)
at
org.apache.felix.scr.impl.manager.AbstractComponentManager.enable(AbstractComponentManager.java:437)
at
org.apache.felix.scr.impl.manager.ConfigurableComponentHolder.enableComponents(ConfigurableComponentHolder.java:667)
at
org.apache.felix.scr.impl.BundleComponentActivator.initialEnable(BundleComponentActivator.java:305)
at org.apache.felix.scr.impl.Activator.loadComponents(Activator.java:554)
at org.apache.felix.scr.impl.Activator.access$200(Activator.java:70)
at
org.apache.felix.scr.impl.Activator$ScrExtension.start(Activator.java:421)
at
org.apache.felix.scr.impl.AbstractExtender.createExtension(AbstractExtender.java:196)
at
org.apache.felix.scr.impl.AbstractExtender.modifiedBundle(AbstractExtender.java:169)
at
org.apache.felix.scr.impl.AbstractExtender.addingBundle(AbstractExtender.java:139)
at
org.apache.felix.scr.impl.AbstractExtender.addingBundle(AbstractExtender.java:49)
at
org.osgi.util.tracker.BundleTracker$Tracked.customizerAdding(BundleTracker.java:475)
at
org.osgi.util.tracker.BundleTracker$Tracked.customizerAdding(BundleTracker.java:420)
at
org.osgi.util.tracker.AbstractTracked.trackAdding(AbstractTracked.java:256)
at
org.osgi.util.tracker.AbstractTracked.trackInitial(AbstractTracked.java:183)
at org.osgi.util.tracker.BundleTracker.open(BundleTracker.java:159)
at
org.apache.felix.scr.impl.AbstractExtender.startTracking(AbstractExtender.java:100)
at
org.apache.felix.scr.impl.AbstractExtender.doStart(AbstractExtender.java:92)
at org.apache.felix.scr.impl.Activator.doStart(Activator.java:197)
at
org.apache.felix.scr.impl.AbstractExtender.start(AbstractExtender.java:72)
at org.apache.felix.scr.impl.Activator.restart(Activator.java:164)
at
org.apache.felix.scr.impl.config.ScrConfigurationImpl.configure(ScrConfigurationImpl.java:234)
at
org.apache.felix.scr.impl.config.ScrConfigurationImpl.start(ScrConfigurationImpl.java:126)
at org.apache.felix.scr.impl.Activator.start(Activator.java:121)
at
org.apache.felix.framework.util.SecureAction.startActivator(SecureAction.java:849)
at org.apache.felix.framework.Felix.activateBundle(Felix.java:2429)
at org.apache.felix.framework.Felix.startBundle(Felix.java:2335)
at org.apache.felix.framework.BundleImpl.start(BundleImpl.java:1006)
[jira] [Commented] (FELIX-6510) NPE within HealthCheck BundlesStartedCheck for bad Bundle
[ https://issues.apache.org/jira/browse/FELIX-6510?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17740265#comment-17740265 ] Heiko Studt commented on FELIX-6510: Basically, we are using Apache Felix, though having several own bundles in like an adapted CM or in the file install. However bundle.getHeader should not return a NULL, it would probably more fail safe to handle that anyways as this is not performance critical!? Sorry that I did not provide a PR yet. > NPE within HealthCheck BundlesStartedCheck for bad Bundle > - > > Key: FELIX-6510 > URL: https://issues.apache.org/jira/browse/FELIX-6510 > Project: Felix > Issue Type: Improvement > Components: Framework >Reporter: Heiko Studt >Priority: Major > > TL;DR: If you have configured the BundlesStartedCheck and there was any > bundle installed without correct OSGI headers (ls is showing `null 0.0.0`), > the BundlesStartedCheck will report some NPE and does not log anything to > file and neither the reason nor a stack trace into the health-check frontend. > The latter (no stack-trace) is a good thing, though. > If you have switched on the debug-level "all", it will stop after some lines > "Bundle [...] not matched by [...]"; the exception itself is then swallowed > and not logged into the osgi runner log, so that one has to wonder why it has > happened. > In my osgi runner there was a bundle installed which was shown by "ls -l" as > "null 0.0.0". It was created from an unit-test jar included by an error. > According to removing that bundle is solving the problem, I assume the > following code is the culprit. > [https://github.com/apache/felix-dev/blob/5becb8f971f904334eb3f32e7eaa9126186a2898/healthcheck/generalchecks/src/main/java/org/apache/felix/hc/generalchecks/BundlesStartedCheck.java#L149] > b.getHeaders().get(Constants.BUNDLE_ACTIVATIONPOLICY) > In my point of view, we should add a null check for b.getHeader() or at least > report the culprit bundle name of the exception. > Should I create a Pull Request for the null check? -- This message was sent by Atlassian Jira (v8.20.10#820010)
Re: [VOTE] Release Apache Felix HC Generalchecks 3.0.6
+1 Carsten On 05.07.2023 11:21, Carsten Ziegeler wrote: Hi, We solved one issue https://issues.apache.org/jira/browse/FELIX-6613 Staging repository: https://repository.apache.org/content/repositories/orgapachefelix-1461/ You can use this UNIX script to download the release and verify the signatures: https://github.com/apache/felix-dev/blob/master/check_staged_release.sh Usage: sh check_staged_release.sh 1461 /tmp/felix-staging Please vote to approve this release: [ ] +1 Approve the release [ ] -1 Veto the release (please provide specific comments) This vote will be open for 72 hours. Regards Carsten -- Carsten Ziegeler Adobe cziege...@apache.org
Re: [VOTE] Release Apache Felix HC Generalchecks 3.0.6
+1 On Wed, Jul 5, 2023 at 5:29 AM Jamie G. wrote: > +1 > > Cheers, > Jamie > > On Wed, Jul 5, 2023 at 6:50 AM Carsten Ziegeler > wrote: > > > > Hi, > > > > We solved one issue > > https://issues.apache.org/jira/browse/FELIX-6613 > > > > Staging repository: > > https://repository.apache.org/content/repositories/orgapachefelix-1461/ > > > > You can use this UNIX script to download the release and verify the > > signatures: > > https://github.com/apache/felix-dev/blob/master/check_staged_release.sh > > > > Usage: > > sh check_staged_release.sh 1461 /tmp/felix-staging > > > > Please vote to approve this release: > > > > [ ] +1 Approve the release > > [ ] -1 Veto the release (please provide specific comments) > > > > This vote will be open for 72 hours. > > > > Regards > > Carsten > > -- > > Carsten Ziegeler > > Adobe > > cziege...@apache.org > -- *Raymond Augé* (@rotty3000) Senior Software Architect *Liferay, Inc.* (@Liferay) OSGi Fellow, Java Champion
Re: [VOTE] Release Apache Felix HC Generalchecks 3.0.6
+1 Cheers, Jamie On Wed, Jul 5, 2023 at 6:50 AM Carsten Ziegeler wrote: > > Hi, > > We solved one issue > https://issues.apache.org/jira/browse/FELIX-6613 > > Staging repository: > https://repository.apache.org/content/repositories/orgapachefelix-1461/ > > You can use this UNIX script to download the release and verify the > signatures: > https://github.com/apache/felix-dev/blob/master/check_staged_release.sh > > Usage: > sh check_staged_release.sh 1461 /tmp/felix-staging > > Please vote to approve this release: > > [ ] +1 Approve the release > [ ] -1 Veto the release (please provide specific comments) > > This vote will be open for 72 hours. > > Regards > Carsten > -- > Carsten Ziegeler > Adobe > cziege...@apache.org
[VOTE] Release Apache Felix HC Generalchecks 3.0.6
Hi, We solved one issue https://issues.apache.org/jira/browse/FELIX-6613 Staging repository: https://repository.apache.org/content/repositories/orgapachefelix-1461/ You can use this UNIX script to download the release and verify the signatures: https://github.com/apache/felix-dev/blob/master/check_staged_release.sh Usage: sh check_staged_release.sh 1461 /tmp/felix-staging Please vote to approve this release: [ ] +1 Approve the release [ ] -1 Veto the release (please provide specific comments) This vote will be open for 72 hours. Regards Carsten -- Carsten Ziegeler Adobe cziege...@apache.org
[jira] [Commented] (FELIX-6510) NPE within HealthCheck BundlesStartedCheck for bad Bundle
[ https://issues.apache.org/jira/browse/FELIX-6510?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17740076#comment-17740076 ] Carsten Ziegeler commented on FELIX-6510: - I moved this to the framework component, bundle.getHeaders must never return null. [~HeikoStudt] Which framework implementation do you use? > NPE within HealthCheck BundlesStartedCheck for bad Bundle > - > > Key: FELIX-6510 > URL: https://issues.apache.org/jira/browse/FELIX-6510 > Project: Felix > Issue Type: Improvement > Components: Framework >Reporter: Heiko Studt >Priority: Major > > TL;DR: If you have configured the BundlesStartedCheck and there was any > bundle installed without correct OSGI headers (ls is showing `null 0.0.0`), > the BundlesStartedCheck will report some NPE and does not log anything to > file and neither the reason nor a stack trace into the health-check frontend. > The latter (no stack-trace) is a good thing, though. > If you have switched on the debug-level "all", it will stop after some lines > "Bundle [...] not matched by [...]"; the exception itself is then swallowed > and not logged into the osgi runner log, so that one has to wonder why it has > happened. > In my osgi runner there was a bundle installed which was shown by "ls -l" as > "null 0.0.0". It was created from an unit-test jar included by an error. > According to removing that bundle is solving the problem, I assume the > following code is the culprit. > [https://github.com/apache/felix-dev/blob/5becb8f971f904334eb3f32e7eaa9126186a2898/healthcheck/generalchecks/src/main/java/org/apache/felix/hc/generalchecks/BundlesStartedCheck.java#L149] > b.getHeaders().get(Constants.BUNDLE_ACTIVATIONPOLICY) > In my point of view, we should add a null check for b.getHeader() or at least > report the culprit bundle name of the exception. > Should I create a Pull Request for the null check? -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Updated] (FELIX-6510) NPE within HealthCheck BundlesStartedCheck for bad Bundle
[ https://issues.apache.org/jira/browse/FELIX-6510?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Carsten Ziegeler updated FELIX-6510: Component/s: Framework (was: Health Checks) > NPE within HealthCheck BundlesStartedCheck for bad Bundle > - > > Key: FELIX-6510 > URL: https://issues.apache.org/jira/browse/FELIX-6510 > Project: Felix > Issue Type: Improvement > Components: Framework >Reporter: Heiko Studt >Priority: Major > > TL;DR: If you have configured the BundlesStartedCheck and there was any > bundle installed without correct OSGI headers (ls is showing `null 0.0.0`), > the BundlesStartedCheck will report some NPE and does not log anything to > file and neither the reason nor a stack trace into the health-check frontend. > The latter (no stack-trace) is a good thing, though. > If you have switched on the debug-level "all", it will stop after some lines > "Bundle [...] not matched by [...]"; the exception itself is then swallowed > and not logged into the osgi runner log, so that one has to wonder why it has > happened. > In my osgi runner there was a bundle installed which was shown by "ls -l" as > "null 0.0.0". It was created from an unit-test jar included by an error. > According to removing that bundle is solving the problem, I assume the > following code is the culprit. > [https://github.com/apache/felix-dev/blob/5becb8f971f904334eb3f32e7eaa9126186a2898/healthcheck/generalchecks/src/main/java/org/apache/felix/hc/generalchecks/BundlesStartedCheck.java#L149] > b.getHeaders().get(Constants.BUNDLE_ACTIVATIONPOLICY) > In my point of view, we should add a null check for b.getHeader() or at least > report the culprit bundle name of the exception. > Should I create a Pull Request for the null check? -- This message was sent by Atlassian Jira (v8.20.10#820010)
