[jira] [Updated] (FELIX-6682) Felix SCR - 3 TestCases fail in OSGi TCK

2024-01-17 Thread Tom Watson (Jira)


 [ 
https://issues.apache.org/jira/browse/FELIX-6682?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Tom Watson updated FELIX-6682:
--
Fix Version/s: scr-2.2.8

> Felix SCR - 3 TestCases fail in OSGi TCK 
> -
>
> Key: FELIX-6682
> URL: https://issues.apache.org/jira/browse/FELIX-6682
> Project: Felix
>  Issue Type: Bug
>  Components: Declarative Services (SCR)
>Reporter: Stefan Bischof
>Priority: Major
> Fix For: scr-2.2.8
>
>
> Felix SCR doea not passt the the OSGi TCK with 3 tests.
> Versions: 2.2.0-RC - 2.2.6
> https://github.com/osgi/osgi/pull/657



--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[jira] [Commented] (FELIX-6682) Felix SCR - 3 TestCases fail in OSGi TCK

2024-01-17 Thread Tom Watson (Jira)


[ 
https://issues.apache.org/jira/browse/FELIX-6682?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17807871#comment-17807871
 ] 

Tom Watson commented on FELIX-6682:
---

Fix going with https://github.com/apache/felix-dev/pull/291

> Felix SCR - 3 TestCases fail in OSGi TCK 
> -
>
> Key: FELIX-6682
> URL: https://issues.apache.org/jira/browse/FELIX-6682
> Project: Felix
>  Issue Type: Bug
>  Components: Declarative Services (SCR)
>Reporter: Stefan Bischof
>Priority: Major
>
> Felix SCR doea not passt the the OSGi TCK with 3 tests.
> Versions: 2.2.0-RC - 2.2.6
> https://github.com/osgi/osgi/pull/657



--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[PR] Scr fix6682 [felix-dev]

2024-01-17 Thread via GitHub


tjwatson opened a new pull request, #291:
URL: https://github.com/apache/felix-dev/pull/291

   (no comment)


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@felix.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



[jira] [Commented] (FELIX-6682) Felix SCR - 3 TestCases fail in OSGi TCK

2024-01-17 Thread Tom Watson (Jira)


[ 
https://issues.apache.org/jira/browse/FELIX-6682?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17807861#comment-17807861
 ] 

Tom Watson commented on FELIX-6682:
---

See https://github.com/osgi/osgi/pull/657#issuecomment-1896477389

The TCK for scr (component) has a bug.  But the end result is that an assertion 
of the specification was never properly tested resulting in a bug in Felix SCR 
where calls to 
org.osgi.service.component.ComponentServiceObjects.ungetService(S) for a 
foreign object are not properly throwing an IllegalArgumentException. 

> Felix SCR - 3 TestCases fail in OSGi TCK 
> -
>
> Key: FELIX-6682
> URL: https://issues.apache.org/jira/browse/FELIX-6682
> Project: Felix
>  Issue Type: Bug
>  Components: Declarative Services (SCR)
>Reporter: Stefan Bischof
>Priority: Major
>
> Felix SCR doea not passt the the OSGi TCK with 3 tests.
> Versions: 2.2.0-RC - 2.2.6
> https://github.com/osgi/osgi/pull/657



--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[jira] [Closed] (FELIX-6672) Potentially losing comment state between reads on CommentRemovingReader

2024-01-17 Thread Robert Munteanu (Jira)


 [ 
https://issues.apache.org/jira/browse/FELIX-6672?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Robert Munteanu closed FELIX-6672.
--

> Potentially losing comment state between reads on CommentRemovingReader
> ---
>
> Key: FELIX-6672
> URL: https://issues.apache.org/jira/browse/FELIX-6672
> Project: Felix
>  Issue Type: Bug
>Affects Versions: cm.json-2.0.4
>Reporter: Dominik Süß
>Assignee: Robert Munteanu
>Priority: Major
> Fix For: cm.json-2.0.6
>
>
> In more extensive testing on real world data I found a case that was not 
> properly handled in the rewrite towards BufferedReader. If. a read ends 
> between the first / and the subsequent / or * for comment start, the 
> detection will currently fail. 
> To fix this I refactored the detection logic that should now also be 
> significantly better readable always capturing the previous char on class 
> level allowing to check for char double char sequences that may be split by 
> the reads. 



--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[RESULT] [VOTE] Release Apache Felix cm.json 2.0.6

2024-01-17 Thread Robert Munteanu
Hi,

The vote has passed with the following result :

  +1 (binding): Carsten Ziegeler, Karl Pauls, David Bosschaert

Can a Felix PMC member please upload the artifacts to the Felix dist
directory and release the cm.json-2.0.6 version? I will then promote
the artifacts to the central Maven repository.

Thanks!
Robert


Re: [VOTE] Release Apache Felix cm.json 2.0.6

2024-01-17 Thread davidb
+1

David

On Wed, 17 Jan 2024 at 13:18, Karl Pauls  wrote:

> +1
>
> regards,
>
> Karl
>
> On Wednesday, January 17, 2024, Robert Munteanu 
> wrote:
>
> > Hi,
> >
> > On Fri, 2024-01-12 at 14:09 +0100, Robert Munteanu wrote:
> > > Please vote to approve this release:
> >
> > Can two more PMC members please review and vote?
> >
> > Thanks,
> > Robert
> >
>
>
> --
> Karl Pauls
> karlpa...@gmail.com
>


Re: [VOTE] Release Apache Felix cm.json 2.0.6

2024-01-17 Thread Karl Pauls
+1

regards,

Karl

On Wednesday, January 17, 2024, Robert Munteanu  wrote:

> Hi,
>
> On Fri, 2024-01-12 at 14:09 +0100, Robert Munteanu wrote:
> > Please vote to approve this release:
>
> Can two more PMC members please review and vote?
>
> Thanks,
> Robert
>


-- 
Karl Pauls
karlpa...@gmail.com


Re: [VOTE] Release Apache Felix cm.json 2.0.6

2024-01-17 Thread Robert Munteanu
Hi,

On Fri, 2024-01-12 at 14:09 +0100, Robert Munteanu wrote:
> Please vote to approve this release:

Can two more PMC members please review and vote?

Thanks,
Robert


Re: [PR] Adds Requirement for Configuration Admin [felix-dev]

2024-01-17 Thread via GitHub


cziegeler commented on PR #290:
URL: https://github.com/apache/felix-dev/pull/290#issuecomment-1895337236

   Apache Felix ConfigAdmin still includes the api packages.
   If it helps, we can include the require capability; however I think the api 
bundle is the one that should be fixed - as the API really requires an 
implementation. An API bundle alone is useless. That's easier to change then 
each and every consumer bundle of the API.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@felix.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



Re: [PR] Adds Requirement for Configuration Admin [felix-dev]

2024-01-17 Thread via GitHub


juergen-albert commented on PR #290:
URL: https://github.com/apache/felix-dev/pull/290#issuecomment-1895315992

   It was in the Past, as the felix cm shipped the api packages as well. Today 
it does not, which leads to resolver to include the API bundle, but no 
implementation, which is quite annoying.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@felix.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org