Re: [PR] Don't add parent packages, only the ones that are actually present [felix-atomos]
bosschaert commented on code in PR #76:
URL: https://github.com/apache/felix-atomos/pull/76#discussion_r1633482885
##
atomos/src/main/java/org/apache/felix/atomos/impl/base/AtomosBase.java:
##
@@ -1663,9 +1663,8 @@ void addPackages(Bundle b)
try
{
content.getEntries().forEach((s) -> {
-if (s.length() > 1 && s.endsWith("/") &&
s.indexOf('-') < 0)
-{
-String pkg = s.substring(0, s.length() -
1).replace('/', '.');
+if (s.endsWith(".class")) {
Review Comment:
I think that would probably work yes.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscr...@felix.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Re: [I] Application structure posibilities with native-image [felix-atomos]
tjwatson commented on issue #78: URL: https://github.com/apache/felix-atomos/issues/78#issuecomment-2158690779 Last time I had experience with GraalVM native image I was not aware it could compile a set of JARs into separate binaries. Are there examples of how to compile such a project? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@felix.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [VOTE] Release Apache Felix Http Jetty 5.1.18
+1 regards, Karl On Mon, Jun 10, 2024 at 5:05 PM Raymond Augé wrote: > > +1 > > On Mon, Jun 10, 2024 at 10:38 AM Paul Rütter wrote: > > > +1 > > > > -Original Message- > > From: Carsten Ziegeler > > Sent: Monday, 10 June 2024 16:26 > > To: dev@felix.apache.org > > Subject: [VOTE] Release Apache Felix Http Jetty 5.1.18 > > > > Hi, > > > > we solved one issue for Http Jetty 5.1.18 > > https://issues.apache.org/jira/browse/FELIX-6710 > > > > > > Staging repository: > > https://repository.apache.org/content/repositories/orgapachefelix-1499 > > > > You can use this UNIX script to download the release and verify the > > signatures: > > https://github.com/apache/felix-dev/blob/master/check_staged_release.sh > > > > Usage: > > sh check_staged_release.sh 1499 /tmp/felix-staging > > > > Please vote to approve this release: > > > > [ ] +1 Approve the release > > [ ] -1 Veto the release (please provide specific comments) > > > > This vote will be open for 72 hours. > > > > Regards > > Carsten > > -- > > Carsten Ziegeler > > Adobe > > cziege...@apache.org > > > > > -- > *Raymond Augé* (@rotty3000) > Senior Software Architect *Liferay, Inc.* (@Liferay) > OSGi Fellow, Java Champion -- Karl Pauls karlpa...@gmail.com
Re: [VOTE] Release Apache Felix SCR 2.2.12
+1 On Mon, Jun 10, 2024 at 10:39 AM Thomas Watson wrote: > +1 > > Tom > > On Thu, May 2, 2024 at 12:03 PM Karl Pauls wrote: > > > +1 > > > > regards, > > > > Karl > > > > On Thursday, May 2, 2024, Carsten Ziegeler wrote: > > > > > +1 > > > > > > Carsten > > > > > > On 02.05.2024 15:24, Thomas Watson wrote: > > > > > >> Hi, > > >> > > >> We solved one issues for SCR 2.2.12 > > >> https://issues.apache.org/jira/projects/FELIX/versions/12354172 > > >> > > >> > > >> Staging repository: > > >> > https://repository.apache.org/content/repositories/orgapachefelix-1494 > > >> > > >> You can use this UNIX script to download the release and verify the > > >> signatures: > > >> > https://github.com/apache/felix-dev/blob/master/check_staged_release.sh > > >> > > >> Usage: > > >> sh check_staged_release.sh 1493 /tmp/felix-staging > > >> > > >> Please vote to approve this release: > > >> > > >> [ ] +1 Approve the release > > >> [ ] -1 Veto the release (please provide specific comments) > > >> > > >> This vote will be open for 72 hours. > > >> > > >> Thanks > > >> Tom > > >> > > >> > > > -- > > > Carsten Ziegeler > > > Adobe > > > cziege...@apache.org > > > > > > > > > -- > > Karl Pauls > > karlpa...@gmail.com > > > -- *Raymond Augé* (@rotty3000) Senior Software Architect *Liferay, Inc.* (@Liferay) OSGi Fellow, Java Champion
Re: [VOTE] Release Apache Felix Http Jetty 5.1.18
+1 On Mon, Jun 10, 2024 at 10:38 AM Paul Rütter wrote: > +1 > > -Original Message- > From: Carsten Ziegeler > Sent: Monday, 10 June 2024 16:26 > To: dev@felix.apache.org > Subject: [VOTE] Release Apache Felix Http Jetty 5.1.18 > > Hi, > > we solved one issue for Http Jetty 5.1.18 > https://issues.apache.org/jira/browse/FELIX-6710 > > > Staging repository: > https://repository.apache.org/content/repositories/orgapachefelix-1499 > > You can use this UNIX script to download the release and verify the > signatures: > https://github.com/apache/felix-dev/blob/master/check_staged_release.sh > > Usage: > sh check_staged_release.sh 1499 /tmp/felix-staging > > Please vote to approve this release: > > [ ] +1 Approve the release > [ ] -1 Veto the release (please provide specific comments) > > This vote will be open for 72 hours. > > Regards > Carsten > -- > Carsten Ziegeler > Adobe > cziege...@apache.org > -- *Raymond Augé* (@rotty3000) Senior Software Architect *Liferay, Inc.* (@Liferay) OSGi Fellow, Java Champion
[VOTE RESULT] Release Apache Felix SCR 2.2.12
Hi, I neglected to close out this vote, doing so now ... The vote passed with four binding +1 Tom
Re: [PR] FELIX-6708 upgrade bnd to 7.0.0 [felix-dev]
paulrutter commented on PR #322: URL: https://github.com/apache/felix-dev/pull/322#issuecomment-2158553485 @tjwatson @cziegeler any feedback on this PR? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@felix.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [VOTE] Release Apache Felix SCR 2.2.12
+1 Tom On Thu, May 2, 2024 at 12:03 PM Karl Pauls wrote: > +1 > > regards, > > Karl > > On Thursday, May 2, 2024, Carsten Ziegeler wrote: > > > +1 > > > > Carsten > > > > On 02.05.2024 15:24, Thomas Watson wrote: > > > >> Hi, > >> > >> We solved one issues for SCR 2.2.12 > >> https://issues.apache.org/jira/projects/FELIX/versions/12354172 > >> > >> > >> Staging repository: > >> https://repository.apache.org/content/repositories/orgapachefelix-1494 > >> > >> You can use this UNIX script to download the release and verify the > >> signatures: > >> https://github.com/apache/felix-dev/blob/master/check_staged_release.sh > >> > >> Usage: > >> sh check_staged_release.sh 1493 /tmp/felix-staging > >> > >> Please vote to approve this release: > >> > >> [ ] +1 Approve the release > >> [ ] -1 Veto the release (please provide specific comments) > >> > >> This vote will be open for 72 hours. > >> > >> Thanks > >> Tom > >> > >> > > -- > > Carsten Ziegeler > > Adobe > > cziege...@apache.org > > > > > -- > Karl Pauls > karlpa...@gmail.com >
RE: [VOTE] Release Apache Felix Http Jetty 5.1.18
+1 -Original Message- From: Carsten Ziegeler Sent: Monday, 10 June 2024 16:26 To: dev@felix.apache.org Subject: [VOTE] Release Apache Felix Http Jetty 5.1.18 Hi, we solved one issue for Http Jetty 5.1.18 https://issues.apache.org/jira/browse/FELIX-6710 Staging repository: https://repository.apache.org/content/repositories/orgapachefelix-1499 You can use this UNIX script to download the release and verify the signatures: https://github.com/apache/felix-dev/blob/master/check_staged_release.sh Usage: sh check_staged_release.sh 1499 /tmp/felix-staging Please vote to approve this release: [ ] +1 Approve the release [ ] -1 Veto the release (please provide specific comments) This vote will be open for 72 hours. Regards Carsten -- Carsten Ziegeler Adobe cziege...@apache.org
Re: [PR] Don't add parent packages, only the ones that are actually present [felix-atomos]
tjwatson commented on code in PR #76:
URL: https://github.com/apache/felix-atomos/pull/76#discussion_r1633357634
##
atomos/src/main/java/org/apache/felix/atomos/impl/base/AtomosBase.java:
##
@@ -1663,9 +1663,8 @@ void addPackages(Bundle b)
try
{
content.getEntries().forEach((s) -> {
-if (s.length() > 1 && s.endsWith("/") &&
s.indexOf('-') < 0)
-{
-String pkg = s.substring(0, s.length() -
1).replace('/', '.');
+if (s.endsWith(".class")) {
Review Comment:
Can we change this to be `if (!s.endswith("/") && s.contains("/")) {`
In other words all paths that are not directories (don't end with "/") and
are not part of the default package (paths with no "/" at all).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscr...@felix.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[VOTE] Release Apache Felix Http Jetty 5.1.18
Hi, we solved one issue for Http Jetty 5.1.18 https://issues.apache.org/jira/browse/FELIX-6710 Staging repository: https://repository.apache.org/content/repositories/orgapachefelix-1499 You can use this UNIX script to download the release and verify the signatures: https://github.com/apache/felix-dev/blob/master/check_staged_release.sh Usage: sh check_staged_release.sh 1499 /tmp/felix-staging Please vote to approve this release: [ ] +1 Approve the release [ ] -1 Veto the release (please provide specific comments) This vote will be open for 72 hours. Regards Carsten -- Carsten Ziegeler Adobe cziege...@apache.org
Re: [I] Next release? [felix-atomos]
tjwatson commented on issue #64: URL: https://github.com/apache/felix-atomos/issues/64#issuecomment-2158514772 > Is this project alive or deprecated? The project is not deprecated. I've not had time to do a release, if others committers are interested in pick up the tasks I would be glad to hear it. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@felix.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Resolved] (FELIX-6710) Ability to configure URI Compliance mode
[ https://issues.apache.org/jira/browse/FELIX-6710?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Carsten Ziegeler resolved FELIX-6710. - Resolution: Fixed > Ability to configure URI Compliance mode > > > Key: FELIX-6710 > URL: https://issues.apache.org/jira/browse/FELIX-6710 > Project: Felix > Issue Type: Improvement > Components: HTTP Service >Reporter: Carsten Ziegeler >Assignee: Carsten Ziegeler >Priority: Major > Fix For: http.jetty-5.1.18 > > > Similar to FELIX-6698 we should make the URICompliance mode for Jetty 11 > configurable. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (FELIX-6710) Ability to configure URI Compliance mode
[ https://issues.apache.org/jira/browse/FELIX-6710?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17853682#comment-17853682 ] Carsten Ziegeler commented on FELIX-6710: - Implemented based on FELIX-6698, using the same configuration property : https://github.com/apache/felix-dev/commit/5d3ed71b7c70080d4cfb4c1797bf21e1f4268862 > Ability to configure URI Compliance mode > > > Key: FELIX-6710 > URL: https://issues.apache.org/jira/browse/FELIX-6710 > Project: Felix > Issue Type: Improvement > Components: HTTP Service >Reporter: Carsten Ziegeler >Assignee: Carsten Ziegeler >Priority: Major > Fix For: http.jetty-5.1.18 > > > Similar to FELIX-6698 we should make the URICompliance mode for Jetty 11 > configurable. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (FELIX-6710) Ability to configure URI Compliance mode
[ https://issues.apache.org/jira/browse/FELIX-6710?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17853676#comment-17853676 ] Paul Rütter (BlueConic) commented on FELIX-6710: Just joking, would be good to have in Jetty 11 bundle as well. > Ability to configure URI Compliance mode > > > Key: FELIX-6710 > URL: https://issues.apache.org/jira/browse/FELIX-6710 > Project: Felix > Issue Type: Improvement > Components: HTTP Service >Reporter: Carsten Ziegeler >Assignee: Carsten Ziegeler >Priority: Major > Fix For: http.jetty-5.1.18 > > > Similar to FELIX-6698 we should make the URICompliance mode for Jetty 11 > configurable. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (FELIX-6710) Ability to configure URI Compliance mode
[ https://issues.apache.org/jira/browse/FELIX-6710?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17853674#comment-17853674 ] Carsten Ziegeler commented on FELIX-6710: - [~paul_blueconic] That would be nice, but I fear will not work - jetty 12 with the requirement for java 17 is a too high hurdle right now for many of our users > Ability to configure URI Compliance mode > > > Key: FELIX-6710 > URL: https://issues.apache.org/jira/browse/FELIX-6710 > Project: Felix > Issue Type: Improvement > Components: HTTP Service >Reporter: Carsten Ziegeler >Assignee: Carsten Ziegeler >Priority: Major > Fix For: http.jetty-5.1.18 > > > Similar to FELIX-6698 we should make the URICompliance mode for Jetty 11 > configurable. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Work started] (FELIX-6710) Ability to configure URI Compliance mode
[ https://issues.apache.org/jira/browse/FELIX-6710?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Work on FELIX-6710 started by Carsten Ziegeler. --- > Ability to configure URI Compliance mode > > > Key: FELIX-6710 > URL: https://issues.apache.org/jira/browse/FELIX-6710 > Project: Felix > Issue Type: Improvement > Components: HTTP Service >Reporter: Carsten Ziegeler >Assignee: Carsten Ziegeler >Priority: Major > Fix For: http.jetty-5.1.18 > > > Similar to FELIX-6698 we should make the URICompliance mode for Jetty 11 > configurable. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (FELIX-6710) Ability to configure URI Compliance mode
[ https://issues.apache.org/jira/browse/FELIX-6710?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17853673#comment-17853673 ] Paul Rütter (BlueConic) commented on FELIX-6710: Not doing this might persuade devs to move to jetty 12 instead ;) > Ability to configure URI Compliance mode > > > Key: FELIX-6710 > URL: https://issues.apache.org/jira/browse/FELIX-6710 > Project: Felix > Issue Type: Improvement > Components: HTTP Service >Reporter: Carsten Ziegeler >Assignee: Carsten Ziegeler >Priority: Major > Fix For: http.jetty-5.1.18 > > > Similar to FELIX-6698 we should make the URICompliance mode for Jetty 11 > configurable. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Created] (FELIX-6710) Ability to configure URI Compliance mode
Carsten Ziegeler created FELIX-6710: --- Summary: Ability to configure URI Compliance mode Key: FELIX-6710 URL: https://issues.apache.org/jira/browse/FELIX-6710 Project: Felix Issue Type: Improvement Components: HTTP Service Reporter: Carsten Ziegeler Assignee: Carsten Ziegeler Fix For: http.jetty-5.1.18 Similar to FELIX-6698 we should make the URICompliance mode for Jetty 11 configurable. -- This message was sent by Atlassian Jira (v8.20.10#820010)
