[jira] [Updated] (FELIX-5015) NPE in ResolverImpl
[ https://issues.apache.org/jira/browse/FELIX-5015?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Enrique Ruiz (DiSiD Technologies S.L.) updated FELIX-5015: -- Attachment: FELIX-5015.patch.gz > NPE in ResolverImpl > --- > > Key: FELIX-5015 > URL: https://issues.apache.org/jira/browse/FELIX-5015 > Project: Felix > Issue Type: Bug > Components: Resolver >Affects Versions: resolver-1.6.0 >Reporter: Alexandre Roman > Attachments: FELIX-5015.patch.gz > > > The method getPackageSources in ResolverImpl.java returns a Set. > This collection is used in mergeUses (line 1039) in a foreach loop. > A null value may be returned by getPackageSources, as a result of querying a > Map. In this case, the foreach loop in mergeUses will trigger a NPE. > The method getPackageSources should return an empty Set when there is no > result. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (FELIX-5015) NPE in ResolverImpl
[ https://issues.apache.org/jira/browse/FELIX-5015?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14733861#comment-14733861 ] Enrique Ruiz (DiSiD Technologies S.L.) commented on FELIX-5015: --- Hi, Spring Roo has been upgraded to OSGi R6, including its Subsystem based feature "Roo Addon Suites". We have implemented Alexandre's patch and it works, so we have attached the patch implementation. Hope you accept it to fix this issue. All the best. > NPE in ResolverImpl > --- > > Key: FELIX-5015 > URL: https://issues.apache.org/jira/browse/FELIX-5015 > Project: Felix > Issue Type: Bug > Components: Resolver >Affects Versions: resolver-1.6.0 >Reporter: Alexandre Roman > Attachments: FELIX-5015.patch.gz > > > The method getPackageSources in ResolverImpl.java returns a Set. > This collection is used in mergeUses (line 1039) in a foreach loop. > A null value may be returned by getPackageSources, as a result of querying a > Map. In this case, the foreach loop in mergeUses will trigger a NPE. > The method getPackageSources should return an empty Set when there is no > result. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (FELIX-4994) Use Java Logging API in spite of System.out
[ https://issues.apache.org/jira/browse/FELIX-4994?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14722836#comment-14722836 ] Enrique Ruiz (DiSiD Technologies S.L.) commented on FELIX-4994: --- Thanks Carsten for your support. I agree, I will try to upgrade to a newer version asap. Use Java Logging API in spite of System.out --- Key: FELIX-4994 URL: https://issues.apache.org/jira/browse/FELIX-4994 Project: Felix Issue Type: Improvement Components: HTTP Service Affects Versions: http-2.3.2, http-2.4.0 Environment: Linux, JDK 1.7, Felix 4.6.1 Reporter: Enrique Ruiz (DiSiD Technologies S.L.) Assignee: Carsten Ziegeler Fix For: http.base-3.0.2 Attachments: java-logging-api.patch.gz If `LogServiceLogger` doesn't have a reference to the `LogService` it delegates on `ConsoleLogger`. The problems are: * The `ConsoleLogger` writes the messages to `System.out` * We cannot configure the log verbosity I think it would be better if `ConsoleLogger` would use the `java.util.logging.Logger`. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (FELIX-4994) Use Java Logging API in spite of System.out
[ https://issues.apache.org/jira/browse/FELIX-4994?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14696764#comment-14696764 ] Enrique Ruiz (DiSiD Technologies S.L.) commented on FELIX-4994: --- Hi Carsten, please let me know if the patch is ok or you need something else ... On the other side, could you apply the patch to version 2.3.2 too? Thanks Use Java Logging API in spite of System.out --- Key: FELIX-4994 URL: https://issues.apache.org/jira/browse/FELIX-4994 Project: Felix Issue Type: Improvement Components: HTTP Service Affects Versions: http-2.3.2, http-2.4.0 Environment: Linux, JDK 1.7, Felix 4.6.1 Reporter: Enrique Ruiz (DiSiD Technologies S.L.) Attachments: java-logging-api.patch.gz If `LogServiceLogger` doesn't have a reference to the `LogService` it delegates on `ConsoleLogger`. The problems are: * The `ConsoleLogger` writes the messages to `System.out` * We cannot configure the log verbosity I think it would be better if `ConsoleLogger` would use the `java.util.logging.Logger`. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Updated] (FELIX-4994) Use Java Logging API in spite of System.out
[ https://issues.apache.org/jira/browse/FELIX-4994?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Enrique Ruiz (DiSiD Technologies S.L.) updated FELIX-4994: -- Attachment: java-logging-api.patch.gz Attached the patch generated over http://svn.apache.org/repos/asf/felix/releases/org.apache.felix.http.base-2.4.0 Thanks! Use Java Logging API in spite of System.out --- Key: FELIX-4994 URL: https://issues.apache.org/jira/browse/FELIX-4994 Project: Felix Issue Type: Improvement Components: HTTP Service Affects Versions: http-2.3.2, http-2.4.0 Environment: Linux, JDK 1.7, Felix 4.6.1 Reporter: Enrique Ruiz (DiSiD Technologies S.L.) Attachments: java-logging-api.patch.gz If `LogServiceLogger` doesn't have a reference to the `LogService` it delegates on `ConsoleLogger`. The problems are: * The `ConsoleLogger` writes the messages to `System.out` * We cannot configure the log verbosity I think it would be better if `ConsoleLogger` would use the `java.util.logging.Logger`. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (FELIX-4994) Use Java Logging API in spite of System.out
[ https://issues.apache.org/jira/browse/FELIX-4994?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14680193#comment-14680193 ] Enrique Ruiz (DiSiD Technologies S.L.) commented on FELIX-4994: --- In OSGi it is a bad practice to assume any order in the services initialization process, in fact I proposed this improvement because Apache Felix HTTP Service starts before the LogService. Use Java Logging API in spite of System.out --- Key: FELIX-4994 URL: https://issues.apache.org/jira/browse/FELIX-4994 Project: Felix Issue Type: Improvement Components: HTTP Service Affects Versions: http-2.3.2, http-2.4.0 Environment: Linux, JDK 1.7, Felix 4.6.1 Reporter: Enrique Ruiz (DiSiD Technologies S.L.) If `LogServiceLogger` doesn't have a reference to the `LogService` it delegates on `ConsoleLogger`. The problems are: * The `ConsoleLogger` writes the messages to `System.out` * We cannot configure the log verbosity I think it would be better if `ConsoleLogger` would use the `java.util.logging.Logger`. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (FELIX-4994) Use JDK Logger in spite of System.out
[
https://issues.apache.org/jira/browse/FELIX-4994?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14661355#comment-14661355
]
Enrique Ruiz (DiSiD Technologies S.L.) commented on FELIX-4994:
---
You are right, the OSGi components and services must use a {{LogService}}
implementation. The problem is the initialization time, when the {{LogService}}
is not instantiated yet, in that case the {{LogServiceLogger}} delegates on
{{ConsoleLogger}} which writes the log messages to System.out.
I proposed to use the Java Logging API because it is included in the JVM since
1.4, so you won't need any 3rd party dependencies but you will be able to
configure the behaviour you need by setting the JVM property
{{java.util.logging.config.file}}
Use JDK Logger in spite of System.out
-
Key: FELIX-4994
URL: https://issues.apache.org/jira/browse/FELIX-4994
Project: Felix
Issue Type: Improvement
Components: HTTP Service
Affects Versions: http-2.3.2, http-2.4.0
Environment: Linux, JDK 1.7, Felix 4.6.1
Reporter: Enrique Ruiz (DiSiD Technologies S.L.)
If `LogServiceLogger` doesn't have a reference to the `LogService` it
delegates on `ConsoleLogger`.
The problems are:
* The `ConsoleLogger` writes the messages to `System.out`
* We cannot configure the log verbosity
I think it would be better if `ConsoleLogger` would use the
`java.util.logging.Logger`.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Updated] (FELIX-4994) Use Java Logging API in spite of System.out
[ https://issues.apache.org/jira/browse/FELIX-4994?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Enrique Ruiz (DiSiD Technologies S.L.) updated FELIX-4994: -- Summary: Use Java Logging API in spite of System.out (was: Use JDK Logger in spite of System.out) Use Java Logging API in spite of System.out --- Key: FELIX-4994 URL: https://issues.apache.org/jira/browse/FELIX-4994 Project: Felix Issue Type: Improvement Components: HTTP Service Affects Versions: http-2.3.2, http-2.4.0 Environment: Linux, JDK 1.7, Felix 4.6.1 Reporter: Enrique Ruiz (DiSiD Technologies S.L.) If `LogServiceLogger` doesn't have a reference to the `LogService` it delegates on `ConsoleLogger`. The problems are: * The `ConsoleLogger` writes the messages to `System.out` * We cannot configure the log verbosity I think it would be better if `ConsoleLogger` would use the `java.util.logging.Logger`. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Created] (FELIX-4994) Use JDK Logger in spite of System.out
Enrique Ruiz (DiSiD Technologies S.L.) created FELIX-4994: - Summary: Use JDK Logger in spite of System.out Key: FELIX-4994 URL: https://issues.apache.org/jira/browse/FELIX-4994 Project: Felix Issue Type: Improvement Components: HTTP Service Affects Versions: http-2.4.0, http-2.3.2 Environment: Linux, JDK 1.7, Felix 4.6.1 Reporter: Enrique Ruiz (DiSiD Technologies S.L.) If `LogServiceLogger` doesn't have a reference to the `LogService` it delegates on `ConsoleLogger`. The problems are: * The `ConsoleLogger` writes the messages to `System.out` * We cannot configure the log verbosity I think it would be better if `ConsoleLogger` would use the `java.util.logging.Logger`. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (FELIX-4370) Support Repository service as defined by OSGi spec
[ https://issues.apache.org/jira/browse/FELIX-4370?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14214787#comment-14214787 ] Enrique Ruiz (DiSiD Technologies S.L.) commented on FELIX-4370: --- Hi David, sorry for disturbing, I know this isn't the right place for questions, but I didn't found another. We are trying to migrate an open source project to OSGi 5 Subsystem + Repository, but we don't found basic documentation about: * Install a public repository server * Publish bundles to public repository servers * Generate OSGi R5 indexes (I saw maven-bundle-plugin doesn't support it yet FELIX-4193) * etc. Could you point us to useful doc to install, run and maintain an OSGi 5 Repository? Many thanks. Support Repository service as defined by OSGi spec -- Key: FELIX-4370 URL: https://issues.apache.org/jira/browse/FELIX-4370 Project: Felix Issue Type: Sub-task Components: Bundle Repository (OBR) Affects Versions: bundlerepository-1.6.6 Reporter: David Bosschaert Assignee: David Bosschaert Fix For: bundlerepository-2.0.2 This API described in section 132.8.4 and throughout chapter 132. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Comment Edited] (FELIX-4370) Support Repository service as defined by OSGi spec
[ https://issues.apache.org/jira/browse/FELIX-4370?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14214787#comment-14214787 ] Enrique Ruiz (DiSiD Technologies S.L.) edited comment on FELIX-4370 at 11/17/14 4:18 PM: - Hi David, sorry for disturbing, I know this isn't the right place for questions, but I didn't found another. We are trying to migrate an open source project to OSGi 5 Subsystem + Repository, but we don't found basic documentation about: * Install a public repository server * Publish bundles to public repository servers * Generate OSGi R5 indexes (I saw maven-bundle-plugin doesn't support it yet FELIX-4193) * etc. Could you point us to useful doc to install, run and maintain an OSGi 5 Repository for OSGi Subsystems? Many thanks. was (Author: eruiz): Hi David, sorry for disturbing, I know this isn't the right place for questions, but I didn't found another. We are trying to migrate an open source project to OSGi 5 Subsystem + Repository, but we don't found basic documentation about: * Install a public repository server * Publish bundles to public repository servers * Generate OSGi R5 indexes (I saw maven-bundle-plugin doesn't support it yet FELIX-4193) * etc. Could you point us to useful doc to install, run and maintain an OSGi 5 Repository? Many thanks. Support Repository service as defined by OSGi spec -- Key: FELIX-4370 URL: https://issues.apache.org/jira/browse/FELIX-4370 Project: Felix Issue Type: Sub-task Components: Bundle Repository (OBR) Affects Versions: bundlerepository-1.6.6 Reporter: David Bosschaert Assignee: David Bosschaert Fix For: bundlerepository-2.0.2 This API described in section 132.8.4 and throughout chapter 132. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (FELIX-4417) Circular references detected but not resolved if one of the references in the cycle has optional cardinality
[ https://issues.apache.org/jira/browse/FELIX-4417?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14128189#comment-14128189 ] Enrique Ruiz (DiSiD Technologies S.L.) commented on FELIX-4417: --- David: I totally agree, I will check the service reference graph. Circular references detected but not resolved if one of the references in the cycle has optional cardinality Key: FELIX-4417 URL: https://issues.apache.org/jira/browse/FELIX-4417 Project: Felix Issue Type: Bug Components: Declarative Services (SCR) Affects Versions: scr-1.8.2 Reporter: Victor Antonovich Attachments: CircularReferenceTest-trunk.patch, CircularReferenceTest.zip Looks like current Apache Felix SCR implementation doesn't conform fully to Declarative Services Specification, which says (http://www.osgi.org/download/r4v43/osgi.cmpn-4.3.0.pdf, 112.3.7): Circular references must be detected by SCR when it attempts to satisfy component configurations and SCR must fail to satisfy the references involved in the cycle and log an error message with the Log Service, if present. However, if one of the references in the cycle has optional cardinality SCR must break the cycle. The reference with the optional cardinality can be satisfied and bound to zero target services. Therefore the cycle is broken and the other references may be satisfied. In case of two components, A and B, where A is delayed with 1..1 static reference to B, and B is immediate with 0..n dynamic reference to A, Felix SCR should: 1) activate B with dynamic reference to A satisfied and bound to zero services 2) activate A with satisfied static reference to B 3) bind dynamic reference to B in component A But it seems current Felix SCR implementation can't handle this kind of circular dependency correctly and is failing with message Circular reference detected. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (FELIX-4417) Circular references detected but not resolved if one of the references in the cycle has optional cardinality
[ https://issues.apache.org/jira/browse/FELIX-4417?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14126627#comment-14126627 ] Enrique Ruiz (DiSiD Technologies S.L.) commented on FELIX-4417: --- This is a serious problem, anyone knows a workaround? Any idea when the fix will be available? Thanks Circular references detected but not resolved if one of the references in the cycle has optional cardinality Key: FELIX-4417 URL: https://issues.apache.org/jira/browse/FELIX-4417 Project: Felix Issue Type: Bug Components: Declarative Services (SCR) Affects Versions: scr-1.8.2 Reporter: Victor Antonovich Attachments: CircularReferenceTest-trunk.patch, CircularReferenceTest.zip Looks like current Apache Felix SCR implementation doesn't conform fully to Declarative Services Specification, which says (http://www.osgi.org/download/r4v43/osgi.cmpn-4.3.0.pdf, 112.3.7): Circular references must be detected by SCR when it attempts to satisfy component configurations and SCR must fail to satisfy the references involved in the cycle and log an error message with the Log Service, if present. However, if one of the references in the cycle has optional cardinality SCR must break the cycle. The reference with the optional cardinality can be satisfied and bound to zero target services. Therefore the cycle is broken and the other references may be satisfied. In case of two components, A and B, where A is delayed with 1..1 static reference to B, and B is immediate with 0..n dynamic reference to A, Felix SCR should: 1) activate B with dynamic reference to A satisfied and bound to zero services 2) activate A with satisfied static reference to B 3) bind dynamic reference to B in component A But it seems current Felix SCR implementation can't handle this kind of circular dependency correctly and is failing with message Circular reference detected. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (FELIX-4370) Support Repository service as defined by OSGi spec
[ https://issues.apache.org/jira/browse/FELIX-4370?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14111900#comment-14111900 ] Enrique Ruiz (DiSiD Technologies S.L.) commented on FELIX-4370: --- Hi David, where can I find documentation or guides about how to use this new feature? Thanks Support Repository service as defined by OSGi spec -- Key: FELIX-4370 URL: https://issues.apache.org/jira/browse/FELIX-4370 Project: Felix Issue Type: Sub-task Components: Bundle Repository (OBR) Affects Versions: bundlerepository-1.6.6 Reporter: David Bosschaert Assignee: David Bosschaert Fix For: bundlerepository-2.0.2 This API described in section 132.8.4 and throughout chapter 132. -- This message was sent by Atlassian JIRA (v6.2#6252)
