[jira] [Commented] (FELIX-6081) Upgrade bndlib to 4.2.0 in order to properly calculate osgi.ee for embedded dependencies

2019-03-12 Thread Krystian Nowak (JIRA)


[ 
https://issues.apache.org/jira/browse/FELIX-6081?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16790393#comment-16790393
 ] 

Krystian Nowak commented on FELIX-6081:
---

PR ready: [https://github.com/apache/felix/pull/186]

> Upgrade bndlib to 4.2.0 in order to properly calculate osgi.ee for embedded 
> dependencies
> 
>
> Key: FELIX-6081
> URL: https://issues.apache.org/jira/browse/FELIX-6081
> Project: Felix
>  Issue Type: Improvement
>  Components: Maven Bundle Plugin
>Affects Versions: maven-bundle-plugin-4.1.0
>Reporter: Krystian Nowak
>Priority: Major
>
> The *_bndlib_* dependency 
> [https://github.com/apache/felix/blob/e12e94cb84d99e4613a4a57c3655bc7c6095140c/tools/maven-bundle-plugin/pom.xml#L172-L176]
>  needs to be upgraded from _4.1.0_ to *_4.2.0_* 
> ([http://repo1.maven.org/maven2/biz/aQute/bnd/biz.aQute.bndlib/4.2.0/]) as in 
> _4.2.0_ the following issue is fixed 
> [https://github.com/bndtools/bnd/issues/3010] by 
> [https://github.com/bndtools/bnd/pull/3015] excluding _module-info_ class 
> from class version in use calculation for _Require-Capability_ *_osgi.ee_* 
> for embedded dependencies.
> This will allow to properly use a dependency where its code is compiled for 
> e.g. _Java SE 5.0_ but the whole build performed on (and also module-info 
> class compiled against) _Java SE 7_ as in 
> [https://gitlab.ow2.org/asm/asm/issues/317870].



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Created] (FELIX-6081) Upgrade bndlib to 4.2.0 in order to properly calculate osgi.ee for embedded dependencies

2019-03-11 Thread Krystian Nowak (JIRA)
Krystian Nowak created FELIX-6081:
-

 Summary: Upgrade bndlib to 4.2.0 in order to properly calculate 
osgi.ee for embedded dependencies
 Key: FELIX-6081
 URL: https://issues.apache.org/jira/browse/FELIX-6081
 Project: Felix
  Issue Type: Improvement
  Components: Maven Bundle Plugin
Affects Versions: maven-bundle-plugin-4.1.0
Reporter: Krystian Nowak


The *_bndlib_* dependency 
[https://github.com/apache/felix/blob/e12e94cb84d99e4613a4a57c3655bc7c6095140c/tools/maven-bundle-plugin/pom.xml#L172-L176]
 needs to be upgraded from _4.1.0_ to *_4.2.0_* 
([http://repo1.maven.org/maven2/biz/aQute/bnd/biz.aQute.bndlib/4.2.0/]) as in 
_4.2.0_ the following issue is fixed 
[https://github.com/bndtools/bnd/issues/3010] by 
[https://github.com/bndtools/bnd/pull/3015] excluding _module-info_ class from 
class version in use calculation for _Require-Capability_ *_osgi.ee_* for 
embedded dependencies.

This will allow to properly use a dependency where its code is compiled for 
e.g. _Java SE 5.0_ but the whole build performed on (and also module-info class 
compiled against) _Java SE 7_ as in 
[https://gitlab.ow2.org/asm/asm/issues/317870].



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Updated] (FELIX-5249) Enabling SSL for org.apache.felix.http fails to properly restart the jetty service

2016-05-17 Thread Krystian Nowak (JIRA)

 [ 
https://issues.apache.org/jira/browse/FELIX-5249?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Krystian Nowak updated FELIX-5249:
--
Attachment: FELIX-5249-patch.txt

I can confirm that this issue is happening once every n times in my case (not 
always, but reoccurring) when changing any Jetty service property (so the issue 
description might be even reworded to be more generic if such details are 
needed). As far as I have checked the protection against the exception 
mentioned proposed by [~alexander.klimetschek] should be not in line 53 
(highestReference retrieval after adding a reference to a set) but in fact in 
line 85 instead, as the highestReference retrieval is made there after 
reference removal and thus can be unsuccessful. The patch attached uses 
[~alexander.klimetschek]’s idea in that exact place and after applying works in 
my case at least.

> Enabling SSL for org.apache.felix.http fails to properly restart the jetty 
> service
> --
>
> Key: FELIX-5249
> URL: https://issues.apache.org/jira/browse/FELIX-5249
> Project: Felix
>  Issue Type: Bug
>  Components: HTTP Service
>Affects Versions: http.jetty-3.1.6
>Reporter: Alexander Klimetschek
> Attachments: FELIX-5249-patch.txt
>
>
> When reconfiguring SSL for org.apache.felix.http.jetty (for a running system 
> where jetty only is configured for an HTTP port), below error happens. 
> Afterwards, jetty is not handling one or both ports anymore.
> Restarting the entire server/osgi environment fixes it. It only seems to be a 
> problem the first time or depending on timing. This happens during a somewhat 
> automatic installation procedure on an Apache Sling based server, in which 
> the osgi configuration comes in via the sling jcr installer. If I manually 
> reconfigure org.apache.felix.http.jetty in the felix webconsole and 
> enable/disable SSL, I don't see the problem.
> This is actually with org.apache.felix.http.jetty 3.1.6.B002, which seems to 
> be a special vendor release.
> {noformat}
> 05.05.2016 16:12:33.931 *ERROR* [CM Configuration Updater (Update: 
> pid=org.apache.felix.http)] org.apache.felix.configadmin Service 
> [org.apache.felix.cm.ConfigurationAdmin,10, 
> [org.osgi.service.cm.ConfigurationAdmin]] 
> [org.osgi.service.cm.ManagedService, id=57, 
> bundle=36/launchpad:resources/install/5/org.apache.felix.http.jetty-3.1.6-B002.jar]:
>  Unexpected problem updating configuration org.apache.felix.http 
> (java.util.NoSuchElementException)
> java.util.NoSuchElementException: null
>   at java.util.TreeMap.key(TreeMap.java:1221)
>   at java.util.TreeMap.lastKey(TreeMap.java:292)
>   at java.util.TreeSet.last(TreeSet.java:401)
>   at 
> org.apache.felix.http.jetty.internal.LoadBalancerCustomizerFactoryTracker.removedService(LoadBalancerCustomizerFactoryTracker.java:85)
>   at 
> org.apache.felix.http.jetty.internal.LoadBalancerCustomizerFactoryTracker.removedService(LoadBalancerCustomizerFactoryTracker.java:30)
>   at 
> org.osgi.util.tracker.ServiceTracker$Tracked.customizerRemoved(ServiceTracker.java:967)
>   at 
> org.osgi.util.tracker.ServiceTracker$Tracked.customizerRemoved(ServiceTracker.java:870)
>   at 
> org.osgi.util.tracker.AbstractTracked.untrack(AbstractTracked.java:341)
>   at org.osgi.util.tracker.ServiceTracker.close(ServiceTracker.java:377)
>   at 
> org.apache.felix.http.jetty.internal.JettyService.stopJetty(JettyService.java:225)
>   at 
> org.apache.felix.http.jetty.internal.JettyService.updated(JettyService.java:196)
>   at 
> org.apache.felix.http.jetty.internal.JettyManagedService$1.updated(JettyManagedService.java:46)
>   at 
> org.apache.felix.cm.impl.helper.ManagedServiceTracker.updated(ManagedServiceTracker.java:189)
>   at 
> org.apache.felix.cm.impl.helper.ManagedServiceTracker.updateService(ManagedServiceTracker.java:152)
>   at 
> org.apache.felix.cm.impl.helper.ManagedServiceTracker.provideConfiguration(ManagedServiceTracker.java:85)
>   at 
> org.apache.felix.cm.impl.ConfigurationManager$UpdateConfiguration.run(ConfigurationManager.java:1753)
>   at org.apache.felix.cm.impl.UpdateThread.run0(UpdateThread.java:143)
>   at org.apache.felix.cm.impl.UpdateThread.run(UpdateThread.java:110)
>   at java.lang.Thread.run(Thread.java:745)
> {noformat}



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)