[jira] [Commented] (FELIX-6455) configadmin.plugin.interpolation: default Value with "]" is interpreted wrong
[
https://issues.apache.org/jira/browse/FELIX-6455?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17408368#comment-17408368
]
Stefan Seifert commented on FELIX-6455:
---
currently, there is no concept for escaping values/string in the interpolation
syntax. FELIX-6164 introduced a special escaping support only for the first $
character, but not for the full string. imho we cannot simply fix the test case
above, we need to support escaping for the whole string e.g. with \ and then
make sure characters like \[, \], \\ etc. result in their unescaped
correspondence and have no special meaning.
looking at the already complex parser code in
[Interpolator.java|https://github.com/apache/felix-dev/blob/master/configadmin-plugins/interpolation/src/main/java/org/apache/felix/configadmin/plugin/interpolation/Interpolator.java],
i'm wondering if it makes sense to make it even more complex to add escaping
support - or if we should switch to a parser generator like javacc?
[~cziegeler] WDYT?
> configadmin.plugin.interpolation: default Value with "]" is interpreted wrong
> -
>
> Key: FELIX-6455
> URL: https://issues.apache.org/jira/browse/FELIX-6455
> Project: Felix
> Issue Type: Bug
> Components: Configuration Admin
>Reporter: Quan
>Priority: Major
>
> configadmin.plugin.interpolation interpreted the default value with "]" wrong:
> * $[env:notset;default=[8080]] => [8080](/)
> * $[env:notset;default=[aabb]cc] => [aabbcc] (x)
> To show the bug I have created a branch with a unit test:
> [https://github.com/apache/felix-dev/compare/master...orangeven:bugfix/configadmin-plugins-interpolation-default-value-with-special-chars?expand=1]
> Line 162 failed with message:
> {noformat}
> org.junit.ComparisonFailure:
> Expected :[aabb]cc
> Actual :[aabbcc]{noformat}
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Commented] (FELIX-6106) Regression after a change in maven-bundle-plugin:4.2.0 related to non-existing files
[
https://issues.apache.org/jira/browse/FELIX-6106?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16908115#comment-16908115
]
Stefan Seifert commented on FELIX-6106:
---
i've started the release process - if all goes well the release should be ready
early next week.
> Regression after a change in maven-bundle-plugin:4.2.0 related to
> non-existing files
>
>
> Key: FELIX-6106
> URL: https://issues.apache.org/jira/browse/FELIX-6106
> Project: Felix
> Issue Type: Bug
> Components: Maven Bundle Plugin
>Affects Versions: maven-bundle-plugin-4.2.0
>Reporter: Martin Grigorov
>Assignee: Stefan Seifert
>Priority: Major
> Fix For: maven-bundle-plugin-4.2.1
>
>
> Commit
> https://github.com/apache/felix/commit/9487647dc2fa8734a0ab4a113b0b93ec281a2594
> introduced with FELIX-6074 leads to an error in one of our projects:
> {code}
> INFO] --- maven-bundle-plugin:4.2.0:bundle (default-bundle) @
> wicketstuff-bundle ---
> [ERROR] An internal error occurred
> java.lang.IllegalArgumentException: A Jar can only accept a file or
> directory that exists:
> /home/solomax/work/wicketstuff-core/wicket-bundle-parent/wicket-bundle/target/classes
> at aQute.bnd.osgi.Jar. (Jar.java:124)
> at aQute.bnd.osgi.Jar. (Jar.java:172)
> at org.apache.felix.bundleplugin.BundlePlugin.getOSGiBuilder
> (BundlePlugin.java:603)
> {code}
> The code of the module can be found at
> https://github.com/wicketstuff/core/tree/master/wicket-bundle-parent/wicket-bundle.
> It is mostly Maven code (pom.xml and assembly.xml) that generates an OSGi
> compatible bundle.
> After upgrading to maven-bundle-plugin:4.2.0 it started failing with the
> above error.
--
This message was sent by Atlassian JIRA
(v7.6.14#76016)
[jira] [Resolved] (FELIX-6142) Documentation on maven-bundle-plugin
[
https://issues.apache.org/jira/browse/FELIX-6142?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Stefan Seifert resolved FELIX-6142.
---
Resolution: Fixed
you're right - documentation is fixed:
http://felix.apache.org/documentation/faqs/apache-felix-bundle-plugin-faq.html#use-scr-metadata-generated-by-bnd-in-unit-tests
> Documentation on maven-bundle-plugin
>
>
> Key: FELIX-6142
> URL: https://issues.apache.org/jira/browse/FELIX-6142
> Project: Felix
> Issue Type: Improvement
>Reporter: Ben Zahler
>Assignee: Stefan Seifert
>Priority: Minor
>
> On
> [http://felix.apache.org/documentation/faqs/apache-felix-bundle-plugin-faq.html,]
> it is documented on how to include the SCRDescriptorBndPlugin with the
> following instruction:
>
>
>
>
> <_plugin>org.apache.felix.scrplugin.bnd.SCRDescriptorBndPlugin;destdir=${project.build.outputDirectory};
>
>
>
> However, it took me a bit more than just that:
> 1. I had to include the dependecy to the plugin inside the
> maven-bundle-plugin section:
>
>
> org.apache.felix
> org.apache.felix.scr.bnd
> 1.9.4
>
>
> 2. I had to remove the final semicolon of this config:
> destdir=${project.build.outputDirectory};
> With this semicolon, I had the following message in my mvn build:
> Header contains name field after attribute or directive: null from
> org.apache.felix.scrplugin.bnd.SCRDescriptorBndPlugin;destdir=/Users/benzahler/Documents/code/repos/reponame/apps/sites/bundle/target/classes;.
> Name fields must be consecutive, separated by a ';' like a;b;c;x=3;y=4
>
>
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Assigned] (FELIX-6142) Documentation on maven-bundle-plugin
[
https://issues.apache.org/jira/browse/FELIX-6142?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Stefan Seifert reassigned FELIX-6142:
-
Assignee: Stefan Seifert
> Documentation on maven-bundle-plugin
>
>
> Key: FELIX-6142
> URL: https://issues.apache.org/jira/browse/FELIX-6142
> Project: Felix
> Issue Type: Improvement
>Reporter: Ben Zahler
>Assignee: Stefan Seifert
>Priority: Minor
>
> On
> [http://felix.apache.org/documentation/faqs/apache-felix-bundle-plugin-faq.html,]
> it is documented on how to include the SCRDescriptorBndPlugin with the
> following instruction:
>
>
>
>
> <_plugin>org.apache.felix.scrplugin.bnd.SCRDescriptorBndPlugin;destdir=${project.build.outputDirectory};
>
>
>
> However, it took me a bit more than just that:
> 1. I had to include the dependecy to the plugin inside the
> maven-bundle-plugin section:
>
>
> org.apache.felix
> org.apache.felix.scr.bnd
> 1.9.4
>
>
> 2. I had to remove the final semicolon of this config:
> destdir=${project.build.outputDirectory};
> With this semicolon, I had the following message in my mvn build:
> Header contains name field after attribute or directive: null from
> org.apache.felix.scrplugin.bnd.SCRDescriptorBndPlugin;destdir=/Users/benzahler/Documents/code/repos/reponame/apps/sites/bundle/target/classes;.
> Name fields must be consecutive, separated by a ';' like a;b;c;x=3;y=4
>
>
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (FELIX-6106) Regression after a change in maven-bundle-plugin:4.2.0 related to non-existing files
[
https://issues.apache.org/jira/browse/FELIX-6106?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16836986#comment-16836986
]
Stefan Seifert commented on FELIX-6106:
---
in felix osgi bundles are usually versioned using an even/odd version number
scheme for the third digit.
but there is no real need to do it for maven plugins, though - although it's
often done as a habit anyways.
setting next version to 4.2.1 here.
> Regression after a change in maven-bundle-plugin:4.2.0 related to
> non-existing files
>
>
> Key: FELIX-6106
> URL: https://issues.apache.org/jira/browse/FELIX-6106
> Project: Felix
> Issue Type: Bug
> Components: Maven Bundle Plugin
>Affects Versions: maven-bundle-plugin-4.2.0
>Reporter: Martin Grigorov
>Assignee: Stefan Seifert
>Priority: Major
> Fix For: maven-bundle-plugin-4.2.1
>
>
> Commit
> https://github.com/apache/felix/commit/9487647dc2fa8734a0ab4a113b0b93ec281a2594
> introduced with FELIX-6074 leads to an error in one of our projects:
> {code}
> INFO] --- maven-bundle-plugin:4.2.0:bundle (default-bundle) @
> wicketstuff-bundle ---
> [ERROR] An internal error occurred
> java.lang.IllegalArgumentException: A Jar can only accept a file or
> directory that exists:
> /home/solomax/work/wicketstuff-core/wicket-bundle-parent/wicket-bundle/target/classes
> at aQute.bnd.osgi.Jar. (Jar.java:124)
> at aQute.bnd.osgi.Jar. (Jar.java:172)
> at org.apache.felix.bundleplugin.BundlePlugin.getOSGiBuilder
> (BundlePlugin.java:603)
> {code}
> The code of the module can be found at
> https://github.com/wicketstuff/core/tree/master/wicket-bundle-parent/wicket-bundle.
> It is mostly Maven code (pom.xml and assembly.xml) that generates an OSGi
> compatible bundle.
> After upgrading to maven-bundle-plugin:4.2.0 it started failing with the
> above error.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Resolved] (FELIX-6106) Regression after a change in maven-bundle-plugin:4.2.0 related to non-existing files
[
https://issues.apache.org/jira/browse/FELIX-6106?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Stefan Seifert resolved FELIX-6106.
---
Resolution: Fixed
Fix Version/s: maven-bundle-plugin-4.2.2
Completed: At revision: 1859009
i've implemented a fix for the problem.
can you confirm it works as expected with 4.2.1-SNAPSHOT?
> Regression after a change in maven-bundle-plugin:4.2.0 related to
> non-existing files
>
>
> Key: FELIX-6106
> URL: https://issues.apache.org/jira/browse/FELIX-6106
> Project: Felix
> Issue Type: Bug
> Components: Maven Bundle Plugin
>Affects Versions: maven-bundle-plugin-4.2.0
>Reporter: Martin Grigorov
>Assignee: Stefan Seifert
>Priority: Major
> Fix For: maven-bundle-plugin-4.2.2
>
>
> Commit
> https://github.com/apache/felix/commit/9487647dc2fa8734a0ab4a113b0b93ec281a2594
> introduced with FELIX-6074 leads to an error in one of our projects:
> {code}
> INFO] --- maven-bundle-plugin:4.2.0:bundle (default-bundle) @
> wicketstuff-bundle ---
> [ERROR] An internal error occurred
> java.lang.IllegalArgumentException: A Jar can only accept a file or
> directory that exists:
> /home/solomax/work/wicketstuff-core/wicket-bundle-parent/wicket-bundle/target/classes
> at aQute.bnd.osgi.Jar. (Jar.java:124)
> at aQute.bnd.osgi.Jar. (Jar.java:172)
> at org.apache.felix.bundleplugin.BundlePlugin.getOSGiBuilder
> (BundlePlugin.java:603)
> {code}
> The code of the module can be found at
> https://github.com/wicketstuff/core/tree/master/wicket-bundle-parent/wicket-bundle.
> It is mostly Maven code (pom.xml and assembly.xml) that generates an OSGi
> compatible bundle.
> After upgrading to maven-bundle-plugin:4.2.0 it started failing with the
> above error.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Assigned] (FELIX-6106) Regression after a change in maven-bundle-plugin:4.2.0 related to non-existing files
[
https://issues.apache.org/jira/browse/FELIX-6106?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Stefan Seifert reassigned FELIX-6106:
-
Assignee: Stefan Seifert
as far a i see the problem was introduced one commit before:
https://github.com/apache/felix/commit/e12e94cb84d99e4613a4a57c3655bc7c6095140c
it seems the collection of class path items with this refactoring includes also
items that does not exist yet (in this case the target/classes folder - because
in this case this project produced no classes at all but combines only
artifacts from dependencies).
> Regression after a change in maven-bundle-plugin:4.2.0 related to
> non-existing files
>
>
> Key: FELIX-6106
> URL: https://issues.apache.org/jira/browse/FELIX-6106
> Project: Felix
> Issue Type: Bug
> Components: Maven Bundle Plugin
>Affects Versions: maven-bundle-plugin-4.2.0
>Reporter: Martin Grigorov
>Assignee: Stefan Seifert
>Priority: Major
>
> Commit
> https://github.com/apache/felix/commit/9487647dc2fa8734a0ab4a113b0b93ec281a2594
> introduced with FELIX-6074 leads to an error in one of our projects:
> {code}
> INFO] --- maven-bundle-plugin:4.2.0:bundle (default-bundle) @
> wicketstuff-bundle ---
> [ERROR] An internal error occurred
> java.lang.IllegalArgumentException: A Jar can only accept a file or
> directory that exists:
> /home/solomax/work/wicketstuff-core/wicket-bundle-parent/wicket-bundle/target/classes
> at aQute.bnd.osgi.Jar. (Jar.java:124)
> at aQute.bnd.osgi.Jar. (Jar.java:172)
> at org.apache.felix.bundleplugin.BundlePlugin.getOSGiBuilder
> (BundlePlugin.java:603)
> {code}
> The code of the module can be found at
> https://github.com/wicketstuff/core/tree/master/wicket-bundle-parent/wicket-bundle.
> It is mostly Maven code (pom.xml and assembly.xml) that generates an OSGi
> compatible bundle.
> After upgrading to maven-bundle-plugin:4.2.0 it started failing with the
> above error.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (FELIX-6125) maven-bundle-plugin changelog.txt out of date
[ https://issues.apache.org/jira/browse/FELIX-6125?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16836362#comment-16836362 ] Stefan Seifert commented on FELIX-6125: --- i've also uploaded the latest plugin documentation to http://felix.apache.org/components/bundle-plugin/ > maven-bundle-plugin changelog.txt out of date > - > > Key: FELIX-6125 > URL: https://issues.apache.org/jira/browse/FELIX-6125 > Project: Felix > Issue Type: Task > Components: Documentation >Affects Versions: maven-bundle-plugin-4.2.0 >Reporter: Ludwig Schmidt >Assignee: Stefan Seifert >Priority: Trivial > > The maven-bundle-plugin changelog only includes changes up to version 3.5.0. > See: > [https://svn.apache.org/repos/asf/felix/releases/maven-bundle-plugin-4.2.0/changelog.txt] -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Updated] (FELIX-6125) maven-bundle-plugin changelog.txt out of date
[ https://issues.apache.org/jira/browse/FELIX-6125?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Stefan Seifert updated FELIX-6125: -- Priority: Trivial (was: Major) Issue Type: Task (was: Bug) > maven-bundle-plugin changelog.txt out of date > - > > Key: FELIX-6125 > URL: https://issues.apache.org/jira/browse/FELIX-6125 > Project: Felix > Issue Type: Task > Components: Documentation >Affects Versions: maven-bundle-plugin-4.2.0 >Reporter: Ludwig Schmidt >Assignee: Stefan Seifert >Priority: Trivial > > The maven-bundle-plugin changelog only includes changes up to version 3.5.0. > See: > [https://svn.apache.org/repos/asf/felix/releases/maven-bundle-plugin-4.2.0/changelog.txt] -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Resolved] (FELIX-6125) maven-bundle-plugin changelog.txt out of date
[ https://issues.apache.org/jira/browse/FELIX-6125?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Stefan Seifert resolved FELIX-6125. --- Resolution: Fixed Completed: At revision: 1858996 i've updated the changelogs for 4.0, 4.1 and 4.2 > maven-bundle-plugin changelog.txt out of date > - > > Key: FELIX-6125 > URL: https://issues.apache.org/jira/browse/FELIX-6125 > Project: Felix > Issue Type: Bug > Components: Documentation >Affects Versions: maven-bundle-plugin-4.2.0 >Reporter: Ludwig Schmidt >Assignee: Stefan Seifert >Priority: Major > > The maven-bundle-plugin changelog only includes changes up to version 3.5.0. > See: > [https://svn.apache.org/repos/asf/felix/releases/maven-bundle-plugin-4.2.0/changelog.txt] -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Assigned] (FELIX-6125) maven-bundle-plugin changelog.txt out of date
[ https://issues.apache.org/jira/browse/FELIX-6125?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Stefan Seifert reassigned FELIX-6125: - Assignee: Stefan Seifert > maven-bundle-plugin changelog.txt out of date > - > > Key: FELIX-6125 > URL: https://issues.apache.org/jira/browse/FELIX-6125 > Project: Felix > Issue Type: Bug > Components: Documentation >Affects Versions: maven-bundle-plugin-4.2.0 >Reporter: Ludwig Schmidt >Assignee: Stefan Seifert >Priority: Major > > The maven-bundle-plugin changelog only includes changes up to version 3.5.0. > See: > [https://svn.apache.org/repos/asf/felix/releases/maven-bundle-plugin-4.2.0/changelog.txt] -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Closed] (FELIX-6122) SCR Tooling: Update to ASM 7.1 for Java 11 compatibility
[ https://issues.apache.org/jira/browse/FELIX-6122?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Stefan Seifert closed FELIX-6122. - > SCR Tooling: Update to ASM 7.1 for Java 11 compatibility > > > Key: FELIX-6122 > URL: https://issues.apache.org/jira/browse/FELIX-6122 > Project: Felix > Issue Type: Improvement > Components: SCR Tooling >Affects Versions: maven-scr-plugin 1.26.0, scr generator 1.18.0, scr bnd > plugin 1.9.2 >Reporter: Stefan Seifert >Assignee: Stefan Seifert >Priority: Major > Fix For: scr bnd plugin 1.9.4, scr generator 1.18.2, > maven-scr-plugin 1.26.2 > > > the BND tooling is currently based on ASM 5.1, which does not support class > files generated by newer java versions (e.g. Java 11). Updating to ASM 7.1 > fixes this. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Resolved] (FELIX-6122) SCR Tooling: Update to ASM 7.1 for Java 11 compatibility
[ https://issues.apache.org/jira/browse/FELIX-6122?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Stefan Seifert resolved FELIX-6122. --- Resolution: Fixed Fix Version/s: maven-scr-plugin 1.26.2 scr generator 1.18.2 scr bnd plugin 1.9.4 Completed: At revision: 1858783 > SCR Tooling: Update to ASM 7.1 for Java 11 compatibility > > > Key: FELIX-6122 > URL: https://issues.apache.org/jira/browse/FELIX-6122 > Project: Felix > Issue Type: Improvement > Components: SCR Tooling >Affects Versions: maven-scr-plugin 1.26.0, scr generator 1.18.0, scr bnd > plugin 1.9.2 >Reporter: Stefan Seifert >Assignee: Stefan Seifert >Priority: Major > Fix For: scr bnd plugin 1.9.4, scr generator 1.18.2, > maven-scr-plugin 1.26.2 > > > the BND tooling is currently based on ASM 5.1, which does not support class > files generated by newer java versions (e.g. Java 11). Updating to ASM 7.1 > fixes this. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Updated] (FELIX-6122) SCR Tooling: Update to ASM 7.1 for Java 11 compatibility
[ https://issues.apache.org/jira/browse/FELIX-6122?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Stefan Seifert updated FELIX-6122: -- Summary: SCR Tooling: Update to ASM 7.1 for Java 11 compatibility (was: SCR Tooling: Update to ASM 7.1 to support latest Java versions) > SCR Tooling: Update to ASM 7.1 for Java 11 compatibility > > > Key: FELIX-6122 > URL: https://issues.apache.org/jira/browse/FELIX-6122 > Project: Felix > Issue Type: Improvement > Components: SCR Tooling >Affects Versions: maven-scr-plugin-1.26.0, scr generator 1.18.0, scr bnd > plugin 1.9.2 >Reporter: Stefan Seifert >Assignee: Stefan Seifert >Priority: Major > > the BND tooling is currently based on ASM 5.1, which does not support class > files generated by newer java versions (e.g. Java 11). Updating to ASM 7.1 > fixes this. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Created] (FELIX-6122) SCR Tooling: Update to ASM 7.1 to support latest Java versions
Stefan Seifert created FELIX-6122: - Summary: SCR Tooling: Update to ASM 7.1 to support latest Java versions Key: FELIX-6122 URL: https://issues.apache.org/jira/browse/FELIX-6122 Project: Felix Issue Type: Improvement Components: SCR Tooling Affects Versions: scr bnd plugin 1.9.2, scr generator 1.18.0, maven-scr-plugin-1.26.0 Reporter: Stefan Seifert Assignee: Stefan Seifert the BND tooling is currently based on ASM 5.1, which does not support class files generated by newer java versions (e.g. Java 11). Updating to ASM 7.1 fixes this. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Closed] (FELIX-6023) SCR bnd plugin sometimes fails with IncompatibleClassChangeError: Implementing class
[
https://issues.apache.org/jira/browse/FELIX-6023?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Stefan Seifert closed FELIX-6023.
-
> SCR bnd plugin sometimes fails with IncompatibleClassChangeError:
> Implementing class
>
>
> Key: FELIX-6023
> URL: https://issues.apache.org/jira/browse/FELIX-6023
> Project: Felix
> Issue Type: Bug
> Components: SCR Tooling
>Affects Versions: scr bnd plugin 1.9.0
> Environment: Maven home: /usr/local/Cellar/maven/3.6.0/libexec
> Java version: 1.8.0_192, vendor: Oracle Corporation, runtime:
> /Library/Java/JavaVirtualMachines/jdk1.8.0_192.jdk/Contents/Home/jre
> Default locale: en_US, platform encoding: UTF-8
> OS name: "mac os x", version: "10.14.2", arch: "x86_64", family: "mac"
>Reporter: Mark Adamcin
>Assignee: Stefan Seifert
>Priority: Major
> Labels: patch-available
> Fix For: scr bnd plugin 1.9.2
>
> Attachments: com.adobe.acs.acs-aem-commons-bundle.bnd-1.9.0.log,
> com.adobe.acs.acs-aem-commons-bundle.bnd-1.9.1-SNAPSHOT.log
>
>
>
> When building a project where a newer version of a dependency is embedded in
> the project artifact with a conflicting older version of said dependency is
> also present on the classpath, SOME environments encounter an exception that
> is similar to the following:
> {noformat}
> [ERROR] Manifest com.adobe.acs:acs-aem-commons-bundle:bundle:3.19.1-SNAPSHOT
> : Got unexpected exception while
> analyzing:org.apache.felix.scrplugin.SCRDescriptorException: Unable to load
> compiled class: com.google.common.base.Suppliers$SupplierFunctionImpl
> at
> org.apache.felix.scrplugin.helper.ClassScanner.scanSources(ClassScanner.java:156)
> at
> org.apache.felix.scrplugin.SCRDescriptorGenerator.execute(SCRDescriptorGenerator.java:146)
> at
> org.apache.felix.scrplugin.bnd.SCRDescriptorBndPlugin.analyzeJar(SCRDescriptorBndPlugin.java:178)
> at aQute.bnd.osgi.Analyzer.doPlugins(Analyzer.java:820)
> at aQute.bnd.osgi.Analyzer.analyze(Analyzer.java:229)
> at aQute.bnd.osgi.Builder.analyze(Builder.java:408)
> at aQute.bnd.osgi.Analyzer.calcManifest(Analyzer.java:850)
> at aQute.bnd.osgi.Builder.build(Builder.java:116)
> at
> org.apache.felix.bundleplugin.ManifestPlugin.getAnalyzer(ManifestPlugin.java:291)
> at
> org.apache.felix.bundleplugin.ManifestPlugin.execute(ManifestPlugin.java:98)
> at
> org.apache.felix.bundleplugin.BundlePlugin.execute(BundlePlugin.java:384)
> at
> org.apache.felix.bundleplugin.BundlePlugin.execute(BundlePlugin.java:375)
> at
> org.apache.maven.plugin.DefaultBuildPluginManager.executeMojo(DefaultBuildPluginManager.java:137)
> at
> org.apache.maven.lifecycle.internal.MojoExecutor.execute(MojoExecutor.java:210)
> at
> org.apache.maven.lifecycle.internal.MojoExecutor.execute(MojoExecutor.java:156)
> at
> org.apache.maven.lifecycle.internal.MojoExecutor.execute(MojoExecutor.java:148)
> at
> org.apache.maven.lifecycle.internal.LifecycleModuleBuilder.buildProject(LifecycleModuleBuilder.java:117)
> at
> org.apache.maven.lifecycle.internal.LifecycleModuleBuilder.buildProject(LifecycleModuleBuilder.java:81)
> at
> org.apache.maven.lifecycle.internal.builder.singlethreaded.SingleThreadedBuilder.build(SingleThreadedBuilder.java:56)
> at
> org.apache.maven.lifecycle.internal.LifecycleStarter.execute(LifecycleStarter.java:128)
> at org.apache.maven.DefaultMaven.doExecute(DefaultMaven.java:305)
> at org.apache.maven.DefaultMaven.doExecute(DefaultMaven.java:192)
> at org.apache.maven.DefaultMaven.execute(DefaultMaven.java:105)
> at org.apache.maven.cli.MavenCli.execute(MavenCli.java:956)
> at org.apache.maven.cli.MavenCli.doMain(MavenCli.java:288)
> at org.apache.maven.cli.MavenCli.main(MavenCli.java:192)
> at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
> at
> sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)
> at
> sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
> at java.lang.reflect.Method.invoke(Method.java:498)
> at
> org.codehaus.plexus.classworlds.launcher.Launcher.launchEnhanced(Launcher.java:289)
> at
> org.codehaus.plexus.classworlds.launcher.Launcher.launch(Launcher.java:229)
> at
> org.codehaus.plexus.classworlds.launcher.Launcher.mainWithExitCode(Launcher.java:415)
> at
> org.codehaus.plexus.classworlds.launcher.Launcher.main(Launcher.java:356)
> Caused by: java.lang.IncompatibleClassChangeError: Implementing class
> at java.lang.ClassLoader.defineClass1(Native Method)
> at java.lang.ClassLoader.defineClass(ClassLoader.java
[jira] [Commented] (FELIX-6023) SCR bnd plugin sometimes fails with IncompatibleClassChangeError: Implementing class
[
https://issues.apache.org/jira/browse/FELIX-6023?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16749670#comment-16749670
]
Stefan Seifert commented on FELIX-6023:
---
yes, i can start a release vote today
> SCR bnd plugin sometimes fails with IncompatibleClassChangeError:
> Implementing class
>
>
> Key: FELIX-6023
> URL: https://issues.apache.org/jira/browse/FELIX-6023
> Project: Felix
> Issue Type: Bug
> Components: SCR Tooling
>Affects Versions: scr bnd plugin 1.9.0
> Environment: Maven home: /usr/local/Cellar/maven/3.6.0/libexec
> Java version: 1.8.0_192, vendor: Oracle Corporation, runtime:
> /Library/Java/JavaVirtualMachines/jdk1.8.0_192.jdk/Contents/Home/jre
> Default locale: en_US, platform encoding: UTF-8
> OS name: "mac os x", version: "10.14.2", arch: "x86_64", family: "mac"
>Reporter: Mark Adamcin
>Assignee: Stefan Seifert
>Priority: Major
> Labels: patch-available
> Fix For: scr bnd plugin 1.10.0
>
> Attachments: com.adobe.acs.acs-aem-commons-bundle.bnd-1.9.0.log,
> com.adobe.acs.acs-aem-commons-bundle.bnd-1.9.1-SNAPSHOT.log
>
>
>
> When building a project where a newer version of a dependency is embedded in
> the project artifact with a conflicting older version of said dependency is
> also present on the classpath, SOME environments encounter an exception that
> is similar to the following:
> {noformat}
> [ERROR] Manifest com.adobe.acs:acs-aem-commons-bundle:bundle:3.19.1-SNAPSHOT
> : Got unexpected exception while
> analyzing:org.apache.felix.scrplugin.SCRDescriptorException: Unable to load
> compiled class: com.google.common.base.Suppliers$SupplierFunctionImpl
> at
> org.apache.felix.scrplugin.helper.ClassScanner.scanSources(ClassScanner.java:156)
> at
> org.apache.felix.scrplugin.SCRDescriptorGenerator.execute(SCRDescriptorGenerator.java:146)
> at
> org.apache.felix.scrplugin.bnd.SCRDescriptorBndPlugin.analyzeJar(SCRDescriptorBndPlugin.java:178)
> at aQute.bnd.osgi.Analyzer.doPlugins(Analyzer.java:820)
> at aQute.bnd.osgi.Analyzer.analyze(Analyzer.java:229)
> at aQute.bnd.osgi.Builder.analyze(Builder.java:408)
> at aQute.bnd.osgi.Analyzer.calcManifest(Analyzer.java:850)
> at aQute.bnd.osgi.Builder.build(Builder.java:116)
> at
> org.apache.felix.bundleplugin.ManifestPlugin.getAnalyzer(ManifestPlugin.java:291)
> at
> org.apache.felix.bundleplugin.ManifestPlugin.execute(ManifestPlugin.java:98)
> at
> org.apache.felix.bundleplugin.BundlePlugin.execute(BundlePlugin.java:384)
> at
> org.apache.felix.bundleplugin.BundlePlugin.execute(BundlePlugin.java:375)
> at
> org.apache.maven.plugin.DefaultBuildPluginManager.executeMojo(DefaultBuildPluginManager.java:137)
> at
> org.apache.maven.lifecycle.internal.MojoExecutor.execute(MojoExecutor.java:210)
> at
> org.apache.maven.lifecycle.internal.MojoExecutor.execute(MojoExecutor.java:156)
> at
> org.apache.maven.lifecycle.internal.MojoExecutor.execute(MojoExecutor.java:148)
> at
> org.apache.maven.lifecycle.internal.LifecycleModuleBuilder.buildProject(LifecycleModuleBuilder.java:117)
> at
> org.apache.maven.lifecycle.internal.LifecycleModuleBuilder.buildProject(LifecycleModuleBuilder.java:81)
> at
> org.apache.maven.lifecycle.internal.builder.singlethreaded.SingleThreadedBuilder.build(SingleThreadedBuilder.java:56)
> at
> org.apache.maven.lifecycle.internal.LifecycleStarter.execute(LifecycleStarter.java:128)
> at org.apache.maven.DefaultMaven.doExecute(DefaultMaven.java:305)
> at org.apache.maven.DefaultMaven.doExecute(DefaultMaven.java:192)
> at org.apache.maven.DefaultMaven.execute(DefaultMaven.java:105)
> at org.apache.maven.cli.MavenCli.execute(MavenCli.java:956)
> at org.apache.maven.cli.MavenCli.doMain(MavenCli.java:288)
> at org.apache.maven.cli.MavenCli.main(MavenCli.java:192)
> at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
> at
> sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)
> at
> sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
> at java.lang.reflect.Method.invoke(Method.java:498)
> at
> org.codehaus.plexus.classworlds.launcher.Launcher.launchEnhanced(Launcher.java:289)
> at
> org.codehaus.plexus.classworlds.launcher.Launcher.launch(Launcher.java:229)
> at
> org.codehaus.plexus.classworlds.launcher.Launcher.mainWithExitCode(Launcher.java:415)
> at
> org.codehaus.plexus.classworlds.launcher.Launcher.main(Launcher.java:356)
> Caused by: java.lang.IncompatibleClassChangeError: Implementing class
> at java.lang.Cl
[jira] [Resolved] (FELIX-6023) SCR bnd plugin sometimes fails with IncompatibleClassChangeError: Implementing class
[
https://issues.apache.org/jira/browse/FELIX-6023?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Stefan Seifert resolved FELIX-6023.
---
Resolution: Fixed
Fix Version/s: scr bnd plugin 1.10.0
thanks, patch applied in rev. 1851503
> SCR bnd plugin sometimes fails with IncompatibleClassChangeError:
> Implementing class
>
>
> Key: FELIX-6023
> URL: https://issues.apache.org/jira/browse/FELIX-6023
> Project: Felix
> Issue Type: Bug
> Components: SCR Tooling
>Affects Versions: scr bnd plugin 1.9.0
> Environment: Maven home: /usr/local/Cellar/maven/3.6.0/libexec
> Java version: 1.8.0_192, vendor: Oracle Corporation, runtime:
> /Library/Java/JavaVirtualMachines/jdk1.8.0_192.jdk/Contents/Home/jre
> Default locale: en_US, platform encoding: UTF-8
> OS name: "mac os x", version: "10.14.2", arch: "x86_64", family: "mac"
>Reporter: Mark Adamcin
>Assignee: Stefan Seifert
>Priority: Major
> Labels: patch-available
> Fix For: scr bnd plugin 1.10.0
>
> Attachments: com.adobe.acs.acs-aem-commons-bundle.bnd-1.9.0.log,
> com.adobe.acs.acs-aem-commons-bundle.bnd-1.9.1-SNAPSHOT.log
>
>
>
> When building a project where a newer version of a dependency is embedded in
> the project artifact with a conflicting older version of said dependency is
> also present on the classpath, SOME environments encounter an exception that
> is similar to the following:
> {noformat}
> [ERROR] Manifest com.adobe.acs:acs-aem-commons-bundle:bundle:3.19.1-SNAPSHOT
> : Got unexpected exception while
> analyzing:org.apache.felix.scrplugin.SCRDescriptorException: Unable to load
> compiled class: com.google.common.base.Suppliers$SupplierFunctionImpl
> at
> org.apache.felix.scrplugin.helper.ClassScanner.scanSources(ClassScanner.java:156)
> at
> org.apache.felix.scrplugin.SCRDescriptorGenerator.execute(SCRDescriptorGenerator.java:146)
> at
> org.apache.felix.scrplugin.bnd.SCRDescriptorBndPlugin.analyzeJar(SCRDescriptorBndPlugin.java:178)
> at aQute.bnd.osgi.Analyzer.doPlugins(Analyzer.java:820)
> at aQute.bnd.osgi.Analyzer.analyze(Analyzer.java:229)
> at aQute.bnd.osgi.Builder.analyze(Builder.java:408)
> at aQute.bnd.osgi.Analyzer.calcManifest(Analyzer.java:850)
> at aQute.bnd.osgi.Builder.build(Builder.java:116)
> at
> org.apache.felix.bundleplugin.ManifestPlugin.getAnalyzer(ManifestPlugin.java:291)
> at
> org.apache.felix.bundleplugin.ManifestPlugin.execute(ManifestPlugin.java:98)
> at
> org.apache.felix.bundleplugin.BundlePlugin.execute(BundlePlugin.java:384)
> at
> org.apache.felix.bundleplugin.BundlePlugin.execute(BundlePlugin.java:375)
> at
> org.apache.maven.plugin.DefaultBuildPluginManager.executeMojo(DefaultBuildPluginManager.java:137)
> at
> org.apache.maven.lifecycle.internal.MojoExecutor.execute(MojoExecutor.java:210)
> at
> org.apache.maven.lifecycle.internal.MojoExecutor.execute(MojoExecutor.java:156)
> at
> org.apache.maven.lifecycle.internal.MojoExecutor.execute(MojoExecutor.java:148)
> at
> org.apache.maven.lifecycle.internal.LifecycleModuleBuilder.buildProject(LifecycleModuleBuilder.java:117)
> at
> org.apache.maven.lifecycle.internal.LifecycleModuleBuilder.buildProject(LifecycleModuleBuilder.java:81)
> at
> org.apache.maven.lifecycle.internal.builder.singlethreaded.SingleThreadedBuilder.build(SingleThreadedBuilder.java:56)
> at
> org.apache.maven.lifecycle.internal.LifecycleStarter.execute(LifecycleStarter.java:128)
> at org.apache.maven.DefaultMaven.doExecute(DefaultMaven.java:305)
> at org.apache.maven.DefaultMaven.doExecute(DefaultMaven.java:192)
> at org.apache.maven.DefaultMaven.execute(DefaultMaven.java:105)
> at org.apache.maven.cli.MavenCli.execute(MavenCli.java:956)
> at org.apache.maven.cli.MavenCli.doMain(MavenCli.java:288)
> at org.apache.maven.cli.MavenCli.main(MavenCli.java:192)
> at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
> at
> sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)
> at
> sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
> at java.lang.reflect.Method.invoke(Method.java:498)
> at
> org.codehaus.plexus.classworlds.launcher.Launcher.launchEnhanced(Launcher.java:289)
> at
> org.codehaus.plexus.classworlds.launcher.Launcher.launch(Launcher.java:229)
> at
> org.codehaus.plexus.classworlds.launcher.Launcher.mainWithExitCode(Launcher.java:415)
> at
> org.codehaus.plexus.classworlds.launcher.Launcher.main(Launcher.java:356)
> Caused by: java.lang.IncompatibleClassChangeError: Implementing class
> at j
[jira] [Assigned] (FELIX-6023) SCR bnd plugin sometimes fails with IncompatibleClassChangeError: Implementing class
[
https://issues.apache.org/jira/browse/FELIX-6023?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Stefan Seifert reassigned FELIX-6023:
-
Assignee: Stefan Seifert
> SCR bnd plugin sometimes fails with IncompatibleClassChangeError:
> Implementing class
>
>
> Key: FELIX-6023
> URL: https://issues.apache.org/jira/browse/FELIX-6023
> Project: Felix
> Issue Type: Bug
> Components: SCR Tooling
>Affects Versions: scr bnd plugin 1.9.0
> Environment: Maven home: /usr/local/Cellar/maven/3.6.0/libexec
> Java version: 1.8.0_192, vendor: Oracle Corporation, runtime:
> /Library/Java/JavaVirtualMachines/jdk1.8.0_192.jdk/Contents/Home/jre
> Default locale: en_US, platform encoding: UTF-8
> OS name: "mac os x", version: "10.14.2", arch: "x86_64", family: "mac"
>Reporter: Mark Adamcin
>Assignee: Stefan Seifert
>Priority: Major
> Labels: patch-available
> Attachments: com.adobe.acs.acs-aem-commons-bundle.bnd-1.9.0.log,
> com.adobe.acs.acs-aem-commons-bundle.bnd-1.9.1-SNAPSHOT.log
>
>
>
> When building a project where a newer version of a dependency is embedded in
> the project artifact with a conflicting older version of said dependency is
> also present on the classpath, SOME environments encounter an exception that
> is similar to the following:
> {noformat}
> [ERROR] Manifest com.adobe.acs:acs-aem-commons-bundle:bundle:3.19.1-SNAPSHOT
> : Got unexpected exception while
> analyzing:org.apache.felix.scrplugin.SCRDescriptorException: Unable to load
> compiled class: com.google.common.base.Suppliers$SupplierFunctionImpl
> at
> org.apache.felix.scrplugin.helper.ClassScanner.scanSources(ClassScanner.java:156)
> at
> org.apache.felix.scrplugin.SCRDescriptorGenerator.execute(SCRDescriptorGenerator.java:146)
> at
> org.apache.felix.scrplugin.bnd.SCRDescriptorBndPlugin.analyzeJar(SCRDescriptorBndPlugin.java:178)
> at aQute.bnd.osgi.Analyzer.doPlugins(Analyzer.java:820)
> at aQute.bnd.osgi.Analyzer.analyze(Analyzer.java:229)
> at aQute.bnd.osgi.Builder.analyze(Builder.java:408)
> at aQute.bnd.osgi.Analyzer.calcManifest(Analyzer.java:850)
> at aQute.bnd.osgi.Builder.build(Builder.java:116)
> at
> org.apache.felix.bundleplugin.ManifestPlugin.getAnalyzer(ManifestPlugin.java:291)
> at
> org.apache.felix.bundleplugin.ManifestPlugin.execute(ManifestPlugin.java:98)
> at
> org.apache.felix.bundleplugin.BundlePlugin.execute(BundlePlugin.java:384)
> at
> org.apache.felix.bundleplugin.BundlePlugin.execute(BundlePlugin.java:375)
> at
> org.apache.maven.plugin.DefaultBuildPluginManager.executeMojo(DefaultBuildPluginManager.java:137)
> at
> org.apache.maven.lifecycle.internal.MojoExecutor.execute(MojoExecutor.java:210)
> at
> org.apache.maven.lifecycle.internal.MojoExecutor.execute(MojoExecutor.java:156)
> at
> org.apache.maven.lifecycle.internal.MojoExecutor.execute(MojoExecutor.java:148)
> at
> org.apache.maven.lifecycle.internal.LifecycleModuleBuilder.buildProject(LifecycleModuleBuilder.java:117)
> at
> org.apache.maven.lifecycle.internal.LifecycleModuleBuilder.buildProject(LifecycleModuleBuilder.java:81)
> at
> org.apache.maven.lifecycle.internal.builder.singlethreaded.SingleThreadedBuilder.build(SingleThreadedBuilder.java:56)
> at
> org.apache.maven.lifecycle.internal.LifecycleStarter.execute(LifecycleStarter.java:128)
> at org.apache.maven.DefaultMaven.doExecute(DefaultMaven.java:305)
> at org.apache.maven.DefaultMaven.doExecute(DefaultMaven.java:192)
> at org.apache.maven.DefaultMaven.execute(DefaultMaven.java:105)
> at org.apache.maven.cli.MavenCli.execute(MavenCli.java:956)
> at org.apache.maven.cli.MavenCli.doMain(MavenCli.java:288)
> at org.apache.maven.cli.MavenCli.main(MavenCli.java:192)
> at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
> at
> sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)
> at
> sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
> at java.lang.reflect.Method.invoke(Method.java:498)
> at
> org.codehaus.plexus.classworlds.launcher.Launcher.launchEnhanced(Launcher.java:289)
> at
> org.codehaus.plexus.classworlds.launcher.Launcher.launch(Launcher.java:229)
> at
> org.codehaus.plexus.classworlds.launcher.Launcher.mainWithExitCode(Launcher.java:415)
> at
> org.codehaus.plexus.classworlds.launcher.Launcher.main(Launcher.java:356)
> Caused by: java.lang.IncompatibleClassChangeError: Implementing class
> at java.lang.ClassLoader.defineClass1(Native Method)
> at java.lang.ClassLoader.defineClass(ClassLoader.java:763)
>
[jira] [Closed] (FELIX-5764) Update to bnd version 3.5
[ https://issues.apache.org/jira/browse/FELIX-5764?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Stefan Seifert closed FELIX-5764. - > Update to bnd version 3.5 > - > > Key: FELIX-5764 > URL: https://issues.apache.org/jira/browse/FELIX-5764 > Project: Felix > Issue Type: Improvement > Components: Maven Bundle Plugin >Affects Versions: maven-bundle-plugin-3.4.0 >Reporter: Neil Bartlett >Assignee: Neil Bartlett > Fix For: maven-bundle-plugin-3.5.0 > > > We just updated the plugin to bnd 3.4 but it is still behind the latest > release of bnd which is 3.5. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Resolved] (FELIX-5712) Maven Bundle Plugin - Broken and non https links
[ https://issues.apache.org/jira/browse/FELIX-5712?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Stefan Seifert resolved FELIX-5712. --- Resolution: Fixed Completed: At revision: 1817515 should be solved with the next release > Maven Bundle Plugin - Broken and non https links > > > Key: FELIX-5712 > URL: https://issues.apache.org/jira/browse/FELIX-5712 > Project: Felix > Issue Type: Bug > Components: Maven Bundle Plugin >Affects Versions: maven-bundle-plugin-3.3.0 > Environment: Website only >Reporter: Robin van Riel >Assignee: Stefan Seifert >Priority: Trivial > Fix For: maven-bundle-plugin-3.4.0 > > > The linking from > https://commons.apache.org/proper/commons-weaver/commons-weaver-build-tools/plugins.html > to https://felix.apache.org/maven-bundle-plugin/ seems to be broken. Also, > the former page seems to contain http links instead of https ones. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Assigned] (FELIX-5712) Maven Bundle Plugin - Broken and non https links
[ https://issues.apache.org/jira/browse/FELIX-5712?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Stefan Seifert reassigned FELIX-5712: - Assignee: Stefan Seifert Affects Version/s: maven-bundle-plugin-3.3.0 Priority: Trivial (was: Minor) Fix Version/s: maven-bundle-plugin-3.4.0 Component/s: (was: Felix Commons) Maven Bundle Plugin Summary: Maven Bundle Plugin - Broken and non https links (was: Broken and non https links) the problem is the generated for the maven-bundle-plugin - it's automatically generated from the url of the parent pom (https://felix.apache.org) and the artifact id is appended - which results in the wrong url. the felix website is by default still used with HTTP (although HTTPs works as well). > Maven Bundle Plugin - Broken and non https links > > > Key: FELIX-5712 > URL: https://issues.apache.org/jira/browse/FELIX-5712 > Project: Felix > Issue Type: Bug > Components: Maven Bundle Plugin >Affects Versions: maven-bundle-plugin-3.3.0 > Environment: Website only >Reporter: Robin van Riel >Assignee: Stefan Seifert >Priority: Trivial > Fix For: maven-bundle-plugin-3.4.0 > > > The linking from > https://commons.apache.org/proper/commons-weaver/commons-weaver-build-tools/plugins.html > to https://felix.apache.org/maven-bundle-plugin/ seems to be broken. Also, > the former page seems to contain http links instead of https ones. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Closed] (FELIX-5582) maven-bundle-plugin: Make sure Closeable resources are closed
[ https://issues.apache.org/jira/browse/FELIX-5582?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Stefan Seifert closed FELIX-5582. - > maven-bundle-plugin: Make sure Closeable resources are closed > - > > Key: FELIX-5582 > URL: https://issues.apache.org/jira/browse/FELIX-5582 > Project: Felix > Issue Type: Bug > Components: Maven Bundle Plugin >Affects Versions: maven-bundle-plugin-3.2.0 >Reporter: Stefan Seifert >Assignee: Stefan Seifert >Priority: Minor > Fix For: maven-bundle-plugin-3.3.0 > > > some resources that implement the Closeable interface are not closed properly > in maven-bundle-plugin. > this affects bnd Analyzer and Verifier objects. -- This message was sent by Atlassian JIRA (v6.3.15#6346)
[jira] [Closed] (FELIX-5424) Augment exported service metadata
[
https://issues.apache.org/jira/browse/FELIX-5424?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Stefan Seifert closed FELIX-5424.
-
> Augment exported service metadata
> -
>
> Key: FELIX-5424
> URL: https://issues.apache.org/jira/browse/FELIX-5424
> Project: Felix
> Issue Type: Improvement
> Components: Maven Bundle Plugin
>Reporter: Paolo Antinori
>Assignee: Guillaume Nodet
> Fix For: maven-bundle-plugin-3.3.0
>
>
> When Apache Aries Blueprint installs a service that points to a {{[bean]}}
> node that has its {{id}} attribute specified, it adds an additional metadata
> entry to the service registry:
> {code}
> osgi.service.blueprint.compname = myBeanId
> {code}
> That information is not automatically added to the Headers section of a
> generated bundle though, thus preventing some kind of validation offline.
> The proposed patch adds the additional metadata at build time.
> This is a snippet of a use case that requires this:
> {code:xml}
>
>
>
> interface="javax.sql.DataSource">
>
>
> {code}
> And, in another file:
> {code:xml}
> availability="mandatory" component-name="mysql-ds" />
> {code}
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
[jira] [Closed] (FELIX-5579) Bundle Plugin uses insecure maven-archiver 2.5
[
https://issues.apache.org/jira/browse/FELIX-5579?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Stefan Seifert closed FELIX-5579.
-
> Bundle Plugin uses insecure maven-archiver 2.5
> --
>
> Key: FELIX-5579
> URL: https://issues.apache.org/jira/browse/FELIX-5579
> Project: Felix
> Issue Type: Bug
> Components: Maven Bundle Plugin
>Affects Versions: maven-bundle-plugin-3.2.0
>Reporter: Mark Symons
>Assignee: Stefan Seifert
> Fix For: maven-bundle-plugin-3.3.0
>
>
> maven-bundle-plugin includes {{org.apache.maven:maven-archiver}} 2.5 as a
> compile dependency.
> This version of maven-archiver uses {{org.codehaus.plexus:plexus-archiver}}
> v2.1. which has level 5 threat
> [CVE-2012-2098|https://web.nvd.nist.gov/view/vuln/detail?vulnId=CVE-2012-2098].
> The CVE mentions "sorting algorithms in bzip2 compressing stream" in context
> of Apache Commons Compress, but here is [one defect
> reference|https://bugzilla.redhat.com/show_bug.cgi?id=951522] that confirms
> that the threat applies to plexus-archiver versions prior to 2.3.1
> Thus, upgrade Bundle Plugin usage of maven-archiver to 2.6 (which uses
> plexus-archiver 2.8.1) or later in order to mitigate the threat,
> Current release of maven-archiver is 3.1.1
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
[jira] [Closed] (FELIX-5581) Update to bndlib 3.3.0
[ https://issues.apache.org/jira/browse/FELIX-5581?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Stefan Seifert closed FELIX-5581. - > Update to bndlib 3.3.0 > -- > > Key: FELIX-5581 > URL: https://issues.apache.org/jira/browse/FELIX-5581 > Project: Felix > Issue Type: Improvement > Components: Maven Bundle Plugin >Affects Versions: maven-bundle-plugin-3.2.0 >Reporter: Stefan Seifert >Assignee: Stefan Seifert > Fix For: maven-bundle-plugin-3.3.0 > > > version 3.3.0 of bndlib was published in sept. 2016. > changelog: https://github.com/bndtools/bnd/wiki/Changes-in-3.3.0 -- This message was sent by Atlassian JIRA (v6.3.15#6346)
[jira] [Commented] (FELIX-5579) Bundle Plugin uses insecure maven-archiver 2.5
[
https://issues.apache.org/jira/browse/FELIX-5579?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15899771#comment-15899771
]
Stefan Seifert commented on FELIX-5579:
---
i think we can start the release process this week, so you should have it next
week.
> Bundle Plugin uses insecure maven-archiver 2.5
> --
>
> Key: FELIX-5579
> URL: https://issues.apache.org/jira/browse/FELIX-5579
> Project: Felix
> Issue Type: Bug
> Components: Maven Bundle Plugin
>Affects Versions: maven-bundle-plugin-3.2.0
>Reporter: Mark Symons
>Assignee: Stefan Seifert
> Fix For: maven-bundle-plugin-3.3.0
>
>
> maven-bundle-plugin includes {{org.apache.maven:maven-archiver}} 2.5 as a
> compile dependency.
> This version of maven-archiver uses {{org.codehaus.plexus:plexus-archiver}}
> v2.1. which has level 5 threat
> [CVE-2012-2098|https://web.nvd.nist.gov/view/vuln/detail?vulnId=CVE-2012-2098].
> The CVE mentions "sorting algorithms in bzip2 compressing stream" in context
> of Apache Commons Compress, but here is [one defect
> reference|https://bugzilla.redhat.com/show_bug.cgi?id=951522] that confirms
> that the threat applies to plexus-archiver versions prior to 2.3.1
> Thus, upgrade Bundle Plugin usage of maven-archiver to 2.6 (which uses
> plexus-archiver 2.8.1) or later in order to mitigate the threat,
> Current release of maven-archiver is 3.1.1
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
[jira] [Resolved] (FELIX-5582) maven-bundle-plugin: Make sure Closeable resources are closed
[ https://issues.apache.org/jira/browse/FELIX-5582?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Stefan Seifert resolved FELIX-5582. --- Resolution: Fixed Completed: At revision: 1785859 > maven-bundle-plugin: Make sure Closeable resources are closed > - > > Key: FELIX-5582 > URL: https://issues.apache.org/jira/browse/FELIX-5582 > Project: Felix > Issue Type: Bug > Components: Maven Bundle Plugin >Affects Versions: maven-bundle-plugin-3.2.0 >Reporter: Stefan Seifert >Assignee: Stefan Seifert >Priority: Minor > Fix For: maven-bundle-plugin-3.3.0 > > > some resources that implement the Closeable interface are not closed properly > in maven-bundle-plugin. > this affects bnd Analyzer and Verifier objects. -- This message was sent by Atlassian JIRA (v6.3.15#6346)
[jira] [Created] (FELIX-5582) maven-bundle-plugin: Make sure Closeable resources are closed
Stefan Seifert created FELIX-5582: - Summary: maven-bundle-plugin: Make sure Closeable resources are closed Key: FELIX-5582 URL: https://issues.apache.org/jira/browse/FELIX-5582 Project: Felix Issue Type: Bug Components: Maven Bundle Plugin Affects Versions: maven-bundle-plugin-3.2.0 Reporter: Stefan Seifert Assignee: Stefan Seifert Priority: Minor Fix For: maven-bundle-plugin-3.3.0 some resources that implement the Closeable interface are not closed properly in maven-bundle-plugin. this affects bnd Analyzer and Verifier objects. -- This message was sent by Atlassian JIRA (v6.3.15#6346)
[jira] [Resolved] (FELIX-5581) Update to bndlib 3.3.0
[ https://issues.apache.org/jira/browse/FELIX-5581?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Stefan Seifert resolved FELIX-5581. --- Resolution: Fixed Completed: At revision: 1785858 > Update to bndlib 3.3.0 > -- > > Key: FELIX-5581 > URL: https://issues.apache.org/jira/browse/FELIX-5581 > Project: Felix > Issue Type: Improvement > Components: Maven Bundle Plugin >Affects Versions: maven-bundle-plugin-3.2.0 >Reporter: Stefan Seifert >Assignee: Stefan Seifert > Fix For: maven-bundle-plugin-3.3.0 > > > version 3.3.0 of bndlib was published in sept. 2016. > changelog: https://github.com/bndtools/bnd/wiki/Changes-in-3.3.0 -- This message was sent by Atlassian JIRA (v6.3.15#6346)
[jira] [Created] (FELIX-5581) Update to bndlib 3.3.0
Stefan Seifert created FELIX-5581: - Summary: Update to bndlib 3.3.0 Key: FELIX-5581 URL: https://issues.apache.org/jira/browse/FELIX-5581 Project: Felix Issue Type: Improvement Components: Maven Bundle Plugin Affects Versions: maven-bundle-plugin-3.2.0 Reporter: Stefan Seifert Assignee: Stefan Seifert Fix For: maven-bundle-plugin-3.3.0 version 3.3.0 of bndlib was published in sept. 2016. changelog: https://github.com/bndtools/bnd/wiki/Changes-in-3.3.0 -- This message was sent by Atlassian JIRA (v6.3.15#6346)
[jira] [Resolved] (FELIX-5579) Bundle Plugin uses insecure maven-archiver 2.5
[
https://issues.apache.org/jira/browse/FELIX-5579?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Stefan Seifert resolved FELIX-5579.
---
Resolution: Fixed
Completed: At revision: 1785822
thanks for reporting - i've updated to maven-archiver 2.6
> Bundle Plugin uses insecure maven-archiver 2.5
> --
>
> Key: FELIX-5579
> URL: https://issues.apache.org/jira/browse/FELIX-5579
> Project: Felix
> Issue Type: Bug
> Components: Maven Bundle Plugin
>Affects Versions: maven-bundle-plugin-3.2.0
>Reporter: Mark Symons
>Assignee: Stefan Seifert
> Fix For: maven-bundle-plugin-3.3.0
>
>
> maven-bundle-plugin includes {{org.apache.maven:maven-archiver}} 2.5 as a
> compile dependency.
> This version of maven-archiver uses {{org.codehaus.plexus:plexus-archiver}}
> v2.1. which has level 5 threat
> [CVE-2012-2098|https://web.nvd.nist.gov/view/vuln/detail?vulnId=CVE-2012-2098].
> The CVE mentions "sorting algorithms in bzip2 compressing stream" in context
> of Apache Commons Compress, but here is [one defect
> reference|https://bugzilla.redhat.com/show_bug.cgi?id=951522] that confirms
> that the threat applies to plexus-archiver versions prior to 2.3.1
> Thus, upgrade Bundle Plugin usage of maven-archiver to 2.6 (which uses
> plexus-archiver 2.8.1) or later in order to mitigate the threat,
> Current release of maven-archiver is 3.1.1
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
[jira] [Assigned] (FELIX-5579) Bundle Plugin uses insecure maven-archiver 2.5
[
https://issues.apache.org/jira/browse/FELIX-5579?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Stefan Seifert reassigned FELIX-5579:
-
Assignee: Stefan Seifert
Fix Version/s: maven-bundle-plugin-3.3.0
> Bundle Plugin uses insecure maven-archiver 2.5
> --
>
> Key: FELIX-5579
> URL: https://issues.apache.org/jira/browse/FELIX-5579
> Project: Felix
> Issue Type: Bug
> Components: Maven Bundle Plugin
>Affects Versions: maven-bundle-plugin-3.2.0
>Reporter: Mark Symons
>Assignee: Stefan Seifert
> Fix For: maven-bundle-plugin-3.3.0
>
>
> maven-bundle-plugin includes {{org.apache.maven:maven-archiver}} 2.5 as a
> compile dependency.
> This version of maven-archiver uses {{org.codehaus.plexus:plexus-archiver}}
> v2.1. which has level 5 threat
> [CVE-2012-2098|https://web.nvd.nist.gov/view/vuln/detail?vulnId=CVE-2012-2098].
> The CVE mentions "sorting algorithms in bzip2 compressing stream" in context
> of Apache Commons Compress, but here is [one defect
> reference|https://bugzilla.redhat.com/show_bug.cgi?id=951522] that confirms
> that the threat applies to plexus-archiver versions prior to 2.3.1
> Thus, upgrade Bundle Plugin usage of maven-archiver to 2.6 (which uses
> plexus-archiver 2.8.1) or later in order to mitigate the threat,
> Current release of maven-archiver is 3.1.1
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
[jira] [Closed] (FELIX-5556) JSONParser does not retain object order
[
https://issues.apache.org/jira/browse/FELIX-5556?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Stefan Seifert closed FELIX-5556.
-
Resolution: Won't Fix
> JSONParser does not retain object order
> ---
>
> Key: FELIX-5556
> URL: https://issues.apache.org/jira/browse/FELIX-5556
> Project: Felix
> Issue Type: Bug
> Components: Utils
>Affects Versions: utils-1.9.0
>Reporter: Stefan Seifert
>
> the {{JSONParser}} does not retain the order of objects the JSON files it
> parses. the order is randomly based on the HashMap implementation used
> internally.
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
[jira] [Assigned] (FELIX-5556) JSONParser does not retain object order
[
https://issues.apache.org/jira/browse/FELIX-5556?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Stefan Seifert reassigned FELIX-5556:
-
Assignee: (was: Stefan Seifert)
Fix Version/s: (was: utils-1.9.2)
> JSONParser does not retain object order
> ---
>
> Key: FELIX-5556
> URL: https://issues.apache.org/jira/browse/FELIX-5556
> Project: Felix
> Issue Type: Bug
> Components: Utils
>Affects Versions: utils-1.9.0
>Reporter: Stefan Seifert
>
> the {{JSONParser}} does not retain the order of objects the JSON files it
> parses. the order is randomly based on the HashMap implementation used
> internally.
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
[jira] [Reopened] (FELIX-5556) JSONParser does not retain object order
[
https://issues.apache.org/jira/browse/FELIX-5556?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Stefan Seifert reopened FELIX-5556:
---
> JSONParser does not retain object order
> ---
>
> Key: FELIX-5556
> URL: https://issues.apache.org/jira/browse/FELIX-5556
> Project: Felix
> Issue Type: Bug
> Components: Utils
>Affects Versions: utils-1.9.0
>Reporter: Stefan Seifert
>Assignee: Stefan Seifert
>
> the {{JSONParser}} does not retain the order of objects the JSON files it
> parses. the order is randomly based on the HashMap implementation used
> internally.
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
[jira] [Closed] (FELIX-5556) JSONParser does not retain object order
[
https://issues.apache.org/jira/browse/FELIX-5556?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Stefan Seifert closed FELIX-5556.
-
Resolution: Won't Fix
agreed - setting to won't fix.
background was migration of some code that used the sling version of org.json
which kept object ordering and used it for mapping to ordered content structure
in JCR repository. then we have to switch to another json implementation.
> JSONParser does not retain object order
> ---
>
> Key: FELIX-5556
> URL: https://issues.apache.org/jira/browse/FELIX-5556
> Project: Felix
> Issue Type: Bug
> Components: Utils
>Affects Versions: utils-1.9.0
>Reporter: Stefan Seifert
>Assignee: Stefan Seifert
> Fix For: utils-1.9.2
>
>
> the {{JSONParser}} does not retain the order of objects the JSON files it
> parses. the order is randomly based on the HashMap implementation used
> internally.
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
[jira] [Reopened] (FELIX-5556) JSONParser does not retain object order
[
https://issues.apache.org/jira/browse/FELIX-5556?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Stefan Seifert reopened FELIX-5556:
---
reverted in rev. 1783837 due to objection in mailing list - starting further
discussion there
https://lists.apache.org/thread.html/9628699bf4bf9cfaa05c1d1752fe9e374a987e72ef3065104768a2dc@%3Cdev.felix.apache.org%3E
> JSONParser does not retain object order
> ---
>
> Key: FELIX-5556
> URL: https://issues.apache.org/jira/browse/FELIX-5556
> Project: Felix
> Issue Type: Bug
> Components: Utils
>Affects Versions: utils-1.9.0
>Reporter: Stefan Seifert
>Assignee: Stefan Seifert
> Fix For: utils-1.9.2
>
>
> the {{JSONParser}} does not retain the order of objects the JSON files it
> parses. the order is randomly based on the HashMap implementation used
> internally.
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
[jira] [Resolved] (FELIX-5556) JSONParser does not retain object order
[
https://issues.apache.org/jira/browse/FELIX-5556?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Stefan Seifert resolved FELIX-5556.
---
Resolution: Fixed
Completed: At revision: 1783803
> JSONParser does not retain object order
> ---
>
> Key: FELIX-5556
> URL: https://issues.apache.org/jira/browse/FELIX-5556
> Project: Felix
> Issue Type: Bug
> Components: Utils
>Affects Versions: utils-1.9.0
>Reporter: Stefan Seifert
>Assignee: Stefan Seifert
> Fix For: utils-1.9.2
>
>
> the {{JSONParser}} does not retain the order of objects the JSON files it
> parses. the order is randomly based on the HashMap implementation used
> internally.
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
[jira] [Created] (FELIX-5556) JSONParser does not retain object order
Stefan Seifert created FELIX-5556:
-
Summary: JSONParser does not retain object order
Key: FELIX-5556
URL: https://issues.apache.org/jira/browse/FELIX-5556
Project: Felix
Issue Type: Bug
Components: Utils
Affects Versions: utils-1.9.0
Reporter: Stefan Seifert
Assignee: Stefan Seifert
Fix For: utils-1.9.2
the {{JSONParser}} does not retain the order of objects the JSON files it
parses. the order is randomly based on the HashMap implementation used
internally.
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
[jira] [Closed] (FELIX-5484) Webconsole configuration factory name hint array rendering
[ https://issues.apache.org/jira/browse/FELIX-5484?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Stefan Seifert closed FELIX-5484. - > Webconsole configuration factory name hint array rendering > -- > > Key: FELIX-5484 > URL: https://issues.apache.org/jira/browse/FELIX-5484 > Project: Felix > Issue Type: Improvement > Components: Web Console >Affects Versions: webconsole-4.2.16 >Reporter: Julian Sedding >Assignee: Stefan Seifert >Priority: Minor > Fix For: webconsole-4.2.18 > > Attachments: FELIX-5484-jsedding.patch > > > The webconsole configuration factory name hint allows displaying of array > values as a comma separated list. Currently there is no space after the comma > and thus no line-break can be inserted when rendered in a browser. > For arrays with many values (or with few long values) this can lead to a > distorted view. The simplest fix is to insert a single space after the comma. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Closed] (FELIX-5387) NPE for requests missing 'felix-webconsole-locale' cookie
[
https://issues.apache.org/jira/browse/FELIX-5387?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Stefan Seifert closed FELIX-5387.
-
> NPE for requests missing 'felix-webconsole-locale' cookie
> -
>
> Key: FELIX-5387
> URL: https://issues.apache.org/jira/browse/FELIX-5387
> Project: Felix
> Issue Type: Bug
> Components: Web Console
>Affects Versions: webconsole-4.2.16
>Reporter: Timothee Maret
>Assignee: Carsten Ziegeler
>Priority: Minor
> Fix For: webconsole-4.2.18
>
>
> Issuing a request without 'felix-webconsole-locale' cookies throws a NPE
> similar to
> {code}
> 24.10.2016 12:44:44.617 *ERROR* [qtp1226339741-3423]
> org.apache.felix.http.jetty Exception while processing request to
> /system/console/configMgr (java.lang.NullPointerException)
> java.lang.NullPointerException: null
> at
> org.apache.felix.webconsole.internal.servlet.OsgiManager.ensureLocaleCookieSet(OsgiManager.java:502)
> at
> org.apache.felix.webconsole.internal.servlet.OsgiManager.service(OsgiManager.java:561)
> at
> org.apache.felix.webconsole.internal.servlet.OsgiManager$3.run(OsgiManager.java:465)
> at java.security.AccessController.doPrivileged(Native Method)
> at
> org.apache.felix.webconsole.internal.servlet.OsgiManager.service(OsgiManager.java:461)
> at
> org.apache.felix.http.base.internal.handler.ServletHandler.handle(ServletHandler.java:85)
> at
> org.apache.felix.http.base.internal.dispatch.InvocationChain.doFilter(InvocationChain.java:79)
> at
> com.adobe.granite.license.impl.LicenseCheckFilter.doFilter(LicenseCheckFilter.java:308)
> at
> org.apache.felix.http.base.internal.handler.FilterHandler.handle(FilterHandler.java:135)
> at
> org.apache.felix.http.base.internal.dispatch.InvocationChain.doFilter(InvocationChain.java:74)
> at
> org.apache.felix.http.sslfilter.internal.SslFilter.doFilter(SslFilter.java:96)
> at
> org.apache.felix.http.base.internal.handler.FilterHandler.handle(FilterHandler.java:135)
> at
> org.apache.felix.http.base.internal.dispatch.InvocationChain.doFilter(InvocationChain.java:74)
> at
> org.apache.sling.security.impl.ReferrerFilter.doFilter(ReferrerFilter.java:295)
> at
> org.apache.felix.http.base.internal.handler.FilterHandler.handle(FilterHandler.java:135)
> at
> org.apache.felix.http.base.internal.dispatch.InvocationChain.doFilter(InvocationChain.java:74)
> at org.apache.sling.i18n.impl.I18NFilter.doFilter(I18NFilter.java:133)
> at
> org.apache.felix.http.base.internal.handler.FilterHandler.handle(FilterHandler.java:135)
> at
> org.apache.felix.http.base.internal.dispatch.InvocationChain.doFilter(InvocationChain.java:74)
> at
> org.apache.felix.http.base.internal.dispatch.Dispatcher.dispatch(Dispatcher.java:128)
> at
> org.apache.felix.http.base.internal.dispatch.DispatcherServlet.service(DispatcherServlet.java:49)
> at javax.servlet.http.HttpServlet.service(HttpServlet.java:725)
> at
> org.eclipse.jetty.servlet.ServletHolder.handle(ServletHolder.java:812)
> at
> org.eclipse.jetty.servlet.ServletHandler.doHandle(ServletHandler.java:587)
> at
> org.eclipse.jetty.server.session.SessionHandler.doHandle(SessionHandler.java:221)
> at
> org.eclipse.jetty.server.handler.ContextHandler.doHandle(ContextHandler.java:1127)
> at
> org.eclipse.jetty.servlet.ServletHandler.doScope(ServletHandler.java:515)
> at
> org.eclipse.jetty.server.session.SessionHandler.doScope(SessionHandler.java:185)
> at
> org.eclipse.jetty.server.handler.ContextHandler.doScope(ContextHandler.java:1061)
> at
> org.eclipse.jetty.server.handler.ScopedHandler.handle(ScopedHandler.java:141)
> at
> org.eclipse.jetty.server.handler.ContextHandlerCollection.handle(ContextHandlerCollection.java:215)
> at
> org.eclipse.jetty.server.handler.HandlerWrapper.handle(HandlerWrapper.java:97)
> at org.eclipse.jetty.server.Server.handle(Server.java:499)
> at org.eclipse.jetty.server.HttpChannel.handle(HttpChannel.java:311)
> at
> org.eclipse.jetty.server.HttpConnection.onFillable(HttpConnection.java:257)
> at
> org.eclipse.jetty.io.AbstractConnection$2.run(AbstractConnection.java:544)
> at
> org.eclipse.jetty.util.thread.QueuedThreadPool.runJob(QueuedThreadPool.java:635)
> at
> org.eclipse.jetty.util.thread.QueuedThreadPool$3.run(QueuedThreadPool.java:555)
> at java.lang.Thread.run(Thread.java:745)
> {code}
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Closed] (FELIX-4840) Asynchronous IO fails in webconsole plugin
[
https://issues.apache.org/jira/browse/FELIX-4840?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Stefan Seifert closed FELIX-4840.
-
> Asynchronous IO fails in webconsole plugin
> --
>
> Key: FELIX-4840
> URL: https://issues.apache.org/jira/browse/FELIX-4840
> Project: Felix
> Issue Type: Bug
> Components: Web Console
>Affects Versions: webconsole-4.2.8
>Reporter: Balazs Zsoldos
>Assignee: Carsten Ziegeler
> Fix For: webconsole-4.2.18
>
>
> *Issue*
> The following function call always returns with true:
> {code:java}
> ServletRequest.isAsyncSupported()
> {code}
> However, async calls fail even if the webconsole plugin tries to provide some
> resource (with some special extension on the end of the URI).
> *Reason*
> In the end of the _OSGiManager.service(ServletRequest, ServletResponse)_
> function, there is the following:
> {code:java}
> // ensure response has been sent back and response is committed
> // (we are authorative for our URL space and no other servlet should
> interfere)
> res.flushBuffer();
> {code}
> Due to the reason that _flushBuffer()_ function is called, any asynchronous
> handling will fail with an exception.
> *Proposed solution*
> - In case the webconsole plugin is rendered (the path ends with / or .html),
> the _request.isAsyncSupported()_ method call should return false
> - In case a custom resource is provided by the webconsole plugin (any
> extension but html on the end of the path) the _flushBuffer()_ method should
> not be called
> At least the second part of the fix should be implemented as if a plugin
> wants to provide bigger files (like a dump), async support can be useful.
> Also, by the time more and more libraries will support asynchronous IO to
> provide resources and if a webconsole plugin uses such library, it will fail.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Closed] (FELIX-5445) Web Console: Properly display non-string property arrays in name hint
[ https://issues.apache.org/jira/browse/FELIX-5445?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Stefan Seifert closed FELIX-5445. - > Web Console: Properly display non-string property arrays in name hint > - > > Key: FELIX-5445 > URL: https://issues.apache.org/jira/browse/FELIX-5445 > Project: Felix > Issue Type: Improvement > Components: Web Console >Affects Versions: webconsole-4.2.16 >Reporter: Stefan Seifert >Assignee: Carsten Ziegeler > Fix For: webconsole-4.2.18 > > Attachments: FELIX-5445.patch > > > a name hint feature for osgi configs in the web console was introduced in > FELIX-4710. it also supported displaying arrays of configuration parameters > in the name hint, but only for String[] arrays. > this should be improved to support all data types, e.g. Integer[] arrays. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Updated] (FELIX-5277) WebConsole config admin styling is broken
[ https://issues.apache.org/jira/browse/FELIX-5277?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Stefan Seifert updated FELIX-5277: -- Fix Version/s: (was: webconsole-4.2.18) webconsole-4.2.20 > WebConsole config admin styling is broken > - > > Key: FELIX-5277 > URL: https://issues.apache.org/jira/browse/FELIX-5277 > Project: Felix > Issue Type: Bug > Components: Web Console >Affects Versions: webconsole-4.2.16 >Reporter: Valentin Valchev >Priority: Minor > Fix For: webconsole-4.2.20 > > Attachments: config-chrome.png, config-ff.png, config-ie.png > > > The web console config admin plugin styling is broken on properties with > cardinality > 1. > It seems, that this was a problem even before FELIX-5223. > The problem occurs, when you hit the plus button right to the property, to > add a next entry. I'm attaching few screenshot to illustrate the problem. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Resolved] (FELIX-5484) Webconsole configuration factory name hint array rendering
[ https://issues.apache.org/jira/browse/FELIX-5484?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Stefan Seifert resolved FELIX-5484. --- Resolution: Fixed Fix Version/s: webconsole-4.2.18 Completed: At revision: 1777969 thanks! - i've tested & applied it > Webconsole configuration factory name hint array rendering > -- > > Key: FELIX-5484 > URL: https://issues.apache.org/jira/browse/FELIX-5484 > Project: Felix > Issue Type: Improvement > Components: Web Console >Affects Versions: webconsole-4.2.16 >Reporter: Julian Sedding >Assignee: Stefan Seifert >Priority: Minor > Fix For: webconsole-4.2.18 > > Attachments: FELIX-5484-jsedding.patch > > > The webconsole configuration factory name hint allows displaying of array > values as a comma separated list. Currently there is no space after the comma > and thus no line-break can be inserted when rendered in a browser. > For arrays with many values (or with few long values) this can lead to a > distorted view. The simplest fix is to insert a single space after the comma. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Assigned] (FELIX-5484) Webconsole configuration factory name hint array rendering
[ https://issues.apache.org/jira/browse/FELIX-5484?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Stefan Seifert reassigned FELIX-5484: - Assignee: Stefan Seifert > Webconsole configuration factory name hint array rendering > -- > > Key: FELIX-5484 > URL: https://issues.apache.org/jira/browse/FELIX-5484 > Project: Felix > Issue Type: Improvement > Components: Web Console >Affects Versions: webconsole-4.2.16 >Reporter: Julian Sedding >Assignee: Stefan Seifert >Priority: Minor > Attachments: FELIX-5484-jsedding.patch > > > The webconsole configuration factory name hint allows displaying of array > values as a comma separated list. Currently there is no space after the comma > and thus no line-break can be inserted when rendered in a browser. > For arrays with many values (or with few long values) this can lead to a > distorted view. The simplest fix is to insert a single space after the comma. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Closed] (FELIX-5470) website documentation is not up-to-date - shows version 3.0.1
[ https://issues.apache.org/jira/browse/FELIX-5470?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Stefan Seifert closed FELIX-5470. - > website documentation is not up-to-date - shows version 3.0.1 > - > > Key: FELIX-5470 > URL: https://issues.apache.org/jira/browse/FELIX-5470 > Project: Felix > Issue Type: Task > Components: Maven Bundle Plugin >Affects Versions: maven-bundle-plugin-3.2.0 >Reporter: Andreas Gebhardt >Assignee: Stefan Seifert > > Website http://felix.apache.org/components/bundle-plugin/index.html is not > up-to-date, version 3.0.1 is shown. > Documentation generated by »Maven Site Plugin« should be uploaded. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Resolved] (FELIX-5470) website documentation is not up-to-date - shows version 3.0.1
[ https://issues.apache.org/jira/browse/FELIX-5470?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Stefan Seifert resolved FELIX-5470. --- Resolution: Fixed Assignee: Stefan Seifert i've published the latest 3.2.0 documentation http://felix.apache.org/components/bundle-plugin/index.html > website documentation is not up-to-date - shows version 3.0.1 > - > > Key: FELIX-5470 > URL: https://issues.apache.org/jira/browse/FELIX-5470 > Project: Felix > Issue Type: Task > Components: Maven Bundle Plugin >Affects Versions: maven-bundle-plugin-3.2.0 >Reporter: Andreas Gebhardt >Assignee: Stefan Seifert > > Website http://felix.apache.org/components/bundle-plugin/index.html is not > up-to-date, version 3.0.1 is shown. > Documentation generated by »Maven Site Plugin« should be uploaded. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Closed] (FELIX-5466) org.apache.felix.scr.bnd: Adding Target Source URL may lead to NPE
[ https://issues.apache.org/jira/browse/FELIX-5466?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Stefan Seifert closed FELIX-5466. - > org.apache.felix.scr.bnd: Adding Target Source URL may lead to NPE > -- > > Key: FELIX-5466 > URL: https://issues.apache.org/jira/browse/FELIX-5466 > Project: Felix > Issue Type: Bug > Components: SCR Tooling >Affects Versions: scr bnd plugin 1.7.0 >Reporter: Stefan Seifert >Assignee: Stefan Seifert >Priority: Critical > Fix For: scr bnd plugin 1.7.2 > > > the fix with adding the target source URL introduced in FELIX-5419 may lead > to NPE when the target source returns null. > in my tests this may affect a lot of projects using maven-bundle-plugin > together with org.apache.felix.scr.bnd. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Resolved] (FELIX-5466) org.apache.felix.scr.bnd: Adding Target Source URL may lead to NPE
[ https://issues.apache.org/jira/browse/FELIX-5466?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Stefan Seifert resolved FELIX-5466. --- Resolution: Fixed Completed: At revision: 1776116 added additional null checks > org.apache.felix.scr.bnd: Adding Target Source URL may lead to NPE > -- > > Key: FELIX-5466 > URL: https://issues.apache.org/jira/browse/FELIX-5466 > Project: Felix > Issue Type: Bug > Components: SCR Tooling >Affects Versions: scr bnd plugin 1.7.0 >Reporter: Stefan Seifert >Assignee: Stefan Seifert >Priority: Critical > Fix For: scr bnd plugin 1.8.0 > > > the fix with adding the target source URL introduced in FELIX-5419 may lead > to NPE when the target source returns null. > in my tests this may affect a lot of projects using maven-bundle-plugin > together with org.apache.felix.scr.bnd. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Created] (FELIX-5466) org.apache.felix.scr.bnd: Adding Target Source URL may lead to NPE
Stefan Seifert created FELIX-5466: - Summary: org.apache.felix.scr.bnd: Adding Target Source URL may lead to NPE Key: FELIX-5466 URL: https://issues.apache.org/jira/browse/FELIX-5466 Project: Felix Issue Type: Bug Components: SCR Tooling Affects Versions: scr bnd plugin 1.7.0 Reporter: Stefan Seifert Assignee: Stefan Seifert Priority: Critical Fix For: scr bnd plugin 1.8.0 the fix with adding the target source URL introduced in FELIX-5419 may lead to NPE when the target source returns null. in my tests this may affect a lot of projects using maven-bundle-plugin together with org.apache.felix.scr.bnd. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (FELIX-5452) SCR bnd plugin fails when embedding jars with optional/excluded dependencies
[ https://issues.apache.org/jira/browse/FELIX-5452?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15761521#comment-15761521 ] Stefan Seifert commented on FELIX-5452: --- yes, i think this is ok. in the maven-scr-plugin it should be quite impossible that class not found exceptions occur, because the generator gets only the class files that where compiled immediately before in the maven build. > SCR bnd plugin fails when embedding jars with optional/excluded dependencies > > > Key: FELIX-5452 > URL: https://issues.apache.org/jira/browse/FELIX-5452 > Project: Felix > Issue Type: Bug > Components: SCR Tooling >Affects Versions: scr generator 1.15.0, scr bnd plugin 1.6.0 >Reporter: Stefan Seifert >Assignee: Carsten Ziegeler > Fix For: scr generator 1.16.0, scr bnd plugin 1.7.0 > > Attachments: FELIX-5452.patch > > > when the maven-bundle-plugin is used to embedded JAR dependencies, and those > dependencies contain optional or excluded further dependencies which classes > are somewhere references in the dependency itself SCR generation via > maven-bundle-plugin and the SCR bnd plugin fails. > it does *not* fail when using the maven-scr-plugin. > the reason for the difference is that the maven-scr-plugin analyzes only the > classes compiled in the target folder, not the classes of embedded > dependencies. the bnd plugin cannot differentiate if the classes in the > bundle jar where embedded or compiled and always scans all of them. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Updated] (FELIX-5451) Input/Output streams not properly closed in org.apache.felix.scr.generator
[ https://issues.apache.org/jira/browse/FELIX-5451?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Stefan Seifert updated FELIX-5451: -- Priority: Critical (was: Major) > Input/Output streams not properly closed in org.apache.felix.scr.generator > -- > > Key: FELIX-5451 > URL: https://issues.apache.org/jira/browse/FELIX-5451 > Project: Felix > Issue Type: Bug > Components: SCR Tooling >Affects Versions: scr generator 1.15.0 >Reporter: Stefan Seifert >Priority: Critical > Fix For: scr generator 1.16.0 > > Attachments: FELIX-5451.patch > > > in various places intput streams and output streams are not closed properly > for org.apache.felix.scr.generator. this may lead to locked files. > on a windows machine even the unit test did fail because of this. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Updated] (FELIX-5452) SCR bnd plugin fails when embedding jars with optional/excluded dependencies
[ https://issues.apache.org/jira/browse/FELIX-5452?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Stefan Seifert updated FELIX-5452: -- Attachment: FELIX-5452.patch patch proposal: [^FELIX-5452.patch] this logs a WARN message when classes not found during analyzing instead of breaking the build. > SCR bnd plugin fails when embedding jars with optional/excluded dependencies > > > Key: FELIX-5452 > URL: https://issues.apache.org/jira/browse/FELIX-5452 > Project: Felix > Issue Type: Bug > Components: SCR Tooling >Affects Versions: scr generator 1.15.0, scr bnd plugin 1.6.0 >Reporter: Stefan Seifert > Fix For: scr generator 1.16.0, scr bnd plugin 1.7.0 > > Attachments: FELIX-5452.patch > > > when the maven-bundle-plugin is used to embedded JAR dependencies, and those > dependencies contain optional or excluded further dependencies which classes > are somewhere references in the dependency itself SCR generation via > maven-bundle-plugin and the SCR bnd plugin fails. > it does *not* fail when using the maven-scr-plugin. > the reason for the difference is that the maven-scr-plugin analyzes only the > classes compiled in the target folder, not the classes of embedded > dependencies. the bnd plugin cannot differentiate if the classes in the > bundle jar where embedded or compiled and always scans all of them. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (FELIX-5452) SCR bnd plugin fails when embedding jars with optional/excluded dependencies
[
https://issues.apache.org/jira/browse/FELIX-5452?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15755883#comment-15755883
]
Stefan Seifert commented on FELIX-5452:
---
example - with this project using maven-scr-plugin it works:
https://github.com/stefanseifert/FELIX-5452-testproject/tree/master/maven-scr-plugin
with the project using scr bnd plugin it fails:
https://github.com/stefanseifert/FELIX-5452-testproject/tree/master/bnd-scr-plugin
with this error:
{noformat}
[ERROR] Bundle sample:sample.handlebars:bundle:1.0.0-SNAPSHOT : Got unexpected
exception while analyzing:org.apache.felix.scrplugin.SCRDescriptorException:
Unable to load compiled class:
com.github.jknack.handlebars.internal.js.RhinoHandlebars
at
org.apache.felix.scrplugin.helper.ClassScanner.scanSources(ClassScanner.java:152)
at
org.apache.felix.scrplugin.SCRDescriptorGenerator.execute(SCRDescriptorGenerator.java:146)
at
org.apache.felix.scrplugin.bnd.SCRDescriptorBndPlugin.analyzeJar(SCRDescriptorBndPlugin.java:178)
at aQute.bnd.osgi.Analyzer.doPlugins(Analyzer.java:656)
at aQute.bnd.osgi.Analyzer.analyze(Analyzer.java:209)
at aQute.bnd.osgi.Builder.analyze(Builder.java:385)
at aQute.bnd.osgi.Analyzer.calcManifest(Analyzer.java:687)
at aQute.bnd.osgi.Builder.build(Builder.java:105)
at
org.apache.felix.bundleplugin.BundlePlugin.buildOSGiBundle(BundlePlugin.java:972)
at
org.apache.felix.bundleplugin.BundlePlugin.execute(BundlePlugin.java:470)
at
org.apache.felix.bundleplugin.BundlePlugin.execute(BundlePlugin.java:387)
at
org.apache.felix.bundleplugin.BundlePlugin.execute(BundlePlugin.java:378)
at
org.apache.maven.plugin.DefaultBuildPluginManager.executeMojo(DefaultBuildPluginManager.java:134)
at
org.apache.maven.lifecycle.internal.MojoExecutor.execute(MojoExecutor.java:207)
at
org.apache.maven.lifecycle.internal.MojoExecutor.execute(MojoExecutor.java:153)
at
org.apache.maven.lifecycle.internal.MojoExecutor.execute(MojoExecutor.java:145)
at
org.apache.maven.lifecycle.internal.LifecycleModuleBuilder.buildProject(LifecycleModuleBuilder.java:116)
at
org.apache.maven.lifecycle.internal.LifecycleModuleBuilder.buildProject(LifecycleModuleBuilder.java:80)
at
org.apache.maven.lifecycle.internal.builder.singlethreaded.SingleThreadedBuilder.build(SingleThreadedBuilder.java:51)
at
org.apache.maven.lifecycle.internal.LifecycleStarter.execute(LifecycleStarter.java:128)
at org.apache.maven.DefaultMaven.doExecute(DefaultMaven.java:307)
at org.apache.maven.DefaultMaven.doExecute(DefaultMaven.java:193)
at org.apache.maven.DefaultMaven.execute(DefaultMaven.java:106)
at org.apache.maven.cli.MavenCli.execute(MavenCli.java:863)
at org.apache.maven.cli.MavenCli.doMain(MavenCli.java:288)
at org.apache.maven.cli.MavenCli.main(MavenCli.java:199)
at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
at
sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)
at
sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
at java.lang.reflect.Method.invoke(Method.java:498)
at
org.codehaus.plexus.classworlds.launcher.Launcher.launchEnhanced(Launcher.java:289)
at
org.codehaus.plexus.classworlds.launcher.Launcher.launch(Launcher.java:229)
at
org.codehaus.plexus.classworlds.launcher.Launcher.mainWithExitCode(Launcher.java:415)
at
org.codehaus.plexus.classworlds.launcher.Launcher.main(Launcher.java:356)
Caused by: java.lang.NoClassDefFoundError: org/mozilla/javascript/NativeObject
at java.lang.ClassLoader.defineClass1(Native Method)
at java.lang.ClassLoader.defineClass(ClassLoader.java:763)
at
java.security.SecureClassLoader.defineClass(SecureClassLoader.java:142)
at java.net.URLClassLoader.defineClass(URLClassLoader.java:467)
at java.net.URLClassLoader.access$100(URLClassLoader.java:73)
at java.net.URLClassLoader$1.run(URLClassLoader.java:368)
at java.net.URLClassLoader$1.run(URLClassLoader.java:362)
at java.security.AccessController.doPrivileged(Native Method)
at java.net.URLClassLoader.findClass(URLClassLoader.java:361)
at java.lang.ClassLoader.loadClass(ClassLoader.java:424)
at java.lang.ClassLoader.loadClass(ClassLoader.java:357)
at java.lang.Class.getDeclaredClasses0(Native Method)
at java.lang.Class.getDeclaredClasses(Class.java:1867)
at
org.apache.felix.scrplugin.helper.ClassScanner.process(ClassScanner.java:186)
at
org.apache.felix.scrplugin.helper.ClassScanner.scanSources(ClassScanner.java:146)
... 33 more
Caused by: java.lang.ClassNotFoundException: org.mozilla.javascript.NativeObject
at java.ne
[jira] [Created] (FELIX-5452) SCR bnd plugin fails when embedding jars with optional/excluded dependencies
Stefan Seifert created FELIX-5452: - Summary: SCR bnd plugin fails when embedding jars with optional/excluded dependencies Key: FELIX-5452 URL: https://issues.apache.org/jira/browse/FELIX-5452 Project: Felix Issue Type: Bug Components: SCR Tooling Affects Versions: scr bnd plugin 1.6.0, scr generator 1.15.0 Reporter: Stefan Seifert Fix For: scr generator 1.16.0, scr bnd plugin 1.7.0 when the maven-bundle-plugin is used to embedded JAR dependencies, and those dependencies contain optional or excluded further dependencies which classes are somewhere references in the dependency itself SCR generation via maven-bundle-plugin and the SCR bnd plugin fails. it does *not* fail when using the maven-scr-plugin. the reason for the difference is that the maven-scr-plugin analyzes only the classes compiled in the target folder, not the classes of embedded dependencies. the bnd plugin cannot differentiate if the classes in the bundle jar where embedded or compiled and always scans all of them. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Updated] (FELIX-5451) Input/Output streams not properly closed in org.apache.felix.scr.generator
[ https://issues.apache.org/jira/browse/FELIX-5451?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Stefan Seifert updated FELIX-5451: -- Attachment: FELIX-5451.patch patch attached: [^FELIX-5451.patch] > Input/Output streams not properly closed in org.apache.felix.scr.generator > -- > > Key: FELIX-5451 > URL: https://issues.apache.org/jira/browse/FELIX-5451 > Project: Felix > Issue Type: Bug > Components: SCR Tooling >Affects Versions: scr generator 1.15.0 >Reporter: Stefan Seifert > Fix For: scr generator 1.16.0 > > Attachments: FELIX-5451.patch > > > in various places intput streams and output streams are not closed properly > for org.apache.felix.scr.generator. this may lead to locked files. > on a windows machine even the unit test did fail because of this. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Created] (FELIX-5451) Input/Output streams not properly closed in org.apache.felix.scr.generator
Stefan Seifert created FELIX-5451: - Summary: Input/Output streams not properly closed in org.apache.felix.scr.generator Key: FELIX-5451 URL: https://issues.apache.org/jira/browse/FELIX-5451 Project: Felix Issue Type: Bug Components: SCR Tooling Affects Versions: scr generator 1.15.0 Reporter: Stefan Seifert Fix For: scr generator 1.16.0 in various places intput streams and output streams are not closed properly for org.apache.felix.scr.generator. this may lead to locked files. on a windows machine even the unit test did fail because of this. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Updated] (FELIX-5445) Web Console: Properly display non-string property arrays in name hint
[ https://issues.apache.org/jira/browse/FELIX-5445?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Stefan Seifert updated FELIX-5445: -- Attachment: FELIX-5445.patch patch: [^FELIX-5445.patch] > Web Console: Properly display non-string property arrays in name hint > - > > Key: FELIX-5445 > URL: https://issues.apache.org/jira/browse/FELIX-5445 > Project: Felix > Issue Type: Improvement > Components: Web Console >Affects Versions: webconsole-4.2.16 >Reporter: Stefan Seifert > Fix For: webconsole-4.2.18 > > Attachments: FELIX-5445.patch > > > a name hint feature for osgi configs in the web console was introduced in > FELIX-4710. it also supported displaying arrays of configuration parameters > in the name hint, but only for String[] arrays. > this should be improved to support all data types, e.g. Integer[] arrays. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Created] (FELIX-5445) Web Console: Properly display non-string property arrays in name hint
Stefan Seifert created FELIX-5445: - Summary: Web Console: Properly display non-string property arrays in name hint Key: FELIX-5445 URL: https://issues.apache.org/jira/browse/FELIX-5445 Project: Felix Issue Type: Improvement Components: Web Console Affects Versions: webconsole-4.2.16 Reporter: Stefan Seifert Fix For: webconsole-4.2.18 a name hint feature for osgi configs in the web console was introduced in FELIX-4710. it also supported displaying arrays of configuration parameters in the name hint, but only for String[] arrays. this should be improved to support all data types, e.g. Integer[] arrays. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (FELIX-5396) Move Sling annotations to dedicated artifact
[ https://issues.apache.org/jira/browse/FELIX-5396?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15636286#comment-15636286 ] Stefan Seifert commented on FELIX-5396: --- and the separate bundle for the sling-only SCR annotations should be part of the sling project. i suppose they are only part of the felix project because long time ago there was no possibility to add custom annotations via an SPI to the SCR generator. and the sling SCR annotations may have be refactored on the way to use the same "style" as the new OSGi annotations. e.g. defining the properties with a string array attribut instead of separate @Property/@Properties annotations - otherwise you still need (part) of the Felix SCR annotations. > Move Sling annotations to dedicated artifact > > > Key: FELIX-5396 > URL: https://issues.apache.org/jira/browse/FELIX-5396 > Project: Felix > Issue Type: Improvement > Components: SCR Tooling >Affects Versions: scr annotations 1.12.0 >Reporter: Konrad Windszus >Priority: Minor > > Currently both the Felix SCR and the custom Sling annotations live in the > same JAR. In my projects I don't want to use Felix SCR annotation since OSGi > 6 defined now its own annotations for components and metatypes (being > evaluated by bnd), but still the custom Sling annotations are useful. For > that it would be helpful to just declare a dependency to the Sling > annotations (and let them process with maven-scr-plugin or scr-bnd-plugin) > without polluting my classpath with the Felix SCR annotations. Probably at > the same time it makes more sense to maintain the Sling specific annotations > and generator in Sling rather than in Felix. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Created] (FELIX-5362) Felix Site Maven Bundle Docs: Add FAQ for using OSGi SCR annotations in unit tests
Stefan Seifert created FELIX-5362: - Summary: Felix Site Maven Bundle Docs: Add FAQ for using OSGi SCR annotations in unit tests Key: FELIX-5362 URL: https://issues.apache.org/jira/browse/FELIX-5362 Project: Felix Issue Type: Improvement Components: Documentation Reporter: Stefan Seifert Priority: Minor as discussed in FELIX-4009 we should update the documentation to add a FAQ entry how maven-bundle-plugin can be used in projects which use the new OSGi DS annotations and unit tests using OSGi mocks. attached is a patch for the documentation. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Updated] (FELIX-5362) Felix Site Maven Bundle Docs: Add FAQ for using OSGi SCR annotations in unit tests
[ https://issues.apache.org/jira/browse/FELIX-5362?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Stefan Seifert updated FELIX-5362: -- Attachment: FELIX-5362-bundle-plugin-faq.patch > Felix Site Maven Bundle Docs: Add FAQ for using OSGi SCR annotations in unit > tests > -- > > Key: FELIX-5362 > URL: https://issues.apache.org/jira/browse/FELIX-5362 > Project: Felix > Issue Type: Improvement > Components: Documentation >Reporter: Stefan Seifert >Priority: Minor > Attachments: FELIX-5362-bundle-plugin-faq.patch > > > as discussed in FELIX-4009 we should update the documentation to add a FAQ > entry how maven-bundle-plugin can be used in projects which use the new OSGi > DS annotations and unit tests using OSGi mocks. > attached is a patch for the documentation. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (FELIX-4009) maven bundle plugin should be integrated directly with eclipse
[ https://issues.apache.org/jira/browse/FELIX-4009?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15516830#comment-15516830 ] Stefan Seifert commented on FELIX-4009: --- makes sense - i've created FELIX-5362 for the documentation update > maven bundle plugin should be integrated directly with eclipse > -- > > Key: FELIX-4009 > URL: https://issues.apache.org/jira/browse/FELIX-4009 > Project: Felix > Issue Type: New Feature > Components: Maven Bundle Plugin >Affects Versions: maven-bundle-plugin-2.3.7 >Reporter: Andrei Pozolotin >Assignee: Carsten Ziegeler > Labels: m2e > Fix For: maven-bundle-plugin-3.2.0 > > > Stuart: > 1) currently, to integrate maven-bundle-plugin into m2e, one must use tycho > configurator > https://github.com/sonatype/m2eclipse-tycho > which adds needles complexity, and makes few strange assumptions > https://github.com/sonatype/m2eclipse-tycho/blob/master/org.sonatype.tycho.m2e/src/org/sonatype/tycho/m2e/internal/OsgiBundleProjectConfigurator.java#L74 > which no one it seems is there to care to correct > https://github.com/sonatype/m2eclipse-tycho/pull/8 > 2) instead, I suggest maven-bundle-plugin to provide direct integration with > eclipse via > http://wiki.eclipse.org/M2E_compatible_maven_plugins#BuildContext > which I would expect to be more customizable / flexible for the end user. > I recently made similar switch with my DS plugin, and life got easier :-) > https://github.com/carrot-garden/carrot-maven/tree/master/carrot-maven-scr-plugin > thanks. > Andrei. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Created] (FELIX-5361) Felix Site: Fix external links to bndtools website
Stefan Seifert created FELIX-5361: - Summary: Felix Site: Fix external links to bndtools website Key: FELIX-5361 URL: https://issues.apache.org/jira/browse/FELIX-5361 Project: Felix Issue Type: Bug Components: Documentation Reporter: Stefan Seifert Priority: Minor Attachments: FELIX-5361-bnd-links.patch http://felix.apache.org/ contains a lot of links to bnd documentation, which are all broken currently - e.g. http://www.aqute.biz/Bnd/Bnd attached is a patch that changes the links to their new locations. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Updated] (FELIX-5361) Felix Site: Fix external links to bndtools website
[ https://issues.apache.org/jira/browse/FELIX-5361?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Stefan Seifert updated FELIX-5361: -- Attachment: FELIX-5361-bnd-links.patch > Felix Site: Fix external links to bndtools website > -- > > Key: FELIX-5361 > URL: https://issues.apache.org/jira/browse/FELIX-5361 > Project: Felix > Issue Type: Bug > Components: Documentation >Reporter: Stefan Seifert >Priority: Minor > Attachments: FELIX-5361-bnd-links.patch > > > http://felix.apache.org/ contains a lot of links to bnd documentation, which > are all broken currently - e.g. http://www.aqute.biz/Bnd/Bnd > attached is a patch that changes the links to their new locations. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (FELIX-5116) Dump SCR component definitions broken
[
https://issues.apache.org/jira/browse/FELIX-5116?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15367929#comment-15367929
]
Stefan Seifert commented on FELIX-5116:
---
bq. May I ask you to give a try with my patch without your different source
location, please ? Just to ensure that those files were created in the
classpath properly...
yes, it works with your patch and without the {{scrLocation}} property as well
with my project.
> Dump SCR component definitions broken
> -
>
> Key: FELIX-5116
> URL: https://issues.apache.org/jira/browse/FELIX-5116
> Project: Felix
> Issue Type: Bug
> Components: Maven Bundle Plugin
>Affects Versions: maven-bundle-plugin-3.0.0
>Reporter: Stefan Seifert
> Fix For: maven-bundle-plugin-3.1.0
>
> Attachments: FELIX-5116.patch
>
>
> the feature to optionally dump SCR component definitions generated by bnd to
> the output classes folder introduced in FELIX-3324 is broken ins
> maven-bundle-plugin 3.0.0 and 3.0.1 - the associated code is never called
> when generating the bundle or manifest.
> the attached patch fixes this and enabled the behavior for both manifest and
> bundle goals.
> this feature is imporant for unit test support in IDEs, e.g. for
> https://sling.apache.org/documentation/development/osgi-mock.html
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (FELIX-5116) Dump SCR component definitions broken
[
https://issues.apache.org/jira/browse/FELIX-5116?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15367581#comment-15367581
]
Stefan Seifert commented on FELIX-5116:
---
the plugin is only there to include SCRDescriptorBndPlugin - so i cannot only
use the "new" OSGi SCR annotations, but also the "old" ones from the felix
project. you need it only if you use the old ones from the package
{{org.apache.felix.scr.annotations}}.
the explicit configuration of scrLocation is only required for the manifest
goal, any only for the unit tests. if you do not configure it you will still
get the correct files in OSGI-INF in your JAR file - bndlib takes care of this.
but only in the JAR file and not in the filesystem in the classes path - and
thus not reachable for the unit tests. the explicit manifest goal generated
them during processing the classses and the scrLocation property tells it where
to put them so the unit tests can find them. it took me some time as well to
get this right.
> Dump SCR component definitions broken
> -
>
> Key: FELIX-5116
> URL: https://issues.apache.org/jira/browse/FELIX-5116
> Project: Felix
> Issue Type: Bug
> Components: Maven Bundle Plugin
>Affects Versions: maven-bundle-plugin-3.0.0
>Reporter: Stefan Seifert
> Fix For: maven-bundle-plugin-3.1.0
>
> Attachments: FELIX-5116.patch
>
>
> the feature to optionally dump SCR component definitions generated by bnd to
> the output classes folder introduced in FELIX-3324 is broken ins
> maven-bundle-plugin 3.0.0 and 3.0.1 - the associated code is never called
> when generating the bundle or manifest.
> the attached patch fixes this and enabled the behavior for both manifest and
> bundle goals.
> this feature is imporant for unit test support in IDEs, e.g. for
> https://sling.apache.org/documentation/development/osgi-mock.html
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (FELIX-5116) Dump SCR component definitions broken
[ https://issues.apache.org/jira/browse/FELIX-5116?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15367563#comment-15367563 ] Stefan Seifert commented on FELIX-5116: --- yes and yes basically this is the parent pom i've used to test my projects: https://github.com/wcm-io/wcm-io-tooling/blob/develop/maven/aem-global-parent/pom.xml i've configured an explicit call to the manifest goal in the pom to have them ready during the osgi-mock based unit tests, and that's before the bundle goal is executed. it works fine for me on the command line and within eclipse with m2e. > Dump SCR component definitions broken > - > > Key: FELIX-5116 > URL: https://issues.apache.org/jira/browse/FELIX-5116 > Project: Felix > Issue Type: Bug > Components: Maven Bundle Plugin >Affects Versions: maven-bundle-plugin-3.0.0 >Reporter: Stefan Seifert > Fix For: maven-bundle-plugin-3.1.0 > > Attachments: FELIX-5116.patch > > > the feature to optionally dump SCR component definitions generated by bnd to > the output classes folder introduced in FELIX-3324 is broken ins > maven-bundle-plugin 3.0.0 and 3.0.1 - the associated code is never called > when generating the bundle or manifest. > the attached patch fixes this and enabled the behavior for both manifest and > bundle goals. > this feature is imporant for unit test support in IDEs, e.g. for > https://sling.apache.org/documentation/development/osgi-mock.html -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Resolved] (FELIX-5116) Dump SCR component definitions broken
[ https://issues.apache.org/jira/browse/FELIX-5116?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Stefan Seifert resolved FELIX-5116. --- Resolution: Fixed > Dump SCR component definitions broken > - > > Key: FELIX-5116 > URL: https://issues.apache.org/jira/browse/FELIX-5116 > Project: Felix > Issue Type: Bug > Components: Maven Bundle Plugin >Affects Versions: maven-bundle-plugin-3.0.0 >Reporter: Stefan Seifert > Fix For: maven-bundle-plugin-3.1.0 > > Attachments: FELIX-5116.patch > > > the feature to optionally dump SCR component definitions generated by bnd to > the output classes folder introduced in FELIX-3324 is broken ins > maven-bundle-plugin 3.0.0 and 3.0.1 - the associated code is never called > when generating the bundle or manifest. > the attached patch fixes this and enabled the behavior for both manifest and > bundle goals. > this feature is imporant for unit test support in IDEs, e.g. for > https://sling.apache.org/documentation/development/osgi-mock.html -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (FELIX-5116) Dump SCR component definitions broken
[ https://issues.apache.org/jira/browse/FELIX-5116?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15367549#comment-15367549 ] Stefan Seifert commented on FELIX-5116: --- [~cvgaviao] its still working fine on my side, so my issue from this ticket is solved. i checked with one of my project - the bpHeader is not null in my case. i think it's best for your to create a separate issue - and perhaps you can provide an example project as well to reproduce your problem. > Dump SCR component definitions broken > - > > Key: FELIX-5116 > URL: https://issues.apache.org/jira/browse/FELIX-5116 > Project: Felix > Issue Type: Bug > Components: Maven Bundle Plugin >Affects Versions: maven-bundle-plugin-3.0.0 >Reporter: Stefan Seifert > Fix For: maven-bundle-plugin-3.1.0 > > Attachments: FELIX-5116.patch > > > the feature to optionally dump SCR component definitions generated by bnd to > the output classes folder introduced in FELIX-3324 is broken ins > maven-bundle-plugin 3.0.0 and 3.0.1 - the associated code is never called > when generating the bundle or manifest. > the attached patch fixes this and enabled the behavior for both manifest and > bundle goals. > this feature is imporant for unit test support in IDEs, e.g. for > https://sling.apache.org/documentation/development/osgi-mock.html -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (FELIX-4009) maven bundle plugin should be integrated directly with eclipse
[ https://issues.apache.org/jira/browse/FELIX-4009?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15308077#comment-15308077 ] Stefan Seifert commented on FELIX-4009: --- thanks! - this should be all > maven bundle plugin should be integrated directly with eclipse > -- > > Key: FELIX-4009 > URL: https://issues.apache.org/jira/browse/FELIX-4009 > Project: Felix > Issue Type: New Feature > Components: Maven Bundle Plugin >Affects Versions: maven-bundle-plugin-2.3.7 >Reporter: Andrei Pozolotin >Assignee: Carsten Ziegeler > Labels: m2e > Fix For: maven-bundle-plugin-3.1.0 > > > Stuart: > 1) currently, to integrate maven-bundle-plugin into m2e, one must use tycho > configurator > https://github.com/sonatype/m2eclipse-tycho > which adds needles complexity, and makes few strange assumptions > https://github.com/sonatype/m2eclipse-tycho/blob/master/org.sonatype.tycho.m2e/src/org/sonatype/tycho/m2e/internal/OsgiBundleProjectConfigurator.java#L74 > which no one it seems is there to care to correct > https://github.com/sonatype/m2eclipse-tycho/pull/8 > 2) instead, I suggest maven-bundle-plugin to provide direct integration with > eclipse via > http://wiki.eclipse.org/M2E_compatible_maven_plugins#BuildContext > which I would expect to be more customizable / flexible for the end user. > I recently made similar switch with my DS plugin, and life got easier :-) > https://github.com/carrot-garden/carrot-maven/tree/master/carrot-maven-scr-plugin > thanks. > Andrei. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (FELIX-4009) maven bundle plugin should be integrated directly with eclipse
[ https://issues.apache.org/jira/browse/FELIX-4009?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15241197#comment-15241197 ] Stefan Seifert commented on FELIX-4009: --- can we apply the changes from my 2nd pull request as well (see previous comment)? they are together with the first PR quite un-intrusive, so for users who do not use osgi mocks and do not care about incremental build support in eclipse not much should change (because only the manifest goal is instrumented to be used in eclipse, which osgi mock users should configure in their poms). if we do not want to apply it because the full solution is not perfect due to external constraints (see previous comment) we should revert the changes from my first PR on the code base. what's currently applied without the second PR is unstable. > maven bundle plugin should be integrated directly with eclipse > -- > > Key: FELIX-4009 > URL: https://issues.apache.org/jira/browse/FELIX-4009 > Project: Felix > Issue Type: New Feature > Components: Maven Bundle Plugin >Affects Versions: maven-bundle-plugin-2.3.7 >Reporter: Andrei Pozolotin >Assignee: Carsten Ziegeler > Labels: m2e > Fix For: maven-bundle-plugin-3.0.2 > > > Stuart: > 1) currently, to integrate maven-bundle-plugin into m2e, one must use tycho > configurator > https://github.com/sonatype/m2eclipse-tycho > which adds needles complexity, and makes few strange assumptions > https://github.com/sonatype/m2eclipse-tycho/blob/master/org.sonatype.tycho.m2e/src/org/sonatype/tycho/m2e/internal/OsgiBundleProjectConfigurator.java#L74 > which no one it seems is there to care to correct > https://github.com/sonatype/m2eclipse-tycho/pull/8 > 2) instead, I suggest maven-bundle-plugin to provide direct integration with > eclipse via > http://wiki.eclipse.org/M2E_compatible_maven_plugins#BuildContext > which I would expect to be more customizable / flexible for the end user. > I recently made similar switch with my DS plugin, and life got easier :-) > https://github.com/carrot-garden/carrot-maven/tree/master/carrot-maven-scr-plugin > thanks. > Andrei. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (FELIX-4009) maven bundle plugin should be integrated directly with eclipse
[
https://issues.apache.org/jira/browse/FELIX-4009?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15205427#comment-15205427
]
Stefan Seifert commented on FELIX-4009:
---
i've contributed another PR with further improvements on this issue:
https://github.com/apache/felix/pull/60
this fixes the "big number of compilations/maven builds where one would be
sufficient" issue together with old-style felix SCR annotations. additionally
it adds a flag {{supportIncrementalBuild}} to the {{manifest}} goal which
defaults to "false", so performance implications on incremental builds may only
occur if this is switched to true (which is required of course if you want to
profit from SCR incremental builds). additionally i added a simple check before
starting the incremental build to run it only if any *.java file was added,
updated or removed since last build. detection changes on the pom.xml did not
work, eclipse project clean may be required in this case.
i think those both contributions are a useful addition to the maven scr plugin.
it adds a sensible default m2e configuration, although some manual work is
required to get support of incremental builds and running osgi-mock based unit
tests (see below).
still, the solution is not optimal - some background information:
# for the usecase for generating the required SCR metadata before the unit test
run these have to be generated before the unit tests are executed (this is also
true for a command line build, not only in Eclipse). this is the reason why
using only the {{bundle}} goal does not work, one has to define an explicit
additionally {{manifest}} goal as well - example:
{code:xml}
org.apache.felix
maven-bundle-plugin
true
scr-metadata
manifest
true
...
{code}
this is tedious and has to be well documented. and in practice on a normal
build the manifest and SCR files are generated twice - once for the manifest
goal and once for the bundle goal. the reason is that the bndlib does not
differ between those usecases internally.
# generation of the SCR metadata seems to be a bit faster with the
maven-scr-plugin than with the maven bundle plugin/bndlib. the reason is that
bndlib does much more magic on manifest generation, and generating the SCR
metadata is more a side-product of this call.
# but the biggest issue is that the bndlib currently does not support
incremental generation. it always does the full job, analyzes all classes, does
all magic, generates all SCR metadata using all configured bnd plugins. i see
no easy way to add support for this in bndlib with the API as-is. so this is a
bit of blocker for further improvements in this area.
# i see no possibilities to step between the plugin and bndlib and apply any
improvements like robert suggested
[here|https://issues.apache.org/jira/browse/FELIX-4009?focusedCommentId=15194952#comment-15194952].
after encountering those issues i was thinking about an easy alternative: the
source of the problem was supporting the new OSGi R6 annotation which are
currently support by bndlib, but not by the maven-scr-plugin. perhaps we should
just add support for them in maven-scr-plugin which has very good incremental
support in eclipse and is stable, and do not use bndlib for this until it has
better support for incremental building.
> maven bundle plugin should be integrated directly with eclipse
> --
>
> Key: FELIX-4009
> URL: https://issues.apache.org/jira/browse/FELIX-4009
> Project: Felix
> Issue Type: New Feature
> Components: Maven Bundle Plugin
>Affects Versions: maven-bundle-plugin-2.3.7
>Reporter: Andrei Pozolotin
>Assignee: Carsten Ziegeler
> Labels: m2e
> Fix For: maven-bundle-plugin-3.0.2
>
>
> Stuart:
> 1) currently, to integrate maven-bundle-plugin into m2e, one must use tycho
> configurator
> https://github.com/sonatype/m2eclipse-tycho
> which adds needles complexity, and makes few strange assumptions
> https://github.com/sonatype/m2eclipse-tycho/blob/master/org.sonatype.tycho.m2e/src/org/sonatype/tycho/m2e/internal/OsgiBundleProjectConfigurator.java#L74
> which no one it seems is there to care to correct
> https://github.com/sonatype/m2eclipse-tycho/pull/8
> 2) instead, I suggest maven-bundle-plugin to provide direct integration with
> eclipse via
> http://wiki.eclipse.org/M2E_compatible_maven_plugins#BuildContext
> which I would expect to be more customizable / flexible for the end user.
> I recently made similar switch with my DS plugin, and life got easier :-)
> https://github.com/carrot-garden/carrot-maven/tree/master/carrot-maven
[jira] [Commented] (FELIX-4009) maven bundle plugin should be integrated directly with eclipse
[
https://issues.apache.org/jira/browse/FELIX-4009?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15194918#comment-15194918
]
Stefan Seifert commented on FELIX-4009:
---
yes, i'm still working on this. (btw., carsten you forget one file from the
patch, the file
{{tools/maven-bundle-plugin/src/main/resources/META-INF/m2e/lifecycle-mapping-metadata.xml}})
- i can contribute it again with the next patch.
currently i'm debugging an issue on a project with a lot of old-style felix SCR
annotations where the eclipse builder does get mixed up with resource file
change detection and starts a big number of compilations/maven builds where one
would be sufficient.
regarding the open points mentioned by konrad:
bq. 1. it conflicts with m2e-tycho
(http://dev.eclipse.org/mhonarc/lists/m2e-users/msg05444.html)
i'm still not shure when this m2e-tycho plugin gets installed. konrad described
when this is happening here:
https://github.com/apache/felix/pull/57#issuecomment-195718014
i've never used this catalog, but perhaps others are affected. the answer in
http://dev.eclipse.org/mhonarc/lists/m2e-users/msg05444.html is:
"Anders Hammar: As I understand the plugin has priority. The connector will be
ignored.".
so there is no conflict?
bq. 2. it does only cover goal manifest but not bundle
this is by intention! the goal is not to do a complete maven build in eclipse.
if you compare it with a non-osgi project: eclipse does not build the jar file,
it does only the compilation. so we do not need to build the bundle here. the
goal is to produce only the artefact that are required by other tools in
eclipse. my main usecase are the SCR metadata required for unit tests based on
osgi-mock. the bundle manifest file would be usefull to in unit test context.
the package imports/exports are normally not import in unit test context, but
we should avoid to produce only partially valid manifest files so we should
generate them as well.
but the bundle goal should not be executed in eclipse.
bq. 3. it might not work for larger projects as triggering the manifest
calculation for every change might just consumer just too much resources (see
also
https://github.com/tesla/m2eclipse-tycho/commit/85cd048ffcd47020992bdec2cd44f1a4945173bf
and
https://github.com/bndtools/bnd/commit/9a899b4eb50b6684b9a75759697066e84e82d16d.
i had some ideas in
https://github.com/apache/felix/pull/57#issuecomment-195712456 how to generate
SCR metadata only when required, but as konrad and robert point out this is not
so easy as it seems.
so my first option would be to make it configurable in the POM whether SCR
metadata and manifest should be generated on incremental builds or not. in my
tests it was not that slow. so each project can decide between comfort and
performance. i will include such an option in an updated patch.
> maven bundle plugin should be integrated directly with eclipse
> --
>
> Key: FELIX-4009
> URL: https://issues.apache.org/jira/browse/FELIX-4009
> Project: Felix
> Issue Type: New Feature
> Components: Maven Bundle Plugin
>Affects Versions: maven-bundle-plugin-2.3.7
>Reporter: Andrei Pozolotin
>Assignee: Carsten Ziegeler
> Labels: m2e
> Fix For: maven-bundle-plugin-3.0.2
>
>
> Stuart:
> 1) currently, to integrate maven-bundle-plugin into m2e, one must use tycho
> configurator
> https://github.com/sonatype/m2eclipse-tycho
> which adds needles complexity, and makes few strange assumptions
> https://github.com/sonatype/m2eclipse-tycho/blob/master/org.sonatype.tycho.m2e/src/org/sonatype/tycho/m2e/internal/OsgiBundleProjectConfigurator.java#L74
> which no one it seems is there to care to correct
> https://github.com/sonatype/m2eclipse-tycho/pull/8
> 2) instead, I suggest maven-bundle-plugin to provide direct integration with
> eclipse via
> http://wiki.eclipse.org/M2E_compatible_maven_plugins#BuildContext
> which I would expect to be more customizable / flexible for the end user.
> I recently made similar switch with my DS plugin, and life got easier :-)
> https://github.com/carrot-garden/carrot-maven/tree/master/carrot-maven-scr-plugin
> thanks.
> Andrei.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (FELIX-4009) maven bundle plugin should be integrated directly with eclipse
[ https://issues.apache.org/jira/browse/FELIX-4009?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15191624#comment-15191624 ] Stefan Seifert commented on FELIX-4009: --- i've contributed a patch for this https://github.com/apache/felix/pull/57 * define m2e lifecycle mapping metadata, enable incremental build for manifest (and SCR metadata) generation - important for unit tests e.g. with sling/osgi-mock * make sure all files that are written use file output streams created via BuildContext to make sure eclipse get notice of it it would be nice to get this integrated into the next maven-bundle-plugin version. m2e support was missing for a long time. this feature is especially important when using sling osgi-mock for unit testing and generate SCR metadata not via the SCR plugin, but via maven-bundle-plugin and bnd. > maven bundle plugin should be integrated directly with eclipse > -- > > Key: FELIX-4009 > URL: https://issues.apache.org/jira/browse/FELIX-4009 > Project: Felix > Issue Type: New Feature > Components: Maven Bundle Plugin >Affects Versions: maven-bundle-plugin-2.3.7 >Reporter: Andrei Pozolotin > Labels: m2e > Fix For: maven-bundle-plugin-future > > > Stuart: > 1) currently, to integrate maven-bundle-plugin into m2e, one must use tycho > configurator > https://github.com/sonatype/m2eclipse-tycho > which adds needles complexity, and makes few strange assumptions > https://github.com/sonatype/m2eclipse-tycho/blob/master/org.sonatype.tycho.m2e/src/org/sonatype/tycho/m2e/internal/OsgiBundleProjectConfigurator.java#L74 > which no one it seems is there to care to correct > https://github.com/sonatype/m2eclipse-tycho/pull/8 > 2) instead, I suggest maven-bundle-plugin to provide direct integration with > eclipse via > http://wiki.eclipse.org/M2E_compatible_maven_plugins#BuildContext > which I would expect to be more customizable / flexible for the end user. > I recently made similar switch with my DS plugin, and life got easier :-) > https://github.com/carrot-garden/carrot-maven/tree/master/carrot-maven-scr-plugin > thanks. > Andrei. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Updated] (FELIX-5149) maven-bundle-plugin: Update to bndlib 3.1.0
[ https://issues.apache.org/jira/browse/FELIX-5149?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Stefan Seifert updated FELIX-5149: -- Attachment: FELIX-5149_bndlip-3.1.0.patch > maven-bundle-plugin: Update to bndlib 3.1.0 > --- > > Key: FELIX-5149 > URL: https://issues.apache.org/jira/browse/FELIX-5149 > Project: Felix > Issue Type: Improvement > Components: Maven Bundle Plugin >Affects Versions: maven-bundle-plugin-3.0.1 >Reporter: Stefan Seifert > Fix For: maven-bundle-plugin-3.0.2 > > Attachments: FELIX-5149_bndlip-3.1.0.patch > > > bndlib 3.1.0 was released some days ago. > we should update maven-bundle-plugin to this version. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Created] (FELIX-5149) maven-bundle-plugin: Update to bndlib 3.1.0
Stefan Seifert created FELIX-5149: - Summary: maven-bundle-plugin: Update to bndlib 3.1.0 Key: FELIX-5149 URL: https://issues.apache.org/jira/browse/FELIX-5149 Project: Felix Issue Type: Improvement Components: Maven Bundle Plugin Affects Versions: maven-bundle-plugin-3.0.1 Reporter: Stefan Seifert Fix For: maven-bundle-plugin-3.0.2 Attachments: FELIX-5149_bndlip-3.1.0.patch bndlib 3.1.0 was released some days ago. we should update maven-bundle-plugin to this version. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Comment Edited] (FELIX-5116) maven-bundle-plugin: Dump SCR component definitions broken
[ https://issues.apache.org/jira/browse/FELIX-5116?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15024017#comment-15024017 ] Stefan Seifert edited comment on FELIX-5116 at 11/24/15 8:48 AM: - yes, correctly. they are packed directly in the JAR file by bnd, but do not appear in the target/classes directory as it was/is the case with felix SCR annotations and the maven SCR plugin (and even the SCR BND plugin). this code (which was alread developed in FELIX-3324, but broken) unpacks those XML files again and stores them in the target/classes directory (if enabled via maven configuration parameters on goals bundle or manifest). was (Author: sseif...@pro-vision.de): yes, correctly. they are packed directly in the JAR file by maven-bundle-plugin, but do not appear in the target/classes directory as it was/is the case with felix SCR annotations and the maven SCR plugin (and even the SCR BND plugin). this code (which was alread developed in FELIX-3324, but broken) unpacks those XML files again and stores them in the target/classes directory (if enabled via maven configuration parameters on goals bundle or manifest). > maven-bundle-plugin: Dump SCR component definitions broken > -- > > Key: FELIX-5116 > URL: https://issues.apache.org/jira/browse/FELIX-5116 > Project: Felix > Issue Type: Bug > Components: Maven Bundle Plugin >Affects Versions: maven-bundle-plugin-3.0.0 >Reporter: Stefan Seifert > Fix For: maven-bundle-plugin-3.0.2 > > Attachments: FELIX-5116.patch > > > the feature to optionally dump SCR component definitions generated by bnd to > the output classes folder introduced in FELIX-3324 is broken ins > maven-bundle-plugin 3.0.0 and 3.0.1 - the associated code is never called > when generating the bundle or manifest. > the attached patch fixes this and enabled the behavior for both manifest and > bundle goals. > this feature is imporant for unit test support in IDEs, e.g. for > https://sling.apache.org/documentation/development/osgi-mock.html -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (FELIX-5116) maven-bundle-plugin: Dump SCR component definitions broken
[ https://issues.apache.org/jira/browse/FELIX-5116?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15024017#comment-15024017 ] Stefan Seifert commented on FELIX-5116: --- yes, correctly. they are packed directly in the JAR file by maven-bundle-plugin, but do not appear in the target/classes directory as it was/is the case with felix SCR annotations and the maven SCR plugin (and even the SCR BND plugin). this code (which was alread developed in FELIX-3324, but broken) unpacks those XML files again and stores them in the target/classes directory (if enabled via maven configuration parameters on goals bundle or manifest). > maven-bundle-plugin: Dump SCR component definitions broken > -- > > Key: FELIX-5116 > URL: https://issues.apache.org/jira/browse/FELIX-5116 > Project: Felix > Issue Type: Bug > Components: Maven Bundle Plugin >Affects Versions: maven-bundle-plugin-3.0.0 >Reporter: Stefan Seifert > Fix For: maven-bundle-plugin-3.0.2 > > Attachments: FELIX-5116.patch > > > the feature to optionally dump SCR component definitions generated by bnd to > the output classes folder introduced in FELIX-3324 is broken ins > maven-bundle-plugin 3.0.0 and 3.0.1 - the associated code is never called > when generating the bundle or manifest. > the attached patch fixes this and enabled the behavior for both manifest and > bundle goals. > this feature is imporant for unit test support in IDEs, e.g. for > https://sling.apache.org/documentation/development/osgi-mock.html -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (FELIX-3324) Allow maven-bundle-plugin:manifest to dump SCR component definitions generated by bnd
[ https://issues.apache.org/jira/browse/FELIX-3324?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15023155#comment-15023155 ] Stefan Seifert commented on FELIX-3324: --- please note that this feature is broken in maven-bundle-plugin 3.0.0 and 3.0.1 - FELIX-5116 should fix this. > Allow maven-bundle-plugin:manifest to dump SCR component definitions > generated by bnd > - > > Key: FELIX-3324 > URL: https://issues.apache.org/jira/browse/FELIX-3324 > Project: Felix > Issue Type: Improvement > Components: Maven Bundle Plugin >Affects Versions: maven-bundle-plugin-2.3.6 >Reporter: Ivan Dubrov >Assignee: Guillaume Nodet > Labels: patch > Fix For: maven-bundle-plugin-3.0.0 > > Attachments: export-scr.patch > > Original Estimate: 2h > Remaining Estimate: 2h > > maven-bundle-plugin allows dumping generated MANIFEST.MF, but does not allow > dumping SCR component definitions generated by the bnd (based on the > component annotations). For example, this could be useful if you need those > files to run the OSGi framework from the IDE without packaging everything. > "unpackBundle" allows achieving the desired behaviour, but it could be too > heavy for large bundles. > I suggest adding two properties to the plugin, "exportScr" to enable SCR > definitions export and "scrLocation" to specify directory to dump those > definitions. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Updated] (FELIX-5116) maven-bundle-plugin: Dump SCR component definitions broken
[ https://issues.apache.org/jira/browse/FELIX-5116?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Stefan Seifert updated FELIX-5116: -- Attachment: FELIX-5116.patch > maven-bundle-plugin: Dump SCR component definitions broken > -- > > Key: FELIX-5116 > URL: https://issues.apache.org/jira/browse/FELIX-5116 > Project: Felix > Issue Type: Bug > Components: Maven Bundle Plugin >Affects Versions: maven-bundle-plugin-3.0.0 >Reporter: Stefan Seifert > Fix For: maven-bundle-plugin-3.0.2 > > Attachments: FELIX-5116.patch > > > the feature to optionally dump SCR component definitions generated by bnd to > the output classes folder introduced in FELIX-3324 is broken ins > maven-bundle-plugin 3.0.0 and 3.0.1 - the associated code is never called > when generating the bundle or manifest. > the attached patch fixes this and enabled the behavior for both manifest and > bundle goals. > this feature is imporant for unit test support in IDEs, e.g. for > https://sling.apache.org/documentation/development/osgi-mock.html -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Created] (FELIX-5116) maven-bundle-plugin: Dump SCR component definitions broken
Stefan Seifert created FELIX-5116: - Summary: maven-bundle-plugin: Dump SCR component definitions broken Key: FELIX-5116 URL: https://issues.apache.org/jira/browse/FELIX-5116 Project: Felix Issue Type: Bug Components: Maven Bundle Plugin Affects Versions: maven-bundle-plugin-3.0.0 Reporter: Stefan Seifert Fix For: maven-bundle-plugin-3.0.2 the feature to optionally dump SCR component definitions generated by bnd to the output classes folder introduced in FELIX-3324 is broken ins maven-bundle-plugin 3.0.0 and 3.0.1 - the associated code is never called when generating the bundle or manifest. the attached patch fixes this and enabled the behavior for both manifest and bundle goals. this feature is imporant for unit test support in IDEs, e.g. for https://sling.apache.org/documentation/development/osgi-mock.html -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Updated] (FELIX-5108) scr bnd plugin: Add option to suppress writing log to filesystem
[
https://issues.apache.org/jira/browse/FELIX-5108?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Stefan Seifert updated FELIX-5108:
--
Attachment: FELIX-5108-logToFile.patch
attached is a patch: [^FELIX-5108-logToFile.patch]
it uses "true" as default value for {{logToFile}}, you may change it to false
if it suites better.
> scr bnd plugin: Add option to suppress writing log to filesystem
>
>
> Key: FELIX-5108
> URL: https://issues.apache.org/jira/browse/FELIX-5108
> Project: Felix
> Issue Type: Improvement
> Components: SCR Tooling
>Affects Versions: scr bnd plugin 1.4.0
>Reporter: Stefan Seifert
> Fix For: scr bnd plugin 1.5.0
>
> Attachments: FELIX-5108-logToFile.patch
>
>
> Currently the scr bnd plugins passes log information not only back to bnd via
> bnd's reporter, but also writes a log file to
> {noformat}
> /tmp/scrplugin/.log
> {noformat}
> this can create problems on systems where writing to such a path is not
> permitted (e.g. on CI servers running concurrently multiple jobs), and it is
> not always useful either.
> A new option {{logToFile}} should be added, default value is true = current
> behavior. if set to false the log file is not written to the temp directory.
> One could discuss if perphaps a default value of false would suite better,
> because it is quite uncommon to write a log file to a fixed path by default.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Created] (FELIX-5108) scr bnd plugin: Add option to suppress writing log to filesystem
Stefan Seifert created FELIX-5108:
-
Summary: scr bnd plugin: Add option to suppress writing log to
filesystem
Key: FELIX-5108
URL: https://issues.apache.org/jira/browse/FELIX-5108
Project: Felix
Issue Type: Improvement
Components: SCR Tooling
Affects Versions: scr bnd plugin 1.4.0
Reporter: Stefan Seifert
Fix For: scr bnd plugin 1.5.0
Currently the scr bnd plugins passes log information not only back to bnd via
bnd's reporter, but also writes a log file to
{noformat}
/tmp/scrplugin/.log
{noformat}
this can create problems on systems where writing to such a path is not
permitted (e.g. on CI servers running concurrently multiple jobs), and it is
not always useful either.
A new option {{logToFile}} should be added, default value is true = current
behavior. if set to false the log file is not written to the temp directory.
One could discuss if perphaps a default value of false would suite better,
because it is quite uncommon to write a log file to a fixed path by default.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Updated] (FELIX-4710) Web Console: Display templated name hint for factory configuration entries
[
https://issues.apache.org/jira/browse/FELIX-4710?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Stefan Seifert updated FELIX-4710:
--
Attachment: 150120_FELIX-4710_site_update.patch
added an update of the felix documentation site for this feature as well:
[^150120_FELIX-4710_site_update.patch]
> Web Console: Display templated name hint for factory configuration entries
> --
>
> Key: FELIX-4710
> URL: https://issues.apache.org/jira/browse/FELIX-4710
> Project: Felix
> Issue Type: Improvement
> Components: Web Console
>Affects Versions: webconsole-4.2.2
>Reporter: Stefan Seifert
>Assignee: Carsten Ziegeler
> Fix For: webconsole-4.2.6
>
> Attachments: 141126_FELIX-4710_webconsole_namehint.patch,
> 150119_FELIX-4710_webconsole_namehint_update.patch,
> 150120_FELIX-4710_site_update.patch, factoryconfig.gif,
> factoryconfig_namehint.gif
>
>
> currently for each factory configuration entry in the web console only a very
> cryptic name is displayed, consisting of the factory PID and a GUID. this is
> very inconvenient esp. if there are a lot of entries and the user want to
> edit a specific one:
> !factoryconfig.gif!
> proposal: the author of the OSGi service with factory configuration should be
> able to provide a "nameHint" template to display a nice human-readable name,
> and display the pid+gui only as tooltip:
> !factoryconfig_namehint.gif!
> attached is a patch with draft implementation of this based on an optional
> service property {{webconsole.configurationFactory.nameHint}} which can be
> set on the service which can reference other property names with
> placeholders. the web console then displays this name hint with the
> configured values replaced.
> example (using SCR annotation):
> {code:java}
> @Property(name = "webconsole.configurationFactory.nameHint", value =
> "{serviceName}: {ribbonHosts}")
> {code}
> this will help on a lot of services, e.g. factory configurations for log
> configuration an others.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Updated] (FELIX-4710) Web Console: Display templated name hint for factory configuration entries
[
https://issues.apache.org/jira/browse/FELIX-4710?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Stefan Seifert updated FELIX-4710:
--
Attachment: 150119_FELIX-4710_webconsole_namehint_update.patch
> Web Console: Display templated name hint for factory configuration entries
> --
>
> Key: FELIX-4710
> URL: https://issues.apache.org/jira/browse/FELIX-4710
> Project: Felix
> Issue Type: Improvement
> Components: Web Console
>Affects Versions: webconsole-4.2.2
>Reporter: Stefan Seifert
>Assignee: Carsten Ziegeler
> Fix For: webconsole-4.2.6
>
> Attachments: 141126_FELIX-4710_webconsole_namehint.patch,
> 150119_FELIX-4710_webconsole_namehint_update.patch, factoryconfig.gif,
> factoryconfig_namehint.gif
>
>
> currently for each factory configuration entry in the web console only a very
> cryptic name is displayed, consisting of the factory PID and a GUID. this is
> very inconvenient esp. if there are a lot of entries and the user want to
> edit a specific one:
> !factoryconfig.gif!
> proposal: the author of the OSGi service with factory configuration should be
> able to provide a "nameHint" template to display a nice human-readable name,
> and display the pid+gui only as tooltip:
> !factoryconfig_namehint.gif!
> attached is a patch with draft implementation of this based on an optional
> service property {{webconsole.configurationFactory.nameHint}} which can be
> set on the service which can reference other property names with
> placeholders. the web console then displays this name hint with the
> configured values replaced.
> example (using SCR annotation):
> {code:java}
> @Property(name = "webconsole.configurationFactory.nameHint", value =
> "{serviceName}: {ribbonHosts}")
> {code}
> this will help on a lot of services, e.g. factory configurations for log
> configuration an others.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Reopened] (FELIX-4710) Web Console: Display templated name hint for factory configuration entries
[
https://issues.apache.org/jira/browse/FELIX-4710?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Stefan Seifert reopened FELIX-4710:
---
thanks for applying!
i've attached an additional patch based on current trunk which fixes one last
issue and adds some polishing:
[^150119_FELIX-4710_webconsole_namehint_update.patch]
the new version is able to insert a default value if no configured value is set
for a placeholder, and makes sure the resulting name hint does not only consist
of whitespaces. additionally always all placeholders are replaced.
> Web Console: Display templated name hint for factory configuration entries
> --
>
> Key: FELIX-4710
> URL: https://issues.apache.org/jira/browse/FELIX-4710
> Project: Felix
> Issue Type: Improvement
> Components: Web Console
>Affects Versions: webconsole-4.2.2
>Reporter: Stefan Seifert
>Assignee: Carsten Ziegeler
> Fix For: webconsole-4.2.6
>
> Attachments: 141126_FELIX-4710_webconsole_namehint.patch,
> factoryconfig.gif, factoryconfig_namehint.gif
>
>
> currently for each factory configuration entry in the web console only a very
> cryptic name is displayed, consisting of the factory PID and a GUID. this is
> very inconvenient esp. if there are a lot of entries and the user want to
> edit a specific one:
> !factoryconfig.gif!
> proposal: the author of the OSGi service with factory configuration should be
> able to provide a "nameHint" template to display a nice human-readable name,
> and display the pid+gui only as tooltip:
> !factoryconfig_namehint.gif!
> attached is a patch with draft implementation of this based on an optional
> service property {{webconsole.configurationFactory.nameHint}} which can be
> set on the service which can reference other property names with
> placeholders. the web console then displays this name hint with the
> configured values replaced.
> example (using SCR annotation):
> {code:java}
> @Property(name = "webconsole.configurationFactory.nameHint", value =
> "{serviceName}: {ribbonHosts}")
> {code}
> this will help on a lot of services, e.g. factory configurations for log
> configuration an others.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Comment Edited] (FELIX-4550) Upgrade embedded Jetty to version 9.2.x in Felix Http Jetty
[
https://issues.apache.org/jira/browse/FELIX-4550?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14234732#comment-14234732
]
Stefan Seifert edited comment on FELIX-4550 at 12/4/14 10:39 PM:
-
attached is an updated version of the patch: [^141204_FELIX-4550_jetty9.patch]
changes additionally to the previous patch:
- updated to jetty 9.2.5.v20141112
- updated all http maven modules via parent pom to JDK 1.7 (not only the jetty
bundle itself, other bundles depend on jetty thus JDK 1.7 as well)
- updated parent pom to servlet 3.1
- re-enabled the configuration option for enabling/disabling JMX stats
publishing and validated that it's working
- removed the commented out "sendServerHeader" code after validation that the
new code in configureHttpConnectionFactory works properly
- removed the configuration options org.apache.felix.http.nio and
org.apache.felix.https.nio because the ServerConnector from Jetty 9 always uses
NIO
- switched println calls in one integration test to print("...\n") because the
other variant failed on windows (i assume platform-dependent new-line)
---
i did not change yet the versions of the poms itself, although it was aggreed
to raise them to the next major version. i'm not sure how to proceed best here
- the felix.http.* poms use different version schemes - most use 2.3.x, others
a single version number, others numbers like 1.0.x or 0.2.x.
when you want to create a branch all of them have to be raised to the next
major version - which does not work e.g. for the parent pom which has only a
single version number. perhaps all poms including the parent pom should be
raised to 3.0.x, to make sure there are no clashes if poms from the old 2.x
branch for JDK versions < 1.7 are released.
was (Author: sseif...@pro-vision.de):
attached is an updated version of the patch: [^141204_FELIX-4550_jetty9.patch]
changes additionally to the previous patch:
- updated to jetty 9.2.5.v20141112
- updated all http maven modules via parent pom to JDK 1.7 (not only the jetty
bundle itself, other bundles depend on jetty thus JDK 1.7 as well)
- updated parent pom to servlet 3.1
- re-enabled the configuration option for enabling/disabling JMX stats
publishing and validated that it's working
- removed the commented out "sendServerHeader" code after validation that the
new code in configureHttpConnectionFactory works properly
- removed the configuration options org.apache.felix.http.nio and
org.apache.felix.https.nio because the ServerConnector from Jetty 9 always uses
NIO
- switched println calls in one integration test to print("...\n") because the
other variant failed on windows (i assume platform-dependent new-line)
---
i did not change yet the versions of the poms itself, although it was aggred to
raise them to the next major version. i'm not sure how to proceed best
currently - the felix.http.* poms use different version schemes - most use
2.3.x, others a single version number, others numbers like 1.0.x or 0.2.x.
when you want to create a branch all of them have to be raised to the next
major version - which does not work e.g. for the parent pom which has only a
single version number. perhaps all poms including the parent pom should be
raised to 3.0.x, to make sure they are no clashes if poms from the old 2.x
branch for JDK versions < 1.7 are released.
> Upgrade embedded Jetty to version 9.2.x in Felix Http Jetty
> ---
>
> Key: FELIX-4550
> URL: https://issues.apache.org/jira/browse/FELIX-4550
> Project: Felix
> Issue Type: New Feature
> Components: HTTP Service
>Reporter: Chetan Mehrotra
> Attachments: 141204_FELIX-4550_jetty9.patch, FELIX-4550.patch
>
>
> Currently HTTP Service embeds Jetty 8.1.14.v20131031 which supports Servlet
> 3.0. Current Jetty version 9.2.1.v20140609 supports Servlet 3.1 which
> provided access to some new NIO based features. Further it also provides lots
> of new features like Spdy support , Websocket support etc [1]
> [1] https://webtide.com/jetty-9-features/
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Updated] (FELIX-4550) Upgrade embedded Jetty to version 9.2.x in Felix Http Jetty
[
https://issues.apache.org/jira/browse/FELIX-4550?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Stefan Seifert updated FELIX-4550:
--
Attachment: 141204_FELIX-4550_jetty9.patch
attached is an updated version of the patch: [^141204_FELIX-4550_jetty9.patch]
changes additionally to the previous patch:
- updated to jetty 9.2.5.v20141112
- updated all http maven modules via parent pom to JDK 1.7 (not only the jetty
bundle itself, other bundles depend on jetty thus JDK 1.7 as well)
- updated parent pom to servlet 3.1
- re-enabled the configuration option for enabling/disabling JMX stats
publishing and validated that it's working
- removed the commented out "sendServerHeader" code after validation that the
new code in configureHttpConnectionFactory works properly
- removed the configuration options org.apache.felix.http.nio and
org.apache.felix.https.nio because the ServerConnector from Jetty 9 always uses
NIO
- switched println calls in one integration test to print("...\n") because the
other variant failed on windows (i assume platform-dependent new-line)
---
i did not change yet the versions of the poms itself, although it was aggred to
raise them to the next major version. i'm not sure how to proceed best
currently - the felix.http.* poms use different version schemes - most use
2.3.x, others a single version number, others numbers like 1.0.x or 0.2.x.
when you want to create a branch all of them have to be raised to the next
major version - which does not work e.g. for the parent pom which has only a
single version number. perhaps all poms including the parent pom should be
raised to 3.0.x, to make sure they are no clashes if poms from the old 2.x
branch for JDK versions < 1.7 are released.
> Upgrade embedded Jetty to version 9.2.x in Felix Http Jetty
> ---
>
> Key: FELIX-4550
> URL: https://issues.apache.org/jira/browse/FELIX-4550
> Project: Felix
> Issue Type: New Feature
> Components: HTTP Service
>Reporter: Chetan Mehrotra
> Attachments: 141204_FELIX-4550_jetty9.patch, FELIX-4550.patch
>
>
> Currently HTTP Service embeds Jetty 8.1.14.v20131031 which supports Servlet
> 3.0. Current Jetty version 9.2.1.v20140609 supports Servlet 3.1 which
> provided access to some new NIO based features. Further it also provides lots
> of new features like Spdy support , Websocket support etc [1]
> [1] https://webtide.com/jetty-9-features/
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (FELIX-4550) Upgrade embedded Jetty to version 9.2.x in Felix Http Jetty
[ https://issues.apache.org/jira/browse/FELIX-4550?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14227986#comment-14227986 ] Stefan Seifert commented on FELIX-4550: --- we are using a snapshot version of felix http service with this patch applied for some weeks now in a osgi-based microservice prototype, it works very well. we tested esp. servlet 3.1 features like async and non-blocking processing and JAX-RS 2.0 async modes, it works as expected. can i help getting this patch into production? from the discussion i take a branch should be created for the existing http service version and to raise the version for the trunk to the next major version. remaining open points in the patch seem to be * re-enable switching on/off jmx mbeans registering by configuration * in JettyService.java is an unresolved FIXME around setSendDateHeader/setSendServerVersion - perhaps this is no longer required * updating to the latest jetty 9.2.5 version > Upgrade embedded Jetty to version 9.2.x in Felix Http Jetty > --- > > Key: FELIX-4550 > URL: https://issues.apache.org/jira/browse/FELIX-4550 > Project: Felix > Issue Type: New Feature > Components: HTTP Service >Reporter: Chetan Mehrotra > Attachments: FELIX-4550.patch > > > Currently HTTP Service embeds Jetty 8.1.14.v20131031 which supports Servlet > 3.0. Current Jetty version 9.2.1.v20140609 supports Servlet 3.1 which > provided access to some new NIO based features. Further it also provides lots > of new features like Spdy support , Websocket support etc [1] > [1] https://webtide.com/jetty-9-features/ -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (FELIX-4677) Web Console Configuration plugin is confusing about default values & optionality of elements
[ https://issues.apache.org/jira/browse/FELIX-4677?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14226029#comment-14226029 ] Stefan Seifert commented on FELIX-4677: --- thanks! > Web Console Configuration plugin is confusing about default values & > optionality of elements > > > Key: FELIX-4677 > URL: https://issues.apache.org/jira/browse/FELIX-4677 > Project: Felix > Issue Type: Improvement > Components: Web Console >Affects Versions: webconsole-4.2.2 >Reporter: Valentin Valchev >Assignee: Valentin Valchev > Attachments: FELIX-4677.jpg, FELIX-4677.patch > > > Currently if you have an empty configuration with metatype, then when the > editor is open, the default values from metatype are filled in. > However, the user cannot determine if the configuration value is set or > coming from metatype. > So there should be an indicator, that the value is the *default* and is not > actually stored in the configuration. > There is also problem with optionality of the elements. In case there is an > optional property, there is no way the user to set all other properties, but > a selected, optional property. > So there should be some checkboxes allowing the user to select which > properties to save, and which not. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (FELIX-4711) Web Console: False AJAX error displayed on deleting or unbinding config
[ https://issues.apache.org/jira/browse/FELIX-4711?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14226030#comment-14226030 ] Stefan Seifert commented on FELIX-4711: --- thanks! > Web Console: False AJAX error displayed on deleting or unbinding config > --- > > Key: FELIX-4711 > URL: https://issues.apache.org/jira/browse/FELIX-4711 > Project: Felix > Issue Type: Improvement > Components: Web Console >Affects Versions: webconsole-4.2.2 >Reporter: Stefan Seifert >Assignee: Valentin Valchev > Fix For: webconsole-4.2.4 > > Attachments: 141126_FELIX-4711_webconsole_ajaxerror.patch > > > when deleting or unbinding a configuration the webconsole displays a (false) > "AJAX Error: true" message, although the operation succeeds successfully. > the attached patch fixes the problem. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Updated] (FELIX-4711) Web Console: False AJAX error displayed on deleting or unbinding config
[ https://issues.apache.org/jira/browse/FELIX-4711?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Stefan Seifert updated FELIX-4711: -- Attachment: 141126_FELIX-4711_webconsole_ajaxerror.patch > Web Console: False AJAX error displayed on deleting or unbinding config > --- > > Key: FELIX-4711 > URL: https://issues.apache.org/jira/browse/FELIX-4711 > Project: Felix > Issue Type: Improvement > Components: Web Console >Affects Versions: webconsole-4.2.2 >Reporter: Stefan Seifert > Fix For: webconsole-4.2.4 > > Attachments: 141126_FELIX-4711_webconsole_ajaxerror.patch > > > when deleting or unbinding a configuration the webconsole displays a (false) > "AJAX Error: true" message, although the operation succeeds successfully. > the attached patch fixes the problem. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Created] (FELIX-4711) Web Console: False AJAX error displayed on deleting or unbinding config
Stefan Seifert created FELIX-4711: - Summary: Web Console: False AJAX error displayed on deleting or unbinding config Key: FELIX-4711 URL: https://issues.apache.org/jira/browse/FELIX-4711 Project: Felix Issue Type: Improvement Components: Web Console Affects Versions: webconsole-4.2.2 Reporter: Stefan Seifert Fix For: webconsole-4.2.4 when deleting or unbinding a configuration the webconsole displays a (false) "AJAX Error: true" message, although the operation succeeds successfully. the attached patch fixes the problem. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (FELIX-4710) Web Console: Display templated name hint for factory configuration entries
[
https://issues.apache.org/jira/browse/FELIX-4710?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14225514#comment-14225514
]
Stefan Seifert commented on FELIX-4710:
---
p.s. is it really required to be still compliant to JDK 1.4 with the current
webconsole version?
this is very cumbersome to code. raising at least to JDK 1.5 as it is the case
for the trunk of http://svn.apache.org/repos/asf/felix/trunk/framework would be
helpful and greatly simplify the code of this patch.
> Web Console: Display templated name hint for factory configuration entries
> --
>
> Key: FELIX-4710
> URL: https://issues.apache.org/jira/browse/FELIX-4710
> Project: Felix
> Issue Type: Improvement
> Components: Web Console
>Affects Versions: webconsole-4.2.2
>Reporter: Stefan Seifert
> Attachments: 141126_FELIX-4710_webconsole_namehint.patch,
> factoryconfig.gif, factoryconfig_namehint.gif
>
>
> currently for each factory configuration entry in the web console only a very
> cryptic name is displayed, consisting of the factory PID and a GUID. this is
> very inconvenient esp. if there are a lot of entries and the user want to
> edit a specific one:
> !factoryconfig.gif!
> proposal: the author of the OSGi service with factory configuration should be
> able to provide a "nameHint" template to display a nice human-readable name,
> and display the pid+gui only as tooltip:
> !factoryconfig_namehint.gif!
> attached is a patch with draft implementation of this based on an optional
> service property {{webconsole.configurationFactory.nameHint}} which can be
> set on the service which can reference other property names with
> placeholders. the web console then displays this name hint with the
> configured values replaced.
> example (using SCR annotation):
> {code:java}
> @Property(name = "webconsole.configurationFactory.nameHint", value =
> "{serviceName}: {ribbonHosts}")
> {code}
> this will help on a lot of services, e.g. factory configurations for log
> configuration an others.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Updated] (FELIX-4710) Web Console: Display templated name hint for factory configuration entries
[
https://issues.apache.org/jira/browse/FELIX-4710?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Stefan Seifert updated FELIX-4710:
--
Description:
currently for each factory configuration entry in the web console only a very
cryptic name is displayed, consisting of the factory PID and a GUID. this is
very inconvenient esp. if there are a lot of entries and the user want to edit
a specific one:
!factoryconfig.gif!
proposal: the author of the OSGi service with factory configuration should be
able to provide a "nameHint" template to display a nice human-readable name,
and display the pid+gui only as tooltip:
!factoryconfig_namehint.gif!
attached is a patch with draft implementation of this based on an optional
service property {{webconsole.configurationFactory.nameHint}} which can be set
on the service which can reference other property names with placeholders. the
web console then displays this name hint with the configured values replaced.
example (using SCR annotation):
{code:java}
@Property(name = "webconsole.configurationFactory.nameHint", value =
"{serviceName}: {ribbonHosts}")
{code}
this will help on a lot of services, e.g. factory configurations for log
configuration an others.
was:
currently for each factory configuration entry in the web console only a very
cryptic name is displayed, consisting of the factory PID and a GUID. this is
very inconvenient esp. if there are a lot of entries and the user want to edit
a specific one:
!factoryconfig.gif!
proposal: the author of the OSGi service with factory configuration should be
able to provide a "nameHint" template to display a nice human-readable name,
and display the pid+gui only as tooltip:
!factoryconfig_namehint.gif!
attached is a patch with draft implementation of this based on an optional
service property {{webconsole.configurationFactory.nameHint}} which can be set
on the service which can reference other property names with placeholders. the
web console then displays this name hint with the configured values replaced.
this will help on a lot of services, e.g. factory configurations for log
configuration an others.
> Web Console: Display templated name hint for factory configuration entries
> --
>
> Key: FELIX-4710
> URL: https://issues.apache.org/jira/browse/FELIX-4710
> Project: Felix
> Issue Type: Improvement
> Components: Web Console
>Affects Versions: webconsole-4.2.2
>Reporter: Stefan Seifert
> Attachments: 141126_FELIX-4710_webconsole_namehint.patch,
> factoryconfig.gif, factoryconfig_namehint.gif
>
>
> currently for each factory configuration entry in the web console only a very
> cryptic name is displayed, consisting of the factory PID and a GUID. this is
> very inconvenient esp. if there are a lot of entries and the user want to
> edit a specific one:
> !factoryconfig.gif!
> proposal: the author of the OSGi service with factory configuration should be
> able to provide a "nameHint" template to display a nice human-readable name,
> and display the pid+gui only as tooltip:
> !factoryconfig_namehint.gif!
> attached is a patch with draft implementation of this based on an optional
> service property {{webconsole.configurationFactory.nameHint}} which can be
> set on the service which can reference other property names with
> placeholders. the web console then displays this name hint with the
> configured values replaced.
> example (using SCR annotation):
> {code:java}
> @Property(name = "webconsole.configurationFactory.nameHint", value =
> "{serviceName}: {ribbonHosts}")
> {code}
> this will help on a lot of services, e.g. factory configurations for log
> configuration an others.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Updated] (FELIX-4710) Web Console: Display templated name hint for factory configuration entries
[
https://issues.apache.org/jira/browse/FELIX-4710?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Stefan Seifert updated FELIX-4710:
--
Description:
currently for each factory configuration entry in the web console only a very
cryptic name is displayed, consisting of the factory PID and a GUID. this is
very inconvenient esp. if there are a lot of entries and the user want to edit
a specific one:
!factoryconfig.gif!
proposal: the author of the OSGi service with factory configuration should be
able to provide a "nameHint" template to display a nice human-readable name,
and display the pid+gui only as tooltip:
!factoryconfig_namehint.gif!
attached is a patch with draft implementation of this based on an optional
service property {{webconsole.configurationFactory.nameHint}} which can be set
on the service which can reference other property names with placeholders. the
web console then displays this name hint with the configured values replaced.
this will help on a lot of services, e.g. factory configurations for log
configuration an others.
was:
currently for each factory configuration entry in the web console only a very
cryptic name is displayed, consisting of the factory PID and a GUID. this is
very inconvenient esp. if there are a lot of entries and the user want to edit
a specific one:
!factoryconfig_namehint.gif!
proposal: the author of the OSGi service with factory configuration should be
able to provide a "nameHint" template to display a nice human-readable name,
and display the pid+gui only as tooltip:
!factoryconfig.gif!
attached is a patch with draft implementation of this based on an optional
service property {{webconsole.configurationFactory.nameHint}} which can be set
on the service which can reference other property names with placeholders. the
web console then displays this name hint with the configured values replaced.
this will help on a lot of services, e.g. factory configurations for log
configuration an others.
> Web Console: Display templated name hint for factory configuration entries
> --
>
> Key: FELIX-4710
> URL: https://issues.apache.org/jira/browse/FELIX-4710
> Project: Felix
> Issue Type: Improvement
> Components: Web Console
>Affects Versions: webconsole-4.2.2
>Reporter: Stefan Seifert
> Attachments: 141126_FELIX-4710_webconsole_namehint.patch,
> factoryconfig.gif, factoryconfig_namehint.gif
>
>
> currently for each factory configuration entry in the web console only a very
> cryptic name is displayed, consisting of the factory PID and a GUID. this is
> very inconvenient esp. if there are a lot of entries and the user want to
> edit a specific one:
> !factoryconfig.gif!
> proposal: the author of the OSGi service with factory configuration should be
> able to provide a "nameHint" template to display a nice human-readable name,
> and display the pid+gui only as tooltip:
> !factoryconfig_namehint.gif!
> attached is a patch with draft implementation of this based on an optional
> service property {{webconsole.configurationFactory.nameHint}} which can be
> set on the service which can reference other property names with
> placeholders. the web console then displays this name hint with the
> configured values replaced.
> this will help on a lot of services, e.g. factory configurations for log
> configuration an others.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Updated] (FELIX-4710) Web Console: Display templated name hint for factory configuration entries
[
https://issues.apache.org/jira/browse/FELIX-4710?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Stefan Seifert updated FELIX-4710:
--
Attachment: factoryconfig_namehint.gif
factoryconfig.gif
141126_FELIX-4710_webconsole_namehint.patch
> Web Console: Display templated name hint for factory configuration entries
> --
>
> Key: FELIX-4710
> URL: https://issues.apache.org/jira/browse/FELIX-4710
> Project: Felix
> Issue Type: Improvement
> Components: Web Console
>Affects Versions: webconsole-4.2.2
>Reporter: Stefan Seifert
> Attachments: 141126_FELIX-4710_webconsole_namehint.patch,
> factoryconfig.gif, factoryconfig_namehint.gif
>
>
> currently for each factory configuration entry in the web console only a very
> cryptic name is displayed, consisting of the factory PID and a GUID. this is
> very inconvenient esp. if there are a lot of entries and the user want to
> edit a specific one:
> !factoryconfig_namehint.gif!
> proposal: the author of the OSGi service with factory configuration should be
> able to provide a "nameHint" template to display a nice human-readable name,
> and display the pid+gui only as tooltip:
> !factoryconfig.gif!
> attached is a patch with draft implementation of this based on an optional
> service property {{webconsole.configurationFactory.nameHint}} which can be
> set on the service which can reference other property names with
> placeholders. the web console then displays this name hint with the
> configured values replaced.
> this will help on a lot of services, e.g. factory configurations for log
> configuration an others.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
