[jira] [Commented] (FELIX-4825) The resolver may return wires to unresolved resources in some cases
[
https://issues.apache.org/jira/browse/FELIX-4825?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14350434#comment-14350434
]
Guillaume Nodet commented on FELIX-4825:
[~rickhall] The test case shows the problem. Let me explain it briefly...
The resource {{res2}} is the resource to resolve. With the current code, the
resolution leads to {{res5}} being wired to {{res6}} through an optional
requirement, while {{res6}} can not be resolved, because it has a mandatory
requirement on {{res3}}, which has a requirement with no matching capability.
The resource {{res6}} is also returned in the wiring map, but with no wires.
The problem seems to be related to optional requirements and cycles (there are
a lot of those in the small resource set). It may be possible to fix the
problem at the time the candidate is added to the localCandidateMap, but I
failed to see how to detect the problem (the resolution exception will be
thrown at a later time because of a cycle).
The resolver may return wires to unresolved resources in some cases
---
Key: FELIX-4825
URL: https://issues.apache.org/jira/browse/FELIX-4825
Project: Felix
Issue Type: Bug
Components: Resolver
Affects Versions: resolver-1.0.0
Reporter: Guillaume Nodet
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (FELIX-4825) The resolver may return wires to unresolved resources in some cases
[ https://issues.apache.org/jira/browse/FELIX-4825?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14350388#comment-14350388 ] Guillaume Nodet commented on FELIX-4825: I've pushed a branch and a possible fix for it at https://github.com/gnodet/felix/commit/9b188ac44a9ba8f0c46d38555f122672c79a38f1 [~ tjwatson] or [~ rick hall], or anyone else, can you review the patch before I apply it ? it seems to solve the problem but I'm not sure if it's the best way at all. The resolver may return wires to unresolved resources in some cases --- Key: FELIX-4825 URL: https://issues.apache.org/jira/browse/FELIX-4825 Project: Felix Issue Type: Bug Components: Resolver Affects Versions: resolver-1.0.0 Reporter: Guillaume Nodet -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (FELIX-4825) The resolver may return wires to unresolved resources in some cases
[ https://issues.apache.org/jira/browse/FELIX-4825?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14350394#comment-14350394 ] Richard S. Hall commented on FELIX-4825: A few more details describing the issue/situation would be welcome. The resolver may return wires to unresolved resources in some cases --- Key: FELIX-4825 URL: https://issues.apache.org/jira/browse/FELIX-4825 Project: Felix Issue Type: Bug Components: Resolver Affects Versions: resolver-1.0.0 Reporter: Guillaume Nodet -- This message was sent by Atlassian JIRA (v6.3.4#6332)
