[jira] [Commented] (FELIX-5196) Capabilities not matching because of case
[ https://issues.apache.org/jira/browse/FELIX-5196?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15160054#comment-15160054 ] Stephen Kahmann commented on FELIX-5196: PR made, but fix https://issues.apache.org/jira/browse/FELIX-5195 first > Capabilities not matching because of case > - > > Key: FELIX-5196 > URL: https://issues.apache.org/jira/browse/FELIX-5196 > Project: Felix > Issue Type: Bug > Components: Bundle Repository (OBR) >Affects Versions: bundlerepository-2.0.6 >Reporter: Stephen Kahmann > > RequirementImpl is not matching Capabilities because it is using a filter > that ignores case. The Filter lowercases the keys, but this is also not done > when trying to match them. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (FELIX-5196) Capabilities not matching because of case
[ https://issues.apache.org/jira/browse/FELIX-5196?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15173920#comment-15173920 ] Stephen Kahmann commented on FELIX-5196: Updated with recent bundlerepository commits and ready for review. > Capabilities not matching because of case > - > > Key: FELIX-5196 > URL: https://issues.apache.org/jira/browse/FELIX-5196 > Project: Felix > Issue Type: Bug > Components: Bundle Repository (OBR) >Affects Versions: bundlerepository-2.0.6 >Reporter: Stephen Kahmann > > RequirementImpl is not matching Capabilities because it is using a filter > that ignores case. The Filter lowercases the keys, but this is also not done > when trying to match them. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (FELIX-5196) Capabilities not matching because of case
[ https://issues.apache.org/jira/browse/FELIX-5196?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15173943#comment-15173943 ] Stephen Kahmann commented on FELIX-5196: PR: https://github.com/apache/felix/pull/54 > Capabilities not matching because of case > - > > Key: FELIX-5196 > URL: https://issues.apache.org/jira/browse/FELIX-5196 > Project: Felix > Issue Type: Bug > Components: Bundle Repository (OBR) >Affects Versions: bundlerepository-2.0.6 >Reporter: Stephen Kahmann > > RequirementImpl is not matching Capabilities because it is using a filter > that ignores case. The Filter lowercases the keys, but this is also not done > when trying to match them. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (FELIX-5196) Capabilities not matching because of case
[ https://issues.apache.org/jira/browse/FELIX-5196?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15179815#comment-15179815 ] Stephen Kahmann commented on FELIX-5196: Any thoughts on this fix? > Capabilities not matching because of case > - > > Key: FELIX-5196 > URL: https://issues.apache.org/jira/browse/FELIX-5196 > Project: Felix > Issue Type: Bug > Components: Bundle Repository (OBR) >Affects Versions: bundlerepository-2.0.6 >Reporter: Stephen Kahmann > > RequirementImpl is not matching Capabilities because it is using a filter > that ignores case. The Filter lowercases the keys, but this is also not done > when trying to match them. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (FELIX-5196) Capabilities not matching because of case
[ https://issues.apache.org/jira/browse/FELIX-5196?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15189404#comment-15189404 ] Stephen Kahmann commented on FELIX-5196: [~bosschaert] > Capabilities not matching because of case > - > > Key: FELIX-5196 > URL: https://issues.apache.org/jira/browse/FELIX-5196 > Project: Felix > Issue Type: Bug > Components: Bundle Repository (OBR) >Affects Versions: bundlerepository-2.0.6 >Reporter: Stephen Kahmann > > RequirementImpl is not matching Capabilities because it is using a filter > that ignores case. The Filter lowercases the keys, but this is also not done > when trying to match them. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (FELIX-5196) Capabilities not matching because of case
[ https://issues.apache.org/jira/browse/FELIX-5196?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15195831#comment-15195831 ] Stephen Kahmann commented on FELIX-5196: Sorry for the bother, but has anyone had a chance to look at this? > Capabilities not matching because of case > - > > Key: FELIX-5196 > URL: https://issues.apache.org/jira/browse/FELIX-5196 > Project: Felix > Issue Type: Bug > Components: Bundle Repository (OBR) >Affects Versions: bundlerepository-2.0.6 >Reporter: Stephen Kahmann > > RequirementImpl is not matching Capabilities because it is using a filter > that ignores case. The Filter lowercases the keys, but this is also not done > when trying to match them. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (FELIX-5196) Capabilities not matching because of case
[ https://issues.apache.org/jira/browse/FELIX-5196?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15245068#comment-15245068 ] Stephen Kahmann commented on FELIX-5196: This is pretty important as this breaks deployment with OSGi services. For example: {code} {code} Anyone able to take a look at this pull request? Thanks. > Capabilities not matching because of case > - > > Key: FELIX-5196 > URL: https://issues.apache.org/jira/browse/FELIX-5196 > Project: Felix > Issue Type: Bug > Components: Bundle Repository (OBR) >Affects Versions: bundlerepository-2.0.6 >Reporter: Stephen Kahmann > > RequirementImpl is not matching Capabilities because it is using a filter > that ignores case. The Filter lowercases the keys, but this is also not done > when trying to match them. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (FELIX-5196) Capabilities not matching because of case
[ https://issues.apache.org/jira/browse/FELIX-5196?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15246457#comment-15246457 ] Richard S. Hall commented on FELIX-5196: Perhaps I'm misunderstanding the issue, but if you want to ignore the case of the keys, why not just call m_filter.match() instead of m_filter.matchCase()? > Capabilities not matching because of case > - > > Key: FELIX-5196 > URL: https://issues.apache.org/jira/browse/FELIX-5196 > Project: Felix > Issue Type: Bug > Components: Bundle Repository (OBR) >Affects Versions: bundlerepository-2.0.6 >Reporter: Stephen Kahmann > > RequirementImpl is not matching Capabilities because it is using a filter > that ignores case. The Filter lowercases the keys, but this is also not done > when trying to match them. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (FELIX-5196) Capabilities not matching because of case
[ https://issues.apache.org/jira/browse/FELIX-5196?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15246575#comment-15246575 ] Stephen Kahmann commented on FELIX-5196: Looks like we could use match, but we'd have to convert the Map to a Dictionary. {code} Dictionary propertyDict = new Hashtable(capability.getPropertiesAsMap()); return m_name.equals(capability.getName()) && m_filter.match(propertyDict) && (m_filter.toString().contains("(mandatory:<*") || propertyDict.get("mandatory:") == null); {code} Thoughts? > Capabilities not matching because of case > - > > Key: FELIX-5196 > URL: https://issues.apache.org/jira/browse/FELIX-5196 > Project: Felix > Issue Type: Bug > Components: Bundle Repository (OBR) >Affects Versions: bundlerepository-2.0.6 >Reporter: Stephen Kahmann > > RequirementImpl is not matching Capabilities because it is using a filter > that ignores case. The Filter lowercases the keys, but this is also not done > when trying to match them. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (FELIX-5196) Capabilities not matching because of case
[ https://issues.apache.org/jira/browse/FELIX-5196?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15246714#comment-15246714 ] Richard S. Hall commented on FELIX-5196: I think utils already has a MapToDictionary class that won't make a copy. > Capabilities not matching because of case > - > > Key: FELIX-5196 > URL: https://issues.apache.org/jira/browse/FELIX-5196 > Project: Felix > Issue Type: Bug > Components: Bundle Repository (OBR) >Affects Versions: bundlerepository-2.0.6 >Reporter: Stephen Kahmann > > RequirementImpl is not matching Capabilities because it is using a filter > that ignores case. The Filter lowercases the keys, but this is also not done > when trying to match them. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (FELIX-5196) Capabilities not matching because of case
[ https://issues.apache.org/jira/browse/FELIX-5196?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15246745#comment-15246745 ] Stephen Kahmann commented on FELIX-5196: Good catch: {code} Dictionary propertyDict = new MapToDictionary(capability.getPropertiesAsMap()); return m_name.equals(capability.getName()) && m_filter.match(propertyDict) && (m_filter.toString().contains("(mandatory:<*") || propertyDict.get("mandatory:") == null); {code} > Capabilities not matching because of case > - > > Key: FELIX-5196 > URL: https://issues.apache.org/jira/browse/FELIX-5196 > Project: Felix > Issue Type: Bug > Components: Bundle Repository (OBR) >Affects Versions: bundlerepository-2.0.6 >Reporter: Stephen Kahmann > > RequirementImpl is not matching Capabilities because it is using a filter > that ignores case. The Filter lowercases the keys, but this is also not done > when trying to match them. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (FELIX-5196) Capabilities not matching because of case
[ https://issues.apache.org/jira/browse/FELIX-5196?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15246750#comment-15246750 ] Richard S. Hall commented on FELIX-5196: I admit that I haven't dug into this too deeply, but that seems reasonable to me. > Capabilities not matching because of case > - > > Key: FELIX-5196 > URL: https://issues.apache.org/jira/browse/FELIX-5196 > Project: Felix > Issue Type: Bug > Components: Bundle Repository (OBR) >Affects Versions: bundlerepository-2.0.6 >Reporter: Stephen Kahmann > > RequirementImpl is not matching Capabilities because it is using a filter > that ignores case. The Filter lowercases the keys, but this is also not done > when trying to match them. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (FELIX-5196) Capabilities not matching because of case
[ https://issues.apache.org/jira/browse/FELIX-5196?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15246754#comment-15246754 ] Stephen Kahmann commented on FELIX-5196: [~rickhall] Thank you for your quick responses! I've pushed the changes to the PR. > Capabilities not matching because of case > - > > Key: FELIX-5196 > URL: https://issues.apache.org/jira/browse/FELIX-5196 > Project: Felix > Issue Type: Bug > Components: Bundle Repository (OBR) >Affects Versions: bundlerepository-2.0.6 >Reporter: Stephen Kahmann > > RequirementImpl is not matching Capabilities because it is using a filter > that ignores case. The Filter lowercases the keys, but this is also not done > when trying to match them. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (FELIX-5196) Capabilities not matching because of case
[ https://issues.apache.org/jira/browse/FELIX-5196?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15247928#comment-15247928 ] ASF GitHub Bot commented on FELIX-5196: --- Github user skahmann closed the pull request at: https://github.com/apache/felix/pull/54 > Capabilities not matching because of case > - > > Key: FELIX-5196 > URL: https://issues.apache.org/jira/browse/FELIX-5196 > Project: Felix > Issue Type: Bug > Components: Bundle Repository (OBR) >Affects Versions: bundlerepository-2.0.6 >Reporter: Stephen Kahmann >Assignee: Richard S. Hall > Fix For: bundlerepository-2.0.10 > > > RequirementImpl is not matching Capabilities because it is using a filter > that ignores case. The Filter lowercases the keys, but this is also not done > when trying to match them. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (FELIX-5196) Capabilities not matching because of case
[ https://issues.apache.org/jira/browse/FELIX-5196?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15247929#comment-15247929 ] Stephen Kahmann commented on FELIX-5196: Thanks! > Capabilities not matching because of case > - > > Key: FELIX-5196 > URL: https://issues.apache.org/jira/browse/FELIX-5196 > Project: Felix > Issue Type: Bug > Components: Bundle Repository (OBR) >Affects Versions: bundlerepository-2.0.6 >Reporter: Stephen Kahmann >Assignee: Richard S. Hall > Fix For: bundlerepository-2.0.10 > > > RequirementImpl is not matching Capabilities because it is using a filter > that ignores case. The Filter lowercases the keys, but this is also not done > when trying to match them. -- This message was sent by Atlassian JIRA (v6.3.4#6332)