[jira] [Commented] (FELIX-5505) ConfigSpiOSGi may miss out on registering some LoginModuleFactory due to race condition

2017-01-20 Thread Carsten Ziegeler (JIRA) 

[ 
https://issues.apache.org/jira/browse/FELIX-5505?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15831523#comment-15831523
 ] 

Carsten Ziegeler commented on FELIX-5505:
-

[~chetanm] Patch looks good to - it seems ConfigSpiOSGi is never unregistered, 
not sure if that should be added (but it was never unregistered before this 
patch either)

> ConfigSpiOSGi may miss out on registering some LoginModuleFactory due to race 
> condition
> ---
>
> Key: FELIX-5505
> URL: https://issues.apache.org/jira/browse/FELIX-5505
> Project: Felix
>  Issue Type: Bug
>  Components: JAAS
>Reporter: Chetan Mehrotra
>Assignee: Chetan Mehrotra
>Priority: Critical
> Fix For: jaas-1.0.0
>
> Attachments: FELIX-5505-v1.patch
>
>
> {{ConfigSpiOsgi}} currently looks for {{LoginModuleFactory}} and upon 
> registration of any factory it recreates its {{Realm}} state. 
> This logic has a race condition where concurrent addition of 
> {{LoginModuleFactory}} may lead to some of them getting missed from getting 
> registered in the Realm



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (FELIX-5505) ConfigSpiOSGi may miss out on registering some LoginModuleFactory due to race condition

2017-01-20 Thread Chetan Mehrotra (JIRA) 

[ 
https://issues.apache.org/jira/browse/FELIX-5505?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15831462#comment-15831462
 ] 

Chetan Mehrotra commented on FELIX-5505:


Added ignored test with 1779592

> ConfigSpiOSGi may miss out on registering some LoginModuleFactory due to race 
> condition
> ---
>
> Key: FELIX-5505
> URL: https://issues.apache.org/jira/browse/FELIX-5505
> Project: Felix
>  Issue Type: Bug
>  Components: JAAS
>Reporter: Chetan Mehrotra
>Assignee: Chetan Mehrotra
>Priority: Critical
> Fix For: jaas-1.0.0
>
>
> {{ConfigSpiOsgi}} currently looks for {{LoginModuleFactory}} and upon 
> registration of any factory it recreates its {{Realm}} state. 
> This logic has a race condition where concurrent addition of 
> {{LoginModuleFactory}} may lead to some of them getting missed from getting 
> registered in the Realm



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)