[jira] [Commented] (FELIX-5641) Add getRepository() to Resource

2017-06-01 Thread Jens Offenbach (JIRA) 

[ 
https://issues.apache.org/jira/browse/FELIX-5641?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16032512#comment-16032512
 ] 

Jens Offenbach commented on FELIX-5641:
---

I also do not like the fact that the Resource API gets extended. Has anybody a 
better idea? The only way that is possible right now, is to iterate over all 
repositories and its provided resources to find the one that contains the 
corresponding resource. That is really slow and the mostly inefficient way I 
can think of.

> Add getRepository() to Resource
> ---
>
> Key: FELIX-5641
> URL: https://issues.apache.org/jira/browse/FELIX-5641
> Project: Felix
>  Issue Type: Bug
>  Components: Bundle Repository (OBR)
>Reporter: Jens Offenbach
>
> The method {{RepositoryAdmin#discoverResources}} returns a list of filtered 
> resources, but it is currently not efficiently possible to get the 
> corresponding repository for a resource. The information is available in 
> {{ResourceImpl}}, but not accessible through the API.
> Is it possible to add this?



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Commented] (FELIX-5641) Add getRepository() to Resource

2017-05-31 Thread Jens Offenbach (JIRA) 

[ 
https://issues.apache.org/jira/browse/FELIX-5641?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16032496#comment-16032496
 ] 

Jens Offenbach commented on FELIX-5641:
---

Thank you very much for your quick response.

The pull request has been updated and now contains the proposed version of the 
API-package export statement.

Isn't it also advisable to increase the major version fo the OBR implementation 
to {{2.1.0-SNAPSHOT}}?

> Add getRepository() to Resource
> ---
>
> Key: FELIX-5641
> URL: https://issues.apache.org/jira/browse/FELIX-5641
> Project: Felix
>  Issue Type: Bug
>  Components: Bundle Repository (OBR)
>Reporter: Jens Offenbach
>
> The method {{RepositoryAdmin#discoverResources}} returns a list of filtered 
> resources, but it is currently not efficiently possible to get the 
> corresponding repository for a resource. The information is available in 
> {{ResourceImpl}}, but not accessible through the API.
> Is it possible to add this?



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Commented] (FELIX-5641) Add getRepository() to Resource

2017-05-31 Thread David Bosschaert (JIRA) 

[ 
https://issues.apache.org/jira/browse/FELIX-5641?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16031518#comment-16031518
 ] 

David Bosschaert commented on FELIX-5641:
-

The pull request contains a change to exported API. I think we can assume that 
the Resource is a provider type here - I don't think users ever need to 
implement this resource. 
Therefore the pull request should be updated to include an update of the 
Export-Package definition to:
{code}org.apache.felix.bundlerepository;version="2.2"
{code}

Does anyone see an issue with this?

Note that the https://osgi.org/javadoc/r6/core/org/osgi/resource/Resource.html 
(which is a different resource) is a consumer type - any API changes to a 
consumer type require a major version update.

> Add getRepository() to Resource
> ---
>
> Key: FELIX-5641
> URL: https://issues.apache.org/jira/browse/FELIX-5641
> Project: Felix
>  Issue Type: Bug
>  Components: Bundle Repository (OBR)
>Reporter: Jens Offenbach
>
> The method {{RepositoryAdmin#discoverResources}} returns a list of filtered 
> resources, but it is currently not efficiently possible to get the 
> corresponding repository for a resource. The information is available in 
> {{ResourceImpl}}, but not accessible through the API.
> Is it possible to add this?



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)