[jira] [Commented] (FELIX-5863) Config Admin doesn't report Number format exception
[
https://issues.apache.org/jira/browse/FELIX-5863?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16509369#comment-16509369
]
Carsten Ziegeler commented on FELIX-5863:
-
I was able to find that code based on your classname. Please in the future post
the full info including package name etc. This makes it easier to understand
the problem.
So you're talking about the WebConsole, not config admin - I agree that user
feedback would be nice
> Config Admin doesn't report Number format exception
> ---
>
> Key: FELIX-5863
> URL: https://issues.apache.org/jira/browse/FELIX-5863
> Project: Felix
> Issue Type: Bug
> Components: Web Console
>Affects Versions: webconsole-4.3.4
>Reporter: Alain Picard
>Priority: Minor
>
> Configured attribute with numberic types (integer or long) and it let the
> user enter non-numeric value and never raises any error or message.
>
> Seems that code just ignores it:
> {code:java}
> try
> {
> props.put( propName, MetaTypeSupport.toType( attributeType, prop ) );
> }
> catch ( NumberFormatException nfe )
> {
>// don't care
> }
> {code}
> This obviously is not very informative.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (FELIX-5863) Config Admin doesn't report Number format exception
[
https://issues.apache.org/jira/browse/FELIX-5863?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16509354#comment-16509354
]
Alain Picard commented on FELIX-5863:
-
This was located in ConfigAdminSupport#applyConfiguration.
In regards to not validating against meta type, IMHO that would be a huge
shortcoming. It doesn't need to be fancy but some user feedback is needed.
> Config Admin doesn't report Number format exception
> ---
>
> Key: FELIX-5863
> URL: https://issues.apache.org/jira/browse/FELIX-5863
> Project: Felix
> Issue Type: Bug
> Components: Configuration Admin
>Affects Versions: configadmin-1.9.2
>Reporter: Alain Picard
>Priority: Minor
>
> Configured attribute with numberic types (integer or long) and it let the
> user enter non-numeric value and never raises any error or message.
>
> Seems that code just ignores it:
> {code:java}
> try
> {
> props.put( propName, MetaTypeSupport.toType( attributeType, prop ) );
> }
> catch ( NumberFormatException nfe )
> {
>// don't care
> }
> {code}
> This obviously is not very informative.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (FELIX-5863) Config Admin doesn't report Number format exception
[
https://issues.apache.org/jira/browse/FELIX-5863?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16509282#comment-16509282
]
Carsten Ziegeler commented on FELIX-5863:
-
[~alpic80] It would be great to get some more context, where did you find the
above code snippet, etc.?
In general, config admin is not validating configurations against meta type,
that's out of the scope of what config admin does.
> Config Admin doesn't report Number format exception
> ---
>
> Key: FELIX-5863
> URL: https://issues.apache.org/jira/browse/FELIX-5863
> Project: Felix
> Issue Type: Bug
> Components: Configuration Admin
>Affects Versions: configadmin-1.9.2
>Reporter: Alain Picard
>Priority: Minor
>
> Configured attribute with numberic types (integer or long) and it let the
> user enter non-numeric value and never raises any error or message.
>
> Seems that code just ignores it:
> {code:java}
> try
> {
> props.put( propName, MetaTypeSupport.toType( attributeType, prop ) );
> }
> catch ( NumberFormatException nfe )
> {
>// don't care
> }
> {code}
> This obviously is not very informative.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
