[jira] [Updated] (FELIX-3973) Exclusion from {local-packages} doesn't work anymore
[ https://issues.apache.org/jira/browse/FELIX-3973?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Stuart McCulloch updated FELIX-3973: Labels: patch (was: ) Exclusion from {local-packages} doesn't work anymore Key: FELIX-3973 URL: https://issues.apache.org/jira/browse/FELIX-3973 Project: Felix Issue Type: Bug Components: Maven Bundle Plugin Environment: bnd 2.0.0.x Reporter: Tuomas Kiviaho Labels: patch Fix For: maven-bundle-plugin-2.4.0 Attachments: FELIX-3973.diff I've been using Export-Package: !org.apache.jsp.*, {local-packages} to exclude jspc compilers output, but with BND 2.0.0 this stopped working completely (although until now I was getting a bunch of warnings). BND currently gives a second chance to non matching packages. This feature will rended !org.apache.jsp.* useless since {local-packages} is expanded to clause that contains org.apache.jsp prefixed packages. A fix would be to pre-filter the {local-packages} against Export/Private-Package clauses -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (FELIX-3973) Exclusion from {local-packages} doesn't work anymore
[ https://issues.apache.org/jira/browse/FELIX-3973?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Stuart McCulloch updated FELIX-3973: Fix Version/s: maven-bundle-plugin-2.4.0 Exclusion from {local-packages} doesn't work anymore Key: FELIX-3973 URL: https://issues.apache.org/jira/browse/FELIX-3973 Project: Felix Issue Type: Bug Components: Maven Bundle Plugin Environment: bnd 2.0.0.x Reporter: Tuomas Kiviaho Fix For: maven-bundle-plugin-2.4.0 Attachments: FELIX-3973.diff I've been using Export-Package: !org.apache.jsp.*, {local-packages} to exclude jspc compilers output, but with BND 2.0.0 this stopped working completely (although until now I was getting a bunch of warnings). BND currently gives a second chance to non matching packages. This feature will rended !org.apache.jsp.* useless since {local-packages} is expanded to clause that contains org.apache.jsp prefixed packages. A fix would be to pre-filter the {local-packages} against Export/Private-Package clauses -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (FELIX-3973) Exclusion from {local-packages} doesn't work anymore
[ https://issues.apache.org/jira/browse/FELIX-3973?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Tuomas Kiviaho updated FELIX-3973: -- Attachment: (was: FELIX-3973.diff) Exclusion from {local-packages} doesn't work anymore Key: FELIX-3973 URL: https://issues.apache.org/jira/browse/FELIX-3973 Project: Felix Issue Type: Bug Components: Maven Bundle Plugin Environment: bnd 2.0.0.x Reporter: Tuomas Kiviaho Attachments: FELIX-3973.diff I've been using Export-Package: !org.apache.jsp.*, {local-packages} to exclude jspc compilers output, but with BND 2.0.0 this stopped working completely (although until now I was getting a bunch of warnings). BND currently gives a second chance to non matching packages. This feature will rended !org.apache.jsp.* useless since {local-packages} is expanded to clause that contains org.apache.jsp prefixed packages. A fix would be to pre-filter the {local-packages} against Export/Private-Package clauses -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (FELIX-3973) Exclusion from {local-packages} doesn't work anymore
[ https://issues.apache.org/jira/browse/FELIX-3973?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Tuomas Kiviaho updated FELIX-3973: -- Attachment: FELIX-3973.diff Fixed the diff a bit yet again. Why didn't I just write a test in the first place Exclusion from {local-packages} doesn't work anymore Key: FELIX-3973 URL: https://issues.apache.org/jira/browse/FELIX-3973 Project: Felix Issue Type: Bug Components: Maven Bundle Plugin Environment: bnd 2.0.0.x Reporter: Tuomas Kiviaho Attachments: FELIX-3973.diff I've been using Export-Package: !org.apache.jsp.*, {local-packages} to exclude jspc compilers output, but with BND 2.0.0 this stopped working completely (although until now I was getting a bunch of warnings). BND currently gives a second chance to non matching packages. This feature will rended !org.apache.jsp.* useless since {local-packages} is expanded to clause that contains org.apache.jsp prefixed packages. A fix would be to pre-filter the {local-packages} against Export/Private-Package clauses -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (FELIX-3973) Exclusion from {local-packages} doesn't work anymore
[ https://issues.apache.org/jira/browse/FELIX-3973?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Tuomas Kiviaho updated FELIX-3973: -- Attachment: (was: FELIX-3973.diff) Exclusion from {local-packages} doesn't work anymore Key: FELIX-3973 URL: https://issues.apache.org/jira/browse/FELIX-3973 Project: Felix Issue Type: Bug Components: Maven Bundle Plugin Environment: bnd 2.0.0.x Reporter: Tuomas Kiviaho I've been using Export-Package: !org.apache.jsp.*, {local-packages} to exclude jspc compilers output, but with BND 2.0.0 this stopped working completely (although until now I was getting a bunch of warnings). BND currently gives a second chance to non matching packages. This feature will rended !org.apache.jsp.* useless since {local-packages} is expanded to clause that contains org.apache.jsp prefixed packages. A fix would be to pre-filter the {local-packages} against Export/Private-Package clauses -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (FELIX-3973) Exclusion from {local-packages} doesn't work anymore
[ https://issues.apache.org/jira/browse/FELIX-3973?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Tuomas Kiviaho updated FELIX-3973: -- Attachment: FELIX-3973.diff Reattaching once more. I reverted unnecessary modifications from the code while fixing one bug that I accidentally introduced. Sorry about the inconvenient GIT diff format. Key of this patch is to retrieve properties without waking up BND macros at this point. I also use BNDs PackageRef instead of direct string manipulation to ensure that delimiter is compatible with BND macros and list notation (, instead of ;). I'll repatch the FELIX-3381 also so that macros can be allied to sources and resources PS. I don't recollect reading a documentation about automatic split package which I think is great considering that plugin takes care of classpath already. For some reason it was only applied to the last package which I don't believe being intentional. Exclusion from {local-packages} doesn't work anymore Key: FELIX-3973 URL: https://issues.apache.org/jira/browse/FELIX-3973 Project: Felix Issue Type: Bug Components: Maven Bundle Plugin Environment: bnd 2.0.0.x Reporter: Tuomas Kiviaho Attachments: FELIX-3973.diff I've been using Export-Package: !org.apache.jsp.*, {local-packages} to exclude jspc compilers output, but with BND 2.0.0 this stopped working completely (although until now I was getting a bunch of warnings). BND currently gives a second chance to non matching packages. This feature will rended !org.apache.jsp.* useless since {local-packages} is expanded to clause that contains org.apache.jsp prefixed packages. A fix would be to pre-filter the {local-packages} against Export/Private-Package clauses -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (FELIX-3973) Exclusion from {local-packages} doesn't work anymore
[ https://issues.apache.org/jira/browse/FELIX-3973?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Tuomas Kiviaho updated FELIX-3973: -- Attachment: FELIX-3973.diff Here's the patch again in such form that doesn't use BND internals via reflection but instead BND postpones macro evaluation after {local-packages} has been replaced. Now I can use ${filterout;{local-packages};org\\.apache\\.jsp.*} macro to solve my problem Exclusion from {local-packages} doesn't work anymore Key: FELIX-3973 URL: https://issues.apache.org/jira/browse/FELIX-3973 Project: Felix Issue Type: Bug Components: Maven Bundle Plugin Environment: bnd 2.0.0.x Reporter: Tuomas Kiviaho Attachments: FELIX-3973.diff I've been using Export-Package: !org.apache.jsp.*, {local-packages} to exclude jspc compilers output, but with BND 2.0.0 this stopped working completely (although until now I was getting a bunch of warnings). BND currently gives a second chance to non matching packages. This feature will rended !org.apache.jsp.* useless since {local-packages} is expanded to clause that contains org.apache.jsp prefixed packages. A fix would be to pre-filter the {local-packages} against Export/Private-Package clauses -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (FELIX-3973) Exclusion from {local-packages} doesn't work anymore
[ https://issues.apache.org/jira/browse/FELIX-3973?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Tuomas Kiviaho updated FELIX-3973: -- Attachment: (was: FELIX-3973.diff) Exclusion from {local-packages} doesn't work anymore Key: FELIX-3973 URL: https://issues.apache.org/jira/browse/FELIX-3973 Project: Felix Issue Type: Bug Components: Maven Bundle Plugin Environment: bnd 2.0.0.x Reporter: Tuomas Kiviaho I've been using Export-Package: !org.apache.jsp.*, {local-packages} to exclude jspc compilers output, but with BND 2.0.0 this stopped working completely (although until now I was getting a bunch of warnings). BND currently gives a second chance to non matching packages. This feature will rended !org.apache.jsp.* useless since {local-packages} is expanded to clause that contains org.apache.jsp prefixed packages. A fix would be to pre-filter the {local-packages} against Export/Private-Package clauses -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (FELIX-3973) Exclusion from {local-packages} doesn't work anymore
[ https://issues.apache.org/jira/browse/FELIX-3973?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Tuomas Kiviaho updated FELIX-3973: -- Attachment: FELIX-3973.diff Here's a patch that fits everything to addLocalPackages by using functionality provided by BND itself. Downsize is that there's still a bit of reflection involved due to https://github.com/bndtools/bnd/issues/319 Exclusion from {local-packages} doesn't work anymore Key: FELIX-3973 URL: https://issues.apache.org/jira/browse/FELIX-3973 Project: Felix Issue Type: Bug Components: Maven Bundle Plugin Environment: bnd 2.0.0.x Reporter: Tuomas Kiviaho Attachments: FELIX-3973.diff I've been using Export-Package: !org.apache.jsp.*, {local-packages} to exclude jspc compilers output, but with BND 2.0.0 this stopped working completely (although until now I was getting a bunch of warnings). BND currently gives a second chance to non matching packages. This feature will rended !org.apache.jsp.* useless since {local-packages} is expanded to clause that contains org.apache.jsp prefixed packages. A fix would be to pre-filter the {local-packages} against Export/Private-Package clauses -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira