[jira] Commented: (FELIX-1704) Support for port as service properties
[ https://issues.apache.org/jira/browse/FELIX-1704?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12762345#action_12762345 ] Richard S. Hall commented on FELIX-1704: is the svnprop portion really necessary? Support for port as service properties -- Key: FELIX-1704 URL: https://issues.apache.org/jira/browse/FELIX-1704 Project: Felix Issue Type: Improvement Components: HTTP Service Affects Versions: http-2.0.2 Reporter: Sten Roger Sandvik Assignee: Sten Roger Sandvik Fix For: http-2.0.4 Support assigned port in Jetty as service property. Both secure and non secure. Use the same logic as in old Jetty http service 1.0.1. * org.apache.felix.http.svcprop.port * org.apache.felix.http.svcprop.port.secure -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Commented: (FELIX-1704) Support for port as service properties
[ https://issues.apache.org/jira/browse/FELIX-1704?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12762350#action_12762350 ] Sten Roger Sandvik commented on FELIX-1704: --- Version 1.0.1 (and 1.0.0) has two properties to be able to set which properties should be exported. This has default values: org.apache.felix.http.svcprop.port = org.osgi.service.http.port org.apache.felix.http.svcprop.port.secure = org.osgi.service.http.port.secure This is probably not necessary. Maybe it's better to just hardcode what properties are exported with the service so it's a well known name. Example: org.osgi.service.http.port = 8080 org.osgi.service.http.port.secure = 4040 Support for port as service properties -- Key: FELIX-1704 URL: https://issues.apache.org/jira/browse/FELIX-1704 Project: Felix Issue Type: Improvement Components: HTTP Service Affects Versions: http-2.0.2 Reporter: Sten Roger Sandvik Assignee: Sten Roger Sandvik Fix For: http-2.0.4 Support assigned port in Jetty as service property. Both secure and non secure. Use the same logic as in old Jetty http service 1.0.1. * org.apache.felix.http.svcprop.port * org.apache.felix.http.svcprop.port.secure -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Commented: (FELIX-1704) Support for port as service properties
[ https://issues.apache.org/jira/browse/FELIX-1704?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12762368#action_12762368 ] Richard S. Hall commented on FELIX-1704: Why aren't the service properties just the same name as the configuration properties? Support for port as service properties -- Key: FELIX-1704 URL: https://issues.apache.org/jira/browse/FELIX-1704 Project: Felix Issue Type: Improvement Components: HTTP Service Affects Versions: http-2.0.2 Reporter: Sten Roger Sandvik Assignee: Sten Roger Sandvik Fix For: http-2.0.4 Support assigned port in Jetty as service property. Both secure and non secure. Use the same logic as in old Jetty http service 1.0.1. * org.apache.felix.http.svcprop.port * org.apache.felix.http.svcprop.port.secure -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Commented: (FELIX-1704) Support for port as service properties
[ https://issues.apache.org/jira/browse/FELIX-1704?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12762373#action_12762373 ] Sten Roger Sandvik commented on FELIX-1704: --- Yes, it should reflect the confguration properties. I do not know why it's configured. Let's just reflect the configuration properties for now if no one has any good reasons for doing otherwise. So, the port properties should then be: org.osgi.service.http.port, org.osgi.service.http.port.secure. Support for port as service properties -- Key: FELIX-1704 URL: https://issues.apache.org/jira/browse/FELIX-1704 Project: Felix Issue Type: Improvement Components: HTTP Service Affects Versions: http-2.0.2 Reporter: Sten Roger Sandvik Assignee: Sten Roger Sandvik Fix For: http-2.0.4 Support assigned port in Jetty as service property. Both secure and non secure. Use the same logic as in old Jetty http service 1.0.1. * org.apache.felix.http.svcprop.port * org.apache.felix.http.svcprop.port.secure -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Commented: (FELIX-1704) Support for port as service properties
[ https://issues.apache.org/jira/browse/FELIX-1704?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12762384#action_12762384 ] Richard S. Hall commented on FELIX-1704: Yeah, there probably was some reason I am missing, but I agree, let's go with this for now until someone complains. I guess it makes sense to me to use the standard property names, since they are the official properties used to configure the port and the service properties just reflect that configuration, right? Support for port as service properties -- Key: FELIX-1704 URL: https://issues.apache.org/jira/browse/FELIX-1704 Project: Felix Issue Type: Improvement Components: HTTP Service Affects Versions: http-2.0.2 Reporter: Sten Roger Sandvik Assignee: Sten Roger Sandvik Fix For: http-2.0.4 Support assigned port in Jetty as service property. Both secure and non secure. Use the same logic as in old Jetty http service 1.0.1. * org.apache.felix.http.svcprop.port * org.apache.felix.http.svcprop.port.secure -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
