[jira] Commented: (FELIX-1956) Collect duplicate reusable code in WebConsoleUtil

2010-01-13 Thread Felix Meschberger (JIRA)

[ 
https://issues.apache.org/jira/browse/FELIX-1956?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12799711#action_12799711
 ] 

Felix Meschberger commented on FELIX-1956:
--

This patch cannot be applied because the WebConsoleUtil class is missing. Can 
you please attach this class to this issue ? Thanks.

 Collect duplicate  reusable code in WebConsoleUtil
 ---

 Key: FELIX-1956
 URL: https://issues.apache.org/jira/browse/FELIX-1956
 Project: Felix
  Issue Type: Improvement
  Components: Web Console
Affects Versions: webconsole-2.0.4
Reporter: Valentin Valchev
Assignee: Felix Meschberger
Priority: Trivial
 Fix For: webconsole-2.0.6

 Attachments: eclipse-warnings-duplicate-code.patch


 I've looked at the Web Console code and found some common methods that are 
 used in the plugins. These methods can be reused by third party plugins and 
 it would be nice, if they are exported as new class WebConsoleUtil.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.



[jira] Commented: (FELIX-1956) Collect duplicate reusable code in WebConsoleUtil

2009-12-21 Thread Felix Meschberger (JIRA)

[ 
https://issues.apache.org/jira/browse/FELIX-1956?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12793251#action_12793251
 ] 

Felix Meschberger commented on FELIX-1956:
--

Thanks for reporting the issue and proposing a patch. At first read, this makes 
perfect sense.

 Collect duplicate  reusable code in WebConsoleUtil
 ---

 Key: FELIX-1956
 URL: https://issues.apache.org/jira/browse/FELIX-1956
 Project: Felix
  Issue Type: Improvement
  Components: Web Console
Affects Versions: webconsole-2.0.4
Reporter: Valentin Valchev
Assignee: Felix Meschberger
Priority: Trivial
 Fix For: webconsole-2.0.6

 Attachments: eclipse-warnings-duplicate-code.patch


 I've looked at the Web Console code and found some common methods that are 
 used in the plugins. These methods can be reused by third party plugins and 
 it would be nice, if they are exported as new class WebConsoleUtil.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.