[jira] Commented: (FELIX-909) White spaces in the Import-Bundle of theManifest file
[ https://issues.apache.org/jira/browse/FELIX-909?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12668819#action_12668819 ] Stuart McCulloch commented on FELIX-909: Yep - btw, as a workaround until they fix their parser you could either do this: com.bla.api,com.bla.impl as whitespace is removed from the start and end (but never from the middle) ... or put your Import-Bundle list in another properties file and include it like so: <_include>some.more.properties where the "some.more.properties" file contains: Import-Bundle: com.bla.api,com.bla.impl but hopefully the dmServer parser will be fixed soon (though I'm surprised it doesn't handle whitespace) > White spaces in the Import-Bundle of theManifest file > - > > Key: FELIX-909 > URL: https://issues.apache.org/jira/browse/FELIX-909 > Project: Felix > Issue Type: Bug > Components: Maven Bundle Plugin >Affects Versions: maven-bundle-plugin-1.4.3 >Reporter: Boris Burgstaller > Attachments: example.txt, patch.txt > > > We are using the Maven Bundle Plugin to generate our bundles and manifests. > We are using the Import-Bundle and we noticed that it does not remove the > white spaces coming from the xml if you format it like this: > > com.bla.api, > com.bla.impl > > We deploy some bundles on a springsource dm server, and if the manifest > contains whitespaces and newlines, it falis to parse the file. > could you please remove the white spaces for this property? -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Commented: (FELIX-909) White spaces in the Import-Bundle of theManifest file
[ https://issues.apache.org/jira/browse/FELIX-909?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12668785#action_12668785 ] Boris Burgstaller commented on FELIX-909: - Thanks for the comment, so i have to report this to the springsource guys, that they fix their Manifest Parser. > White spaces in the Import-Bundle of theManifest file > - > > Key: FELIX-909 > URL: https://issues.apache.org/jira/browse/FELIX-909 > Project: Felix > Issue Type: Bug > Components: Maven Bundle Plugin >Affects Versions: maven-bundle-plugin-1.4.3 >Reporter: Boris Burgstaller > Attachments: example.txt, patch.txt > > > We are using the Maven Bundle Plugin to generate our bundles and manifests. > We are using the Import-Bundle and we noticed that it does not remove the > white spaces coming from the xml if you format it like this: > > com.bla.api, > com.bla.impl > > We deploy some bundles on a springsource dm server, and if the manifest > contains whitespaces and newlines, it falis to parse the file. > could you please remove the white spaces for this property? -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Commented: (FELIX-909) White spaces in the Import-Bundle of theManifest file
[ https://issues.apache.org/jira/browse/FELIX-909?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12668783#action_12668783 ] Stuart McCulloch commented on FELIX-909: Yes, that's because Export-Package and Import-Package are OSGi properties that are calculated by Bnd itself based on the given instructions, whereas Import-Bundle is a non-standard property that Bnd knows nothing about and simply copies it across unchanged from the XML content (including whitespace contained inside the string). Because it doesn't know anything about the structure of Import-Bundle it cannot remove this whitespace - for all Bnd knows that whitespace might be important. But regardless of this point, even if I create a hand-crafted manifest with spaces in the Export-Package / Import-Package properties it is _still_ valid and can be parsed by OSGi frameworks. So whatever parser you're using to read the Import-Bundle property should be made more robust to handle whitespace - because otherwise you're going to hit the same problem when a customer uses a bundle with a hand-written manifest that has spaces inside Import-Bundle. > White spaces in the Import-Bundle of theManifest file > - > > Key: FELIX-909 > URL: https://issues.apache.org/jira/browse/FELIX-909 > Project: Felix > Issue Type: Bug > Components: Maven Bundle Plugin >Affects Versions: maven-bundle-plugin-1.4.3 >Reporter: Boris Burgstaller > Attachments: example.txt, patch.txt > > > We are using the Maven Bundle Plugin to generate our bundles and manifests. > We are using the Import-Bundle and we noticed that it does not remove the > white spaces coming from the xml if you format it like this: > > com.bla.api, > com.bla.impl > > We deploy some bundles on a springsource dm server, and if the manifest > contains whitespaces and newlines, it falis to parse the file. > could you please remove the white spaces for this property? -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Commented: (FELIX-909) White spaces in the Import-Bundle of theManifest file
[ https://issues.apache.org/jira/browse/FELIX-909?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12668781#action_12668781 ] Boris Burgstaller commented on FELIX-909: - an Example, in th pom you have com.bla.api, com.bla.impl com.bla2.api, com.bla2.impl in the manifes you get: Manifest-Version: 1.0 Export-Package: com.bla.api,com.bla.impl Built-By: bburgstaller Tool: Bnd-0.0.255 Bundle-Name: bla_api Created-By: Apache Maven Bundle Plugin Import-Bundle: com.bla2.api, com.bla2.impl Bundle-Version: 1.0.0.SNAPSHOT Build-Jdk: 1.6.0_05 Bnd-LastModified: 1233305399966 Bundle-ManifestVersion: 2 Import-Package: com.bla.api,com.bla.impl Bundle-SymbolicName: com.bla.bla > White spaces in the Import-Bundle of theManifest file > - > > Key: FELIX-909 > URL: https://issues.apache.org/jira/browse/FELIX-909 > Project: Felix > Issue Type: Bug > Components: Maven Bundle Plugin >Affects Versions: maven-bundle-plugin-1.4.3 >Reporter: Boris Burgstaller > Attachments: patch.txt > > > We are using the Maven Bundle Plugin to generate our bundles and manifests. > We are using the Import-Bundle and we noticed that it does not remove the > white spaces coming from the xml if you format it like this: > > com.bla.api, > com.bla.impl > > We deploy some bundles on a springsource dm server, and if the manifest > contains whitespaces and newlines, it falis to parse the file. > could you please remove the white spaces for this property? -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Commented: (FELIX-909) White spaces in the Import-Bundle of theManifest file
[ https://issues.apache.org/jira/browse/FELIX-909?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12668780#action_12668780 ] Boris Burgstaller commented on FELIX-909: - The thing is that the format of the Export-Package and Import-Package entries in the manifest are not the same as in the Import-Bundle. In the pom file they look similar, but they are not treated the same way during the generation of the Manifest > White spaces in the Import-Bundle of theManifest file > - > > Key: FELIX-909 > URL: https://issues.apache.org/jira/browse/FELIX-909 > Project: Felix > Issue Type: Bug > Components: Maven Bundle Plugin >Affects Versions: maven-bundle-plugin-1.4.3 >Reporter: Boris Burgstaller > Attachments: patch.txt > > > We are using the Maven Bundle Plugin to generate our bundles and manifests. > We are using the Import-Bundle and we noticed that it does not remove the > white spaces coming from the xml if you format it like this: > > com.bla.api, > com.bla.impl > > We deploy some bundles on a springsource dm server, and if the manifest > contains whitespaces and newlines, it falis to parse the file. > could you please remove the white spaces for this property? -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Commented: (FELIX-909) White spaces in the Import-Bundle of theManifest file
[ https://issues.apache.org/jira/browse/FELIX-909?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12668774#action_12668774 ] Stuart McCulloch commented on FELIX-909: Whitespace _is_ allowed in manifest properties: http://java.sun.com/j2se/1.3/docs/guide/jar/jar.html#Name-Value%20pairs%20and%20Sections Your patch would strip all formatting from descriptions and other such properties, which is completely wrong. BTW, I just tried a quick test with bundleplugin 1.4.3 and the (non-standard) metadata entry you mentioned: com.bla.api, com.bla.impl and while you will see whitespace between the 2 entries, the generated manifest is still valid and deploys correctly to an OSGi framework. Can you provide a sample testcase (ie. pom.xml, etc. that I can build and test) that clearly demonstrates the problem of an invalid manifest. Otherwise, it sounds more like you need to enhance your manifest parser to support whitespace > White spaces in the Import-Bundle of theManifest file > - > > Key: FELIX-909 > URL: https://issues.apache.org/jira/browse/FELIX-909 > Project: Felix > Issue Type: Bug > Components: Maven Bundle Plugin >Affects Versions: maven-bundle-plugin-1.4.3 >Reporter: Boris Burgstaller > Attachments: patch.txt > > > We are using the Maven Bundle Plugin to generate our bundles and manifests. > We are using the Import-Bundle and we noticed that it does not remove the > white spaces coming from the xml if you format it like this: > > com.bla.api, > com.bla.impl > > We deploy some bundles on a springsource dm server, and if the manifest > contains whitespaces and newlines, it falis to parse the file. > could you please remove the white spaces for this property? -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
