[jira] [Closed] (FELIX-5083) Set webconsole.configurationFactory.nameHint for JAAS configurations

2015-12-02 Thread Chetan Mehrotra (JIRA)

 [ 
https://issues.apache.org/jira/browse/FELIX-5083?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Chetan Mehrotra closed FELIX-5083.
--

> Set webconsole.configurationFactory.nameHint for JAAS configurations
> 
>
> Key: FELIX-5083
> URL: https://issues.apache.org/jira/browse/FELIX-5083
> Project: Felix
>  Issue Type: Improvement
>  Components: JAAS
>Affects Versions: jaas-0.0.2
>Reporter: Robert Munteanu
>Assignee: Chetan Mehrotra
>Priority: Minor
> Fix For: jaas-0.0.4
>
> Attachments: FELIX-5083.patch, FELIX-5083.png
>
>
> When working with multiple JAAS configuration in the Felix Web Console it's 
> hard to distinguish them.
> Setting the {{webconsole.configurationFactory.nameHint}} property to a 
> reasonable default removes this problem.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Closed] (FELIX-5123) Script Console UI improvements

2015-12-02 Thread Chetan Mehrotra (JIRA)

 [ 
https://issues.apache.org/jira/browse/FELIX-5123?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Chetan Mehrotra closed FELIX-5123.
--

> Script Console UI improvements
> --
>
> Key: FELIX-5123
> URL: https://issues.apache.org/jira/browse/FELIX-5123
> Project: Felix
>  Issue Type: Improvement
>  Components: Script Console Plugin
>Affects Versions: script-console-1.0.0
>Reporter: Chetan Mehrotra
>Assignee: Chetan Mehrotra
>Priority: Minor
> Fix For: script-console-1.0.2
>
>
> Following improvements need to be done to script console UI
> # Remove timeout on executed command
> # Drop the Language button



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Closed] (FELIX-5122) Script console output cannot be copied

2015-12-02 Thread Chetan Mehrotra (JIRA)

 [ 
https://issues.apache.org/jira/browse/FELIX-5122?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Chetan Mehrotra closed FELIX-5122.
--

> Script console output cannot be copied
> --
>
> Key: FELIX-5122
> URL: https://issues.apache.org/jira/browse/FELIX-5122
> Project: Felix
>  Issue Type: Bug
>  Components: Script Console Plugin
>Affects Versions: script-console-1.0.0
>Reporter: Chetan Mehrotra
>Assignee: Chetan Mehrotra
> Fix For: script-console-1.0.2
>
>
> Script console output cannot be copied.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Closed] (FELIX-5121) Script console build failing on latest trunk

2015-12-02 Thread Chetan Mehrotra (JIRA)

 [ 
https://issues.apache.org/jira/browse/FELIX-5121?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Chetan Mehrotra closed FELIX-5121.
--

> Script console build failing on latest trunk
> 
>
> Key: FELIX-5121
> URL: https://issues.apache.org/jira/browse/FELIX-5121
> Project: Felix
>  Issue Type: Task
>  Components: Script Console Plugin
>Reporter: Chetan Mehrotra
>Assignee: Chetan Mehrotra
> Fix For: script-console-1.0.2
>
>
> Current trunk build is failing as exam-maven-plugin launch is not working 
> {noformat}
> [INFO] Failsafe report directory: 
> /home/chetanm/git/apache/felix/webconsole-plugins/script-console/target/failsafe-reports
> Error: Main method not found in class org.ops4j.pax.exam.spi.PaxExamRuntime, 
> please define the main method as:
>public static void main(String[] args)
> {noformat}
> Due to this the OSGi container is not launched



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Closed] (FELIX-5120) ScriptEngineManager not able to parse service file with comments at end of classname

2015-12-02 Thread Chetan Mehrotra (JIRA)

 [ 
https://issues.apache.org/jira/browse/FELIX-5120?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Chetan Mehrotra closed FELIX-5120.
--

> ScriptEngineManager not able to parse service file with comments at end of 
> classname
> 
>
> Key: FELIX-5120
> URL: https://issues.apache.org/jira/browse/FELIX-5120
> Project: Felix
>  Issue Type: Bug
>  Components: Script Console Plugin
>Affects Versions: script-console-1.0.0
>Reporter: Chetan Mehrotra
>Assignee: Chetan Mehrotra
>Priority: Minor
> Fix For: script-console-1.0.2
>
>
> A service file can also have a comment like below like
> {noformat}
> #script engines supported
> com.sun.script.javascript.RhinoScriptEngineFactory #javascript
> {noformat}
> Such a service file is not parsed properly and following exception is thrown
> {noformat}
> 2015-11-30 11:23:58.375 ERROR 23215 --- [ixDispatchQueue] 
> o.a.f.webconsole.plugins.scriptconsole   : Cannot register 
> ScriptEngineFactory com.sun.script.javascript.RhinoScriptEngineFactory 
> #javascript (java.lang.ClassNotFoundException: 
> com.sun.script.javascript.RhinoScriptEngineFactory #javascript)
> java.lang.ClassNotFoundException: 
> com.sun.script.javascript.RhinoScriptEngineFactory #javascript
> at java.net.URLClassLoader$1.run(URLClassLoader.java:366) 
> ~[na:1.7.0_55]
> at java.net.URLClassLoader$1.run(URLClassLoader.java:355) 
> ~[na:1.7.0_55]
> at java.security.AccessController.doPrivileged(Native Method) 
> ~[na:1.7.0_55]
> at java.net.URLClassLoader.findClass(URLClassLoader.java:354) 
> ~[na:1.7.0_55]
> at java.lang.ClassLoader.loadClass(ClassLoader.java:425) 
> ~[na:1.7.0_55]
> at java.lang.ClassLoader.loadClass(ClassLoader.java:358) 
> ~[na:1.7.0_55]
> at 
> org.apache.felix.connect.PojoSRBundle.loadClass(PojoSRBundle.java:451) 
> ~[org.apache.felix.connect-0.1.0.jar:na]
> at 
> org.apache.felix.webconsole.plugins.scriptconsole.internal.ScriptEngineManager.registerFactories(ScriptEngineManager.java:197)
>  [org.apache.felix.webconsole.plugins.scriptconsole-1.0.0.jar:na]
> at 
> org.apache.felix.webconsole.plugins.scriptconsole.internal.ScriptEngineManager.refreshScriptEngineManager(ScriptEngineManager.java:160)
>  [org.apache.felix.webconsole.plugins.scriptconsole-1.0.0.jar:na]
> at 
> org.apache.felix.webconsole.plugins.scriptconsole.internal.ScriptEngineManager.bundleChanged(ScriptEngineManager.java:111)
>  [org.apache.felix.webconsole.plugins.scriptconsole-1.0.0.jar:na]
> at 
> org.apache.felix.connect.felix.framework.util.EventDispatcher.invokeBundleListenerCallback(EventDispatcher.java:821)
>  [org.apache.felix.connect-0.1.0.jar:na]
> at 
> org.apache.felix.connect.felix.framework.util.EventDispatcher.fireEventImmediately(EventDispatcher.java:771)
>  [org.apache.felix.connect-0.1.0.jar:na]
> at 
> org.apache.felix.connect.felix.framework.util.EventDispatcher.run(EventDispatcher.java:993)
>  [org.apache.felix.connect-0.1.0.jar:na]
> at 
> org.apache.felix.connect.felix.framework.util.EventDispatcher.access$000(EventDispatcher.java:52)
>  [org.apache.felix.connect-0.1.0.jar:na]
> at 
> org.apache.felix.connect.felix.framework.util.EventDispatcher$1.run(EventDispatcher.java:94)
>  [org.apache.felix.connect-0.1.0.jar:na]
> at java.lang.Thread.run(Thread.java:745) [na:1.7.0_55]
> {noformat}



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Resolved] (FELIX-5121) Script console build failing on latest trunk

2015-11-30 Thread Chetan Mehrotra (JIRA)

 [ 
https://issues.apache.org/jira/browse/FELIX-5121?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Chetan Mehrotra resolved FELIX-5121.

Resolution: Fixed

Done in 1717198 

> Script console build failing on latest trunk
> 
>
> Key: FELIX-5121
> URL: https://issues.apache.org/jira/browse/FELIX-5121
> Project: Felix
>  Issue Type: Task
>  Components: Script Console Plugin
>Reporter: Chetan Mehrotra
>Assignee: Chetan Mehrotra
> Fix For: script-console-1.0.2
>
>
> Current trunk build is failing as exam-maven-plugin launch is not working 
> {noformat}
> [INFO] Failsafe report directory: 
> /home/chetanm/git/apache/felix/webconsole-plugins/script-console/target/failsafe-reports
> Error: Main method not found in class org.ops4j.pax.exam.spi.PaxExamRuntime, 
> please define the main method as:
>public static void main(String[] args)
> {noformat}
> Due to this the OSGi container is not launched



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Created] (FELIX-5122) Script console output cannot be copied

2015-11-30 Thread Chetan Mehrotra (JIRA)
Chetan Mehrotra created FELIX-5122:
--

 Summary: Script console output cannot be copied
 Key: FELIX-5122
 URL: https://issues.apache.org/jira/browse/FELIX-5122
 Project: Felix
  Issue Type: Bug
  Components: Script Console Plugin
Affects Versions: script-console-1.0.0
Reporter: Chetan Mehrotra
Assignee: Chetan Mehrotra
 Fix For: script-console-1.0.2


Script console output cannot be copied.





--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Resolved] (FELIX-5122) Script console output cannot be copied

2015-11-30 Thread Chetan Mehrotra (JIRA)

 [ 
https://issues.apache.org/jira/browse/FELIX-5122?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Chetan Mehrotra resolved FELIX-5122.

Resolution: Fixed

Done with 1717220

> Script console output cannot be copied
> --
>
> Key: FELIX-5122
> URL: https://issues.apache.org/jira/browse/FELIX-5122
> Project: Felix
>  Issue Type: Bug
>  Components: Script Console Plugin
>Affects Versions: script-console-1.0.0
>Reporter: Chetan Mehrotra
>Assignee: Chetan Mehrotra
> Fix For: script-console-1.0.2
>
>
> Script console output cannot be copied.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Resolved] (FELIX-3982) Allow usage of LoginModule present outside of OSGi space

2015-11-29 Thread Chetan Mehrotra (JIRA)

 [ 
https://issues.apache.org/jira/browse/FELIX-3982?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Chetan Mehrotra resolved FELIX-3982.

Resolution: Later

Resolving for later for now as not seen need for such a feature for long time

> Allow usage of LoginModule present outside of OSGi space
> 
>
> Key: FELIX-3982
> URL: https://issues.apache.org/jira/browse/FELIX-3982
> Project: Felix
>  Issue Type: Improvement
>  Components: JAAS
>Reporter: Chetan Mehrotra
>Assignee: Chetan Mehrotra
>Priority: Minor
>
> The Sun JDK ships many LoginModule [1] out of the box. It should be possible 
> to use them within the OSGi
> [1] http://docs.oracle.com/javase/6/docs/jre/api/security/jaas/spec/index.html



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Resolved] (FELIX-4827) Improve logging on LoginModule registration

2015-11-29 Thread Chetan Mehrotra (JIRA)

 [ 
https://issues.apache.org/jira/browse/FELIX-4827?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Chetan Mehrotra resolved FELIX-4827.

   Resolution: Fixed
Fix Version/s: jaas-0.0.4

Done in 1717186

> Improve logging on LoginModule registration
> ---
>
> Key: FELIX-4827
> URL: https://issues.apache.org/jira/browse/FELIX-4827
> Project: Felix
>  Issue Type: Bug
>  Components: JAAS
>Reporter: Alex Parvulescu
>Assignee: Chetan Mehrotra
>Priority: Minor
> Fix For: jaas-0.0.4
>
>
> There's a space missing in the log message when registering a new LoginModule 
> [0], currently the log looks like the following:
> {code}
> 22.02.2015 03:03:28.256 *INFO* [FelixStartLevel] org.apache.felix.jaas 
> Registering LoginModule class 
> [org.apache.jackrabbit.oak.security.authentication.token.TokenLoginModule] 
> from Bundleorg.apache.jackrabbit.oak-core [85]
> {code}
> _from Bundleorg.apache.jackrabbit.oak-core_ -> _from Bundle 
> org.apache.jackrabbit.oak-core_
> [0] 
> https://github.com/apache/felix/blob/33f093d4862955286c3a37b0b1a01153821c50f3/jaas/src/main/java/org/apache/felix/jaas/internal/BundleLoginModuleCreator.java#L151



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Resolved] (FELIX-4978) Enable name hint for JAAS Config entries

2015-11-29 Thread Chetan Mehrotra (JIRA)

 [ 
https://issues.apache.org/jira/browse/FELIX-4978?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Chetan Mehrotra resolved FELIX-4978.

Resolution: Duplicate

Resolving as duplicate for FELIX-5083 as that also has a patch provided

> Enable name hint for JAAS Config entries
> 
>
> Key: FELIX-4978
> URL: https://issues.apache.org/jira/browse/FELIX-4978
> Project: Felix
>  Issue Type: Improvement
>  Components: JAAS
>Reporter: Chetan Mehrotra
>Assignee: Chetan Mehrotra
>Priority: Minor
> Fix For: jaas-0.0.4
>
>
> the latest webconsole provides a feature to display name hints instead of 
> GUIDs for osgi factory configurations, which greatly enhances the usability 
> in the web console esp. when lots of factory configurations are defined 
> (FELIX-4710).
> for the JAAS we should define a name hint for the JAAS LoginModule Config



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Created] (FELIX-5120) ScriptEngineManager not able to parse service file with comments at end of classname

2015-11-29 Thread Chetan Mehrotra (JIRA)
Chetan Mehrotra created FELIX-5120:
--

 Summary: ScriptEngineManager not able to parse service file with 
comments at end of classname
 Key: FELIX-5120
 URL: https://issues.apache.org/jira/browse/FELIX-5120
 Project: Felix
  Issue Type: Bug
  Components: Script Console Plugin
Affects Versions: script-console-1.0.0
Reporter: Chetan Mehrotra
Assignee: Chetan Mehrotra
Priority: Minor
 Fix For: script-console-1.0.2


A service file can also have a comment like below like

{noformat}
#script engines supported

com.sun.script.javascript.RhinoScriptEngineFactory #javascript
{noformat}

Such a service file is not parsed properly and following exception is thrown
{noformat}
2015-11-30 11:23:58.375 ERROR 23215 --- [ixDispatchQueue] 
o.a.f.webconsole.plugins.scriptconsole   : Cannot register ScriptEngineFactory 
com.sun.script.javascript.RhinoScriptEngineFactory #javascript 
(java.lang.ClassNotFoundException: 
com.sun.script.javascript.RhinoScriptEngineFactory #javascript)

java.lang.ClassNotFoundException: 
com.sun.script.javascript.RhinoScriptEngineFactory #javascript
at java.net.URLClassLoader$1.run(URLClassLoader.java:366) ~[na:1.7.0_55]
at java.net.URLClassLoader$1.run(URLClassLoader.java:355) ~[na:1.7.0_55]
at java.security.AccessController.doPrivileged(Native Method) 
~[na:1.7.0_55]
at java.net.URLClassLoader.findClass(URLClassLoader.java:354) 
~[na:1.7.0_55]
at java.lang.ClassLoader.loadClass(ClassLoader.java:425) ~[na:1.7.0_55]
at java.lang.ClassLoader.loadClass(ClassLoader.java:358) ~[na:1.7.0_55]
at 
org.apache.felix.connect.PojoSRBundle.loadClass(PojoSRBundle.java:451) 
~[org.apache.felix.connect-0.1.0.jar:na]
at 
org.apache.felix.webconsole.plugins.scriptconsole.internal.ScriptEngineManager.registerFactories(ScriptEngineManager.java:197)
 [org.apache.felix.webconsole.plugins.scriptconsole-1.0.0.jar:na]
at 
org.apache.felix.webconsole.plugins.scriptconsole.internal.ScriptEngineManager.refreshScriptEngineManager(ScriptEngineManager.java:160)
 [org.apache.felix.webconsole.plugins.scriptconsole-1.0.0.jar:na]
at 
org.apache.felix.webconsole.plugins.scriptconsole.internal.ScriptEngineManager.bundleChanged(ScriptEngineManager.java:111)
 [org.apache.felix.webconsole.plugins.scriptconsole-1.0.0.jar:na]
at 
org.apache.felix.connect.felix.framework.util.EventDispatcher.invokeBundleListenerCallback(EventDispatcher.java:821)
 [org.apache.felix.connect-0.1.0.jar:na]
at 
org.apache.felix.connect.felix.framework.util.EventDispatcher.fireEventImmediately(EventDispatcher.java:771)
 [org.apache.felix.connect-0.1.0.jar:na]
at 
org.apache.felix.connect.felix.framework.util.EventDispatcher.run(EventDispatcher.java:993)
 [org.apache.felix.connect-0.1.0.jar:na]
at 
org.apache.felix.connect.felix.framework.util.EventDispatcher.access$000(EventDispatcher.java:52)
 [org.apache.felix.connect-0.1.0.jar:na]
at 
org.apache.felix.connect.felix.framework.util.EventDispatcher$1.run(EventDispatcher.java:94)
 [org.apache.felix.connect-0.1.0.jar:na]
at java.lang.Thread.run(Thread.java:745) [na:1.7.0_55]
{noformat}



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Assigned] (FELIX-5083) Set webconsole.configurationFactory.nameHint for JAAS configurations

2015-11-29 Thread Chetan Mehrotra (JIRA)

 [ 
https://issues.apache.org/jira/browse/FELIX-5083?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Chetan Mehrotra reassigned FELIX-5083:
--

Assignee: Chetan Mehrotra

> Set webconsole.configurationFactory.nameHint for JAAS configurations
> 
>
> Key: FELIX-5083
> URL: https://issues.apache.org/jira/browse/FELIX-5083
> Project: Felix
>  Issue Type: Improvement
>  Components: JAAS
>Affects Versions: jaas-0.0.2
>Reporter: Robert Munteanu
>Assignee: Chetan Mehrotra
>Priority: Minor
> Fix For: jaas-0.0.4
>
> Attachments: FELIX-5083.patch, FELIX-5083.png
>
>
> When working with multiple JAAS configuration in the Felix Web Console it's 
> hard to distinguish them.
> Setting the {{webconsole.configurationFactory.nameHint}} property to a 
> reasonable default removes this problem.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Created] (FELIX-5119) Jaas module build fails with JDK 8

2015-11-29 Thread Chetan Mehrotra (JIRA)
Chetan Mehrotra created FELIX-5119:
--

 Summary: Jaas module build fails with JDK 8
 Key: FELIX-5119
 URL: https://issues.apache.org/jira/browse/FELIX-5119
 Project: Felix
  Issue Type: Task
  Components: JAAS
Reporter: Chetan Mehrotra
Assignee: Chetan Mehrotra
 Fix For: jaas-0.0.4


Building trunk with JDK 8 fails with test failures

See http://markmail.org/message/2dvzkkawoe26bw7w



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Created] (FELIX-5121) Script console build failing on latest trunk

2015-11-30 Thread Chetan Mehrotra (JIRA)
Chetan Mehrotra created FELIX-5121:
--

 Summary: Script console build failing on latest trunk
 Key: FELIX-5121
 URL: https://issues.apache.org/jira/browse/FELIX-5121
 Project: Felix
  Issue Type: Task
  Components: Script Console Plugin
Reporter: Chetan Mehrotra
Assignee: Chetan Mehrotra
 Fix For: script-console-1.0.2


Current trunk build is failing as exam-maven-plugin launch is not working 
{noformat}
[INFO] Failsafe report directory: 
/home/chetanm/git/apache/felix/webconsole-plugins/script-console/target/failsafe-reports
Error: Main method not found in class org.ops4j.pax.exam.spi.PaxExamRuntime, 
please define the main method as:
   public static void main(String[] args)
{noformat}

Due to this the OSGi container is not launched



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Resolved] (FELIX-5083) Set webconsole.configurationFactory.nameHint for JAAS configurations

2015-11-29 Thread Chetan Mehrotra (JIRA)

 [ 
https://issues.apache.org/jira/browse/FELIX-5083?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Chetan Mehrotra resolved FELIX-5083.

Resolution: Fixed

Thanks for the patch [~rombert]. Applied the part of patch related to 
{{JaasConfigFactory}} in 1717190

Opened FELIX-5119 to track build failure on JDK 1.8

> Set webconsole.configurationFactory.nameHint for JAAS configurations
> 
>
> Key: FELIX-5083
> URL: https://issues.apache.org/jira/browse/FELIX-5083
> Project: Felix
>  Issue Type: Improvement
>  Components: JAAS
>Affects Versions: jaas-0.0.2
>Reporter: Robert Munteanu
>Assignee: Chetan Mehrotra
>Priority: Minor
> Fix For: jaas-0.0.4
>
> Attachments: FELIX-5083.patch, FELIX-5083.png
>
>
> When working with multiple JAAS configuration in the Felix Web Console it's 
> hard to distinguish them.
> Setting the {{webconsole.configurationFactory.nameHint}} property to a 
> reasonable default removes this problem.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Resolved] (FELIX-5119) Jaas module build fails with JDK 8

2015-11-29 Thread Chetan Mehrotra (JIRA)

 [ 
https://issues.apache.org/jira/browse/FELIX-5119?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Chetan Mehrotra resolved FELIX-5119.

Resolution: Fixed

Updated the framework dependency to latest 5.4 so as to get test pass on JDK 
1.8 with 1717191. With this build passes for both JDK 1.7 and 1.8

[~rombert] Can you try again with latest trunk. For now I am resolving this 
issue. If some issue comes again it can be reopened

> Jaas module build fails with JDK 8
> --
>
> Key: FELIX-5119
> URL: https://issues.apache.org/jira/browse/FELIX-5119
> Project: Felix
>  Issue Type: Task
>  Components: JAAS
>Reporter: Chetan Mehrotra
>Assignee: Chetan Mehrotra
> Fix For: jaas-0.0.4
>
>
> Building trunk with JDK 8 fails with test failures
> See http://markmail.org/message/2dvzkkawoe26bw7w



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Resolved] (FELIX-5123) Script Console UI improvements

2015-11-30 Thread Chetan Mehrotra (JIRA)

 [ 
https://issues.apache.org/jira/browse/FELIX-5123?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Chetan Mehrotra resolved FELIX-5123.

Resolution: Fixed

Done with 1717221

> Script Console UI improvements
> --
>
> Key: FELIX-5123
> URL: https://issues.apache.org/jira/browse/FELIX-5123
> Project: Felix
>  Issue Type: Improvement
>  Components: Script Console Plugin
>Affects Versions: script-console-1.0.0
>Reporter: Chetan Mehrotra
>Assignee: Chetan Mehrotra
>Priority: Minor
> Fix For: script-console-1.0.2
>
>
> Following improvements need to be done to script console UI
> # Remove timeout on executed command
> # Drop the Language button



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Resolved] (FELIX-5120) ScriptEngineManager not able to parse service file with comments at end of classname

2015-11-30 Thread Chetan Mehrotra (JIRA)

 [ 
https://issues.apache.org/jira/browse/FELIX-5120?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Chetan Mehrotra resolved FELIX-5120.

Resolution: Fixed

Fixed with 1717206

> ScriptEngineManager not able to parse service file with comments at end of 
> classname
> 
>
> Key: FELIX-5120
> URL: https://issues.apache.org/jira/browse/FELIX-5120
> Project: Felix
>  Issue Type: Bug
>  Components: Script Console Plugin
>Affects Versions: script-console-1.0.0
>Reporter: Chetan Mehrotra
>Assignee: Chetan Mehrotra
>Priority: Minor
> Fix For: script-console-1.0.2
>
>
> A service file can also have a comment like below like
> {noformat}
> #script engines supported
> com.sun.script.javascript.RhinoScriptEngineFactory #javascript
> {noformat}
> Such a service file is not parsed properly and following exception is thrown
> {noformat}
> 2015-11-30 11:23:58.375 ERROR 23215 --- [ixDispatchQueue] 
> o.a.f.webconsole.plugins.scriptconsole   : Cannot register 
> ScriptEngineFactory com.sun.script.javascript.RhinoScriptEngineFactory 
> #javascript (java.lang.ClassNotFoundException: 
> com.sun.script.javascript.RhinoScriptEngineFactory #javascript)
> java.lang.ClassNotFoundException: 
> com.sun.script.javascript.RhinoScriptEngineFactory #javascript
> at java.net.URLClassLoader$1.run(URLClassLoader.java:366) 
> ~[na:1.7.0_55]
> at java.net.URLClassLoader$1.run(URLClassLoader.java:355) 
> ~[na:1.7.0_55]
> at java.security.AccessController.doPrivileged(Native Method) 
> ~[na:1.7.0_55]
> at java.net.URLClassLoader.findClass(URLClassLoader.java:354) 
> ~[na:1.7.0_55]
> at java.lang.ClassLoader.loadClass(ClassLoader.java:425) 
> ~[na:1.7.0_55]
> at java.lang.ClassLoader.loadClass(ClassLoader.java:358) 
> ~[na:1.7.0_55]
> at 
> org.apache.felix.connect.PojoSRBundle.loadClass(PojoSRBundle.java:451) 
> ~[org.apache.felix.connect-0.1.0.jar:na]
> at 
> org.apache.felix.webconsole.plugins.scriptconsole.internal.ScriptEngineManager.registerFactories(ScriptEngineManager.java:197)
>  [org.apache.felix.webconsole.plugins.scriptconsole-1.0.0.jar:na]
> at 
> org.apache.felix.webconsole.plugins.scriptconsole.internal.ScriptEngineManager.refreshScriptEngineManager(ScriptEngineManager.java:160)
>  [org.apache.felix.webconsole.plugins.scriptconsole-1.0.0.jar:na]
> at 
> org.apache.felix.webconsole.plugins.scriptconsole.internal.ScriptEngineManager.bundleChanged(ScriptEngineManager.java:111)
>  [org.apache.felix.webconsole.plugins.scriptconsole-1.0.0.jar:na]
> at 
> org.apache.felix.connect.felix.framework.util.EventDispatcher.invokeBundleListenerCallback(EventDispatcher.java:821)
>  [org.apache.felix.connect-0.1.0.jar:na]
> at 
> org.apache.felix.connect.felix.framework.util.EventDispatcher.fireEventImmediately(EventDispatcher.java:771)
>  [org.apache.felix.connect-0.1.0.jar:na]
> at 
> org.apache.felix.connect.felix.framework.util.EventDispatcher.run(EventDispatcher.java:993)
>  [org.apache.felix.connect-0.1.0.jar:na]
> at 
> org.apache.felix.connect.felix.framework.util.EventDispatcher.access$000(EventDispatcher.java:52)
>  [org.apache.felix.connect-0.1.0.jar:na]
> at 
> org.apache.felix.connect.felix.framework.util.EventDispatcher$1.run(EventDispatcher.java:94)
>  [org.apache.felix.connect-0.1.0.jar:na]
> at java.lang.Thread.run(Thread.java:745) [na:1.7.0_55]
> {noformat}



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Created] (FELIX-5123) Script Console UI improvements

2015-11-30 Thread Chetan Mehrotra (JIRA)
Chetan Mehrotra created FELIX-5123:
--

 Summary: Script Console UI improvements
 Key: FELIX-5123
 URL: https://issues.apache.org/jira/browse/FELIX-5123
 Project: Felix
  Issue Type: Improvement
  Components: Script Console Plugin
Affects Versions: script-console-1.0.0
Reporter: Chetan Mehrotra
Assignee: Chetan Mehrotra
Priority: Minor
 Fix For: script-console-1.0.2


Following improvements need to be done to script console UI

# Remove timeout on executed command
# Drop the Language button



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Commented] (FELIX-5318) SCR causes startup to wait when bundle uninstall itself in activator

2016-08-02 Thread Chetan Mehrotra (JIRA)

[ 
https://issues.apache.org/jira/browse/FELIX-5318?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15405364#comment-15405364
 ] 

Chetan Mehrotra commented on FELIX-5318:


With latest trunk I do not see the pause post uninstall. So it works!

> SCR causes startup to wait when bundle uninstall itself in activator
> 
>
> Key: FELIX-5318
> URL: https://issues.apache.org/jira/browse/FELIX-5318
> Project: Felix
>  Issue Type: Bug
>  Components: Declarative Services (SCR)
>Reporter: Chetan Mehrotra
>Assignee: David Jencks
>Priority: Minor
> Fix For: scr-2.0.6
>
> Attachments: FELIX-5318-v1.patch
>
>
> If a bundle which does not have any service component configured uninstall 
> itself upon activation then SCR waits for latch to timeout in 
> {{Activator$ScrExtension.destroy}}
> The threaddump indicate that FelixStartLevel thread is waiting for latch to 
> timeout
> {noformat}
> "FelixStartLevel" daemon prio=10 tid=0x7f4df45c5000 nid=0x65e6 waiting on 
> condition [0x7f4d92fcc000]
>java.lang.Thread.State: TIMED_WAITING (parking)
>   at sun.misc.Unsafe.park(Native Method)
>   - parking to wait for  <0x000783400420> (a 
> java.util.concurrent.CountDownLatch$Sync)
>   at 
> java.util.concurrent.locks.LockSupport.parkNanos(LockSupport.java:226)
>   at 
> java.util.concurrent.locks.AbstractQueuedSynchronizer.doAcquireSharedNanos(AbstractQueuedSynchronizer.java:1033)
>   at 
> java.util.concurrent.locks.AbstractQueuedSynchronizer.tryAcquireSharedNanos(AbstractQueuedSynchronizer.java:1326)
>   at java.util.concurrent.CountDownLatch.await(CountDownLatch.java:282)
>   at 
> org.apache.felix.scr.impl.Activator$ScrExtension.destroy(Activator.java:268)
>   at 
> org.apache.felix.utils.extender.AbstractExtender$2.run(AbstractExtender.java:290)
>   at 
> java.util.concurrent.Executors$RunnableAdapter.call(Executors.java:471)
>   at java.util.concurrent.FutureTask.run(FutureTask.java:262)
>   at 
> org.apache.felix.utils.extender.AbstractExtender.destroyExtension(AbstractExtender.java:312)
>   at 
> org.apache.felix.utils.extender.AbstractExtender.bundleChanged(AbstractExtender.java:186)
>   at 
> org.apache.felix.framework.util.EventDispatcher.invokeBundleListenerCallback(EventDispatcher.java:916)
>   at 
> org.apache.felix.framework.util.EventDispatcher.fireEventImmediately(EventDispatcher.java:835)
>   at 
> org.apache.felix.framework.util.EventDispatcher.fireBundleEvent(EventDispatcher.java:517)
>   at org.apache.felix.framework.Felix.fireBundleEvent(Felix.java:4541)
>   at org.apache.felix.framework.Felix.stopBundle(Felix.java:2600)
>   at org.apache.felix.framework.Felix.uninstallBundle(Felix.java:2712)
>   at org.apache.felix.framework.BundleImpl.uninstall(BundleImpl.java:1055)
>   at com.foo.bar.Initializer.activate(Initializer.java:71)
> {noformat}
> This happens at [1] most likely because Framework has not invoked started yet 
> so latch is not changed. As a fix destroy method should check if the bundle 
> being stopped has any service component. If not it should then not wait on 
> the latch
> [1] 
> https://github.com/apache/felix/blob/trunk/scr/src/main/java/org/apache/felix/scr/impl/Activator.java#L280



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Commented] (FELIX-5318) SCR causes startup to wait when bundle uninstall itself in activator

2016-08-03 Thread Chetan Mehrotra (JIRA)

[ 
https://issues.apache.org/jira/browse/FELIX-5318?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15405387#comment-15405387
 ] 

Chetan Mehrotra commented on FELIX-5318:


Thanks to you David for fixing it so promptly :)

> SCR causes startup to wait when bundle uninstall itself in activator
> 
>
> Key: FELIX-5318
> URL: https://issues.apache.org/jira/browse/FELIX-5318
> Project: Felix
>  Issue Type: Bug
>  Components: Declarative Services (SCR)
>Reporter: Chetan Mehrotra
>Assignee: David Jencks
>Priority: Minor
> Fix For: scr-2.0.6
>
> Attachments: FELIX-5318-v1.patch
>
>
> If a bundle which does not have any service component configured uninstall 
> itself upon activation then SCR waits for latch to timeout in 
> {{Activator$ScrExtension.destroy}}
> The threaddump indicate that FelixStartLevel thread is waiting for latch to 
> timeout
> {noformat}
> "FelixStartLevel" daemon prio=10 tid=0x7f4df45c5000 nid=0x65e6 waiting on 
> condition [0x7f4d92fcc000]
>java.lang.Thread.State: TIMED_WAITING (parking)
>   at sun.misc.Unsafe.park(Native Method)
>   - parking to wait for  <0x000783400420> (a 
> java.util.concurrent.CountDownLatch$Sync)
>   at 
> java.util.concurrent.locks.LockSupport.parkNanos(LockSupport.java:226)
>   at 
> java.util.concurrent.locks.AbstractQueuedSynchronizer.doAcquireSharedNanos(AbstractQueuedSynchronizer.java:1033)
>   at 
> java.util.concurrent.locks.AbstractQueuedSynchronizer.tryAcquireSharedNanos(AbstractQueuedSynchronizer.java:1326)
>   at java.util.concurrent.CountDownLatch.await(CountDownLatch.java:282)
>   at 
> org.apache.felix.scr.impl.Activator$ScrExtension.destroy(Activator.java:268)
>   at 
> org.apache.felix.utils.extender.AbstractExtender$2.run(AbstractExtender.java:290)
>   at 
> java.util.concurrent.Executors$RunnableAdapter.call(Executors.java:471)
>   at java.util.concurrent.FutureTask.run(FutureTask.java:262)
>   at 
> org.apache.felix.utils.extender.AbstractExtender.destroyExtension(AbstractExtender.java:312)
>   at 
> org.apache.felix.utils.extender.AbstractExtender.bundleChanged(AbstractExtender.java:186)
>   at 
> org.apache.felix.framework.util.EventDispatcher.invokeBundleListenerCallback(EventDispatcher.java:916)
>   at 
> org.apache.felix.framework.util.EventDispatcher.fireEventImmediately(EventDispatcher.java:835)
>   at 
> org.apache.felix.framework.util.EventDispatcher.fireBundleEvent(EventDispatcher.java:517)
>   at org.apache.felix.framework.Felix.fireBundleEvent(Felix.java:4541)
>   at org.apache.felix.framework.Felix.stopBundle(Felix.java:2600)
>   at org.apache.felix.framework.Felix.uninstallBundle(Felix.java:2712)
>   at org.apache.felix.framework.BundleImpl.uninstall(BundleImpl.java:1055)
>   at com.foo.bar.Initializer.activate(Initializer.java:71)
> {noformat}
> This happens at [1] most likely because Framework has not invoked started yet 
> so latch is not changed. As a fix destroy method should check if the bundle 
> being stopped has any service component. If not it should then not wait on 
> the latch
> [1] 
> https://github.com/apache/felix/blob/trunk/scr/src/main/java/org/apache/felix/scr/impl/Activator.java#L280



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Updated] (FELIX-5318) SCR causes startup to wait when bundle uninstall itself in activator

2016-08-02 Thread Chetan Mehrotra (JIRA)

 [ 
https://issues.apache.org/jira/browse/FELIX-5318?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Chetan Mehrotra updated FELIX-5318:
---
Attachment: FELIX-5318-v1.patch

[possible patch|^FELIX-5318-v1.patch] this should fix the issue based on 
logical flow. Creating a testcase would take some time. May be logical fix is  
sufficient!! Otherwise would try to come up with test also

> SCR causes startup to wait when bundle uninstall itself in activator
> 
>
> Key: FELIX-5318
> URL: https://issues.apache.org/jira/browse/FELIX-5318
> Project: Felix
>  Issue Type: Bug
>  Components: Declarative Services (SCR)
>Reporter: Chetan Mehrotra
>Priority: Minor
> Fix For: scr-2.0.6
>
> Attachments: FELIX-5318-v1.patch
>
>
> If a bundle which does not have any service component configured uninstall 
> itself upon activation then SCR waits for latch to timeout in 
> {{Activator$ScrExtension.destroy}}
> The threaddump indicate that FelixStartLevel thread is waiting for latch to 
> timeout
> {noformat}
> "FelixStartLevel" daemon prio=10 tid=0x7f4df45c5000 nid=0x65e6 waiting on 
> condition [0x7f4d92fcc000]
>java.lang.Thread.State: TIMED_WAITING (parking)
>   at sun.misc.Unsafe.park(Native Method)
>   - parking to wait for  <0x000783400420> (a 
> java.util.concurrent.CountDownLatch$Sync)
>   at 
> java.util.concurrent.locks.LockSupport.parkNanos(LockSupport.java:226)
>   at 
> java.util.concurrent.locks.AbstractQueuedSynchronizer.doAcquireSharedNanos(AbstractQueuedSynchronizer.java:1033)
>   at 
> java.util.concurrent.locks.AbstractQueuedSynchronizer.tryAcquireSharedNanos(AbstractQueuedSynchronizer.java:1326)
>   at java.util.concurrent.CountDownLatch.await(CountDownLatch.java:282)
>   at 
> org.apache.felix.scr.impl.Activator$ScrExtension.destroy(Activator.java:268)
>   at 
> org.apache.felix.utils.extender.AbstractExtender$2.run(AbstractExtender.java:290)
>   at 
> java.util.concurrent.Executors$RunnableAdapter.call(Executors.java:471)
>   at java.util.concurrent.FutureTask.run(FutureTask.java:262)
>   at 
> org.apache.felix.utils.extender.AbstractExtender.destroyExtension(AbstractExtender.java:312)
>   at 
> org.apache.felix.utils.extender.AbstractExtender.bundleChanged(AbstractExtender.java:186)
>   at 
> org.apache.felix.framework.util.EventDispatcher.invokeBundleListenerCallback(EventDispatcher.java:916)
>   at 
> org.apache.felix.framework.util.EventDispatcher.fireEventImmediately(EventDispatcher.java:835)
>   at 
> org.apache.felix.framework.util.EventDispatcher.fireBundleEvent(EventDispatcher.java:517)
>   at org.apache.felix.framework.Felix.fireBundleEvent(Felix.java:4541)
>   at org.apache.felix.framework.Felix.stopBundle(Felix.java:2600)
>   at org.apache.felix.framework.Felix.uninstallBundle(Felix.java:2712)
>   at org.apache.felix.framework.BundleImpl.uninstall(BundleImpl.java:1055)
>   at com.foo.bar.Initializer.activate(Initializer.java:71)
> {noformat}
> This happens at [1] most likely because Framework has not invoked started yet 
> so latch is not changed. As a fix destroy method should check if the bundle 
> being stopped has any service component. If not it should then not wait on 
> the latch
> [1] 
> https://github.com/apache/felix/blob/trunk/scr/src/main/java/org/apache/felix/scr/impl/Activator.java#L280



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Created] (FELIX-5318) SCR causes startup to wait when bundle uninstall itself in activator

2016-08-02 Thread Chetan Mehrotra (JIRA)
Chetan Mehrotra created FELIX-5318:
--

 Summary: SCR causes startup to wait when bundle uninstall itself 
in activator
 Key: FELIX-5318
 URL: https://issues.apache.org/jira/browse/FELIX-5318
 Project: Felix
  Issue Type: Bug
  Components: Declarative Services (SCR)
Reporter: Chetan Mehrotra
Priority: Minor
 Fix For: scr-2.0.6


If a bundle which does not have any service component configured uninstall 
itself upon activation then SCR waits for latch to timeout in 
{{Activator$ScrExtension.destroy}}

The threaddump indicate that FelixStartLevel thread is waiting for latch to 
timeout
{noformat}
"FelixStartLevel" daemon prio=10 tid=0x7f4df45c5000 nid=0x65e6 waiting on 
condition [0x7f4d92fcc000]
   java.lang.Thread.State: TIMED_WAITING (parking)
at sun.misc.Unsafe.park(Native Method)
- parking to wait for  <0x000783400420> (a 
java.util.concurrent.CountDownLatch$Sync)
at 
java.util.concurrent.locks.LockSupport.parkNanos(LockSupport.java:226)
at 
java.util.concurrent.locks.AbstractQueuedSynchronizer.doAcquireSharedNanos(AbstractQueuedSynchronizer.java:1033)
at 
java.util.concurrent.locks.AbstractQueuedSynchronizer.tryAcquireSharedNanos(AbstractQueuedSynchronizer.java:1326)
at java.util.concurrent.CountDownLatch.await(CountDownLatch.java:282)
at 
org.apache.felix.scr.impl.Activator$ScrExtension.destroy(Activator.java:268)
at 
org.apache.felix.utils.extender.AbstractExtender$2.run(AbstractExtender.java:290)
at 
java.util.concurrent.Executors$RunnableAdapter.call(Executors.java:471)
at java.util.concurrent.FutureTask.run(FutureTask.java:262)
at 
org.apache.felix.utils.extender.AbstractExtender.destroyExtension(AbstractExtender.java:312)
at 
org.apache.felix.utils.extender.AbstractExtender.bundleChanged(AbstractExtender.java:186)
at 
org.apache.felix.framework.util.EventDispatcher.invokeBundleListenerCallback(EventDispatcher.java:916)
at 
org.apache.felix.framework.util.EventDispatcher.fireEventImmediately(EventDispatcher.java:835)
at 
org.apache.felix.framework.util.EventDispatcher.fireBundleEvent(EventDispatcher.java:517)
at org.apache.felix.framework.Felix.fireBundleEvent(Felix.java:4541)
at org.apache.felix.framework.Felix.stopBundle(Felix.java:2600)
at org.apache.felix.framework.Felix.uninstallBundle(Felix.java:2712)
at org.apache.felix.framework.BundleImpl.uninstall(BundleImpl.java:1055)
at com.foo.bar.Initializer.activate(Initializer.java:71)
{noformat}

This happens at [1] most likely because Framework has not invoked started yet 
so latch is not changed. As a fix destroy method should check if the bundle 
being stopped has any service component. If not it should then not wait on the 
latch

[1] 
https://github.com/apache/felix/blob/trunk/scr/src/main/java/org/apache/felix/scr/impl/Activator.java#L280



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Created] (FELIX-5555) JSONParser is not removing escape char

2017-02-20 Thread Chetan Mehrotra (JIRA)
Chetan Mehrotra created FELIX-:
--

 Summary: JSONParser is not removing escape char
 Key: FELIX-
 URL: https://issues.apache.org/jira/browse/FELIX-
 Project: Felix
  Issue Type: Bug
  Components: Utils
Affects Versions: utils-1.9.0
Reporter: Chetan Mehrotra
 Fix For: utils-1.9.2


{{JSONWriter}} currently adds an escape char for '/'. So "foo=/bar" is rendered 
as 
{noformat}
{"foo":"\/bar"}
{noformat}

When such a json is read via {{JSONParser}} then the '\' is not removed

Following test fails
{code}
@Test
public void escapeChar() throws Exception{
StringWriter sw = new StringWriter();
JSONWriter js = new JSONWriter(sw);
js.object().key("foo").value("/bar").endObject().flush();

JSONParser jp = new JSONParser(sw.toString());
assertEquals("/bar", jp.getParsed().get("foo"));
}
{code}



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)


[jira] [Updated] (FELIX-5555) JSONParser is not handling escape char properly

2017-02-20 Thread Chetan Mehrotra (JIRA)

 [ 
https://issues.apache.org/jira/browse/FELIX-?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Chetan Mehrotra updated FELIX-:
---
Summary: JSONParser is not handling escape char properly  (was: JSONParser 
is not removing escape char)

> JSONParser is not handling escape char properly
> ---
>
> Key: FELIX-
> URL: https://issues.apache.org/jira/browse/FELIX-
> Project: Felix
>  Issue Type: Bug
>  Components: Utils
>Affects Versions: utils-1.9.0
>Reporter: Chetan Mehrotra
> Fix For: utils-1.9.2
>
>
> {{JSONWriter}} currently adds an escape char for '/'. So "foo=/bar" is 
> rendered as 
> {noformat}
> {"foo":"\/bar"}
> {noformat}
> When such a json is read via {{JSONParser}} then the '\' is not removed
> Following test fails
> {code}
> @Test
> public void escapeChar() throws Exception{
> StringWriter sw = new StringWriter();
> JSONWriter js = new JSONWriter(sw);
> js.object().key("foo").value("/bar").endObject().flush();
> 
> JSONParser jp = new JSONParser(sw.toString());
> assertEquals("/bar", jp.getParsed().get("foo"));
> }
> {code}



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)


[jira] [Commented] (FELIX-5555) JSONParser is not handling escape char properly

2017-02-20 Thread Chetan Mehrotra (JIRA)

[ 
https://issues.apache.org/jira/browse/FELIX-?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15874385#comment-15874385
 ] 

Chetan Mehrotra commented on FELIX-:


Added ignored test in 1783740. 

> JSONParser is not handling escape char properly
> ---
>
> Key: FELIX-
> URL: https://issues.apache.org/jira/browse/FELIX-
> Project: Felix
>  Issue Type: Bug
>  Components: Utils
>Affects Versions: utils-1.9.0
>Reporter: Chetan Mehrotra
> Fix For: utils-1.9.2
>
>
> {{JSONWriter}} currently adds an escape char for '/'. So "foo=/bar" is 
> rendered as 
> {noformat}
> {"foo":"\/bar"}
> {noformat}
> When such a json is read via {{JSONParser}} then the '\' is not removed
> Following test fails
> {code}
> @Test
> public void escapeChar() throws Exception{
> StringWriter sw = new StringWriter();
> JSONWriter js = new JSONWriter(sw);
> js.object().key("foo").value("/bar").endObject().flush();
> 
> JSONParser jp = new JSONParser(sw.toString());
> assertEquals("/bar", jp.getParsed().get("foo"));
> }
> {code}



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)


[jira] [Commented] (FELIX-5555) JSONParser is not handling escape char properly

2017-02-20 Thread Chetan Mehrotra (JIRA)

[ 
https://issues.apache.org/jira/browse/FELIX-?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15874410#comment-15874410
 ] 

Chetan Mehrotra commented on FELIX-:


bq. escaping of the writer is correct, a slash can be espaced - it's not a must 
though

http://stackoverflow.com/questions/1580647/json-why-are-forward-slashes-escaped 
also confirms that. FWIW org.json.JSONObject did not escaped the slash but its 
done by other libraries

> JSONParser is not handling escape char properly
> ---
>
> Key: FELIX-
> URL: https://issues.apache.org/jira/browse/FELIX-
> Project: Felix
>  Issue Type: Bug
>  Components: Utils
>Affects Versions: utils-1.9.0
>Reporter: Chetan Mehrotra
> Fix For: utils-1.9.2
>
>
> {{JSONWriter}} currently adds an escape char for '/'. So "foo=/bar" is 
> rendered as 
> {noformat}
> {"foo":"\/bar"}
> {noformat}
> When such a json is read via {{JSONParser}} then the '\' is not removed
> Following test fails
> {code}
> @Test
> public void escapeChar() throws Exception{
> StringWriter sw = new StringWriter();
> JSONWriter js = new JSONWriter(sw);
> js.object().key("foo").value("/bar").endObject().flush();
> 
> JSONParser jp = new JSONParser(sw.toString());
> assertEquals("/bar", jp.getParsed().get("foo"));
> }
> {code}



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)


[jira] [Created] (FELIX-5536) ConfigSpiOSGi may end with in complete realm due to race conditions

2017-02-10 Thread Chetan Mehrotra (JIRA)
Chetan Mehrotra created FELIX-5536:
--

 Summary: ConfigSpiOSGi may end with in complete realm due to race 
conditions
 Key: FELIX-5536
 URL: https://issues.apache.org/jira/browse/FELIX-5536
 Project: Felix
  Issue Type: Bug
  Components: JAAS
Reporter: Chetan Mehrotra
Assignee: Chetan Mehrotra
 Fix For: jaas-1.0.2


Some race conditions around this have been fixed with FELIX-5505. However one 
more case surfaced where {{ConfigSpiOsgi#recreateConfigs}} can be invoked 
concurrently without lock from 

# {{ConfigSpiOsgi#updated}} - When ConfigurationAdmin dispatches config update 
for {{org.apache.felix.jaas.ConfigurationSpi}}
# {{ConfigSpiOsgi#addingService}} - When some LoginModuleFactory is registered

In such a case the setup may end up with incomplete realm where some 
LoginModuleFactory are missed out



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)


[jira] [Updated] (FELIX-5536) ConfigSpiOSGi may end with incomplete realm due to race conditions

2017-02-10 Thread Chetan Mehrotra (JIRA)

 [ 
https://issues.apache.org/jira/browse/FELIX-5536?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Chetan Mehrotra updated FELIX-5536:
---
Summary: ConfigSpiOSGi may end with incomplete realm due to race conditions 
 (was: ConfigSpiOSGi may end with in complete realm due to race conditions)

> ConfigSpiOSGi may end with incomplete realm due to race conditions
> --
>
> Key: FELIX-5536
> URL: https://issues.apache.org/jira/browse/FELIX-5536
> Project: Felix
>  Issue Type: Bug
>  Components: JAAS
>Reporter: Chetan Mehrotra
>Assignee: Chetan Mehrotra
> Fix For: jaas-1.0.2
>
>
> Some race conditions around this have been fixed with FELIX-5505. However one 
> more case surfaced where {{ConfigSpiOsgi#recreateConfigs}} can be invoked 
> concurrently without lock from 
> # {{ConfigSpiOsgi#updated}} - When ConfigurationAdmin dispatches config 
> update for {{org.apache.felix.jaas.ConfigurationSpi}}
> # {{ConfigSpiOsgi#addingService}} - When some LoginModuleFactory is registered
> In such a case the setup may end up with incomplete realm where some 
> LoginModuleFactory are missed out



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)


[jira] [Created] (FELIX-5537) ConfigSpiOsgi should not try to unregister provider if not registered

2017-02-10 Thread Chetan Mehrotra (JIRA)
Chetan Mehrotra created FELIX-5537:
--

 Summary: ConfigSpiOsgi should not try to unregister provider if 
not registered
 Key: FELIX-5537
 URL: https://issues.apache.org/jira/browse/FELIX-5537
 Project: Felix
  Issue Type: Improvement
  Components: JAAS
Reporter: Chetan Mehrotra
Assignee: Chetan Mehrotra
Priority: Minor
 Fix For: jaas-1.0.2


On startup following log is seen which indicates a provider with null name is 
being unregistered. This should be avoided as when provider name is null then 
it indicates that provider has not be regsitered

{noformat}
10.02.2017 17:09:19.873 *INFO* [FelixStartLevel] org.apache.felix.jaas Removed 
provider null type JavaLoginConfig from Security providers list
{noformat}



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)


[jira] [Commented] (FELIX-5536) ConfigSpiOSGi may end with incomplete realm due to race conditions

2017-02-10 Thread Chetan Mehrotra (JIRA)

[ 
https://issues.apache.org/jira/browse/FELIX-5536?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15861666#comment-15861666
 ] 

Chetan Mehrotra commented on FELIX-5536:


Adding ignored test in 1782497

> ConfigSpiOSGi may end with incomplete realm due to race conditions
> --
>
> Key: FELIX-5536
> URL: https://issues.apache.org/jira/browse/FELIX-5536
> Project: Felix
>  Issue Type: Bug
>  Components: JAAS
>Reporter: Chetan Mehrotra
>Assignee: Chetan Mehrotra
> Fix For: jaas-1.0.2
>
>
> Some race conditions around this have been fixed with FELIX-5505. However one 
> more case surfaced where {{ConfigSpiOsgi#recreateConfigs}} can be invoked 
> concurrently without lock from 
> # {{ConfigSpiOsgi#updated}} - When ConfigurationAdmin dispatches config 
> update for {{org.apache.felix.jaas.ConfigurationSpi}}
> # {{ConfigSpiOsgi#addingService}} - When some LoginModuleFactory is registered
> In such a case the setup may end up with incomplete realm where some 
> LoginModuleFactory are missed out



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)


[jira] [Resolved] (FELIX-5536) ConfigSpiOSGi may end with incomplete realm due to race conditions

2017-02-10 Thread Chetan Mehrotra (JIRA)

 [ 
https://issues.apache.org/jira/browse/FELIX-5536?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Chetan Mehrotra resolved FELIX-5536.

Resolution: Fixed

Fixed with 1782501

> ConfigSpiOSGi may end with incomplete realm due to race conditions
> --
>
> Key: FELIX-5536
> URL: https://issues.apache.org/jira/browse/FELIX-5536
> Project: Felix
>  Issue Type: Bug
>  Components: JAAS
>Reporter: Chetan Mehrotra
>Assignee: Chetan Mehrotra
> Fix For: jaas-1.0.2
>
>
> Some race conditions around this have been fixed with FELIX-5505. However one 
> more case surfaced where {{ConfigSpiOsgi#recreateConfigs}} can be invoked 
> concurrently without lock from 
> # {{ConfigSpiOsgi#updated}} - When ConfigurationAdmin dispatches config 
> update for {{org.apache.felix.jaas.ConfigurationSpi}}
> # {{ConfigSpiOsgi#addingService}} - When some LoginModuleFactory is registered
> In such a case the setup may end up with incomplete realm where some 
> LoginModuleFactory are missed out



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)


[jira] [Resolved] (FELIX-5537) ConfigSpiOsgi should not try to unregister provider if not registered

2017-02-10 Thread Chetan Mehrotra (JIRA)

 [ 
https://issues.apache.org/jira/browse/FELIX-5537?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Chetan Mehrotra resolved FELIX-5537.

Resolution: Fixed

Done with 1782503

> ConfigSpiOsgi should not try to unregister provider if not registered
> -
>
> Key: FELIX-5537
> URL: https://issues.apache.org/jira/browse/FELIX-5537
> Project: Felix
>  Issue Type: Improvement
>  Components: JAAS
>Reporter: Chetan Mehrotra
>Assignee: Chetan Mehrotra
>Priority: Minor
> Fix For: jaas-1.0.2
>
>
> On startup following log is seen which indicates a provider with null name is 
> being unregistered. This should be avoided as when provider name is null then 
> it indicates that provider has not be regsitered
> {noformat}
> 10.02.2017 17:09:19.873 *INFO* [FelixStartLevel] org.apache.felix.jaas 
> Removed provider null type JavaLoginConfig from Security providers list
> {noformat}



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)


[jira] [Created] (FELIX-5502) Startup logs from ConfigSpiOsgi may get dropped due to race condition

2017-01-19 Thread Chetan Mehrotra (JIRA)
Chetan Mehrotra created FELIX-5502:
--

 Summary: Startup logs from ConfigSpiOsgi may get dropped due to 
race condition
 Key: FELIX-5502
 URL: https://issues.apache.org/jira/browse/FELIX-5502
 Project: Felix
  Issue Type: Bug
  Components: JAAS
Reporter: Chetan Mehrotra
Assignee: Chetan Mehrotra
Priority: Minor
 Fix For: jaas-1.0.0


Felix JAAS bundle Activator [1] starts the Logger tracker *after* creating 
{{ConfigSpiOsgi}} instance. Due to this some log statements may get missed out 
if config admin invokes managed service update before logger tracker is opened 
which would cause the logger to drop those messages

[1] 
https://github.com/apache/felix/blob/trunk/jaas/src/main/java/org/apache/felix/jaas/internal/Activator.java#L49



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Resolved] (FELIX-5502) Startup logs from ConfigSpiOsgi may get dropped due to race condition

2017-01-20 Thread Chetan Mehrotra (JIRA)

 [ 
https://issues.apache.org/jira/browse/FELIX-5502?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Chetan Mehrotra resolved FELIX-5502.

Resolution: Fixed

Fixed with 1779591

> Startup logs from ConfigSpiOsgi may get dropped due to race condition
> -
>
> Key: FELIX-5502
> URL: https://issues.apache.org/jira/browse/FELIX-5502
> Project: Felix
>  Issue Type: Bug
>  Components: JAAS
>Reporter: Chetan Mehrotra
>Assignee: Chetan Mehrotra
>Priority: Minor
> Fix For: jaas-1.0.0
>
>
> Felix JAAS bundle Activator [1] starts the Logger tracker *after* creating 
> {{ConfigSpiOsgi}} instance. Due to this some log statements may get missed 
> out if config admin invokes managed service update before logger tracker is 
> opened which would cause the logger to drop those messages
> [1] 
> https://github.com/apache/felix/blob/trunk/jaas/src/main/java/org/apache/felix/jaas/internal/Activator.java#L49



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Commented] (FELIX-5505) ConfigSpiOSGi may miss out on registering some LoginModuleFactory due to race condition

2017-01-20 Thread Chetan Mehrotra (JIRA)

[ 
https://issues.apache.org/jira/browse/FELIX-5505?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15831462#comment-15831462
 ] 

Chetan Mehrotra commented on FELIX-5505:


Added ignored test with 1779592

> ConfigSpiOSGi may miss out on registering some LoginModuleFactory due to race 
> condition
> ---
>
> Key: FELIX-5505
> URL: https://issues.apache.org/jira/browse/FELIX-5505
> Project: Felix
>  Issue Type: Bug
>  Components: JAAS
>Reporter: Chetan Mehrotra
>Assignee: Chetan Mehrotra
>Priority: Critical
> Fix For: jaas-1.0.0
>
>
> {{ConfigSpiOsgi}} currently looks for {{LoginModuleFactory}} and upon 
> registration of any factory it recreates its {{Realm}} state. 
> This logic has a race condition where concurrent addition of 
> {{LoginModuleFactory}} may lead to some of them getting missed from getting 
> registered in the Realm



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Created] (FELIX-5505) ConfigSpiOSGi may miss out on registering some LoginModuleFactory due to race condition

2017-01-20 Thread Chetan Mehrotra (JIRA)
Chetan Mehrotra created FELIX-5505:
--

 Summary: ConfigSpiOSGi may miss out on registering some 
LoginModuleFactory due to race condition
 Key: FELIX-5505
 URL: https://issues.apache.org/jira/browse/FELIX-5505
 Project: Felix
  Issue Type: Bug
  Components: JAAS
Reporter: Chetan Mehrotra
Assignee: Chetan Mehrotra
Priority: Critical
 Fix For: jaas-1.0.0


{{ConfigSpiOsgi}} currently looks for {{LoginModuleFactory}} and upon 
registration of any factory it recreates its {{Realm}} state. 

This logic has a race condition where concurrent addition of 
{{LoginModuleFactory}} may lead to some of them getting missed from getting 
registered in the Realm



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Updated] (FELIX-5505) ConfigSpiOSGi may miss out on registering some LoginModuleFactory due to race condition

2017-01-20 Thread Chetan Mehrotra (JIRA)

 [ 
https://issues.apache.org/jira/browse/FELIX-5505?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Chetan Mehrotra updated FELIX-5505:
---
Attachment: FELIX-5505-v1.patch

[patch|^FELIX-5505-v1.patch] for the same

[~cziegeler] [~bosschaert] Would be helpful if you can review the patch

> ConfigSpiOSGi may miss out on registering some LoginModuleFactory due to race 
> condition
> ---
>
> Key: FELIX-5505
> URL: https://issues.apache.org/jira/browse/FELIX-5505
> Project: Felix
>  Issue Type: Bug
>  Components: JAAS
>Reporter: Chetan Mehrotra
>Assignee: Chetan Mehrotra
>Priority: Critical
> Fix For: jaas-1.0.0
>
> Attachments: FELIX-5505-v1.patch
>
>
> {{ConfigSpiOsgi}} currently looks for {{LoginModuleFactory}} and upon 
> registration of any factory it recreates its {{Realm}} state. 
> This logic has a race condition where concurrent addition of 
> {{LoginModuleFactory}} may lead to some of them getting missed from getting 
> registered in the Realm



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Resolved] (FELIX-5505) ConfigSpiOSGi may miss out on registering some LoginModuleFactory due to race condition

2017-01-20 Thread Chetan Mehrotra (JIRA)

 [ 
https://issues.apache.org/jira/browse/FELIX-5505?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Chetan Mehrotra resolved FELIX-5505.

Resolution: Fixed

Thanks Carsten for the review

Took care of unregistering the spi in close

Applied the patch in 1779601

> ConfigSpiOSGi may miss out on registering some LoginModuleFactory due to race 
> condition
> ---
>
> Key: FELIX-5505
> URL: https://issues.apache.org/jira/browse/FELIX-5505
> Project: Felix
>  Issue Type: Bug
>  Components: JAAS
>Reporter: Chetan Mehrotra
>Assignee: Chetan Mehrotra
>Priority: Critical
> Fix For: jaas-1.0.0
>
> Attachments: FELIX-5505-v1.patch
>
>
> {{ConfigSpiOsgi}} currently looks for {{LoginModuleFactory}} and upon 
> registration of any factory it recreates its {{Realm}} state. 
> This logic has a race condition where concurrent addition of 
> {{LoginModuleFactory}} may lead to some of them getting missed from getting 
> registered in the Realm



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Created] (FELIX-5398) Inventory printer to dump all framework properties

2016-11-06 Thread Chetan Mehrotra (JIRA)
Chetan Mehrotra created FELIX-5398:
--

 Summary: Inventory printer to dump all framework properties
 Key: FELIX-5398
 URL: https://issues.apache.org/jira/browse/FELIX-5398
 Project: Felix
  Issue Type: Improvement
  Components: Web Console
Reporter: Chetan Mehrotra
Assignee: Chetan Mehrotra
Priority: Minor


Add a Inventory Status Printer to dump all Framework Property. This can use the 
approach suggested by [~tjwatson] at [1]

[1] https://mail.osgi.org/pipermail/osgi-dev/2016-November/005800.html



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Assigned] (FELIX-5758) metatype.properties file must not be in OSGI-INF/metatype directory

2017-12-14 Thread Chetan Mehrotra (JIRA)

 [ 
https://issues.apache.org/jira/browse/FELIX-5758?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Chetan Mehrotra reassigned FELIX-5758:
--

Assignee: Chetan Mehrotra

> metatype.properties file must not be in OSGI-INF/metatype directory
> ---
>
> Key: FELIX-5758
> URL: https://issues.apache.org/jira/browse/FELIX-5758
> Project: Felix
>  Issue Type: Bug
>  Components: JAAS
>Reporter: Daniele Pirola
>Assignee: Chetan Mehrotra
>
> According to the spec all files inside OSGI-INF/metatype directory must be 
> valid meta type documents. See bug FELIX-5701



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)


<    1   2