Re: Intergration test

2018-02-12 Thread Ed Cable
Kumaranath,

Could you please look into these failing integration tests? It's one of the
last items we need to address before we can release.

Thanks,

Ed

On Sat, Feb 10, 2018 at 3:15 AM, Nazeer Hussain Shaik <
nazeerhussain.sh...@gmail.com> wrote:

> Hi Vishwas,
>
> I can see the below test case failures related to bulk import feature(with
> yellow background) which was added recently into Fineract (on both Develop
> and 1.1.0 release branch). I don't see any other issue mentioned by you.
>
>- FixedDepositTest
>FixedDepositTest.html>.
>   testMaturityAmountForDailyCompoundingAndMonthlyPosting_With_360_Days
>testMaturityAmountForDailyCompoundingAndMonthlyPosting_With_360_Days>
>   - SchedulerJobsTest
>SchedulerJobsTest.html>.
>testSchedulerJobs
>SchedulerJobsTest.html#testSchedulerJobs>
>   - ClientEntityImportHandlerTest
>importhandler.client.ClientEntityImportHandlerTest.html>
>   . testClientImport
>importhandler.client.ClientEntityImportHandlerTest.html#testClientImport>
>   - LoanImportHandlerTest
>importhandler.loan.LoanImportHandlerTest.html>
>   . testLoanImport
>importhandler.loan.LoanImportHandlerTest.html#testLoanImport>
>   - SavingsImportHandlerTest
>importhandler.savings.SavingsImportHandlerTest.html>
>   . testSavingsImport
>importhandler.savings.SavingsImportHandlerTest.html#testSavingsImport>
>   - LoanWorkbookPopulatorTest
>populator.loan.LoanWorkbookPopulatorTest.html>
>   . testLoanWorkbookPopulate
>populator.loan.LoanWorkbookPopulatorTest.html#testLoanWorkbookPopulate>
>   - SavingsWorkbookPopulateTest
>populator.savings.SavingsWorkbookPopulateTest.html>
>   . testSavingsWorkbookPopulate
>populator.savings.SavingsWorkbookPopulateTest.html#
> testSavingsWorkbookPopulate>
>
>
> Regards.
> Nazeer
>
>
> On Sat, Feb 10, 2018 at 8:50 AM, Steve Conrad  wrote:
>
> > Vishwas,
> > Thanks for updating the integration tests relating to the FINERACT-590
> > change. I'll make sure to run integration tests before any promotions.
> > Steve
> >
> >
> > On Fri, Feb 9, 2018 at 8:26 PM, vishwas  >
> > wrote:
> >
> > > Hi Mexina,
> > >
> > > Many of the failures were related to recent changes made for
> > FINERACT-590.
> > > I have fixed the same now.
> > >
> > > However, I still see 15 failures (details below)
> > >
> > > @Nazeer, Ed, Any devs active on the codebase recently : Do we know how
> > > long these test cases have been failing ? Do we having any CI setup for
> > > Fineract (we had Travis CI for the erstwhile Mifos codebase, the same
> > seems
> > > to be down now) ?
> > >
> > > ClientUndoRejectAndWithdrawalIntegrationTest
> > >  > > classes/org.apache.fineract.integrationtests.
> > > ClientUndoRejectAndWithdrawalIntegrationTest.html>.
> > > testClientUndoRejectWithFutureDate  > > 47B7-B872-A1213C63AF43/classes/org.apache.fineract.integrationtests.
> > > ClientUndoRejectAndWithdrawalIntegrationTest.html#
> > > testClientUndoRejectWithFutureDate>
> > > ClientUndoRejectAndWithdrawalIntegrationTest
> > >  > > classes/org.apache.fineract.integrationtests.
> > > ClientUndoRejectAndWithdrawalIntegrationTest.html>.
> > > testClientUndoWithDrawnWithFutureDate  > > 47B7-B872-A1213C63AF43/classes/org.apache.fineract.integrationtests.
> > > ClientUndoRejectAndWithdrawalIntegrationTest.html#
> > > testClientUndoWithDrawnWithFutureDate>
> > > FixedDepositTest  > > classes/org.apache.fineract.integrationtests.FixedDepositTest.html>.
> > > testMaturityAmountForDailyCompoundingAndMonthlyPosting_With_360_Days
> > >  > > classes/org.apache.fineract.integrationtests.FixedDepositTest.html#
> > > testMaturityAmountForDailyCompoundingAndMonthlyPosting_With_360_Days>
> > > GroupSavingsIntegrationTest  > > 47B7-B872-A1213C63AF43/classes/org.apache.fineract.integrationtests.
> > > GroupSavingsIntegrationTest.html>. testSavingsAccountCharges
> > >  > > classes/org.apache.fineract.integrationtests.
> > GroupSavingsIntegrationTest.
> > > html#testSavingsAccountCharges>
> > > SchedulerJobsTest  47B7-B872-A1213C63AF43/
> > > classes/org.apache.fineract.integrationtests.SchedulerJobsTest.html>.
> > > testSchedulerJobs  47B7-B872-A1213C63AF43/
> > > classes/org.apache.fineract.integrationtests.SchedulerJobsTest.html#
> > > testSchedulerJobs>
> > > SchedulerJobsTestResults  > > 47B7-B872-A1213C63AF43/classes/org.apache.fineract.integrationtests.
> > > SchedulerJobsTestResults.html>. testApplyDueFeeChargesForSavin
> > gsJobOutcome
> > >  > > classes/org.apache.fineract.integrationtests.
> > > SchedulerJobsTestResults.html#testApplyDueFeeChargesForSavin
> > gsJobOutcome>
> > > ClientEntityImportHandlerTest  > > 47B7-B872-A1213C63AF43/classes/org.apache.fineract.
> > > integrationtests.bulkimport.importhandler.client.
> > > ClientEntityImportHandlerTest.html>. testClientImport
> > >  > > classes/org.apache.fineract.integrationtests.bulkimport.
> > > importhandle

Re: Meeting to Discuss Release Management Process

2018-02-12 Thread Phil Steitz
On 2/12/18 9:32 AM, Ed Cable wrote:
> Here's the link to screencast from the discussion:
> https://youtu.be/xnTGf4R2s5k
>
> Ed
>
> On Mon, Feb 12, 2018 at 6:32 AM, Ed Cable  wrote:
>
>> Hi all,
>>
>> Thanks to Nazeer for leading this session and the sizeable group that
>> attended. Based on the process, we can clearly use the assistance of other
>> community members in the planning process and committers in the release
>> process so happy we had such good attendance.
>>
>> Based on the discussion, here's a proposal of how timing might look for
>> monthly release cycles with planning (a new phase) starting out six months
>> prior to the release date.
>>
>> Screencast of session will be posted soon.
>>
>> Please comment on the notes in the table and here's proposed timing for
>> the next 1.2 release:
>>
>> Plans for Release Apache Fineract 1.2
>>
>> Planning Release - Start with a Meeting on Feb 14

How about starting with a discussion on this list?  Relying on
synchronous meetings cuts out people who can't attend due to time
zones / other commitments.

Phil
>>
>> Announce Release - Feb 28
>>
>> QA - Feb 28 - March 14
>>
>> Publish Release Notes - March 14
>>
>> Vote on Release - March 21
>>
>> Target release date - March 28
>>
>> Stage
>>
>> Description
>>
>> Proposed Length
>>
>> How Far in Advance of Release (Proposed)
>>
>> How Far in Advance of Release (Currently)
>>
>> Planning of Next Release
>>
>> Discuss with community what would like to ship in next release and what
>> people could work on.
>>
>> Create fix version on JIRA to assign to.
>>
>> Action: modify existing email template to open up planning process,
>> schedule a meeting to discuss and set a tentative branching date (i.e. 2
>> weeks later, if release date is a month past that).
>>
>> .
>>
>> 1 week
>>
>> 6 weeks
>>
>> Doesn’t Exist
>>
>> Announcement of Release
>>
>> Announce what is going to come in the release (should be 80% done at
>> least).
>>
>> Cut a release branch and freeze release branch and then develop branch can
>> still have active work on it but only in rare cases might anything
>> additional from develop
>>
>> Email out sharing release branch details
>>
>> 4 weeks prior
>>
>> 1 - 2 months
>>
>> QA
>>
>> QA begins on the release branch - staging Server setup
>>
>> Might fix some regression issues
>>
>> 1 - 2 weeks
>>
>> 4 weeks prior
>>
>> JIRA Sanitization/Publish RElease Notes
>>
>> Sanitize release documentation
>>
>> Create release notes and email community release information with links.
>>
>>
>> 2 weeks prior
>>
>> Vote
>>
>> Create artifacts, sign release, etc. Open up votes
>>
>> 1 week prior
>>
>> Release
>>
>> Tally up votes, announce, update websites and infrastructure with new
>> release artifacts.
>>
>> Release date
>>
>>
>>
>>
>> On Sun, Feb 11, 2018 at 7:40 AM, Ed Cable  wrote:
>>
>>> Hi all,
>>>
>>> This meeting is happening now for anybody that wants to join.
>>>
>>> Ed
>>>
>>> On Sat, Feb 10, 2018 at 6:07 AM, Ed Cable  wrote:
>>>
 Hi all

 Woule 1530GMT work on Sunday? Nazeer had a conflict on Saturday. I'll
 update the GoToTraining session.

 Ed

 On Thu, Feb 8, 2018 at 9:19 AM, Sendoro Juma 
 wrote:

> Hello Ed,
>
> Just in case, same Saturday(s) but starting 15:30GMT!
>
> if it is fine with Nazeer, then we will very much appreciate...
>
> Sorry our request is based on the fact on belief/religious related!
>
> Cheers
> Sendoro
>
> - Original Message -
> From: "Ed Cable" 
> To: "dev" 
> Cc: "Nazeer Hussain Shaik" 
> Sent: Thursday, February 8, 2018 7:05:55 PM
> Subject: Re: Meeting to Discuss Release Management Process
>
> Hmm... We can reschedule to accommodate everyone. Weekdays might be
> difficult for Nazeer with his new schedule.
>
> Ed
>
> On Thu, Feb 8, 2018 at 7:42 AM, Sendoro Juma 
> wrote:
>
>> Hello Ed,
>>
>> Hope you will record,
>>
>> I see two members missing from our side because of that new timing.
>>
>> Cheers
>> Sendoro
>>
>> - Original Message -
>> From: "Ed Cable" 
>> To: "dev" 
>> Cc: "Nazeer Hussain Shaik" 
>> Sent: Thursday, February 8, 2018 5:05:35 PM
>> Subject: Re: Meeting to Discuss Release Management Process
>>
>> Hi all,
>>
>> Nazeer is not available till Saturday for this meeting so I am going
> to
>> adjust the timing to Saturday at 1400GMT and will update the
> GoToTraining
>> session accordingly.
>>
>> Ed
>>
>> On Thu, Feb 8, 2018 at 6:46 AM, Awasum Yannick <
>> awasum.yann...@skylabase.com
>>> wrote:
>>> I already registered for it.
>>>
>>> I hope it happens.
>>>
>>> Thanks
>>> Awasum
>>>
>>> On Thu, Feb 8, 2018 at 1:23 PM, Nikhil Pawar 
> wrote:
 Is this meeting happening?
 I’ll be interested to participate.

 Regards,
 Nikhi

Re: Meeting to Discuss Release Management Process

2018-02-12 Thread Ed Cable
Here's the link to screencast from the discussion:
https://youtu.be/xnTGf4R2s5k

Ed

On Mon, Feb 12, 2018 at 6:32 AM, Ed Cable  wrote:

> Hi all,
>
> Thanks to Nazeer for leading this session and the sizeable group that
> attended. Based on the process, we can clearly use the assistance of other
> community members in the planning process and committers in the release
> process so happy we had such good attendance.
>
> Based on the discussion, here's a proposal of how timing might look for
> monthly release cycles with planning (a new phase) starting out six months
> prior to the release date.
>
> Screencast of session will be posted soon.
>
> Please comment on the notes in the table and here's proposed timing for
> the next 1.2 release:
>
> Plans for Release Apache Fineract 1.2
>
> Planning Release - Start with a Meeting on Feb 14
>
> Announce Release - Feb 28
>
> QA - Feb 28 - March 14
>
> Publish Release Notes - March 14
>
> Vote on Release - March 21
>
> Target release date - March 28
>
> Stage
>
> Description
>
> Proposed Length
>
> How Far in Advance of Release (Proposed)
>
> How Far in Advance of Release (Currently)
>
> Planning of Next Release
>
> Discuss with community what would like to ship in next release and what
> people could work on.
>
> Create fix version on JIRA to assign to.
>
> Action: modify existing email template to open up planning process,
> schedule a meeting to discuss and set a tentative branching date (i.e. 2
> weeks later, if release date is a month past that).
>
> .
>
> 1 week
>
> 6 weeks
>
> Doesn’t Exist
>
> Announcement of Release
>
> Announce what is going to come in the release (should be 80% done at
> least).
>
> Cut a release branch and freeze release branch and then develop branch can
> still have active work on it but only in rare cases might anything
> additional from develop
>
> Email out sharing release branch details
>
> 4 weeks prior
>
> 1 - 2 months
>
> QA
>
> QA begins on the release branch - staging Server setup
>
> Might fix some regression issues
>
> 1 - 2 weeks
>
> 4 weeks prior
>
> JIRA Sanitization/Publish RElease Notes
>
> Sanitize release documentation
>
> Create release notes and email community release information with links.
>
>
> 2 weeks prior
>
> Vote
>
> Create artifacts, sign release, etc. Open up votes
>
> 1 week prior
>
> Release
>
> Tally up votes, announce, update websites and infrastructure with new
> release artifacts.
>
> Release date
>
>
>
>
> On Sun, Feb 11, 2018 at 7:40 AM, Ed Cable  wrote:
>
>> Hi all,
>>
>> This meeting is happening now for anybody that wants to join.
>>
>> Ed
>>
>> On Sat, Feb 10, 2018 at 6:07 AM, Ed Cable  wrote:
>>
>>> Hi all
>>>
>>> Woule 1530GMT work on Sunday? Nazeer had a conflict on Saturday. I'll
>>> update the GoToTraining session.
>>>
>>> Ed
>>>
>>> On Thu, Feb 8, 2018 at 9:19 AM, Sendoro Juma 
>>> wrote:
>>>
 Hello Ed,

 Just in case, same Saturday(s) but starting 15:30GMT!

 if it is fine with Nazeer, then we will very much appreciate...

 Sorry our request is based on the fact on belief/religious related!

 Cheers
 Sendoro

 - Original Message -
 From: "Ed Cable" 
 To: "dev" 
 Cc: "Nazeer Hussain Shaik" 
 Sent: Thursday, February 8, 2018 7:05:55 PM
 Subject: Re: Meeting to Discuss Release Management Process

 Hmm... We can reschedule to accommodate everyone. Weekdays might be
 difficult for Nazeer with his new schedule.

 Ed

 On Thu, Feb 8, 2018 at 7:42 AM, Sendoro Juma 
 wrote:

 > Hello Ed,
 >
 > Hope you will record,
 >
 > I see two members missing from our side because of that new timing.
 >
 > Cheers
 > Sendoro
 >
 > - Original Message -
 > From: "Ed Cable" 
 > To: "dev" 
 > Cc: "Nazeer Hussain Shaik" 
 > Sent: Thursday, February 8, 2018 5:05:35 PM
 > Subject: Re: Meeting to Discuss Release Management Process
 >
 > Hi all,
 >
 > Nazeer is not available till Saturday for this meeting so I am going
 to
 > adjust the timing to Saturday at 1400GMT and will update the
 GoToTraining
 > session accordingly.
 >
 > Ed
 >
 > On Thu, Feb 8, 2018 at 6:46 AM, Awasum Yannick <
 > awasum.yann...@skylabase.com
 > > wrote:
 >
 > > I already registered for it.
 > >
 > > I hope it happens.
 > >
 > > Thanks
 > > Awasum
 > >
 > > On Thu, Feb 8, 2018 at 1:23 PM, Nikhil Pawar 
 wrote:
 > >
 > > > Is this meeting happening?
 > > > I’ll be interested to participate.
 > > >
 > > > Regards,
 > > > Nikhil
 > > >
 > > > On Wed, Feb 7, 2018 at 10:54 AM Ed Cable 
 wrote:
 > > >
 > > > > Nazeer,
 > > > >
 > > > > Per the other email thread, we'd like to set up a meeting to
 both
 > > discuss
 > > > > and improve our release management process and to transfer
 knowledge
 > to
 > > > >

Re: [SOLUTION] | ISSUE : FINERACT-547

2018-02-12 Thread Rahul Goel
Hi Vishwas,

Thank you for doing the needful.

On Mon, Feb 12, 2018 at 10:37 AM, Vishwas Babu <
vish...@confluxtechnologies.com> wrote:

> Hi Rahul,
>
> I have updated the demo server.
>
> A fresh installation of Fineract should not have this issue.
>
> It looks like tenants created on the demo server are having a sample
> database that consists of a few loan products and Chart of accounts
> configured, this sample database is restored from
> incubator-fineract/fineract-provider/src/main/resources/
> sql/migrations/sample_data/load_sample_data.sql.
> I had a quick look at this file and it has incorrect symbols for INR and
> other currencies.
>
> Fixing this file would ensure that
> *https://issues.apache.org/jira/browse/FINERACT-547?filter=12342983
> * does
> not occur in new tenants created with sample data on the demo server.
>
>
> Regards,
>
> Vishwas
>
> Regards,
> Vishwas
> +1 (202) 716 6675
>
> On Sat, Feb 10, 2018 at 10:41 AM, Rahul Goel 
> wrote:
>
> > Hi community,
> >
> > I was looking into this iss*u*e :
> > https://github.com/openMF/community-app/issues/2440
> > *https://issues.apache.org/jira/browse/FINERACT-547?filter=12342983
> > *
> >
> > I found that this is a bug of FINERACT project due to incorrect data in
> > database.
> > I tried fetching currency details using below API endpoint and found that
> > backend is giving incorrect symbol. (screenshot attached)
> > https://demo.openmf.org/fineract-provider/api/v1/currencies?
> > tenantIdentifier=default&pretty=true
> >
> > I then replicated this on my local machine using staging database dump
> > shared with me by Sampath. Because staging database had correct symbol,
> > correct result was received from API(screenshot attached).
> >
> > I request community members who has access to the database to kindly run
> > these queries.
> >
> >1.
> > *UPDATE `m_currency` SET display_symbol = '₹' where code = 'INR' *
> >2. *UPDATE `m_organisation_currency` SET display_symbol = '₹' where
> >code = 'INR'*
> >
> >
> > After running these queries ISSUE : FINERACT-547 should be resolved.
> > --
> > RAHUL GOEL
> >
> >
>



-- 
RAHUL GOEL
+91-9873124753


Re: Meeting to Discuss Release Management Process

2018-02-12 Thread Ed Cable
Hi all,

Thanks to Nazeer for leading this session and the sizeable group that
attended. Based on the process, we can clearly use the assistance of other
community members in the planning process and committers in the release
process so happy we had such good attendance.

Based on the discussion, here's a proposal of how timing might look for
monthly release cycles with planning (a new phase) starting out six months
prior to the release date.

Screencast of session will be posted soon.

Please comment on the notes in the table and here's proposed timing for the
next 1.2 release:

Plans for Release Apache Fineract 1.2

Planning Release - Start with a Meeting on Feb 14

Announce Release - Feb 28

QA - Feb 28 - March 14

Publish Release Notes - March 14

Vote on Release - March 21

Target release date - March 28

Stage

Description

Proposed Length

How Far in Advance of Release (Proposed)

How Far in Advance of Release (Currently)

Planning of Next Release

Discuss with community what would like to ship in next release and what
people could work on.

Create fix version on JIRA to assign to.

Action: modify existing email template to open up planning process,
schedule a meeting to discuss and set a tentative branching date (i.e. 2
weeks later, if release date is a month past that).

.

1 week

6 weeks

Doesn’t Exist

Announcement of Release

Announce what is going to come in the release (should be 80% done at least).

Cut a release branch and freeze release branch and then develop branch can
still have active work on it but only in rare cases might anything
additional from develop

Email out sharing release branch details

4 weeks prior

1 - 2 months

QA

QA begins on the release branch - staging Server setup

Might fix some regression issues

1 - 2 weeks

4 weeks prior

JIRA Sanitization/Publish RElease Notes

Sanitize release documentation

Create release notes and email community release information with links.


2 weeks prior

Vote

Create artifacts, sign release, etc. Open up votes

1 week prior

Release

Tally up votes, announce, update websites and infrastructure with new
release artifacts.

Release date




On Sun, Feb 11, 2018 at 7:40 AM, Ed Cable  wrote:

> Hi all,
>
> This meeting is happening now for anybody that wants to join.
>
> Ed
>
> On Sat, Feb 10, 2018 at 6:07 AM, Ed Cable  wrote:
>
>> Hi all
>>
>> Woule 1530GMT work on Sunday? Nazeer had a conflict on Saturday. I'll
>> update the GoToTraining session.
>>
>> Ed
>>
>> On Thu, Feb 8, 2018 at 9:19 AM, Sendoro Juma 
>> wrote:
>>
>>> Hello Ed,
>>>
>>> Just in case, same Saturday(s) but starting 15:30GMT!
>>>
>>> if it is fine with Nazeer, then we will very much appreciate...
>>>
>>> Sorry our request is based on the fact on belief/religious related!
>>>
>>> Cheers
>>> Sendoro
>>>
>>> - Original Message -
>>> From: "Ed Cable" 
>>> To: "dev" 
>>> Cc: "Nazeer Hussain Shaik" 
>>> Sent: Thursday, February 8, 2018 7:05:55 PM
>>> Subject: Re: Meeting to Discuss Release Management Process
>>>
>>> Hmm... We can reschedule to accommodate everyone. Weekdays might be
>>> difficult for Nazeer with his new schedule.
>>>
>>> Ed
>>>
>>> On Thu, Feb 8, 2018 at 7:42 AM, Sendoro Juma 
>>> wrote:
>>>
>>> > Hello Ed,
>>> >
>>> > Hope you will record,
>>> >
>>> > I see two members missing from our side because of that new timing.
>>> >
>>> > Cheers
>>> > Sendoro
>>> >
>>> > - Original Message -
>>> > From: "Ed Cable" 
>>> > To: "dev" 
>>> > Cc: "Nazeer Hussain Shaik" 
>>> > Sent: Thursday, February 8, 2018 5:05:35 PM
>>> > Subject: Re: Meeting to Discuss Release Management Process
>>> >
>>> > Hi all,
>>> >
>>> > Nazeer is not available till Saturday for this meeting so I am going to
>>> > adjust the timing to Saturday at 1400GMT and will update the
>>> GoToTraining
>>> > session accordingly.
>>> >
>>> > Ed
>>> >
>>> > On Thu, Feb 8, 2018 at 6:46 AM, Awasum Yannick <
>>> > awasum.yann...@skylabase.com
>>> > > wrote:
>>> >
>>> > > I already registered for it.
>>> > >
>>> > > I hope it happens.
>>> > >
>>> > > Thanks
>>> > > Awasum
>>> > >
>>> > > On Thu, Feb 8, 2018 at 1:23 PM, Nikhil Pawar 
>>> wrote:
>>> > >
>>> > > > Is this meeting happening?
>>> > > > I’ll be interested to participate.
>>> > > >
>>> > > > Regards,
>>> > > > Nikhil
>>> > > >
>>> > > > On Wed, Feb 7, 2018 at 10:54 AM Ed Cable 
>>> wrote:
>>> > > >
>>> > > > > Nazeer,
>>> > > > >
>>> > > > > Per the other email thread, we'd like to set up a meeting to both
>>> > > discuss
>>> > > > > and improve our release management process and to transfer
>>> knowledge
>>> > to
>>> > > > > additional Apache Fineract committers who would like to help
>>> with the
>>> > > > > release management process.
>>> > > > >
>>> > > > > Hopefully after this meeting, we'll be able to update our wiki
>>> page
>>> > on
>>> > > > > release management -
>>> > > > > https://cwiki.apache.org/confluence/display/FINERACT/
>>> > > Release+Management
>>> > > > > -  with these processes and have an expanded team of releas