TODO Auto-generated method stub in journalentry

2019-11-21 Thread Yemdjih Kaze Nasser 
I came accross this TODO in CashBasedAccountingProcessorForLoan.java

and
I would like to know what is expected to be done there or if it has already
been done

Re: Error when enabling portfolio__v1__khepri during provisioning.

2019-11-21 Thread Courage Angeh 
Hi Juhan,

Yea I made sure the services are registered on Eureka. Actually Steps 01 to
07.021 completed successfully just step 07.022 produces an error.

When you look at the logs it shows that it is a JDBC data source connection
error so I am thinking it has to be related to database configuration.
Can I see your logs for portfolio after completing step 07.022 and the
description of your fineract cn portfolio container?

P.S: I get this same error when using the bash scripts and the postman
scripts.

Regards,
Courage.

On Wed, Nov 20, 2019 at 1:59 AM Juhan Aasaru  wrote:

> Hi Courage!
>
> I tried myself and in order to have a repeatable process I created (and
> merged with few minor fixes)
>
> https://github.com/apache/fineract-cn-docker-compose/blob/master/integration_test.sh
> I didn't manage yet to complete this however as for some reason the Docker
> engine started
> failing locally when I tried to provision everything. I try to look more
> into this in coming days.
> So unfortunately I couldn't yet repeat your problem.
>
> The "portfolio__v1__khepri permission" error suggests that not all the
> micro services are registered with Eureka.
> If a micro service wants to connect to other micro service it asks Eureka
> for the IP/DNS of the other micro service.
> Open up Eureka console at http://localhost:8761/ (or http://eureka:8761)
> and check which micro-services are registered. All micro services except
> provisioner should be there.
>
> Also I have had this error when the provisioning scripts used
> wrong hostname for micro services.
> So for Postman scripts see steps 02.01, 02.02... for the body of the
> scripts as it contains the host of the micro service.
>
> I don't have any ideas about why Flyway is failing.
>
> Juhan
>
> Kontakt Courage Angeh () kirjutas kuupäeval T,
> 19. november 2019 kell 18:21:
>
>> Yea, Juhan.
>> I am using the latest docker images created 4 weeks ago.
>>
>> On Tue, Nov 19, 2019 at 2:52 AM Juhan Aasaru  wrote:
>>
>>> Hi Courage!
>>>
>>> Did you force Docker Compose to pull the latest images from repository?
>>>
>>> docker-compose rm -f
>>> docker-compose pull
>>>
>>> Kind regards
>>> Juhan
>>>
>>> Kontakt Courage Angeh () kirjutas kuupäeval E,
>>> 18. november 2019 kell 19:34:
>>>
 Hi Juhan,

 I am trying to do some updates to the fineract-cn-docker-compose bash
 scripts. Uhmm... I tried to enable portfolio__v1__khepri permission
 but I get this error
 `Error while processing command. FlywayException: Unable to obtain Jdbc
 connection from DataSource`

 I also tried it using the postman scripts you implemented I get the
 same error.
 I am not sure what is wrong. Here is the log file:
 https://pastebin.com/11vRW2wC for more information.

 P.S I made no changes to the docker configurations.

 Regards,
 Courage.

>>>

Re: White Paper: Global Perspective on Real-Time Payments Systems from Google Pay

2019-11-21 Thread Victor Romero 


 
 
  
   Thanks Ed,
  
  
   
  
  
   It is a very good document, e.g. the QR experience in Mexico provided by CoDi,  which has been deployed by the Central Bank (Banxico) is a very strong  challenger for the other Payment Gateways and RTP, because the fee is zero and the seller has immediately the money of the selling.
  
  
   
  
  
   Regards
  
  
   
  
  
   Victor
  
  
   El 20 de noviembre de 2019 a las 04:52 PM Ed Cable  escribió: 
   
   
   
I thought the community would benefit from reading this white paper from Google

 


 Download it from  
 https://pay.google.com/about/business/resources/ or directly from this link:  
 https://pay.google.com/about/business/static/data/GPay_RTP_2019.pdf


 


 Hat tip to  
 @Karim Jindani for sharing.


 Ed


 

   
  
  
    

Fineract 1.x Spring Boot 2.1.7 Upgrade Re: Status of Merging Pull Requests 642 and 649

2019-11-21 Thread Awasum Yannick 
Hi All,

We now have Travis passing again for
https://github.com/apache/fineract/pull/642

This is ready to go, I think.

One thing I have not done is to test the security aspect to make sure the
upgrade to spring boot 2.1.7 has not caused any problems.

Please, will a few people help to test the PR locally, especially the
spring security side of things. Probably by end of day or tomorrow, I will
merge the PR and if there are any subsequent issues, we can fix in the
coming days and weeks.

This is critical for Fineract 1.x, we have always been using spring boot
1.2 (Spring 4.x). This new PR upgrades Fineract 1.x to Spring Boot 2.1.7
(Spring 5.x). This is a major change and I encourage more people to test
this.

Thanks.
Awasum

On Thu, Nov 21, 2019 at 12:37 PM Awasum Yannick  wrote:

> Hi Ivan,
>
>
>
> On Thu, Nov 21, 2019 at 10:26 AM Ivan Bondarenko 
> wrote:
>
>> Hi, Ed, Awasum, All
>>
>> 1) My tests are passing locally, I have ran it many times.
>> 2) My local machine has really powerful configuration. I think there is
>> some race conditions in the integration tests that cause the random test
>> fail.
>>
>
> I noticed this. Even on Travis you see some Optimistic locking problems
> once in  a while. Maybe an issue should be created for this?
>
>
>> 3) Awasum, I have just connected mifos-comunity app to the upgraded
>> version of the back-endand it works fine.
>> Do you use basic auth mode? If not please update the code. I have just
>> committed fix for oauth config, hope it helps.
>> If you use basic - could you confirm that
>> `V353__migrate_passwords_to_ss_5.sql` was executed on startup?
>>
>
> Yes,..I missed this..I was using my old DB for testing which had flyway
> versions above 353 and so could not log in. I used a clean DB now and i can
> login from UI. Thanks Ivan.
>
>
>> PS: Unfortunately I have found that integration tests have bugs and some
>> critical cases are not covered, examples :
>> 1) As I can see
>> `HookIntegrationTest.shouldSendOfficeCreationNotification` will pas in any
>> case, it has no assertions(just "sout" logging)
>> 2) I can't find tests with oauth config
>> 3) Can't find test for documents and image uploads
>> 4) I think there is some race conditions on job execution and job's
>> status checks in integration tests. (I hope get it wrong)
>>
>> I will create jira issues for found problems, but a little bit later. (If
>> someone confirm the described issues it would be really helpfull)
>>
>
> You are right on all the above. Go ahead and create issues on Jira for
> these.
>
> Thanks for your contributions and patience, Ivan.
>
> чт, 21 нояб. 2019 г. в 09:51, Awasum Yannick :
>>
>>> Hi All,
>>>
>>> I left some review comments here:
>>> https://github.com/apache/fineract/pull/642#issuecomment-556962459
>>> on why Travis is failing and also problems when connecting the front end
>>> to the upgraded (Spring 5.x) Fineract branch/PR.
>>>
>>> Any ideas?
>>>
>>> On Wed, Nov 20, 2019 at 11:18 PM Ed Cable  wrote:
>>>
 Hi all,

 I just wanted to follow up on this as we're trying to wrap up the 1.4
 release and bring it to a vote.

 Ed

 On Fri, Nov 15, 2019 at 12:01 PM Ed Cable  wrote:

> Michael and Ivan,
>
> So we can ship the 1.4 release on time, I wanted to inquire about the
> status of merging https://github.com/apache/fineract/pull/642
>
> Is there anything blocking it? It looks like Ivan's test are passing
> locally but the build is still failing.
>
> Once that's merged, I believe we can then merge
> https://github.com/apache/fineract/pull/649
>
> THanks,
>
> Ed
>
>

 --
 *Ed Cable*
 President/CEO, Mifos Initiative
 edca...@mifos.org | Skype: edcable | Mobile: +1.484.477.8649

 *Collectively Creating a World of 3 Billion Maries | *http://mifos.org

Re: Status of Merging Pull Requests 642 and 649

2019-11-21 Thread Awasum Yannick 
Hi Ivan,



On Thu, Nov 21, 2019 at 10:26 AM Ivan Bondarenko  wrote:

> Hi, Ed, Awasum, All
>
> 1) My tests are passing locally, I have ran it many times.
> 2) My local machine has really powerful configuration. I think there is
> some race conditions in the integration tests that cause the random test
> fail.
>

I noticed this. Even on Travis you see some Optimistic locking problems
once in  a while. Maybe an issue should be created for this?


> 3) Awasum, I have just connected mifos-comunity app to the upgraded
> version of the back-endand it works fine.
> Do you use basic auth mode? If not please update the code. I have just
> committed fix for oauth config, hope it helps.
> If you use basic - could you confirm that
> `V353__migrate_passwords_to_ss_5.sql` was executed on startup?
>

Yes,..I missed this..I was using my old DB for testing which had flyway
versions above 353 and so could not log in. I used a clean DB now and i can
login from UI. Thanks Ivan.


> PS: Unfortunately I have found that integration tests have bugs and some
> critical cases are not covered, examples :
> 1) As I can see `HookIntegrationTest.shouldSendOfficeCreationNotification`
> will pas in any case, it has no assertions(just "sout" logging)
> 2) I can't find tests with oauth config
> 3) Can't find test for documents and image uploads
> 4) I think there is some race conditions on job execution and job's status
> checks in integration tests. (I hope get it wrong)
>
> I will create jira issues for found problems, but a little bit later. (If
> someone confirm the described issues it would be really helpfull)
>

You are right on all the above. Go ahead and create issues on Jira for
these.

Thanks for your contributions and patience, Ivan.

чт, 21 нояб. 2019 г. в 09:51, Awasum Yannick :
>
>> Hi All,
>>
>> I left some review comments here:
>> https://github.com/apache/fineract/pull/642#issuecomment-556962459
>> on why Travis is failing and also problems when connecting the front end
>> to the upgraded (Spring 5.x) Fineract branch/PR.
>>
>> Any ideas?
>>
>> On Wed, Nov 20, 2019 at 11:18 PM Ed Cable  wrote:
>>
>>> Hi all,
>>>
>>> I just wanted to follow up on this as we're trying to wrap up the 1.4
>>> release and bring it to a vote.
>>>
>>> Ed
>>>
>>> On Fri, Nov 15, 2019 at 12:01 PM Ed Cable  wrote:
>>>
 Michael and Ivan,

 So we can ship the 1.4 release on time, I wanted to inquire about the
 status of merging https://github.com/apache/fineract/pull/642

 Is there anything blocking it? It looks like Ivan's test are passing
 locally but the build is still failing.

 Once that's merged, I believe we can then merge
 https://github.com/apache/fineract/pull/649

 THanks,

 Ed


>>>
>>> --
>>> *Ed Cable*
>>> President/CEO, Mifos Initiative
>>> edca...@mifos.org | Skype: edcable | Mobile: +1.484.477.8649
>>>
>>> *Collectively Creating a World of 3 Billion Maries | *http://mifos.org
>>>   
>>>
>>>

Re: White Paper: Global Perspective on Real-Time Payments Systems from Google Pay

2019-11-21 Thread Edmore Tshuma 
Thanks Ed

On Thu, Nov 21, 2019 at 12:53 AM Ed Cable  wrote:

> I thought the community would benefit from reading this white paper from
> Google
>
> Download it from https://pay.google.com/about/business/resources/ or
> directly from this link:
> https://pay.google.com/about/business/static/data/GPay_RTP_2019.pdf
>
> Hat tip to @Karim Jindani  for sharing.
>
> Ed
>
>