[jira] [Commented] (FINERACT-72) Speed up the retrieval of journal entries when "transactionDetails" is set to true

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/FINERACT-72?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15418350#comment-15418350
 ] 

ASF GitHub Bot commented on FINERACT-72:


Github user nazeer1100126 commented on a diff in the pull request:

https://github.com/apache/incubator-fineract/pull/199#discussion_r74540171
  
--- Diff: 
fineract-provider/src/main/java/org/apache/fineract/accounting/journalentry/service/AccountingProcessorHelper.java
 ---
@@ -909,12 +911,13 @@ private void createDebitJournalEntryForSavings(final 
Office office, final String
 LoanTransaction loanTransaction = null;
 SavingsAccountTransaction savingsAccountTransaction = null;
 ClientTransaction clientTransaction = null;
-final PaymentDetail paymentDetail = null;
+PaymentDetail paymentDetail = null;
 final Long shareTransactionId = null;
 String modifiedTransactionId = transactionId;
 if (StringUtils.isNumeric(transactionId)) {
 long id = Long.parseLong(transactionId);
 savingsAccountTransaction = 
this.savingsAccountTransactionRepository.findOne(id);
+paymentDetail = 
this.savingsAccountTransactionRepository.findOne(id).getPaymentDetail();
--- End diff --

unnecessary repository call. You can make use of savingsAccountTransaction 
object to retrieve payment details 


> Speed up the retrieval of journal entries when "transactionDetails" is set to 
> true
> --
>
> Key: FINERACT-72
> URL: https://issues.apache.org/jira/browse/FINERACT-72
> Project: Apache Fineract
>  Issue Type: Improvement
>Reporter: Emmanuel Nnaa
>Assignee: Markus Geiss
>
> It takes a little over 3 minutes to retrieve about 360 journal entries if the 
> "transactionDetails" parameter is set to true.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (FINERACT-65) Implement ability to schedule & e-mail reports

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/FINERACT-65?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15418312#comment-15418312
 ] 

ASF GitHub Bot commented on FINERACT-65:


Github user asfgit closed the pull request at:

https://github.com/apache/incubator-fineract/pull/197


> Implement ability to schedule & e-mail reports
> --
>
> Key: FINERACT-65
> URL: https://issues.apache.org/jira/browse/FINERACT-65
> Project: Apache Fineract
>  Issue Type: New Feature
>Reporter: Emmanuel Nnaa
>Assignee: Markus Geiss
>Priority: Minor
>
> Some reports take a bit longer to run, therefore we should be able to allow 
> our users to schedule them overnight to be e-mailed. 
> The way this should work is:
> - Add e-mailaddress to users and make it mandatory (possibly already in 
> MifosX)
> - Allow users to configure schedule entries which consist of:
> - One or multiple target users (e-mailaddresses)
> - Set the preferred subject and content of the e-mail (Look at user generated 
> documents API in MifosX for replacing certain variables)
> - Choose the run frequency of the report (daily, weekly, every x'th day of 
> the month etc, cron-like flexibility with a UI)
> - Pick the preferred output format (PDF/XLS/CSV)
> These reports should be picked up by a scheduled job overnight and then run 
> in serial to avoid performance hits and sent out to the users.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)