[jira] [Commented] (FINERACT-245) Introduce RAT checks

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/FINERACT-245?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15689254#comment-15689254
 ] 

ASF GitHub Bot commented on FINERACT-245:
-

GitHub user nazeer1100126 opened a pull request:

https://github.com/apache/incubator-fineract/pull/249

Integrating Apache RAT FINERACT-245



You can merge this pull request into a Git repository by running:

$ git pull https://github.com/nazeer1100126/incubator-fineract 
RAT_Integration

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/incubator-fineract/pull/249.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #249


commit e9e3326f5b8ad18586a11f1bf2faa149d6afcacb
Author: Nazeer Hussain Shaik 
Date:   2016-11-23T07:53:13Z

Integrating Apache RAT FINERACT-245




> Introduce RAT checks
> 
>
> Key: FINERACT-245
> URL: https://issues.apache.org/jira/browse/FINERACT-245
> Project: Apache Fineract
>  Issue Type: Task
>Reporter: Myrle Krantz
>Assignee: Shaik Nazeer Hussain
>
> GIVEN a contributor or committer forks the fineract code base, and builds it 
> locally to fix bugs and add features,
> WHEN an apache policy violating library dependency is accidentally introduced 
> to the source code,
> THEN the build fails.
> See https://github.com/apache/incubator-geode/blob/develop/gradle/rat.gradle 
> for an example of how to do this.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Created] (FINERACT-263) "Add Notes" for Centers permission is missing

[Edward Cable (JIRA)]

Edward Cable created FINERACT-263:
-

 Summary: "Add Notes" for Centers permission is missing
 Key: FINERACT-263
 URL: https://issues.apache.org/jira/browse/FINERACT-263
 Project: Apache Fineract
  Issue Type: Bug
Reporter: Edward Cable
Assignee: Markus Geiss
Priority: Minor


Migrated over from https://mifosforge.jira.com/browse/MIFOSX-1080

Original Description:

Now user can add notes to centers with out permissions. Permission should be 
assigned separately for Read, Create, Edit and Delete options. See permissions 
for group for example.

Comments

Shashvat Tripathi Documentation for the notes API can be found at 
https://demo.openmf.org/api-docs/apiLive.htm#notes
>From a microfinance perspective, clients can be aggregated for applying Joint 
>liability principles. Such a collection of clients is called a Group. Some 
>organizations would want to further extend this aggregation, so you have 
>collections of Groups which are called Centers etc.
In Mifosx, Centers were originally modeled as specializations of Groups 
(centers are also stored in m_group table with level_id set to 1, the level_id 
for groups is 2), for easier use through the API though, separate API's were 
created for Centers https://demo.openmf.org/api-docs/apiLive.htm#centers, which 
are mostly abstraction over the Group API with new center specific permissions.
subramanya Talks about now extending notes API to have a center specific 
abstractions (with its own permissions), so we need a new notes api which would 
look like
 centers/{centerId}/notes/{noteId} 
, also the existing group notes API i.e
groups/{groupId}/notes
should no longer work for centers



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Updated] (FINERACT-262) MIFOSX-1060: Holidays declared for head office is not getting applied to the newly attached child offices

[Edward Cable (JIRA)]

 [ 
https://issues.apache.org/jira/browse/FINERACT-262?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Edward Cable updated FINERACT-262:
--
Summary: MIFOSX-1060: Holidays declared for head office is not getting 
applied to the newly attached child offices  (was: MIFOSX-1060: Holidays 
declared for organization is not getting applied to the newly attached child 
offices.)

> MIFOSX-1060: Holidays declared for head office is not getting applied to the 
> newly attached child offices
> -
>
> Key: FINERACT-262
> URL: https://issues.apache.org/jira/browse/FINERACT-262
> Project: Apache Fineract
>  Issue Type: Bug
>Reporter: Edward Cable
>Assignee: Markus Geiss
>Priority: Minor
>  Labels: fineract-gci
>
> Migrated over from MifosForge at 
> https://mifosforge.jira.com/browse/MIFOSX-1060
> Original description:
> 1.Create holiday under Head office and activate it.
> 2. Create a child office under that head office.
> 3. Click on the Administration -> Organization -> Manage Holidays - in which 
> select the above created child office from the dropdown, - no holidays are 
> displaying under that office.
> Ideally if in the organization level (or head office) any holiday is declared 
> then it should affect the child offices which are attached newly even after 
> declaring the holiday.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Updated] (FINERACT-261) Validate that a GL account isn't attached to a product before setting to disabled

[Edward Cable (JIRA)]

 [ 
https://issues.apache.org/jira/browse/FINERACT-261?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Edward Cable updated FINERACT-261:
--
Attachment: Screen Shot 2016-11-22 at 4.23.15 PM.png
Screen Shot 2016-11-22 at 4.23.07 PM.png
Screen Shot 2016-11-22 at 4.22.56 PM.png

> Validate that a GL account isn't attached to a product before setting to 
> disabled 
> --
>
> Key: FINERACT-261
> URL: https://issues.apache.org/jira/browse/FINERACT-261
> Project: Apache Fineract
>  Issue Type: Bug
>Reporter: Edward Cable
>Assignee: Markus Geiss
>Priority: Minor
>  Labels: fineract-gci
> Attachments: Screen Shot 2016-11-22 at 4.22.56 PM.png, Screen Shot 
> 2016-11-22 at 4.23.07 PM.png, Screen Shot 2016-11-22 at 4.23.15 PM.png
>
>
> As reported by [~andrew.dzak] at 
> https://mifosforge.jira.com/browse/MIFOSX-1045
> Original description:
> "when editing gl accounts to "disabled" there should be a validation, to 
> check if the gl account been edited is attached to a product".
> Steps to reproduce:
> 1. Create a loan or savings product and attach a GL account to that product.
> 2. Go into chart of accounts and edit the GL account you added to the product 
> and set it to disabled. 
> 3. Try and disburse a loan from that product.
> The loan is still able to disbursed even though the attached GL account is 
> disabled.
> Validation should be in place to prevent a user from disabling a GL account 
> that is attached to a product and providing the proper error message. 



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Created] (FINERACT-262) MIFOSX-1060: Holidays declared for organization is not getting applied to the newly attached child offices.

[Edward Cable (JIRA)]

Edward Cable created FINERACT-262:
-

 Summary: MIFOSX-1060: Holidays declared for organization is not 
getting applied to the newly attached child offices.
 Key: FINERACT-262
 URL: https://issues.apache.org/jira/browse/FINERACT-262
 Project: Apache Fineract
  Issue Type: Bug
Reporter: Edward Cable
Assignee: Markus Geiss
Priority: Minor


Migrated over from MifosForge at https://mifosforge.jira.com/browse/MIFOSX-1060

Original description:

1.Create holiday under Head office and activate it.
2. Create a child office under that head office.
3. Click on the Administration -> Organization -> Manage Holidays - in which 
select the above created child office from the dropdown, - no holidays are 
displaying under that office.

Ideally if in the organization level (or head office) any holiday is declared 
then it should affect the child offices which are attached newly even after 
declaring the holiday.





--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Updated] (FINERACT-261) Validate that a GL account isn't attached to a product before setting to disabled

[Edward Cable (JIRA)]

 [ 
https://issues.apache.org/jira/browse/FINERACT-261?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Edward Cable updated FINERACT-261:
--
Labels: fineract-gci  (was: )

> Validate that a GL account isn't attached to a product before setting to 
> disabled 
> --
>
> Key: FINERACT-261
> URL: https://issues.apache.org/jira/browse/FINERACT-261
> Project: Apache Fineract
>  Issue Type: Bug
>Reporter: Edward Cable
>Assignee: Markus Geiss
>Priority: Minor
>  Labels: fineract-gci
>
> As reported by [~andrew.dzak] at 
> https://mifosforge.jira.com/browse/MIFOSX-1045
> Original description:
> "when editing gl accounts to "disabled" there should be a validation, to 
> check if the gl account been edited is attached to a product".
> Steps to reproduce:
> 1. Create a loan or savings product and attach a GL account to that product.
> 2. Go into chart of accounts and edit the GL account you added to the product 
> and set it to disabled. 
> 3. Try and disburse a loan from that product.
> The loan is still able to disbursed even though the attached GL account is 
> disabled.
> Validation should be in place to prevent a user from disabling a GL account 
> that is attached to a product and providing the proper error message. 



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Created] (FINERACT-261) Validate that a GL account isn't attached to a product before setting to disabled

[Edward Cable (JIRA)]

Edward Cable created FINERACT-261:
-

 Summary: Validate that a GL account isn't attached to a product 
before setting to disabled 
 Key: FINERACT-261
 URL: https://issues.apache.org/jira/browse/FINERACT-261
 Project: Apache Fineract
  Issue Type: Bug
Reporter: Edward Cable
Assignee: Markus Geiss
Priority: Minor


As reported by [~andrew.dzak] at https://mifosforge.jira.com/browse/MIFOSX-1045

Original description:
"when editing gl accounts to "disabled" there should be a validation, to check 
if the gl account been edited is attached to a product".

Steps to reproduce:

1. Create a loan or savings product and attach a GL account to that product.
2. Go into chart of accounts and edit the GL account you added to the product 
and set it to disabled. 
3. Try and disburse a loan from that product.

The loan is still able to disbursed even though the attached GL account is 
disabled.

Validation should be in place to prevent a user from disabling a GL account 
that is attached to a product and providing the proper error message. 



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Updated] (FINERACT-260) Validation need to be added if the client charge is applied before client activation date

[Edward Cable (JIRA)]

 [ 
https://issues.apache.org/jira/browse/FINERACT-260?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Edward Cable updated FINERACT-260:
--
Attachment: Screen Shot 2016-11-22 at 3.21.31 PM.png

> Validation need to be added if the client charge is applied before client 
> activation date
> -
>
> Key: FINERACT-260
> URL: https://issues.apache.org/jira/browse/FINERACT-260
> Project: Apache Fineract
>  Issue Type: Bug
>Reporter: Edward Cable
>Assignee: Markus Geiss
>Priority: Minor
> Attachments: Screen Shot 2016-11-22 at 3.21.31 PM.png
>
>
> Migrated over from MifosForge.
> Original Description:
> If the client activation date is on 01 June 2016 and the charge for a client 
> is getting applied before that date then validation need to be added, and 
> proper error message should get displayed
> Steps to Reproduce
> 1. Add a client charge, select a due date prior to client activation date. 
> 2. Submit and it successfully goes through.
> Expected Behavior
> 1. Upon submission of charge with a due date prior to activation date of the 
> client, a proper error message should be displayed stating that the the 
> charge due date is before the client activation date. 
> See https://demo3.openmf.org/#/viewclient/10 for an example. 



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Created] (FINERACT-260) Validation need to be added if the client charge is applied before client activation date

[Edward Cable (JIRA)]

Edward Cable created FINERACT-260:
-

 Summary: Validation need to be added if the client charge is 
applied before client activation date
 Key: FINERACT-260
 URL: https://issues.apache.org/jira/browse/FINERACT-260
 Project: Apache Fineract
  Issue Type: Bug
Reporter: Edward Cable
Assignee: Markus Geiss
Priority: Minor


Migrated over from MifosForge.

Original Description:

If the client activation date is on 01 June 2016 and the charge for a client is 
getting applied before that date then validation need to be added, and proper 
error message should get displayed

Steps to Reproduce
1. Add a client charge, select a due date prior to client activation date. 
2. Submit and it successfully goes through.

Expected Behavior
1. Upon submission of charge with a due date prior to activation date of the 
client, a proper error message should be displayed stating that the the charge 
due date is before the client activation date. 

See https://demo3.openmf.org/#/viewclient/10 for an example. 



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Updated] (FINERACT-259) Repaid every setting can't be edited without restarting loan application

[Edward Cable (JIRA)]

 [ 
https://issues.apache.org/jira/browse/FINERACT-259?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Edward Cable updated FINERACT-259:
--
Attachment: Screen Shot 2016-11-22 at 9.08.28 AM.png

> Repaid every setting can't be edited without restarting loan application
> 
>
> Key: FINERACT-259
> URL: https://issues.apache.org/jira/browse/FINERACT-259
> Project: Apache Fineract
>  Issue Type: Bug
> Environment: https://demo3.openmf.org
>Reporter: Edward Cable
>Assignee: Markus Geiss
> Attachments: Screen Shot 2016-11-22 at 9.08.28 AM.png
>
>
> When attempting to create a new loan account (an instance of a loan product), 
> when you modify the repaid every setting from monthly to weekly and then 
> switch back to weekly, it still retains monthly setting and can't be 
> submitted. 
> Steps to Reproduce
> 1. Navigate to Allen E Client
> 2. Add new Loan Account
> 3. Fill out parameters
> 4. Modify Repaid every by changing it from weeks to months and then specify 
> fourth Wednesday of the month.
> 5. Revert this change by switching repaid every back to 1 weeks
> 6. Click Submit
> Error message gets displayed saying frequency day of week type must be 
> provided when frequency nth day type is fourth.
> See attached screenshot.
> The loan form seems to think repaid monthly is still selected even though 
> it's repaid weekly. The only way to submit the loan would be to start over 
> the loan application from scratch. 



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Created] (FINERACT-259) Repaid every setting can't be edited without restarting loan application

[Edward Cable (JIRA)]

Edward Cable created FINERACT-259:
-

 Summary: Repaid every setting can't be edited without restarting 
loan application
 Key: FINERACT-259
 URL: https://issues.apache.org/jira/browse/FINERACT-259
 Project: Apache Fineract
  Issue Type: Bug
 Environment: https://demo3.openmf.org
Reporter: Edward Cable
Assignee: Markus Geiss


When attempting to create a new loan account (an instance of a loan product), 
when you modify the repaid every setting from monthly to weekly and then switch 
back to weekly, it still retains monthly setting and can't be submitted. 

Steps to Reproduce

1. Navigate to Allen E Client
2. Add new Loan Account
3. Fill out parameters
4. Modify Repaid every by changing it from weeks to months and then specify 
fourth Wednesday of the month.
5. Revert this change by switching repaid every back to 1 weeks
6. Click Submit

Error message gets displayed saying frequency day of week type must be provided 
when frequency nth day type is fourth.

See attached screenshot.

The loan form seems to think repaid monthly is still selected even though it's 
repaid weekly. The only way to submit the loan would be to start over the loan 
application from scratch. 



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Assigned] (FINERACT-245) Introduce RAT checks

[Shaik Nazeer Hussain (JIRA)]

 [ 
https://issues.apache.org/jira/browse/FINERACT-245?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Shaik Nazeer Hussain reassigned FINERACT-245:
-

Assignee: Shaik Nazeer Hussain  (was: Markus Geiss)

> Introduce RAT checks
> 
>
> Key: FINERACT-245
> URL: https://issues.apache.org/jira/browse/FINERACT-245
> Project: Apache Fineract
>  Issue Type: Task
>Reporter: Myrle Krantz
>Assignee: Shaik Nazeer Hussain
>
> GIVEN a contributor or committer forks the fineract code base, and builds it 
> locally to fix bugs and add features,
> WHEN an apache policy violating library dependency is accidentally introduced 
> to the source code,
> THEN the build fails.
> See https://github.com/apache/incubator-geode/blob/develop/gradle/rat.gradle 
> for an example of how to do this.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[MENTORS] Managing non-Apache code from ASF resources?

[Myrle Krantz]

Hi Mentors,

As you know Apache Fineract has a UI project which Mifos did not donate to
the ASF because it's not licensable in the way the ASF requires.  This has
been a major communication challenge.  We've split the communication across
two lists, even though newbies don't understand the difference between the
UI and the backend code, and even though many discussions impact both.

At the ApacheCon I was asked if we have any volunteer opportunites for
non-techies.  Mifos does, and among those are translations or documentation
which are definitely more prevalent in the UI.

So here's the question (s): Is there any objection to us creating tickets
for non-Apache code in the Apache's Jira, or moving documentation of the UI
to Apache's Confluence? Is there any reason we should be careful about
having discussions about the UI on the Apache mailing list?

Because if we could move these kinds of communications into one channel,
instead of the two it currently is split between, it might help alleviate
some of the confusion...

Greets,
Myrle


*Myrle Krantz*
Solutions Architect
RɅĐɅЯ, The Mifos Initiative
mkra...@mifos.org | Skype: mkrantz.mifos.org | http://mifos.org
  

Re: Speaker's notes from the Shark Tank ApacheCon EU

[Sander van der Heyden]

Hi Myrle,

Looks like you had a busy week with the presentations! I think you hit the
nail on the head with the feedback, from my side I think re-engaging the
community will be most important point here. I definitely think the past
year or so there has been a lot of confusion amongst the community.
Obviously of MifosX vs Fineract, where do people feel they 'belong', but
also on the confusion of Gen 2 vs Gen 3 and how that linked to the
projects. While it is clear to us, and presumably to Conflux as well it is
something that still seems to need more clarification. Once the community
become more active and cohesive again I would say we are in a much better
position for graduation.

S





Sander van der Heyden

CTO Musoni Services




Mobile (NL): +31 (0)6 14239505
Skype: s.vdheyden
Website: musonisystem.com
Follow us on Twitter!  
Postal address: Hillegomstraat 12-14, office 0.09, 1058 LS, Amsterdam,
The Netherlands

On 21 November 2016 at 15:19, Myrle Krantz  wrote:

> Hi all,
>
> On Friday I gave a five minute presentation to the incubation Shark Tank.
> The idea behind the shark tank is to take a critical look in public at
> whether a podling is ready for graduation.  Here are the notes I used to
> prepare for this short presentation:
>
> https://cwiki.apache.org/confluence/display/FINERACT/Shark+Tank+Notes
>
> You'll note that at the end, I included some of the things I felt we needed
> to improve/complete before we can call ourselves a mature project.
>
> What do you, the Apache Fineract developers, feel is left to do?
>
> Greets,
> Myrle
>
>
> *Myrle Krantz*
> Solutions Architect
> RɅĐɅЯ, The Mifos Initiative
> mkra...@mifos.org | Skype: mkrantz.mifos.org | http://mifos.org
>   
>