Re: [FlexJS] Summary of Changes
Yes. I think the problem is that the size is not being set. > On Mar 27, 2017, at 11:58 PM, Alex Harui wrote: > > For #2, again, what does the DOM look like? Did the margins get set > properly?
Re: [FlexJS] Anyone working on the build problems?
Yes, after the Maven build failed, I saw that the other MXML tests were excluded, and I excluded my new ones in the same place. The Maven side has no problems with my changes anymore. Just gotta tweak the Ant build a bit. If we find the time to come up with better tests in Miami, that would be cool. I have some ideas for how to run my new tests without the asjs dependency. Basically, it involves creating a couple of custom AS/MXML classes to reference in MXML instead of real components from the framework. The exact classes referenced in MXML don't matter for my tests. It was simply convenient to follow the patterns of the existing tests to get it written quickly. These custom classes could probably be used to improve some of those other tests too. - Josh On Mar 27, 2017 1:04 PM, "Christofer Dutz" wrote: Hi Josh, I guess in that case it was one of the tests which I excluded from the Maven build … so if you add another it will automatically be run, as Maven doesn’t know it should exclude it. If you have a look in the pom.xml you will see the surefire plugin (runs unit tests) and the failsafe plugin (runs integration tests). Here a hand full of tests are excluded because they need a refactoring to not introduce a cycle or need to be moved to the framework module (I would prefer the first option) Guess it would be cool if we figured out a way to refactor the tests so we can run them in Maven … eventually doing so over a beer in Miami would be a good invest of time? What do you think ;-) Chris Am 27.03.17, 17:43 schrieb "Josh Tynjala" : I didn't structure the tests this way. I followed the existing tests that were already there. - Josh On Mar 27, 2017 1:04 AM, "Christofer Dutz" wrote: > Hi Josh, > > Tests shouldn’t require a directory structure … especially not outside of > the current maven modules directory. This type of refactoring is what > consumed most of my time while migrating Falcon from Ant to Maven. Having a > look at the current problem, it seems the problems are related to its > dependency to FlexJSTestBase, which seems to require a set of environment > variables and expects other directories. This dependency to framework would > have introduced a cycle, which is also the reason I couldn’t refactor the > tests without completely re-writing most of them. > > We should address the FlexJsTestBase tests and make sure we are able to > test what they should be testing without introducing a cyclic dependency. > > For now, excluding them from the testsuite is probably the best option. > > Chris > > > Am 26.03.17, 23:19 schrieb "Josh Tynjala" : > > 1. I don't think this part is actually an issue (other than being > annoying > noise in the output). I also see this warning and my build finishes > successfully. > > 2/3. I think these new tests that I wrote rely on flex-asjs in some way > (since they're parsing MXML), and maybe it's having trouble finding > that > project on your machine. I'll see if I can move them to the correct > part of > the build where it runs the optional "dependent" tests. > > - Josh > > On Sun, Mar 26, 2017 at 1:53 PM, Harbs wrote: > > > There seemed to be three things causing me build problems: > > 1. compiler-jx/src/test/java/org/apache/flex/compiler/internal/ > test/FlexJSTestBase.java > > A reference to frameworks/as/basic-manifest.xml which does not seem > to > > exist. > > 2. compiler-jx/src/test/java/org/apache/flex/compiler/internal/ > > codegen/mxml/sourcemaps/TestSourceMapMXMLScript.java The tests are > > failing. > > 3. compiler-jx/src/test/java/org/apache/flex/compiler/internal/ > > codegen/mxml/sourcemaps/TestSourceMapMXMLEvents.java The tests are > > failing. > > > > Removing the test in 1 and the latter two files allowed Falcon and > asjs to > > build on my machine. > > > > Harbs > > > > > On Mar 26, 2017, at 11:26 PM, Harbs wrote: > > > > > > I’m also having trouble building, but it’s failing at a totally > > different place. > > > > > >> On Mar 26, 2017, at 11:08 PM, piotrz < piotrzarzyck...@gmail.com> > wrote: > > >> > > >> Hi Harbs, > > >> > > >> This is stack trace is straight from jenkins build. > > >> > > >> Locally I have same fail and definitely I did build with fresh > sources > > of > > >> Falcon. > > >> > > >> Piotr > > >> > > >> > > >> > > >> - > > >> Apache Flex PMC > > >> piotrzarzyck...@gmail.com > > >> -- > > >> View this message in context: http://apache-flex- > > development.247.n4.nabb
Re: [FlexJS] Summary of Changes
I've just done a sweep through one project fixing our 'borked' stuff, I guess the latest change might re-'bork' some of the fixes, but I think at least these changes should be easier to address. Sometimes I needed to swap a Container to a Group and other times not, because of the relative/absolute changes. I found it easier to migrate a lot of the layout stuff to pure css for now using flexbox, thinking that doing so might insulate us from further changes in the coded layout support. We would have the ability to swap back to beads etc later if we want to have that in the mxml, once things have become stable. On Tue, Mar 28, 2017 at 9:52 AM, Peter Ent wrote: > Does the HTML look OK - the structure. Is there anything missing? You > should see a simplified nesting of DIVs. If that's the case, then maybe > there is more work to do with the layouts. > > The topmost Container, outer controls, doesn't look like it has a layout, > so with Container that should default to BasicLayout. That's one thing to > check. > > Does the Container with id scrollContainer have a parent somewhere with a > fixed width and height? The auto margins should still work for HTML. > Mostly the work is on the SWF side; the JS code was "cleaned up" so maybe > that's the problem. I took out much of the algorithmic code for Vertical > and Horizontal layout since I believe HTML would respond property to the > addition of children, removal of children, resizing, etc. I did have, if I > remember correctly, to add "white-space:nowrap" to the HorizontalLayout; I > don't know that will affect you. > > Would you mind tinker with the HTML DOM in the browser to see if you can > get the look you want? That will help determine if the layout code needs > to be adjusted. > > Thanks and so sorry for the problems. *must use feature branch next time* > —peter > > On 3/27/17, 4:35 PM, "Harbs" wrote: > > >Better, but I still have some problems (there’s probably more): > > > > > > > >backgroundColor="0x44"/> > > > > > > > >marginLeft="auto" marginRight="auto"/> > > > > > > > > > >>click="undo_clickHandler(event)" id="undoButton" > >src="assets/images/icons/0726-undo.svg"> > > > > > > > > > >>click="redo_clickHandler(event)" id="redoButton" > >src="assets/images/icons/0727-redo.svg"> > > > > > > > > > >>click="zoomin_clickHandler(event)" > >src="assets/images/icons/0806-zoom-in.svg"/> > >>click="zoomout_clickHandler(event)" > >src="assets/images/icons/0807-zoom-out.svg"/> > >>click="fitButton_clickHandler(event)" > >src="assets/images/icons/0843-expand.svg"/> > >>click="previewButton_clickHandler(event)" > >src="assets/images/icons/0786-file-preview-white.svg"/> > > > >>click="finishButton_clickHandler()" > >src="assets/images/icons/0821-check.svg"/> > > > >>click="cancelButton_clickHandler()" > >src="assets/images/icons/0822-cross2.svg"/> > > > > > >1. This used to create a centered group of buttons. Now, the container > >has a height of 0 and the buttons don’t show up. > > > >2. > >id="scrollContainer" > >width="100%" height="100%"> > > > > > > > >id="designContainer" > >className="_holder" y="0"> > > > > > > > > > > > > > > > > >This used to create a scrolling div that was centered in the the window. > >It now is aligned left, and I don’t know if it scrolls. > > > >There’s other issues, and I’ll see tomorrow what I can work around. > > > >> On Mar 27, 2017, at 11:08 PM, Peter Ent wrote: > >> > >> Hi, > >> > >> I just pushed a change to UIBase to set position="absolute" when > >>setting x > >> or y. I think this is perfectly safe and if someone does set x and y and > >> then tries to use a layout where that would be a conflict, they will get > >>
Re: Cloning rectangles
FWIW, my internal contacts think this issue is fixed in the latest FP 25 beta (build 143 or later). HTH, -Alex On 3/27/17, 10:23 AM, "Dev LFM" wrote: >Hi, > >I end up figuring out a way of validating my rectangles and re-assigning >correct values. I'll definitely change this to other type.. > >Thank you > >2017-03-24 19:02 GMT+00:00 Alex Harui : > >> >> On 3/24/17, 11:46 AM, "Dev LFM" wrote: >> >> >I hope they take it serious, because all "projects" are a >>serialization of >> >an entire class "Project" and posted to server as it is... then our >> >editors >> >/ content generators load that serialized "Project"... it definitely >>saved >> >me a lot of time and gave me piece of mind.. on the other hand not so >>good >> >to port over other frameworks/apps. >> >> OK, but if you go an remove all "import flash.geom.Rectangle" from your >> data objects and replace it with your own Rectangle, it should solve the >> problem not only for now, but make your code more portable to FlexJS. >> >> HTH, >> -Alex >> >>
Re: [FlexJS] Struggling with custom HTML
On 3/27/17, 12:03 AM, "Harbs" wrote: > >My specific problem was caused by the CheckBox component. The way >CheckBox was made, it’s not styleable. Styleable checkboxes require CSS >which hides the default checkbox and creates a pseudo-element which is >styled by CSS to have the desired look. > >I’m working on a panel for InDesign. Generally I’m using Topcoat CSS >because that matches the general styling of InDesign components pretty >closely. This works for most FlexJS components pretty well. Because >FlexJS checkboxes are not styleable, checkboxes are not usable with the >Topcoat CSS. The CSS hides the default checkbox, but the Topcoat one does >not appear because the expected HTML structure is not there. > >I am considering changing Checkbox to have the expected structure or >creating a new “CSSCheckBox” component which has the structure. The >problem I see that there seems to be more than one method of creating CSS >styled checkbox. > >Ultimately, I don’t think using HTML checkboxes is the “FlexJS” way of >making checkboxes. That’s because any styling of checkboxes are hacks. >I’d really like to see our skinning story improve. Flex 3 and Flex 4 had >very good methods for skinning components, and I wish we had a better >platform agnostic skinning story for FlexJS. In the Flat.swc, there is a RadioButton that has a different HTML structure that the Flat theme expects. I don't know what we did for MDL, but I'm pretty sure some of those components have different HTML structures than the Basic versions. IMO, if you want to support TopCoat, start a TopCoat.swc and get the HTML structure you want in there. Basic's CheckBox is meant to be just a thin wrapper over the single HTMLElement. Someday, I hope the Flat set grows into the Bootstrap set and can handle all Bootstrap themes. Again, we are in the business of encapsulating patterns. There is a cost to make a one-size-fits-all or in the case, one-checkbox-that-can-be-styled-any-way-you-want. We should eventually get around to creating such a component set for those who need it, but I think the "optimized" versions will be specific to their main themes. IOW, it will be more efficient to use the MDL set for MDL than have an MDL skin for the skinnable set. So, in my vision of the future there will be a Checkbox in Basic, Flat/Bootstrap, MDL, Topcoat, Jquery, CreateJS and others. Of course, I could be wrong. -Alex
Re: [FlexJS] Summary of Changes
I probably need to examine the new “flex” layouts. Is there a way to have content centered using those? > On Mar 27, 2017, at 11:35 PM, Harbs wrote: > > Better, but I still have some problems (there’s probably more): > > > > > > > >marginRight="auto"/> > > > > >width="30" height="30" click="undo_clickHandler(event)" id="undoButton" > src="assets/images/icons/0726-undo.svg"> > > > > >width="30" height="30" click="redo_clickHandler(event)" id="redoButton" > src="assets/images/icons/0727-redo.svg"> > > > > >width="30" height="30" click="zoomin_clickHandler(event)" > src="assets/images/icons/0806-zoom-in.svg"/> >width="30" height="30" click="zoomout_clickHandler(event)" > src="assets/images/icons/0807-zoom-out.svg"/> >width="30" height="30" click="fitButton_clickHandler(event)" > src="assets/images/icons/0843-expand.svg"/> >width="30" height="30" click="previewButton_clickHandler(event)" > src="assets/images/icons/0786-file-preview-white.svg"/> > >width="30" height="30" click="finishButton_clickHandler()" > src="assets/images/icons/0821-check.svg"/> > >width="30" height="30" click="cancelButton_clickHandler()" > src="assets/images/icons/0822-cross2.svg"/> > > > 1. This used to create a centered group of buttons. Now, the container has a > height of 0 and the buttons don’t show up. > > 2. >id="scrollContainer" width="100%" height="100%"> > > > >id="designContainer" className="_holder" y="0"> > >marginLeft="auto" marginRight="auto"/> > > > > > > This used to create a scrolling div that was centered in the the window. It > now is aligned left, and I don’t know if it scrolls. > > There’s other issues, and I’ll see tomorrow what I can work around. > >> On Mar 27, 2017, at 11:08 PM, Peter Ent wrote: >> >> Hi, >> >> I just pushed a change to UIBase to set position="absolute" when setting x >> or y. I think this is perfectly safe and if someone does set x and y and >> then tries to use a layout where that would be a conflict, they will get >> have to avoid setting those properties. >> >> I figured this would eventually happen. Let's see if this fixes the issue. >> >> —peter >> >> >> On 3/27/17, 2:58 PM, "Harbs" wrote: >> >>> Peter, >>> >>> I just tried loading my app with your changes, and everything is totally >>> borked. We rely a lot on absolute positioning and transformations. >>> >>> We really need the old behavior in some components. >>> >>> Is there any components which work the same as they used to? >>> >>> Harbs >>> On Mar 26, 2017, at 6:55 PM, Peter Ent wrote: For the time being, the Tour main view should have a width and a height: Then in the style section, give everything flex-grow: 1; and it should look better. I think some padding and/or margins might be needed, but I think I have more work do with the layouts. I'll bump getting the tour to the top of the list for this week because I think its nesting of elements is a good test. I think it is just a matter of setting the style values right. HTML structure-wise it looks fine, so that's good. ‹peter On 3/26/17, 11:31 AM, "piotrz" wrote: > Peter, > > I've started to experiment with your new classes in TourJS and I think > I've > achieved some good look, but not everything is working as expected. > > For some reason code of examples has not been loaded properly. If you > could > review my changes and give some feedback, whether I used your new > classes > in > appropriate manner. >>
Re: [FlexJS] Summary of Changes
Does the HTML look OK - the structure. Is there anything missing? You should see a simplified nesting of DIVs. If that's the case, then maybe there is more work to do with the layouts. The topmost Container, outer controls, doesn't look like it has a layout, so with Container that should default to BasicLayout. That's one thing to check. Does the Container with id scrollContainer have a parent somewhere with a fixed width and height? The auto margins should still work for HTML. Mostly the work is on the SWF side; the JS code was "cleaned up" so maybe that's the problem. I took out much of the algorithmic code for Vertical and Horizontal layout since I believe HTML would respond property to the addition of children, removal of children, resizing, etc. I did have, if I remember correctly, to add "white-space:nowrap" to the HorizontalLayout; I don't know that will affect you. Would you mind tinker with the HTML DOM in the browser to see if you can get the look you want? That will help determine if the layout code needs to be adjusted. Thanks and so sorry for the problems. *must use feature branch next time* —peter On 3/27/17, 4:35 PM, "Harbs" wrote: >Better, but I still have some problems (there’s probably more): > > > > > > > >marginRight="auto"/> > > > > >width="30" height="30" >click="undo_clickHandler(event)" id="undoButton" >src="assets/images/icons/0726-undo.svg"> > > > > >width="30" height="30" >click="redo_clickHandler(event)" id="redoButton" >src="assets/images/icons/0727-redo.svg"> > > > > >width="30" height="30" >click="zoomin_clickHandler(event)" >src="assets/images/icons/0806-zoom-in.svg"/> >width="30" height="30" >click="zoomout_clickHandler(event)" >src="assets/images/icons/0807-zoom-out.svg"/> >width="30" height="30" >click="fitButton_clickHandler(event)" >src="assets/images/icons/0843-expand.svg"/> >width="30" height="30" >click="previewButton_clickHandler(event)" >src="assets/images/icons/0786-file-preview-white.svg"/> > >width="30" height="30" >click="finishButton_clickHandler()" >src="assets/images/icons/0821-check.svg"/> > >width="30" height="30" >click="cancelButton_clickHandler()" >src="assets/images/icons/0822-cross2.svg"/> > > >1. This used to create a centered group of buttons. Now, the container >has a height of 0 and the buttons don’t show up. > >2. >id="scrollContainer" >width="100%" height="100%"> > > > >id="designContainer" >className="_holder" y="0"> > >marginLeft="auto" marginRight="auto"/> > > > > > >This used to create a scrolling div that was centered in the the window. >It now is aligned left, and I don’t know if it scrolls. > >There’s other issues, and I’ll see tomorrow what I can work around. > >> On Mar 27, 2017, at 11:08 PM, Peter Ent wrote: >> >> Hi, >> >> I just pushed a change to UIBase to set position="absolute" when >>setting x >> or y. I think this is perfectly safe and if someone does set x and y and >> then tries to use a layout where that would be a conflict, they will get >> have to avoid setting those properties. >> >> I figured this would eventually happen. Let's see if this fixes the >>issue. >> >> —peter >> >> >> On 3/27/17, 2:58 PM, "Harbs" wrote: >> >>> Peter, >>> >>> I just tried loading my app with your changes, and everything is >>>totally >>> borked. We rely a lot on absolute positioning and transformations. >>> >>> We really need the old behavior in some components. >>> >>> Is there any components which work the same as they used to? >>> >>> Harbs >>> On Mar 26, 2017, at 6:55 PM, Peter Ent wrote: For the time being, t
Re: [FlexJS] Summary of Changes
Harbs, For #1, that sounds like a problem with deferred loading of images. What is in the DOM? Are heights still being set on the containers? Also, Peter, should Harbs switch from Container to Group? For #2, again, what does the DOM look like? Did the margins get set properly? Thanks, -Alex On 3/27/17, 1:35 PM, "Harbs" wrote: >Better, but I still have some problems (there’s probably more): > > > > > > > >marginRight="auto"/> > > > > >width="30" height="30" >click="undo_clickHandler(event)" id="undoButton" >src="assets/images/icons/0726-undo.svg"> > > > > >width="30" height="30" >click="redo_clickHandler(event)" id="redoButton" >src="assets/images/icons/0727-redo.svg"> > > > > >width="30" height="30" >click="zoomin_clickHandler(event)" >src="assets/images/icons/0806-zoom-in.svg"/> >width="30" height="30" >click="zoomout_clickHandler(event)" >src="assets/images/icons/0807-zoom-out.svg"/> >width="30" height="30" >click="fitButton_clickHandler(event)" >src="assets/images/icons/0843-expand.svg"/> >width="30" height="30" >click="previewButton_clickHandler(event)" >src="assets/images/icons/0786-file-preview-white.svg"/> > >width="30" height="30" >click="finishButton_clickHandler()" >src="assets/images/icons/0821-check.svg"/> > >width="30" height="30" >click="cancelButton_clickHandler()" >src="assets/images/icons/0822-cross2.svg"/> > > >1. This used to create a centered group of buttons. Now, the container >has a height of 0 and the buttons don’t show up. > >2. >id="scrollContainer" >width="100%" height="100%"> > > > >id="designContainer" >className="_holder" y="0"> > >marginLeft="auto" marginRight="auto"/> > > > > > >This used to create a scrolling div that was centered in the the window. >It now is aligned left, and I don’t know if it scrolls. > >There’s other issues, and I’ll see tomorrow what I can work around. > >> On Mar 27, 2017, at 11:08 PM, Peter Ent wrote: >> >> Hi, >> >> I just pushed a change to UIBase to set position="absolute" when >>setting x >> or y. I think this is perfectly safe and if someone does set x and y and >> then tries to use a layout where that would be a conflict, they will get >> have to avoid setting those properties. >> >> I figured this would eventually happen. Let's see if this fixes the >>issue. >> >> —peter >> >> >> On 3/27/17, 2:58 PM, "Harbs" wrote: >> >>> Peter, >>> >>> I just tried loading my app with your changes, and everything is >>>totally >>> borked. We rely a lot on absolute positioning and transformations. >>> >>> We really need the old behavior in some components. >>> >>> Is there any components which work the same as they used to? >>> >>> Harbs >>> On Mar 26, 2017, at 6:55 PM, Peter Ent wrote: For the time being, the Tour main view should have a width and a height: Then in the style section, give everything flex-grow: 1; and it should look better. I think some padding and/or margins might be needed, but I think I have more work do with the layouts. I'll bump getting the tour to the top of the list for this week because I think its nesting of elements is a good test. I think it is just a matter of setting the style values right. HTML structure-wise it looks fine, so that's good. ‹peter On 3/26/17, 11:31 AM, "piotrz" wrote: > Peter, > > I've started to experiment with your new classes in TourJS and I >think > I've > achieved some good look, but not everything is working as expected. > > For some reason co
[DISCUSS] Release Apache Flex BlazeDS 4.7.3
Hi, Please discuss the release candidate here and not in the vote thread. Thanks, Chris
[VOTE] Release Apache Flex BlazeDS 4.7.3
Hi,
This is Apache Flex BlazeDS 4.7.3 release candidate 1.
RELEASE NOTES:
Apache Flex BlazeDS 4.7.3 is an update to 4.7.2 which adds a new
blazeds-spring-boot-starter module for easily setting up a BlazeDS server with
Spring Boot. It also provides Maven archetypes for easily creating new
spring-boot
project that make use of BlazeDS. We also did quite a lot of fine-tuning of the
security default settings to make BlazeDS more secure.
Starting with 4.7.3 BlazeDS Deserialization of XML is disabled completely per
default
but can easily be enabled in your services-config.xml:
http://{server.name}:{server.port}/{context.root}/messagebroker/amf";
class="flex.messaging.endpoints.AMFEndpoint"/>
true
Also we now enable the ClassDeserializationValidator per default to only allow
deserialization of whitelisted classes. BlazeDS internally comes with the
following
whitelist:
flex.messaging.io.amf.ASObject
flex.messaging.io.amf.SerializedObject
flex.messaging.io.ArrayCollection
flex.messaging.io.ArrayList
flex.messaging.messages.AcknowledgeMessage
flex.messaging.messages.AcknowledgeMessageExt
flex.messaging.messages.AsyncMessage
flex.messaging.messages.AsyncMessageExt
flex.messaging.messages.CommandMessage
flex.messaging.messages.CommandMessageExt
flex.messaging.messages.ErrorMessage
flex.messaging.messages.HTTPMessage
flex.messaging.messages.RemotingMessage
flex.messaging.messages.SOAPMessage
java.lang.Boolean
java.lang.Byte
java.lang.Character
java.lang.Double
java.lang.Float
java.lang.Integer
java.lang.Long
java.lang.Object
java.lang.Short
java.lang.String
java.util.ArrayList
java.util.Date
java.util.HashMap
org.w3c.dom.Document
If you need to deserialize any other classes, be sure to register them in your
services-config.xml:
(Beware, by manually providing a whitelist the default whitelist is disabled)
Known Issues
_
FLEX-34648 Memory Leak occurred in AsyncMessage when sending a lot of messages
---
The release candidate can be found here:
https://repository.apache.org/content/repositories/orgapacheflex-1019/org/apache/flex/blazeds/blazeds/4.7.3/blazeds-4.7.3-source-release.zip
Re: [FlexJS] Summary of Changes
Better, but I still have some problems (there’s probably more): 1. This used to create a centered group of buttons. Now, the container has a height of 0 and the buttons don’t show up. 2. This used to create a scrolling div that was centered in the the window. It now is aligned left, and I don’t know if it scrolls. There’s other issues, and I’ll see tomorrow what I can work around. > On Mar 27, 2017, at 11:08 PM, Peter Ent wrote: > > Hi, > > I just pushed a change to UIBase to set position="absolute" when setting x > or y. I think this is perfectly safe and if someone does set x and y and > then tries to use a layout where that would be a conflict, they will get > have to avoid setting those properties. > > I figured this would eventually happen. Let's see if this fixes the issue. > > —peter > > > On 3/27/17, 2:58 PM, "Harbs" wrote: > >> Peter, >> >> I just tried loading my app with your changes, and everything is totally >> borked. We rely a lot on absolute positioning and transformations. >> >> We really need the old behavior in some components. >> >> Is there any components which work the same as they used to? >> >> Harbs >> >>> On Mar 26, 2017, at 6:55 PM, Peter Ent wrote: >>> >>> For the time being, the Tour main view should have a width and a height: >>> >>> >>> >>> Then in the style section, give everything flex-grow: 1; and it should >>> look better. I think some padding and/or margins might be needed, but I >>> think I have more work do with the layouts. I'll bump getting the tour >>> to >>> the top of the list for this week because I think its nesting of >>> elements >>> is a good test. I think it is just a matter of setting the style values >>> right. HTML structure-wise it looks fine, so that's good. >>> >>> ‹peter >>> >>> On 3/26/17, 11:31 AM, "piotrz" wrote: >>> Peter, I've started to experiment with your new classes in TourJS and I think I've achieved some good look, but not everything is working as expected. For some reason code of examples has not been loaded properly. If you could review my changes and give some feedback, whether I used your new classes in appropriate manner. Thanks, Piotr - Apache Flex PMC piotrzarzyck...@gmail.com -- View this message in context: https://na01.safelinks.protection.outlook.com/?url=http%3A%2F%2Fapache-f le x-development.247.n4.nabble.com%2FFlexJS-Summary-of-Changes-tp60709p 60 779.html&data=02%7C01%7C%7Cd418c8770a394118a2f208d4745e47ea%7Cfa7b1b5a7b 34 438794aed2c178decee1%7C0%7C0%7C636261395657671115&sdata=29GdLLPJdgglZFzZ UF AOBNCBt0S8qshiPOmXCDEbRKw%3D&reserved=0 Sent from the Apache Flex Development mailing list archive at Nabble.com. >>> >> >
Re: [FlexJS] Summary of Changes
Hi, I just pushed a change to UIBase to set position="absolute" when setting x or y. I think this is perfectly safe and if someone does set x and y and then tries to use a layout where that would be a conflict, they will get have to avoid setting those properties. I figured this would eventually happen. Let's see if this fixes the issue. —peter On 3/27/17, 2:58 PM, "Harbs" wrote: >Peter, > >I just tried loading my app with your changes, and everything is totally >borked. We rely a lot on absolute positioning and transformations. > >We really need the old behavior in some components. > >Is there any components which work the same as they used to? > >Harbs > >> On Mar 26, 2017, at 6:55 PM, Peter Ent wrote: >> >> For the time being, the Tour main view should have a width and a height: >> >> >> >> Then in the style section, give everything flex-grow: 1; and it should >> look better. I think some padding and/or margins might be needed, but I >> think I have more work do with the layouts. I'll bump getting the tour >>to >> the top of the list for this week because I think its nesting of >>elements >> is a good test. I think it is just a matter of setting the style values >> right. HTML structure-wise it looks fine, so that's good. >> >> ‹peter >> >> On 3/26/17, 11:31 AM, "piotrz" wrote: >> >>> Peter, >>> >>> I've started to experiment with your new classes in TourJS and I think >>> I've >>> achieved some good look, but not everything is working as expected. >>> >>> For some reason code of examples has not been loaded properly. If you >>> could >>> review my changes and give some feedback, whether I used your new >>>classes >>> in >>> appropriate manner. >>> >>> Thanks, >>> Piotr >>> >>> >>> >>> - >>> Apache Flex PMC >>> piotrzarzyck...@gmail.com >>> -- >>> View this message in context: >>> >>>https://na01.safelinks.protection.outlook.com/?url=http%3A%2F%2Fapache-f >>>le >>> >>>x-development.247.n4.nabble.com%2FFlexJS-Summary-of-Changes-tp60709p >>>60 >>> >>>779.html&data=02%7C01%7C%7Cd418c8770a394118a2f208d4745e47ea%7Cfa7b1b5a7b >>>34 >>> >>>438794aed2c178decee1%7C0%7C0%7C636261395657671115&sdata=29GdLLPJdgglZFzZ >>>UF >>> AOBNCBt0S8qshiPOmXCDEbRKw%3D&reserved=0 >>> Sent from the Apache Flex Development mailing list archive at >>>Nabble.com. >> >
Re: [FlexJS] Anyone working on the build problems?
Hi Josh, I guess in that case it was one of the tests which I excluded from the Maven build … so if you add another it will automatically be run, as Maven doesn’t know it should exclude it. If you have a look in the pom.xml you will see the surefire plugin (runs unit tests) and the failsafe plugin (runs integration tests). Here a hand full of tests are excluded because they need a refactoring to not introduce a cycle or need to be moved to the framework module (I would prefer the first option) Guess it would be cool if we figured out a way to refactor the tests so we can run them in Maven … eventually doing so over a beer in Miami would be a good invest of time? What do you think ;-) Chris Am 27.03.17, 17:43 schrieb "Josh Tynjala" : I didn't structure the tests this way. I followed the existing tests that were already there. - Josh On Mar 27, 2017 1:04 AM, "Christofer Dutz" wrote: > Hi Josh, > > Tests shouldn’t require a directory structure … especially not outside of > the current maven modules directory. This type of refactoring is what > consumed most of my time while migrating Falcon from Ant to Maven. Having a > look at the current problem, it seems the problems are related to its > dependency to FlexJSTestBase, which seems to require a set of environment > variables and expects other directories. This dependency to framework would > have introduced a cycle, which is also the reason I couldn’t refactor the > tests without completely re-writing most of them. > > We should address the FlexJsTestBase tests and make sure we are able to > test what they should be testing without introducing a cyclic dependency. > > For now, excluding them from the testsuite is probably the best option. > > Chris > > > Am 26.03.17, 23:19 schrieb "Josh Tynjala" : > > 1. I don't think this part is actually an issue (other than being > annoying > noise in the output). I also see this warning and my build finishes > successfully. > > 2/3. I think these new tests that I wrote rely on flex-asjs in some way > (since they're parsing MXML), and maybe it's having trouble finding > that > project on your machine. I'll see if I can move them to the correct > part of > the build where it runs the optional "dependent" tests. > > - Josh > > On Sun, Mar 26, 2017 at 1:53 PM, Harbs wrote: > > > There seemed to be three things causing me build problems: > > 1. compiler-jx/src/test/java/org/apache/flex/compiler/internal/ > test/FlexJSTestBase.java > > A reference to frameworks/as/basic-manifest.xml which does not seem > to > > exist. > > 2. compiler-jx/src/test/java/org/apache/flex/compiler/internal/ > > codegen/mxml/sourcemaps/TestSourceMapMXMLScript.java The tests are > > failing. > > 3. compiler-jx/src/test/java/org/apache/flex/compiler/internal/ > > codegen/mxml/sourcemaps/TestSourceMapMXMLEvents.java The tests are > > failing. > > > > Removing the test in 1 and the latter two files allowed Falcon and > asjs to > > build on my machine. > > > > Harbs > > > > > On Mar 26, 2017, at 11:26 PM, Harbs wrote: > > > > > > I’m also having trouble building, but it’s failing at a totally > > different place. > > > > > >> On Mar 26, 2017, at 11:08 PM, piotrz > wrote: > > >> > > >> Hi Harbs, > > >> > > >> This is stack trace is straight from jenkins build. > > >> > > >> Locally I have same fail and definitely I did build with fresh > sources > > of > > >> Falcon. > > >> > > >> Piotr > > >> > > >> > > >> > > >> - > > >> Apache Flex PMC > > >> piotrzarzyck...@gmail.com > > >> -- > > >> View this message in context: http://apache-flex- > > development.247.n4.nabble.com/FlexJS-Anyone-working-on- > > the-build-problems-tp60777p60789.html > > >> Sent from the Apache Flex Development mailing list archive at > > Nabble.com. > > > > > > > > > >
Re: [FlexJS] Summary of Changes
Peter, I just tried loading my app with your changes, and everything is totally borked. We rely a lot on absolute positioning and transformations. We really need the old behavior in some components. Is there any components which work the same as they used to? Harbs > On Mar 26, 2017, at 6:55 PM, Peter Ent wrote: > > For the time being, the Tour main view should have a width and a height: > > > > Then in the style section, give everything flex-grow: 1; and it should > look better. I think some padding and/or margins might be needed, but I > think I have more work do with the layouts. I'll bump getting the tour to > the top of the list for this week because I think its nesting of elements > is a good test. I think it is just a matter of setting the style values > right. HTML structure-wise it looks fine, so that's good. > > ‹peter > > On 3/26/17, 11:31 AM, "piotrz" wrote: > >> Peter, >> >> I've started to experiment with your new classes in TourJS and I think >> I've >> achieved some good look, but not everything is working as expected. >> >> For some reason code of examples has not been loaded properly. If you >> could >> review my changes and give some feedback, whether I used your new classes >> in >> appropriate manner. >> >> Thanks, >> Piotr >> >> >> >> - >> Apache Flex PMC >> piotrzarzyck...@gmail.com >> -- >> View this message in context: >> https://na01.safelinks.protection.outlook.com/?url=http%3A%2F%2Fapache-fle >> x-development.247.n4.nabble.com%2FFlexJS-Summary-of-Changes-tp60709p60 >> 779.html&data=02%7C01%7C%7Cd418c8770a394118a2f208d4745e47ea%7Cfa7b1b5a7b34 >> 438794aed2c178decee1%7C0%7C0%7C636261395657671115&sdata=29GdLLPJdgglZFzZUF >> AOBNCBt0S8qshiPOmXCDEbRKw%3D&reserved=0 >> Sent from the Apache Flex Development mailing list archive at Nabble.com. >
Re: Cloning rectangles
Hi, I end up figuring out a way of validating my rectangles and re-assigning correct values. I'll definitely change this to other type.. Thank you 2017-03-24 19:02 GMT+00:00 Alex Harui : > > On 3/24/17, 11:46 AM, "Dev LFM" wrote: > > >I hope they take it serious, because all "projects" are a serialization of > >an entire class "Project" and posted to server as it is... then our > >editors > >/ content generators load that serialized "Project"... it definitely saved > >me a lot of time and gave me piece of mind.. on the other hand not so good > >to port over other frameworks/apps. > > OK, but if you go an remove all "import flash.geom.Rectangle" from your > data objects and replace it with your own Rectangle, it should solve the > problem not only for now, but make your code more portable to FlexJS. > > HTH, > -Alex > >
Re: Peter Ent's emails being flagged
I got some emails again in February routed to spam, then I march it went to inbox normaly. Very strange behaviour... 2017-03-24 16:35 GMT+01:00 Alex Harui : > Carlos had a problem with Peter's email in January. I'm not sure what the > answer is. > > -Alex > > On 3/24/17, 7:54 AM, "Dave Glasser" wrote: > > >I use Yahoo email, and it seems that the majority of Peter Ent's (and > >others from this list) get routed into my spam folder. Marking the > >flagged messages as "Not Spam" seems to have no effect on subsequent > >mails. > >Is anyone else experiencing this with Yahoo email? > > > > > > From: Peter Ent > > To: "dev@flex.apache.org" > > Sent: Thursday, March 23, 2017 1:44 PM > > Subject: [FlexJS] Summary of Changes > > > >FlexJS Container and Layout Upgrade > > > >My goal when starting this process was to have FlexJS produce leaner HTML > >structures and to reduce the amount of JavaScript code getting > >cross-compiled. My latest commit does the following: > > > >- Produces simpler HTML structures for the container classes, Group, > >Container, and Panel. > >- Simplifies a number of the layout classes for JS while fixing or tuning > >the SWF code to mimic the browser. > >- Moves code that only affects the SWF side into SWF code blocks. > > > >I touched only Core and HTML projects and fixed Effects so it would > >compile since it had the fewest issues. MDL and Charts have larger > >concerns and I hope to sort those out as quickly as I can. > > > >Here are the classes and changes you will find: > > > >Group: This new class (introduced in a previous commit) produces the > >simplest container for HTML (it is just a DIV) and SWF. By default it > >provides no layout in case you want to style in completely using CSS. > >Group (and its view bead, GroupView), are the foundation of the container > >classes. Group runs a layout bead (if there is one) and handles the > >sizing of elements on the SWF side. The JS side is left alone for the > >browser to manage (this was the biggest change). > > > >Container: This class, which extends Group, exists to provide scrolling > >on the SWF side. The JS side of Container is very light adds little to > >what Group does. On the SWF side, Container is a nested structure in > >order to providing content masking and scrolling (which is handled on the > >JS side by using overflow:auto style, which is all the ScrollingViewport > >bead will do if you add it to Container). > > > >UIBase: The major change to UIBase is that it no longer sets the position > >style. That means if you set the x and y properties of a component, it > >will, on the JS side, only set the left and top style values. If you > >intend to place elements at specific pixel coordinates, use a container > >(Group or Container) with BasicLayout which will add position:absolute > >style to all of the children. > > > >NOTE: I made UIBase (and a couple other classes, too) not set position > >style because I saw how easily that caused other problems, especially > >when there was a mixing of "absolute" and "relative" position values. Now > >that this work is done, it may not be a bad thing to have UIBase's x and > >y properties set position:absolute has a convenience. It does however, > >have some ramifications; if you have position:absolute that will override > >pretty much all of the layout types. But maybe the developer just sees > >this and stops setting x and y. Also, there is no way to unset position > >once set. These are things we will have to see how they play out. > > > >Layouts: The layouts no longer change the size of their container hosts > >nor do they produce the "layoutComplete" event. The GroupView class > >handles both of these now to make the process of layout and > >sizing/positioning consistent. > > > >Lists: The DataGroup that lists use to hold the item renderers is no > >longer in play. The DataGroup caused unnecessary nesting of elements (DIV > >inside of DIV). To break that, components like List had to become their > >own item renderer parents. Squaring this away is perhaps the biggest > >challenge since a number of complex components use List as their base. > >The DataContainer is now the basis for lists, with List being its first > >subclass since they have so much in common. The DataContainerView bead is > >now the basis for all list views. > > > >Panel: The Panel is now an extension of Group and it contains three > >children: a TitleBar, a ControlBar (for PanelWithControlBar), and a > >Container for the content space. When you do: panel.addElement(object), > >the Panel code redirects this to its Container child. Similarly, > >panel.numElements tells you the number of elements in the Container > >child. Because Panel is now a Group (so are TitleBar and ControlBar), it > >uses a layout to size and position those three children. When you build > >your own components, you can use Group + layout to achieve the look you > >want with minimal HTML structure. > > > >Interfaces: There are couple
Re: [FlexJS] Anyone working on the build problems?
I didn't structure the tests this way. I followed the existing tests that were already there. - Josh On Mar 27, 2017 1:04 AM, "Christofer Dutz" wrote: > Hi Josh, > > Tests shouldn’t require a directory structure … especially not outside of > the current maven modules directory. This type of refactoring is what > consumed most of my time while migrating Falcon from Ant to Maven. Having a > look at the current problem, it seems the problems are related to its > dependency to FlexJSTestBase, which seems to require a set of environment > variables and expects other directories. This dependency to framework would > have introduced a cycle, which is also the reason I couldn’t refactor the > tests without completely re-writing most of them. > > We should address the FlexJsTestBase tests and make sure we are able to > test what they should be testing without introducing a cyclic dependency. > > For now, excluding them from the testsuite is probably the best option. > > Chris > > > Am 26.03.17, 23:19 schrieb "Josh Tynjala" : > > 1. I don't think this part is actually an issue (other than being > annoying > noise in the output). I also see this warning and my build finishes > successfully. > > 2/3. I think these new tests that I wrote rely on flex-asjs in some way > (since they're parsing MXML), and maybe it's having trouble finding > that > project on your machine. I'll see if I can move them to the correct > part of > the build where it runs the optional "dependent" tests. > > - Josh > > On Sun, Mar 26, 2017 at 1:53 PM, Harbs wrote: > > > There seemed to be three things causing me build problems: > > 1. compiler-jx/src/test/java/org/apache/flex/compiler/internal/ > test/FlexJSTestBase.java > > A reference to frameworks/as/basic-manifest.xml which does not seem > to > > exist. > > 2. compiler-jx/src/test/java/org/apache/flex/compiler/internal/ > > codegen/mxml/sourcemaps/TestSourceMapMXMLScript.java The tests are > > failing. > > 3. compiler-jx/src/test/java/org/apache/flex/compiler/internal/ > > codegen/mxml/sourcemaps/TestSourceMapMXMLEvents.java The tests are > > failing. > > > > Removing the test in 1 and the latter two files allowed Falcon and > asjs to > > build on my machine. > > > > Harbs > > > > > On Mar 26, 2017, at 11:26 PM, Harbs wrote: > > > > > > I’m also having trouble building, but it’s failing at a totally > > different place. > > > > > >> On Mar 26, 2017, at 11:08 PM, piotrz > wrote: > > >> > > >> Hi Harbs, > > >> > > >> This is stack trace is straight from jenkins build. > > >> > > >> Locally I have same fail and definitely I did build with fresh > sources > > of > > >> Falcon. > > >> > > >> Piotr > > >> > > >> > > >> > > >> - > > >> Apache Flex PMC > > >> piotrzarzyck...@gmail.com > > >> -- > > >> View this message in context: http://apache-flex- > > development.247.n4.nabble.com/FlexJS-Anyone-working-on- > > the-build-problems-tp60777p60789.html > > >> Sent from the Apache Flex Development mailing list archive at > > Nabble.com. > > > > > > > > > >
Tweaks.php and the upcoming release
Hi, With another release around the corner, I want to make sure that everyone understands the new database change paradigm: 1) When you create a JIRA stack, it's database (a fresh copy of production) is brought up to date with the recent changes made earlier in the dev process by automatically running 'tools/run_tweaks.php' when the stack creation is complete; no dev action needed. 2) Any database changes you make during development (structurally, always, and content when relevant) should be recorded in 'db/tweaks.php'. The correct syntax is to add to the changes array a HEREDOC containing the SQL statements. Note: the statements in a block are split over the semi-colons to get the individual queries. 3) When you merge your branch back into it's parent - most likely trunk - make sure to run 'tools/run_tweaks.php' on the parent - most likely staging. This will bring the database up to date and will be a good check if the merge of 'db/tweaks.php' did not introduce any issues. 4) Upon release I will run the fully combined 'db/tweaks.php' on production and all should be well ;-) The update mechanism records which queries have already been run. This has the advantage that you can run 'tools/run_tweaks.php' as often as you like. Any queries in 'db/tweaks.php' will only run once on the database in your stack. WARNING: do not make changes to earlier statements, not even to the whitespace. Take care when committing any changes that any changes to earlier statements are excluded. Since the procedure to determine which queries to run depends on a has of the statement, any changes to the statement will cause the hash to change and the query to run again. This can be BAD :-) Thanks, EdB -- Ix Multimedia Software Jan Luykenstraat 27 3521 VB Utrecht T. 06-51952295 I. www.ixsoftware.nl
Re: [FlexJS] Anyone working on the build problems?
Hi Josh, Tests shouldn’t require a directory structure … especially not outside of the current maven modules directory. This type of refactoring is what consumed most of my time while migrating Falcon from Ant to Maven. Having a look at the current problem, it seems the problems are related to its dependency to FlexJSTestBase, which seems to require a set of environment variables and expects other directories. This dependency to framework would have introduced a cycle, which is also the reason I couldn’t refactor the tests without completely re-writing most of them. We should address the FlexJsTestBase tests and make sure we are able to test what they should be testing without introducing a cyclic dependency. For now, excluding them from the testsuite is probably the best option. Chris Am 26.03.17, 23:19 schrieb "Josh Tynjala" : 1. I don't think this part is actually an issue (other than being annoying noise in the output). I also see this warning and my build finishes successfully. 2/3. I think these new tests that I wrote rely on flex-asjs in some way (since they're parsing MXML), and maybe it's having trouble finding that project on your machine. I'll see if I can move them to the correct part of the build where it runs the optional "dependent" tests. - Josh On Sun, Mar 26, 2017 at 1:53 PM, Harbs wrote: > There seemed to be three things causing me build problems: > 1. compiler-jx/src/test/java/org/apache/flex/compiler/internal/test/FlexJSTestBase.java > A reference to frameworks/as/basic-manifest.xml which does not seem to > exist. > 2. compiler-jx/src/test/java/org/apache/flex/compiler/internal/ > codegen/mxml/sourcemaps/TestSourceMapMXMLScript.java The tests are > failing. > 3. compiler-jx/src/test/java/org/apache/flex/compiler/internal/ > codegen/mxml/sourcemaps/TestSourceMapMXMLEvents.java The tests are > failing. > > Removing the test in 1 and the latter two files allowed Falcon and asjs to > build on my machine. > > Harbs > > > On Mar 26, 2017, at 11:26 PM, Harbs wrote: > > > > I’m also having trouble building, but it’s failing at a totally > different place. > > > >> On Mar 26, 2017, at 11:08 PM, piotrz wrote: > >> > >> Hi Harbs, > >> > >> This is stack trace is straight from jenkins build. > >> > >> Locally I have same fail and definitely I did build with fresh sources > of > >> Falcon. > >> > >> Piotr > >> > >> > >> > >> - > >> Apache Flex PMC > >> piotrzarzyck...@gmail.com > >> -- > >> View this message in context: http://apache-flex- > development.247.n4.nabble.com/FlexJS-Anyone-working-on- > the-build-problems-tp60777p60789.html > >> Sent from the Apache Flex Development mailing list archive at > Nabble.com. > > > >
Re: [FlexJS] Struggling with custom HTML
> On Mar 27, 2017, at 7:03 AM, Alex Harui wrote: > > > > On 3/26/17, 5:59 AM, "Harbs" wrote: > >> I have been successful using compc with conditional compiles outside the >> framework, but I was not successful using mxmlc. > > The "dual" branch should have better support for conditional compilation > in the application source. Good to know. I will have to try that. > But I'd like to understand which problem you want to solve. As you > mentioned, the snippet you provided did not have any code in it and should > be ok to use as innerHTML. But as soon as you add an event handler, the > questions start to arise about the scope of the code. Our compilers are > probably not ready to be JS compilers and if you want to access the code > from your AS code, I don't think we've defined how that should work. > > There are other options where you promise that the AS code will not touch > the JS code. That's closer to what externs/typedefs are. My specific problem was caused by the CheckBox component. The way CheckBox was made, it’s not styleable. Styleable checkboxes require CSS which hides the default checkbox and creates a pseudo-element which is styled by CSS to have the desired look. I’m working on a panel for InDesign. Generally I’m using Topcoat CSS because that matches the general styling of InDesign components pretty closely. This works for most FlexJS components pretty well. Because FlexJS checkboxes are not styleable, checkboxes are not usable with the Topcoat CSS. The CSS hides the default checkbox, but the Topcoat one does not appear because the expected HTML structure is not there. I am considering changing Checkbox to have the expected structure or creating a new “CSSCheckBox” component which has the structure. The problem I see that there seems to be more than one method of creating CSS styled checkbox. Ultimately, I don’t think using HTML checkboxes is the “FlexJS” way of making checkboxes. That’s because any styling of checkboxes are hacks. I’d really like to see our skinning story improve. Flex 3 and Flex 4 had very good methods for skinning components, and I wish we had a better platform agnostic skinning story for FlexJS. > You should be able to create library projects just like you did with > regular Flex and thus create SWCs with components that aren't "framework" > components. I don't think we've had anybody actually try that, but I > would think we want that to work. Yes. I’ve already done this, and it works. > Thoughts? > -Alex > >> >>> On Mar 26, 2017, at 3:20 PM, Peter Ent wrote: >>> >>> The way it stands now, you do need to create a new component in the >>> framework somewhere. In the long run, developers will want to make their >>> own component sets that make use of conditional compilation, so now >>> would >>> be a good time to come up with that. You should be able to do this >>> outside >>> of the framework, IMO. >>> >>> You could even imagine a company that has a bunch of JavaScript >>> "components" that they'd like to use. We have the extern mechanism, and >>> maybe that's appropriate when there is a lot of JavaScript to reference, >>> but perhaps a developer will just want to copy a component's JavaScript >>> code into their project - even temporarily - and I think we should be >>> able >>> to provide for that. >>> >>> ‹peter >>> >>> On 3/26/17, 6:36 AM, "Harbs" wrote: >>> I want to use a Topcoat checkbox in an app. That requires some HTML like this: Checkbox Label I cannot think of a normal way of including something like this in my app without creating a whole new framework component. Conditional compiles do not seem to work. I don¹t know why. I also considered using an InnerHTML bead, but that does not allow handling the checkbox clicks. The fact that FlexJS abstracts the HTML and JS most of the time is great, but I think there needs to be an easy way to use bog-standard HTML when the need comes up. Thoughts? Harbs >>> >> >
