Re: [07/13] git commit: [flex-asjs] [refs/heads/release0.8.0] - give up on trying to use FlexBox for full-screen 3-pane views. FlexBox seems more happy stretching to content size instead of clipping a

[Alex Harui]

It will either work in the examples that use it or it won't.  Try it and
find out.

-Alex

On 7/30/17, 3:04 AM, "Harbs"  wrote:

>I think I just ran into the same issue.
>
>This layout seems to more-or-less do the job, but it’s kind of heavy.
>
>I did some research into flexbox and it appear that setting flex-basis to
>0 does the job. It needs to be set on ONLY the one flexible child.
>
>Here’s a codepen which shows a use case.
>https://na01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fcodepen.i
>o%2Fjpdevries%2Fpen%2FoXxPOP=02%7C01%7C%7C699bbb170b2c4f0bf3ae08d4d73
>2638a%7Cfa7b1b5a7b34438794aed2c178decee1%7C0%7C0%7C636370058818766511
>a=tSTNYANFFiQ4DMGYbAZaz0dJ9qYDYpcwP2ZoSYRIcG8%3D=0
>io%2Fjpdevries%2Fpen%2FoXxPOP=02%7C01%7C%7C699bbb170b2c4f0bf3ae08d4d7
>32638a%7Cfa7b1b5a7b34438794aed2c178decee1%7C0%7C0%7C636370058818766511
>ta=tSTNYANFFiQ4DMGYbAZaz0dJ9qYDYpcwP2ZoSYRIcG8%3D=0>
>
>I noticed that the OneFlexibleLayouts have code which set the flex-basis
>of the children if a percentage value is set. When setting the size of
>the one flexible child to 0% this causes the flex-basis to be set to 0
>and then the one flexible child will fit the remaining space even if it
>might overflow because of its children.
>
>I have wasted quite a bit of time before I discovered this. I’m not sure
>whether the OneFlexibleLayout classes should be changed, or maybe we need
>documentation that to fit content that might overflow, the percentage
>should be set to 0. It could be there are cases where the entire
>OnFlexibleLayout should be fit when smaller and expand (and not scroll)
>when bigger. In that case, the current behavior might be correct.
>
>Thoughts?
>Harbs
>
>> On May 23, 2017, at 10:16 AM, aha...@apache.org wrote:
>> 
>> give up on trying to use FlexBox for full-screen 3-pane views.  FlexBox
>>seems more happy stretching to content size instead of clipping at the
>>computed flex-ed size.  These custom layouts will do the proper sizing
>> 
>> 
>> Project: 
>>https://na01.safelinks.protection.outlook.com/?url=http%3A%2F%2Fgit-wip-u
>>s.apache.org%2Frepos%2Fasf%2Fflex-asjs%2Frepo=02%7C01%7C%7C699bbb170
>>b2c4f0bf3ae08d4d732638a%7Cfa7b1b5a7b34438794aed2c178decee1%7C0%7C0%7C6363
>>70058818766511=P%2FMkfZAwCYwpQEoCe5UGx8tW0mZaIZsMdDg6VxlaKWA%3D
>>erved=0
>> Commit: 
>>https://na01.safelinks.protection.outlook.com/?url=http%3A%2F%2Fgit-wip-u
>>s.apache.org%2Frepos%2Fasf%2Fflex-asjs%2Fcommit%2Fbdd34d2e=02%7C01%7
>>C%7C699bbb170b2c4f0bf3ae08d4d732638a%7Cfa7b1b5a7b34438794aed2c178decee1%7
>>C0%7C0%7C636370058818766511=QosBAau8lE4nCS7c%2F8B6GDc%2Bqa%2BpSkoP5
>>5x3oji5FnI%3D=0
>> Tree: 
>>https://na01.safelinks.protection.outlook.com/?url=http%3A%2F%2Fgit-wip-u
>>s.apache.org%2Frepos%2Fasf%2Fflex-asjs%2Ftree%2Fbdd34d2e=02%7C01%7C%
>>7C699bbb170b2c4f0bf3ae08d4d732638a%7Cfa7b1b5a7b34438794aed2c178decee1%7C0
>>%7C0%7C636370058818766511=T4CCqwtn%2FgFTmAnaI%2BuCXqtX0P75ebpKVZOxf
>>XOTbIE%3D=0
>> Diff: 
>>https://na01.safelinks.protection.outlook.com/?url=http%3A%2F%2Fgit-wip-u
>>s.apache.org%2Frepos%2Fasf%2Fflex-asjs%2Fdiff%2Fbdd34d2e=02%7C01%7C%
>>7C699bbb170b2c4f0bf3ae08d4d732638a%7Cfa7b1b5a7b34438794aed2c178decee1%7C0
>>%7C0%7C636370058818766511=f8WVJXc81KrLMuUgRckULYCfglNL7d%2BfdjSbBBU
>>0fRo%3D=0
>> 
>> Branch: refs/heads/release0.8.0
>> Commit: bdd34d2ef4d8117fa1b222ac470482a42dbea9eb
>> Parents: c505d67
>> Author: Alex Harui 
>> Authored: Mon May 22 10:12:02 2017 -0700
>> Committer: Alex Harui 
>> Committed: Tue May 23 00:15:56 2017 -0700
>> 
>> --
>> ...eFlexibleChildHorizontalLayoutForOverflow.as | 290 ++
>> ...xibleChildHorizontalLayoutLockChildHeight.as |  91 --
>> ...OneFlexibleChildVerticalLayoutForOverflow.as | 291
>>+++
>> ...FlexibleChildVerticalLayoutLockChildWidth.as |  93 --
>> .../Basic/src/main/resources/basic-manifest.xml |   4 +-
>> 5 files changed, 583 insertions(+), 186 deletions(-)
>> --
>> 
>> 
>> 
>>https://na01.safelinks.protection.outlook.com/?url=http%3A%2F%2Fgit-wip-u
>>s.apache.org%2Frepos%2Fasf%2Fflex-asjs%2Fblob%2Fbdd34d2e%2Fframeworks%2Fp
>>rojects%2FBasic%2Fsrc%2Fmain%2Fflex%2Forg%2Fapache%2Fflex%2Fhtml%2Fbeads%
>>2Flayouts%2FOneFlexibleChildHorizontalLayoutForOverflow.as=02%7C01%7
>>C%7C699bbb170b2c4f0bf3ae08d4d732638a%7Cfa7b1b5a7b34438794aed2c178decee1%7
>>C0%7C0%7C636370058818766511=L7BjG%2BM7nTwguX%2BNaE5Op6BIT7XZrEqKFop
>>0D%2Frc0Aw%3D=0
>> --
>> diff --git 
>>a/frameworks/projects/Basic/src/main/flex/org/apache/flex/html/beads/layo
>>uts/OneFlexibleChildHorizontalLayoutForOverflow.as
>>b/frameworks/projects/Basic/src/main/flex/org/apache/flex/html/beads/layo

Re: [MAVEN-BUILD] FlexJS Framework (maven) - Build # 1129 - Still Failing

[piotrz]

Hi Harbs,

Yes I saw it but I didn't have time to proper look. My first thought is that
this is some problem not related to our build. Maybe I should contact with
infra. Not sure.

Piotr



-
Apache Flex PMC
piotrzarzyck...@gmail.com
--
View this message in context: 
http://apache-flex-development.247.n4.nabble.com/Re-MAVEN-BUILD-FlexJS-Framework-maven-Build-1129-Still-Failing-tp63607p63609.html
Sent from the Apache Flex Development mailing list archive at Nabble.com.

Re: XML hasOwnProperty method

[Harbs]

There are quite a few fixes to XML in particular in the nightly, so I would 
recommend that you use the nightly anyway.

If you need help getting the nightly, let us know.

Thanks,
Harbs

> On Jul 30, 2017, at 11:05 PM, Jim Norris  wrote:
> 
> That's great news!  I am using 0.8 right now although I may need to get this 
> update to be able to progress much further.
> 
> 
> 
> Thanks,
> 
> Jim
> 
> -Original Message-
> From: Harbs [mailto:harbs.li...@gmail.com] 
> Sent: Sunday, July 30, 2017 3:47 PM
> To: dev@flex.apache.org
> Subject: Re: XML hasOwnProperty method
> 
> I just tried this and I see the problem.
> 
> I should have it fixed soon…
> 
>> On Jul 30, 2017, at 10:38 PM, Harbs  wrote:
>> 
>> Hi Jim,
>> 
>> Do you get some kind of error when you do this? Are you using 0.8.0 or the 
>> nightly?
>> 
>> I don’t think hasOwnProperty is something I personally use, so I wouldn’t be 
>> too surprised if there are issues there.
>> 
>> (FWIW, you should be able to use if(resourceXML.@collapsible.length()) 
>> as a workaround.)
>> 
>> Thanks,
>> Harbs
>> 
>>> On Jul 30, 2017, at 9:56 PM, Jim Norris  wrote:
>>> 
>>> This may be for Harbs as I think he did a lot of the work for XML.
>>> 
>>> 
>>> 
>>> I am working on some existing Flex code and trying to convert 
>>> portions of it to FlexJS.  As part of the application it loads a lot 
>>> of XML files and uses E4X to parse them.  I was able to get this 
>>> working quickly in swf format, so that was awesome!
>>> 
>>> 
>>> 
>>> However, I am having a problem with the hasOwnProperty method.  It 
>>> works fine running in swf format, but when I export to HTML/JS the 
>>> Javascript bombs on the hasOwnProperty method calls.  If I remove 
>>> them the code executes as it should.
>>> 
>>> 
>>> 
>>> I checked here
>>> (https://cwiki.apache.org/confluence/display/FLEX/E4X+Observations) 
>>> and it seems like they should be working but I wanted to check if I 
>>> am doing something I should not.
>>> 
>>> 
>>> 
>>> 
>>> 
>>> Typically these checks look like this in AS:
>>> 
>>> 
>>> 
>>> if (resourceXML.hasOwnProperty("@collapsible") == true){
>>> 
>>> globalCollapsible = toBoolean(resourceXML.@collapsible);
>>> 
>>> }else{
>>> 
>>>_globalCollapsible = false;
>>> 
>>> }
>>> 
>>> 
>>> 
>>> And look like this in the JS (the last alert I message I see is the 
>>> 'checking global property'):
>>> 
>>> 
>>> 
>>> alert('TextViewer checking global property');
>>> 
>>> if (resourceXML.hasOwnProperty("@collapsible") == true) {
>>> 
>>>  alert('TextViewer.init found global property');
>>> 
>>>  this._globalCollapsible =
>>> this.toBoolean(resourceXML.attribute('collapsible'));
>>> 
>>> } else {
>>> 
>>>  alert('TextViewer.init global property not found');
>>> 
>>>  this._globalCollapsible = false;
>>> 
>>> }
>>> 
>>> 
>>> 
>>> 
>>> 
>>> I have a ton of these types of checks in my code so any insight you 
>>> may have into either 1) what is wrong, or 2) what I should do instead 
>>> would be a lot of help.
>>> 
>>> 
>>> 
>>> 
>>> 
>>> Thanks,
>>> 
>>> 
>>> 
>>> Jim
>>> 
>> 
> 
> 

Re: [MAVEN-BUILD] FlexJS Framework (maven) - Build # 1129 - Still Failing

[Harbs]

The Maven build has been failing for the last 3 days. I could not figure out 
why. (The Ant build seems to be fine.)

Does any of the Maven folks want to take a look?

Thanks,
Harbs

> On Jul 30, 2017, at 11:00 PM, Apache Jenkins Server 
>  wrote:
> 
> The Apache Jenkins build system has built FlexJS Framework (maven) (build 
> #1129)
> 
> Status: Still Failing
> 
> Check console output at 
> https://builds.apache.org/job/FlexJS%20Framework%20(maven)/1129/ to view the 
> results.

RE: XML hasOwnProperty method

[Jim Norris]

That's great news!  I am using 0.8 right now although I may need to get this 
update to be able to progress much further.



Thanks,

Jim

-Original Message-
From: Harbs [mailto:harbs.li...@gmail.com] 
Sent: Sunday, July 30, 2017 3:47 PM
To: dev@flex.apache.org
Subject: Re: XML hasOwnProperty method

I just tried this and I see the problem.

I should have it fixed soon…

> On Jul 30, 2017, at 10:38 PM, Harbs  wrote:
> 
> Hi Jim,
> 
> Do you get some kind of error when you do this? Are you using 0.8.0 or the 
> nightly?
> 
> I don’t think hasOwnProperty is something I personally use, so I wouldn’t be 
> too surprised if there are issues there.
> 
> (FWIW, you should be able to use if(resourceXML.@collapsible.length()) 
> as a workaround.)
> 
> Thanks,
> Harbs
> 
>> On Jul 30, 2017, at 9:56 PM, Jim Norris  wrote:
>> 
>> This may be for Harbs as I think he did a lot of the work for XML.
>> 
>> 
>> 
>> I am working on some existing Flex code and trying to convert 
>> portions of it to FlexJS.  As part of the application it loads a lot 
>> of XML files and uses E4X to parse them.  I was able to get this 
>> working quickly in swf format, so that was awesome!
>> 
>> 
>> 
>> However, I am having a problem with the hasOwnProperty method.  It 
>> works fine running in swf format, but when I export to HTML/JS the 
>> Javascript bombs on the hasOwnProperty method calls.  If I remove 
>> them the code executes as it should.
>> 
>> 
>> 
>> I checked here
>> (https://cwiki.apache.org/confluence/display/FLEX/E4X+Observations) 
>> and it seems like they should be working but I wanted to check if I 
>> am doing something I should not.
>> 
>> 
>> 
>> 
>> 
>> Typically these checks look like this in AS:
>> 
>> 
>> 
>> if (resourceXML.hasOwnProperty("@collapsible") == true){
>> 
>> globalCollapsible = toBoolean(resourceXML.@collapsible);
>> 
>> }else{
>> 
>> _globalCollapsible = false;
>> 
>> }
>> 
>> 
>> 
>> And look like this in the JS (the last alert I message I see is the 
>> 'checking global property'):
>> 
>> 
>> 
>> alert('TextViewer checking global property');
>> 
>> if (resourceXML.hasOwnProperty("@collapsible") == true) {
>> 
>>   alert('TextViewer.init found global property');
>> 
>>   this._globalCollapsible =
>> this.toBoolean(resourceXML.attribute('collapsible'));
>> 
>> } else {
>> 
>>   alert('TextViewer.init global property not found');
>> 
>>   this._globalCollapsible = false;
>> 
>> }
>> 
>> 
>> 
>> 
>> 
>> I have a ton of these types of checks in my code so any insight you 
>> may have into either 1) what is wrong, or 2) what I should do instead 
>> would be a lot of help.
>> 
>> 
>> 
>> 
>> 
>> Thanks,
>> 
>> 
>> 
>> Jim
>> 
> 

Re: XML hasOwnProperty method

[Harbs]

I just pushed a fix. If you know how to patch your build, you can do that.

Otherwise, the fix should be in tomorrow’s nightly.

Thanks,
Harbs

> On Jul 30, 2017, at 10:47 PM, Harbs  wrote:
> 
> I just tried this and I see the problem.
> 
> I should have it fixed soon…
> 
>> On Jul 30, 2017, at 10:38 PM, Harbs  wrote:
>> 
>> Hi Jim,
>> 
>> Do you get some kind of error when you do this? Are you using 0.8.0 or the 
>> nightly?
>> 
>> I don’t think hasOwnProperty is something I personally use, so I wouldn’t be 
>> too surprised if there are issues there.
>> 
>> (FWIW, you should be able to use if(resourceXML.@collapsible.length()) as a 
>> workaround.)
>> 
>> Thanks,
>> Harbs
>> 
>>> On Jul 30, 2017, at 9:56 PM, Jim Norris  wrote:
>>> 
>>> This may be for Harbs as I think he did a lot of the work for XML.
>>> 
>>> 
>>> 
>>> I am working on some existing Flex code and trying to convert portions of it
>>> to FlexJS.  As part of the application it loads a lot of XML files and uses
>>> E4X to parse them.  I was able to get this working quickly in swf format, so
>>> that was awesome!
>>> 
>>> 
>>> 
>>> However, I am having a problem with the hasOwnProperty method.  It works
>>> fine running in swf format, but when I export to HTML/JS the Javascript
>>> bombs on the hasOwnProperty method calls.  If I remove them the code
>>> executes as it should.
>>> 
>>> 
>>> 
>>> I checked here
>>> (https://cwiki.apache.org/confluence/display/FLEX/E4X+Observations) and it
>>> seems like they should be working but I wanted to check if I am doing
>>> something I should not.
>>> 
>>> 
>>> 
>>> 
>>> 
>>> Typically these checks look like this in AS:
>>> 
>>> 
>>> 
>>> if (resourceXML.hasOwnProperty("@collapsible") == true){
>>> 
>>> globalCollapsible = toBoolean(resourceXML.@collapsible);
>>> 
>>> }else{
>>> 
>>>_globalCollapsible = false;
>>> 
>>> }
>>> 
>>> 
>>> 
>>> And look like this in the JS (the last alert I message I see is the
>>> 'checking global property'):
>>> 
>>> 
>>> 
>>> alert('TextViewer checking global property');
>>> 
>>> if (resourceXML.hasOwnProperty("@collapsible") == true) {
>>> 
>>>  alert('TextViewer.init found global property');
>>> 
>>>  this._globalCollapsible =
>>> this.toBoolean(resourceXML.attribute('collapsible'));
>>> 
>>> } else {
>>> 
>>>  alert('TextViewer.init global property not found');
>>> 
>>>  this._globalCollapsible = false;
>>> 
>>> }
>>> 
>>> 
>>> 
>>> 
>>> 
>>> I have a ton of these types of checks in my code so any insight you may have
>>> into either 1) what is wrong, or 2) what I should do instead would be a lot
>>> of help.
>>> 
>>> 
>>> 
>>> 
>>> 
>>> Thanks,
>>> 
>>> 
>>> 
>>> Jim
>>> 
>> 
> 

Re: XML hasOwnProperty method

[Harbs]

I just tried this and I see the problem.

I should have it fixed soon…

> On Jul 30, 2017, at 10:38 PM, Harbs  wrote:
> 
> Hi Jim,
> 
> Do you get some kind of error when you do this? Are you using 0.8.0 or the 
> nightly?
> 
> I don’t think hasOwnProperty is something I personally use, so I wouldn’t be 
> too surprised if there are issues there.
> 
> (FWIW, you should be able to use if(resourceXML.@collapsible.length()) as a 
> workaround.)
> 
> Thanks,
> Harbs
> 
>> On Jul 30, 2017, at 9:56 PM, Jim Norris  wrote:
>> 
>> This may be for Harbs as I think he did a lot of the work for XML.
>> 
>> 
>> 
>> I am working on some existing Flex code and trying to convert portions of it
>> to FlexJS.  As part of the application it loads a lot of XML files and uses
>> E4X to parse them.  I was able to get this working quickly in swf format, so
>> that was awesome!
>> 
>> 
>> 
>> However, I am having a problem with the hasOwnProperty method.  It works
>> fine running in swf format, but when I export to HTML/JS the Javascript
>> bombs on the hasOwnProperty method calls.  If I remove them the code
>> executes as it should.
>> 
>> 
>> 
>> I checked here
>> (https://cwiki.apache.org/confluence/display/FLEX/E4X+Observations) and it
>> seems like they should be working but I wanted to check if I am doing
>> something I should not.
>> 
>> 
>> 
>> 
>> 
>> Typically these checks look like this in AS:
>> 
>> 
>> 
>> if (resourceXML.hasOwnProperty("@collapsible") == true){
>> 
>> globalCollapsible = toBoolean(resourceXML.@collapsible);
>> 
>> }else{
>> 
>> _globalCollapsible = false;
>> 
>> }
>> 
>> 
>> 
>> And look like this in the JS (the last alert I message I see is the
>> 'checking global property'):
>> 
>> 
>> 
>> alert('TextViewer checking global property');
>> 
>> if (resourceXML.hasOwnProperty("@collapsible") == true) {
>> 
>>   alert('TextViewer.init found global property');
>> 
>>   this._globalCollapsible =
>> this.toBoolean(resourceXML.attribute('collapsible'));
>> 
>> } else {
>> 
>>   alert('TextViewer.init global property not found');
>> 
>>   this._globalCollapsible = false;
>> 
>> }
>> 
>> 
>> 
>> 
>> 
>> I have a ton of these types of checks in my code so any insight you may have
>> into either 1) what is wrong, or 2) what I should do instead would be a lot
>> of help.
>> 
>> 
>> 
>> 
>> 
>> Thanks,
>> 
>> 
>> 
>> Jim
>> 
> 

Re: XML hasOwnProperty method

[Harbs]

Hi Jim,

Do you get some kind of error when you do this? Are you using 0.8.0 or the 
nightly?

I don’t think hasOwnProperty is something I personally use, so I wouldn’t be 
too surprised if there are issues there.

(FWIW, you should be able to use if(resourceXML.@collapsible.length()) as a 
workaround.)

Thanks,
Harbs

> On Jul 30, 2017, at 9:56 PM, Jim Norris  wrote:
> 
> This may be for Harbs as I think he did a lot of the work for XML.
> 
> 
> 
> I am working on some existing Flex code and trying to convert portions of it
> to FlexJS.  As part of the application it loads a lot of XML files and uses
> E4X to parse them.  I was able to get this working quickly in swf format, so
> that was awesome!
> 
> 
> 
> However, I am having a problem with the hasOwnProperty method.  It works
> fine running in swf format, but when I export to HTML/JS the Javascript
> bombs on the hasOwnProperty method calls.  If I remove them the code
> executes as it should.
> 
> 
> 
> I checked here
> (https://cwiki.apache.org/confluence/display/FLEX/E4X+Observations) and it
> seems like they should be working but I wanted to check if I am doing
> something I should not.
> 
> 
> 
> 
> 
> Typically these checks look like this in AS:
> 
> 
> 
> if (resourceXML.hasOwnProperty("@collapsible") == true){
> 
> globalCollapsible = toBoolean(resourceXML.@collapsible);
> 
> }else{
> 
>  _globalCollapsible = false;
> 
> }
> 
> 
> 
> And look like this in the JS (the last alert I message I see is the
> 'checking global property'):
> 
> 
> 
>  alert('TextViewer checking global property');
> 
>  if (resourceXML.hasOwnProperty("@collapsible") == true) {
> 
>alert('TextViewer.init found global property');
> 
>this._globalCollapsible =
> this.toBoolean(resourceXML.attribute('collapsible'));
> 
>  } else {
> 
>alert('TextViewer.init global property not found');
> 
>this._globalCollapsible = false;
> 
>  }
> 
> 
> 
> 
> 
> I have a ton of these types of checks in my code so any insight you may have
> into either 1) what is wrong, or 2) what I should do instead would be a lot
> of help.
> 
> 
> 
> 
> 
> Thanks,
> 
> 
> 
> Jim
> 

XML hasOwnProperty method

[Jim Norris]

This may be for Harbs as I think he did a lot of the work for XML.

 

I am working on some existing Flex code and trying to convert portions of it
to FlexJS.  As part of the application it loads a lot of XML files and uses
E4X to parse them.  I was able to get this working quickly in swf format, so
that was awesome!

 

However, I am having a problem with the hasOwnProperty method.  It works
fine running in swf format, but when I export to HTML/JS the Javascript
bombs on the hasOwnProperty method calls.  If I remove them the code
executes as it should.

 

I checked here
(https://cwiki.apache.org/confluence/display/FLEX/E4X+Observations) and it
seems like they should be working but I wanted to check if I am doing
something I should not.

 

 

Typically these checks look like this in AS:

 

if (resourceXML.hasOwnProperty("@collapsible") == true){

globalCollapsible = toBoolean(resourceXML.@collapsible);

}else{

  _globalCollapsible = false;

}

 

And look like this in the JS (the last alert I message I see is the
'checking global property'):

 

  alert('TextViewer checking global property');

  if (resourceXML.hasOwnProperty("@collapsible") == true) {

alert('TextViewer.init found global property');

this._globalCollapsible =
this.toBoolean(resourceXML.attribute('collapsible'));

  } else {

alert('TextViewer.init global property not found');

this._globalCollapsible = false;

  }

 

 

I have a ton of these types of checks in my code so any insight you may have
into either 1) what is wrong, or 2) what I should do instead would be a lot
of help.

 

 

Thanks,

 

Jim

Re: [FlexJS] ClippingViewport

[Peter Ent]

I must have forgotten to delete that. 

Peter 


> On Jul 30, 2017, at 7:20 AM, Harbs  wrote:
> 
> Is anyone using ClippingViewport?
> 
> It seems to be extraneous at this point. Viewport does clipping by default.
> 
> Thanks,
> Harbs

[FlexJS] ClippingViewport

[Harbs]

Is anyone using ClippingViewport?

It seems to be extraneous at this point. Viewport does clipping by default.

Thanks,
Harbs

Re: [07/13] git commit: [flex-asjs] [refs/heads/release0.8.0] - give up on trying to use FlexBox for full-screen 3-pane views. FlexBox seems more happy stretching to content size instead of clipping a

[yishayw]

Here's a test app [1] that demonstrates it.

[1] https://paste.apache.org/i5Ui




--
View this message in context: 
http://apache-flex-development.247.n4.nabble.com/Re-07-13-git-commit-flex-asjs-refs-heads-release0-8-0-give-up-on-trying-to-use-FlexBox-for-full-scred-tp63598p63599.html
Sent from the Apache Flex Development mailing list archive at Nabble.com.

Re: [07/13] git commit: [flex-asjs] [refs/heads/release0.8.0] - give up on trying to use FlexBox for full-screen 3-pane views. FlexBox seems more happy stretching to content size instead of clipping a

[Harbs]

I think I just ran into the same issue.

This layout seems to more-or-less do the job, but it’s kind of heavy.

I did some research into flexbox and it appear that setting flex-basis to 0 
does the job. It needs to be set on ONLY the one flexible child.

Here’s a codepen which shows a use case.
https://codepen.io/jpdevries/pen/oXxPOP 


I noticed that the OneFlexibleLayouts have code which set the flex-basis of the 
children if a percentage value is set. When setting the size of the one 
flexible child to 0% this causes the flex-basis to be set to 0 and then the one 
flexible child will fit the remaining space even if it might overflow because 
of its children.

I have wasted quite a bit of time before I discovered this. I’m not sure 
whether the OneFlexibleLayout classes should be changed, or maybe we need 
documentation that to fit content that might overflow, the percentage should be 
set to 0. It could be there are cases where the entire OnFlexibleLayout should 
be fit when smaller and expand (and not scroll) when bigger. In that case, the 
current behavior might be correct.

Thoughts?
Harbs

> On May 23, 2017, at 10:16 AM, aha...@apache.org wrote:
> 
> give up on trying to use FlexBox for full-screen 3-pane views.  FlexBox seems 
> more happy stretching to content size instead of clipping at the computed 
> flex-ed size.  These custom layouts will do the proper sizing
> 
> 
> Project: http://git-wip-us.apache.org/repos/asf/flex-asjs/repo
> Commit: http://git-wip-us.apache.org/repos/asf/flex-asjs/commit/bdd34d2e
> Tree: http://git-wip-us.apache.org/repos/asf/flex-asjs/tree/bdd34d2e
> Diff: http://git-wip-us.apache.org/repos/asf/flex-asjs/diff/bdd34d2e
> 
> Branch: refs/heads/release0.8.0
> Commit: bdd34d2ef4d8117fa1b222ac470482a42dbea9eb
> Parents: c505d67
> Author: Alex Harui 
> Authored: Mon May 22 10:12:02 2017 -0700
> Committer: Alex Harui 
> Committed: Tue May 23 00:15:56 2017 -0700
> 
> --
> ...eFlexibleChildHorizontalLayoutForOverflow.as | 290 ++
> ...xibleChildHorizontalLayoutLockChildHeight.as |  91 --
> ...OneFlexibleChildVerticalLayoutForOverflow.as | 291 +++
> ...FlexibleChildVerticalLayoutLockChildWidth.as |  93 --
> .../Basic/src/main/resources/basic-manifest.xml |   4 +-
> 5 files changed, 583 insertions(+), 186 deletions(-)
> --
> 
> 
> http://git-wip-us.apache.org/repos/asf/flex-asjs/blob/bdd34d2e/frameworks/projects/Basic/src/main/flex/org/apache/flex/html/beads/layouts/OneFlexibleChildHorizontalLayoutForOverflow.as
> --
> diff --git 
> a/frameworks/projects/Basic/src/main/flex/org/apache/flex/html/beads/layouts/OneFlexibleChildHorizontalLayoutForOverflow.as
>  
> b/frameworks/projects/Basic/src/main/flex/org/apache/flex/html/beads/layouts/OneFlexibleChildHorizontalLayoutForOverflow.as
> new file mode 100644
> index 000..c6abc22
> --- /dev/null
> +++ 
> b/frameworks/projects/Basic/src/main/flex/org/apache/flex/html/beads/layouts/OneFlexibleChildHorizontalLayoutForOverflow.as
> @@ -0,0 +1,290 @@
> +
> +//
> +//  Licensed to the Apache Software Foundation (ASF) under one or more
> +//  contributor license agreements.  See the NOTICE file distributed with
> +//  this work for additional information regarding copyright ownership.
> +//  The ASF licenses this file to You under the Apache License, Version 2.0
> +//  (the "License"); you may not use this file except in compliance with
> +//  the License.  You may obtain a copy of the License at
> +//
> +//  http://www.apache.org/licenses/LICENSE-2.0
> +//
> +//  Unless required by applicable law or agreed to in writing, software
> +//  distributed under the License is distributed on an "AS IS" BASIS,
> +//  WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
> +//  See the License for the specific language governing permissions and
> +//  limitations under the License.
> +//
> +
> +package org.apache.flex.html.beads.layouts
> +{
> + import org.apache.flex.core.LayoutBase;
> + import org.apache.flex.core.IDocument;
> + import org.apache.flex.core.ILayoutChild;
> + import org.apache.flex.core.ILayoutHost;
> + import org.apache.flex.core.ILayoutView;
> + import org.apache.flex.core.ILayoutParent;
> + import org.apache.flex.core.IParentIUIBase;
> + import org.apache.flex.core.IStrand;
> + import org.apache.flex.core.IUIBase;
> + import org.apache.flex.core.ValuesManager;
> + import org.apache.flex.core.UIBase;
> + import org.apache.flex.events.Event;
> + import 

RE: [FlexJS, MDL] Menu with dataProvider and itemRenderer API

[yishayw]

Added the stack trace to the bug.



--
View this message in context: 
http://apache-flex-development.247.n4.nabble.com/FlexJS-MDL-Menu-with-dataProvider-and-itemRenderer-API-tp57637p63597.html
Sent from the Apache Flex Development mailing list archive at Nabble.com.