AW: Flex PMD donation
Hi Alex, well I wrote such a step-by-step tutorial .. it should be in our Wiki: https://cwiki.apache.org/confluence/display/FLEX/Apache+Flex+SDK+Mavenizer But seems you have successfully mavenized Flex. The problem is that I haven't released Flexmojos 7.1 yet so you need to add the sonatype snapshot repo: https://oss.sonatype.org/content/repositories/snapshots Probably it would be better for me to release 7.1 and to target implementing the final changes to 7.2. Regarding the release ... I would be willing to step up as Release Manager for FlexUnit, BlazeDS, Mavenizer and as soon as it's ready FlexPMD. My new Employer grants me one working day per week for stuff like this and I would be glad to do so. Chris Von: Justin Mclean jus...@classsoftware.com Gesendet: Mittwoch, 27. August 2014 04:23 An: dev@flex.apache.org Betreff: Re: Flex PMD donation Hi, I updated the structure to be more intuitive. Updated to Flexmojos 7.1.0-SNAPSHOT, Apache Flex 4.13.0, Apache FlexUnit 4.2, ... Thanks - hopefully we can get it working. It was quite a lot of work and a big number of Tests will definitely fail, I've fixed a few of those and will check in once I can get teh new structure working. You need a few jars manually deployed as well as Flex 4.13.0 created by the Mavenizer (mavenizer-refactoring branch). Are the step by step instructions on how to do this? I would of guessed that this: java -cp ./target/flex-sdk-converter-1.0.0-SNAPSHOT.jar SDKGenerator $FLEX_HOME ~/.m2 true Would mavinise a SDK and place in to my local repo but (obviously) I don't really know what I'm doing. Currently when trying to build FlexPMD I get: [ERROR] Unresolveable build extension: Plugin net.flexmojos.oss:flexmojos-maven-plugin:7.1.0-SNAPSHOT or one of its dependencies could not be resolved: The following artifacts could not be resolved: net.flexmojos.oss:flexmojos-maven-plugin:jar:7.1.0-SNAPSHOT, net.flexmojos.oss:flexmojos-threadlocaltoolkit-wrapper:jar:7.1.0-SNAPSHOT, org.apache.flex:compiler:pom:4.13.0.20140701: Could not find artifact net.flexmojos.oss:flexmojos-maven-plugin:jar:7.1.0-SNAPSHOT - [Help 2] [ERROR] Unknown packaging: swc @ line 29, column 13 We have so much stuff in a pending state ... finally starting to release our stuff would make things so much easier. For that we need people willing to fix this stuff up and someone to be a release manager. Thanks, Justin
AW: Flex PMD donation
Of course I don't want to do this all in one. My priority would currently be: - Mavenizer - FlexUnit - BlazeDS - FlexPMD Chris Von: Justin Mclean jus...@classsoftware.com Gesendet: Mittwoch, 27. August 2014 08:57 An: dev@flex.apache.org Betreff: Re: Flex PMD donation Hi, Regarding the release ... I would be willing to step up as Release Manager for FlexUnit, BlazeDS, Mavenizer and as soon as it's ready FlexPMD. I'd try one at a time :-) My new Employer grants me one working day per week Nice - more employers should allow that. Thanks, Justin
AW: Flex PMD donation
Hi Guys, ok so I just committed the refactored FlexPMD project (develop branch). I updated the structure to be more intuitive. Updated to Flexmojos 7.1.0-SNAPSHOT, Apache Flex 4.13.0, Apache FlexUnit 4.2, ... It was quite a lot of work and a big number of Tests will definitely fail, cause the Apache Headers have a different size than the Adobe ones and a lot of tests count line numbers or check line numbers of certain lines. I would like to ask you guys to spend a few hours in fixing them. You need a few jars manually deployed as well as Flex 4.13.0 created by the Mavenizer (mavenizer-refactoring branch). We have so much stuff in a pending state ... finally starting to release our stuff would make things so much easier. Chris Von: Justin Mclean jus...@classsoftware.com Gesendet: Dienstag, 26. August 2014 00:43 An: dev@flex.apache.org Betreff: Re: Flex PMD donation Hi, @Justin ... you claimed to have had the build running, I wonder how this is possible. Most of the Unit Tests depend on line numbers. Yep I had to modify a few unit tests to get it to work and I hadn't got all sub projects to compile just 4 or 5. What's currently blocking me, is that the class FlexMetricsReportMojo is depending on some classes, which I simply can't find anywhere: import com.adobe.ac.pmd.metrics.maven.generators.NcssAggregateReportGenerator; import com.adobe.ac.pmd.metrics.maven.generators.NcssReportGenerator; import com.adobe.ac.pmd.metrics.maven.utils.ModuleReport; Didn't get that far so not much help there sorry. Thanks, Justin
AW: AW: Flex PMD donation
Ok, so now I have refactored the entire project structure, streamlined the directory names and artifactIds, groupIds etc. as well as switched to Apache Flex 4.13 and Flexmojos 7.0.0 but I am having some trouble in getting the build working. @Justin ... you claimed to have had the build running, I wonder how this is possible. Most of the Unit Tests depend on line numbers. Due to the fact that the Apache headers have a different size than the old Adobe headers, I had to manually debug a lot of tests and adjust some of these now invalid line numbers. What's currently blocking me, is that the class FlexMetricsReportMojo is depending on some classes, which I simply can't find anywhere: import com.adobe.ac.pmd.metrics.maven.generators.NcssAggregateReportGenerator; import com.adobe.ac.pmd.metrics.maven.generators.NcssReportGenerator; import com.adobe.ac.pmd.metrics.maven.utils.ModuleReport; Unfortunately this module seems to be one of the core modules ... If anyone has seen one of these little buggers ... please bring them back. And don't be surprised. Even if the groupIds have been updated, the packages of PMD still refer to adobe :-( ... guess this will be a lot of work fixing. So anyone here got an idea where these classes could have gone? Chris Von: Frédéric THOMAS webdoubl...@hotmail.com Gesendet: Sonntag, 24. August 2014 13:35 An: dev@flex.apache.org Betreff: RE: AW: Flex PMD donation I was on this as well and can't spend more time on it today, but I arrived at the same conclusions and hate this kind of structure as well, anyway you're are the best person to do it. Thanks, Frédéric THOMAS From: christofer.d...@c-ware.de To: dev@flex.apache.org Subject: AW: Flex PMD donation Date: Sun, 24 Aug 2014 11:20:27 + Hi Justin, well it's not that big of a surprize as the Flexmojos artifacts are publically available. Flexmojos is compiled against an Adobe Flex version that is also publically available, so it will simply have automatically downloaded that old Flex version. But I doubt it's something we should like. I think we should eat our own dogfood. So I guess, cleanning up the maven structure and migrating everything to Flexmojos 7.0.0 and Flex 4.13 would be the best to rid ourselves from problemattic stuff. Chris -Ursprüngliche Nachricht- Von: Justin Mclean [mailto:jus...@classsoftware.com] Gesendet: Sonntag, 24. August 2014 13:15 An: dev@flex.apache.org Betreff: Re: Flex PMD donation Hi, It is built with flexmojos 3.5.0 ... this is insanely old and completely incompatable with Apache Flex. Surprised I managed to get anything to compile. :-) I also saw a lot of the Maven metadata needs updating ... the SCM the DistributionManagement and a lot more still point to Adobe systems. Yep it needs a bit of work. Thanks for looking at it. Justin
AW: Flex PMD donation
I'll have a look at this ... usually in these cases, there's a minimal profile you select to build the initial artifacts and then you can build as normal. Chris -Ursprüngliche Nachricht- Von: Justin Mclean [mailto:jus...@classsoftware.com] Gesendet: Sonntag, 24. August 2014 10:42 An: dev@flex.apache.org Betreff: Flex PMD donation Hi, I've taken a look at Flex PMD to see what it required to become a release and can't make head or tails of the maven setup. It seem to me that each subproject requires all the others to be already compiled - sort of a chicken and egg issue. My knowledge about maven is minimal at best, so would someone who knows a bit more mind taking a look at the poms and explain what's going on / what needs to be done to get everything to compile locally. I am able to compile some sub projects but only if I manually do each one in a specific order. eg this order works for the first few projects as3-parser-api. as3-plugin-utils (test need to be modified for test to pass), flex-pmd-test-resources, flex-pmd-files. Thanks, Justin
AW: Flex PMD donation
Hi Justin, no wonder you were having a hard time with this ;-) It is built with flexmojos 3.5.0 ... this is insanely old and completely incompatable with Apache Flex. Perhaps I should simply update the project to work with Flexmojos 7.0.0 and to use Apache Flex 4.13 But as we have never released Flex officially yet, you would still have to Mavenize 4.13 manually before being able to build it. I also saw a lot of the Maven metadata needs updating ... the SCM the DistributionManagement and a lot more still point to Adobe systems. Sounds like a good thing for me to work on when I'm sitting around in my Hotel during the week ... certainly better than getting a few of these Alt Beers they drink in Düsseldorf (Local speciality beer) ;-) Chris -Ursprüngliche Nachricht- Von: Christofer Dutz [mailto:christofer.d...@c-ware.de] Gesendet: Sonntag, 24. August 2014 12:32 An: dev@flex.apache.org Betreff: AW: Flex PMD donation I'll have a look at this ... usually in these cases, there's a minimal profile you select to build the initial artifacts and then you can build as normal. Chris -Ursprüngliche Nachricht- Von: Justin Mclean [mailto:jus...@classsoftware.com] Gesendet: Sonntag, 24. August 2014 10:42 An: dev@flex.apache.org Betreff: Flex PMD donation Hi, I've taken a look at Flex PMD to see what it required to become a release and can't make head or tails of the maven setup. It seem to me that each subproject requires all the others to be already compiled - sort of a chicken and egg issue. My knowledge about maven is minimal at best, so would someone who knows a bit more mind taking a look at the poms and explain what's going on / what needs to be done to get everything to compile locally. I am able to compile some sub projects but only if I manually do each one in a specific order. eg this order works for the first few projects as3-parser-api. as3-plugin-utils (test need to be modified for test to pass), flex-pmd-test-resources, flex-pmd-files. Thanks, Justin
AW: Flex PMD donation
While I'm at it ... currently all maven artifacts are structured in a flat directory and the parents are found using the relativePath tag ... I greatly dislike projects in this structure. Would there be any objections against me moving things around a little to reflect their natural structure? Currently I had to open a pom and find out what that modules parent was, from that modules pom I got to that modules parent and so on ... at the end I found the root, but I really prefer a pom.xml in the root of the project and to get started from there on. What do you think? Chris -Ursprüngliche Nachricht- Von: Christofer Dutz [mailto:christofer.d...@c-ware.de] Gesendet: Sonntag, 24. August 2014 12:32 An: dev@flex.apache.org Betreff: AW: Flex PMD donation I'll have a look at this ... usually in these cases, there's a minimal profile you select to build the initial artifacts and then you can build as normal. Chris -Ursprüngliche Nachricht- Von: Justin Mclean [mailto:jus...@classsoftware.com] Gesendet: Sonntag, 24. August 2014 10:42 An: dev@flex.apache.org Betreff: Flex PMD donation Hi, I've taken a look at Flex PMD to see what it required to become a release and can't make head or tails of the maven setup. It seem to me that each subproject requires all the others to be already compiled - sort of a chicken and egg issue. My knowledge about maven is minimal at best, so would someone who knows a bit more mind taking a look at the poms and explain what's going on / what needs to be done to get everything to compile locally. I am able to compile some sub projects but only if I manually do each one in a specific order. eg this order works for the first few projects as3-parser-api. as3-plugin-utils (test need to be modified for test to pass), flex-pmd-test-resources, flex-pmd-files. Thanks, Justin
AW: Flex PMD donation
Hi Justin, well it's not that big of a surprize as the Flexmojos artifacts are publically available. Flexmojos is compiled against an Adobe Flex version that is also publically available, so it will simply have automatically downloaded that old Flex version. But I doubt it's something we should like. I think we should eat our own dogfood. So I guess, cleanning up the maven structure and migrating everything to Flexmojos 7.0.0 and Flex 4.13 would be the best to rid ourselves from problemattic stuff. Chris -Ursprüngliche Nachricht- Von: Justin Mclean [mailto:jus...@classsoftware.com] Gesendet: Sonntag, 24. August 2014 13:15 An: dev@flex.apache.org Betreff: Re: Flex PMD donation Hi, It is built with flexmojos 3.5.0 ... this is insanely old and completely incompatable with Apache Flex. Surprised I managed to get anything to compile. :-) I also saw a lot of the Maven metadata needs updating ... the SCM the DistributionManagement and a lot more still point to Adobe systems. Yep it needs a bit of work. Thanks for looking at it. Justin
RE: AW: Flex PMD donation
I was on this as well and can't spend more time on it today, but I arrived at the same conclusions and hate this kind of structure as well, anyway you're are the best person to do it. Thanks, Frédéric THOMAS From: christofer.d...@c-ware.de To: dev@flex.apache.org Subject: AW: Flex PMD donation Date: Sun, 24 Aug 2014 11:20:27 + Hi Justin, well it's not that big of a surprize as the Flexmojos artifacts are publically available. Flexmojos is compiled against an Adobe Flex version that is also publically available, so it will simply have automatically downloaded that old Flex version. But I doubt it's something we should like. I think we should eat our own dogfood. So I guess, cleanning up the maven structure and migrating everything to Flexmojos 7.0.0 and Flex 4.13 would be the best to rid ourselves from problemattic stuff. Chris -Ursprüngliche Nachricht- Von: Justin Mclean [mailto:jus...@classsoftware.com] Gesendet: Sonntag, 24. August 2014 13:15 An: dev@flex.apache.org Betreff: Re: Flex PMD donation Hi, It is built with flexmojos 3.5.0 ... this is insanely old and completely incompatable with Apache Flex. Surprised I managed to get anything to compile. :-) I also saw a lot of the Maven metadata needs updating ... the SCM the DistributionManagement and a lot more still point to Adobe systems. Yep it needs a bit of work. Thanks for looking at it. Justin
