Re: Build failed in Jenkins: flex-sdk_mustella #258

[Justin Mclean]

Hi,

> Never mind, I found the thread where you're discussing this. Read
> first, complain later ;-)
No issue - changes have been reverted so it should be good now. Mean those RTE 
still exist but it's an edge case.

Thanks,
Justin

Re: Build failed in Jenkins: flex-sdk_mustella #258

[Erik de Bruin]

Never mind, I found the thread where you're discussing this. Read
first, complain later ;-)

My bad.

EdB



On Thu, Aug 15, 2013 at 7:40 AM, Erik de Bruin  wrote:
> I'm sorry to keep harassing you about this, but there are still 4
> tests failing :-(
>
> EdB
>
>
>
> On Tue, Aug 13, 2013 at 1:06 PM, Justin Mclean  
> wrote:
>> Hi,
>>
>> I'll sort this out and either fix or revert today.
>>
>> Thanks,
>> Justin
>
>
>
> --
> Ix Multimedia Software
>
> Jan Luykenstraat 27
> 3521 VB Utrecht
>
> T. 06-51952295
> I. www.ixsoftware.nl



-- 
Ix Multimedia Software

Jan Luykenstraat 27
3521 VB Utrecht

T. 06-51952295
I. www.ixsoftware.nl

Re: Build failed in Jenkins: flex-sdk_mustella #258

[Erik de Bruin]

I'm sorry to keep harassing you about this, but there are still 4
tests failing :-(

EdB



On Tue, Aug 13, 2013 at 1:06 PM, Justin Mclean  wrote:
> Hi,
>
> I'll sort this out and either fix or revert today.
>
> Thanks,
> Justin



-- 
Ix Multimedia Software

Jan Luykenstraat 27
3521 VB Utrecht

T. 06-51952295
I. www.ixsoftware.nl

Re: Build failed in Jenkins: flex-sdk_mustella #258

[Justin Mclean]

Hi,

I'll sort this out and either fix or revert today.

Thanks,
Justin

Re: Build failed in Jenkins: flex-sdk_mustella #258

[Alex Harui]

On 8/10/13 5:28 AM, "Justin Mclean"  wrote:

>Hi,
>
>> The commits look like you reverted the ObjectUtil change,
>Yep.
>
>> then checked in the "editable item" code instead of tweaking the
>>creation of the empty
>> column
>I checked in both tweaking the creation of the empty column (see that
>"length" property is excluded if the data is a String).
I was expecting to see a revert of
e47f993773fd5dd7e5c636068d4e9ddd37d3ba98.
Specifically, the following code:

+   if (n == 0) {
+   col = new DataGridColumn();
+   newCols.push(col);
+   }

which I think is independent of the ObjectUtil.as change and may be the
reason the last run still failed?


-Alex

Re: Build failed in Jenkins: flex-sdk_mustella #258

[Justin Mclean]

Hi,

> The commits look like you reverted the ObjectUtil change,
Yep.

> then checked in the "editable item" code instead of tweaking the creation of 
> the empty
> column
I checked in both tweaking the creation of the empty column (see that "length" 
property is excluded if the data is a String).

Justin

Re: Build failed in Jenkins: flex-sdk_mustella #258

[Alex Harui]

Justin,

The commits look like you reverted the ObjectUtil change, then checked in
the "editable item" code instead of tweaking the creation of the empty
column when there are no columns at the time that generateCols gets
called.  Was that intentional?

-Alex

On 8/9/13 5:01 PM, "Justin Mclean"  wrote:

>Hi,
>
>> And now, after all the slack has run out, a gentle 'bump'...
>Should of been fixed this morning, one if the fixes was revered and the
>other should now be more test friendly.
>
>Justin

Re: Build failed in Jenkins: flex-sdk_mustella #258

[Justin Mclean]

Hi,

> And now, after all the slack has run out, a gentle 'bump'...
Should of been fixed this morning, one if the fixes was revered and the other 
should now be more test friendly.

Justin

Re: Build failed in Jenkins: flex-sdk_mustella #258

[Erik de Bruin]

And now, after all the slack has run out, a gentle 'bump'...

:-)

EdB



On Mon, Aug 5, 2013 at 4:33 PM, Erik de Bruin  wrote:
> +1 on the slack cutting :-)
>
> EdB
>
>
>
> On Mon, Aug 5, 2013 at 4:29 PM, Alex Harui  wrote:
>> Not surprising.  Without looking it appears the tests are failing in
>> response to the one change to DataGrid, but it isn't obvious why.
>>
>> At Adobe, the rule was you had to revert so others could check in, and
>> only re-check in when you also had repaired tests to go with them.  But I
>> don't have anything queued for checkin to that repo right now and with the
>> 360|Stack conference starting up and serving as a distraction, I saw we
>> cut Justin some slack on investigating.
>>
>> I'll try to look into the failures as well.
>>
>> -Alex
>>
>> On 8/5/13 7:15 AM, "Erik de Bruin"  wrote:
>>
>>>FYI, the tests fails in all three configurations.
>>>
>>>EdB
>>>
>>>
>>>
>>>On Sun, Aug 4, 2013 at 4:20 PM, Justin Mclean 
>>>wrote:
 Hi

> I think the latest commits really broke a few tests...

 Quite likely there an issue with the tests. I'm not going to be able to
look at it today but can tomorrow.

 Thanks,
 Justin
>>>
>>>
>>>
>>>--
>>>Ix Multimedia Software
>>>
>>>Jan Luykenstraat 27
>>>3521 VB Utrecht
>>>
>>>T. 06-51952295
>>>I. www.ixsoftware.nl
>>
>
>
>
> --
> Ix Multimedia Software
>
> Jan Luykenstraat 27
> 3521 VB Utrecht
>
> T. 06-51952295
> I. www.ixsoftware.nl



-- 
Ix Multimedia Software

Jan Luykenstraat 27
3521 VB Utrecht

T. 06-51952295
I. www.ixsoftware.nl

Re: Build failed in Jenkins: flex-sdk_mustella #258

[Erik de Bruin]

+1 on the slack cutting :-)

EdB



On Mon, Aug 5, 2013 at 4:29 PM, Alex Harui  wrote:
> Not surprising.  Without looking it appears the tests are failing in
> response to the one change to DataGrid, but it isn't obvious why.
>
> At Adobe, the rule was you had to revert so others could check in, and
> only re-check in when you also had repaired tests to go with them.  But I
> don't have anything queued for checkin to that repo right now and with the
> 360|Stack conference starting up and serving as a distraction, I saw we
> cut Justin some slack on investigating.
>
> I'll try to look into the failures as well.
>
> -Alex
>
> On 8/5/13 7:15 AM, "Erik de Bruin"  wrote:
>
>>FYI, the tests fails in all three configurations.
>>
>>EdB
>>
>>
>>
>>On Sun, Aug 4, 2013 at 4:20 PM, Justin Mclean 
>>wrote:
>>> Hi
>>>
 I think the latest commits really broke a few tests...
>>>
>>> Quite likely there an issue with the tests. I'm not going to be able to
>>>look at it today but can tomorrow.
>>>
>>> Thanks,
>>> Justin
>>
>>
>>
>>--
>>Ix Multimedia Software
>>
>>Jan Luykenstraat 27
>>3521 VB Utrecht
>>
>>T. 06-51952295
>>I. www.ixsoftware.nl
>



-- 
Ix Multimedia Software

Jan Luykenstraat 27
3521 VB Utrecht

T. 06-51952295
I. www.ixsoftware.nl

Re: Build failed in Jenkins: flex-sdk_mustella #258

[Alex Harui]

Not surprising.  Without looking it appears the tests are failing in
response to the one change to DataGrid, but it isn't obvious why.

At Adobe, the rule was you had to revert so others could check in, and
only re-check in when you also had repaired tests to go with them.  But I
don't have anything queued for checkin to that repo right now and with the
360|Stack conference starting up and serving as a distraction, I saw we
cut Justin some slack on investigating.

I'll try to look into the failures as well.

-Alex

On 8/5/13 7:15 AM, "Erik de Bruin"  wrote:

>FYI, the tests fails in all three configurations.
>
>EdB
>
>
>
>On Sun, Aug 4, 2013 at 4:20 PM, Justin Mclean 
>wrote:
>> Hi
>>
>>> I think the latest commits really broke a few tests...
>>
>> Quite likely there an issue with the tests. I'm not going to be able to
>>look at it today but can tomorrow.
>>
>> Thanks,
>> Justin
>
>
>
>-- 
>Ix Multimedia Software
>
>Jan Luykenstraat 27
>3521 VB Utrecht
>
>T. 06-51952295
>I. www.ixsoftware.nl

Re: Build failed in Jenkins: flex-sdk_mustella #258

[Erik de Bruin]

FYI, the tests fails in all three configurations.

EdB



On Sun, Aug 4, 2013 at 4:20 PM, Justin Mclean  wrote:
> Hi
>
>> I think the latest commits really broke a few tests...
>
> Quite likely there an issue with the tests. I'm not going to be able to look 
> at it today but can tomorrow.
>
> Thanks,
> Justin



-- 
Ix Multimedia Software

Jan Luykenstraat 27
3521 VB Utrecht

T. 06-51952295
I. www.ixsoftware.nl

Re: Build failed in Jenkins: flex-sdk_mustella #258

[Justin Mclean]

Hi

> I think the latest commits really broke a few tests...

Quite likely there an issue with the tests. I'm not going to be able to look at 
it today but can tomorrow.

Thanks,
Justin

Re: Build failed in Jenkins: flex-sdk_mustella #258

[Erik de Bruin]

I think the latest commits really broke a few tests...

EdB



On Sun, Aug 4, 2013 at 9:08 AM,   wrote:
> See 
>
> Changes:
>
> [jmclean] updated to reflect recent changes
>
> [jmclean] Date updated for Apache Flex 4.10 RC4
>
> [jmclean] FLEX-32959 use calculated height
>
> [jmclean] Don't treat Strings as Objects as the length property gets added 
> and can confuses DataGrid columns
>
> [jmclean] Fixed issue (RTEs) with editable data grid when it has an array of 
> simple values (Number, String etc)
>
> [jmclean] Fixed issue (RTEs) with editable data grid when it has an array of 
> simple values (Number, String etc)
>
> [jmclean] FLEX-32948 Fix to drawing row background
>
> --
> [...truncated 85052 lines...]
>  [java] ClobberProcess, it was already null
>  [java] Grab log, do parse = false
>  [java] Grabbing the log from: 
> C:\Users\ApacheFlex\AppData/Roaming\Macromedia/Flash Player/Logs/flashlog.txt 
> to: 
> C:\jenkins_slave\workspace\flex-sdk_mustella\mustella\tests\gumbo\components\Application\SWFs\Application_Properties_App1.log
>  [java] new test file: 
> C:\jenkins_slave\workspace\flex-sdk_mustella\mustella\tests\gumbo\components\Image\swfs\ImageMain.swf
>  [java]  cmdArr before:
>  [java] 
> C:\ApacheFlex\dependencies\FlashPlayer_Debug\flashplayer11_7r700_232_win_sa_debug.exe
>  [java] 
> C:\jenkins_slave\workspace\flex-sdk_mustella\mustella\tests\gumbo\components\Image\swfs\ImageMain.swf
>  [java]  moreParameters before:
>  [java]  cmdArr after:
>  [java] 
> C:\ApacheFlex\dependencies\FlashPlayer_Debug\flashplayer11_7r700_232_win_sa_debug.exe
>  [java] 
> C:\jenkins_slave\workspace\flex-sdk_mustella\mustella\tests\gumbo\components\Image\swfs\ImageMain.swf
>  [java] getting directory from the swf file
>  [java] derived directory: 
> C:\jenkins_slave\workspace\flex-sdk_mustella\mustella\tests\gumbo\components\Image\swfs
>  [java] Launching:
>  [java]  
> C:\ApacheFlex\dependencies\FlashPlayer_Debug\flashplayer11_7r700_232_win_sa_debug.exe
>  
> C:\jenkins_slave\workspace\flex-sdk_mustella\mustella\tests\gumbo\components\Image\swfs\ImageMain.swf
>  Launching: 
> C:\ApacheFlex\dependencies\FlashPlayer_Debug\flashplayer11_7r700_232_win_sa_debug.exe
>  
> C:\jenkins_slave\workspace\flex-sdk_mustella\mustella\tests\gumbo\components\Image\swfs\ImageMain.swf
>  [java] USING directory: 
> C:\jenkins_slave\workspace\flex-sdk_mustella\mustella\tests\gumbo\components\Image\swfs
>  [java] time: 02:07:47.278
>  [java] SCRIPTDONE! 02:07:51.022
>  [java] GET /ScriptComplete?0 HTTP/1.1
>  [java] Before Wait loop 02:07:51.022 waiting = 0
>  [java] After Wait loop 02:07:51.022 waiting = 0
>  [java] clobberProcess false
>  [java] Total Results so far: 4
>  [java] Grab log, do parse = false
>  [java] Grabbing the log from: 
> C:\Users\ApacheFlex\AppData/Roaming\Macromedia/Flash Player/Logs/flashlog.txt 
> to: 
> C:\jenkins_slave\workspace\flex-sdk_mustella\mustella\tests\gumbo\components\Image\swfs\ImageMain.log
>  [java] new test file: 
> C:\jenkins_slave\workspace\flex-sdk_mustella\mustella\tests\gumbo\components\ListDragDrop\swfs\SparkDNDListBasic.swf
>  [java]  cmdArr before:
>  [java] 
> C:\ApacheFlex\dependencies\FlashPlayer_Debug\flashplayer11_7r700_232_win_sa_debug.exe
>  [java] 
> C:\jenkins_slave\workspace\flex-sdk_mustella\mustella\tests\gumbo\components\ListDragDrop\swfs\SparkDNDListBasic.swf
>  [java]  moreParameters before:
>  [java]  cmdArr after:
>  [java] 
> C:\ApacheFlex\dependencies\FlashPlayer_Debug\flashplayer11_7r700_232_win_sa_debug.exe
>  [java] 
> C:\jenkins_slave\workspace\flex-sdk_mustella\mustella\tests\gumbo\components\ListDragDrop\swfs\SparkDNDListBasic.swf
>  [java] getting directory from the swf file
>  [java] derived directory: 
> C:\jenkins_slave\workspace\flex-sdk_mustella\mustella\tests\gumbo\components\ListDragDrop\swfs
>  [java] Launching:
>  [java]  
> C:\ApacheFlex\dependencies\FlashPlayer_Debug\flashplayer11_7r700_232_win_sa_debug.exe
>  
> C:\jenkins_slave\workspace\flex-sdk_mustella\mustella\tests\gumbo\components\ListDragDrop\swfs\SparkDNDListBasic.swf
>  Launching: 
> C:\ApacheFlex\dependencies\FlashPlayer_Debug\flashplayer11_7r700_232_win_sa_debug.exe
>  
> C:\jenkins_slave\workspace\flex-sdk_mustella\mustella\tests\gumbo\components\ListDragDrop\swfs\SparkDNDListBasic.swf
>  [java] USING directory: 
> C:\jenkins_slave\workspace\flex-sdk_mustella\mustella\tests\gumbo\components\ListDragDrop\swfs
>  [java] time: 02:07:53.366
>  [java] waited 2100
>  [java] ClobberProcess, it was already null
>  [java] SCRIPTDONE! 02:07:58.003
>  [java] GET /ScriptComplete?0 HTTP/1.1
>  [java] Before Wait loop 02:07:58.003 waiting = 0
>  [ja