Re: FlexUnit - code coverage pull request
Hi Mike do you if anything has been done to solve the external dependencies issue so it could be donated to FlexUnit? On 9 October 2013 15:22, Michael A. Labriola labri...@digitalprimates.netwrote: If the patch is small, they should just submit the patch in a JIRA and an ICLA is not required. It will eventually come in via jira but there are other hurdles to pass first. It is using work from others, likely binaries and a ton of other issues that all need to be resolved before the patch can be accepted. That's why I invited them to join the list and talk through it hear. Trying to move the conversations here instead of github. I am also going to make the decision on my own and turn off the flexunit github and site at the end of this month as no one seems to have an opinion as of late. Mike -- João Fernandes
RE: FlexUnit - code coverage pull request
Hi Mike do you if anything has been done to solve the external dependencies issue so it could be donated to FlexUnit? Nothing has been done.
RE: FlexUnit - code coverage pull request
If the patch is small, they should just submit the patch in a JIRA and an ICLA is not required. It will eventually come in via jira but there are other hurdles to pass first. It is using work from others, likely binaries and a ton of other issues that all need to be resolved before the patch can be accepted. That's why I invited them to join the list and talk through it hear. Trying to move the conversations here instead of github. I am also going to make the decision on my own and turn off the flexunit github and site at the end of this month as no one seems to have an opinion as of late. Mike
FlexUnit - code coverage pull request
Hi, Flex Unit with code coverage pull request: https://github.com/flexunit/flexunit/pull/14 Is Flex unit in a state where we can apply pull requests like this? Thanks, Justin
Re: FlexUnit - code coverage pull request
Hi, I guess the first thing to sort out would be who actually wrote the code in that pull request (it's unclear to me) and have they all signed an ICLA? Anyone know? Thanks, Justin
RE: FlexUnit - code coverage pull request
I guess the first thing to sort out would be who actually wrote the code in that pull request (it's unclear to me) and have they all signed an ICLA? They have not yet. That was actually the origin of my previous comment on wondering if I can take the github repo and site offline and start redirecting here so I don't have to keep having that conversation with folks. In this case I already reached out to the committer, asked them to join here and volunteered to work through the process here if they would be willing to resubmit it as a patch against our repos. Mike
RE: FlexUnit - code coverage pull request
If the patch is small, they should just submit the patch in a JIRA and an ICLA is not required. -Alex From: Michael A. Labriola [labri...@digitalprimates.net] Sent: Tuesday, October 08, 2013 6:41 PM To: dev@flex.apache.org Subject: RE: FlexUnit - code coverage pull request I guess the first thing to sort out would be who actually wrote the code in that pull request (it's unclear to me) and have they all signed an ICLA? They have not yet. That was actually the origin of my previous comment on wondering if I can take the github repo and site offline and start redirecting here so I don't have to keep having that conversation with folks. In this case I already reached out to the committer, asked them to join here and volunteered to work through the process here if they would be willing to resubmit it as a patch against our repos. Mike
