Re: [FlexJS] TileLayout.js errors
Before I committed this code I ran it through gjshint without an errors or warnings. So why did this happen now? Seems flaky to me. --peter On 2/22/14 4:23 AM, Erik de Bruin e...@ixsoftware.nl wrote: Committed the fixes for the JSHint errors. EdB On Sat, Feb 22, 2014 at 7:56 AM, Alex Harui aha...@adobe.com wrote: OK, hopefully Peter can clean that up on Monday. Thanks for fixing the other build.xml files. -Alex From: carlos.rov...@gmail.com [carlos.rov...@gmail.com] on behalf of Carlos Rovira [carlosrov...@apache.org] Sent: Friday, February 21, 2014 3:23 PM To: dev@flex.apache.org Subject: [FlexJS] TileLayout.js errors Hi, building flex-asjs is throwing some errors in one of the latest additions: TileLayout.js compile: [echo] running gjslint [exec] 134 files checked, no errors found. [echo] running jshint [exec] FlexJS/src/org/apache/flex/html/staticControls/beads/layouts/TileLayout.j s: line 50, col 1, Expected '}' to have an indentation at 5 instead at 1. [exec] FlexJS/src/org/apache/flex/html/staticControls/beads/layouts/TileLayout.j s: line 60, col 1, Expected '}' to have an indentation at 5 instead at 1. [exec] FlexJS/src/org/apache/flex/html/staticControls/beads/layouts/TileLayout.j s: line 70, col 1, Expected '}' to have an indentation at 5 instead at 1. [exec] FlexJS/src/org/apache/flex/html/staticControls/beads/layouts/TileLayout.j s: line 80, col 1, Expected '}' to have an indentation at 5 instead at 1. [exec] FlexJS/src/org/apache/flex/html/staticControls/beads/layouts/TileLayout.j s: line 90, col 1, Expected '}' to have an indentation at 5 instead at 1. [exec] FlexJS/src/org/apache/flex/html/staticControls/beads/layouts/TileLayout.j s: line 100, col 1, Expected '}' to have an indentation at 5 instead at 1. [exec] FlexJS/src/org/apache/flex/html/staticControls/beads/layouts/TileLayout.j s: line 129, col 9, Use '===' to compare with '0'. [exec] FlexJS/src/org/apache/flex/html/staticControls/beads/layouts/TileLayout.j s: line 153, col 43, Use '===' to compare with '0'. [exec] [exec] 8 errors BUILD FAILED /Users/carlosrovira/dev/apacheflex/flex-asjs/build.xml:399: The following error occurred while executing this line: /Users/carlosrovira/dev/apacheflex/flex-asjs/frameworks/js/build.xml:96: exec returned: 2 I remove the file in my local. maybe I'm missing something? others have the same problem? -- Carlos Rovira http://about.me/carlosrovira -- Ix Multimedia Software Jan Luykenstraat 27 3521 VB Utrecht T. 06-51952295 I. www.ixsoftware.nl
Re: [FlexJS] TileLayout.js errors
These were JSHint errors; the other linter we use ;-) EdB On Mon, Feb 24, 2014 at 4:08 PM, Peter Ent p...@adobe.com wrote: Before I committed this code I ran it through gjshint without an errors or warnings. So why did this happen now? Seems flaky to me. --peter On 2/22/14 4:23 AM, Erik de Bruin e...@ixsoftware.nl wrote: Committed the fixes for the JSHint errors. EdB On Sat, Feb 22, 2014 at 7:56 AM, Alex Harui aha...@adobe.com wrote: OK, hopefully Peter can clean that up on Monday. Thanks for fixing the other build.xml files. -Alex From: carlos.rov...@gmail.com [carlos.rov...@gmail.com] on behalf of Carlos Rovira [carlosrov...@apache.org] Sent: Friday, February 21, 2014 3:23 PM To: dev@flex.apache.org Subject: [FlexJS] TileLayout.js errors Hi, building flex-asjs is throwing some errors in one of the latest additions: TileLayout.js compile: [echo] running gjslint [exec] 134 files checked, no errors found. [echo] running jshint [exec] FlexJS/src/org/apache/flex/html/staticControls/beads/layouts/TileLayout.j s: line 50, col 1, Expected '}' to have an indentation at 5 instead at 1. [exec] FlexJS/src/org/apache/flex/html/staticControls/beads/layouts/TileLayout.j s: line 60, col 1, Expected '}' to have an indentation at 5 instead at 1. [exec] FlexJS/src/org/apache/flex/html/staticControls/beads/layouts/TileLayout.j s: line 70, col 1, Expected '}' to have an indentation at 5 instead at 1. [exec] FlexJS/src/org/apache/flex/html/staticControls/beads/layouts/TileLayout.j s: line 80, col 1, Expected '}' to have an indentation at 5 instead at 1. [exec] FlexJS/src/org/apache/flex/html/staticControls/beads/layouts/TileLayout.j s: line 90, col 1, Expected '}' to have an indentation at 5 instead at 1. [exec] FlexJS/src/org/apache/flex/html/staticControls/beads/layouts/TileLayout.j s: line 100, col 1, Expected '}' to have an indentation at 5 instead at 1. [exec] FlexJS/src/org/apache/flex/html/staticControls/beads/layouts/TileLayout.j s: line 129, col 9, Use '===' to compare with '0'. [exec] FlexJS/src/org/apache/flex/html/staticControls/beads/layouts/TileLayout.j s: line 153, col 43, Use '===' to compare with '0'. [exec] [exec] 8 errors BUILD FAILED /Users/carlosrovira/dev/apacheflex/flex-asjs/build.xml:399: The following error occurred while executing this line: /Users/carlosrovira/dev/apacheflex/flex-asjs/frameworks/js/build.xml:96: exec returned: 2 I remove the file in my local. maybe I'm missing something? others have the same problem? -- Carlos Rovira http://about.me/carlosrovira -- Ix Multimedia Software Jan Luykenstraat 27 3521 VB Utrecht T. 06-51952295 I. www.ixsoftware.nl -- Ix Multimedia Software Jan Luykenstraat 27 3521 VB Utrecht T. 06-51952295 I. www.ixsoftware.nl
Re: [FlexJS] TileLayout.js errors
Ah, got confused by the email thread. Thanks for fixing those up. --peter On 2/24/14 10:10 AM, Erik de Bruin e...@ixsoftware.nl wrote: These were JSHint errors; the other linter we use ;-) EdB On Mon, Feb 24, 2014 at 4:08 PM, Peter Ent p...@adobe.com wrote: Before I committed this code I ran it through gjshint without an errors or warnings. So why did this happen now? Seems flaky to me. --peter On 2/22/14 4:23 AM, Erik de Bruin e...@ixsoftware.nl wrote: Committed the fixes for the JSHint errors. EdB On Sat, Feb 22, 2014 at 7:56 AM, Alex Harui aha...@adobe.com wrote: OK, hopefully Peter can clean that up on Monday. Thanks for fixing the other build.xml files. -Alex From: carlos.rov...@gmail.com [carlos.rov...@gmail.com] on behalf of Carlos Rovira [carlosrov...@apache.org] Sent: Friday, February 21, 2014 3:23 PM To: dev@flex.apache.org Subject: [FlexJS] TileLayout.js errors Hi, building flex-asjs is throwing some errors in one of the latest additions: TileLayout.js compile: [echo] running gjslint [exec] 134 files checked, no errors found. [echo] running jshint [exec] FlexJS/src/org/apache/flex/html/staticControls/beads/layouts/TileLayout .j s: line 50, col 1, Expected '}' to have an indentation at 5 instead at 1. [exec] FlexJS/src/org/apache/flex/html/staticControls/beads/layouts/TileLayout .j s: line 60, col 1, Expected '}' to have an indentation at 5 instead at 1. [exec] FlexJS/src/org/apache/flex/html/staticControls/beads/layouts/TileLayout .j s: line 70, col 1, Expected '}' to have an indentation at 5 instead at 1. [exec] FlexJS/src/org/apache/flex/html/staticControls/beads/layouts/TileLayout .j s: line 80, col 1, Expected '}' to have an indentation at 5 instead at 1. [exec] FlexJS/src/org/apache/flex/html/staticControls/beads/layouts/TileLayout .j s: line 90, col 1, Expected '}' to have an indentation at 5 instead at 1. [exec] FlexJS/src/org/apache/flex/html/staticControls/beads/layouts/TileLayout .j s: line 100, col 1, Expected '}' to have an indentation at 5 instead at 1. [exec] FlexJS/src/org/apache/flex/html/staticControls/beads/layouts/TileLayout .j s: line 129, col 9, Use '===' to compare with '0'. [exec] FlexJS/src/org/apache/flex/html/staticControls/beads/layouts/TileLayout .j s: line 153, col 43, Use '===' to compare with '0'. [exec] [exec] 8 errors BUILD FAILED /Users/carlosrovira/dev/apacheflex/flex-asjs/build.xml:399: The following error occurred while executing this line: /Users/carlosrovira/dev/apacheflex/flex-asjs/frameworks/js/build.xml:96: exec returned: 2 I remove the file in my local. maybe I'm missing something? others have the same problem? -- Carlos Rovira http://about.me/carlosrovira -- Ix Multimedia Software Jan Luykenstraat 27 3521 VB Utrecht T. 06-51952295 I. www.ixsoftware.nl -- Ix Multimedia Software Jan Luykenstraat 27 3521 VB Utrecht T. 06-51952295 I. www.ixsoftware.nl
RE: [FlexJS] TileLayout.js errors
OK, hopefully Peter can clean that up on Monday. Thanks for fixing the other build.xml files. -Alex From: carlos.rov...@gmail.com [carlos.rov...@gmail.com] on behalf of Carlos Rovira [carlosrov...@apache.org] Sent: Friday, February 21, 2014 3:23 PM To: dev@flex.apache.org Subject: [FlexJS] TileLayout.js errors Hi, building flex-asjs is throwing some errors in one of the latest additions: TileLayout.js compile: [echo] running gjslint [exec] 134 files checked, no errors found. [echo] running jshint [exec] FlexJS/src/org/apache/flex/html/staticControls/beads/layouts/TileLayout.js: line 50, col 1, Expected '}' to have an indentation at 5 instead at 1. [exec] FlexJS/src/org/apache/flex/html/staticControls/beads/layouts/TileLayout.js: line 60, col 1, Expected '}' to have an indentation at 5 instead at 1. [exec] FlexJS/src/org/apache/flex/html/staticControls/beads/layouts/TileLayout.js: line 70, col 1, Expected '}' to have an indentation at 5 instead at 1. [exec] FlexJS/src/org/apache/flex/html/staticControls/beads/layouts/TileLayout.js: line 80, col 1, Expected '}' to have an indentation at 5 instead at 1. [exec] FlexJS/src/org/apache/flex/html/staticControls/beads/layouts/TileLayout.js: line 90, col 1, Expected '}' to have an indentation at 5 instead at 1. [exec] FlexJS/src/org/apache/flex/html/staticControls/beads/layouts/TileLayout.js: line 100, col 1, Expected '}' to have an indentation at 5 instead at 1. [exec] FlexJS/src/org/apache/flex/html/staticControls/beads/layouts/TileLayout.js: line 129, col 9, Use '===' to compare with '0'. [exec] FlexJS/src/org/apache/flex/html/staticControls/beads/layouts/TileLayout.js: line 153, col 43, Use '===' to compare with '0'. [exec] [exec] 8 errors BUILD FAILED /Users/carlosrovira/dev/apacheflex/flex-asjs/build.xml:399: The following error occurred while executing this line: /Users/carlosrovira/dev/apacheflex/flex-asjs/frameworks/js/build.xml:96: exec returned: 2 I remove the file in my local. maybe I'm missing something? others have the same problem? -- Carlos Rovira http://about.me/carlosrovira
