Re: [FlexJS] UndoManager

[Harbs]

Very possibly. At such time that we end up with a hodgepodge, I would suggest 
splitting Core into logical pieces. Right now, I don’t see a logical place to 
split pieces out, but I’m open to hearing suggestions.

> On Feb 13, 2017, at 11:27 AM, Carlos Rovira  wrote:
> 
> we could end making it a hodgepodge.

Re: [FlexJS] UndoManager

[Carlos Rovira]

Hi Harbs

2017-02-13 10:09 GMT+01:00 Harbs :

> I have no problem moving it to somewhere other than Core, but I cannot
> think of a more logical place. It does not fit in anywhere.
>
> Unless we create a “Utils” project for all “non-esential” core-like
> functionality, Core seems like the logical place.
>
> The only issue with including it in Core is that the swc is slightly
> bigger and the Core build time is slightly longer. It has no effect on
> applications built using Core.
>

I think people could suggest about what they think, if left where is now or
suggest other place, but for me Core should be that...core...in other way
we could end making it a hodgepodge. It's clear that the code will not go
with you App if you don't reference it, but for the same way of thinking we
could have only one big SWC library. Anyway, for me is only a suggestion
since seems strange to me have it in Core.

Thanks!

Carlos

Re: [FlexJS] UndoManager

[Harbs]

I have no problem moving it to somewhere other than Core, but I cannot think of 
a more logical place. It does not fit in anywhere.

Unless we create a “Utils” project for all “non-esential” core-like 
functionality, Core seems like the logical place.

The only issue with including it in Core is that the swc is slightly bigger and 
the Core build time is slightly longer. It has no effect on applications built 
using Core.

> On Feb 13, 2017, at 10:23 AM, Carlos Rovira  
> wrote:
> 
> Hi,
> 
> I saw the commit, and seems to me that UndoManager is specialized
> functionality. So for me it should not be in "Core".  Make it sense? Let me
> know what you think
> 
> Thanks for creating it :)
> 
> Carlos
> 
> 
> 2017-02-13 0:02 GMT+01:00 Harbs :
> 
>> I just committed this.
>> 
>>> On Feb 12, 2017, at 10:17 PM, Harbs  wrote:
>>> 
>>> I would like to add the tlf UndoManager to FlexJS Core utils.
>>> 
>>> Any objections to my doing so?
>>> 
>>> Harbs
>> 
>> 
> 
> 
> -- 
> 
> Carlos Rovira
> Director General
> M: +34 607 22 60 05
> http://www.codeoscopic.com
> http://www.avant2.es
> 
> Este mensaje se dirige exclusivamente a su destinatario y puede contener
> información privilegiada o confidencial. Si ha recibido este mensaje por
> error, le rogamos que nos lo comunique inmediatamente por esta misma vía y
> proceda a su destrucción.
> 
> De la vigente Ley Orgánica de Protección de Datos (15/1999), le comunicamos
> que sus datos forman parte de un fichero cuyo responsable es CODEOSCOPIC
> S.A. La finalidad de dicho tratamiento es facilitar la prestación del
> servicio o información solicitados, teniendo usted derecho de acceso,
> rectificación, cancelación y oposición de sus datos dirigiéndose a nuestras
> oficinas c/ Paseo de la Habana 9-11, 28036, Madrid con la documentación
> necesaria.

Re: [FlexJS] UndoManager

[Harbs]

I just committed this.

> On Feb 12, 2017, at 10:17 PM, Harbs  wrote:
> 
> I would like to add the tlf UndoManager to FlexJS Core utils.
> 
> Any objections to my doing so?
> 
> Harbs

Re: [FlexJS] UndoManager

[Harbs]

In the past, I’ve used the TLF UndoManager in my projects for full undo and 
added my own IOperations.

Operations are not specific to TLF. Hence my desire to add it to Core.

I’m actually working on porting TLF for FlexJS, but I expect it will be near 
the end of the year before I have anything to commit to the project on that 
front… ;-)

> On Feb 12, 2017, at 10:46 PM, piotrz  wrote:
> 
> Hi Harbs,
> 
> I like UndoManager and I don't see anything wrong to have it in FlexJS. 
> 
> Can you share how you are going to use it in your project? Ho it will help
> you?
> 
> Thanks,
> Piotr
> 
> 
> 
> -
> Apache Flex PMC
> piotrzarzyck...@gmail.com
> --
> View this message in context: 
> http://apache-flex-development.247.n4.nabble.com/FlexJS-UndoManager-tp59260p59261.html
> Sent from the Apache Flex Development mailing list archive at Nabble.com.

Re: [FlexJS] UndoManager

[piotrz]

Hi Harbs,

I like UndoManager and I don't see anything wrong to have it in FlexJS. 

Can you share how you are going to use it in your project? Ho it will help
you?

Thanks,
Piotr



-
Apache Flex PMC
piotrzarzyck...@gmail.com
--
View this message in context: 
http://apache-flex-development.247.n4.nabble.com/FlexJS-UndoManager-tp59260p59261.html
Sent from the Apache Flex Development mailing list archive at Nabble.com.