Re: RTE in TitleWindow

2013-03-09 Thread Alex Harui
NM, I see you mean Spark TW.  No idea.  Really, sounds like a bug, but there
are backward compatibility issues if you change it.

Maybe now is a good time to make sure that 4.10 is actually greater than 4.9
and put a version check around the event type that is dispatched.


On 3/9/13 9:32 PM, Alex Harui aha...@adobe.com wrote:

 Spark TitleWindow or MX TitleWindow
 
 
 On 3/9/13 6:10 PM, Justin Mclean jus...@classsoftware.com wrote:
 
 Hi,
 
 Any one know why TitleWindow dispatches an mx CloseEvent.CLOSE rather than a
 spark PopupEvent.CLOSE? Both have the value close which is a bit naughty
 IMIO.
 
 Justin

-- 
Alex Harui
Flex SDK Team
Adobe Systems, Inc.
http://blogs.adobe.com/aharui



Re: RTE in TitleWindow

2013-03-09 Thread Justin Mclean
Hi,

 NM, I see you mean Spark TW.  No idea.  Really, sounds like a bug, but there
 are backward compatibility issues if you change it.
Yep even if it is a bug I don't think we can change it to be a PopUpEvent. if 
any user code was relying on that event changing it may break quite a few 
applications out there.

I looked a bit more into it and I think I tracked down the error to 
StyeableStageText.as and the the ancestor_closeHandler method. Fix may be as 
simple as changing the method signature to be Event rather than PopUpEvent.

Justin



Re: RTE in TitleWindow

2013-03-09 Thread Alex Harui



On 3/9/13 10:09 PM, Justin Mclean jus...@classsoftware.com wrote:

 Hi,
 
 NM, I see you mean Spark TW.  No idea.  Really, sounds like a bug, but there
 are backward compatibility issues if you change it.
 Yep even if it is a bug I don't think we can change it to be a PopUpEvent. if
 any user code was relying on that event changing it may break quite a few
 applications out there.
 
Well, in the Adobe days, you could change it, but put it behind a version
check.

-- 
Alex Harui
Flex SDK Team
Adobe Systems, Inc.
http://blogs.adobe.com/aharui



Re: RTE in TitleWindow

2013-03-09 Thread Justin Mclean
HI,

 Well, in the Adobe days, you could change it, but put it behind a version
 check.
if any user code listened for a CloseEvent (fairly common I think) we would 
break that so I'm not sure a version check would help.

Justin

Re: RTE in TitleWindow

2013-03-09 Thread Alex Harui



On 3/9/13 10:55 PM, Justin Mclean jus...@classsoftware.com wrote:

 HI,
 
 Well, in the Adobe days, you could change it, but put it behind a version
 check.
 if any user code listened for a CloseEvent (fairly common I think) we would
 break that so I'm not sure a version check would help.
The version check policy says you can break folks, but they can set the
version back to 4.9 and the code will dispatch the old event.

-- 
Alex Harui
Flex SDK Team
Adobe Systems, Inc.
http://blogs.adobe.com/aharui