Re: [VOTE] FLIP-260: Expose Finish Method For TableFunction

2022-09-25 Thread Lincoln Lee
Hi Timo,
Thanks for reminding this, currently ExpressionReducer doesn't support
TableFunction, so it's not mentioned in the flip, but this should be
covered when we start to support it.

Best,
Lincoln Lee


Jingsong Li  于2022年9月23日周五 09:47写道:

> +1 (binding)
>
> Best,
> Jingsong
>
> On Thu, Sep 22, 2022 at 9:45 PM Timo Walther  wrote:
> >
> > +1 (binding)
> >
> > Please make also sure to update ExpressionReducer during implementation.
> > This is not mentioned in the FLIP yet.
> >
> > Thanks,
> > Timo
> >
> > On 22.09.22 10:41, Piotr Nowojski wrote:
> > > +1 (binding)
> > >
> > > czw., 22 wrz 2022 o 08:21 Lincoln Lee 
> napisał(a):
> > >
> > >> Hi everyone,
> > >>
> > >> Thanks for all your feedback for FLIP-260[1] in the discussion
> thread[2],
> > >> I'd
> > >> like to start a vote for it.
> > >>
> > >> The vote will be open for at least 72 hours.
> > >>
> > >> [1]
> > >>
> > >>
> https://cwiki.apache.org/confluence/display/FLINK/FLIP-260%3A+Expose+Finish+Method+For+TableFunction
> > >> [2] https://lists.apache.org/thread/m9hj60p3mntyctkbxrksm8l4d0s4q9dw
> > >>
> > >> Best,
> > >> Lincoln Lee
> > >>
> > >
> >
>


[RESULT][VOTE]FLIP-260: Expose Finish Method For TableFunction

2022-09-25 Thread Lincoln Lee
Hi everyone,

FLIP-260[1] has been accepted.

There are 3 approving votes which are all binding[2]

- Binding: Piotr Nowojski
- Binding: Timo Walther
- Binding: Jingsong Li

None against.

Thanks again to everyone!

[1]
https://cwiki.apache.org/confluence/display/FLINK/FLIP-260%3A+Expose+Finish+Method+For+TableFunction
[2] https://lists.apache.org/thread/nr9wwf98fkw1tk7ycgbcfjjo5g4x8pmz

Best,
Lincoln Lee


Re: [VOTE] FLIP-260: Expose Finish Method For TableFunction

2022-09-22 Thread Jingsong Li
+1 (binding)

Best,
Jingsong

On Thu, Sep 22, 2022 at 9:45 PM Timo Walther  wrote:
>
> +1 (binding)
>
> Please make also sure to update ExpressionReducer during implementation.
> This is not mentioned in the FLIP yet.
>
> Thanks,
> Timo
>
> On 22.09.22 10:41, Piotr Nowojski wrote:
> > +1 (binding)
> >
> > czw., 22 wrz 2022 o 08:21 Lincoln Lee  napisał(a):
> >
> >> Hi everyone,
> >>
> >> Thanks for all your feedback for FLIP-260[1] in the discussion thread[2],
> >> I'd
> >> like to start a vote for it.
> >>
> >> The vote will be open for at least 72 hours.
> >>
> >> [1]
> >>
> >> https://cwiki.apache.org/confluence/display/FLINK/FLIP-260%3A+Expose+Finish+Method+For+TableFunction
> >> [2] https://lists.apache.org/thread/m9hj60p3mntyctkbxrksm8l4d0s4q9dw
> >>
> >> Best,
> >> Lincoln Lee
> >>
> >
>


Re: [VOTE] FLIP-260: Expose Finish Method For TableFunction

2022-09-22 Thread Timo Walther

+1 (binding)

Please make also sure to update ExpressionReducer during implementation. 
This is not mentioned in the FLIP yet.


Thanks,
Timo

On 22.09.22 10:41, Piotr Nowojski wrote:

+1 (binding)

czw., 22 wrz 2022 o 08:21 Lincoln Lee  napisał(a):


Hi everyone,

Thanks for all your feedback for FLIP-260[1] in the discussion thread[2],
I'd
like to start a vote for it.

The vote will be open for at least 72 hours.

[1]

https://cwiki.apache.org/confluence/display/FLINK/FLIP-260%3A+Expose+Finish+Method+For+TableFunction
[2] https://lists.apache.org/thread/m9hj60p3mntyctkbxrksm8l4d0s4q9dw

Best,
Lincoln Lee







Re: [VOTE] FLIP-260: Expose Finish Method For TableFunction

2022-09-22 Thread Piotr Nowojski
+1 (binding)

czw., 22 wrz 2022 o 08:21 Lincoln Lee  napisał(a):

> Hi everyone,
>
> Thanks for all your feedback for FLIP-260[1] in the discussion thread[2],
> I'd
> like to start a vote for it.
>
> The vote will be open for at least 72 hours.
>
> [1]
>
> https://cwiki.apache.org/confluence/display/FLINK/FLIP-260%3A+Expose+Finish+Method+For+TableFunction
> [2] https://lists.apache.org/thread/m9hj60p3mntyctkbxrksm8l4d0s4q9dw
>
> Best,
> Lincoln Lee
>


[VOTE] FLIP-260: Expose Finish Method For TableFunction

2022-09-22 Thread Lincoln Lee
Hi everyone,

Thanks for all your feedback for FLIP-260[1] in the discussion thread[2], I'd
like to start a vote for it.

The vote will be open for at least 72 hours.

[1]
https://cwiki.apache.org/confluence/display/FLINK/FLIP-260%3A+Expose+Finish+Method+For+TableFunction
[2] https://lists.apache.org/thread/m9hj60p3mntyctkbxrksm8l4d0s4q9dw

Best,
Lincoln Lee