[RESULT][VOTE] Release 1.19.0, release candidate #2
Hi everyone, I'm happy to announce that we have unanimously approved this release. There are 24 approving votes, 4 of which are binding: - Xintong Song (binding) - Jean-Baptiste Onofré (non binding) - Ahmed Hamdy (non binding) - Samrat Deb (non binding) - Jeyhun Karimov (non binding) - Hangxiang Yu (non binding) - Yanfei Lei (non binding) - Ron liu (non binding) - Feng Jin (non binding) - Hang Ruan (non binding) - Xuannan Su (non binding) - Jane Chan (non binding) - Rui Fan (non binding) - weijie guo (non binding) - Benchao Li (non binding) - Qingsheng Ren (binding) - Yun Tang (non binding) - Ferenc Csaky (non binding) - gongzhongqiang (non binding) - Martijn Visser (binding) - Sergey Nuyanzin (non binding) - Jing Ge (non binding) - Leonard Xu (binding) - Jiabao Sun (non binding) There are no disapproving votes. Thank you for verifying the release candidate. We will now proceed to finalize the release and announce it once everything is published. Best, Yun, Jing, Martijn and Lincoln
Re: [VOTE] Release 1.19.0, release candidate #2
ped > >>>>>>> identify > >>>>>>> a concurrency issue in the JobMaster shutdown logic which seems > >> to > >>>> be in > >>>>>>> the code for quite some time. I created a PR fixing the issue > >>> hoping > >>>> that > >>>>>>> the test instability is resolved with it. > >>>>>>> > >>>>>>> The concurrency issue doesn't really explain why it only started > >> to > >>>>>>> appear > >>>>>>> recently in a specific CI setup (GHA with AdaptiveScheduler). > >> There > >>>> is no > >>>>>>> hint in the git history indicating that it's caused by some newly > >>>>>>> introduced change. That is why I wouldn't make FLINK-34227 a > >> reason > >>>> to > >>>>>>> cancel rc2. Instead, the fix can be provided in subsequent patch > >>>>>>> releases. > >>>>>>> > >>>>>>> Matthias > >>>>>>> > >>>>>>> [1] https://issues.apache.org/jira/browse/FLINK-34227 > >>>>>>> > >>>>>>> On Thu, Mar 14, 2024 at 8:49 AM Jane Chan qingyue@gmail.com > >>>> wrote: > >>>>>>> > >>>>>>>> Hi Yun, Jing, Martijn and Lincoln, > >>>>>>>> > >>>>>>>> I'm seeking guidance on whether merging the bugfix[1][2] at > >> this > >>>> stage > >>>>>>>> is > >>>>>>>> appropriate. I want to ensure that the actions align with the > >>>> current > >>>>>>>> release process and do not disrupt the ongoing preparations. > >>>>>>>> > >>>>>>>> [1] https://issues.apache.org/jira/browse/FLINK-29114 > >>>>>>>> [2] https://github.com/apache/flink/pull/24492 > >>>>>>>> > >>>>>>>> Best, > >>>>>>>> Jane > >>>>>>>> > >>>>>>>> On Thu, Mar 14, 2024 at 1:33 PM Yun Tang myas...@live.com > >> wrote: > >>>>>>>> > >>>>>>>>> +1 (non-binding) > >>>>>>>>> > >>>>>>>>> * > >>>>>>>>> Verified the signature and checksum. > >>>>>>>>> * > >>>>>>>>> Reviewed the release note PR > >>>>>>>>> * > >>>>>>>>> Reviewed the web announcement PR > >>>>>>>>> * > >>>>>>>>> Start a standalone cluster to submit the state machine > >> example, > >>>> which > >>>>>>>>> works well. > >>>>>>>>> * > >>>>>>>>> Checked the pre-built jars are generated via JDK8 > >>>>>>>>> * > >>>>>>>>> Verified the process profiler works well after setting > >>>>>>>>> rest.profiling.enabled: true > >>>>>>>>> > >>>>>>>>> Best > >>>>>>>>> Yun Tang > >>>>>>>>> > >>>>>>>>> > >>>>>>>>> From: Qingsheng Ren re...@apache.org > >>>>>>>>> Sent: Wednesday, March 13, 2024 12:45 > >>>>>>>>> To: dev@flink.apache.org dev@flink.apache.org > >>>>>>>>> Subject: Re: [VOTE] Release 1.19.0, release candidate #2 > >>>>>>>>> > >>>>>>>>> +1 (binding) > >>>>>>>>> > >>>>>>>>> - Verified signature and checksum > >>>>>>>>> - Verified no binary in source > >>>>>>>>> - Built from source > >>>>>>>>> - Tested reading and writing Kafka with SQL client and Kafka > >>>>>>>>> connector > >>>>>>>>> 3.1.0 > >>>>>>>>> - Verified source code tag > >>>>>>>>> - Reviewed release note > >>>>>>>>> - Reviewed web PR > >&g
Re: [VOTE] Release 1.19.0, release candidate #2
NK-34227 a >> reason >>>> to >>>>>>> cancel rc2. Instead, the fix can be provided in subsequent patch >>>>>>> releases. >>>>>>> >>>>>>> Matthias >>>>>>> >>>>>>> [1] https://issues.apache.org/jira/browse/FLINK-34227 >>>>>>> >>>>>>> On Thu, Mar 14, 2024 at 8:49 AM Jane Chan qingyue@gmail.com >>>> wrote: >>>>>>> >>>>>>>> Hi Yun, Jing, Martijn and Lincoln, >>>>>>>> >>>>>>>> I'm seeking guidance on whether merging the bugfix[1][2] at >> this >>>> stage >>>>>>>> is >>>>>>>> appropriate. I want to ensure that the actions align with the >>>> current >>>>>>>> release process and do not disrupt the ongoing preparations. >>>>>>>> >>>>>>>> [1] https://issues.apache.org/jira/browse/FLINK-29114 >>>>>>>> [2] https://github.com/apache/flink/pull/24492 >>>>>>>> >>>>>>>> Best, >>>>>>>> Jane >>>>>>>> >>>>>>>> On Thu, Mar 14, 2024 at 1:33 PM Yun Tang myas...@live.com >> wrote: >>>>>>>> >>>>>>>>> +1 (non-binding) >>>>>>>>> >>>>>>>>> * >>>>>>>>> Verified the signature and checksum. >>>>>>>>> * >>>>>>>>> Reviewed the release note PR >>>>>>>>> * >>>>>>>>> Reviewed the web announcement PR >>>>>>>>> * >>>>>>>>> Start a standalone cluster to submit the state machine >> example, >>>> which >>>>>>>>> works well. >>>>>>>>> * >>>>>>>>> Checked the pre-built jars are generated via JDK8 >>>>>>>>> * >>>>>>>>> Verified the process profiler works well after setting >>>>>>>>> rest.profiling.enabled: true >>>>>>>>> >>>>>>>>> Best >>>>>>>>> Yun Tang >>>>>>>>> >>>>>>>>> >>>>>>>>> From: Qingsheng Ren re...@apache.org >>>>>>>>> Sent: Wednesday, March 13, 2024 12:45 >>>>>>>>> To: dev@flink.apache.org dev@flink.apache.org >>>>>>>>> Subject: Re: [VOTE] Release 1.19.0, release candidate #2 >>>>>>>>> >>>>>>>>> +1 (binding) >>>>>>>>> >>>>>>>>> - Verified signature and checksum >>>>>>>>> - Verified no binary in source >>>>>>>>> - Built from source >>>>>>>>> - Tested reading and writing Kafka with SQL client and Kafka >>>>>>>>> connector >>>>>>>>> 3.1.0 >>>>>>>>> - Verified source code tag >>>>>>>>> - Reviewed release note >>>>>>>>> - Reviewed web PR >>>>>>>>> >>>>>>>>> Thanks to all release managers and contributors for the >> awesome >>>> work! >>>>>>>>> >>>>>>>>> Best, >>>>>>>>> Qingsheng >>>>>>>>> >>>>>>>>> On Wed, Mar 13, 2024 at 1:23 AM Matthias Pohl >>>>>>>>> matthias.p...@aiven.io.invalid wrote: >>>>>>>>> >>>>>>>>>> I want to share an update on FLINK-34227 [1]: It's still >> not >>>> clear >>>>>>>>>> what's >>>>>>>>>> causing the test instability. So far, we agreed in today's >>>> release >>>>>>>>>> sync >>>>>>>>>> [2] >>>>>>>>>> that it's not considered a blocker because it is observed >> in >>>> 1.18 >>>>>>>>>> nightly >>>>>>>>>> builds and it only appears in the GitHub Actions workflow. >>> But >>>> I >>>>>>>>>>
Re: [VOTE] Release 1.19.0, release candidate #2
> > > > > > recently in a specific CI setup (GHA with AdaptiveScheduler). > > There > > > > is no > > > > > > > hint in the git history indicating that it's caused by some > newly > > > > > > > introduced change. That is why I wouldn't make FLINK-34227 a > > reason > > > > to > > > > > > > cancel rc2. Instead, the fix can be provided in subsequent > patch > > > > > > > releases. > > > > > > > > > > > > > > Matthias > > > > > > > > > > > > > > [1] https://issues.apache.org/jira/browse/FLINK-34227 > > > > > > > > > > > > > > On Thu, Mar 14, 2024 at 8:49 AM Jane Chan > qingyue@gmail.com > > > > wrote: > > > > > > > > > > > > > > > Hi Yun, Jing, Martijn and Lincoln, > > > > > > > > > > > > > > > > I'm seeking guidance on whether merging the bugfix[1][2] at > > this > > > > stage > > > > > > > > is > > > > > > > > appropriate. I want to ensure that the actions align with the > > > > current > > > > > > > > release process and do not disrupt the ongoing preparations. > > > > > > > > > > > > > > > > [1] https://issues.apache.org/jira/browse/FLINK-29114 > > > > > > > > [2] https://github.com/apache/flink/pull/24492 > > > > > > > > > > > > > > > > Best, > > > > > > > > Jane > > > > > > > > > > > > > > > > On Thu, Mar 14, 2024 at 1:33 PM Yun Tang myas...@live.com > > wrote: > > > > > > > > > > > > > > > > > +1 (non-binding) > > > > > > > > > > > > > > > > > > * > > > > > > > > > Verified the signature and checksum. > > > > > > > > > * > > > > > > > > > Reviewed the release note PR > > > > > > > > > * > > > > > > > > > Reviewed the web announcement PR > > > > > > > > > * > > > > > > > > > Start a standalone cluster to submit the state machine > > example, > > > > which > > > > > > > > > works well. > > > > > > > > > * > > > > > > > > > Checked the pre-built jars are generated via JDK8 > > > > > > > > > * > > > > > > > > > Verified the process profiler works well after setting > > > > > > > > > rest.profiling.enabled: true > > > > > > > > > > > > > > > > > > Best > > > > > > > > > Yun Tang > > > > > > > > > > > > > > > > > > > > > > > > > > > From: Qingsheng Ren re...@apache.org > > > > > > > > > Sent: Wednesday, March 13, 2024 12:45 > > > > > > > > > To: dev@flink.apache.org dev@flink.apache.org > > > > > > > > > Subject: Re: [VOTE] Release 1.19.0, release candidate #2 > > > > > > > > > > > > > > > > > > +1 (binding) > > > > > > > > > > > > > > > > > > - Verified signature and checksum > > > > > > > > > - Verified no binary in source > > > > > > > > > - Built from source > > > > > > > > > - Tested reading and writing Kafka with SQL client and > Kafka > > > > > > > > > connector > > > > > > > > > 3.1.0 > > > > > > > > > - Verified source code tag > > > > > > > > > - Reviewed release note > > > > > > > > > - Reviewed web PR > > > > > > > > > > > > > > > > > > Thanks to all release managers and contributors for the > > awesome > > > > work! > > > > > > > > > > > > > > > > > > Best, > > > > > > > > > Qingsheng > > > > > > > > > > > > > > > > > > On Wed, Mar 13, 2024 at 1:23 AM Matthias Pohl > > > > > > > > > matthias.p...@aiv
Re: [VOTE] Release 1.19.0, release candidate #2
t; > > > > > > > > I'm seeking guidance on whether merging the bugfix[1][2] at > this > > > stage > > > > > > > is > > > > > > > appropriate. I want to ensure that the actions align with the > > > current > > > > > > > release process and do not disrupt the ongoing preparations. > > > > > > > > > > > > > > [1] https://issues.apache.org/jira/browse/FLINK-29114 > > > > > > > [2] https://github.com/apache/flink/pull/24492 > > > > > > > > > > > > > > Best, > > > > > > > Jane > > > > > > > > > > > > > > On Thu, Mar 14, 2024 at 1:33 PM Yun Tang myas...@live.com > wrote: > > > > > > > > > > > > > > > +1 (non-binding) > > > > > > > > > > > > > > > > * > > > > > > > > Verified the signature and checksum. > > > > > > > > * > > > > > > > > Reviewed the release note PR > > > > > > > > * > > > > > > > > Reviewed the web announcement PR > > > > > > > > * > > > > > > > > Start a standalone cluster to submit the state machine > example, > > > which > > > > > > > > works well. > > > > > > > > * > > > > > > > > Checked the pre-built jars are generated via JDK8 > > > > > > > > * > > > > > > > > Verified the process profiler works well after setting > > > > > > > > rest.profiling.enabled: true > > > > > > > > > > > > > > > > Best > > > > > > > > Yun Tang > > > > > > > > > > > > > > > > > > > > > > > > From: Qingsheng Ren re...@apache.org > > > > > > > > Sent: Wednesday, March 13, 2024 12:45 > > > > > > > > To: dev@flink.apache.org dev@flink.apache.org > > > > > > > > Subject: Re: [VOTE] Release 1.19.0, release candidate #2 > > > > > > > > > > > > > > > > +1 (binding) > > > > > > > > > > > > > > > > - Verified signature and checksum > > > > > > > > - Verified no binary in source > > > > > > > > - Built from source > > > > > > > > - Tested reading and writing Kafka with SQL client and Kafka > > > > > > > > connector > > > > > > > > 3.1.0 > > > > > > > > - Verified source code tag > > > > > > > > - Reviewed release note > > > > > > > > - Reviewed web PR > > > > > > > > > > > > > > > > Thanks to all release managers and contributors for the > awesome > > > work! > > > > > > > > > > > > > > > > Best, > > > > > > > > Qingsheng > > > > > > > > > > > > > > > > On Wed, Mar 13, 2024 at 1:23 AM Matthias Pohl > > > > > > > > matthias.p...@aiven.io.invalid wrote: > > > > > > > > > > > > > > > > > I want to share an update on FLINK-34227 [1]: It's still > not > > > clear > > > > > > > > > what's > > > > > > > > > causing the test instability. So far, we agreed in today's > > > release > > > > > > > > > sync > > > > > > > > > [2] > > > > > > > > > that it's not considered a blocker because it is observed > in > > > 1.18 > > > > > > > > > nightly > > > > > > > > > builds and it only appears in the GitHub Actions workflow. > > But > > > I > > > > > > > > > still > > > > > > > > > have > > > > > > > > > a bit of a concern that this is something that was > introduced > > > in > > > > > > > > > 1.19 > > > > > > > > > and > > > > > > > > > backported to 1.18 after the 1.18.1 release (because the > test > > > > > > > > > instability > > > > > > > > > started to appear more regularly in March; with
Re: [VOTE] Release 1.19.0, release candidate #2
+1 (binding) - Validated hashes - Verified signature - Verified that no binaries exist in the source archive - Build the source with Maven via mvn clean install -Pcheck-convergence -Dflink.version=1.19.0 - Verified licenses - Verified web PR - Started a cluster and the Flink SQL client, successfully read and wrote with the Kafka connector to Confluent Cloud with AVRO and Schema Registry enabled On Thu, Mar 14, 2024 at 1:32 PM gongzhongqiang wrote: > +1 (non-binding) > > - Verified no binary files in source code > - Verified signature and checksum > - Build source code and run a simple job successfully > - Reviewed the release announcement PR > > Best, > > Zhongqiang Gong > > Ferenc Csaky 于2024年3月14日周四 20:07写道： > > > +1 (non-binding) > > > > - Verified checksum and signature > > - Verified no binary in src > > - Built from src > > - Reviewed release note PR > > - Reviewed web PR > > - Tested a simple datagen query and insert to blackhole sink via SQL > > Gateway > > > > Best, > > Ferenc > > > > > > > > > > On Thursday, March 14th, 2024 at 12:14, Jane Chan > > > wrote: > > > > > > > > > > > Hi Lincoln, > > > > > > Thank you for the prompt response and the effort to provide clarity on > > this > > > matter. > > > > > > Best, > > > Jane > > > > > > On Thu, Mar 14, 2024 at 6:02 PM Lincoln Lee lincoln.8...@gmail.com > > wrote: > > > > > > > Hi Jane, > > > > > > > > Thank you for raising this question. I saw the discussion in the Jira > > > > (include Matthias' point) > > > > and sought advice from several PMCs (including the previous RMs), the > > > > majority of people > > > > are in favor of merging the bugfix into the release branch even > during > > the > > > > release candidate > > > > (RC) voting period, so we should accept all bugfixes (unless there > is a > > > > specific community > > > > rule preventing it). > > > > > > > > Thanks again for contributing to the community! > > > > > > > > Best, > > > > Lincoln Lee > > > > > > > > Matthias Pohl matthias.p...@aiven.io.invalid 于2024年3月14日周四 17:50写道： > > > > > > > > > Update on FLINK-34227 [1] which I mentioned above: Chesnay helped > > > > > identify > > > > > a concurrency issue in the JobMaster shutdown logic which seems to > > be in > > > > > the code for quite some time. I created a PR fixing the issue > hoping > > that > > > > > the test instability is resolved with it. > > > > > > > > > > The concurrency issue doesn't really explain why it only started to > > > > > appear > > > > > recently in a specific CI setup (GHA with AdaptiveScheduler). There > > is no > > > > > hint in the git history indicating that it's caused by some newly > > > > > introduced change. That is why I wouldn't make FLINK-34227 a reason > > to > > > > > cancel rc2. Instead, the fix can be provided in subsequent patch > > > > > releases. > > > > > > > > > > Matthias > > > > > > > > > > [1] https://issues.apache.org/jira/browse/FLINK-34227 > > > > > > > > > > On Thu, Mar 14, 2024 at 8:49 AM Jane Chan qingyue@gmail.com > > wrote: > > > > > > > > > > > Hi Yun, Jing, Martijn and Lincoln, > > > > > > > > > > > > I'm seeking guidance on whether merging the bugfix[1][2] at this > > stage > > > > > > is > > > > > > appropriate. I want to ensure that the actions align with the > > current > > > > > > release process and do not disrupt the ongoing preparations. > > > > > > > > > > > > [1] https://issues.apache.org/jira/browse/FLINK-29114 > > > > > > [2] https://github.com/apache/flink/pull/24492 > > > > > > > > > > > > Best, > > > > > > Jane > > > > > > > > > > > > On Thu, Mar 14, 2024 at 1:33 PM Yun Tang myas...@live.com wrote: > > > > > > > > > > > > > +1 (non-binding) > > > > > > > > > > > > > > * > > > > > > > Verified the signature and checksum. > &g
Re: [VOTE] Release 1.19.0, release candidate #2
+1 (non-binding) - Verified no binary files in source code - Verified signature and checksum - Build source code and run a simple job successfully - Reviewed the release announcement PR Best, Zhongqiang Gong Ferenc Csaky 于2024年3月14日周四 20:07写道： > +1 (non-binding) > > - Verified checksum and signature > - Verified no binary in src > - Built from src > - Reviewed release note PR > - Reviewed web PR > - Tested a simple datagen query and insert to blackhole sink via SQL > Gateway > > Best, > Ferenc > > > > > On Thursday, March 14th, 2024 at 12:14, Jane Chan > wrote: > > > > > > > Hi Lincoln, > > > > Thank you for the prompt response and the effort to provide clarity on > this > > matter. > > > > Best, > > Jane > > > > On Thu, Mar 14, 2024 at 6:02 PM Lincoln Lee lincoln.8...@gmail.com > wrote: > > > > > Hi Jane, > > > > > > Thank you for raising this question. I saw the discussion in the Jira > > > (include Matthias' point) > > > and sought advice from several PMCs (including the previous RMs), the > > > majority of people > > > are in favor of merging the bugfix into the release branch even during > the > > > release candidate > > > (RC) voting period, so we should accept all bugfixes (unless there is a > > > specific community > > > rule preventing it). > > > > > > Thanks again for contributing to the community! > > > > > > Best, > > > Lincoln Lee > > > > > > Matthias Pohl matthias.p...@aiven.io.invalid 于2024年3月14日周四 17:50写道： > > > > > > > Update on FLINK-34227 [1] which I mentioned above: Chesnay helped > > > > identify > > > > a concurrency issue in the JobMaster shutdown logic which seems to > be in > > > > the code for quite some time. I created a PR fixing the issue hoping > that > > > > the test instability is resolved with it. > > > > > > > > The concurrency issue doesn't really explain why it only started to > > > > appear > > > > recently in a specific CI setup (GHA with AdaptiveScheduler). There > is no > > > > hint in the git history indicating that it's caused by some newly > > > > introduced change. That is why I wouldn't make FLINK-34227 a reason > to > > > > cancel rc2. Instead, the fix can be provided in subsequent patch > > > > releases. > > > > > > > > Matthias > > > > > > > > [1] https://issues.apache.org/jira/browse/FLINK-34227 > > > > > > > > On Thu, Mar 14, 2024 at 8:49 AM Jane Chan qingyue@gmail.com > wrote: > > > > > > > > > Hi Yun, Jing, Martijn and Lincoln, > > > > > > > > > > I'm seeking guidance on whether merging the bugfix[1][2] at this > stage > > > > > is > > > > > appropriate. I want to ensure that the actions align with the > current > > > > > release process and do not disrupt the ongoing preparations. > > > > > > > > > > [1] https://issues.apache.org/jira/browse/FLINK-29114 > > > > > [2] https://github.com/apache/flink/pull/24492 > > > > > > > > > > Best, > > > > > Jane > > > > > > > > > > On Thu, Mar 14, 2024 at 1:33 PM Yun Tang myas...@live.com wrote: > > > > > > > > > > > +1 (non-binding) > > > > > > > > > > > > * > > > > > > Verified the signature and checksum. > > > > > > * > > > > > > Reviewed the release note PR > > > > > > * > > > > > > Reviewed the web announcement PR > > > > > > * > > > > > > Start a standalone cluster to submit the state machine example, > which > > > > > > works well. > > > > > > * > > > > > > Checked the pre-built jars are generated via JDK8 > > > > > > * > > > > > > Verified the process profiler works well after setting > > > > > > rest.profiling.enabled: true > > > > > > > > > > > > Best > > > > > > Yun Tang > > > > > > > > > > > > > > > > > > From: Qingsheng Ren re...@apache.org > > > > > > Sent: Wednesday, March 13, 2024 12:45 > > > > > > To: dev@flink.apache.org dev@flin
Re: [VOTE] Release 1.19.0, release candidate #2
+1 (non-binding) - Verified checksum and signature - Verified no binary in src - Built from src - Reviewed release note PR - Reviewed web PR - Tested a simple datagen query and insert to blackhole sink via SQL Gateway Best, Ferenc On Thursday, March 14th, 2024 at 12:14, Jane Chan wrote: > > > Hi Lincoln, > > Thank you for the prompt response and the effort to provide clarity on this > matter. > > Best, > Jane > > On Thu, Mar 14, 2024 at 6:02 PM Lincoln Lee lincoln.8...@gmail.com wrote: > > > Hi Jane, > > > > Thank you for raising this question. I saw the discussion in the Jira > > (include Matthias' point) > > and sought advice from several PMCs (including the previous RMs), the > > majority of people > > are in favor of merging the bugfix into the release branch even during the > > release candidate > > (RC) voting period, so we should accept all bugfixes (unless there is a > > specific community > > rule preventing it). > > > > Thanks again for contributing to the community! > > > > Best, > > Lincoln Lee > > > > Matthias Pohl matthias.p...@aiven.io.invalid 于2024年3月14日周四 17:50写道： > > > > > Update on FLINK-34227 [1] which I mentioned above: Chesnay helped > > > identify > > > a concurrency issue in the JobMaster shutdown logic which seems to be in > > > the code for quite some time. I created a PR fixing the issue hoping that > > > the test instability is resolved with it. > > > > > > The concurrency issue doesn't really explain why it only started to > > > appear > > > recently in a specific CI setup (GHA with AdaptiveScheduler). There is no > > > hint in the git history indicating that it's caused by some newly > > > introduced change. That is why I wouldn't make FLINK-34227 a reason to > > > cancel rc2. Instead, the fix can be provided in subsequent patch > > > releases. > > > > > > Matthias > > > > > > [1] https://issues.apache.org/jira/browse/FLINK-34227 > > > > > > On Thu, Mar 14, 2024 at 8:49 AM Jane Chan qingyue@gmail.com wrote: > > > > > > > Hi Yun, Jing, Martijn and Lincoln, > > > > > > > > I'm seeking guidance on whether merging the bugfix[1][2] at this stage > > > > is > > > > appropriate. I want to ensure that the actions align with the current > > > > release process and do not disrupt the ongoing preparations. > > > > > > > > [1] https://issues.apache.org/jira/browse/FLINK-29114 > > > > [2] https://github.com/apache/flink/pull/24492 > > > > > > > > Best, > > > > Jane > > > > > > > > On Thu, Mar 14, 2024 at 1:33 PM Yun Tang myas...@live.com wrote: > > > > > > > > > +1 (non-binding) > > > > > > > > > > * > > > > > Verified the signature and checksum. > > > > > * > > > > > Reviewed the release note PR > > > > > * > > > > > Reviewed the web announcement PR > > > > > * > > > > > Start a standalone cluster to submit the state machine example, which > > > > > works well. > > > > > * > > > > > Checked the pre-built jars are generated via JDK8 > > > > > * > > > > > Verified the process profiler works well after setting > > > > > rest.profiling.enabled: true > > > > > > > > > > Best > > > > > Yun Tang > > > > > > > > > > > > > > > From: Qingsheng Ren re...@apache.org > > > > > Sent: Wednesday, March 13, 2024 12:45 > > > > > To: dev@flink.apache.org dev@flink.apache.org > > > > > Subject: Re: [VOTE] Release 1.19.0, release candidate #2 > > > > > > > > > > +1 (binding) > > > > > > > > > > - Verified signature and checksum > > > > > - Verified no binary in source > > > > > - Built from source > > > > > - Tested reading and writing Kafka with SQL client and Kafka > > > > > connector > > > > > 3.1.0 > > > > > - Verified source code tag > > > > > - Reviewed release note > > > > > - Reviewed web PR > > > > > > > > > > Thanks to all release managers and contributors for the awesome work! > > > > > > > > > > Be
Re: [VOTE] Release 1.19.0, release candidate #2
Hi Lincoln, Thank you for the prompt response and the effort to provide clarity on this matter. Best, Jane On Thu, Mar 14, 2024 at 6:02 PM Lincoln Lee wrote: > Hi Jane, > > Thank you for raising this question. I saw the discussion in the Jira > (include Matthias' point) > and sought advice from several PMCs (including the previous RMs), the > majority of people > are in favor of merging the bugfix into the release branch even during the > release candidate > (RC) voting period, so we should accept all bugfixes (unless there is a > specific community > rule preventing it). > > Thanks again for contributing to the community! > > Best, > Lincoln Lee > > > Matthias Pohl 于2024年3月14日周四 17:50写道： > > > Update on FLINK-34227 [1] which I mentioned above: Chesnay helped > identify > > a concurrency issue in the JobMaster shutdown logic which seems to be in > > the code for quite some time. I created a PR fixing the issue hoping that > > the test instability is resolved with it. > > > > The concurrency issue doesn't really explain why it only started to > appear > > recently in a specific CI setup (GHA with AdaptiveScheduler). There is no > > hint in the git history indicating that it's caused by some newly > > introduced change. That is why I wouldn't make FLINK-34227 a reason to > > cancel rc2. Instead, the fix can be provided in subsequent patch > releases. > > > > Matthias > > > > [1] https://issues.apache.org/jira/browse/FLINK-34227 > > > > On Thu, Mar 14, 2024 at 8:49 AM Jane Chan wrote: > > > > > Hi Yun, Jing, Martijn and Lincoln, > > > > > > I'm seeking guidance on whether merging the bugfix[1][2] at this stage > is > > > appropriate. I want to ensure that the actions align with the current > > > release process and do not disrupt the ongoing preparations. > > > > > > [1] https://issues.apache.org/jira/browse/FLINK-29114 > > > [2] https://github.com/apache/flink/pull/24492 > > > > > > Best, > > > Jane > > > > > > On Thu, Mar 14, 2024 at 1:33 PM Yun Tang wrote: > > > > > > > +1 (non-binding) > > > > > > > > > > > > * > > > > Verified the signature and checksum. > > > > * > > > > Reviewed the release note PR > > > > * > > > > Reviewed the web announcement PR > > > > * > > > > Start a standalone cluster to submit the state machine example, which > > > > works well. > > > > * > > > > Checked the pre-built jars are generated via JDK8 > > > > * > > > > Verified the process profiler works well after setting > > > > rest.profiling.enabled: true > > > > > > > > Best > > > > Yun Tang > > > > > > > > > > > > From: Qingsheng Ren > > > > Sent: Wednesday, March 13, 2024 12:45 > > > > To: dev@flink.apache.org > > > > Subject: Re: [VOTE] Release 1.19.0, release candidate #2 > > > > > > > > +1 (binding) > > > > > > > > - Verified signature and checksum > > > > - Verified no binary in source > > > > - Built from source > > > > - Tested reading and writing Kafka with SQL client and Kafka > connector > > > > 3.1.0 > > > > - Verified source code tag > > > > - Reviewed release note > > > > - Reviewed web PR > > > > > > > > Thanks to all release managers and contributors for the awesome work! > > > > > > > > Best, > > > > Qingsheng > > > > > > > > On Wed, Mar 13, 2024 at 1:23 AM Matthias Pohl > > > > wrote: > > > > > > > > > I want to share an update on FLINK-34227 [1]: It's still not clear > > > what's > > > > > causing the test instability. So far, we agreed in today's release > > sync > > > > [2] > > > > > that it's not considered a blocker because it is observed in 1.18 > > > nightly > > > > > builds and it only appears in the GitHub Actions workflow. But I > > still > > > > have > > > > > a bit of a concern that this is something that was introduced in > 1.19 > > > and > > > > > backported to 1.18 after the 1.18.1 release (because the test > > > instability > > > > > started to appear more regularly in March; with one occurrence in > >
Re: [VOTE] Release 1.19.0, release candidate #2
Hi Matthias, Thanks for the updating! And once again, thank you for continuously tracking all unstable cases and driving the resolution! Best, Lincoln Lee Lincoln Lee 于2024年3月14日周四 18:00写道： > Hi Jane, > > Thank you for raising this question. I saw the discussion in the Jira > (include Matthias' point) > and sought advice from several PMCs (including the previous RMs), the > majority of people > are in favor of merging the bugfix into the release branch even during the > release candidate > (RC) voting period, so we should accept all bugfixes (unless there is a > specific community > rule preventing it). > > Thanks again for contributing to the community! > > Best, > Lincoln Lee > > > Matthias Pohl 于2024年3月14日周四 17:50写道： > >> Update on FLINK-34227 [1] which I mentioned above: Chesnay helped identify >> a concurrency issue in the JobMaster shutdown logic which seems to be in >> the code for quite some time. I created a PR fixing the issue hoping that >> the test instability is resolved with it. >> >> The concurrency issue doesn't really explain why it only started to appear >> recently in a specific CI setup (GHA with AdaptiveScheduler). There is no >> hint in the git history indicating that it's caused by some newly >> introduced change. That is why I wouldn't make FLINK-34227 a reason to >> cancel rc2. Instead, the fix can be provided in subsequent patch releases. >> >> Matthias >> >> [1] https://issues.apache.org/jira/browse/FLINK-34227 >> >> On Thu, Mar 14, 2024 at 8:49 AM Jane Chan wrote: >> >> > Hi Yun, Jing, Martijn and Lincoln, >> > >> > I'm seeking guidance on whether merging the bugfix[1][2] at this stage >> is >> > appropriate. I want to ensure that the actions align with the current >> > release process and do not disrupt the ongoing preparations. >> > >> > [1] https://issues.apache.org/jira/browse/FLINK-29114 >> > [2] https://github.com/apache/flink/pull/24492 >> > >> > Best, >> > Jane >> > >> > On Thu, Mar 14, 2024 at 1:33 PM Yun Tang wrote: >> > >> > > +1 (non-binding) >> > > >> > > >> > > * >> > > Verified the signature and checksum. >> > > * >> > > Reviewed the release note PR >> > > * >> > > Reviewed the web announcement PR >> > > * >> > > Start a standalone cluster to submit the state machine example, which >> > > works well. >> > > * >> > > Checked the pre-built jars are generated via JDK8 >> > > * >> > > Verified the process profiler works well after setting >> > > rest.profiling.enabled: true >> > > >> > > Best >> > > Yun Tang >> > > >> > > >> > > From: Qingsheng Ren >> > > Sent: Wednesday, March 13, 2024 12:45 >> > > To: dev@flink.apache.org >> > > Subject: Re: [VOTE] Release 1.19.0, release candidate #2 >> > > >> > > +1 (binding) >> > > >> > > - Verified signature and checksum >> > > - Verified no binary in source >> > > - Built from source >> > > - Tested reading and writing Kafka with SQL client and Kafka connector >> > > 3.1.0 >> > > - Verified source code tag >> > > - Reviewed release note >> > > - Reviewed web PR >> > > >> > > Thanks to all release managers and contributors for the awesome work! >> > > >> > > Best, >> > > Qingsheng >> > > >> > > On Wed, Mar 13, 2024 at 1:23 AM Matthias Pohl >> > > wrote: >> > > >> > > > I want to share an update on FLINK-34227 [1]: It's still not clear >> > what's >> > > > causing the test instability. So far, we agreed in today's release >> sync >> > > [2] >> > > > that it's not considered a blocker because it is observed in 1.18 >> > nightly >> > > > builds and it only appears in the GitHub Actions workflow. But I >> still >> > > have >> > > > a bit of a concern that this is something that was introduced in >> 1.19 >> > and >> > > > backported to 1.18 after the 1.18.1 release (because the test >> > instability >> > > > started to appear more regularly in March; with one occurrence in >> > > January). >> > > > Additionally, I have no r
Re: [VOTE] Release 1.19.0, release candidate #2
Hi Jane, Thank you for raising this question. I saw the discussion in the Jira (include Matthias' point) and sought advice from several PMCs (including the previous RMs), the majority of people are in favor of merging the bugfix into the release branch even during the release candidate (RC) voting period, so we should accept all bugfixes (unless there is a specific community rule preventing it). Thanks again for contributing to the community! Best, Lincoln Lee Matthias Pohl 于2024年3月14日周四 17:50写道： > Update on FLINK-34227 [1] which I mentioned above: Chesnay helped identify > a concurrency issue in the JobMaster shutdown logic which seems to be in > the code for quite some time. I created a PR fixing the issue hoping that > the test instability is resolved with it. > > The concurrency issue doesn't really explain why it only started to appear > recently in a specific CI setup (GHA with AdaptiveScheduler). There is no > hint in the git history indicating that it's caused by some newly > introduced change. That is why I wouldn't make FLINK-34227 a reason to > cancel rc2. Instead, the fix can be provided in subsequent patch releases. > > Matthias > > [1] https://issues.apache.org/jira/browse/FLINK-34227 > > On Thu, Mar 14, 2024 at 8:49 AM Jane Chan wrote: > > > Hi Yun, Jing, Martijn and Lincoln, > > > > I'm seeking guidance on whether merging the bugfix[1][2] at this stage is > > appropriate. I want to ensure that the actions align with the current > > release process and do not disrupt the ongoing preparations. > > > > [1] https://issues.apache.org/jira/browse/FLINK-29114 > > [2] https://github.com/apache/flink/pull/24492 > > > > Best, > > Jane > > > > On Thu, Mar 14, 2024 at 1:33 PM Yun Tang wrote: > > > > > +1 (non-binding) > > > > > > > > > * > > > Verified the signature and checksum. > > > * > > > Reviewed the release note PR > > > * > > > Reviewed the web announcement PR > > > * > > > Start a standalone cluster to submit the state machine example, which > > > works well. > > > * > > > Checked the pre-built jars are generated via JDK8 > > > * > > > Verified the process profiler works well after setting > > > rest.profiling.enabled: true > > > > > > Best > > > Yun Tang > > > > > > > > > From: Qingsheng Ren > > > Sent: Wednesday, March 13, 2024 12:45 > > > To: dev@flink.apache.org > > > Subject: Re: [VOTE] Release 1.19.0, release candidate #2 > > > > > > +1 (binding) > > > > > > - Verified signature and checksum > > > - Verified no binary in source > > > - Built from source > > > - Tested reading and writing Kafka with SQL client and Kafka connector > > > 3.1.0 > > > - Verified source code tag > > > - Reviewed release note > > > - Reviewed web PR > > > > > > Thanks to all release managers and contributors for the awesome work! > > > > > > Best, > > > Qingsheng > > > > > > On Wed, Mar 13, 2024 at 1:23 AM Matthias Pohl > > > wrote: > > > > > > > I want to share an update on FLINK-34227 [1]: It's still not clear > > what's > > > > causing the test instability. So far, we agreed in today's release > sync > > > [2] > > > > that it's not considered a blocker because it is observed in 1.18 > > nightly > > > > builds and it only appears in the GitHub Actions workflow. But I > still > > > have > > > > a bit of a concern that this is something that was introduced in 1.19 > > and > > > > backported to 1.18 after the 1.18.1 release (because the test > > instability > > > > started to appear more regularly in March; with one occurrence in > > > January). > > > > Additionally, I have no reason to believe, yet, that the instability > is > > > > caused by some GHA-related infrastructure issue. > > > > > > > > So, if someone else has some capacity to help looking into it; that > > would > > > > be appreciated. I will continue my investigation tomorrow. > > > > > > > > Best, > > > > Matthias > > > > > > > > [1] https://issues.apache.org/jira/browse/FLINK-34227 > > > > [2] > > > > > > > > > > > > > > https://cwiki.apache.org/confluence/display/FLINK/1.19+Release#id-1.19Release-03/12/2024 &g
Re: [VOTE] Release 1.19.0, release candidate #2
Update on FLINK-34227 [1] which I mentioned above: Chesnay helped identify a concurrency issue in the JobMaster shutdown logic which seems to be in the code for quite some time. I created a PR fixing the issue hoping that the test instability is resolved with it. The concurrency issue doesn't really explain why it only started to appear recently in a specific CI setup (GHA with AdaptiveScheduler). There is no hint in the git history indicating that it's caused by some newly introduced change. That is why I wouldn't make FLINK-34227 a reason to cancel rc2. Instead, the fix can be provided in subsequent patch releases. Matthias [1] https://issues.apache.org/jira/browse/FLINK-34227 On Thu, Mar 14, 2024 at 8:49 AM Jane Chan wrote: > Hi Yun, Jing, Martijn and Lincoln, > > I'm seeking guidance on whether merging the bugfix[1][2] at this stage is > appropriate. I want to ensure that the actions align with the current > release process and do not disrupt the ongoing preparations. > > [1] https://issues.apache.org/jira/browse/FLINK-29114 > [2] https://github.com/apache/flink/pull/24492 > > Best, > Jane > > On Thu, Mar 14, 2024 at 1:33 PM Yun Tang wrote: > > > +1 (non-binding) > > > > > > * > > Verified the signature and checksum. > > * > > Reviewed the release note PR > > * > > Reviewed the web announcement PR > > * > > Start a standalone cluster to submit the state machine example, which > > works well. > > * > > Checked the pre-built jars are generated via JDK8 > > * > > Verified the process profiler works well after setting > > rest.profiling.enabled: true > > > > Best > > Yun Tang > > > > ________ > > From: Qingsheng Ren > > Sent: Wednesday, March 13, 2024 12:45 > > To: dev@flink.apache.org > > Subject: Re: [VOTE] Release 1.19.0, release candidate #2 > > > > +1 (binding) > > > > - Verified signature and checksum > > - Verified no binary in source > > - Built from source > > - Tested reading and writing Kafka with SQL client and Kafka connector > > 3.1.0 > > - Verified source code tag > > - Reviewed release note > > - Reviewed web PR > > > > Thanks to all release managers and contributors for the awesome work! > > > > Best, > > Qingsheng > > > > On Wed, Mar 13, 2024 at 1:23 AM Matthias Pohl > > wrote: > > > > > I want to share an update on FLINK-34227 [1]: It's still not clear > what's > > > causing the test instability. So far, we agreed in today's release sync > > [2] > > > that it's not considered a blocker because it is observed in 1.18 > nightly > > > builds and it only appears in the GitHub Actions workflow. But I still > > have > > > a bit of a concern that this is something that was introduced in 1.19 > and > > > backported to 1.18 after the 1.18.1 release (because the test > instability > > > started to appear more regularly in March; with one occurrence in > > January). > > > Additionally, I have no reason to believe, yet, that the instability is > > > caused by some GHA-related infrastructure issue. > > > > > > So, if someone else has some capacity to help looking into it; that > would > > > be appreciated. I will continue my investigation tomorrow. > > > > > > Best, > > > Matthias > > > > > > [1] https://issues.apache.org/jira/browse/FLINK-34227 > > > [2] > > > > > > > > > https://cwiki.apache.org/confluence/display/FLINK/1.19+Release#id-1.19Release-03/12/2024 > > > > > > On Tue, Mar 12, 2024 at 12:50 PM Benchao Li > > wrote: > > > > > > > +1 (non-binding) > > > > > > > > - checked signature and checksum: OK > > > > - checkout copyright year in notice file: OK > > > > - diffed source distribution with tag, make sure there is no > > > > unexpected files: OK > > > > - build from source : OK > > > > - start a local cluster, played with jdbc connector: OK > > > > > > > > weijie guo 于2024年3月12日周二 16:55写道： > > > > > > > > > > +1 (non-binding) > > > > > > > > > > - Verified signature and checksum > > > > > - Verified source distribution does not contains binaries > > > > > - Build from source code and submit a word-count job successfully > > > > > > > > > > > > > > > Best regards, > > > > > > > > > > Weijie >
Re: [VOTE] Release 1.19.0, release candidate #2
Hi Yun, Jing, Martijn and Lincoln, I'm seeking guidance on whether merging the bugfix[1][2] at this stage is appropriate. I want to ensure that the actions align with the current release process and do not disrupt the ongoing preparations. [1] https://issues.apache.org/jira/browse/FLINK-29114 [2] https://github.com/apache/flink/pull/24492 Best, Jane On Thu, Mar 14, 2024 at 1:33 PM Yun Tang wrote: > +1 (non-binding) > > > * > Verified the signature and checksum. > * > Reviewed the release note PR > * > Reviewed the web announcement PR > * > Start a standalone cluster to submit the state machine example, which > works well. > * > Checked the pre-built jars are generated via JDK8 > * > Verified the process profiler works well after setting > rest.profiling.enabled: true > > Best > Yun Tang > > > From: Qingsheng Ren > Sent: Wednesday, March 13, 2024 12:45 > To: dev@flink.apache.org > Subject: Re: [VOTE] Release 1.19.0, release candidate #2 > > +1 (binding) > > - Verified signature and checksum > - Verified no binary in source > - Built from source > - Tested reading and writing Kafka with SQL client and Kafka connector > 3.1.0 > - Verified source code tag > - Reviewed release note > - Reviewed web PR > > Thanks to all release managers and contributors for the awesome work! > > Best, > Qingsheng > > On Wed, Mar 13, 2024 at 1:23 AM Matthias Pohl > wrote: > > > I want to share an update on FLINK-34227 [1]: It's still not clear what's > > causing the test instability. So far, we agreed in today's release sync > [2] > > that it's not considered a blocker because it is observed in 1.18 nightly > > builds and it only appears in the GitHub Actions workflow. But I still > have > > a bit of a concern that this is something that was introduced in 1.19 and > > backported to 1.18 after the 1.18.1 release (because the test instability > > started to appear more regularly in March; with one occurrence in > January). > > Additionally, I have no reason to believe, yet, that the instability is > > caused by some GHA-related infrastructure issue. > > > > So, if someone else has some capacity to help looking into it; that would > > be appreciated. I will continue my investigation tomorrow. > > > > Best, > > Matthias > > > > [1] https://issues.apache.org/jira/browse/FLINK-34227 > > [2] > > > > > https://cwiki.apache.org/confluence/display/FLINK/1.19+Release#id-1.19Release-03/12/2024 > > > > On Tue, Mar 12, 2024 at 12:50 PM Benchao Li > wrote: > > > > > +1 (non-binding) > > > > > > - checked signature and checksum: OK > > > - checkout copyright year in notice file: OK > > > - diffed source distribution with tag, make sure there is no > > > unexpected files: OK > > > - build from source : OK > > > - start a local cluster, played with jdbc connector: OK > > > > > > weijie guo 于2024年3月12日周二 16:55写道： > > > > > > > > +1 (non-binding) > > > > > > > > - Verified signature and checksum > > > > - Verified source distribution does not contains binaries > > > > - Build from source code and submit a word-count job successfully > > > > > > > > > > > > Best regards, > > > > > > > > Weijie > > > > > > > > > > > > Jane Chan 于2024年3月12日周二 16:38写道： > > > > > > > > > +1 (non-binding) > > > > > > > > > > - Verify that the source distributions do not contain any binaries; > > > > > - Build the source distribution to ensure all source files have > > Apache > > > > > headers; > > > > > - Verify checksum and GPG signatures; > > > > > > > > > > Best, > > > > > Jane > > > > > > > > > > On Tue, Mar 12, 2024 at 4:08 PM Xuannan Su > > > wrote: > > > > > > > > > > > +1 (non-binding) > > > > > > > > > > > > - Verified signature and checksum > > > > > > - Verified that source distribution does not contain binaries > > > > > > - Built from source code successfully > > > > > > - Reviewed the release announcement PR > > > > > > > > > > > > Best regards, > > > > > > Xuannan > > > > > > > > > > > > On Tue, Mar 12, 2024 at 2:18 PM Hang Ruan < > ruanhang1...@gmail.c
Re: [VOTE] Release 1.19.0, release candidate #2
+1 (non-binding) * Verified the signature and checksum. * Reviewed the release note PR * Reviewed the web announcement PR * Start a standalone cluster to submit the state machine example, which works well. * Checked the pre-built jars are generated via JDK8 * Verified the process profiler works well after setting rest.profiling.enabled: true Best Yun Tang From: Qingsheng Ren Sent: Wednesday, March 13, 2024 12:45 To: dev@flink.apache.org Subject: Re: [VOTE] Release 1.19.0, release candidate #2 +1 (binding) - Verified signature and checksum - Verified no binary in source - Built from source - Tested reading and writing Kafka with SQL client and Kafka connector 3.1.0 - Verified source code tag - Reviewed release note - Reviewed web PR Thanks to all release managers and contributors for the awesome work! Best, Qingsheng On Wed, Mar 13, 2024 at 1:23 AM Matthias Pohl wrote: > I want to share an update on FLINK-34227 [1]: It's still not clear what's > causing the test instability. So far, we agreed in today's release sync [2] > that it's not considered a blocker because it is observed in 1.18 nightly > builds and it only appears in the GitHub Actions workflow. But I still have > a bit of a concern that this is something that was introduced in 1.19 and > backported to 1.18 after the 1.18.1 release (because the test instability > started to appear more regularly in March; with one occurrence in January). > Additionally, I have no reason to believe, yet, that the instability is > caused by some GHA-related infrastructure issue. > > So, if someone else has some capacity to help looking into it; that would > be appreciated. I will continue my investigation tomorrow. > > Best, > Matthias > > [1] https://issues.apache.org/jira/browse/FLINK-34227 > [2] > > https://cwiki.apache.org/confluence/display/FLINK/1.19+Release#id-1.19Release-03/12/2024 > > On Tue, Mar 12, 2024 at 12:50 PM Benchao Li wrote: > > > +1 (non-binding) > > > > - checked signature and checksum: OK > > - checkout copyright year in notice file: OK > > - diffed source distribution with tag, make sure there is no > > unexpected files: OK > > - build from source : OK > > - start a local cluster, played with jdbc connector: OK > > > > weijie guo 于2024年3月12日周二 16:55写道： > > > > > > +1 (non-binding) > > > > > > - Verified signature and checksum > > > - Verified source distribution does not contains binaries > > > - Build from source code and submit a word-count job successfully > > > > > > > > > Best regards, > > > > > > Weijie > > > > > > > > > Jane Chan 于2024年3月12日周二 16:38写道： > > > > > > > +1 (non-binding) > > > > > > > > - Verify that the source distributions do not contain any binaries; > > > > - Build the source distribution to ensure all source files have > Apache > > > > headers; > > > > - Verify checksum and GPG signatures; > > > > > > > > Best, > > > > Jane > > > > > > > > On Tue, Mar 12, 2024 at 4:08 PM Xuannan Su > > wrote: > > > > > > > > > +1 (non-binding) > > > > > > > > > > - Verified signature and checksum > > > > > - Verified that source distribution does not contain binaries > > > > > - Built from source code successfully > > > > > - Reviewed the release announcement PR > > > > > > > > > > Best regards, > > > > > Xuannan > > > > > > > > > > On Tue, Mar 12, 2024 at 2:18 PM Hang Ruan > > > > wrote: > > > > > > > > > > > > +1 (non-binding) > > > > > > > > > > > > - Verified signatures and checksums > > > > > > - Verified that source does not contain binaries > > > > > > - Build source code successfully > > > > > > - Reviewed the release note and left a comment > > > > > > > > > > > > Best, > > > > > > Hang > > > > > > > > > > > > Feng Jin 于2024年3月12日周二 11:23写道： > > > > > > > > > > > > > +1 (non-binding) > > > > > > > > > > > > > > - Verified signatures and checksums > > > > > > > - Verified that source does not contain binaries > > > > > > > - Build source code successfully > > > > > > > - Run a simple sql query successfully > > > > &g
Re: [VOTE] Release 1.19.0, release candidate #2
+1 (binding) - Verified signature and checksum - Verified no binary in source - Built from source - Tested reading and writing Kafka with SQL client and Kafka connector 3.1.0 - Verified source code tag - Reviewed release note - Reviewed web PR Thanks to all release managers and contributors for the awesome work! Best, Qingsheng On Wed, Mar 13, 2024 at 1:23 AM Matthias Pohl wrote: > I want to share an update on FLINK-34227 [1]: It's still not clear what's > causing the test instability. So far, we agreed in today's release sync [2] > that it's not considered a blocker because it is observed in 1.18 nightly > builds and it only appears in the GitHub Actions workflow. But I still have > a bit of a concern that this is something that was introduced in 1.19 and > backported to 1.18 after the 1.18.1 release (because the test instability > started to appear more regularly in March; with one occurrence in January). > Additionally, I have no reason to believe, yet, that the instability is > caused by some GHA-related infrastructure issue. > > So, if someone else has some capacity to help looking into it; that would > be appreciated. I will continue my investigation tomorrow. > > Best, > Matthias > > [1] https://issues.apache.org/jira/browse/FLINK-34227 > [2] > > https://cwiki.apache.org/confluence/display/FLINK/1.19+Release#id-1.19Release-03/12/2024 > > On Tue, Mar 12, 2024 at 12:50 PM Benchao Li wrote: > > > +1 (non-binding) > > > > - checked signature and checksum: OK > > - checkout copyright year in notice file: OK > > - diffed source distribution with tag, make sure there is no > > unexpected files: OK > > - build from source : OK > > - start a local cluster, played with jdbc connector: OK > > > > weijie guo 于2024年3月12日周二 16:55写道： > > > > > > +1 (non-binding) > > > > > > - Verified signature and checksum > > > - Verified source distribution does not contains binaries > > > - Build from source code and submit a word-count job successfully > > > > > > > > > Best regards, > > > > > > Weijie > > > > > > > > > Jane Chan 于2024年3月12日周二 16:38写道： > > > > > > > +1 (non-binding) > > > > > > > > - Verify that the source distributions do not contain any binaries; > > > > - Build the source distribution to ensure all source files have > Apache > > > > headers; > > > > - Verify checksum and GPG signatures; > > > > > > > > Best, > > > > Jane > > > > > > > > On Tue, Mar 12, 2024 at 4:08 PM Xuannan Su > > wrote: > > > > > > > > > +1 (non-binding) > > > > > > > > > > - Verified signature and checksum > > > > > - Verified that source distribution does not contain binaries > > > > > - Built from source code successfully > > > > > - Reviewed the release announcement PR > > > > > > > > > > Best regards, > > > > > Xuannan > > > > > > > > > > On Tue, Mar 12, 2024 at 2:18 PM Hang Ruan > > > > wrote: > > > > > > > > > > > > +1 (non-binding) > > > > > > > > > > > > - Verified signatures and checksums > > > > > > - Verified that source does not contain binaries > > > > > > - Build source code successfully > > > > > > - Reviewed the release note and left a comment > > > > > > > > > > > > Best, > > > > > > Hang > > > > > > > > > > > > Feng Jin 于2024年3月12日周二 11:23写道： > > > > > > > > > > > > > +1 (non-binding) > > > > > > > > > > > > > > - Verified signatures and checksums > > > > > > > - Verified that source does not contain binaries > > > > > > > - Build source code successfully > > > > > > > - Run a simple sql query successfully > > > > > > > > > > > > > > Best, > > > > > > > Feng Jin > > > > > > > > > > > > > > > > > > > > > On Tue, Mar 12, 2024 at 11:09 AM Ron liu > > wrote: > > > > > > > > > > > > > > > +1 (non binding) > > > > > > > > > > > > > > > > quickly verified: > > > > > > > > - verified that source distribution does not contain binaries > > > > > > > > - verified checksums > > > > > > > > - built source code successfully > > > > > > > > > > > > > > > > > > > > > > > > Best, > > > > > > > > Ron > > > > > > > > > > > > > > > > Jeyhun Karimov 于2024年3月12日周二 01:00写道： > > > > > > > > > > > > > > > > > +1 (non binding) > > > > > > > > > > > > > > > > > > - verified that source distribution does not contain > binaries > > > > > > > > > - verified signatures and checksums > > > > > > > > > - built source code successfully > > > > > > > > > > > > > > > > > > Regards, > > > > > > > > > Jeyhun > > > > > > > > > > > > > > > > > > > > > > > > > > > On Mon, Mar 11, 2024 at 3:08 PM Samrat Deb < > > > > decordea...@gmail.com> > > > > > > > > wrote: > > > > > > > > > > > > > > > > > > > +1 (non binding) > > > > > > > > > > > > > > > > > > > > - verified signatures and checksums > > > > > > > > > > - ASF headers are present in all expected file > > > > > > > > > > - No unexpected binaries files found in the source > > > > > > > > > > - Build successful locally > > > > > > > > > > - tested basic word count example > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > Bests, > > > > > > >
Re: [VOTE] Release 1.19.0, release candidate #2
I want to share an update on FLINK-34227 [1]: It's still not clear what's causing the test instability. So far, we agreed in today's release sync [2] that it's not considered a blocker because it is observed in 1.18 nightly builds and it only appears in the GitHub Actions workflow. But I still have a bit of a concern that this is something that was introduced in 1.19 and backported to 1.18 after the 1.18.1 release (because the test instability started to appear more regularly in March; with one occurrence in January). Additionally, I have no reason to believe, yet, that the instability is caused by some GHA-related infrastructure issue. So, if someone else has some capacity to help looking into it; that would be appreciated. I will continue my investigation tomorrow. Best, Matthias [1] https://issues.apache.org/jira/browse/FLINK-34227 [2] https://cwiki.apache.org/confluence/display/FLINK/1.19+Release#id-1.19Release-03/12/2024 On Tue, Mar 12, 2024 at 12:50 PM Benchao Li wrote: > +1 (non-binding) > > - checked signature and checksum: OK > - checkout copyright year in notice file: OK > - diffed source distribution with tag, make sure there is no > unexpected files: OK > - build from source : OK > - start a local cluster, played with jdbc connector: OK > > weijie guo 于2024年3月12日周二 16:55写道： > > > > +1 (non-binding) > > > > - Verified signature and checksum > > - Verified source distribution does not contains binaries > > - Build from source code and submit a word-count job successfully > > > > > > Best regards, > > > > Weijie > > > > > > Jane Chan 于2024年3月12日周二 16:38写道： > > > > > +1 (non-binding) > > > > > > - Verify that the source distributions do not contain any binaries; > > > - Build the source distribution to ensure all source files have Apache > > > headers; > > > - Verify checksum and GPG signatures; > > > > > > Best, > > > Jane > > > > > > On Tue, Mar 12, 2024 at 4:08 PM Xuannan Su > wrote: > > > > > > > +1 (non-binding) > > > > > > > > - Verified signature and checksum > > > > - Verified that source distribution does not contain binaries > > > > - Built from source code successfully > > > > - Reviewed the release announcement PR > > > > > > > > Best regards, > > > > Xuannan > > > > > > > > On Tue, Mar 12, 2024 at 2:18 PM Hang Ruan > > > wrote: > > > > > > > > > > +1 (non-binding) > > > > > > > > > > - Verified signatures and checksums > > > > > - Verified that source does not contain binaries > > > > > - Build source code successfully > > > > > - Reviewed the release note and left a comment > > > > > > > > > > Best, > > > > > Hang > > > > > > > > > > Feng Jin 于2024年3月12日周二 11:23写道： > > > > > > > > > > > +1 (non-binding) > > > > > > > > > > > > - Verified signatures and checksums > > > > > > - Verified that source does not contain binaries > > > > > > - Build source code successfully > > > > > > - Run a simple sql query successfully > > > > > > > > > > > > Best, > > > > > > Feng Jin > > > > > > > > > > > > > > > > > > On Tue, Mar 12, 2024 at 11:09 AM Ron liu > wrote: > > > > > > > > > > > > > +1 (non binding) > > > > > > > > > > > > > > quickly verified: > > > > > > > - verified that source distribution does not contain binaries > > > > > > > - verified checksums > > > > > > > - built source code successfully > > > > > > > > > > > > > > > > > > > > > Best, > > > > > > > Ron > > > > > > > > > > > > > > Jeyhun Karimov 于2024年3月12日周二 01:00写道： > > > > > > > > > > > > > > > +1 (non binding) > > > > > > > > > > > > > > > > - verified that source distribution does not contain binaries > > > > > > > > - verified signatures and checksums > > > > > > > > - built source code successfully > > > > > > > > > > > > > > > > Regards, > > > > > > > > Jeyhun > > > > > > > > > > > > > > > > > > > > > > > > On Mon, Mar 11, 2024 at 3:08 PM Samrat Deb < > > > decordea...@gmail.com> > > > > > > > wrote: > > > > > > > > > > > > > > > > > +1 (non binding) > > > > > > > > > > > > > > > > > > - verified signatures and checksums > > > > > > > > > - ASF headers are present in all expected file > > > > > > > > > - No unexpected binaries files found in the source > > > > > > > > > - Build successful locally > > > > > > > > > - tested basic word count example > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > Bests, > > > > > > > > > Samrat > > > > > > > > > > > > > > > > > > On Mon, 11 Mar 2024 at 7:33 PM, Ahmed Hamdy < > > > > hamdy10...@gmail.com> > > > > > > > > wrote: > > > > > > > > > > > > > > > > > > > Hi Lincoln > > > > > > > > > > +1 (non-binding) from me > > > > > > > > > > > > > > > > > > > > - Verified Checksums & Signatures > > > > > > > > > > - Verified Source dists don't contain binaries > > > > > > > > > > - Built source successfully > > > > > > > > > > - reviewed web PR > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > Best Regards > > > > > > > > > > Ahmed Hamdy > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > On Mon, 11 Mar 2024 at 15:18,
Re: [VOTE] Release 1.19.0, release candidate #2
+1 (non-binding) - checked signature and checksum: OK - checkout copyright year in notice file: OK - diffed source distribution with tag, make sure there is no unexpected files: OK - build from source : OK - start a local cluster, played with jdbc connector: OK weijie guo 于2024年3月12日周二 16:55写道： > > +1 (non-binding) > > - Verified signature and checksum > - Verified source distribution does not contains binaries > - Build from source code and submit a word-count job successfully > > > Best regards, > > Weijie > > > Jane Chan 于2024年3月12日周二 16:38写道： > > > +1 (non-binding) > > > > - Verify that the source distributions do not contain any binaries; > > - Build the source distribution to ensure all source files have Apache > > headers; > > - Verify checksum and GPG signatures; > > > > Best, > > Jane > > > > On Tue, Mar 12, 2024 at 4:08 PM Xuannan Su wrote: > > > > > +1 (non-binding) > > > > > > - Verified signature and checksum > > > - Verified that source distribution does not contain binaries > > > - Built from source code successfully > > > - Reviewed the release announcement PR > > > > > > Best regards, > > > Xuannan > > > > > > On Tue, Mar 12, 2024 at 2:18 PM Hang Ruan > > wrote: > > > > > > > > +1 (non-binding) > > > > > > > > - Verified signatures and checksums > > > > - Verified that source does not contain binaries > > > > - Build source code successfully > > > > - Reviewed the release note and left a comment > > > > > > > > Best, > > > > Hang > > > > > > > > Feng Jin 于2024年3月12日周二 11:23写道： > > > > > > > > > +1 (non-binding) > > > > > > > > > > - Verified signatures and checksums > > > > > - Verified that source does not contain binaries > > > > > - Build source code successfully > > > > > - Run a simple sql query successfully > > > > > > > > > > Best, > > > > > Feng Jin > > > > > > > > > > > > > > > On Tue, Mar 12, 2024 at 11:09 AM Ron liu wrote: > > > > > > > > > > > +1 (non binding) > > > > > > > > > > > > quickly verified: > > > > > > - verified that source distribution does not contain binaries > > > > > > - verified checksums > > > > > > - built source code successfully > > > > > > > > > > > > > > > > > > Best, > > > > > > Ron > > > > > > > > > > > > Jeyhun Karimov 于2024年3月12日周二 01:00写道： > > > > > > > > > > > > > +1 (non binding) > > > > > > > > > > > > > > - verified that source distribution does not contain binaries > > > > > > > - verified signatures and checksums > > > > > > > - built source code successfully > > > > > > > > > > > > > > Regards, > > > > > > > Jeyhun > > > > > > > > > > > > > > > > > > > > > On Mon, Mar 11, 2024 at 3:08 PM Samrat Deb < > > decordea...@gmail.com> > > > > > > wrote: > > > > > > > > > > > > > > > +1 (non binding) > > > > > > > > > > > > > > > > - verified signatures and checksums > > > > > > > > - ASF headers are present in all expected file > > > > > > > > - No unexpected binaries files found in the source > > > > > > > > - Build successful locally > > > > > > > > - tested basic word count example > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > Bests, > > > > > > > > Samrat > > > > > > > > > > > > > > > > On Mon, 11 Mar 2024 at 7:33 PM, Ahmed Hamdy < > > > hamdy10...@gmail.com> > > > > > > > wrote: > > > > > > > > > > > > > > > > > Hi Lincoln > > > > > > > > > +1 (non-binding) from me > > > > > > > > > > > > > > > > > > - Verified Checksums & Signatures > > > > > > > > > - Verified Source dists don't contain binaries > > > > > > > > > - Built source successfully > > > > > > > > > - reviewed web PR > > > > > > > > > > > > > > > > > > > > > > > > > > > Best Regards > > > > > > > > > Ahmed Hamdy > > > > > > > > > > > > > > > > > > > > > > > > > > > On Mon, 11 Mar 2024 at 15:18, Lincoln Lee < > > > lincoln.8...@gmail.com> > > > > > > > > wrote: > > > > > > > > > > > > > > > > > > > Hi Robin, > > > > > > > > > > > > > > > > > > > > Thanks for helping verifying the release note[1], > > FLINK-14879 > > > > > > should > > > > > > > > not > > > > > > > > > > have been included, after confirming this > > > > > > > > > > I moved all unresolved non-blocker issues left over from > > > 1.19.0 > > > > > to > > > > > > > > 1.20.0 > > > > > > > > > > and reconfigured the release note [1]. > > > > > > > > > > > > > > > > > > > > Best, > > > > > > > > > > Lincoln Lee > > > > > > > > > > > > > > > > > > > > [1] > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > https://issues.apache.org/jira/secure/ReleaseNote.jspa?projectId=12315522=12353282 > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > Robin Moffatt 于2024年3月11日周一 > > > > > 19:36写道： > > > > > > > > > > > > > > > > > > > > > Looking at the release notes [1] it lists `DESCRIBE > > > DATABASE` > > > > > > > > > > (FLINK-14879) > > > > > > > > > > > and `DESCRIBE CATALOG` (FLINK-14690). > > > > > > > > > > > When I try these in 1.19 RC2 the behaviour is as in > > 1.18.1, > > > > > i.e. > > > > > > it > > > > > >
Re: [VOTE] Release 1.19.0, release candidate #2
+1 (non-binding) - Verified signature and checksum - Verified source distribution does not contains binaries - Build from source code and submit a word-count job successfully Best regards, Weijie Jane Chan 于2024年3月12日周二 16:38写道： > +1 (non-binding) > > - Verify that the source distributions do not contain any binaries; > - Build the source distribution to ensure all source files have Apache > headers; > - Verify checksum and GPG signatures; > > Best, > Jane > > On Tue, Mar 12, 2024 at 4:08 PM Xuannan Su wrote: > > > +1 (non-binding) > > > > - Verified signature and checksum > > - Verified that source distribution does not contain binaries > > - Built from source code successfully > > - Reviewed the release announcement PR > > > > Best regards, > > Xuannan > > > > On Tue, Mar 12, 2024 at 2:18 PM Hang Ruan > wrote: > > > > > > +1 (non-binding) > > > > > > - Verified signatures and checksums > > > - Verified that source does not contain binaries > > > - Build source code successfully > > > - Reviewed the release note and left a comment > > > > > > Best, > > > Hang > > > > > > Feng Jin 于2024年3月12日周二 11:23写道： > > > > > > > +1 (non-binding) > > > > > > > > - Verified signatures and checksums > > > > - Verified that source does not contain binaries > > > > - Build source code successfully > > > > - Run a simple sql query successfully > > > > > > > > Best, > > > > Feng Jin > > > > > > > > > > > > On Tue, Mar 12, 2024 at 11:09 AM Ron liu wrote: > > > > > > > > > +1 (non binding) > > > > > > > > > > quickly verified: > > > > > - verified that source distribution does not contain binaries > > > > > - verified checksums > > > > > - built source code successfully > > > > > > > > > > > > > > > Best, > > > > > Ron > > > > > > > > > > Jeyhun Karimov 于2024年3月12日周二 01:00写道： > > > > > > > > > > > +1 (non binding) > > > > > > > > > > > > - verified that source distribution does not contain binaries > > > > > > - verified signatures and checksums > > > > > > - built source code successfully > > > > > > > > > > > > Regards, > > > > > > Jeyhun > > > > > > > > > > > > > > > > > > On Mon, Mar 11, 2024 at 3:08 PM Samrat Deb < > decordea...@gmail.com> > > > > > wrote: > > > > > > > > > > > > > +1 (non binding) > > > > > > > > > > > > > > - verified signatures and checksums > > > > > > > - ASF headers are present in all expected file > > > > > > > - No unexpected binaries files found in the source > > > > > > > - Build successful locally > > > > > > > - tested basic word count example > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > Bests, > > > > > > > Samrat > > > > > > > > > > > > > > On Mon, 11 Mar 2024 at 7:33 PM, Ahmed Hamdy < > > hamdy10...@gmail.com> > > > > > > wrote: > > > > > > > > > > > > > > > Hi Lincoln > > > > > > > > +1 (non-binding) from me > > > > > > > > > > > > > > > > - Verified Checksums & Signatures > > > > > > > > - Verified Source dists don't contain binaries > > > > > > > > - Built source successfully > > > > > > > > - reviewed web PR > > > > > > > > > > > > > > > > > > > > > > > > Best Regards > > > > > > > > Ahmed Hamdy > > > > > > > > > > > > > > > > > > > > > > > > On Mon, 11 Mar 2024 at 15:18, Lincoln Lee < > > lincoln.8...@gmail.com> > > > > > > > wrote: > > > > > > > > > > > > > > > > > Hi Robin, > > > > > > > > > > > > > > > > > > Thanks for helping verifying the release note[1], > FLINK-14879 > > > > > should > > > > > > > not > > > > > > > > > have been included, after confirming this > > > > > > > > > I moved all unresolved non-blocker issues left over from > > 1.19.0 > > > > to > > > > > > > 1.20.0 > > > > > > > > > and reconfigured the release note [1]. > > > > > > > > > > > > > > > > > > Best, > > > > > > > > > Lincoln Lee > > > > > > > > > > > > > > > > > > [1] > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > https://issues.apache.org/jira/secure/ReleaseNote.jspa?projectId=12315522=12353282 > > > > > > > > > > > > > > > > > > > > > > > > > > > Robin Moffatt 于2024年3月11日周一 > > > > 19:36写道： > > > > > > > > > > > > > > > > > > > Looking at the release notes [1] it lists `DESCRIBE > > DATABASE` > > > > > > > > > (FLINK-14879) > > > > > > > > > > and `DESCRIBE CATALOG` (FLINK-14690). > > > > > > > > > > When I try these in 1.19 RC2 the behaviour is as in > 1.18.1, > > > > i.e. > > > > > it > > > > > > > is > > > > > > > > > not > > > > > > > > > > supported: > > > > > > > > > > > > > > > > > > > > ``` > > > > > > > > > > [INFO] Execute statement succeed. > > > > > > > > > > > > > > > > > > > > Flink SQL> show catalogs; > > > > > > > > > > +-+ > > > > > > > > > > |catalog name | > > > > > > > > > > +-+ > > > > > > > > > > | c_new | > > > > > > > > > > | default_catalog | > > > > > > > > > > +-+ > > > > > > > > > > 2 rows in set > > > > > > > > > > > > > > > > > > > > Flink SQL> DESCRIBE CATALOG c_new; > > > > > > > > > > [ERROR] Could not execute SQL
Re: [VOTE] Release 1.19.0, release candidate #2
+1 (non-binding) - Verified signature - Verified checksum - Built source code successfully - Reviewed the release PR and some comments are updated Best, Rui On Tue, Mar 12, 2024 at 4:08 PM Xuannan Su wrote: > +1 (non-binding) > > - Verified signature and checksum > - Verified that source distribution does not contain binaries > - Built from source code successfully > - Reviewed the release announcement PR > > Best regards, > Xuannan > > On Tue, Mar 12, 2024 at 2:18 PM Hang Ruan wrote: > > > > +1 (non-binding) > > > > - Verified signatures and checksums > > - Verified that source does not contain binaries > > - Build source code successfully > > - Reviewed the release note and left a comment > > > > Best, > > Hang > > > > Feng Jin 于2024年3月12日周二 11:23写道： > > > > > +1 (non-binding) > > > > > > - Verified signatures and checksums > > > - Verified that source does not contain binaries > > > - Build source code successfully > > > - Run a simple sql query successfully > > > > > > Best, > > > Feng Jin > > > > > > > > > On Tue, Mar 12, 2024 at 11:09 AM Ron liu wrote: > > > > > > > +1 (non binding) > > > > > > > > quickly verified: > > > > - verified that source distribution does not contain binaries > > > > - verified checksums > > > > - built source code successfully > > > > > > > > > > > > Best, > > > > Ron > > > > > > > > Jeyhun Karimov 于2024年3月12日周二 01:00写道： > > > > > > > > > +1 (non binding) > > > > > > > > > > - verified that source distribution does not contain binaries > > > > > - verified signatures and checksums > > > > > - built source code successfully > > > > > > > > > > Regards, > > > > > Jeyhun > > > > > > > > > > > > > > > On Mon, Mar 11, 2024 at 3:08 PM Samrat Deb > > > > wrote: > > > > > > > > > > > +1 (non binding) > > > > > > > > > > > > - verified signatures and checksums > > > > > > - ASF headers are present in all expected file > > > > > > - No unexpected binaries files found in the source > > > > > > - Build successful locally > > > > > > - tested basic word count example > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > Bests, > > > > > > Samrat > > > > > > > > > > > > On Mon, 11 Mar 2024 at 7:33 PM, Ahmed Hamdy < > hamdy10...@gmail.com> > > > > > wrote: > > > > > > > > > > > > > Hi Lincoln > > > > > > > +1 (non-binding) from me > > > > > > > > > > > > > > - Verified Checksums & Signatures > > > > > > > - Verified Source dists don't contain binaries > > > > > > > - Built source successfully > > > > > > > - reviewed web PR > > > > > > > > > > > > > > > > > > > > > Best Regards > > > > > > > Ahmed Hamdy > > > > > > > > > > > > > > > > > > > > > On Mon, 11 Mar 2024 at 15:18, Lincoln Lee < > lincoln.8...@gmail.com> > > > > > > wrote: > > > > > > > > > > > > > > > Hi Robin, > > > > > > > > > > > > > > > > Thanks for helping verifying the release note[1], FLINK-14879 > > > > should > > > > > > not > > > > > > > > have been included, after confirming this > > > > > > > > I moved all unresolved non-blocker issues left over from > 1.19.0 > > > to > > > > > > 1.20.0 > > > > > > > > and reconfigured the release note [1]. > > > > > > > > > > > > > > > > Best, > > > > > > > > Lincoln Lee > > > > > > > > > > > > > > > > [1] > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > https://issues.apache.org/jira/secure/ReleaseNote.jspa?projectId=12315522=12353282 > > > > > > > > > > > > > > > > > > > > > > > > Robin Moffatt 于2024年3月11日周一 > > > 19:36写道： > > > > > > > > > > > > > > > > > Looking at the release notes [1] it lists `DESCRIBE > DATABASE` > > > > > > > > (FLINK-14879) > > > > > > > > > and `DESCRIBE CATALOG` (FLINK-14690). > > > > > > > > > When I try these in 1.19 RC2 the behaviour is as in 1.18.1, > > > i.e. > > > > it > > > > > > is > > > > > > > > not > > > > > > > > > supported: > > > > > > > > > > > > > > > > > > ``` > > > > > > > > > [INFO] Execute statement succeed. > > > > > > > > > > > > > > > > > > Flink SQL> show catalogs; > > > > > > > > > +-+ > > > > > > > > > |catalog name | > > > > > > > > > +-+ > > > > > > > > > | c_new | > > > > > > > > > | default_catalog | > > > > > > > > > +-+ > > > > > > > > > 2 rows in set > > > > > > > > > > > > > > > > > > Flink SQL> DESCRIBE CATALOG c_new; > > > > > > > > > [ERROR] Could not execute SQL statement. Reason: > > > > > > > > > org.apache.calcite.sql.validate.SqlValidatorException: > Column > > > > > 'c_new' > > > > > > > not > > > > > > > > > found in any table > > > > > > > > > > > > > > > > > > Flink SQL> show databases; > > > > > > > > > +--+ > > > > > > > > > |database name | > > > > > > > > > +--+ > > > > > > > > > | default_database | > > > > > > > > > +--+ > > > > > > > > > 1 row in set > > > > > > > > > > > > > > > > > > Flink SQL> DESCRIBE DATABASE default_database; > > > > > > > > > [ERROR] Could not execute SQL statement. Reason: > > > > > > > > >
Re: [VOTE] Release 1.19.0, release candidate #2
+1 (non-binding) - Verify that the source distributions do not contain any binaries; - Build the source distribution to ensure all source files have Apache headers; - Verify checksum and GPG signatures; Best, Jane On Tue, Mar 12, 2024 at 4:08 PM Xuannan Su wrote: > +1 (non-binding) > > - Verified signature and checksum > - Verified that source distribution does not contain binaries > - Built from source code successfully > - Reviewed the release announcement PR > > Best regards, > Xuannan > > On Tue, Mar 12, 2024 at 2:18 PM Hang Ruan wrote: > > > > +1 (non-binding) > > > > - Verified signatures and checksums > > - Verified that source does not contain binaries > > - Build source code successfully > > - Reviewed the release note and left a comment > > > > Best, > > Hang > > > > Feng Jin 于2024年3月12日周二 11:23写道： > > > > > +1 (non-binding) > > > > > > - Verified signatures and checksums > > > - Verified that source does not contain binaries > > > - Build source code successfully > > > - Run a simple sql query successfully > > > > > > Best, > > > Feng Jin > > > > > > > > > On Tue, Mar 12, 2024 at 11:09 AM Ron liu wrote: > > > > > > > +1 (non binding) > > > > > > > > quickly verified: > > > > - verified that source distribution does not contain binaries > > > > - verified checksums > > > > - built source code successfully > > > > > > > > > > > > Best, > > > > Ron > > > > > > > > Jeyhun Karimov 于2024年3月12日周二 01:00写道： > > > > > > > > > +1 (non binding) > > > > > > > > > > - verified that source distribution does not contain binaries > > > > > - verified signatures and checksums > > > > > - built source code successfully > > > > > > > > > > Regards, > > > > > Jeyhun > > > > > > > > > > > > > > > On Mon, Mar 11, 2024 at 3:08 PM Samrat Deb > > > > wrote: > > > > > > > > > > > +1 (non binding) > > > > > > > > > > > > - verified signatures and checksums > > > > > > - ASF headers are present in all expected file > > > > > > - No unexpected binaries files found in the source > > > > > > - Build successful locally > > > > > > - tested basic word count example > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > Bests, > > > > > > Samrat > > > > > > > > > > > > On Mon, 11 Mar 2024 at 7:33 PM, Ahmed Hamdy < > hamdy10...@gmail.com> > > > > > wrote: > > > > > > > > > > > > > Hi Lincoln > > > > > > > +1 (non-binding) from me > > > > > > > > > > > > > > - Verified Checksums & Signatures > > > > > > > - Verified Source dists don't contain binaries > > > > > > > - Built source successfully > > > > > > > - reviewed web PR > > > > > > > > > > > > > > > > > > > > > Best Regards > > > > > > > Ahmed Hamdy > > > > > > > > > > > > > > > > > > > > > On Mon, 11 Mar 2024 at 15:18, Lincoln Lee < > lincoln.8...@gmail.com> > > > > > > wrote: > > > > > > > > > > > > > > > Hi Robin, > > > > > > > > > > > > > > > > Thanks for helping verifying the release note[1], FLINK-14879 > > > > should > > > > > > not > > > > > > > > have been included, after confirming this > > > > > > > > I moved all unresolved non-blocker issues left over from > 1.19.0 > > > to > > > > > > 1.20.0 > > > > > > > > and reconfigured the release note [1]. > > > > > > > > > > > > > > > > Best, > > > > > > > > Lincoln Lee > > > > > > > > > > > > > > > > [1] > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > https://issues.apache.org/jira/secure/ReleaseNote.jspa?projectId=12315522=12353282 > > > > > > > > > > > > > > > > > > > > > > > > Robin Moffatt 于2024年3月11日周一 > > > 19:36写道： > > > > > > > > > > > > > > > > > Looking at the release notes [1] it lists `DESCRIBE > DATABASE` > > > > > > > > (FLINK-14879) > > > > > > > > > and `DESCRIBE CATALOG` (FLINK-14690). > > > > > > > > > When I try these in 1.19 RC2 the behaviour is as in 1.18.1, > > > i.e. > > > > it > > > > > > is > > > > > > > > not > > > > > > > > > supported: > > > > > > > > > > > > > > > > > > ``` > > > > > > > > > [INFO] Execute statement succeed. > > > > > > > > > > > > > > > > > > Flink SQL> show catalogs; > > > > > > > > > +-+ > > > > > > > > > |catalog name | > > > > > > > > > +-+ > > > > > > > > > | c_new | > > > > > > > > > | default_catalog | > > > > > > > > > +-+ > > > > > > > > > 2 rows in set > > > > > > > > > > > > > > > > > > Flink SQL> DESCRIBE CATALOG c_new; > > > > > > > > > [ERROR] Could not execute SQL statement. Reason: > > > > > > > > > org.apache.calcite.sql.validate.SqlValidatorException: > Column > > > > > 'c_new' > > > > > > > not > > > > > > > > > found in any table > > > > > > > > > > > > > > > > > > Flink SQL> show databases; > > > > > > > > > +--+ > > > > > > > > > |database name | > > > > > > > > > +--+ > > > > > > > > > | default_database | > > > > > > > > > +--+ > > > > > > > > > 1 row in set > > > > > > > > > > > > > > > > > > Flink SQL> DESCRIBE DATABASE default_database; > > > > > > > > > [ERROR] Could not execute SQL
Re: [VOTE] Release 1.19.0, release candidate #2
+1 (non-binding) - Verified signature and checksum - Verified that source distribution does not contain binaries - Built from source code successfully - Reviewed the release announcement PR Best regards, Xuannan On Tue, Mar 12, 2024 at 2:18 PM Hang Ruan wrote: > > +1 (non-binding) > > - Verified signatures and checksums > - Verified that source does not contain binaries > - Build source code successfully > - Reviewed the release note and left a comment > > Best, > Hang > > Feng Jin 于2024年3月12日周二 11:23写道： > > > +1 (non-binding) > > > > - Verified signatures and checksums > > - Verified that source does not contain binaries > > - Build source code successfully > > - Run a simple sql query successfully > > > > Best, > > Feng Jin > > > > > > On Tue, Mar 12, 2024 at 11:09 AM Ron liu wrote: > > > > > +1 (non binding) > > > > > > quickly verified: > > > - verified that source distribution does not contain binaries > > > - verified checksums > > > - built source code successfully > > > > > > > > > Best, > > > Ron > > > > > > Jeyhun Karimov 于2024年3月12日周二 01:00写道： > > > > > > > +1 (non binding) > > > > > > > > - verified that source distribution does not contain binaries > > > > - verified signatures and checksums > > > > - built source code successfully > > > > > > > > Regards, > > > > Jeyhun > > > > > > > > > > > > On Mon, Mar 11, 2024 at 3:08 PM Samrat Deb > > > wrote: > > > > > > > > > +1 (non binding) > > > > > > > > > > - verified signatures and checksums > > > > > - ASF headers are present in all expected file > > > > > - No unexpected binaries files found in the source > > > > > - Build successful locally > > > > > - tested basic word count example > > > > > > > > > > > > > > > > > > > > > > > > > Bests, > > > > > Samrat > > > > > > > > > > On Mon, 11 Mar 2024 at 7:33 PM, Ahmed Hamdy > > > > wrote: > > > > > > > > > > > Hi Lincoln > > > > > > +1 (non-binding) from me > > > > > > > > > > > > - Verified Checksums & Signatures > > > > > > - Verified Source dists don't contain binaries > > > > > > - Built source successfully > > > > > > - reviewed web PR > > > > > > > > > > > > > > > > > > Best Regards > > > > > > Ahmed Hamdy > > > > > > > > > > > > > > > > > > On Mon, 11 Mar 2024 at 15:18, Lincoln Lee > > > > > wrote: > > > > > > > > > > > > > Hi Robin, > > > > > > > > > > > > > > Thanks for helping verifying the release note[1], FLINK-14879 > > > should > > > > > not > > > > > > > have been included, after confirming this > > > > > > > I moved all unresolved non-blocker issues left over from 1.19.0 > > to > > > > > 1.20.0 > > > > > > > and reconfigured the release note [1]. > > > > > > > > > > > > > > Best, > > > > > > > Lincoln Lee > > > > > > > > > > > > > > [1] > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > https://issues.apache.org/jira/secure/ReleaseNote.jspa?projectId=12315522=12353282 > > > > > > > > > > > > > > > > > > > > > Robin Moffatt 于2024年3月11日周一 > > 19:36写道： > > > > > > > > > > > > > > > Looking at the release notes [1] it lists `DESCRIBE DATABASE` > > > > > > > (FLINK-14879) > > > > > > > > and `DESCRIBE CATALOG` (FLINK-14690). > > > > > > > > When I try these in 1.19 RC2 the behaviour is as in 1.18.1, > > i.e. > > > it > > > > > is > > > > > > > not > > > > > > > > supported: > > > > > > > > > > > > > > > > ``` > > > > > > > > [INFO] Execute statement succeed. > > > > > > > > > > > > > > > > Flink SQL> show catalogs; > > > > > > > > +-+ > > > > > > > > |catalog name | > > > > > > > > +-+ > > > > > > > > | c_new | > > > > > > > > | default_catalog | > > > > > > > > +-+ > > > > > > > > 2 rows in set > > > > > > > > > > > > > > > > Flink SQL> DESCRIBE CATALOG c_new; > > > > > > > > [ERROR] Could not execute SQL statement. Reason: > > > > > > > > org.apache.calcite.sql.validate.SqlValidatorException: Column > > > > 'c_new' > > > > > > not > > > > > > > > found in any table > > > > > > > > > > > > > > > > Flink SQL> show databases; > > > > > > > > +--+ > > > > > > > > |database name | > > > > > > > > +--+ > > > > > > > > | default_database | > > > > > > > > +--+ > > > > > > > > 1 row in set > > > > > > > > > > > > > > > > Flink SQL> DESCRIBE DATABASE default_database; > > > > > > > > [ERROR] Could not execute SQL statement. Reason: > > > > > > > > org.apache.calcite.sql.validate.SqlValidatorException: Column > > > > > > > > 'default_database' not found in > > > > > > > > any table > > > > > > > > ``` > > > > > > > > > > > > > > > > Is this an error in the release notes, or my mistake in > > > > interpreting > > > > > > > them? > > > > > > > > > > > > > > > > thanks, Robin. > > > > > > > > > > > > > > > > > > > > > > > > [1] > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > https://issues.apache.org/jira/secure/ReleaseNote.jspa?projectId=12315522=12353282 > > > > > > > > > > > > > > > > On Thu, 7 Mar 2024 at 10:01,
Re: [VOTE] Release 1.19.0, release candidate #2
+1 (non-binding) - Verified signatures and checksums - Verified that source does not contain binaries - Build source code successfully - Reviewed the release note and left a comment Best, Hang Feng Jin 于2024年3月12日周二 11:23写道： > +1 (non-binding) > > - Verified signatures and checksums > - Verified that source does not contain binaries > - Build source code successfully > - Run a simple sql query successfully > > Best, > Feng Jin > > > On Tue, Mar 12, 2024 at 11:09 AM Ron liu wrote: > > > +1 (non binding) > > > > quickly verified: > > - verified that source distribution does not contain binaries > > - verified checksums > > - built source code successfully > > > > > > Best, > > Ron > > > > Jeyhun Karimov 于2024年3月12日周二 01:00写道： > > > > > +1 (non binding) > > > > > > - verified that source distribution does not contain binaries > > > - verified signatures and checksums > > > - built source code successfully > > > > > > Regards, > > > Jeyhun > > > > > > > > > On Mon, Mar 11, 2024 at 3:08 PM Samrat Deb > > wrote: > > > > > > > +1 (non binding) > > > > > > > > - verified signatures and checksums > > > > - ASF headers are present in all expected file > > > > - No unexpected binaries files found in the source > > > > - Build successful locally > > > > - tested basic word count example > > > > > > > > > > > > > > > > > > > > Bests, > > > > Samrat > > > > > > > > On Mon, 11 Mar 2024 at 7:33 PM, Ahmed Hamdy > > > wrote: > > > > > > > > > Hi Lincoln > > > > > +1 (non-binding) from me > > > > > > > > > > - Verified Checksums & Signatures > > > > > - Verified Source dists don't contain binaries > > > > > - Built source successfully > > > > > - reviewed web PR > > > > > > > > > > > > > > > Best Regards > > > > > Ahmed Hamdy > > > > > > > > > > > > > > > On Mon, 11 Mar 2024 at 15:18, Lincoln Lee > > > > wrote: > > > > > > > > > > > Hi Robin, > > > > > > > > > > > > Thanks for helping verifying the release note[1], FLINK-14879 > > should > > > > not > > > > > > have been included, after confirming this > > > > > > I moved all unresolved non-blocker issues left over from 1.19.0 > to > > > > 1.20.0 > > > > > > and reconfigured the release note [1]. > > > > > > > > > > > > Best, > > > > > > Lincoln Lee > > > > > > > > > > > > [1] > > > > > > > > > > > > > > > > > > > > > > > > > > > https://issues.apache.org/jira/secure/ReleaseNote.jspa?projectId=12315522=12353282 > > > > > > > > > > > > > > > > > > Robin Moffatt 于2024年3月11日周一 > 19:36写道： > > > > > > > > > > > > > Looking at the release notes [1] it lists `DESCRIBE DATABASE` > > > > > > (FLINK-14879) > > > > > > > and `DESCRIBE CATALOG` (FLINK-14690). > > > > > > > When I try these in 1.19 RC2 the behaviour is as in 1.18.1, > i.e. > > it > > > > is > > > > > > not > > > > > > > supported: > > > > > > > > > > > > > > ``` > > > > > > > [INFO] Execute statement succeed. > > > > > > > > > > > > > > Flink SQL> show catalogs; > > > > > > > +-+ > > > > > > > |catalog name | > > > > > > > +-+ > > > > > > > | c_new | > > > > > > > | default_catalog | > > > > > > > +-+ > > > > > > > 2 rows in set > > > > > > > > > > > > > > Flink SQL> DESCRIBE CATALOG c_new; > > > > > > > [ERROR] Could not execute SQL statement. Reason: > > > > > > > org.apache.calcite.sql.validate.SqlValidatorException: Column > > > 'c_new' > > > > > not > > > > > > > found in any table > > > > > > > > > > > > > > Flink SQL> show databases; > > > > > > > +--+ > > > > > > > |database name | > > > > > > > +--+ > > > > > > > | default_database | > > > > > > > +--+ > > > > > > > 1 row in set > > > > > > > > > > > > > > Flink SQL> DESCRIBE DATABASE default_database; > > > > > > > [ERROR] Could not execute SQL statement. Reason: > > > > > > > org.apache.calcite.sql.validate.SqlValidatorException: Column > > > > > > > 'default_database' not found in > > > > > > > any table > > > > > > > ``` > > > > > > > > > > > > > > Is this an error in the release notes, or my mistake in > > > interpreting > > > > > > them? > > > > > > > > > > > > > > thanks, Robin. > > > > > > > > > > > > > > > > > > > > > [1] > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > https://issues.apache.org/jira/secure/ReleaseNote.jspa?projectId=12315522=12353282 > > > > > > > > > > > > > > On Thu, 7 Mar 2024 at 10:01, Lincoln Lee < > lincoln.8...@gmail.com > > > > > > > > wrote: > > > > > > > > > > > > > > > Hi everyone, > > > > > > > > > > > > > > > > Please review and vote on the release candidate #2 for the > > > version > > > > > > > 1.19.0, > > > > > > > > as follows: > > > > > > > > [ ] +1, Approve the release > > > > > > > > [ ] -1, Do not approve the release (please provide specific > > > > comments) > > > > > > > > > > > > > > > > The complete staging area is available for your review, which > > > > > includes: > > > > > > > > > > > > > > > > * JIRA release notes [1], and the pull request adding release > > >
Re: [VOTE] Release 1.19.0, release candidate #2
+1 (non-binding) - Verified signatures and checksums - Verified that source does not contain binaries - Build source code successfully - Run a simple sql query successfully Best, Feng Jin On Tue, Mar 12, 2024 at 11:09 AM Ron liu wrote: > +1 (non binding) > > quickly verified: > - verified that source distribution does not contain binaries > - verified checksums > - built source code successfully > > > Best, > Ron > > Jeyhun Karimov 于2024年3月12日周二 01:00写道： > > > +1 (non binding) > > > > - verified that source distribution does not contain binaries > > - verified signatures and checksums > > - built source code successfully > > > > Regards, > > Jeyhun > > > > > > On Mon, Mar 11, 2024 at 3:08 PM Samrat Deb > wrote: > > > > > +1 (non binding) > > > > > > - verified signatures and checksums > > > - ASF headers are present in all expected file > > > - No unexpected binaries files found in the source > > > - Build successful locally > > > - tested basic word count example > > > > > > > > > > > > > > > Bests, > > > Samrat > > > > > > On Mon, 11 Mar 2024 at 7:33 PM, Ahmed Hamdy > > wrote: > > > > > > > Hi Lincoln > > > > +1 (non-binding) from me > > > > > > > > - Verified Checksums & Signatures > > > > - Verified Source dists don't contain binaries > > > > - Built source successfully > > > > - reviewed web PR > > > > > > > > > > > > Best Regards > > > > Ahmed Hamdy > > > > > > > > > > > > On Mon, 11 Mar 2024 at 15:18, Lincoln Lee > > > wrote: > > > > > > > > > Hi Robin, > > > > > > > > > > Thanks for helping verifying the release note[1], FLINK-14879 > should > > > not > > > > > have been included, after confirming this > > > > > I moved all unresolved non-blocker issues left over from 1.19.0 to > > > 1.20.0 > > > > > and reconfigured the release note [1]. > > > > > > > > > > Best, > > > > > Lincoln Lee > > > > > > > > > > [1] > > > > > > > > > > > > > > > > > > > > https://issues.apache.org/jira/secure/ReleaseNote.jspa?projectId=12315522=12353282 > > > > > > > > > > > > > > > Robin Moffatt 于2024年3月11日周一 19:36写道： > > > > > > > > > > > Looking at the release notes [1] it lists `DESCRIBE DATABASE` > > > > > (FLINK-14879) > > > > > > and `DESCRIBE CATALOG` (FLINK-14690). > > > > > > When I try these in 1.19 RC2 the behaviour is as in 1.18.1, i.e. > it > > > is > > > > > not > > > > > > supported: > > > > > > > > > > > > ``` > > > > > > [INFO] Execute statement succeed. > > > > > > > > > > > > Flink SQL> show catalogs; > > > > > > +-+ > > > > > > |catalog name | > > > > > > +-+ > > > > > > | c_new | > > > > > > | default_catalog | > > > > > > +-+ > > > > > > 2 rows in set > > > > > > > > > > > > Flink SQL> DESCRIBE CATALOG c_new; > > > > > > [ERROR] Could not execute SQL statement. Reason: > > > > > > org.apache.calcite.sql.validate.SqlValidatorException: Column > > 'c_new' > > > > not > > > > > > found in any table > > > > > > > > > > > > Flink SQL> show databases; > > > > > > +--+ > > > > > > |database name | > > > > > > +--+ > > > > > > | default_database | > > > > > > +--+ > > > > > > 1 row in set > > > > > > > > > > > > Flink SQL> DESCRIBE DATABASE default_database; > > > > > > [ERROR] Could not execute SQL statement. Reason: > > > > > > org.apache.calcite.sql.validate.SqlValidatorException: Column > > > > > > 'default_database' not found in > > > > > > any table > > > > > > ``` > > > > > > > > > > > > Is this an error in the release notes, or my mistake in > > interpreting > > > > > them? > > > > > > > > > > > > thanks, Robin. > > > > > > > > > > > > > > > > > > [1] > > > > > > > > > > > > > > > > > > > > > > > > > > > https://issues.apache.org/jira/secure/ReleaseNote.jspa?projectId=12315522=12353282 > > > > > > > > > > > > On Thu, 7 Mar 2024 at 10:01, Lincoln Lee > > > > > wrote: > > > > > > > > > > > > > Hi everyone, > > > > > > > > > > > > > > Please review and vote on the release candidate #2 for the > > version > > > > > > 1.19.0, > > > > > > > as follows: > > > > > > > [ ] +1, Approve the release > > > > > > > [ ] -1, Do not approve the release (please provide specific > > > comments) > > > > > > > > > > > > > > The complete staging area is available for your review, which > > > > includes: > > > > > > > > > > > > > > * JIRA release notes [1], and the pull request adding release > > note > > > > for > > > > > > > users [2] > > > > > > > * the official Apache source release and binary convenience > > > releases > > > > to > > > > > > be > > > > > > > deployed to dist.apache.org [3], which are signed with the key > > > with > > > > > > > fingerprint E57D30ABEE75CA06 [4], > > > > > > > * all artifacts to be deployed to the Maven Central Repository > > [5], > > > > > > > * source code tag "release-1.19.0-rc2" [6], > > > > > > > * website pull request listing the new release and adding > > > > announcement > > > > > > blog > > > > > > > post [7]. > > > > > > > > > > > > > > The vote will
Re: [VOTE] Release 1.19.0, release candidate #2
+1 (non binding) quickly verified: - verified that source distribution does not contain binaries - verified checksums - built source code successfully Best, Ron Jeyhun Karimov 于2024年3月12日周二 01:00写道： > +1 (non binding) > > - verified that source distribution does not contain binaries > - verified signatures and checksums > - built source code successfully > > Regards, > Jeyhun > > > On Mon, Mar 11, 2024 at 3:08 PM Samrat Deb wrote: > > > +1 (non binding) > > > > - verified signatures and checksums > > - ASF headers are present in all expected file > > - No unexpected binaries files found in the source > > - Build successful locally > > - tested basic word count example > > > > > > > > > > Bests, > > Samrat > > > > On Mon, 11 Mar 2024 at 7:33 PM, Ahmed Hamdy > wrote: > > > > > Hi Lincoln > > > +1 (non-binding) from me > > > > > > - Verified Checksums & Signatures > > > - Verified Source dists don't contain binaries > > > - Built source successfully > > > - reviewed web PR > > > > > > > > > Best Regards > > > Ahmed Hamdy > > > > > > > > > On Mon, 11 Mar 2024 at 15:18, Lincoln Lee > > wrote: > > > > > > > Hi Robin, > > > > > > > > Thanks for helping verifying the release note[1], FLINK-14879 should > > not > > > > have been included, after confirming this > > > > I moved all unresolved non-blocker issues left over from 1.19.0 to > > 1.20.0 > > > > and reconfigured the release note [1]. > > > > > > > > Best, > > > > Lincoln Lee > > > > > > > > [1] > > > > > > > > > > > > > > https://issues.apache.org/jira/secure/ReleaseNote.jspa?projectId=12315522=12353282 > > > > > > > > > > > > Robin Moffatt 于2024年3月11日周一 19:36写道： > > > > > > > > > Looking at the release notes [1] it lists `DESCRIBE DATABASE` > > > > (FLINK-14879) > > > > > and `DESCRIBE CATALOG` (FLINK-14690). > > > > > When I try these in 1.19 RC2 the behaviour is as in 1.18.1, i.e. it > > is > > > > not > > > > > supported: > > > > > > > > > > ``` > > > > > [INFO] Execute statement succeed. > > > > > > > > > > Flink SQL> show catalogs; > > > > > +-+ > > > > > |catalog name | > > > > > +-+ > > > > > | c_new | > > > > > | default_catalog | > > > > > +-+ > > > > > 2 rows in set > > > > > > > > > > Flink SQL> DESCRIBE CATALOG c_new; > > > > > [ERROR] Could not execute SQL statement. Reason: > > > > > org.apache.calcite.sql.validate.SqlValidatorException: Column > 'c_new' > > > not > > > > > found in any table > > > > > > > > > > Flink SQL> show databases; > > > > > +--+ > > > > > |database name | > > > > > +--+ > > > > > | default_database | > > > > > +--+ > > > > > 1 row in set > > > > > > > > > > Flink SQL> DESCRIBE DATABASE default_database; > > > > > [ERROR] Could not execute SQL statement. Reason: > > > > > org.apache.calcite.sql.validate.SqlValidatorException: Column > > > > > 'default_database' not found in > > > > > any table > > > > > ``` > > > > > > > > > > Is this an error in the release notes, or my mistake in > interpreting > > > > them? > > > > > > > > > > thanks, Robin. > > > > > > > > > > > > > > > [1] > > > > > > > > > > > > > > > > > > > > https://issues.apache.org/jira/secure/ReleaseNote.jspa?projectId=12315522=12353282 > > > > > > > > > > On Thu, 7 Mar 2024 at 10:01, Lincoln Lee > > > wrote: > > > > > > > > > > > Hi everyone, > > > > > > > > > > > > Please review and vote on the release candidate #2 for the > version > > > > > 1.19.0, > > > > > > as follows: > > > > > > [ ] +1, Approve the release > > > > > > [ ] -1, Do not approve the release (please provide specific > > comments) > > > > > > > > > > > > The complete staging area is available for your review, which > > > includes: > > > > > > > > > > > > * JIRA release notes [1], and the pull request adding release > note > > > for > > > > > > users [2] > > > > > > * the official Apache source release and binary convenience > > releases > > > to > > > > > be > > > > > > deployed to dist.apache.org [3], which are signed with the key > > with > > > > > > fingerprint E57D30ABEE75CA06 [4], > > > > > > * all artifacts to be deployed to the Maven Central Repository > [5], > > > > > > * source code tag "release-1.19.0-rc2" [6], > > > > > > * website pull request listing the new release and adding > > > announcement > > > > > blog > > > > > > post [7]. > > > > > > > > > > > > The vote will be open for at least 72 hours. It is adopted by > > > majority > > > > > > approval, with at least 3 PMC affirmative votes. > > > > > > > > > > > > [1] > > > > > > > > > > > > > > > > > > > > > > > > > > > https://issues.apache.org/jira/secure/ReleaseNote.jspa?projectId=12315522=12353282 > > > > > > [2] https://github.com/apache/flink/pull/24394 > > > > > > [3] > https://dist.apache.org/repos/dist/dev/flink/flink-1.19.0-rc2/ > > > > > > [4] https://dist.apache.org/repos/dist/release/flink/KEYS > > > > > > [5] > > > > > > >
Re: [VOTE] Release 1.19.0, release candidate #2
+1 (non-binding) - Signature and checksum are OK - Source dist doesn't contain unexpected binaries - Build from source successfully, `SocketWindowWordCount` worked well Hangxiang Yu 于2024年3月12日周二 09:59写道： > > +1 (non-binding) > > - Verified signatures and checksums > - Reviewed Web PR > - Built from source successfully > - Ran a wordcount job which worked well > > > > On Tue, Mar 12, 2024 at 1:00 AM Jeyhun Karimov wrote: > > > +1 (non binding) > > > > - verified that source distribution does not contain binaries > > - verified signatures and checksums > > - built source code successfully > > > > Regards, > > Jeyhun > > > > > > On Mon, Mar 11, 2024 at 3:08 PM Samrat Deb wrote: > > > > > +1 (non binding) > > > > > > - verified signatures and checksums > > > - ASF headers are present in all expected file > > > - No unexpected binaries files found in the source > > > - Build successful locally > > > - tested basic word count example > > > > > > > > > > > > > > > Bests, > > > Samrat > > > > > > On Mon, 11 Mar 2024 at 7:33 PM, Ahmed Hamdy > > wrote: > > > > > > > Hi Lincoln > > > > +1 (non-binding) from me > > > > > > > > - Verified Checksums & Signatures > > > > - Verified Source dists don't contain binaries > > > > - Built source successfully > > > > - reviewed web PR > > > > > > > > > > > > Best Regards > > > > Ahmed Hamdy > > > > > > > > > > > > On Mon, 11 Mar 2024 at 15:18, Lincoln Lee > > > wrote: > > > > > > > > > Hi Robin, > > > > > > > > > > Thanks for helping verifying the release note[1], FLINK-14879 should > > > not > > > > > have been included, after confirming this > > > > > I moved all unresolved non-blocker issues left over from 1.19.0 to > > > 1.20.0 > > > > > and reconfigured the release note [1]. > > > > > > > > > > Best, > > > > > Lincoln Lee > > > > > > > > > > [1] > > > > > > > > > > > > > > > > > > > https://issues.apache.org/jira/secure/ReleaseNote.jspa?projectId=12315522=12353282 > > > > > > > > > > > > > > > Robin Moffatt 于2024年3月11日周一 19:36写道： > > > > > > > > > > > Looking at the release notes [1] it lists `DESCRIBE DATABASE` > > > > > (FLINK-14879) > > > > > > and `DESCRIBE CATALOG` (FLINK-14690). > > > > > > When I try these in 1.19 RC2 the behaviour is as in 1.18.1, i.e. it > > > is > > > > > not > > > > > > supported: > > > > > > > > > > > > ``` > > > > > > [INFO] Execute statement succeed. > > > > > > > > > > > > Flink SQL> show catalogs; > > > > > > +-+ > > > > > > |catalog name | > > > > > > +-+ > > > > > > | c_new | > > > > > > | default_catalog | > > > > > > +-+ > > > > > > 2 rows in set > > > > > > > > > > > > Flink SQL> DESCRIBE CATALOG c_new; > > > > > > [ERROR] Could not execute SQL statement. Reason: > > > > > > org.apache.calcite.sql.validate.SqlValidatorException: Column > > 'c_new' > > > > not > > > > > > found in any table > > > > > > > > > > > > Flink SQL> show databases; > > > > > > +--+ > > > > > > |database name | > > > > > > +--+ > > > > > > | default_database | > > > > > > +--+ > > > > > > 1 row in set > > > > > > > > > > > > Flink SQL> DESCRIBE DATABASE default_database; > > > > > > [ERROR] Could not execute SQL statement. Reason: > > > > > > org.apache.calcite.sql.validate.SqlValidatorException: Column > > > > > > 'default_database' not found in > > > > > > any table > > > > > > ``` > > > > > > > > > > > > Is this an error in the release notes, or my mistake in > > interpreting > > > > > them? > > > > > > > > > > > > thanks, Robin. > > > > > > > > > > > > > > > > > > [1] > > > > > > > > > > > > > > > > > > > > > > > > > > https://issues.apache.org/jira/secure/ReleaseNote.jspa?projectId=12315522=12353282 > > > > > > > > > > > > On Thu, 7 Mar 2024 at 10:01, Lincoln Lee > > > > wrote: > > > > > > > > > > > > > Hi everyone, > > > > > > > > > > > > > > Please review and vote on the release candidate #2 for the > > version > > > > > > 1.19.0, > > > > > > > as follows: > > > > > > > [ ] +1, Approve the release > > > > > > > [ ] -1, Do not approve the release (please provide specific > > > comments) > > > > > > > > > > > > > > The complete staging area is available for your review, which > > > > includes: > > > > > > > > > > > > > > * JIRA release notes [1], and the pull request adding release > > note > > > > for > > > > > > > users [2] > > > > > > > * the official Apache source release and binary convenience > > > releases > > > > to > > > > > > be > > > > > > > deployed to dist.apache.org [3], which are signed with the key > > > with > > > > > > > fingerprint E57D30ABEE75CA06 [4], > > > > > > > * all artifacts to be deployed to the Maven Central Repository > > [5], > > > > > > > * source code tag "release-1.19.0-rc2" [6], > > > > > > > * website pull request listing the new release and adding > > > > announcement > > > > > > blog > > > > > > > post [7]. > > > > > > > > > > > > > > The vote will be open for at least 72 hours. It is adopted by
Re: [VOTE] Release 1.19.0, release candidate #2
+1 (non-binding) - Verified signatures and checksums - Reviewed Web PR - Built from source successfully - Ran a wordcount job which worked well On Tue, Mar 12, 2024 at 1:00 AM Jeyhun Karimov wrote: > +1 (non binding) > > - verified that source distribution does not contain binaries > - verified signatures and checksums > - built source code successfully > > Regards, > Jeyhun > > > On Mon, Mar 11, 2024 at 3:08 PM Samrat Deb wrote: > > > +1 (non binding) > > > > - verified signatures and checksums > > - ASF headers are present in all expected file > > - No unexpected binaries files found in the source > > - Build successful locally > > - tested basic word count example > > > > > > > > > > Bests, > > Samrat > > > > On Mon, 11 Mar 2024 at 7:33 PM, Ahmed Hamdy > wrote: > > > > > Hi Lincoln > > > +1 (non-binding) from me > > > > > > - Verified Checksums & Signatures > > > - Verified Source dists don't contain binaries > > > - Built source successfully > > > - reviewed web PR > > > > > > > > > Best Regards > > > Ahmed Hamdy > > > > > > > > > On Mon, 11 Mar 2024 at 15:18, Lincoln Lee > > wrote: > > > > > > > Hi Robin, > > > > > > > > Thanks for helping verifying the release note[1], FLINK-14879 should > > not > > > > have been included, after confirming this > > > > I moved all unresolved non-blocker issues left over from 1.19.0 to > > 1.20.0 > > > > and reconfigured the release note [1]. > > > > > > > > Best, > > > > Lincoln Lee > > > > > > > > [1] > > > > > > > > > > > > > > https://issues.apache.org/jira/secure/ReleaseNote.jspa?projectId=12315522=12353282 > > > > > > > > > > > > Robin Moffatt 于2024年3月11日周一 19:36写道： > > > > > > > > > Looking at the release notes [1] it lists `DESCRIBE DATABASE` > > > > (FLINK-14879) > > > > > and `DESCRIBE CATALOG` (FLINK-14690). > > > > > When I try these in 1.19 RC2 the behaviour is as in 1.18.1, i.e. it > > is > > > > not > > > > > supported: > > > > > > > > > > ``` > > > > > [INFO] Execute statement succeed. > > > > > > > > > > Flink SQL> show catalogs; > > > > > +-+ > > > > > |catalog name | > > > > > +-+ > > > > > | c_new | > > > > > | default_catalog | > > > > > +-+ > > > > > 2 rows in set > > > > > > > > > > Flink SQL> DESCRIBE CATALOG c_new; > > > > > [ERROR] Could not execute SQL statement. Reason: > > > > > org.apache.calcite.sql.validate.SqlValidatorException: Column > 'c_new' > > > not > > > > > found in any table > > > > > > > > > > Flink SQL> show databases; > > > > > +--+ > > > > > |database name | > > > > > +--+ > > > > > | default_database | > > > > > +--+ > > > > > 1 row in set > > > > > > > > > > Flink SQL> DESCRIBE DATABASE default_database; > > > > > [ERROR] Could not execute SQL statement. Reason: > > > > > org.apache.calcite.sql.validate.SqlValidatorException: Column > > > > > 'default_database' not found in > > > > > any table > > > > > ``` > > > > > > > > > > Is this an error in the release notes, or my mistake in > interpreting > > > > them? > > > > > > > > > > thanks, Robin. > > > > > > > > > > > > > > > [1] > > > > > > > > > > > > > > > > > > > > https://issues.apache.org/jira/secure/ReleaseNote.jspa?projectId=12315522=12353282 > > > > > > > > > > On Thu, 7 Mar 2024 at 10:01, Lincoln Lee > > > wrote: > > > > > > > > > > > Hi everyone, > > > > > > > > > > > > Please review and vote on the release candidate #2 for the > version > > > > > 1.19.0, > > > > > > as follows: > > > > > > [ ] +1, Approve the release > > > > > > [ ] -1, Do not approve the release (please provide specific > > comments) > > > > > > > > > > > > The complete staging area is available for your review, which > > > includes: > > > > > > > > > > > > * JIRA release notes [1], and the pull request adding release > note > > > for > > > > > > users [2] > > > > > > * the official Apache source release and binary convenience > > releases > > > to > > > > > be > > > > > > deployed to dist.apache.org [3], which are signed with the key > > with > > > > > > fingerprint E57D30ABEE75CA06 [4], > > > > > > * all artifacts to be deployed to the Maven Central Repository > [5], > > > > > > * source code tag "release-1.19.0-rc2" [6], > > > > > > * website pull request listing the new release and adding > > > announcement > > > > > blog > > > > > > post [7]. > > > > > > > > > > > > The vote will be open for at least 72 hours. It is adopted by > > > majority > > > > > > approval, with at least 3 PMC affirmative votes. > > > > > > > > > > > > [1] > > > > > > > > > > > > > > > > > > > > > > > > > > > https://issues.apache.org/jira/secure/ReleaseNote.jspa?projectId=12315522=12353282 > > > > > > [2] https://github.com/apache/flink/pull/24394 > > > > > > [3] > https://dist.apache.org/repos/dist/dev/flink/flink-1.19.0-rc2/ > > > > > > [4] https://dist.apache.org/repos/dist/release/flink/KEYS > > > > > > [5] > > > > > > >
Re: [VOTE] Release 1.19.0, release candidate #2
+1 (non binding) - verified that source distribution does not contain binaries - verified signatures and checksums - built source code successfully Regards, Jeyhun On Mon, Mar 11, 2024 at 3:08 PM Samrat Deb wrote: > +1 (non binding) > > - verified signatures and checksums > - ASF headers are present in all expected file > - No unexpected binaries files found in the source > - Build successful locally > - tested basic word count example > > > > > Bests, > Samrat > > On Mon, 11 Mar 2024 at 7:33 PM, Ahmed Hamdy wrote: > > > Hi Lincoln > > +1 (non-binding) from me > > > > - Verified Checksums & Signatures > > - Verified Source dists don't contain binaries > > - Built source successfully > > - reviewed web PR > > > > > > Best Regards > > Ahmed Hamdy > > > > > > On Mon, 11 Mar 2024 at 15:18, Lincoln Lee > wrote: > > > > > Hi Robin, > > > > > > Thanks for helping verifying the release note[1], FLINK-14879 should > not > > > have been included, after confirming this > > > I moved all unresolved non-blocker issues left over from 1.19.0 to > 1.20.0 > > > and reconfigured the release note [1]. > > > > > > Best, > > > Lincoln Lee > > > > > > [1] > > > > > > > > > https://issues.apache.org/jira/secure/ReleaseNote.jspa?projectId=12315522=12353282 > > > > > > > > > Robin Moffatt 于2024年3月11日周一 19:36写道： > > > > > > > Looking at the release notes [1] it lists `DESCRIBE DATABASE` > > > (FLINK-14879) > > > > and `DESCRIBE CATALOG` (FLINK-14690). > > > > When I try these in 1.19 RC2 the behaviour is as in 1.18.1, i.e. it > is > > > not > > > > supported: > > > > > > > > ``` > > > > [INFO] Execute statement succeed. > > > > > > > > Flink SQL> show catalogs; > > > > +-+ > > > > |catalog name | > > > > +-+ > > > > | c_new | > > > > | default_catalog | > > > > +-+ > > > > 2 rows in set > > > > > > > > Flink SQL> DESCRIBE CATALOG c_new; > > > > [ERROR] Could not execute SQL statement. Reason: > > > > org.apache.calcite.sql.validate.SqlValidatorException: Column 'c_new' > > not > > > > found in any table > > > > > > > > Flink SQL> show databases; > > > > +--+ > > > > |database name | > > > > +--+ > > > > | default_database | > > > > +--+ > > > > 1 row in set > > > > > > > > Flink SQL> DESCRIBE DATABASE default_database; > > > > [ERROR] Could not execute SQL statement. Reason: > > > > org.apache.calcite.sql.validate.SqlValidatorException: Column > > > > 'default_database' not found in > > > > any table > > > > ``` > > > > > > > > Is this an error in the release notes, or my mistake in interpreting > > > them? > > > > > > > > thanks, Robin. > > > > > > > > > > > > [1] > > > > > > > > > > > > > > https://issues.apache.org/jira/secure/ReleaseNote.jspa?projectId=12315522=12353282 > > > > > > > > On Thu, 7 Mar 2024 at 10:01, Lincoln Lee > > wrote: > > > > > > > > > Hi everyone, > > > > > > > > > > Please review and vote on the release candidate #2 for the version > > > > 1.19.0, > > > > > as follows: > > > > > [ ] +1, Approve the release > > > > > [ ] -1, Do not approve the release (please provide specific > comments) > > > > > > > > > > The complete staging area is available for your review, which > > includes: > > > > > > > > > > * JIRA release notes [1], and the pull request adding release note > > for > > > > > users [2] > > > > > * the official Apache source release and binary convenience > releases > > to > > > > be > > > > > deployed to dist.apache.org [3], which are signed with the key > with > > > > > fingerprint E57D30ABEE75CA06 [4], > > > > > * all artifacts to be deployed to the Maven Central Repository [5], > > > > > * source code tag "release-1.19.0-rc2" [6], > > > > > * website pull request listing the new release and adding > > announcement > > > > blog > > > > > post [7]. > > > > > > > > > > The vote will be open for at least 72 hours. It is adopted by > > majority > > > > > approval, with at least 3 PMC affirmative votes. > > > > > > > > > > [1] > > > > > > > > > > > > > > > > > > > > https://issues.apache.org/jira/secure/ReleaseNote.jspa?projectId=12315522=12353282 > > > > > [2] https://github.com/apache/flink/pull/24394 > > > > > [3] https://dist.apache.org/repos/dist/dev/flink/flink-1.19.0-rc2/ > > > > > [4] https://dist.apache.org/repos/dist/release/flink/KEYS > > > > > [5] > > > > > https://repository.apache.org/content/repositories/orgapacheflink-1709 > > > > > [6] > https://github.com/apache/flink/releases/tag/release-1.19.0-rc2 > > > > > [7] https://github.com/apache/flink-web/pull/721 > > > > > > > > > > > > > > > Best, > > > > > Yun, Jing, Martijn and Lincoln > > > > > > > > > > > > > > >
Re: [VOTE] Release 1.19.0, release candidate #2
+1 (non binding) - verified signatures and checksums - ASF headers are present in all expected file - No unexpected binaries files found in the source - Build successful locally - tested basic word count example Bests, Samrat On Mon, 11 Mar 2024 at 7:33 PM, Ahmed Hamdy wrote: > Hi Lincoln > +1 (non-binding) from me > > - Verified Checksums & Signatures > - Verified Source dists don't contain binaries > - Built source successfully > - reviewed web PR > > > Best Regards > Ahmed Hamdy > > > On Mon, 11 Mar 2024 at 15:18, Lincoln Lee wrote: > > > Hi Robin, > > > > Thanks for helping verifying the release note[1], FLINK-14879 should not > > have been included, after confirming this > > I moved all unresolved non-blocker issues left over from 1.19.0 to 1.20.0 > > and reconfigured the release note [1]. > > > > Best, > > Lincoln Lee > > > > [1] > > > > > https://issues.apache.org/jira/secure/ReleaseNote.jspa?projectId=12315522=12353282 > > > > > > Robin Moffatt 于2024年3月11日周一 19:36写道： > > > > > Looking at the release notes [1] it lists `DESCRIBE DATABASE` > > (FLINK-14879) > > > and `DESCRIBE CATALOG` (FLINK-14690). > > > When I try these in 1.19 RC2 the behaviour is as in 1.18.1, i.e. it is > > not > > > supported: > > > > > > ``` > > > [INFO] Execute statement succeed. > > > > > > Flink SQL> show catalogs; > > > +-+ > > > |catalog name | > > > +-+ > > > | c_new | > > > | default_catalog | > > > +-+ > > > 2 rows in set > > > > > > Flink SQL> DESCRIBE CATALOG c_new; > > > [ERROR] Could not execute SQL statement. Reason: > > > org.apache.calcite.sql.validate.SqlValidatorException: Column 'c_new' > not > > > found in any table > > > > > > Flink SQL> show databases; > > > +--+ > > > |database name | > > > +--+ > > > | default_database | > > > +--+ > > > 1 row in set > > > > > > Flink SQL> DESCRIBE DATABASE default_database; > > > [ERROR] Could not execute SQL statement. Reason: > > > org.apache.calcite.sql.validate.SqlValidatorException: Column > > > 'default_database' not found in > > > any table > > > ``` > > > > > > Is this an error in the release notes, or my mistake in interpreting > > them? > > > > > > thanks, Robin. > > > > > > > > > [1] > > > > > > > > > https://issues.apache.org/jira/secure/ReleaseNote.jspa?projectId=12315522=12353282 > > > > > > On Thu, 7 Mar 2024 at 10:01, Lincoln Lee > wrote: > > > > > > > Hi everyone, > > > > > > > > Please review and vote on the release candidate #2 for the version > > > 1.19.0, > > > > as follows: > > > > [ ] +1, Approve the release > > > > [ ] -1, Do not approve the release (please provide specific comments) > > > > > > > > The complete staging area is available for your review, which > includes: > > > > > > > > * JIRA release notes [1], and the pull request adding release note > for > > > > users [2] > > > > * the official Apache source release and binary convenience releases > to > > > be > > > > deployed to dist.apache.org [3], which are signed with the key with > > > > fingerprint E57D30ABEE75CA06 [4], > > > > * all artifacts to be deployed to the Maven Central Repository [5], > > > > * source code tag "release-1.19.0-rc2" [6], > > > > * website pull request listing the new release and adding > announcement > > > blog > > > > post [7]. > > > > > > > > The vote will be open for at least 72 hours. It is adopted by > majority > > > > approval, with at least 3 PMC affirmative votes. > > > > > > > > [1] > > > > > > > > > > > > > > https://issues.apache.org/jira/secure/ReleaseNote.jspa?projectId=12315522=12353282 > > > > [2] https://github.com/apache/flink/pull/24394 > > > > [3] https://dist.apache.org/repos/dist/dev/flink/flink-1.19.0-rc2/ > > > > [4] https://dist.apache.org/repos/dist/release/flink/KEYS > > > > [5] > > > https://repository.apache.org/content/repositories/orgapacheflink-1709 > > > > [6] https://github.com/apache/flink/releases/tag/release-1.19.0-rc2 > > > > [7] https://github.com/apache/flink-web/pull/721 > > > > > > > > > > > > Best, > > > > Yun, Jing, Martijn and Lincoln > > > > > > > > > >
Re: [VOTE] Release 1.19.0, release candidate #2
Hi Lincoln +1 (non-binding) from me - Verified Checksums & Signatures - Verified Source dists don't contain binaries - Built source successfully - reviewed web PR Best Regards Ahmed Hamdy On Mon, 11 Mar 2024 at 15:18, Lincoln Lee wrote: > Hi Robin, > > Thanks for helping verifying the release note[1], FLINK-14879 should not > have been included, after confirming this > I moved all unresolved non-blocker issues left over from 1.19.0 to 1.20.0 > and reconfigured the release note [1]. > > Best, > Lincoln Lee > > [1] > > https://issues.apache.org/jira/secure/ReleaseNote.jspa?projectId=12315522=12353282 > > > Robin Moffatt 于2024年3月11日周一 19:36写道： > > > Looking at the release notes [1] it lists `DESCRIBE DATABASE` > (FLINK-14879) > > and `DESCRIBE CATALOG` (FLINK-14690). > > When I try these in 1.19 RC2 the behaviour is as in 1.18.1, i.e. it is > not > > supported: > > > > ``` > > [INFO] Execute statement succeed. > > > > Flink SQL> show catalogs; > > +-+ > > |catalog name | > > +-+ > > | c_new | > > | default_catalog | > > +-+ > > 2 rows in set > > > > Flink SQL> DESCRIBE CATALOG c_new; > > [ERROR] Could not execute SQL statement. Reason: > > org.apache.calcite.sql.validate.SqlValidatorException: Column 'c_new' not > > found in any table > > > > Flink SQL> show databases; > > +--+ > > |database name | > > +--+ > > | default_database | > > +--+ > > 1 row in set > > > > Flink SQL> DESCRIBE DATABASE default_database; > > [ERROR] Could not execute SQL statement. Reason: > > org.apache.calcite.sql.validate.SqlValidatorException: Column > > 'default_database' not found in > > any table > > ``` > > > > Is this an error in the release notes, or my mistake in interpreting > them? > > > > thanks, Robin. > > > > > > [1] > > > > > https://issues.apache.org/jira/secure/ReleaseNote.jspa?projectId=12315522=12353282 > > > > On Thu, 7 Mar 2024 at 10:01, Lincoln Lee wrote: > > > > > Hi everyone, > > > > > > Please review and vote on the release candidate #2 for the version > > 1.19.0, > > > as follows: > > > [ ] +1, Approve the release > > > [ ] -1, Do not approve the release (please provide specific comments) > > > > > > The complete staging area is available for your review, which includes: > > > > > > * JIRA release notes [1], and the pull request adding release note for > > > users [2] > > > * the official Apache source release and binary convenience releases to > > be > > > deployed to dist.apache.org [3], which are signed with the key with > > > fingerprint E57D30ABEE75CA06 [4], > > > * all artifacts to be deployed to the Maven Central Repository [5], > > > * source code tag "release-1.19.0-rc2" [6], > > > * website pull request listing the new release and adding announcement > > blog > > > post [7]. > > > > > > The vote will be open for at least 72 hours. It is adopted by majority > > > approval, with at least 3 PMC affirmative votes. > > > > > > [1] > > > > > > > > > https://issues.apache.org/jira/secure/ReleaseNote.jspa?projectId=12315522=12353282 > > > [2] https://github.com/apache/flink/pull/24394 > > > [3] https://dist.apache.org/repos/dist/dev/flink/flink-1.19.0-rc2/ > > > [4] https://dist.apache.org/repos/dist/release/flink/KEYS > > > [5] > > https://repository.apache.org/content/repositories/orgapacheflink-1709 > > > [6] https://github.com/apache/flink/releases/tag/release-1.19.0-rc2 > > > [7] https://github.com/apache/flink-web/pull/721 > > > > > > > > > Best, > > > Yun, Jing, Martijn and Lincoln > > > > > >
Re: [VOTE] Release 1.19.0, release candidate #2
Hi Robin, Thanks for helping verifying the release note[1], FLINK-14879 should not have been included, after confirming this I moved all unresolved non-blocker issues left over from 1.19.0 to 1.20.0 and reconfigured the release note [1]. Best, Lincoln Lee [1] https://issues.apache.org/jira/secure/ReleaseNote.jspa?projectId=12315522=12353282 Robin Moffatt 于2024年3月11日周一 19:36写道： > Looking at the release notes [1] it lists `DESCRIBE DATABASE` (FLINK-14879) > and `DESCRIBE CATALOG` (FLINK-14690). > When I try these in 1.19 RC2 the behaviour is as in 1.18.1, i.e. it is not > supported: > > ``` > [INFO] Execute statement succeed. > > Flink SQL> show catalogs; > +-+ > |catalog name | > +-+ > | c_new | > | default_catalog | > +-+ > 2 rows in set > > Flink SQL> DESCRIBE CATALOG c_new; > [ERROR] Could not execute SQL statement. Reason: > org.apache.calcite.sql.validate.SqlValidatorException: Column 'c_new' not > found in any table > > Flink SQL> show databases; > +--+ > |database name | > +--+ > | default_database | > +--+ > 1 row in set > > Flink SQL> DESCRIBE DATABASE default_database; > [ERROR] Could not execute SQL statement. Reason: > org.apache.calcite.sql.validate.SqlValidatorException: Column > 'default_database' not found in > any table > ``` > > Is this an error in the release notes, or my mistake in interpreting them? > > thanks, Robin. > > > [1] > > https://issues.apache.org/jira/secure/ReleaseNote.jspa?projectId=12315522=12353282 > > On Thu, 7 Mar 2024 at 10:01, Lincoln Lee wrote: > > > Hi everyone, > > > > Please review and vote on the release candidate #2 for the version > 1.19.0, > > as follows: > > [ ] +1, Approve the release > > [ ] -1, Do not approve the release (please provide specific comments) > > > > The complete staging area is available for your review, which includes: > > > > * JIRA release notes [1], and the pull request adding release note for > > users [2] > > * the official Apache source release and binary convenience releases to > be > > deployed to dist.apache.org [3], which are signed with the key with > > fingerprint E57D30ABEE75CA06 [4], > > * all artifacts to be deployed to the Maven Central Repository [5], > > * source code tag "release-1.19.0-rc2" [6], > > * website pull request listing the new release and adding announcement > blog > > post [7]. > > > > The vote will be open for at least 72 hours. It is adopted by majority > > approval, with at least 3 PMC affirmative votes. > > > > [1] > > > > > https://issues.apache.org/jira/secure/ReleaseNote.jspa?projectId=12315522=12353282 > > [2] https://github.com/apache/flink/pull/24394 > > [3] https://dist.apache.org/repos/dist/dev/flink/flink-1.19.0-rc2/ > > [4] https://dist.apache.org/repos/dist/release/flink/KEYS > > [5] > https://repository.apache.org/content/repositories/orgapacheflink-1709 > > [6] https://github.com/apache/flink/releases/tag/release-1.19.0-rc2 > > [7] https://github.com/apache/flink-web/pull/721 > > > > > > Best, > > Yun, Jing, Martijn and Lincoln > > >
Re: [VOTE] Release 1.19.0, release candidate #2
Looking at the release notes [1] it lists `DESCRIBE DATABASE` (FLINK-14879) and `DESCRIBE CATALOG` (FLINK-14690). When I try these in 1.19 RC2 the behaviour is as in 1.18.1, i.e. it is not supported: ``` [INFO] Execute statement succeed. Flink SQL> show catalogs; +-+ |catalog name | +-+ | c_new | | default_catalog | +-+ 2 rows in set Flink SQL> DESCRIBE CATALOG c_new; [ERROR] Could not execute SQL statement. Reason: org.apache.calcite.sql.validate.SqlValidatorException: Column 'c_new' not found in any table Flink SQL> show databases; +--+ |database name | +--+ | default_database | +--+ 1 row in set Flink SQL> DESCRIBE DATABASE default_database; [ERROR] Could not execute SQL statement. Reason: org.apache.calcite.sql.validate.SqlValidatorException: Column 'default_database' not found in any table ``` Is this an error in the release notes, or my mistake in interpreting them? thanks, Robin. [1] https://issues.apache.org/jira/secure/ReleaseNote.jspa?projectId=12315522=12353282 On Thu, 7 Mar 2024 at 10:01, Lincoln Lee wrote: > Hi everyone, > > Please review and vote on the release candidate #2 for the version 1.19.0, > as follows: > [ ] +1, Approve the release > [ ] -1, Do not approve the release (please provide specific comments) > > The complete staging area is available for your review, which includes: > > * JIRA release notes [1], and the pull request adding release note for > users [2] > * the official Apache source release and binary convenience releases to be > deployed to dist.apache.org [3], which are signed with the key with > fingerprint E57D30ABEE75CA06 [4], > * all artifacts to be deployed to the Maven Central Repository [5], > * source code tag "release-1.19.0-rc2" [6], > * website pull request listing the new release and adding announcement blog > post [7]. > > The vote will be open for at least 72 hours. It is adopted by majority > approval, with at least 3 PMC affirmative votes. > > [1] > > https://issues.apache.org/jira/secure/ReleaseNote.jspa?projectId=12315522=12353282 > [2] https://github.com/apache/flink/pull/24394 > [3] https://dist.apache.org/repos/dist/dev/flink/flink-1.19.0-rc2/ > [4] https://dist.apache.org/repos/dist/release/flink/KEYS > [5] https://repository.apache.org/content/repositories/orgapacheflink-1709 > [6] https://github.com/apache/flink/releases/tag/release-1.19.0-rc2 > [7] https://github.com/apache/flink-web/pull/721 > > > Best, > Yun, Jing, Martijn and Lincoln >
Re: [VOTE] Release 1.19.0, release candidate #2
+1 (non binding) I quickly checked: - signatures and checksums are OK - ASF headers are present in all expected file - No unexpected binaries files found in the source distribution - Build OK on the tag Thanks ! Regards JB On Thu, Mar 7, 2024 at 11:00 AM Lincoln Lee wrote: > > Hi everyone, > > Please review and vote on the release candidate #2 for the version 1.19.0, > as follows: > [ ] +1, Approve the release > [ ] -1, Do not approve the release (please provide specific comments) > > The complete staging area is available for your review, which includes: > > * JIRA release notes [1], and the pull request adding release note for > users [2] > * the official Apache source release and binary convenience releases to be > deployed to dist.apache.org [3], which are signed with the key with > fingerprint E57D30ABEE75CA06 [4], > * all artifacts to be deployed to the Maven Central Repository [5], > * source code tag "release-1.19.0-rc2" [6], > * website pull request listing the new release and adding announcement blog > post [7]. > > The vote will be open for at least 72 hours. It is adopted by majority > approval, with at least 3 PMC affirmative votes. > > [1] > https://issues.apache.org/jira/secure/ReleaseNote.jspa?projectId=12315522=12353282 > [2] https://github.com/apache/flink/pull/24394 > [3] https://dist.apache.org/repos/dist/dev/flink/flink-1.19.0-rc2/ > [4] https://dist.apache.org/repos/dist/release/flink/KEYS > [5] https://repository.apache.org/content/repositories/orgapacheflink-1709 > [6] https://github.com/apache/flink/releases/tag/release-1.19.0-rc2 > [7] https://github.com/apache/flink-web/pull/721 > > > Best, > Yun, Jing, Martijn and Lincoln
Re: [VOTE] Release 1.19.0, release candidate #2
+1 (binding) - verified signature and checksum - verified that source distribution does not contain binaries - built from source and played with example jobs, everything looks fine - reviewed the release announcement PR Best, Xintong On Thu, Mar 7, 2024 at 6:01 PM Lincoln Lee wrote: > Hi everyone, > > Please review and vote on the release candidate #2 for the version 1.19.0, > as follows: > [ ] +1, Approve the release > [ ] -1, Do not approve the release (please provide specific comments) > > The complete staging area is available for your review, which includes: > > * JIRA release notes [1], and the pull request adding release note for > users [2] > * the official Apache source release and binary convenience releases to be > deployed to dist.apache.org [3], which are signed with the key with > fingerprint E57D30ABEE75CA06 [4], > * all artifacts to be deployed to the Maven Central Repository [5], > * source code tag "release-1.19.0-rc2" [6], > * website pull request listing the new release and adding announcement blog > post [7]. > > The vote will be open for at least 72 hours. It is adopted by majority > approval, with at least 3 PMC affirmative votes. > > [1] > > https://issues.apache.org/jira/secure/ReleaseNote.jspa?projectId=12315522=12353282 > [2] https://github.com/apache/flink/pull/24394 > [3] https://dist.apache.org/repos/dist/dev/flink/flink-1.19.0-rc2/ > [4] https://dist.apache.org/repos/dist/release/flink/KEYS > [5] https://repository.apache.org/content/repositories/orgapacheflink-1709 > [6] https://github.com/apache/flink/releases/tag/release-1.19.0-rc2 > [7] https://github.com/apache/flink-web/pull/721 > > > Best, > Yun, Jing, Martijn and Lincoln >
[VOTE] Release 1.19.0, release candidate #2
Hi everyone, Please review and vote on the release candidate #2 for the version 1.19.0, as follows: [ ] +1, Approve the release [ ] -1, Do not approve the release (please provide specific comments) The complete staging area is available for your review, which includes: * JIRA release notes [1], and the pull request adding release note for users [2] * the official Apache source release and binary convenience releases to be deployed to dist.apache.org [3], which are signed with the key with fingerprint E57D30ABEE75CA06 [4], * all artifacts to be deployed to the Maven Central Repository [5], * source code tag "release-1.19.0-rc2" [6], * website pull request listing the new release and adding announcement blog post [7]. The vote will be open for at least 72 hours. It is adopted by majority approval, with at least 3 PMC affirmative votes. [1] https://issues.apache.org/jira/secure/ReleaseNote.jspa?projectId=12315522=12353282 [2] https://github.com/apache/flink/pull/24394 [3] https://dist.apache.org/repos/dist/dev/flink/flink-1.19.0-rc2/ [4] https://dist.apache.org/repos/dist/release/flink/KEYS [5] https://repository.apache.org/content/repositories/orgapacheflink-1709 [6] https://github.com/apache/flink/releases/tag/release-1.19.0-rc2 [7] https://github.com/apache/flink-web/pull/721 Best, Yun, Jing, Martijn and Lincoln
