Re: [VOTE] Release flink-connector-jdbc, release candidate #2

2024-01-31 Thread Sergey Nuyanzin
Thanks everyone for the feedback

This RC is cancelled and a new one will be created

On Thu, Feb 1, 2024 at 2:42 AM Leonard Xu  wrote:

> Thanks Sergey for driving this!
>
> -1(binding) as we discussed on the web PR[1], looking forward next RC.
>
> Best,
> Leonard
> [1] https://github.com/apache/flink-web/pull/707#discussion_r1471090061
>
> > 2024年1月30日 上午8:17,Sergey Nuyanzin  写道:
> >
> > Hi everyone,
> > Please review and vote on the release candidate #2 for the version
> > 3.1.2, as follows:
> > [ ] +1, Approve the release
> > [ ] -1, Do not approve the release (please provide specific comments)
> >
> > This version is compatible with Flink 1.16.x, 1.17.x and 1.18.x.
> >
> > The complete staging area is available for your review, which includes:
> > * JIRA release notes [1],
> > * the official Apache source release to be deployed to dist.apache.org
> > [2], which are signed with the key with fingerprint
> > 1596BBF0726835D8 [3],
> > * all artifacts to be deployed to the Maven Central Repository [4],
> > * source code tag v3.1.2-rc2 [5],
> > * website pull request listing the new release [6].
> >
> > The vote will be open for at least 72 hours. It is adopted by majority
> > approval, with at least 3 PMC affirmative votes.
> >
> > Thanks,
> > Release Manager
> >
> > [1]
> >
> https://issues.apache.org/jira/secure/ReleaseNote.jspa?projectId=12315522=12354088
> > [2]
> >
> https://dist.apache.org/repos/dist/dev/flink/flink-connector-jdbc-3.1.2-rc2
> > [3] https://dist.apache.org/repos/dist/release/flink/KEYS
> > [4]
> https://repository.apache.org/content/repositories/orgapacheflink-1704/
> > [5]
> https://github.com/apache/flink-connector-jdbc/releases/tag/v3.1.2-rc2
> > [6] https://github.com/apache/flink-web/pull/707
>
>

-- 
Best regards,
Sergey


Re: [VOTE] Release flink-connector-jdbc, release candidate #2

2024-01-31 Thread Leonard Xu
Thanks Sergey for driving this!
 
-1(binding) as we discussed on the web PR[1], looking forward next RC.

Best,
Leonard
[1] https://github.com/apache/flink-web/pull/707#discussion_r1471090061

> 2024年1月30日 上午8:17,Sergey Nuyanzin  写道:
> 
> Hi everyone,
> Please review and vote on the release candidate #2 for the version
> 3.1.2, as follows:
> [ ] +1, Approve the release
> [ ] -1, Do not approve the release (please provide specific comments)
> 
> This version is compatible with Flink 1.16.x, 1.17.x and 1.18.x.
> 
> The complete staging area is available for your review, which includes:
> * JIRA release notes [1],
> * the official Apache source release to be deployed to dist.apache.org
> [2], which are signed with the key with fingerprint
> 1596BBF0726835D8 [3],
> * all artifacts to be deployed to the Maven Central Repository [4],
> * source code tag v3.1.2-rc2 [5],
> * website pull request listing the new release [6].
> 
> The vote will be open for at least 72 hours. It is adopted by majority
> approval, with at least 3 PMC affirmative votes.
> 
> Thanks,
> Release Manager
> 
> [1]
> https://issues.apache.org/jira/secure/ReleaseNote.jspa?projectId=12315522=12354088
> [2]
> https://dist.apache.org/repos/dist/dev/flink/flink-connector-jdbc-3.1.2-rc2
> [3] https://dist.apache.org/repos/dist/release/flink/KEYS
> [4] https://repository.apache.org/content/repositories/orgapacheflink-1704/
> [5] https://github.com/apache/flink-connector-jdbc/releases/tag/v3.1.2-rc2
> [6] https://github.com/apache/flink-web/pull/707



Re: [VOTE] Release flink-connector-jdbc, release candidate #2

2024-01-31 Thread Sergey Nuyanzin
Hi David, thanks for your feedback

> This release introduces (I assume experimental, like Flink’s statement
around Java compatibility but we have not documented this as experimental)
support for Java 17. I see
https://nightlies.apache.org/flink/flink-docs-master/docs/deployment/java_compatibility/
says that java 17 support was added at 1.18. I can’t find a backport to
1.16 or 1.17? Should JDBC java 17 support (FLINK-33787) be included in this
release?

FLINK-33787 is included in release, please see JIRA release notes[1]
I don't think we can backport java 17 support to 1.16, 1.17,
that's why java 17 support was added only for connector running with Flink
1.18, you can see it in GHA config [2]

>The Flink version in the pom is 1.17, but we are saying we support Flink
1.16.

yes, that's true, it seems it is is the result of [3], as there were issues
with archunit tests
at the same time we still have nightly/weekly tests running against Flink
1.16 as well
and latest test are green [4]
@Martijn Visser may be you can provide more details

[1]
https://issues.apache.org/jira/secure/ReleaseNote.jspa?projectId=12315522=12354088
[2]
https://github.com/apache/flink-connector-jdbc/blob/v3.1/.github/workflows/push_pr.yml#L27-L32
[3] https://issues.apache.org/jira/browse/FLINK-31699
[4] https://github.com/apache/flink-connector-jdbc/actions/runs/7723924144

On Wed, Jan 31, 2024 at 11:18 AM David Radley 
wrote:

> Hi,
> [x] -1, Do not approve the release (please provide specific comments)
>
> I wanted clarifications on our thinking around the following.
>
> In the source code
> https://github.com/apache/flink-connector-jdbc/releases/tag/v3.1.2-rc2
>
>   *   This release introduces (I assume experimental, like Flink’s
> statement around Java compatibility but we have not documented this as
> experimental) support for Java 17. I see
> https://nightlies.apache.org/flink/flink-docs-master/docs/deployment/java_compatibility/
> says that java 17 support was added at 1.18. I can’t find a backport to
> 1.16 or 1.17? Should JDBC java 17 support (FLINK-33787) be included in this
> release?
>   *   The Flink version in the pom is 1.17, but we are saying we support
> Flink 1.16.
>
>
> Kind regards, David.
>
> From: Sergey Nuyanzin 
> Date: Tuesday, 30 January 2024 at 00:18
> To: dev@flink.apache.org 
> Subject: [EXTERNAL] [VOTE] Release flink-connector-jdbc, release candidate
> #2
> Hi everyone,
> Please review and vote on the release candidate #2 for the version
> 3.1.2, as follows:
> [ ] +1, Approve the release
> [ ] -1, Do not approve the release (please provide specific comments)
>
> This version is compatible with Flink 1.16.x, 1.17.x and 1.18.x.
>
> The complete staging area is available for your review, which includes:
> * JIRA release notes [1],
> * the official Apache source release to be deployed to dist.apache.org
> [2], which are signed with the key with fingerprint
> 1596BBF0726835D8 [3],
> * all artifacts to be deployed to the Maven Central Repository [4],
> * source code tag v3.1.2-rc2 [5],
> * website pull request listing the new release [6].
>
> The vote will be open for at least 72 hours. It is adopted by majority
> approval, with at least 3 PMC affirmative votes.
>
> Thanks,
> Release Manager
>
> [1]
>
> https://issues.apache.org/jira/secure/ReleaseNote.jspa?projectId=12315522=12354088
> [2]
> https://dist.apache.org/repos/dist/dev/flink/flink-connector-jdbc-3.1.2-rc2
> [3] https://dist.apache.org/repos/dist/release/flink/KEYS
> [4]
> https://repository.apache.org/content/repositories/orgapacheflink-1704/
> [5] https://github.com/apache/flink-connector-jdbc/releases/tag/v3.1.2-rc2
> [6] https://github.com/apache/flink-web/pull/707
>
> Unless otherwise stated above:
>
> IBM United Kingdom Limited
> Registered in England and Wales with number 741598
> Registered office: PO Box 41, North Harbour, Portsmouth, Hants. PO6 3AU
>


-- 
Best regards,
Sergey


Re: [VOTE] Release flink-connector-jdbc, release candidate #2

2024-01-31 Thread David Radley
Hi,
[x] -1, Do not approve the release (please provide specific comments)

I wanted clarifications on our thinking around the following.

In the source code 
https://github.com/apache/flink-connector-jdbc/releases/tag/v3.1.2-rc2

  *   This release introduces (I assume experimental, like Flink’s statement 
around Java compatibility but we have not documented this as experimental) 
support for Java 17. I see 
https://nightlies.apache.org/flink/flink-docs-master/docs/deployment/java_compatibility/
 says that java 17 support was added at 1.18. I can’t find a backport to 1.16 
or 1.17? Should JDBC java 17 support (FLINK-33787) be included in this release?
  *   The Flink version in the pom is 1.17, but we are saying we support Flink 
1.16.


Kind regards, David.

From: Sergey Nuyanzin 
Date: Tuesday, 30 January 2024 at 00:18
To: dev@flink.apache.org 
Subject: [EXTERNAL] [VOTE] Release flink-connector-jdbc, release candidate #2
Hi everyone,
Please review and vote on the release candidate #2 for the version
3.1.2, as follows:
[ ] +1, Approve the release
[ ] -1, Do not approve the release (please provide specific comments)

This version is compatible with Flink 1.16.x, 1.17.x and 1.18.x.

The complete staging area is available for your review, which includes:
* JIRA release notes [1],
* the official Apache source release to be deployed to dist.apache.org
[2], which are signed with the key with fingerprint
1596BBF0726835D8 [3],
* all artifacts to be deployed to the Maven Central Repository [4],
* source code tag v3.1.2-rc2 [5],
* website pull request listing the new release [6].

The vote will be open for at least 72 hours. It is adopted by majority
approval, with at least 3 PMC affirmative votes.

Thanks,
Release Manager

[1]
https://issues.apache.org/jira/secure/ReleaseNote.jspa?projectId=12315522=12354088
[2]
https://dist.apache.org/repos/dist/dev/flink/flink-connector-jdbc-3.1.2-rc2
[3] https://dist.apache.org/repos/dist/release/flink/KEYS
[4] https://repository.apache.org/content/repositories/orgapacheflink-1704/
[5] https://github.com/apache/flink-connector-jdbc/releases/tag/v3.1.2-rc2
[6] https://github.com/apache/flink-web/pull/707

Unless otherwise stated above:

IBM United Kingdom Limited
Registered in England and Wales with number 741598
Registered office: PO Box 41, North Harbour, Portsmouth, Hants. PO6 3AU


Re: [VOTE] Release flink-connector-jdbc, release candidate #2

2024-01-29 Thread Hang Ruan
+1 (non-binding)

- Validated checksum hash
- Verified signature
- Verified that no binaries exist in the source archive
- Build the source with Maven and jdk11
- Verified web PR
- Check that the jar is built by jdk8

Best,
Hang

Jiabao Sun  于2024年1月30日周二 10:52写道:

> +1(non-binding)
>
> - Release notes look good
> - Tag is present in Github
> - Validated checksum hash
> - Verified signature
> - Verified web PR and left minor comments
>
> Best,
> Jiabao
>
>
> On 2024/01/30 00:17:54 Sergey Nuyanzin wrote:
> > Hi everyone,
> > Please review and vote on the release candidate #2 for the version
> > 3.1.2, as follows:
> > [ ] +1, Approve the release
> > [ ] -1, Do not approve the release (please provide specific comments)
> >
> > This version is compatible with Flink 1.16.x, 1.17.x and 1.18.x.
> >
> > The complete staging area is available for your review, which includes:
> > * JIRA release notes [1],
> > * the official Apache source release to be deployed to dist.apache.org
> > [2], which are signed with the key with fingerprint
> > 1596BBF0726835D8 [3],
> > * all artifacts to be deployed to the Maven Central Repository [4],
> > * source code tag v3.1.2-rc2 [5],
> > * website pull request listing the new release [6].
> >
> > The vote will be open for at least 72 hours. It is adopted by majority
> > approval, with at least 3 PMC affirmative votes.
> >
> > Thanks,
> > Release Manager
> >
> > [1]
> >
> https://issues.apache.org/jira/secure/ReleaseNote.jspa?projectId=12315522=12354088
> > [2]
> >
> https://dist.apache.org/repos/dist/dev/flink/flink-connector-jdbc-3.1.2-rc2
> > [3] https://dist.apache.org/repos/dist/release/flink/KEYS
> > [4]
> https://repository.apache.org/content/repositories/orgapacheflink-1704/
> > [5]
> https://github.com/apache/flink-connector-jdbc/releases/tag/v3.1.2-rc2
> > [6] https://github.com/apache/flink-web/pull/707
> >


RE: [VOTE] Release flink-connector-jdbc, release candidate #2

2024-01-29 Thread Jiabao Sun
+1(non-binding)

- Release notes look good
- Tag is present in Github
- Validated checksum hash
- Verified signature
- Verified web PR and left minor comments

Best,
Jiabao


On 2024/01/30 00:17:54 Sergey Nuyanzin wrote:
> Hi everyone,
> Please review and vote on the release candidate #2 for the version
> 3.1.2, as follows:
> [ ] +1, Approve the release
> [ ] -1, Do not approve the release (please provide specific comments)
> 
> This version is compatible with Flink 1.16.x, 1.17.x and 1.18.x.
> 
> The complete staging area is available for your review, which includes:
> * JIRA release notes [1],
> * the official Apache source release to be deployed to dist.apache.org
> [2], which are signed with the key with fingerprint
> 1596BBF0726835D8 [3],
> * all artifacts to be deployed to the Maven Central Repository [4],
> * source code tag v3.1.2-rc2 [5],
> * website pull request listing the new release [6].
> 
> The vote will be open for at least 72 hours. It is adopted by majority
> approval, with at least 3 PMC affirmative votes.
> 
> Thanks,
> Release Manager
> 
> [1]
> https://issues.apache.org/jira/secure/ReleaseNote.jspa?projectId=12315522=12354088
> [2]
> https://dist.apache.org/repos/dist/dev/flink/flink-connector-jdbc-3.1.2-rc2
> [3] https://dist.apache.org/repos/dist/release/flink/KEYS
> [4] https://repository.apache.org/content/repositories/orgapacheflink-1704/
> [5] https://github.com/apache/flink-connector-jdbc/releases/tag/v3.1.2-rc2
> [6] https://github.com/apache/flink-web/pull/707
> 

[VOTE] Release flink-connector-jdbc, release candidate #2

2024-01-29 Thread Sergey Nuyanzin
Hi everyone,
Please review and vote on the release candidate #2 for the version
3.1.2, as follows:
[ ] +1, Approve the release
[ ] -1, Do not approve the release (please provide specific comments)

This version is compatible with Flink 1.16.x, 1.17.x and 1.18.x.

The complete staging area is available for your review, which includes:
* JIRA release notes [1],
* the official Apache source release to be deployed to dist.apache.org
[2], which are signed with the key with fingerprint
1596BBF0726835D8 [3],
* all artifacts to be deployed to the Maven Central Repository [4],
* source code tag v3.1.2-rc2 [5],
* website pull request listing the new release [6].

The vote will be open for at least 72 hours. It is adopted by majority
approval, with at least 3 PMC affirmative votes.

Thanks,
Release Manager

[1]
https://issues.apache.org/jira/secure/ReleaseNote.jspa?projectId=12315522=12354088
[2]
https://dist.apache.org/repos/dist/dev/flink/flink-connector-jdbc-3.1.2-rc2
[3] https://dist.apache.org/repos/dist/release/flink/KEYS
[4] https://repository.apache.org/content/repositories/orgapacheflink-1704/
[5] https://github.com/apache/flink-connector-jdbc/releases/tag/v3.1.2-rc2
[6] https://github.com/apache/flink-web/pull/707


Re: [VOTE] Release flink-connector-jdbc, release candidate #2

2022-12-21 Thread Martijn Visser
Hi all,

I'm happy to announce that we have unanimously approved this release.

There are 4 approving votes, 3 of which are binding:
* Sergey Nuyanzin (non-binding)
* Dawid (binding)
* Martijn (binding)
* Danny (binding)

There are no disapproving votes.

Thanks everyone!

Best regards,

Martijn

On Tue, Dec 20, 2022 at 2:31 PM Danny Cranmer 
wrote:

> Hello,
>
> +1 (binding)
>
> - Release notes look good
> - Verified signatures and hashes
> - Verified there are no binaries in the source archive
> - NOTICE/Licenses look good
> - Built source
> - Tag exists in Github
> - Contents of Maven repo look good
> - Reviewed web PR
>
> Thanks,
>
> On Tue, Dec 20, 2022 at 12:04 PM Martijn Visser 
> wrote:
>
> > +1 (binding)
> >
> > - Validated hashes
> > - Verified signature
> > - Verified that no binaries exist in the source archive
> > - Build the source with Maven
> > - Verified licenses
> > - Verified web PR
> >
> > On Mon, Dec 19, 2022 at 3:53 PM Dawid Wysakowicz  >
> > wrote:
> >
> > > +1 (binding)
> > >
> > >- verified signatures and checksums
> > >- built from sources
> > >- the PR looks good
> > >- the artifacts to be published look fine
> > >- checked files diff to the 1.16.0 release tag
> > >
> > > Best,
> > >
> > > Dawid
> > >
> > > On 19/12/2022 12:17, Sergey Nuyanzin wrote:
> > >
> > > +1 (non-binding)
> > >
> > > - Validated hashes and signature
> > > - Verified that no binaries exist in the source archive
> > > - Build from sources with Maven
> > > - Verified licenses
> > >
> > > one nitpick: it seems a link to the tag is broken (number 5)
> > > I guess it should be this onehttps://
> > github.com/apache/flink-connector-jdbc/releases/tag/v3.0.0-rc2
> > >
> > > Thank you Martijn
> > >
> > > On Wed, Dec 14, 2022 at 2:16 PM Martijn Visser <
> martijnvis...@apache.org>
> > 
> > > wrote:
> > >
> > >
> > > Hi everyone,
> > > Please review and vote on the release candidate #2 for the version
> 3.0.0,
> > > as follows:
> > > [ ] +1, Approve the release
> > > [ ] -1, Do not approve the release (please provide specific comments)
> > >
> > >
> > > The complete staging area is available for your review, which includes:
> > > * JIRA release notes [1],
> > > * the official Apache source release to be deployed to dist.apache.org
> > > [2],
> > > which are signed with the key with fingerprint
> > > A5F3BCE4CBE993573EC5966A65321B8382B219AF [3],
> > > * all artifacts to be deployed to the Maven Central Repository [4],
> > > * source code tag v3.0.0-rc2 [5],
> > > * website pull request listing the new release [6].
> > >
> > > The vote will be open for at least 72 hours. It is adopted by majority
> > > approval, with at least 3 PMC affirmative votes.
> > >
> > > Thanks,
> > > Release Manager
> > >
> > > [1]
> > >
> >
> https://issues.apache.org/jira/secure/ReleaseNote.jspa?projectId=12315522=12352590
> > > [2]
> >
> https://dist.apache.org/repos/dist/dev/flink/flink-connector-jdbc-3.0.0-rc2
> > > [3] https://dist.apache.org/repos/dist/release/flink/KEYS
> > > [4]
> > https://repository.apache.org/content/repositories/orgapacheflink-1565/
> > > [5] https://github.com/apache/flink-connector-
> > > /releases/tag/v3.0.0-rc2
> > > [6] https://github.com/apache/flink-web/pull/590
> > >
> > >
> >
>


Re: [VOTE] Release flink-connector-jdbc, release candidate #2

2022-12-20 Thread Danny Cranmer
Hello,

+1 (binding)

- Release notes look good
- Verified signatures and hashes
- Verified there are no binaries in the source archive
- NOTICE/Licenses look good
- Built source
- Tag exists in Github
- Contents of Maven repo look good
- Reviewed web PR

Thanks,

On Tue, Dec 20, 2022 at 12:04 PM Martijn Visser 
wrote:

> +1 (binding)
>
> - Validated hashes
> - Verified signature
> - Verified that no binaries exist in the source archive
> - Build the source with Maven
> - Verified licenses
> - Verified web PR
>
> On Mon, Dec 19, 2022 at 3:53 PM Dawid Wysakowicz 
> wrote:
>
> > +1 (binding)
> >
> >- verified signatures and checksums
> >- built from sources
> >- the PR looks good
> >- the artifacts to be published look fine
> >- checked files diff to the 1.16.0 release tag
> >
> > Best,
> >
> > Dawid
> >
> > On 19/12/2022 12:17, Sergey Nuyanzin wrote:
> >
> > +1 (non-binding)
> >
> > - Validated hashes and signature
> > - Verified that no binaries exist in the source archive
> > - Build from sources with Maven
> > - Verified licenses
> >
> > one nitpick: it seems a link to the tag is broken (number 5)
> > I guess it should be this onehttps://
> github.com/apache/flink-connector-jdbc/releases/tag/v3.0.0-rc2
> >
> > Thank you Martijn
> >
> > On Wed, Dec 14, 2022 at 2:16 PM Martijn Visser 
> 
> > wrote:
> >
> >
> > Hi everyone,
> > Please review and vote on the release candidate #2 for the version 3.0.0,
> > as follows:
> > [ ] +1, Approve the release
> > [ ] -1, Do not approve the release (please provide specific comments)
> >
> >
> > The complete staging area is available for your review, which includes:
> > * JIRA release notes [1],
> > * the official Apache source release to be deployed to dist.apache.org
> > [2],
> > which are signed with the key with fingerprint
> > A5F3BCE4CBE993573EC5966A65321B8382B219AF [3],
> > * all artifacts to be deployed to the Maven Central Repository [4],
> > * source code tag v3.0.0-rc2 [5],
> > * website pull request listing the new release [6].
> >
> > The vote will be open for at least 72 hours. It is adopted by majority
> > approval, with at least 3 PMC affirmative votes.
> >
> > Thanks,
> > Release Manager
> >
> > [1]
> >
> https://issues.apache.org/jira/secure/ReleaseNote.jspa?projectId=12315522=12352590
> > [2]
> https://dist.apache.org/repos/dist/dev/flink/flink-connector-jdbc-3.0.0-rc2
> > [3] https://dist.apache.org/repos/dist/release/flink/KEYS
> > [4]
> https://repository.apache.org/content/repositories/orgapacheflink-1565/
> > [5] https://github.com/apache/flink-connector-
> > /releases/tag/v3.0.0-rc2
> > [6] https://github.com/apache/flink-web/pull/590
> >
> >
>


Re: [VOTE] Release flink-connector-jdbc, release candidate #2

2022-12-20 Thread Martijn Visser
+1 (binding)

- Validated hashes
- Verified signature
- Verified that no binaries exist in the source archive
- Build the source with Maven
- Verified licenses
- Verified web PR

On Mon, Dec 19, 2022 at 3:53 PM Dawid Wysakowicz 
wrote:

> +1 (binding)
>
>- verified signatures and checksums
>- built from sources
>- the PR looks good
>- the artifacts to be published look fine
>- checked files diff to the 1.16.0 release tag
>
> Best,
>
> Dawid
>
> On 19/12/2022 12:17, Sergey Nuyanzin wrote:
>
> +1 (non-binding)
>
> - Validated hashes and signature
> - Verified that no binaries exist in the source archive
> - Build from sources with Maven
> - Verified licenses
>
> one nitpick: it seems a link to the tag is broken (number 5)
> I guess it should be this 
> onehttps://github.com/apache/flink-connector-jdbc/releases/tag/v3.0.0-rc2
>
> Thank you Martijn
>
> On Wed, Dec 14, 2022 at 2:16 PM Martijn Visser  
> 
> wrote:
>
>
> Hi everyone,
> Please review and vote on the release candidate #2 for the version 3.0.0,
> as follows:
> [ ] +1, Approve the release
> [ ] -1, Do not approve the release (please provide specific comments)
>
>
> The complete staging area is available for your review, which includes:
> * JIRA release notes [1],
> * the official Apache source release to be deployed to dist.apache.org
> [2],
> which are signed with the key with fingerprint
> A5F3BCE4CBE993573EC5966A65321B8382B219AF [3],
> * all artifacts to be deployed to the Maven Central Repository [4],
> * source code tag v3.0.0-rc2 [5],
> * website pull request listing the new release [6].
>
> The vote will be open for at least 72 hours. It is adopted by majority
> approval, with at least 3 PMC affirmative votes.
>
> Thanks,
> Release Manager
>
> [1]
> https://issues.apache.org/jira/secure/ReleaseNote.jspa?projectId=12315522=12352590
> [2]https://dist.apache.org/repos/dist/dev/flink/flink-connector-jdbc-3.0.0-rc2
> [3] https://dist.apache.org/repos/dist/release/flink/KEYS
> [4]https://repository.apache.org/content/repositories/orgapacheflink-1565/
> [5] https://github.com/apache/flink-connector-
> /releases/tag/v3.0.0-rc2
> [6] https://github.com/apache/flink-web/pull/590
>
>


Re: [VOTE] Release flink-connector-jdbc, release candidate #2

2022-12-19 Thread Dawid Wysakowicz

+1 (binding)

 * verified signatures and checksums
 * built from sources
 * the PR looks good
 * the artifacts to be published look fine
 * checked files diff to the 1.16.0 release tag

Best,

Dawid

On 19/12/2022 12:17, Sergey Nuyanzin wrote:

+1 (non-binding)

- Validated hashes and signature
- Verified that no binaries exist in the source archive
- Build from sources with Maven
- Verified licenses

one nitpick: it seems a link to the tag is broken (number 5)
I guess it should be this one
https://github.com/apache/flink-connector-jdbc/releases/tag/v3.0.0-rc2

Thank you Martijn

On Wed, Dec 14, 2022 at 2:16 PM Martijn Visser
wrote:


Hi everyone,
Please review and vote on the release candidate #2 for the version 3.0.0,
as follows:
[ ] +1, Approve the release
[ ] -1, Do not approve the release (please provide specific comments)


The complete staging area is available for your review, which includes:
* JIRA release notes [1],
* the official Apache source release to be deployed to dist.apache.org
[2],
which are signed with the key with fingerprint
A5F3BCE4CBE993573EC5966A65321B8382B219AF [3],
* all artifacts to be deployed to the Maven Central Repository [4],
* source code tag v3.0.0-rc2 [5],
* website pull request listing the new release [6].

The vote will be open for at least 72 hours. It is adopted by majority
approval, with at least 3 PMC affirmative votes.

Thanks,
Release Manager

[1]

https://issues.apache.org/jira/secure/ReleaseNote.jspa?projectId=12315522=12352590
[2]
https://dist.apache.org/repos/dist/dev/flink/flink-connector-jdbc-3.0.0-rc2
[3]https://dist.apache.org/repos/dist/release/flink/KEYS
[4]
https://repository.apache.org/content/repositories/orgapacheflink-1565/
[5]https://github.com/apache/flink-connector-
/releases/tag/v3.0.0-rc2
[6]https://github.com/apache/flink-web/pull/590





OpenPGP_0x31D2DD10BFC15A2D.asc
Description: OpenPGP public key


OpenPGP_signature
Description: OpenPGP digital signature


Re: [VOTE] Release flink-connector-jdbc, release candidate #2

2022-12-19 Thread Sergey Nuyanzin
+1 (non-binding)

- Validated hashes and signature
- Verified that no binaries exist in the source archive
- Build from sources with Maven
- Verified licenses

one nitpick: it seems a link to the tag is broken (number 5)
I guess it should be this one
https://github.com/apache/flink-connector-jdbc/releases/tag/v3.0.0-rc2

Thank you Martijn

On Wed, Dec 14, 2022 at 2:16 PM Martijn Visser 
wrote:

> Hi everyone,
> Please review and vote on the release candidate #2 for the version 3.0.0,
> as follows:
> [ ] +1, Approve the release
> [ ] -1, Do not approve the release (please provide specific comments)
>
>
> The complete staging area is available for your review, which includes:
> * JIRA release notes [1],
> * the official Apache source release to be deployed to dist.apache.org
> [2],
> which are signed with the key with fingerprint
> A5F3BCE4CBE993573EC5966A65321B8382B219AF [3],
> * all artifacts to be deployed to the Maven Central Repository [4],
> * source code tag v3.0.0-rc2 [5],
> * website pull request listing the new release [6].
>
> The vote will be open for at least 72 hours. It is adopted by majority
> approval, with at least 3 PMC affirmative votes.
>
> Thanks,
> Release Manager
>
> [1]
>
> https://issues.apache.org/jira/secure/ReleaseNote.jspa?projectId=12315522=12352590
> [2]
> https://dist.apache.org/repos/dist/dev/flink/flink-connector-jdbc-3.0.0-rc2
> [3] https://dist.apache.org/repos/dist/release/flink/KEYS
> [4]
> https://repository.apache.org/content/repositories/orgapacheflink-1565/
> [5] https://github.com/apache/flink-connector-
> /releases/tag/v3.0.0-rc2
> [6] https://github.com/apache/flink-web/pull/590
>


-- 
Best regards,
Sergey


[VOTE] Release flink-connector-jdbc, release candidate #2

2022-12-14 Thread Martijn Visser
Hi everyone,
Please review and vote on the release candidate #2 for the version 3.0.0,
as follows:
[ ] +1, Approve the release
[ ] -1, Do not approve the release (please provide specific comments)


The complete staging area is available for your review, which includes:
* JIRA release notes [1],
* the official Apache source release to be deployed to dist.apache.org [2],
which are signed with the key with fingerprint
A5F3BCE4CBE993573EC5966A65321B8382B219AF [3],
* all artifacts to be deployed to the Maven Central Repository [4],
* source code tag v3.0.0-rc2 [5],
* website pull request listing the new release [6].

The vote will be open for at least 72 hours. It is adopted by majority
approval, with at least 3 PMC affirmative votes.

Thanks,
Release Manager

[1]
https://issues.apache.org/jira/secure/ReleaseNote.jspa?projectId=12315522=12352590
[2]
https://dist.apache.org/repos/dist/dev/flink/flink-connector-jdbc-3.0.0-rc2
[3] https://dist.apache.org/repos/dist/release/flink/KEYS
[4] https://repository.apache.org/content/repositories/orgapacheflink-1565/
[5] https://github.com/apache/flink-connector-
/releases/tag/v3.0.0-rc2
[6] https://github.com/apache/flink-web/pull/590