Re: [VOTE] Release flink-connector-jdbc v3.1.1, release candidate #1

2023-06-15 Thread Martijn Visser
Hi all,

Apologies for the long delay on this one, but with the help of Sergey
Nuyanzin and Joao Boto we managed to resolve this issue. To summarize:

1. The vote for this connector is cancelled, due to
https://issues.apache.org/jira/browse/FLINK-31770
2. That Jira ticket has now been resolved
3. When doing testing, we noticed flaky results and filed
https://issues.apache.org/jira/browse/FLINK-32325. It seems that Surefire
forks and MSSQL server images are not fans of each other, but we mitigated
the issue by setting the forkCount to 1. For a permanent solution we have
https://issues.apache.org/jira/browse/FLINK-32342 to track.

I'll create a new JDBC 3.1.1 release candidate.

Best regards,

Martijn

On Tue, Jun 6, 2023 at 11:37 AM Chesnay Schepler  wrote:

> I'm a bit concerned that the last 4 CI runs haven't succeeded in the 3.1
> branch.
>
> Has anyone looked into the failing oracle test (both 1.17/1.18)?
>
> https://github.com/apache/flink-connector-jdbc/actions/runs/5058372107/jobs/9078398092
>
> Why is a vote being opened when there's still a blocker ticket for this
> very test failure? (FLINK-31770)
>
> How can it be that CI is broken for 2 months and no one notices?
>
> On 24/05/2023 20:54, Martijn Visser wrote:
> > Hi everyone,
> > Please review and vote on the release candidate #1 for the version 3.1.1,
> > as follows:
> > [ ] +1, Approve the release
> > [ ] -1, Do not approve the release (please provide specific comments)
> >
> >
> > The complete staging area is available for your review, which includes:
> > * JIRA release notes [1],
> > * the official Apache source release to be deployed to dist.apache.org
> [2],
> > which are signed with the key with fingerprint
> > A5F3BCE4CBE993573EC5966A65321B8382B219AF [3],
> > * all artifacts to be deployed to the Maven Central Repository [4],
> > * source code tag v3.1.1-rc1 [5],
> > * website pull request listing the new release [6].
> >
> > The vote will be open for at least 72 hours. It is adopted by majority
> > approval, with at least 3 PMC affirmative votes.
> >
> > Thanks,
> > Release Manager
> >
> > [1]
> >
> https://issues.apache.org/jira/secure/ReleaseNote.jspa?projectId=12315522=12353281
> > [2]
> >
> https://dist.apache.org/repos/dist/dev/flink/flink-connector-jdbc-3.1.1-rc1
> > [3] https://dist.apache.org/repos/dist/release/flink/KEYS
> > [4]
> https://repository.apache.org/content/repositories/orgapacheflink-1636/
> > [5]
> https://github.com/apache/flink-connector-jdbc/releases/tag/v3.1.1-rc1
> > [6] https://github.com/apache/flink-web/pull/654
> >
>
>


Re: [VOTE] Release flink-connector-jdbc v3.1.1, release candidate #1

2023-06-06 Thread Chesnay Schepler
I'm a bit concerned that the last 4 CI runs haven't succeeded in the 3.1 
branch.


Has anyone looked into the failing oracle test (both 1.17/1.18)?
https://github.com/apache/flink-connector-jdbc/actions/runs/5058372107/jobs/9078398092

Why is a vote being opened when there's still a blocker ticket for this 
very test failure? (FLINK-31770)


How can it be that CI is broken for 2 months and no one notices?

On 24/05/2023 20:54, Martijn Visser wrote:

Hi everyone,
Please review and vote on the release candidate #1 for the version 3.1.1,
as follows:
[ ] +1, Approve the release
[ ] -1, Do not approve the release (please provide specific comments)


The complete staging area is available for your review, which includes:
* JIRA release notes [1],
* the official Apache source release to be deployed to dist.apache.org [2],
which are signed with the key with fingerprint
A5F3BCE4CBE993573EC5966A65321B8382B219AF [3],
* all artifacts to be deployed to the Maven Central Repository [4],
* source code tag v3.1.1-rc1 [5],
* website pull request listing the new release [6].

The vote will be open for at least 72 hours. It is adopted by majority
approval, with at least 3 PMC affirmative votes.

Thanks,
Release Manager

[1]
https://issues.apache.org/jira/secure/ReleaseNote.jspa?projectId=12315522=12353281
[2]
https://dist.apache.org/repos/dist/dev/flink/flink-connector-jdbc-3.1.1-rc1
[3] https://dist.apache.org/repos/dist/release/flink/KEYS
[4] https://repository.apache.org/content/repositories/orgapacheflink-1636/
[5] https://github.com/apache/flink-connector-jdbc/releases/tag/v3.1.1-rc1
[6] https://github.com/apache/flink-web/pull/654





Re: [VOTE] Release flink-connector-jdbc v3.1.1, release candidate #1

2023-06-01 Thread Sergey Nuyanzin
+1 (non-binding)

* built from source
* verified signatures and hashsums
* checked release notes
* reviewed web PR

thanks for driving this

On Thu, Jun 1, 2023 at 8:15 PM Ahmed Hamdy  wrote:

> Hi Martijn,
>
> +1 (non-binding)
>
> - built from source code succeeded
> - verified signatures match yours
> - verified hashsums
> - checked release notes
> - reviewed the web PR
>
> Best regards,
> Ahmed Hamdy
>
> On Wed, 31 May 2023 at 09:33, Leonard Xu  wrote:
>
> > +1 (binding)
> >
> > - built from source code succeeded
> > - verified signatures
> > - verified hashsums
> > - checked Github release tag, left one minor comment about the release
> > commit
> > - checked release notes
> > - checked the contents contains jar and pom files in apache repo
> > - reviewed the web PR
> >
> > Best,
> > Leonard
> >
> >
> > > On May 30, 2023, at 1:56 PM, Yuxin Tan  wrote:
> > >
> > > +1 (non-binding)
> > >
> > > - Checked sign
> > > - Checked the hash
> > > - Checked tag
> > > - Build from source
> > >
> > > Best,
> > > Yuxin
> > >
> > >
> > > weijie guo  于2023年5月29日周一 14:14写道:
> > >
> > >> +1 (non-binding)
> > >>
> > >> - checked sign and checksum
> > >> - checked tag in github repository
> > >> - compiled from source
> > >> - checked the web PR
> > >>
> > >> BTW, please remember to update docs/jdbc.yaml for the v3.1 branch
> after
> > the
> > >> release is completed.
> > >>
> > >> Best regards,
> > >>
> > >> Weijie
> > >>
> > >>
> > >> Jing Ge  于2023年5月29日周一 04:26写道:
> > >>
> > >>> +1 (non-binding)
> > >>>
> > >>> - checked sign
> > >>> - checked hash
> > >>> - checked repos
> > >>> - checked tag
> > >>> - compiled from source
> > >>> - check the web PR
> > >>>
> > >>> Best regards,
> > >>> Jing
> > >>>
> > >>>
> > >>> On Sun, May 28, 2023 at 4:00 PM Benchao Li 
> > wrote:
> > >>>
> >  Thanks Martijn,
> > 
> >  - checked signature/checksum [OK]
> >  - downloaded src, compiled from source [OK]
> >  - diffed src and tag, no binary files [OK]
> >  - gone through nexus staging area, looks good [OK]
> >  - run with flink 1.7.1 [OK]
> > 
> >  One thing I spotted is that the version in `docs/data/jdbc.yml` is
> > >> still
> >  3.1.0, I'm not sure whether this should be a blocker.
> > 
> > 
> >  Martijn Visser  于2023年5月25日周四 02:55写道:
> > 
> > > Hi everyone,
> > > Please review and vote on the release candidate #1 for the version
> > >>> 3.1.1,
> > > as follows:
> > > [ ] +1, Approve the release
> > > [ ] -1, Do not approve the release (please provide specific
> comments)
> > >
> > >
> > > The complete staging area is available for your review, which
> > >> includes:
> > > * JIRA release notes [1],
> > > * the official Apache source release to be deployed to
> > >> dist.apache.org
> > > [2],
> > > which are signed with the key with fingerprint
> > > A5F3BCE4CBE993573EC5966A65321B8382B219AF [3],
> > > * all artifacts to be deployed to the Maven Central Repository [4],
> > > * source code tag v3.1.1-rc1 [5],
> > > * website pull request listing the new release [6].
> > >
> > > The vote will be open for at least 72 hours. It is adopted by
> > >> majority
> > > approval, with at least 3 PMC affirmative votes.
> > >
> > > Thanks,
> > > Release Manager
> > >
> > > [1]
> > >
> > >
> > 
> > >>>
> > >>
> >
> https://issues.apache.org/jira/secure/ReleaseNote.jspa?projectId=12315522=12353281
> > > [2]
> > >
> > 
> > >>>
> > >>
> >
> https://dist.apache.org/repos/dist/dev/flink/flink-connector-jdbc-3.1.1-rc1
> > > [3] https://dist.apache.org/repos/dist/release/flink/KEYS
> > > [4]
> > >
> > >>>
> > https://repository.apache.org/content/repositories/orgapacheflink-1636/
> > > [5]
> > 
> > https://github.com/apache/flink-connector-jdbc/releases/tag/v3.1.1-rc1
> > > [6] https://github.com/apache/flink-web/pull/654
> > >
> > 
> > 
> >  --
> > 
> >  Best,
> >  Benchao Li
> > 
> > >>>
> > >>
> >
> >
>


-- 
Best regards,
Sergey


Re: [VOTE] Release flink-connector-jdbc v3.1.1, release candidate #1

2023-06-01 Thread Ahmed Hamdy
Hi Martijn,

+1 (non-binding)

- built from source code succeeded
- verified signatures match yours
- verified hashsums
- checked release notes
- reviewed the web PR

Best regards,
Ahmed Hamdy

On Wed, 31 May 2023 at 09:33, Leonard Xu  wrote:

> +1 (binding)
>
> - built from source code succeeded
> - verified signatures
> - verified hashsums
> - checked Github release tag, left one minor comment about the release
> commit
> - checked release notes
> - checked the contents contains jar and pom files in apache repo
> - reviewed the web PR
>
> Best,
> Leonard
>
>
> > On May 30, 2023, at 1:56 PM, Yuxin Tan  wrote:
> >
> > +1 (non-binding)
> >
> > - Checked sign
> > - Checked the hash
> > - Checked tag
> > - Build from source
> >
> > Best,
> > Yuxin
> >
> >
> > weijie guo  于2023年5月29日周一 14:14写道:
> >
> >> +1 (non-binding)
> >>
> >> - checked sign and checksum
> >> - checked tag in github repository
> >> - compiled from source
> >> - checked the web PR
> >>
> >> BTW, please remember to update docs/jdbc.yaml for the v3.1 branch after
> the
> >> release is completed.
> >>
> >> Best regards,
> >>
> >> Weijie
> >>
> >>
> >> Jing Ge  于2023年5月29日周一 04:26写道:
> >>
> >>> +1 (non-binding)
> >>>
> >>> - checked sign
> >>> - checked hash
> >>> - checked repos
> >>> - checked tag
> >>> - compiled from source
> >>> - check the web PR
> >>>
> >>> Best regards,
> >>> Jing
> >>>
> >>>
> >>> On Sun, May 28, 2023 at 4:00 PM Benchao Li 
> wrote:
> >>>
>  Thanks Martijn,
> 
>  - checked signature/checksum [OK]
>  - downloaded src, compiled from source [OK]
>  - diffed src and tag, no binary files [OK]
>  - gone through nexus staging area, looks good [OK]
>  - run with flink 1.7.1 [OK]
> 
>  One thing I spotted is that the version in `docs/data/jdbc.yml` is
> >> still
>  3.1.0, I'm not sure whether this should be a blocker.
> 
> 
>  Martijn Visser  于2023年5月25日周四 02:55写道:
> 
> > Hi everyone,
> > Please review and vote on the release candidate #1 for the version
> >>> 3.1.1,
> > as follows:
> > [ ] +1, Approve the release
> > [ ] -1, Do not approve the release (please provide specific comments)
> >
> >
> > The complete staging area is available for your review, which
> >> includes:
> > * JIRA release notes [1],
> > * the official Apache source release to be deployed to
> >> dist.apache.org
> > [2],
> > which are signed with the key with fingerprint
> > A5F3BCE4CBE993573EC5966A65321B8382B219AF [3],
> > * all artifacts to be deployed to the Maven Central Repository [4],
> > * source code tag v3.1.1-rc1 [5],
> > * website pull request listing the new release [6].
> >
> > The vote will be open for at least 72 hours. It is adopted by
> >> majority
> > approval, with at least 3 PMC affirmative votes.
> >
> > Thanks,
> > Release Manager
> >
> > [1]
> >
> >
> 
> >>>
> >>
> https://issues.apache.org/jira/secure/ReleaseNote.jspa?projectId=12315522=12353281
> > [2]
> >
> 
> >>>
> >>
> https://dist.apache.org/repos/dist/dev/flink/flink-connector-jdbc-3.1.1-rc1
> > [3] https://dist.apache.org/repos/dist/release/flink/KEYS
> > [4]
> >
> >>>
> https://repository.apache.org/content/repositories/orgapacheflink-1636/
> > [5]
> 
> https://github.com/apache/flink-connector-jdbc/releases/tag/v3.1.1-rc1
> > [6] https://github.com/apache/flink-web/pull/654
> >
> 
> 
>  --
> 
>  Best,
>  Benchao Li
> 
> >>>
> >>
>
>


Re: [VOTE] Release flink-connector-jdbc v3.1.1, release candidate #1

2023-05-31 Thread Leonard Xu
+1 (binding)

- built from source code succeeded
- verified signatures
- verified hashsums 
- checked Github release tag, left one minor comment about the release commit
- checked release notes
- checked the contents contains jar and pom files in apache repo 
- reviewed the web PR 

Best,
Leonard


> On May 30, 2023, at 1:56 PM, Yuxin Tan  wrote:
> 
> +1 (non-binding)
> 
> - Checked sign
> - Checked the hash
> - Checked tag
> - Build from source
> 
> Best,
> Yuxin
> 
> 
> weijie guo  于2023年5月29日周一 14:14写道:
> 
>> +1 (non-binding)
>> 
>> - checked sign and checksum
>> - checked tag in github repository
>> - compiled from source
>> - checked the web PR
>> 
>> BTW, please remember to update docs/jdbc.yaml for the v3.1 branch after the
>> release is completed.
>> 
>> Best regards,
>> 
>> Weijie
>> 
>> 
>> Jing Ge  于2023年5月29日周一 04:26写道:
>> 
>>> +1 (non-binding)
>>> 
>>> - checked sign
>>> - checked hash
>>> - checked repos
>>> - checked tag
>>> - compiled from source
>>> - check the web PR
>>> 
>>> Best regards,
>>> Jing
>>> 
>>> 
>>> On Sun, May 28, 2023 at 4:00 PM Benchao Li  wrote:
>>> 
 Thanks Martijn,
 
 - checked signature/checksum [OK]
 - downloaded src, compiled from source [OK]
 - diffed src and tag, no binary files [OK]
 - gone through nexus staging area, looks good [OK]
 - run with flink 1.7.1 [OK]
 
 One thing I spotted is that the version in `docs/data/jdbc.yml` is
>> still
 3.1.0, I'm not sure whether this should be a blocker.
 
 
 Martijn Visser  于2023年5月25日周四 02:55写道:
 
> Hi everyone,
> Please review and vote on the release candidate #1 for the version
>>> 3.1.1,
> as follows:
> [ ] +1, Approve the release
> [ ] -1, Do not approve the release (please provide specific comments)
> 
> 
> The complete staging area is available for your review, which
>> includes:
> * JIRA release notes [1],
> * the official Apache source release to be deployed to
>> dist.apache.org
> [2],
> which are signed with the key with fingerprint
> A5F3BCE4CBE993573EC5966A65321B8382B219AF [3],
> * all artifacts to be deployed to the Maven Central Repository [4],
> * source code tag v3.1.1-rc1 [5],
> * website pull request listing the new release [6].
> 
> The vote will be open for at least 72 hours. It is adopted by
>> majority
> approval, with at least 3 PMC affirmative votes.
> 
> Thanks,
> Release Manager
> 
> [1]
> 
> 
 
>>> 
>> https://issues.apache.org/jira/secure/ReleaseNote.jspa?projectId=12315522=12353281
> [2]
> 
 
>>> 
>> https://dist.apache.org/repos/dist/dev/flink/flink-connector-jdbc-3.1.1-rc1
> [3] https://dist.apache.org/repos/dist/release/flink/KEYS
> [4]
> 
>>> https://repository.apache.org/content/repositories/orgapacheflink-1636/
> [5]
 https://github.com/apache/flink-connector-jdbc/releases/tag/v3.1.1-rc1
> [6] https://github.com/apache/flink-web/pull/654
> 
 
 
 --
 
 Best,
 Benchao Li
 
>>> 
>> 



Re: [VOTE] Release flink-connector-jdbc v3.1.1, release candidate #1

2023-05-29 Thread Yuxin Tan
+1 (non-binding)

- Checked sign
- Checked the hash
- Checked tag
- Build from source

Best,
Yuxin


weijie guo  于2023年5月29日周一 14:14写道:

> +1 (non-binding)
>
> - checked sign and checksum
> - checked tag in github repository
> - compiled from source
> - checked the web PR
>
> BTW, please remember to update docs/jdbc.yaml for the v3.1 branch after the
> release is completed.
>
> Best regards,
>
> Weijie
>
>
> Jing Ge  于2023年5月29日周一 04:26写道:
>
> > +1 (non-binding)
> >
> > - checked sign
> > - checked hash
> > - checked repos
> > - checked tag
> > - compiled from source
> > - check the web PR
> >
> > Best regards,
> > Jing
> >
> >
> > On Sun, May 28, 2023 at 4:00 PM Benchao Li  wrote:
> >
> > > Thanks Martijn,
> > >
> > > - checked signature/checksum [OK]
> > > - downloaded src, compiled from source [OK]
> > > - diffed src and tag, no binary files [OK]
> > > - gone through nexus staging area, looks good [OK]
> > > - run with flink 1.7.1 [OK]
> > >
> > > One thing I spotted is that the version in `docs/data/jdbc.yml` is
> still
> > > 3.1.0, I'm not sure whether this should be a blocker.
> > >
> > >
> > > Martijn Visser  于2023年5月25日周四 02:55写道:
> > >
> > > > Hi everyone,
> > > > Please review and vote on the release candidate #1 for the version
> > 3.1.1,
> > > > as follows:
> > > > [ ] +1, Approve the release
> > > > [ ] -1, Do not approve the release (please provide specific comments)
> > > >
> > > >
> > > > The complete staging area is available for your review, which
> includes:
> > > > * JIRA release notes [1],
> > > > * the official Apache source release to be deployed to
> dist.apache.org
> > > > [2],
> > > > which are signed with the key with fingerprint
> > > > A5F3BCE4CBE993573EC5966A65321B8382B219AF [3],
> > > > * all artifacts to be deployed to the Maven Central Repository [4],
> > > > * source code tag v3.1.1-rc1 [5],
> > > > * website pull request listing the new release [6].
> > > >
> > > > The vote will be open for at least 72 hours. It is adopted by
> majority
> > > > approval, with at least 3 PMC affirmative votes.
> > > >
> > > > Thanks,
> > > > Release Manager
> > > >
> > > > [1]
> > > >
> > > >
> > >
> >
> https://issues.apache.org/jira/secure/ReleaseNote.jspa?projectId=12315522=12353281
> > > > [2]
> > > >
> > >
> >
> https://dist.apache.org/repos/dist/dev/flink/flink-connector-jdbc-3.1.1-rc1
> > > > [3] https://dist.apache.org/repos/dist/release/flink/KEYS
> > > > [4]
> > > >
> > https://repository.apache.org/content/repositories/orgapacheflink-1636/
> > > > [5]
> > > https://github.com/apache/flink-connector-jdbc/releases/tag/v3.1.1-rc1
> > > > [6] https://github.com/apache/flink-web/pull/654
> > > >
> > >
> > >
> > > --
> > >
> > > Best,
> > > Benchao Li
> > >
> >
>


Re: [VOTE] Release flink-connector-jdbc v3.1.1, release candidate #1

2023-05-29 Thread weijie guo
+1 (non-binding)

- checked sign and checksum
- checked tag in github repository
- compiled from source
- checked the web PR

BTW, please remember to update docs/jdbc.yaml for the v3.1 branch after the
release is completed.

Best regards,

Weijie


Jing Ge  于2023年5月29日周一 04:26写道:

> +1 (non-binding)
>
> - checked sign
> - checked hash
> - checked repos
> - checked tag
> - compiled from source
> - check the web PR
>
> Best regards,
> Jing
>
>
> On Sun, May 28, 2023 at 4:00 PM Benchao Li  wrote:
>
> > Thanks Martijn,
> >
> > - checked signature/checksum [OK]
> > - downloaded src, compiled from source [OK]
> > - diffed src and tag, no binary files [OK]
> > - gone through nexus staging area, looks good [OK]
> > - run with flink 1.7.1 [OK]
> >
> > One thing I spotted is that the version in `docs/data/jdbc.yml` is still
> > 3.1.0, I'm not sure whether this should be a blocker.
> >
> >
> > Martijn Visser  于2023年5月25日周四 02:55写道:
> >
> > > Hi everyone,
> > > Please review and vote on the release candidate #1 for the version
> 3.1.1,
> > > as follows:
> > > [ ] +1, Approve the release
> > > [ ] -1, Do not approve the release (please provide specific comments)
> > >
> > >
> > > The complete staging area is available for your review, which includes:
> > > * JIRA release notes [1],
> > > * the official Apache source release to be deployed to dist.apache.org
> > > [2],
> > > which are signed with the key with fingerprint
> > > A5F3BCE4CBE993573EC5966A65321B8382B219AF [3],
> > > * all artifacts to be deployed to the Maven Central Repository [4],
> > > * source code tag v3.1.1-rc1 [5],
> > > * website pull request listing the new release [6].
> > >
> > > The vote will be open for at least 72 hours. It is adopted by majority
> > > approval, with at least 3 PMC affirmative votes.
> > >
> > > Thanks,
> > > Release Manager
> > >
> > > [1]
> > >
> > >
> >
> https://issues.apache.org/jira/secure/ReleaseNote.jspa?projectId=12315522=12353281
> > > [2]
> > >
> >
> https://dist.apache.org/repos/dist/dev/flink/flink-connector-jdbc-3.1.1-rc1
> > > [3] https://dist.apache.org/repos/dist/release/flink/KEYS
> > > [4]
> > >
> https://repository.apache.org/content/repositories/orgapacheflink-1636/
> > > [5]
> > https://github.com/apache/flink-connector-jdbc/releases/tag/v3.1.1-rc1
> > > [6] https://github.com/apache/flink-web/pull/654
> > >
> >
> >
> > --
> >
> > Best,
> > Benchao Li
> >
>


Re: [VOTE] Release flink-connector-jdbc v3.1.1, release candidate #1

2023-05-28 Thread Jing Ge
+1 (non-binding)

- checked sign
- checked hash
- checked repos
- checked tag
- compiled from source
- check the web PR

Best regards,
Jing


On Sun, May 28, 2023 at 4:00 PM Benchao Li  wrote:

> Thanks Martijn,
>
> - checked signature/checksum [OK]
> - downloaded src, compiled from source [OK]
> - diffed src and tag, no binary files [OK]
> - gone through nexus staging area, looks good [OK]
> - run with flink 1.7.1 [OK]
>
> One thing I spotted is that the version in `docs/data/jdbc.yml` is still
> 3.1.0, I'm not sure whether this should be a blocker.
>
>
> Martijn Visser  于2023年5月25日周四 02:55写道:
>
> > Hi everyone,
> > Please review and vote on the release candidate #1 for the version 3.1.1,
> > as follows:
> > [ ] +1, Approve the release
> > [ ] -1, Do not approve the release (please provide specific comments)
> >
> >
> > The complete staging area is available for your review, which includes:
> > * JIRA release notes [1],
> > * the official Apache source release to be deployed to dist.apache.org
> > [2],
> > which are signed with the key with fingerprint
> > A5F3BCE4CBE993573EC5966A65321B8382B219AF [3],
> > * all artifacts to be deployed to the Maven Central Repository [4],
> > * source code tag v3.1.1-rc1 [5],
> > * website pull request listing the new release [6].
> >
> > The vote will be open for at least 72 hours. It is adopted by majority
> > approval, with at least 3 PMC affirmative votes.
> >
> > Thanks,
> > Release Manager
> >
> > [1]
> >
> >
> https://issues.apache.org/jira/secure/ReleaseNote.jspa?projectId=12315522=12353281
> > [2]
> >
> https://dist.apache.org/repos/dist/dev/flink/flink-connector-jdbc-3.1.1-rc1
> > [3] https://dist.apache.org/repos/dist/release/flink/KEYS
> > [4]
> > https://repository.apache.org/content/repositories/orgapacheflink-1636/
> > [5]
> https://github.com/apache/flink-connector-jdbc/releases/tag/v3.1.1-rc1
> > [6] https://github.com/apache/flink-web/pull/654
> >
>
>
> --
>
> Best,
> Benchao Li
>


Re: [VOTE] Release flink-connector-jdbc v3.1.1, release candidate #1

2023-05-28 Thread Benchao Li
Thanks Martijn,

- checked signature/checksum [OK]
- downloaded src, compiled from source [OK]
- diffed src and tag, no binary files [OK]
- gone through nexus staging area, looks good [OK]
- run with flink 1.7.1 [OK]

One thing I spotted is that the version in `docs/data/jdbc.yml` is still
3.1.0, I'm not sure whether this should be a blocker.


Martijn Visser  于2023年5月25日周四 02:55写道:

> Hi everyone,
> Please review and vote on the release candidate #1 for the version 3.1.1,
> as follows:
> [ ] +1, Approve the release
> [ ] -1, Do not approve the release (please provide specific comments)
>
>
> The complete staging area is available for your review, which includes:
> * JIRA release notes [1],
> * the official Apache source release to be deployed to dist.apache.org
> [2],
> which are signed with the key with fingerprint
> A5F3BCE4CBE993573EC5966A65321B8382B219AF [3],
> * all artifacts to be deployed to the Maven Central Repository [4],
> * source code tag v3.1.1-rc1 [5],
> * website pull request listing the new release [6].
>
> The vote will be open for at least 72 hours. It is adopted by majority
> approval, with at least 3 PMC affirmative votes.
>
> Thanks,
> Release Manager
>
> [1]
>
> https://issues.apache.org/jira/secure/ReleaseNote.jspa?projectId=12315522=12353281
> [2]
> https://dist.apache.org/repos/dist/dev/flink/flink-connector-jdbc-3.1.1-rc1
> [3] https://dist.apache.org/repos/dist/release/flink/KEYS
> [4]
> https://repository.apache.org/content/repositories/orgapacheflink-1636/
> [5] https://github.com/apache/flink-connector-jdbc/releases/tag/v3.1.1-rc1
> [6] https://github.com/apache/flink-web/pull/654
>


-- 

Best,
Benchao Li


[VOTE] Release flink-connector-jdbc v3.1.1, release candidate #1

2023-05-24 Thread Martijn Visser
Hi everyone,
Please review and vote on the release candidate #1 for the version 3.1.1,
as follows:
[ ] +1, Approve the release
[ ] -1, Do not approve the release (please provide specific comments)


The complete staging area is available for your review, which includes:
* JIRA release notes [1],
* the official Apache source release to be deployed to dist.apache.org [2],
which are signed with the key with fingerprint
A5F3BCE4CBE993573EC5966A65321B8382B219AF [3],
* all artifacts to be deployed to the Maven Central Repository [4],
* source code tag v3.1.1-rc1 [5],
* website pull request listing the new release [6].

The vote will be open for at least 72 hours. It is adopted by majority
approval, with at least 3 PMC affirmative votes.

Thanks,
Release Manager

[1]
https://issues.apache.org/jira/secure/ReleaseNote.jspa?projectId=12315522=12353281
[2]
https://dist.apache.org/repos/dist/dev/flink/flink-connector-jdbc-3.1.1-rc1
[3] https://dist.apache.org/repos/dist/release/flink/KEYS
[4] https://repository.apache.org/content/repositories/orgapacheflink-1636/
[5] https://github.com/apache/flink-connector-jdbc/releases/tag/v3.1.1-rc1
[6] https://github.com/apache/flink-web/pull/654