Re: [VOTE] Release flink-connector-jdbc v3.2.0, release candidate #2

2024-06-07 Thread Danny Cranmer
Thanks all. This vote is now closed, I will announce the results in a
separate thread.


On Fri, Jun 7, 2024 at 4:59 AM weijie guo  wrote:

> Thanks Danny!
>
> +1(binding)
> - Verified signatures and hash sums
> - Checked the CI build
> - Checked the release note
> - Reviewed the flink-web PR
> - Build from source.
>
> Best regards,
>
> Weijie
>
>
> Rui Fan <1996fan...@gmail.com> 于2024年6月7日周五 11:08写道:
>
> > Thanks Danny for the hard work!
> >
> > +1(binding)
> >
> > - Verified signatures
> > - Verified sha512 (hashsums)
> > - The source archives do not contain any binaries
> > - Build the source with Maven 3 and java8 (Checked the license as well)
> > - Checked Github release tag
> > - Reviewed the flink-web PR
> >
> > Best,
> > Rui
> >
> > On Tue, Jun 4, 2024 at 1:31 PM gongzhongqiang  >
> > wrote:
> >
> > > +1 (non-binding)
> > >
> > > - Validated checksum hash and signature.
> > > - Confirmed that no binaries exist in the source archive.
> > > - Built the source with JDK 8.
> > > - Verified the web PR.
> > > - Ensured the JAR is built by JDK 8.
> > >
> > > Best,
> > > Zhongqiang Gong
> > >
> > > Danny Cranmer  于2024年4月18日周四 18:20写道:
> > >
> > > > Hi everyone,
> > > >
> > > > Please review and vote on the release candidate #1 for the version
> > 3.2.0,
> > > > as follows:
> > > > [ ] +1, Approve the release
> > > > [ ] -1, Do not approve the release (please provide specific comments)
> > > >
> > > > This release supports Flink 1.18 and 1.19.
> > > >
> > > > The complete staging area is available for your review, which
> includes:
> > > > * JIRA release notes [1],
> > > > * the official Apache source release to be deployed to
> dist.apache.org
> > > > [2],
> > > > which are signed with the key with fingerprint 125FD8DB [3],
> > > > * all artifacts to be deployed to the Maven Central Repository [4],
> > > > * source code tag v3.2.0-rc1 [5],
> > > > * website pull request listing the new release [6].
> > > > * CI run of tag [7].
> > > >
> > > > The vote will be open for at least 72 hours. It is adopted by
> majority
> > > > approval, with at least 3 PMC affirmative votes.
> > > >
> > > > Thanks,
> > > > Danny
> > > >
> > > > [1]
> > > >
> > > >
> > >
> >
> https://issues.apache.org/jira/secure/ReleaseNote.jspa?projectId=12315522=12353143
> > > > [2]
> > > >
> > >
> >
> https://dist.apache.org/repos/dist/dev/flink/flink-connector-jdbc-3.2.0-rc2
> > > > [3] https://dist.apache.org/repos/dist/release/flink/KEYS
> > > > [4]
> > > >
> > https://repository.apache.org/content/repositories/orgapacheflink-1718/
> > > > [5]
> > > https://github.com/apache/flink-connector-jdbc/releases/tag/v3.2.0-rc2
> > > > [6] https://github.com/apache/flink-web/pull/734
> > > > [7]
> > > https://github.com/apache/flink-connector-jdbc/actions/runs/8736019099
> > > >
> > >
> >
>


Re: [VOTE] Release flink-connector-jdbc v3.2.0, release candidate #2

2024-06-06 Thread weijie guo
Thanks Danny!

+1(binding)
- Verified signatures and hash sums
- Checked the CI build
- Checked the release note
- Reviewed the flink-web PR
- Build from source.

Best regards,

Weijie


Rui Fan <1996fan...@gmail.com> 于2024年6月7日周五 11:08写道:

> Thanks Danny for the hard work!
>
> +1(binding)
>
> - Verified signatures
> - Verified sha512 (hashsums)
> - The source archives do not contain any binaries
> - Build the source with Maven 3 and java8 (Checked the license as well)
> - Checked Github release tag
> - Reviewed the flink-web PR
>
> Best,
> Rui
>
> On Tue, Jun 4, 2024 at 1:31 PM gongzhongqiang 
> wrote:
>
> > +1 (non-binding)
> >
> > - Validated checksum hash and signature.
> > - Confirmed that no binaries exist in the source archive.
> > - Built the source with JDK 8.
> > - Verified the web PR.
> > - Ensured the JAR is built by JDK 8.
> >
> > Best,
> > Zhongqiang Gong
> >
> > Danny Cranmer  于2024年4月18日周四 18:20写道:
> >
> > > Hi everyone,
> > >
> > > Please review and vote on the release candidate #1 for the version
> 3.2.0,
> > > as follows:
> > > [ ] +1, Approve the release
> > > [ ] -1, Do not approve the release (please provide specific comments)
> > >
> > > This release supports Flink 1.18 and 1.19.
> > >
> > > The complete staging area is available for your review, which includes:
> > > * JIRA release notes [1],
> > > * the official Apache source release to be deployed to dist.apache.org
> > > [2],
> > > which are signed with the key with fingerprint 125FD8DB [3],
> > > * all artifacts to be deployed to the Maven Central Repository [4],
> > > * source code tag v3.2.0-rc1 [5],
> > > * website pull request listing the new release [6].
> > > * CI run of tag [7].
> > >
> > > The vote will be open for at least 72 hours. It is adopted by majority
> > > approval, with at least 3 PMC affirmative votes.
> > >
> > > Thanks,
> > > Danny
> > >
> > > [1]
> > >
> > >
> >
> https://issues.apache.org/jira/secure/ReleaseNote.jspa?projectId=12315522=12353143
> > > [2]
> > >
> >
> https://dist.apache.org/repos/dist/dev/flink/flink-connector-jdbc-3.2.0-rc2
> > > [3] https://dist.apache.org/repos/dist/release/flink/KEYS
> > > [4]
> > >
> https://repository.apache.org/content/repositories/orgapacheflink-1718/
> > > [5]
> > https://github.com/apache/flink-connector-jdbc/releases/tag/v3.2.0-rc2
> > > [6] https://github.com/apache/flink-web/pull/734
> > > [7]
> > https://github.com/apache/flink-connector-jdbc/actions/runs/8736019099
> > >
> >
>


Re: [VOTE] Release flink-connector-jdbc v3.2.0, release candidate #2

2024-06-06 Thread Rui Fan
Thanks Danny for the hard work!

+1(binding)

- Verified signatures
- Verified sha512 (hashsums)
- The source archives do not contain any binaries
- Build the source with Maven 3 and java8 (Checked the license as well)
- Checked Github release tag
- Reviewed the flink-web PR

Best,
Rui

On Tue, Jun 4, 2024 at 1:31 PM gongzhongqiang 
wrote:

> +1 (non-binding)
>
> - Validated checksum hash and signature.
> - Confirmed that no binaries exist in the source archive.
> - Built the source with JDK 8.
> - Verified the web PR.
> - Ensured the JAR is built by JDK 8.
>
> Best,
> Zhongqiang Gong
>
> Danny Cranmer  于2024年4月18日周四 18:20写道:
>
> > Hi everyone,
> >
> > Please review and vote on the release candidate #1 for the version 3.2.0,
> > as follows:
> > [ ] +1, Approve the release
> > [ ] -1, Do not approve the release (please provide specific comments)
> >
> > This release supports Flink 1.18 and 1.19.
> >
> > The complete staging area is available for your review, which includes:
> > * JIRA release notes [1],
> > * the official Apache source release to be deployed to dist.apache.org
> > [2],
> > which are signed with the key with fingerprint 125FD8DB [3],
> > * all artifacts to be deployed to the Maven Central Repository [4],
> > * source code tag v3.2.0-rc1 [5],
> > * website pull request listing the new release [6].
> > * CI run of tag [7].
> >
> > The vote will be open for at least 72 hours. It is adopted by majority
> > approval, with at least 3 PMC affirmative votes.
> >
> > Thanks,
> > Danny
> >
> > [1]
> >
> >
> https://issues.apache.org/jira/secure/ReleaseNote.jspa?projectId=12315522=12353143
> > [2]
> >
> https://dist.apache.org/repos/dist/dev/flink/flink-connector-jdbc-3.2.0-rc2
> > [3] https://dist.apache.org/repos/dist/release/flink/KEYS
> > [4]
> > https://repository.apache.org/content/repositories/orgapacheflink-1718/
> > [5]
> https://github.com/apache/flink-connector-jdbc/releases/tag/v3.2.0-rc2
> > [6] https://github.com/apache/flink-web/pull/734
> > [7]
> https://github.com/apache/flink-connector-jdbc/actions/runs/8736019099
> >
>


Re: [VOTE] Release flink-connector-jdbc v3.2.0, release candidate #2

2024-06-03 Thread gongzhongqiang
+1 (non-binding)

- Validated checksum hash and signature.
- Confirmed that no binaries exist in the source archive.
- Built the source with JDK 8.
- Verified the web PR.
- Ensured the JAR is built by JDK 8.

Best,
Zhongqiang Gong

Danny Cranmer  于2024年4月18日周四 18:20写道:

> Hi everyone,
>
> Please review and vote on the release candidate #1 for the version 3.2.0,
> as follows:
> [ ] +1, Approve the release
> [ ] -1, Do not approve the release (please provide specific comments)
>
> This release supports Flink 1.18 and 1.19.
>
> The complete staging area is available for your review, which includes:
> * JIRA release notes [1],
> * the official Apache source release to be deployed to dist.apache.org
> [2],
> which are signed with the key with fingerprint 125FD8DB [3],
> * all artifacts to be deployed to the Maven Central Repository [4],
> * source code tag v3.2.0-rc1 [5],
> * website pull request listing the new release [6].
> * CI run of tag [7].
>
> The vote will be open for at least 72 hours. It is adopted by majority
> approval, with at least 3 PMC affirmative votes.
>
> Thanks,
> Danny
>
> [1]
>
> https://issues.apache.org/jira/secure/ReleaseNote.jspa?projectId=12315522=12353143
> [2]
> https://dist.apache.org/repos/dist/dev/flink/flink-connector-jdbc-3.2.0-rc2
> [3] https://dist.apache.org/repos/dist/release/flink/KEYS
> [4]
> https://repository.apache.org/content/repositories/orgapacheflink-1718/
> [5] https://github.com/apache/flink-connector-jdbc/releases/tag/v3.2.0-rc2
> [6] https://github.com/apache/flink-web/pull/734
> [7] https://github.com/apache/flink-connector-jdbc/actions/runs/8736019099
>


Re: [VOTE] Release flink-connector-jdbc v3.2.0, release candidate #2

2024-06-03 Thread Yuepeng Pan
Thanks Leonard for the checking and Rui for the discussion.

I cancel the '-1 (non-binding)' vote.
And +1(non-binding) for the vote thread.

- Verified hash
- Test a few of usage demo on mysql-5.7
- build from source code with jdk-1.8 on MacOS.

Best regards,
Yuepeng Pan.

On 2024/06/03 14:46:35 Leonard Xu wrote:
> 
> > -1 (non-binding)
> > blocked by https://issues.apache.org/jira/browse/FLINK-35496.
> 
> 
> I just replied in https://issues.apache.org/jira/browse/FLINK-35496 
> , I think the API 
> annotation understanding is incorrect in this case, hope to see your comments
> 
> Best,
> Leonard
> 
> 
> 
> 
> > Best, 
> > Yuepeng Pan
> > 
> > 
> > On 2024/05/22 12:13:51 Leonard Xu wrote:
> >> +1 (binding)
> >> 
> >> - verified signatures
> >> - verified hashsums
> >> - built from source code with java 1.8 succeeded
> >> - checked Github release tag 
> >> - checked release notes
> >> - reviewed the web PR
> >> 
> >> Best,
> >> Leonard
> >> 
> >>> 2024年4月21日 下午9:42,Hang Ruan  写道:
> >>> 
> >>> +1 (non-binding)
> >>> 
> >>> - Validated checksum hash
> >>> - Verified signature
> >>> - Verified that no binaries exist in the source archive
> >>> - Build the source with Maven and jdk8
> >>> - Verified web PR
> >>> - Check that the jar is built by jdk8
> >>> 
> >>> Best,
> >>> Hang
> >>> 
> >>> Ahmed Hamdy  于2024年4月18日周四 21:37写道:
> >>> 
>  +1 (non-binding)
>  
>  - Verified Checksums and hashes
>  - Verified Signatures
>  - No binaries in source
>  - Build source
>  - Github tag exists
>  - Reviewed Web PR
>  
>  
>  Best Regards
>  Ahmed Hamdy
>  
>  
>  On Thu, 18 Apr 2024 at 11:22, Danny Cranmer 
>  wrote:
>  
> > Sorry for typos:
> > 
> >> Please review and vote on the release candidate #1 for the version
>  3.2.0,
> > as follows:
> > Should be "release candidate #2"
> > 
> >> * source code tag v3.2.0-rc1 [5],
> > Should be "source code tag v3.2.0-rc2"
> > 
> > Thanks,
> > Danny
> > 
> > On Thu, Apr 18, 2024 at 11:19 AM Danny Cranmer 
> > wrote:
> > 
> >> Hi everyone,
> >> 
> >> Please review and vote on the release candidate #1 for the version
>  3.2.0,
> >> as follows:
> >> [ ] +1, Approve the release
> >> [ ] -1, Do not approve the release (please provide specific comments)
> >> 
> >> This release supports Flink 1.18 and 1.19.
> >> 
> >> The complete staging area is available for your review, which includes:
> >> * JIRA release notes [1],
> >> * the official Apache source release to be deployed to dist.apache.org
> >> [2], which are signed with the key with fingerprint 125FD8DB [3],
> >> * all artifacts to be deployed to the Maven Central Repository [4],
> >> * source code tag v3.2.0-rc1 [5],
> >> * website pull request listing the new release [6].
> >> * CI run of tag [7].
> >> 
> >> The vote will be open for at least 72 hours. It is adopted by majority
> >> approval, with at least 3 PMC affirmative votes.
> >> 
> >> Thanks,
> >> Danny
> >> 
> >> [1]
> >> 
> > 
>  https://issues.apache.org/jira/secure/ReleaseNote.jspa?projectId=12315522=12353143
> >> [2]
> >> 
> > 
>  https://dist.apache.org/repos/dist/dev/flink/flink-connector-jdbc-3.2.0-rc2
> >> [3] https://dist.apache.org/repos/dist/release/flink/KEYS
> >> [4]
> >> 
>  https://repository.apache.org/content/repositories/orgapacheflink-1718/
> >> [5]
> > https://github.com/apache/flink-connector-jdbc/releases/tag/v3.2.0-rc2
> >> [6] https://github.com/apache/flink-web/pull/734
> >> [7]
> > https://github.com/apache/flink-connector-jdbc/actions/runs/8736019099
> >> 
> > 
>  
> >> 
> >> 
> 
> 


Re: [VOTE] Release flink-connector-jdbc v3.2.0, release candidate #2

2024-06-03 Thread Leonard Xu

> -1 (non-binding)
> blocked by https://issues.apache.org/jira/browse/FLINK-35496.


I just replied in https://issues.apache.org/jira/browse/FLINK-35496 
, I think the API annotation 
understanding is incorrect in this case, hope to see your comments

Best,
Leonard




> Best, 
> Yuepeng Pan
> 
> 
> On 2024/05/22 12:13:51 Leonard Xu wrote:
>> +1 (binding)
>> 
>> - verified signatures
>> - verified hashsums
>> - built from source code with java 1.8 succeeded
>> - checked Github release tag 
>> - checked release notes
>> - reviewed the web PR
>> 
>> Best,
>> Leonard
>> 
>>> 2024年4月21日 下午9:42,Hang Ruan  写道:
>>> 
>>> +1 (non-binding)
>>> 
>>> - Validated checksum hash
>>> - Verified signature
>>> - Verified that no binaries exist in the source archive
>>> - Build the source with Maven and jdk8
>>> - Verified web PR
>>> - Check that the jar is built by jdk8
>>> 
>>> Best,
>>> Hang
>>> 
>>> Ahmed Hamdy  于2024年4月18日周四 21:37写道:
>>> 
 +1 (non-binding)
 
 - Verified Checksums and hashes
 - Verified Signatures
 - No binaries in source
 - Build source
 - Github tag exists
 - Reviewed Web PR
 
 
 Best Regards
 Ahmed Hamdy
 
 
 On Thu, 18 Apr 2024 at 11:22, Danny Cranmer 
 wrote:
 
> Sorry for typos:
> 
>> Please review and vote on the release candidate #1 for the version
 3.2.0,
> as follows:
> Should be "release candidate #2"
> 
>> * source code tag v3.2.0-rc1 [5],
> Should be "source code tag v3.2.0-rc2"
> 
> Thanks,
> Danny
> 
> On Thu, Apr 18, 2024 at 11:19 AM Danny Cranmer 
> wrote:
> 
>> Hi everyone,
>> 
>> Please review and vote on the release candidate #1 for the version
 3.2.0,
>> as follows:
>> [ ] +1, Approve the release
>> [ ] -1, Do not approve the release (please provide specific comments)
>> 
>> This release supports Flink 1.18 and 1.19.
>> 
>> The complete staging area is available for your review, which includes:
>> * JIRA release notes [1],
>> * the official Apache source release to be deployed to dist.apache.org
>> [2], which are signed with the key with fingerprint 125FD8DB [3],
>> * all artifacts to be deployed to the Maven Central Repository [4],
>> * source code tag v3.2.0-rc1 [5],
>> * website pull request listing the new release [6].
>> * CI run of tag [7].
>> 
>> The vote will be open for at least 72 hours. It is adopted by majority
>> approval, with at least 3 PMC affirmative votes.
>> 
>> Thanks,
>> Danny
>> 
>> [1]
>> 
> 
 https://issues.apache.org/jira/secure/ReleaseNote.jspa?projectId=12315522=12353143
>> [2]
>> 
> 
 https://dist.apache.org/repos/dist/dev/flink/flink-connector-jdbc-3.2.0-rc2
>> [3] https://dist.apache.org/repos/dist/release/flink/KEYS
>> [4]
>> 
 https://repository.apache.org/content/repositories/orgapacheflink-1718/
>> [5]
> https://github.com/apache/flink-connector-jdbc/releases/tag/v3.2.0-rc2
>> [6] https://github.com/apache/flink-web/pull/734
>> [7]
> https://github.com/apache/flink-connector-jdbc/actions/runs/8736019099
>> 
> 
 
>> 
>> 



Re: [VOTE] Release flink-connector-jdbc v3.2.0, release candidate #2

2024-05-31 Thread Yuepeng Pan
-1 (non-binding)
blocked by https://issues.apache.org/jira/browse/FLINK-35496.

Best, 
Yuepeng Pan


On 2024/05/22 12:13:51 Leonard Xu wrote:
> +1 (binding)
> 
> - verified signatures
> - verified hashsums
> - built from source code with java 1.8 succeeded
> - checked Github release tag 
> - checked release notes
> - reviewed the web PR
> 
> Best,
> Leonard
> 
> > 2024年4月21日 下午9:42,Hang Ruan  写道:
> > 
> > +1 (non-binding)
> > 
> > - Validated checksum hash
> > - Verified signature
> > - Verified that no binaries exist in the source archive
> > - Build the source with Maven and jdk8
> > - Verified web PR
> > - Check that the jar is built by jdk8
> > 
> > Best,
> > Hang
> > 
> > Ahmed Hamdy  于2024年4月18日周四 21:37写道:
> > 
> >> +1 (non-binding)
> >> 
> >> - Verified Checksums and hashes
> >> - Verified Signatures
> >> - No binaries in source
> >> - Build source
> >> - Github tag exists
> >> - Reviewed Web PR
> >> 
> >> 
> >> Best Regards
> >> Ahmed Hamdy
> >> 
> >> 
> >> On Thu, 18 Apr 2024 at 11:22, Danny Cranmer 
> >> wrote:
> >> 
> >>> Sorry for typos:
> >>> 
>  Please review and vote on the release candidate #1 for the version
> >> 3.2.0,
> >>> as follows:
> >>> Should be "release candidate #2"
> >>> 
>  * source code tag v3.2.0-rc1 [5],
> >>> Should be "source code tag v3.2.0-rc2"
> >>> 
> >>> Thanks,
> >>> Danny
> >>> 
> >>> On Thu, Apr 18, 2024 at 11:19 AM Danny Cranmer 
> >>> wrote:
> >>> 
>  Hi everyone,
>  
>  Please review and vote on the release candidate #1 for the version
> >> 3.2.0,
>  as follows:
>  [ ] +1, Approve the release
>  [ ] -1, Do not approve the release (please provide specific comments)
>  
>  This release supports Flink 1.18 and 1.19.
>  
>  The complete staging area is available for your review, which includes:
>  * JIRA release notes [1],
>  * the official Apache source release to be deployed to dist.apache.org
>  [2], which are signed with the key with fingerprint 125FD8DB [3],
>  * all artifacts to be deployed to the Maven Central Repository [4],
>  * source code tag v3.2.0-rc1 [5],
>  * website pull request listing the new release [6].
>  * CI run of tag [7].
>  
>  The vote will be open for at least 72 hours. It is adopted by majority
>  approval, with at least 3 PMC affirmative votes.
>  
>  Thanks,
>  Danny
>  
>  [1]
>  
> >>> 
> >> https://issues.apache.org/jira/secure/ReleaseNote.jspa?projectId=12315522=12353143
>  [2]
>  
> >>> 
> >> https://dist.apache.org/repos/dist/dev/flink/flink-connector-jdbc-3.2.0-rc2
>  [3] https://dist.apache.org/repos/dist/release/flink/KEYS
>  [4]
>  
> >> https://repository.apache.org/content/repositories/orgapacheflink-1718/
>  [5]
> >>> https://github.com/apache/flink-connector-jdbc/releases/tag/v3.2.0-rc2
>  [6] https://github.com/apache/flink-web/pull/734
>  [7]
> >>> https://github.com/apache/flink-connector-jdbc/actions/runs/8736019099
>  
> >>> 
> >> 
> 
> 


Re: [VOTE] Release flink-connector-jdbc v3.2.0, release candidate #2

2024-05-22 Thread Leonard Xu
+1 (binding)

- verified signatures
- verified hashsums
- built from source code with java 1.8 succeeded
- checked Github release tag 
- checked release notes
- reviewed the web PR

Best,
Leonard

> 2024年4月21日 下午9:42,Hang Ruan  写道:
> 
> +1 (non-binding)
> 
> - Validated checksum hash
> - Verified signature
> - Verified that no binaries exist in the source archive
> - Build the source with Maven and jdk8
> - Verified web PR
> - Check that the jar is built by jdk8
> 
> Best,
> Hang
> 
> Ahmed Hamdy  于2024年4月18日周四 21:37写道:
> 
>> +1 (non-binding)
>> 
>> - Verified Checksums and hashes
>> - Verified Signatures
>> - No binaries in source
>> - Build source
>> - Github tag exists
>> - Reviewed Web PR
>> 
>> 
>> Best Regards
>> Ahmed Hamdy
>> 
>> 
>> On Thu, 18 Apr 2024 at 11:22, Danny Cranmer 
>> wrote:
>> 
>>> Sorry for typos:
>>> 
 Please review and vote on the release candidate #1 for the version
>> 3.2.0,
>>> as follows:
>>> Should be "release candidate #2"
>>> 
 * source code tag v3.2.0-rc1 [5],
>>> Should be "source code tag v3.2.0-rc2"
>>> 
>>> Thanks,
>>> Danny
>>> 
>>> On Thu, Apr 18, 2024 at 11:19 AM Danny Cranmer 
>>> wrote:
>>> 
 Hi everyone,
 
 Please review and vote on the release candidate #1 for the version
>> 3.2.0,
 as follows:
 [ ] +1, Approve the release
 [ ] -1, Do not approve the release (please provide specific comments)
 
 This release supports Flink 1.18 and 1.19.
 
 The complete staging area is available for your review, which includes:
 * JIRA release notes [1],
 * the official Apache source release to be deployed to dist.apache.org
 [2], which are signed with the key with fingerprint 125FD8DB [3],
 * all artifacts to be deployed to the Maven Central Repository [4],
 * source code tag v3.2.0-rc1 [5],
 * website pull request listing the new release [6].
 * CI run of tag [7].
 
 The vote will be open for at least 72 hours. It is adopted by majority
 approval, with at least 3 PMC affirmative votes.
 
 Thanks,
 Danny
 
 [1]
 
>>> 
>> https://issues.apache.org/jira/secure/ReleaseNote.jspa?projectId=12315522=12353143
 [2]
 
>>> 
>> https://dist.apache.org/repos/dist/dev/flink/flink-connector-jdbc-3.2.0-rc2
 [3] https://dist.apache.org/repos/dist/release/flink/KEYS
 [4]
 
>> https://repository.apache.org/content/repositories/orgapacheflink-1718/
 [5]
>>> https://github.com/apache/flink-connector-jdbc/releases/tag/v3.2.0-rc2
 [6] https://github.com/apache/flink-web/pull/734
 [7]
>>> https://github.com/apache/flink-connector-jdbc/actions/runs/8736019099
 
>>> 
>> 



Re: [VOTE] Release flink-connector-jdbc v3.2.0, release candidate #2

2024-04-21 Thread Hang Ruan
+1 (non-binding)

- Validated checksum hash
- Verified signature
- Verified that no binaries exist in the source archive
- Build the source with Maven and jdk8
- Verified web PR
- Check that the jar is built by jdk8

Best,
Hang

Ahmed Hamdy  于2024年4月18日周四 21:37写道:

> +1 (non-binding)
>
> - Verified Checksums and hashes
> - Verified Signatures
> - No binaries in source
> - Build source
> - Github tag exists
> - Reviewed Web PR
>
>
> Best Regards
> Ahmed Hamdy
>
>
> On Thu, 18 Apr 2024 at 11:22, Danny Cranmer 
> wrote:
>
> > Sorry for typos:
> >
> > > Please review and vote on the release candidate #1 for the version
> 3.2.0,
> > as follows:
> > Should be "release candidate #2"
> >
> > > * source code tag v3.2.0-rc1 [5],
> > Should be "source code tag v3.2.0-rc2"
> >
> > Thanks,
> > Danny
> >
> > On Thu, Apr 18, 2024 at 11:19 AM Danny Cranmer 
> > wrote:
> >
> > > Hi everyone,
> > >
> > > Please review and vote on the release candidate #1 for the version
> 3.2.0,
> > > as follows:
> > > [ ] +1, Approve the release
> > > [ ] -1, Do not approve the release (please provide specific comments)
> > >
> > > This release supports Flink 1.18 and 1.19.
> > >
> > > The complete staging area is available for your review, which includes:
> > > * JIRA release notes [1],
> > > * the official Apache source release to be deployed to dist.apache.org
> > > [2], which are signed with the key with fingerprint 125FD8DB [3],
> > > * all artifacts to be deployed to the Maven Central Repository [4],
> > > * source code tag v3.2.0-rc1 [5],
> > > * website pull request listing the new release [6].
> > > * CI run of tag [7].
> > >
> > > The vote will be open for at least 72 hours. It is adopted by majority
> > > approval, with at least 3 PMC affirmative votes.
> > >
> > > Thanks,
> > > Danny
> > >
> > > [1]
> > >
> >
> https://issues.apache.org/jira/secure/ReleaseNote.jspa?projectId=12315522=12353143
> > > [2]
> > >
> >
> https://dist.apache.org/repos/dist/dev/flink/flink-connector-jdbc-3.2.0-rc2
> > > [3] https://dist.apache.org/repos/dist/release/flink/KEYS
> > > [4]
> > >
> https://repository.apache.org/content/repositories/orgapacheflink-1718/
> > > [5]
> > https://github.com/apache/flink-connector-jdbc/releases/tag/v3.2.0-rc2
> > > [6] https://github.com/apache/flink-web/pull/734
> > > [7]
> > https://github.com/apache/flink-connector-jdbc/actions/runs/8736019099
> > >
> >
>


Re: [VOTE] Release flink-connector-jdbc v3.2.0, release candidate #2

2024-04-18 Thread Ahmed Hamdy
+1 (non-binding)

- Verified Checksums and hashes
- Verified Signatures
- No binaries in source
- Build source
- Github tag exists
- Reviewed Web PR


Best Regards
Ahmed Hamdy


On Thu, 18 Apr 2024 at 11:22, Danny Cranmer  wrote:

> Sorry for typos:
>
> > Please review and vote on the release candidate #1 for the version 3.2.0,
> as follows:
> Should be "release candidate #2"
>
> > * source code tag v3.2.0-rc1 [5],
> Should be "source code tag v3.2.0-rc2"
>
> Thanks,
> Danny
>
> On Thu, Apr 18, 2024 at 11:19 AM Danny Cranmer 
> wrote:
>
> > Hi everyone,
> >
> > Please review and vote on the release candidate #1 for the version 3.2.0,
> > as follows:
> > [ ] +1, Approve the release
> > [ ] -1, Do not approve the release (please provide specific comments)
> >
> > This release supports Flink 1.18 and 1.19.
> >
> > The complete staging area is available for your review, which includes:
> > * JIRA release notes [1],
> > * the official Apache source release to be deployed to dist.apache.org
> > [2], which are signed with the key with fingerprint 125FD8DB [3],
> > * all artifacts to be deployed to the Maven Central Repository [4],
> > * source code tag v3.2.0-rc1 [5],
> > * website pull request listing the new release [6].
> > * CI run of tag [7].
> >
> > The vote will be open for at least 72 hours. It is adopted by majority
> > approval, with at least 3 PMC affirmative votes.
> >
> > Thanks,
> > Danny
> >
> > [1]
> >
> https://issues.apache.org/jira/secure/ReleaseNote.jspa?projectId=12315522=12353143
> > [2]
> >
> https://dist.apache.org/repos/dist/dev/flink/flink-connector-jdbc-3.2.0-rc2
> > [3] https://dist.apache.org/repos/dist/release/flink/KEYS
> > [4]
> > https://repository.apache.org/content/repositories/orgapacheflink-1718/
> > [5]
> https://github.com/apache/flink-connector-jdbc/releases/tag/v3.2.0-rc2
> > [6] https://github.com/apache/flink-web/pull/734
> > [7]
> https://github.com/apache/flink-connector-jdbc/actions/runs/8736019099
> >
>


Re: [VOTE] Release flink-connector-jdbc v3.2.0, release candidate #2

2024-04-18 Thread Danny Cranmer
Sorry for typos:

> Please review and vote on the release candidate #1 for the version 3.2.0,
as follows:
Should be "release candidate #2"

> * source code tag v3.2.0-rc1 [5],
Should be "source code tag v3.2.0-rc2"

Thanks,
Danny

On Thu, Apr 18, 2024 at 11:19 AM Danny Cranmer 
wrote:

> Hi everyone,
>
> Please review and vote on the release candidate #1 for the version 3.2.0,
> as follows:
> [ ] +1, Approve the release
> [ ] -1, Do not approve the release (please provide specific comments)
>
> This release supports Flink 1.18 and 1.19.
>
> The complete staging area is available for your review, which includes:
> * JIRA release notes [1],
> * the official Apache source release to be deployed to dist.apache.org
> [2], which are signed with the key with fingerprint 125FD8DB [3],
> * all artifacts to be deployed to the Maven Central Repository [4],
> * source code tag v3.2.0-rc1 [5],
> * website pull request listing the new release [6].
> * CI run of tag [7].
>
> The vote will be open for at least 72 hours. It is adopted by majority
> approval, with at least 3 PMC affirmative votes.
>
> Thanks,
> Danny
>
> [1]
> https://issues.apache.org/jira/secure/ReleaseNote.jspa?projectId=12315522=12353143
> [2]
> https://dist.apache.org/repos/dist/dev/flink/flink-connector-jdbc-3.2.0-rc2
> [3] https://dist.apache.org/repos/dist/release/flink/KEYS
> [4]
> https://repository.apache.org/content/repositories/orgapacheflink-1718/
> [5] https://github.com/apache/flink-connector-jdbc/releases/tag/v3.2.0-rc2
> [6] https://github.com/apache/flink-web/pull/734
> [7] https://github.com/apache/flink-connector-jdbc/actions/runs/8736019099
>


[VOTE] Release flink-connector-jdbc v3.2.0, release candidate #2

2024-04-18 Thread Danny Cranmer
Hi everyone,

Please review and vote on the release candidate #1 for the version 3.2.0,
as follows:
[ ] +1, Approve the release
[ ] -1, Do not approve the release (please provide specific comments)

This release supports Flink 1.18 and 1.19.

The complete staging area is available for your review, which includes:
* JIRA release notes [1],
* the official Apache source release to be deployed to dist.apache.org [2],
which are signed with the key with fingerprint 125FD8DB [3],
* all artifacts to be deployed to the Maven Central Repository [4],
* source code tag v3.2.0-rc1 [5],
* website pull request listing the new release [6].
* CI run of tag [7].

The vote will be open for at least 72 hours. It is adopted by majority
approval, with at least 3 PMC affirmative votes.

Thanks,
Danny

[1]
https://issues.apache.org/jira/secure/ReleaseNote.jspa?projectId=12315522=12353143
[2]
https://dist.apache.org/repos/dist/dev/flink/flink-connector-jdbc-3.2.0-rc2
[3] https://dist.apache.org/repos/dist/release/flink/KEYS
[4] https://repository.apache.org/content/repositories/orgapacheflink-1718/
[5] https://github.com/apache/flink-connector-jdbc/releases/tag/v3.2.0-rc2
[6] https://github.com/apache/flink-web/pull/734
[7] https://github.com/apache/flink-connector-jdbc/actions/runs/8736019099