Re: FLINK-21672
Makes sense to defer this to the next release On Fri, 16 Feb 2024 at 17:52, Martijn Visser wrote: > Well I wouldn't be too comfortable with merging a change about how > Flink works on different JDKs at this stage, especially since we > already have to test for 4 different JDKs at this point. > > On Fri, Feb 16, 2024 at 5:00 PM Gyula Fóra wrote: > > > > Depending on the scope of this change, it may not be considered a feature > > right Martijn? > > If it's a test improvement, can it still be part of the release? > > > > Gyula > > > > On Fri, Feb 16, 2024 at 4:45 PM Martijn Visser > > > wrote: > > > > > Hi David, > > > > > > Happy to assign it to you. It can't be merged for Flink 1.19 anymore > > > though: feature freeze has started for that one, as announced > > > previously on the mailing list. > > > > > > Best regards, > > > > > > Martijn > > > > > > On Fri, Feb 16, 2024 at 4:32 PM David Radley > > > wrote: > > > > > > > > Hi, > > > > I see https://issues.apache.org/jira/browse/FLINK-21672 has been > open > > > for a while. We at IBM are building Flink with the latest v11 Semeru > JDK ( > > > https://developer.ibm.com/languages/java/semeru-runtimes/). > > > > Flink fails to build with skipTests. It fails because > > > sun.management.VMManagement class > > > > Cannot be found at build time. I see some logic in the Flink code to > > > tolerate the lack of com.sun packages, but not this sun package. We > get: > > > > > > > > > > > > ERROR] Failed to execute goal > > > org.apache.maven.plugins:maven-compiler-plugin:3.8.0:compile > > > (default-compile) on project flink-local-recovery-and-allocation-test: > > > Compilation failure: Compilation failure: > > > > > > > > [ERROR] > > > > /Users/davidradley/flinkapicurio/flink-end-to-end-tests/flink-local-recovery-and-allocation-test/src/main/java/org/apache/flink/streaming/tests/StickyAllocationAndLocalRecoveryTestJob.java:[418,23] > > > cannot find symbol > > > > > > > > [ERROR] symbol: class VMManagement > > > > > > > > [ERROR] location: package sun.management > > > > > > > > [ERROR] > > > > /Users/davidradley/flinkapicurio/flink-end-to-end-tests/flink-local-recovery-and-allocation-test/src/main/java/org/apache/flink/streaming/tests/StickyAllocationAndLocalRecoveryTestJob.java:[418,59] > > > cannot find symbol > > > > > > > > [ERROR] symbol: class VMManagement > > > > > > > > [ERROR] location: package sun.management > > > > > > > > > > > > As per the link in the issue, sun. packages are not supported or > part of > > > the JDK after java 1.7. > > > > > > > > I would like to have the priority raised on this Jira and would like > to > > > change the code so it builds successfully by removing the dependency > on > > > this old / unsupported sun package . I am happy to work on this, if > you are > > > willing to support this by assigning me the Jira and merging the fix; > > > ideally we would like this to be in the next release - Flink 1.19, > > > > Kind regards, David. > > > > > > > > Unless otherwise stated above: > > > > > > > > IBM United Kingdom Limited > > > > Registered in England and Wales with number 741598 > > > > Registered office: PO Box 41, North Harbour, Portsmouth, Hants. PO6 > 3AU > > > >
Re: FLINK-21672
Well I wouldn't be too comfortable with merging a change about how Flink works on different JDKs at this stage, especially since we already have to test for 4 different JDKs at this point. On Fri, Feb 16, 2024 at 5:00 PM Gyula Fóra wrote: > > Depending on the scope of this change, it may not be considered a feature > right Martijn? > If it's a test improvement, can it still be part of the release? > > Gyula > > On Fri, Feb 16, 2024 at 4:45 PM Martijn Visser > wrote: > > > Hi David, > > > > Happy to assign it to you. It can't be merged for Flink 1.19 anymore > > though: feature freeze has started for that one, as announced > > previously on the mailing list. > > > > Best regards, > > > > Martijn > > > > On Fri, Feb 16, 2024 at 4:32 PM David Radley > > wrote: > > > > > > Hi, > > > I see https://issues.apache.org/jira/browse/FLINK-21672 has been open > > for a while. We at IBM are building Flink with the latest v11 Semeru JDK ( > > https://developer.ibm.com/languages/java/semeru-runtimes/). > > > Flink fails to build with skipTests. It fails because > > sun.management.VMManagement class > > > Cannot be found at build time. I see some logic in the Flink code to > > tolerate the lack of com.sun packages, but not this sun package. We get: > > > > > > > > > ERROR] Failed to execute goal > > org.apache.maven.plugins:maven-compiler-plugin:3.8.0:compile > > (default-compile) on project flink-local-recovery-and-allocation-test: > > Compilation failure: Compilation failure: > > > > > > [ERROR] > > /Users/davidradley/flinkapicurio/flink-end-to-end-tests/flink-local-recovery-and-allocation-test/src/main/java/org/apache/flink/streaming/tests/StickyAllocationAndLocalRecoveryTestJob.java:[418,23] > > cannot find symbol > > > > > > [ERROR] symbol: class VMManagement > > > > > > [ERROR] location: package sun.management > > > > > > [ERROR] > > /Users/davidradley/flinkapicurio/flink-end-to-end-tests/flink-local-recovery-and-allocation-test/src/main/java/org/apache/flink/streaming/tests/StickyAllocationAndLocalRecoveryTestJob.java:[418,59] > > cannot find symbol > > > > > > [ERROR] symbol: class VMManagement > > > > > > [ERROR] location: package sun.management > > > > > > > > > As per the link in the issue, sun. packages are not supported or part of > > the JDK after java 1.7. > > > > > > I would like to have the priority raised on this Jira and would like to > > change the code so it builds successfully by removing the dependency on > > this old / unsupported sun package . I am happy to work on this, if you are > > willing to support this by assigning me the Jira and merging the fix; > > ideally we would like this to be in the next release - Flink 1.19, > > > Kind regards, David. > > > > > > Unless otherwise stated above: > > > > > > IBM United Kingdom Limited > > > Registered in England and Wales with number 741598 > > > Registered office: PO Box 41, North Harbour, Portsmouth, Hants. PO6 3AU > >
Re: FLINK-21672
Depending on the scope of this change, it may not be considered a feature right Martijn? If it's a test improvement, can it still be part of the release? Gyula On Fri, Feb 16, 2024 at 4:45 PM Martijn Visser wrote: > Hi David, > > Happy to assign it to you. It can't be merged for Flink 1.19 anymore > though: feature freeze has started for that one, as announced > previously on the mailing list. > > Best regards, > > Martijn > > On Fri, Feb 16, 2024 at 4:32 PM David Radley > wrote: > > > > Hi, > > I see https://issues.apache.org/jira/browse/FLINK-21672 has been open > for a while. We at IBM are building Flink with the latest v11 Semeru JDK ( > https://developer.ibm.com/languages/java/semeru-runtimes/). > > Flink fails to build with skipTests. It fails because > sun.management.VMManagement class > > Cannot be found at build time. I see some logic in the Flink code to > tolerate the lack of com.sun packages, but not this sun package. We get: > > > > > > ERROR] Failed to execute goal > org.apache.maven.plugins:maven-compiler-plugin:3.8.0:compile > (default-compile) on project flink-local-recovery-and-allocation-test: > Compilation failure: Compilation failure: > > > > [ERROR] > /Users/davidradley/flinkapicurio/flink-end-to-end-tests/flink-local-recovery-and-allocation-test/src/main/java/org/apache/flink/streaming/tests/StickyAllocationAndLocalRecoveryTestJob.java:[418,23] > cannot find symbol > > > > [ERROR] symbol: class VMManagement > > > > [ERROR] location: package sun.management > > > > [ERROR] > /Users/davidradley/flinkapicurio/flink-end-to-end-tests/flink-local-recovery-and-allocation-test/src/main/java/org/apache/flink/streaming/tests/StickyAllocationAndLocalRecoveryTestJob.java:[418,59] > cannot find symbol > > > > [ERROR] symbol: class VMManagement > > > > [ERROR] location: package sun.management > > > > > > As per the link in the issue, sun. packages are not supported or part of > the JDK after java 1.7. > > > > I would like to have the priority raised on this Jira and would like to > change the code so it builds successfully by removing the dependency on > this old / unsupported sun package . I am happy to work on this, if you are > willing to support this by assigning me the Jira and merging the fix; > ideally we would like this to be in the next release - Flink 1.19, > > Kind regards, David. > > > > Unless otherwise stated above: > > > > IBM United Kingdom Limited > > Registered in England and Wales with number 741598 > > Registered office: PO Box 41, North Harbour, Portsmouth, Hants. PO6 3AU >
Re: FLINK-21672
Hi David, Happy to assign it to you. It can't be merged for Flink 1.19 anymore though: feature freeze has started for that one, as announced previously on the mailing list. Best regards, Martijn On Fri, Feb 16, 2024 at 4:32 PM David Radley wrote: > > Hi, > I see https://issues.apache.org/jira/browse/FLINK-21672 has been open for a > while. We at IBM are building Flink with the latest v11 Semeru JDK > (https://developer.ibm.com/languages/java/semeru-runtimes/). > Flink fails to build with skipTests. It fails because > sun.management.VMManagement class > Cannot be found at build time. I see some logic in the Flink code to tolerate > the lack of com.sun packages, but not this sun package. We get: > > > ERROR] Failed to execute goal > org.apache.maven.plugins:maven-compiler-plugin:3.8.0:compile > (default-compile) on project flink-local-recovery-and-allocation-test: > Compilation failure: Compilation failure: > > [ERROR] > /Users/davidradley/flinkapicurio/flink-end-to-end-tests/flink-local-recovery-and-allocation-test/src/main/java/org/apache/flink/streaming/tests/StickyAllocationAndLocalRecoveryTestJob.java:[418,23] > cannot find symbol > > [ERROR] symbol: class VMManagement > > [ERROR] location: package sun.management > > [ERROR] > /Users/davidradley/flinkapicurio/flink-end-to-end-tests/flink-local-recovery-and-allocation-test/src/main/java/org/apache/flink/streaming/tests/StickyAllocationAndLocalRecoveryTestJob.java:[418,59] > cannot find symbol > > [ERROR] symbol: class VMManagement > > [ERROR] location: package sun.management > > > As per the link in the issue, sun. packages are not supported or part of the > JDK after java 1.7. > > I would like to have the priority raised on this Jira and would like to > change the code so it builds successfully by removing the dependency on this > old / unsupported sun package . I am happy to work on this, if you are > willing to support this by assigning me the Jira and merging the fix; ideally > we would like this to be in the next release - Flink 1.19, > Kind regards, David. > > Unless otherwise stated above: > > IBM United Kingdom Limited > Registered in England and Wales with number 741598 > Registered office: PO Box 41, North Harbour, Portsmouth, Hants. PO6 3AU
FLINK-21672
Hi, I see https://issues.apache.org/jira/browse/FLINK-21672 has been open for a while. We at IBM are building Flink with the latest v11 Semeru JDK (https://developer.ibm.com/languages/java/semeru-runtimes/). Flink fails to build with skipTests. It fails because sun.management.VMManagement class Cannot be found at build time. I see some logic in the Flink code to tolerate the lack of com.sun packages, but not this sun package. We get: ERROR] Failed to execute goal org.apache.maven.plugins:maven-compiler-plugin:3.8.0:compile (default-compile) on project flink-local-recovery-and-allocation-test: Compilation failure: Compilation failure: [ERROR] /Users/davidradley/flinkapicurio/flink-end-to-end-tests/flink-local-recovery-and-allocation-test/src/main/java/org/apache/flink/streaming/tests/StickyAllocationAndLocalRecoveryTestJob.java:[418,23] cannot find symbol [ERROR] symbol: class VMManagement [ERROR] location: package sun.management [ERROR] /Users/davidradley/flinkapicurio/flink-end-to-end-tests/flink-local-recovery-and-allocation-test/src/main/java/org/apache/flink/streaming/tests/StickyAllocationAndLocalRecoveryTestJob.java:[418,59] cannot find symbol [ERROR] symbol: class VMManagement [ERROR] location: package sun.management As per the link in the issue, sun. packages are not supported or part of the JDK after java 1.7. I would like to have the priority raised on this Jira and would like to change the code so it builds successfully by removing the dependency on this old / unsupported sun package . I am happy to work on this, if you are willing to support this by assigning me the Jira and merging the fix; ideally we would like this to be in the next release - Flink 1.19, Kind regards, David. Unless otherwise stated above: IBM United Kingdom Limited Registered in England and Wales with number 741598 Registered office: PO Box 41, North Harbour, Portsmouth, Hants. PO6 3AU
[jira] [Created] (FLINK-21672) End to end tests (streaming) aren't Java vendor neutral (sun.management bean used)
Adam Roberts created FLINK-21672: Summary: End to end tests (streaming) aren't Java vendor neutral (sun.management bean used) Key: FLINK-21672 URL: https://issues.apache.org/jira/browse/FLINK-21672 Project: Flink Issue Type: Improvement Components: Tests Reporter: Adam Roberts Hi everyone, have been looking to run the tests for Flink using an 11 AdoptOpenJDK 11 distribution (so the latest for Linux, x86-64 specifically) and I see [ERROR] Failed to execute goal org.apache.maven.plugins:maven-compiler-plugin:3.8.0:compile (default-compile) on project flink-local-recovery-and-allocation-test: Compilation failure: Compilation failure: [ERROR] /var/home/core/flink/flink-end-to-end-tests/flink-local-recovery-and-allocation-test/src/main/java/org/apache/flink/streaming/tests/StickyAllocationAndLocalRecoveryTestJob.java:[416,23] cannot find symbol [ERROR] symbol: class VMManagement [ERROR] location: package sun.management [ERROR] /var/home/core/flink/flink-end-to-end-tests/flink-local-recovery-and-allocation-test/src/main/java/org/apache/flink/streaming/tests/StickyAllocationAndLocalRecoveryTestJob.java:[416,59] cannot find symbol [ERROR] symbol: class VMManagement [ERROR] location: package sun.management [ERROR] -> [Help 1] my guess is that AdoptOpenJDK's class-library simply doesn't have this package and we should use a more neutral one if that's available - I went with [https://adoptopenjdk.net/releases.html?variant=openjdk11&jvmVariant=openj9] personally (OpenJ9 being the name for IBM's open-sourced J9 JVM), but I wonder if that has its own platform specific bean as well; I haven't worked on IBM's distribution of Java for almost seven years* but hopefully someone may have more insight so you don't need to be using OpenJDK backed by HotSpot to run said tests. *full disclaimer, I work at IBM and helped create AdoptOpenJDK, and used to work in its Java team...I've honestly forgot if we have a vendor-neutral bean available and now work on something totally different! Cheers! -- This message was sent by Atlassian Jira (v8.3.4#803005)
