Re: Looking for reviewer: FLINK-13127
Hi Till, the PR should be ready ;) Can you please do the final check? Best, D. On Tue, Jul 23, 2019 at 3:01 PM Till Rohrmann wrote: > I've assigned the issue to you David. I think this feature makes sense. The > only question I have is why we need to sort the values. But let's discuss > the issue on the Github PR. > > @Tison and @Xintong, let me know once the PR is in mergeable state. > > Cheers, > Till > > On Tue, Jul 23, 2019 at 4:14 AM Xintong Song > wrote: > > > David, > > > > Thank you for opening this PR. I also left a few comments. > > > > And I think we need a committer to assign this jira ticket to David. > Maybe > > Till or any other committer could look into this? > > > > > > Thank you~ > > > > Xintong Song > > > > > > > > On Mon, Jul 22, 2019 at 8:37 PM Zili Chen wrote: > > > > > Hi David, > > > > > > Just reviewed and left several comments. Thanks for your contribution! > > > > > > Best, > > > tison. > > > > > > > > > David Morávek 于2019年7月22日周一 下午5:59写道： > > > > > > > Hi, I've prepared a small patch related to Yarn deployment. Would > > anyone > > > > please have a time to take a look at it? Thanks > > > > > > > > https://github.com/apache/flink/pull/9022 > > > > > > > > Regards, > > > > D. > > > > > > > > > >
Re: Looking for reviewer: FLINK-13127
I've assigned the issue to you David. I think this feature makes sense. The only question I have is why we need to sort the values. But let's discuss the issue on the Github PR. @Tison and @Xintong, let me know once the PR is in mergeable state. Cheers, Till On Tue, Jul 23, 2019 at 4:14 AM Xintong Song wrote: > David, > > Thank you for opening this PR. I also left a few comments. > > And I think we need a committer to assign this jira ticket to David. Maybe > Till or any other committer could look into this? > > > Thank you~ > > Xintong Song > > > > On Mon, Jul 22, 2019 at 8:37 PM Zili Chen wrote: > > > Hi David, > > > > Just reviewed and left several comments. Thanks for your contribution! > > > > Best, > > tison. > > > > > > David Morávek 于2019年7月22日周一 下午5:59写道： > > > > > Hi, I've prepared a small patch related to Yarn deployment. Would > anyone > > > please have a time to take a look at it? Thanks > > > > > > https://github.com/apache/flink/pull/9022 > > > > > > Regards, > > > D. > > > > > >
Re: Looking for reviewer: FLINK-13127
David, Thank you for opening this PR. I also left a few comments. And I think we need a committer to assign this jira ticket to David. Maybe Till or any other committer could look into this? Thank you~ Xintong Song On Mon, Jul 22, 2019 at 8:37 PM Zili Chen wrote: > Hi David, > > Just reviewed and left several comments. Thanks for your contribution! > > Best, > tison. > > > David Morávek 于2019年7月22日周一 下午5:59写道： > > > Hi, I've prepared a small patch related to Yarn deployment. Would anyone > > please have a time to take a look at it? Thanks > > > > https://github.com/apache/flink/pull/9022 > > > > Regards, > > D. > > >
Re: Looking for reviewer: FLINK-13127
Hi David, Just reviewed and left several comments. Thanks for your contribution! Best, tison. David Morávek 于2019年7月22日周一 下午5:59写道： > Hi, I've prepared a small patch related to Yarn deployment. Would anyone > please have a time to take a look at it? Thanks > > https://github.com/apache/flink/pull/9022 > > Regards, > D. >
Looking for reviewer: FLINK-13127
Hi, I've prepared a small patch related to Yarn deployment. Would anyone please have a time to take a look at it? Thanks https://github.com/apache/flink/pull/9022 Regards, D.
