Please review FLINK-9610 Add Kafka partitioner that uses the key to partition by
Hi, Yesterday we ran into problems regarding the distribution of records across Kafka where Flink was used as the producer. So we fixed this and realized that the code to do this would be useful to others. I put up a Jira ticket and pull request yesterday and it passes all automated tests. Please review. https://issues.apache.org/jira/browse/FLINK-9610 https://github.com/apache/flink/pull/6181 -- Best regards / Met vriendelijke groeten, Niels Basjes
Re: Please review FLINK-9610 Add Kafka partitioner that uses the key to partition by
Interesting enhancement. I left a minor comment on the PR. Cheers On Tue, Jun 19, 2018 at 12:26 AM, Niels Basjes wrote: > Hi, > > Yesterday we ran into problems regarding the distribution of records across > Kafka where Flink was used as the producer. So we fixed this and realized > that the code to do this would be useful to others. > > I put up a Jira ticket and pull request yesterday and it passes all > automated tests. > Please review. > > https://issues.apache.org/jira/browse/FLINK-9610 > https://github.com/apache/flink/pull/6181 > > > -- > Best regards / Met vriendelijke groeten, > > Niels Basjes >
Re: Please review FLINK-9610 Add Kafka partitioner that uses the key to partition by
I fixed the problem indicated in your comment and added an extra test for that. CI is currently running the tests. Niels On Tue, Jun 19, 2018 at 12:19 PM, Ted Yu wrote: > Interesting enhancement. > > I left a minor comment on the PR. > > Cheers > > On Tue, Jun 19, 2018 at 12:26 AM, Niels Basjes wrote: > > > Hi, > > > > Yesterday we ran into problems regarding the distribution of records > across > > Kafka where Flink was used as the producer. So we fixed this and realized > > that the code to do this would be useful to others. > > > > I put up a Jira ticket and pull request yesterday and it passes all > > automated tests. > > Please review. > > > > https://issues.apache.org/jira/browse/FLINK-9610 > > https://github.com/apache/flink/pull/6181 > > > > > > -- > > Best regards / Met vriendelijke groeten, > > > > Niels Basjes > > > -- Best regards / Met vriendelijke groeten, Niels Basjes
