RE: Maven and java version variables
Hi Matthias, That sounds reasonable, Kind regards, David From: Matthias Pohl Date: Monday, 23 October 2023 at 16:41 To: dev@flink.apache.org Subject: [EXTERNAL] Re: Maven and java version variables Hi David, The change that caused the conflict in your PR is caused by FLINK-33291 [1]. I was thinking about adding links to the comments to make the navigation to the corresponding resources easier as you rightfully mentioned. I didn't do it in the end because I was afraid that documentation might be moved in the future and those links wouldn't be valid anymore. That is why I tried to make the comments descriptive instead. But I agree: We could definitely do better with the documentation. ...especially (but not only) for CI. Best, Matthias [1] https://issues.apache.org/jira/browse/FLINK-33291 On Mon, Oct 23, 2023 at 2:53 PM Alexander Fedulov < alexander.fedu...@gmail.com> wrote: > (under "Prepare for the release") > > As for CI: > > https://github.com/apache/flink/blob/78b5ddb11dfd2a3a00b58079fe9ee29a80555988/tools/ci/maven-utils.sh#L84 > > https://github.com/apache/flink/blob/9b63099964b36ad9d78649bb6f5b39473e0031bd/tools/azure-pipelines/build-apache-repo.yml#L39 > > https://github.com/apache/flink/blob/9b63099964b36ad9d78649bb6f5b39473e0031bd/azure-pipelines.yml#L39 > > Best, > Alexander Fedulov > > > On Mon, 23 Oct 2023 at 14:44, Jing Ge wrote: > > > Hi David, > > > > Please check [1] in the section Verify Java and Maven Version. Thanks! > > > > Best regards, > > Jing > > > > > > [1] > > > https://cwiki.apache.org/confluence/display/FLINK/Creating+a+Flink+Release > > > > On Mon, Oct 23, 2023 at 1:25 PM David Radley > > wrote: > > > > > Hi, > > > > > > I have an open pr in the backlog that improves the pom.xml by > introducing > > > some Maven variables. The pr is > > https://github.com/apache/flink/pull/23469 > > > It has been reviewed but not merged. In the meantime another pom change > > > has been added that caused a conflict. I have amended the code in my pr > > to > > > implement the new logic, introducing a new java upper bounds version > > > variable. > > > I notice that the pom change that was added introduced this comment: > > > > > > > --> > > > > > > > > > > > > I am not sure what the CI setup means and where in the Flink Release > wiki > > > the java range is mentioned. It would be great if the comment could be > > > extended to include links to this information. I am happy to do that as > > > part of this pr , if needed, if I can be supplied the links. I think > > this > > > pr should be merged asap, so subsequent pom file changes use the Maven > > > variables. > > > > > > WDYT > > > > > > Kind regards, David. > > > > > > Unless otherwise stated above: > > > > > > IBM United Kingdom Limited > > > Registered in England and Wales with number 741598 > > > Registered office: PO Box 41, North Harbour, Portsmouth, Hants. PO6 3AU > > > > > > Unless otherwise stated above: IBM United Kingdom Limited Registered in England and Wales with number 741598 Registered office: PO Box 41, North Harbour, Portsmouth, Hants. PO6 3AU
Re: Maven and java version variables
Hi David, The change that caused the conflict in your PR is caused by FLINK-33291 [1]. I was thinking about adding links to the comments to make the navigation to the corresponding resources easier as you rightfully mentioned. I didn't do it in the end because I was afraid that documentation might be moved in the future and those links wouldn't be valid anymore. That is why I tried to make the comments descriptive instead. But I agree: We could definitely do better with the documentation. ...especially (but not only) for CI. Best, Matthias [1] https://issues.apache.org/jira/browse/FLINK-33291 On Mon, Oct 23, 2023 at 2:53 PM Alexander Fedulov < alexander.fedu...@gmail.com> wrote: > (under "Prepare for the release") > > As for CI: > > https://github.com/apache/flink/blob/78b5ddb11dfd2a3a00b58079fe9ee29a80555988/tools/ci/maven-utils.sh#L84 > > https://github.com/apache/flink/blob/9b63099964b36ad9d78649bb6f5b39473e0031bd/tools/azure-pipelines/build-apache-repo.yml#L39 > > https://github.com/apache/flink/blob/9b63099964b36ad9d78649bb6f5b39473e0031bd/azure-pipelines.yml#L39 > > Best, > Alexander Fedulov > > > On Mon, 23 Oct 2023 at 14:44, Jing Ge wrote: > > > Hi David, > > > > Please check [1] in the section Verify Java and Maven Version. Thanks! > > > > Best regards, > > Jing > > > > > > [1] > > > https://cwiki.apache.org/confluence/display/FLINK/Creating+a+Flink+Release > > > > On Mon, Oct 23, 2023 at 1:25 PM David Radley > > wrote: > > > > > Hi, > > > > > > I have an open pr in the backlog that improves the pom.xml by > introducing > > > some Maven variables. The pr is > > https://github.com/apache/flink/pull/23469 > > > It has been reviewed but not merged. In the meantime another pom change > > > has been added that caused a conflict. I have amended the code in my pr > > to > > > implement the new logic, introducing a new java upper bounds version > > > variable. > > > I notice that the pom change that was added introduced this comment: > > > > > > > --> > > > > > > > > > > > > I am not sure what the CI setup means and where in the Flink Release > wiki > > > the java range is mentioned. It would be great if the comment could be > > > extended to include links to this information. I am happy to do that as > > > part of this pr , if needed, if I can be supplied the links. I think > > this > > > pr should be merged asap, so subsequent pom file changes use the Maven > > > variables. > > > > > > WDYT > > > > > > Kind regards, David. > > > > > > Unless otherwise stated above: > > > > > > IBM United Kingdom Limited > > > Registered in England and Wales with number 741598 > > > Registered office: PO Box 41, North Harbour, Portsmouth, Hants. PO6 3AU > > > > > >
Re: Maven and java version variables
(under "Prepare for the release") As for CI: https://github.com/apache/flink/blob/78b5ddb11dfd2a3a00b58079fe9ee29a80555988/tools/ci/maven-utils.sh#L84 https://github.com/apache/flink/blob/9b63099964b36ad9d78649bb6f5b39473e0031bd/tools/azure-pipelines/build-apache-repo.yml#L39 https://github.com/apache/flink/blob/9b63099964b36ad9d78649bb6f5b39473e0031bd/azure-pipelines.yml#L39 Best, Alexander Fedulov On Mon, 23 Oct 2023 at 14:44, Jing Ge wrote: > Hi David, > > Please check [1] in the section Verify Java and Maven Version. Thanks! > > Best regards, > Jing > > > [1] > https://cwiki.apache.org/confluence/display/FLINK/Creating+a+Flink+Release > > On Mon, Oct 23, 2023 at 1:25 PM David Radley > wrote: > > > Hi, > > > > I have an open pr in the backlog that improves the pom.xml by introducing > > some Maven variables. The pr is > https://github.com/apache/flink/pull/23469 > > It has been reviewed but not merged. In the meantime another pom change > > has been added that caused a conflict. I have amended the code in my pr > to > > implement the new logic, introducing a new java upper bounds version > > variable. > > I notice that the pom change that was added introduced this comment: > > > > --> > > > > > > > > I am not sure what the CI setup means and where in the Flink Release wiki > > the java range is mentioned. It would be great if the comment could be > > extended to include links to this information. I am happy to do that as > > part of this pr , if needed, if I can be supplied the links. I think > this > > pr should be merged asap, so subsequent pom file changes use the Maven > > variables. > > > > WDYT > > > > Kind regards, David. > > > > Unless otherwise stated above: > > > > IBM United Kingdom Limited > > Registered in England and Wales with number 741598 > > Registered office: PO Box 41, North Harbour, Portsmouth, Hants. PO6 3AU > > >
Re: Maven and java version variables
Hi David, Please check [1] in the section Verify Java and Maven Version. Thanks! Best regards, Jing [1] https://cwiki.apache.org/confluence/display/FLINK/Creating+a+Flink+Release On Mon, Oct 23, 2023 at 1:25 PM David Radley wrote: > Hi, > > I have an open pr in the backlog that improves the pom.xml by introducing > some Maven variables. The pr is https://github.com/apache/flink/pull/23469 > It has been reviewed but not merged. In the meantime another pom change > has been added that caused a conflict. I have amended the code in my pr to > implement the new logic, introducing a new java upper bounds version > variable. > I notice that the pom change that was added introduced this comment: > > > > > > I am not sure what the CI setup means and where in the Flink Release wiki > the java range is mentioned. It would be great if the comment could be > extended to include links to this information. I am happy to do that as > part of this pr , if needed, if I can be supplied the links. I think this > pr should be merged asap, so subsequent pom file changes use the Maven > variables. > > WDYT > > Kind regards, David. > > Unless otherwise stated above: > > IBM United Kingdom Limited > Registered in England and Wales with number 741598 > Registered office: PO Box 41, North Harbour, Portsmouth, Hants. PO6 3AU >
