Re: [DISCUSS] Release flink-connector-parent v1.01
Thnx, +1 :) On Fri, Dec 22, 2023 at 10:15 AM Etienne Chauchot wrote: > > Thanks Max ! > > Etienne > > Le 21/12/2023 à 16:22, Maximilian Michels a écrit : > >> Anyone for pushing my pub key to apache dist ? > > Done. > > > > On Thu, Dec 21, 2023 at 2:36 PM Etienne Chauchot > > wrote: > >> Hello, > >> > >> All the ongoing PRs on this repo were merged. But, I'd like to leave > >> some more days until feature freeze in case someone had a feature ready > >> to integrate. > >> > >> Let' put the feature freeze to 00:00:00 UTC on December 27th. > >> > >> Best > >> > >> Etienne > >> > >> Le 15/12/2023 à 16:41, Ryan Skraba a écrit : > >>> Hello! I've been following this discussion (while looking and > >>> building a lot of the connectors): > >>> > >>> +1 (non-binding) to doing a 1.1.0 release adding the configurability > >>> of surefire and jvm flags. > >>> > >>> Thanks for driving this! > >>> > >>> Ryan > >>> > >>> On Fri, Dec 15, 2023 at 2:06 PM Etienne Chauchot > >>> wrote: > Hi PMC members, > > Version will be 1.1.0 and not 1.0.1 as one of the PMC members already > created this version tag in jira and tickets are targeted to this > version. > > Anyone for pushing my pub key to apache dist ? > > Thanks > > Etienne > > Le 14/12/2023 à 17:51, Etienne Chauchot a écrit : > > Hi all, > > > > It has been 2 weeks since the start of this release discussion. For > > now only Sergey agreed to release. On a lazy consensus basis, let's > > say that we leave until Monday for people to express concerns about > > releasing connector-parent. > > > > In the meantime, I'm doing my environment setup and I miss the rights > > to upload my GPG pub key to flink apache dist repo. Can one of the PMC > > members push it ? > > > > Joint to this email is the updated KEYS file with my pub key added. > > > > Thanks > > > > Best > > > > Etienne > > > > Le 05/12/2023 à 16:30, Etienne Chauchot a écrit : > >> Hi Péter, > >> > >> My answers are inline > >> > >> > >> Best > >> > >> Etienne > >> > >> > >> Le 05/12/2023 à 05:27, Péter Váry a écrit : > >>> Hi Etienne, > >>> > >>> Which branch would you cut the release from? > >> the parent_pom branch (consisting of a single maven pom file) > >>> I find the flink-connector-parent branches confusing. > >>> > >>> If I merge a PR to the ci_utils branch, would it immediately change > >>> the CI > >>> workflow of all of the connectors? > >> The ci_utils branch is basically one ci.yml workflow. _testing.yml > >> and maven test-project are both for testing the ci.yml workflow and > >> display what it can do to connector authors. > >> > >> As the connectors workflows refer ci.yml as this: > >> apache/flink-connector-shared-utils/.github/workflows/ci.yml@ci_utils, > >> if we merge changes to ci.yml all the CIs in the connectors' repo > >> will change. > >> > >>> If I merge something to the release_utils branch, would it immediately > >>> change the release process of all of the connectors? > >> I don't know how release-utils scripts are integrated with the > >> connectors' code yet > >>> I would like to add the possibility of creating Python packages for > >>> the > >>> connectors [1]. This would consist of some common code, which should > >>> reside > >>> in flink-connector-parent, like: > >>> - scripts for running Python test - test infra. I expect that this > >>> would > >>> evolve in time > >>> - ci workflow - this would be more slow moving, but might change if > >>> the > >>> infra is charging > >>> - release scripts - this would be slow moving, but might change too. > >>> > >>> I think we should have a release for all of the above components, so > >>> the > >>> connectors could move forward on their own pace. > >> I think it is quite out of the scope of this release: here we are > >> only talking about releasing a parent pom maven file for the > >> connectors. > >> > >>> What do you think? > >>> > >>> Thanks, > >>> Péter > >>> > >>> [1]https://issues.apache.org/jira/browse/FLINK-33528 > >>> > >>> On Thu, Nov 30, 2023, 16:55 Etienne Chauchot > >>> wrote: > >>> > Thanks Sergey for your vote. Indeed I have listed only the PRs merged > since last release but there are these 2 open PRs that could be worth > reviewing/merging before release. > > https://github.com/apache/flink-connector-shared-utils/pull/25 > > https://github.com/apache/flink-connector-shared-utils/pull/20 > > Best > > Etienne > > > Le 30/11/2023 à 11:12, Sergey Nuyanzin a écrit : > > thanks for volunt
Re: [DISCUSS] Release flink-connector-parent v1.01
Thanks Max ! Etienne Le 21/12/2023 à 16:22, Maximilian Michels a écrit : Anyone for pushing my pub key to apache dist ? Done. On Thu, Dec 21, 2023 at 2:36 PM Etienne Chauchot wrote: Hello, All the ongoing PRs on this repo were merged. But, I'd like to leave some more days until feature freeze in case someone had a feature ready to integrate. Let' put the feature freeze to 00:00:00 UTC on December 27th. Best Etienne Le 15/12/2023 à 16:41, Ryan Skraba a écrit : Hello! I've been following this discussion (while looking and building a lot of the connectors): +1 (non-binding) to doing a 1.1.0 release adding the configurability of surefire and jvm flags. Thanks for driving this! Ryan On Fri, Dec 15, 2023 at 2:06 PM Etienne Chauchot wrote: Hi PMC members, Version will be 1.1.0 and not 1.0.1 as one of the PMC members already created this version tag in jira and tickets are targeted to this version. Anyone for pushing my pub key to apache dist ? Thanks Etienne Le 14/12/2023 à 17:51, Etienne Chauchot a écrit : Hi all, It has been 2 weeks since the start of this release discussion. For now only Sergey agreed to release. On a lazy consensus basis, let's say that we leave until Monday for people to express concerns about releasing connector-parent. In the meantime, I'm doing my environment setup and I miss the rights to upload my GPG pub key to flink apache dist repo. Can one of the PMC members push it ? Joint to this email is the updated KEYS file with my pub key added. Thanks Best Etienne Le 05/12/2023 à 16:30, Etienne Chauchot a écrit : Hi Péter, My answers are inline Best Etienne Le 05/12/2023 à 05:27, Péter Váry a écrit : Hi Etienne, Which branch would you cut the release from? the parent_pom branch (consisting of a single maven pom file) I find the flink-connector-parent branches confusing. If I merge a PR to the ci_utils branch, would it immediately change the CI workflow of all of the connectors? The ci_utils branch is basically one ci.yml workflow. _testing.yml and maven test-project are both for testing the ci.yml workflow and display what it can do to connector authors. As the connectors workflows refer ci.yml as this: apache/flink-connector-shared-utils/.github/workflows/ci.yml@ci_utils, if we merge changes to ci.yml all the CIs in the connectors' repo will change. If I merge something to the release_utils branch, would it immediately change the release process of all of the connectors? I don't know how release-utils scripts are integrated with the connectors' code yet I would like to add the possibility of creating Python packages for the connectors [1]. This would consist of some common code, which should reside in flink-connector-parent, like: - scripts for running Python test - test infra. I expect that this would evolve in time - ci workflow - this would be more slow moving, but might change if the infra is charging - release scripts - this would be slow moving, but might change too. I think we should have a release for all of the above components, so the connectors could move forward on their own pace. I think it is quite out of the scope of this release: here we are only talking about releasing a parent pom maven file for the connectors. What do you think? Thanks, Péter [1]https://issues.apache.org/jira/browse/FLINK-33528 On Thu, Nov 30, 2023, 16:55 Etienne Chauchotwrote: Thanks Sergey for your vote. Indeed I have listed only the PRs merged since last release but there are these 2 open PRs that could be worth reviewing/merging before release. https://github.com/apache/flink-connector-shared-utils/pull/25 https://github.com/apache/flink-connector-shared-utils/pull/20 Best Etienne Le 30/11/2023 à 11:12, Sergey Nuyanzin a écrit : thanks for volunteering Etienne +1 for releasing however there is one more PR to enable custom jvm flags for connectors in similar way it is done in Flink main repo for modules It will simplify a bit support for java 17 could we have this as well in the coming release? On Wed, Nov 29, 2023 at 11:40 AM Etienne Chauchot wrote: Hi all, I would like to discuss making a v1.0.1 release of flink-connector-parent. Since last release, there were only 2 changes: -https://github.com/apache/flink-connector-shared-utils/pull/19 (spotless addition) -https://github.com/apache/flink-connector-shared-utils/pull/26 (surefire configuration) The new release would bring the ability to skip some tests in the connectors and among other things skip the archunit tests. It is important for connectors to skip archunit tests when tested against a version of Flink that changes the archunit rules leading to a change of the violation store. As there is only one violation store and the connector needs to be tested against last 2 minor Flink versions, only the version the connector was built against needs to run the archunit tests and have them reflected in the violation store. I volunteer to make the release. As it would
Re: [DISCUSS] Release flink-connector-parent v1.01
> Anyone for pushing my pub key to apache dist ? Done. On Thu, Dec 21, 2023 at 2:36 PM Etienne Chauchot wrote: > > Hello, > > All the ongoing PRs on this repo were merged. But, I'd like to leave > some more days until feature freeze in case someone had a feature ready > to integrate. > > Let' put the feature freeze to 00:00:00 UTC on December 27th. > > Best > > Etienne > > Le 15/12/2023 à 16:41, Ryan Skraba a écrit : > > Hello! I've been following this discussion (while looking and > > building a lot of the connectors): > > > > +1 (non-binding) to doing a 1.1.0 release adding the configurability > > of surefire and jvm flags. > > > > Thanks for driving this! > > > > Ryan > > > > On Fri, Dec 15, 2023 at 2:06 PM Etienne Chauchot > > wrote: > >> Hi PMC members, > >> > >> Version will be 1.1.0 and not 1.0.1 as one of the PMC members already > >> created this version tag in jira and tickets are targeted to this version. > >> > >> Anyone for pushing my pub key to apache dist ? > >> > >> Thanks > >> > >> Etienne > >> > >> Le 14/12/2023 à 17:51, Etienne Chauchot a écrit : > >>> Hi all, > >>> > >>> It has been 2 weeks since the start of this release discussion. For > >>> now only Sergey agreed to release. On a lazy consensus basis, let's > >>> say that we leave until Monday for people to express concerns about > >>> releasing connector-parent. > >>> > >>> In the meantime, I'm doing my environment setup and I miss the rights > >>> to upload my GPG pub key to flink apache dist repo. Can one of the PMC > >>> members push it ? > >>> > >>> Joint to this email is the updated KEYS file with my pub key added. > >>> > >>> Thanks > >>> > >>> Best > >>> > >>> Etienne > >>> > >>> Le 05/12/2023 à 16:30, Etienne Chauchot a écrit : > Hi Péter, > > My answers are inline > > > Best > > Etienne > > > Le 05/12/2023 à 05:27, Péter Váry a écrit : > > Hi Etienne, > > > > Which branch would you cut the release from? > the parent_pom branch (consisting of a single maven pom file) > > I find the flink-connector-parent branches confusing. > > > > If I merge a PR to the ci_utils branch, would it immediately change the > > CI > > workflow of all of the connectors? > The ci_utils branch is basically one ci.yml workflow. _testing.yml > and maven test-project are both for testing the ci.yml workflow and > display what it can do to connector authors. > > As the connectors workflows refer ci.yml as this: > apache/flink-connector-shared-utils/.github/workflows/ci.yml@ci_utils, > if we merge changes to ci.yml all the CIs in the connectors' repo > will change. > > > If I merge something to the release_utils branch, would it immediately > > change the release process of all of the connectors? > I don't know how release-utils scripts are integrated with the > connectors' code yet > > I would like to add the possibility of creating Python packages for the > > connectors [1]. This would consist of some common code, which should > > reside > > in flink-connector-parent, like: > > - scripts for running Python test - test infra. I expect that this would > > evolve in time > > - ci workflow - this would be more slow moving, but might change if the > > infra is charging > > - release scripts - this would be slow moving, but might change too. > > > > I think we should have a release for all of the above components, so the > > connectors could move forward on their own pace. > > I think it is quite out of the scope of this release: here we are > only talking about releasing a parent pom maven file for the connectors. > > > What do you think? > > > > Thanks, > > Péter > > > > [1]https://issues.apache.org/jira/browse/FLINK-33528 > > > > On Thu, Nov 30, 2023, 16:55 Etienne Chauchot > > wrote: > > > >> Thanks Sergey for your vote. Indeed I have listed only the PRs merged > >> since last release but there are these 2 open PRs that could be worth > >> reviewing/merging before release. > >> > >> https://github.com/apache/flink-connector-shared-utils/pull/25 > >> > >> https://github.com/apache/flink-connector-shared-utils/pull/20 > >> > >> Best > >> > >> Etienne > >> > >> > >> Le 30/11/2023 à 11:12, Sergey Nuyanzin a écrit : > >>> thanks for volunteering Etienne > >>> > >>> +1 for releasing > >>> however there is one more PR to enable custom jvm flags for connectors > >>> in similar way it is done in Flink main repo for modules > >>> It will simplify a bit support for java 17 > >>> > >>> could we have this as well in the coming release? > >>> > >>> > >>> > >>> On Wed, Nov 29, 2023 at 11:40 AM Etienne > >>> Chauchot > >>> wrote: > >>> > Hi all, > > I would li
Re: [DISCUSS] Release flink-connector-parent v1.01
Hello, All the ongoing PRs on this repo were merged. But, I'd like to leave some more days until feature freeze in case someone had a feature ready to integrate. Let' put the feature freeze to 00:00:00 UTC on December 27th. Best Etienne Le 15/12/2023 à 16:41, Ryan Skraba a écrit : Hello! I've been following this discussion (while looking and building a lot of the connectors): +1 (non-binding) to doing a 1.1.0 release adding the configurability of surefire and jvm flags. Thanks for driving this! Ryan On Fri, Dec 15, 2023 at 2:06 PM Etienne Chauchot wrote: Hi PMC members, Version will be 1.1.0 and not 1.0.1 as one of the PMC members already created this version tag in jira and tickets are targeted to this version. Anyone for pushing my pub key to apache dist ? Thanks Etienne Le 14/12/2023 à 17:51, Etienne Chauchot a écrit : Hi all, It has been 2 weeks since the start of this release discussion. For now only Sergey agreed to release. On a lazy consensus basis, let's say that we leave until Monday for people to express concerns about releasing connector-parent. In the meantime, I'm doing my environment setup and I miss the rights to upload my GPG pub key to flink apache dist repo. Can one of the PMC members push it ? Joint to this email is the updated KEYS file with my pub key added. Thanks Best Etienne Le 05/12/2023 à 16:30, Etienne Chauchot a écrit : Hi Péter, My answers are inline Best Etienne Le 05/12/2023 à 05:27, Péter Váry a écrit : Hi Etienne, Which branch would you cut the release from? the parent_pom branch (consisting of a single maven pom file) I find the flink-connector-parent branches confusing. If I merge a PR to the ci_utils branch, would it immediately change the CI workflow of all of the connectors? The ci_utils branch is basically one ci.yml workflow. _testing.yml and maven test-project are both for testing the ci.yml workflow and display what it can do to connector authors. As the connectors workflows refer ci.yml as this: apache/flink-connector-shared-utils/.github/workflows/ci.yml@ci_utils, if we merge changes to ci.yml all the CIs in the connectors' repo will change. If I merge something to the release_utils branch, would it immediately change the release process of all of the connectors? I don't know how release-utils scripts are integrated with the connectors' code yet I would like to add the possibility of creating Python packages for the connectors [1]. This would consist of some common code, which should reside in flink-connector-parent, like: - scripts for running Python test - test infra. I expect that this would evolve in time - ci workflow - this would be more slow moving, but might change if the infra is charging - release scripts - this would be slow moving, but might change too. I think we should have a release for all of the above components, so the connectors could move forward on their own pace. I think it is quite out of the scope of this release: here we are only talking about releasing a parent pom maven file for the connectors. What do you think? Thanks, Péter [1]https://issues.apache.org/jira/browse/FLINK-33528 On Thu, Nov 30, 2023, 16:55 Etienne Chauchot wrote: Thanks Sergey for your vote. Indeed I have listed only the PRs merged since last release but there are these 2 open PRs that could be worth reviewing/merging before release. https://github.com/apache/flink-connector-shared-utils/pull/25 https://github.com/apache/flink-connector-shared-utils/pull/20 Best Etienne Le 30/11/2023 à 11:12, Sergey Nuyanzin a écrit : thanks for volunteering Etienne +1 for releasing however there is one more PR to enable custom jvm flags for connectors in similar way it is done in Flink main repo for modules It will simplify a bit support for java 17 could we have this as well in the coming release? On Wed, Nov 29, 2023 at 11:40 AM Etienne Chauchot wrote: Hi all, I would like to discuss making a v1.0.1 release of flink-connector-parent. Since last release, there were only 2 changes: -https://github.com/apache/flink-connector-shared-utils/pull/19 (spotless addition) -https://github.com/apache/flink-connector-shared-utils/pull/26 (surefire configuration) The new release would bring the ability to skip some tests in the connectors and among other things skip the archunit tests. It is important for connectors to skip archunit tests when tested against a version of Flink that changes the archunit rules leading to a change of the violation store. As there is only one violation store and the connector needs to be tested against last 2 minor Flink versions, only the version the connector was built against needs to run the archunit tests and have them reflected in the violation store. I volunteer to make the release. As it would be my first ASF release, I might require the guidance of one of the PMC members. Best Etienne
Re: [DISCUSS] Release flink-connector-parent v1.01
Hello! I've been following this discussion (while looking and building a lot of the connectors): +1 (non-binding) to doing a 1.1.0 release adding the configurability of surefire and jvm flags. Thanks for driving this! Ryan On Fri, Dec 15, 2023 at 2:06 PM Etienne Chauchot wrote: > > Hi PMC members, > > Version will be 1.1.0 and not 1.0.1 as one of the PMC members already > created this version tag in jira and tickets are targeted to this version. > > Anyone for pushing my pub key to apache dist ? > > Thanks > > Etienne > > Le 14/12/2023 à 17:51, Etienne Chauchot a écrit : > > > > Hi all, > > > > It has been 2 weeks since the start of this release discussion. For > > now only Sergey agreed to release. On a lazy consensus basis, let's > > say that we leave until Monday for people to express concerns about > > releasing connector-parent. > > > > In the meantime, I'm doing my environment setup and I miss the rights > > to upload my GPG pub key to flink apache dist repo. Can one of the PMC > > members push it ? > > > > Joint to this email is the updated KEYS file with my pub key added. > > > > Thanks > > > > Best > > > > Etienne > > > > Le 05/12/2023 à 16:30, Etienne Chauchot a écrit : > >> > >> Hi Péter, > >> > >> My answers are inline > >> > >> > >> Best > >> > >> Etienne > >> > >> > >> Le 05/12/2023 à 05:27, Péter Váry a écrit : > >>> Hi Etienne, > >>> > >>> Which branch would you cut the release from? > >> the parent_pom branch (consisting of a single maven pom file) > >>> I find the flink-connector-parent branches confusing. > >>> > >>> If I merge a PR to the ci_utils branch, would it immediately change the CI > >>> workflow of all of the connectors? > >> > >> The ci_utils branch is basically one ci.yml workflow. _testing.yml > >> and maven test-project are both for testing the ci.yml workflow and > >> display what it can do to connector authors. > >> > >> As the connectors workflows refer ci.yml as this: > >> apache/flink-connector-shared-utils/.github/workflows/ci.yml@ci_utils, > >> if we merge changes to ci.yml all the CIs in the connectors' repo > >> will change. > >> > >>> If I merge something to the release_utils branch, would it immediately > >>> change the release process of all of the connectors? > >> I don't know how release-utils scripts are integrated with the > >> connectors' code yet > >>> I would like to add the possibility of creating Python packages for the > >>> connectors [1]. This would consist of some common code, which should > >>> reside > >>> in flink-connector-parent, like: > >>> - scripts for running Python test - test infra. I expect that this would > >>> evolve in time > >>> - ci workflow - this would be more slow moving, but might change if the > >>> infra is charging > >>> - release scripts - this would be slow moving, but might change too. > >>> > >>> I think we should have a release for all of the above components, so the > >>> connectors could move forward on their own pace. > >> > >> > >> I think it is quite out of the scope of this release: here we are > >> only talking about releasing a parent pom maven file for the connectors. > >> > >>> What do you think? > >>> > >>> Thanks, > >>> Péter > >>> > >>> [1]https://issues.apache.org/jira/browse/FLINK-33528 > >>> > >>> On Thu, Nov 30, 2023, 16:55 Etienne Chauchot wrote: > >>> > Thanks Sergey for your vote. Indeed I have listed only the PRs merged > since last release but there are these 2 open PRs that could be worth > reviewing/merging before release. > > https://github.com/apache/flink-connector-shared-utils/pull/25 > > https://github.com/apache/flink-connector-shared-utils/pull/20 > > Best > > Etienne > > > Le 30/11/2023 à 11:12, Sergey Nuyanzin a écrit : > > thanks for volunteering Etienne > > > > +1 for releasing > > however there is one more PR to enable custom jvm flags for connectors > > in similar way it is done in Flink main repo for modules > > It will simplify a bit support for java 17 > > > > could we have this as well in the coming release? > > > > > > > > On Wed, Nov 29, 2023 at 11:40 AM Etienne Chauchot > > wrote: > > > >> Hi all, > >> > >> I would like to discuss making a v1.0.1 release of > flink-connector-parent. > >> Since last release, there were only 2 changes: > >> > >> -https://github.com/apache/flink-connector-shared-utils/pull/19 > >> (spotless addition) > >> > >> -https://github.com/apache/flink-connector-shared-utils/pull/26 > >> (surefire configuration) > >> > >> The new release would bring the ability to skip some tests in the > >> connectors and among other things skip the archunit tests. It is > >> important for connectors to skip archunit tests when tested against a > >> version of Flink that changes the archunit rules leading to a change of > >> the violation store. As there is only one violati
Re: [DISCUSS] Release flink-connector-parent v1.01
Hi PMC members, Version will be 1.1.0 and not 1.0.1 as one of the PMC members already created this version tag in jira and tickets are targeted to this version. Anyone for pushing my pub key to apache dist ? Thanks Etienne Le 14/12/2023 à 17:51, Etienne Chauchot a écrit : Hi all, It has been 2 weeks since the start of this release discussion. For now only Sergey agreed to release. On a lazy consensus basis, let's say that we leave until Monday for people to express concerns about releasing connector-parent. In the meantime, I'm doing my environment setup and I miss the rights to upload my GPG pub key to flink apache dist repo. Can one of the PMC members push it ? Joint to this email is the updated KEYS file with my pub key added. Thanks Best Etienne Le 05/12/2023 à 16:30, Etienne Chauchot a écrit : Hi Péter, My answers are inline Best Etienne Le 05/12/2023 à 05:27, Péter Váry a écrit : Hi Etienne, Which branch would you cut the release from? the parent_pom branch (consisting of a single maven pom file) I find the flink-connector-parent branches confusing. If I merge a PR to the ci_utils branch, would it immediately change the CI workflow of all of the connectors? The ci_utils branch is basically one ci.yml workflow. _testing.yml and maven test-project are both for testing the ci.yml workflow and display what it can do to connector authors. As the connectors workflows refer ci.yml as this: apache/flink-connector-shared-utils/.github/workflows/ci.yml@ci_utils, if we merge changes to ci.yml all the CIs in the connectors' repo will change. If I merge something to the release_utils branch, would it immediately change the release process of all of the connectors? I don't know how release-utils scripts are integrated with the connectors' code yet I would like to add the possibility of creating Python packages for the connectors [1]. This would consist of some common code, which should reside in flink-connector-parent, like: - scripts for running Python test - test infra. I expect that this would evolve in time - ci workflow - this would be more slow moving, but might change if the infra is charging - release scripts - this would be slow moving, but might change too. I think we should have a release for all of the above components, so the connectors could move forward on their own pace. I think it is quite out of the scope of this release: here we are only talking about releasing a parent pom maven file for the connectors. What do you think? Thanks, Péter [1]https://issues.apache.org/jira/browse/FLINK-33528 On Thu, Nov 30, 2023, 16:55 Etienne Chauchot wrote: Thanks Sergey for your vote. Indeed I have listed only the PRs merged since last release but there are these 2 open PRs that could be worth reviewing/merging before release. https://github.com/apache/flink-connector-shared-utils/pull/25 https://github.com/apache/flink-connector-shared-utils/pull/20 Best Etienne Le 30/11/2023 à 11:12, Sergey Nuyanzin a écrit : thanks for volunteering Etienne +1 for releasing however there is one more PR to enable custom jvm flags for connectors in similar way it is done in Flink main repo for modules It will simplify a bit support for java 17 could we have this as well in the coming release? On Wed, Nov 29, 2023 at 11:40 AM Etienne Chauchot wrote: Hi all, I would like to discuss making a v1.0.1 release of flink-connector-parent. Since last release, there were only 2 changes: -https://github.com/apache/flink-connector-shared-utils/pull/19 (spotless addition) -https://github.com/apache/flink-connector-shared-utils/pull/26 (surefire configuration) The new release would bring the ability to skip some tests in the connectors and among other things skip the archunit tests. It is important for connectors to skip archunit tests when tested against a version of Flink that changes the archunit rules leading to a change of the violation store. As there is only one violation store and the connector needs to be tested against last 2 minor Flink versions, only the version the connector was built against needs to run the archunit tests and have them reflected in the violation store. I volunteer to make the release. As it would be my first ASF release, I might require the guidance of one of the PMC members. Best Etienne
Re: [DISCUSS] Release flink-connector-parent v1.01
Hi Péter, My answers are inline Best Etienne Le 05/12/2023 à 05:27, Péter Váry a écrit : Hi Etienne, Which branch would you cut the release from? the parent_pom branch (consisting of a single maven pom file) I find the flink-connector-parent branches confusing. If I merge a PR to the ci_utils branch, would it immediately change the CI workflow of all of the connectors? The ci_utils branch is basically one ci.yml workflow. _testing.yml and maven test-project are both for testing the ci.yml workflow and display what it can do to connector authors. As the connectors workflows refer ci.yml as this: apache/flink-connector-shared-utils/.github/workflows/ci.yml@ci_utils, if we merge changes to ci.yml all the CIs in the connectors' repo will change. If I merge something to the release_utils branch, would it immediately change the release process of all of the connectors? I don't know how release-utils scripts are integrated with the connectors' code yet I would like to add the possibility of creating Python packages for the connectors [1]. This would consist of some common code, which should reside in flink-connector-parent, like: - scripts for running Python test - test infra. I expect that this would evolve in time - ci workflow - this would be more slow moving, but might change if the infra is charging - release scripts - this would be slow moving, but might change too. I think we should have a release for all of the above components, so the connectors could move forward on their own pace. I think it is quite out of the scope of this release: here we are only talking about releasing a parent pom maven file for the connectors. What do you think? Thanks, Péter [1]https://issues.apache.org/jira/browse/FLINK-33528 On Thu, Nov 30, 2023, 16:55 Etienne Chauchot wrote: Thanks Sergey for your vote. Indeed I have listed only the PRs merged since last release but there are these 2 open PRs that could be worth reviewing/merging before release. https://github.com/apache/flink-connector-shared-utils/pull/25 https://github.com/apache/flink-connector-shared-utils/pull/20 Best Etienne Le 30/11/2023 à 11:12, Sergey Nuyanzin a écrit : thanks for volunteering Etienne +1 for releasing however there is one more PR to enable custom jvm flags for connectors in similar way it is done in Flink main repo for modules It will simplify a bit support for java 17 could we have this as well in the coming release? On Wed, Nov 29, 2023 at 11:40 AM Etienne Chauchot wrote: Hi all, I would like to discuss making a v1.0.1 release of flink-connector-parent. Since last release, there were only 2 changes: -https://github.com/apache/flink-connector-shared-utils/pull/19 (spotless addition) -https://github.com/apache/flink-connector-shared-utils/pull/26 (surefire configuration) The new release would bring the ability to skip some tests in the connectors and among other things skip the archunit tests. It is important for connectors to skip archunit tests when tested against a version of Flink that changes the archunit rules leading to a change of the violation store. As there is only one violation store and the connector needs to be tested against last 2 minor Flink versions, only the version the connector was built against needs to run the archunit tests and have them reflected in the violation store. I volunteer to make the release. As it would be my first ASF release, I might require the guidance of one of the PMC members. Best Etienne
Re: [DISCUSS] Release flink-connector-parent v1.01
Hi Etienne, Which branch would you cut the release from? I find the flink-connector-parent branches confusing. If I merge a PR to the ci_utils branch, would it immediately change the CI workflow of all of the connectors? If I merge something to the release_utils branch, would it immediately change the release process of all of the connectors? I would like to add the possibility of creating Python packages for the connectors [1]. This would consist of some common code, which should reside in flink-connector-parent, like: - scripts for running Python test - test infra. I expect that this would evolve in time - ci workflow - this would be more slow moving, but might change if the infra is charging - release scripts - this would be slow moving, but might change too. I think we should have a release for all of the above components, so the connectors could move forward on their own pace. What do you think? Thanks, Péter [1] https://issues.apache.org/jira/browse/FLINK-33528 On Thu, Nov 30, 2023, 16:55 Etienne Chauchot wrote: > Thanks Sergey for your vote. Indeed I have listed only the PRs merged > since last release but there are these 2 open PRs that could be worth > reviewing/merging before release. > > https://github.com/apache/flink-connector-shared-utils/pull/25 > > https://github.com/apache/flink-connector-shared-utils/pull/20 > > Best > > Etienne > > > Le 30/11/2023 à 11:12, Sergey Nuyanzin a écrit : > > thanks for volunteering Etienne > > > > +1 for releasing > > however there is one more PR to enable custom jvm flags for connectors > > in similar way it is done in Flink main repo for modules > > It will simplify a bit support for java 17 > > > > could we have this as well in the coming release? > > > > > > > > On Wed, Nov 29, 2023 at 11:40 AM Etienne Chauchot > > wrote: > > > >> Hi all, > >> > >> I would like to discuss making a v1.0.1 release of > flink-connector-parent. > >> > >> Since last release, there were only 2 changes: > >> > >> -https://github.com/apache/flink-connector-shared-utils/pull/19 > >> (spotless addition) > >> > >> -https://github.com/apache/flink-connector-shared-utils/pull/26 > >> (surefire configuration) > >> > >> The new release would bring the ability to skip some tests in the > >> connectors and among other things skip the archunit tests. It is > >> important for connectors to skip archunit tests when tested against a > >> version of Flink that changes the archunit rules leading to a change of > >> the violation store. As there is only one violation store and the > >> connector needs to be tested against last 2 minor Flink versions, only > >> the version the connector was built against needs to run the archunit > >> tests and have them reflected in the violation store. > >> > >> > >> I volunteer to make the release. As it would be my first ASF release, I > >> might require the guidance of one of the PMC members. > >> > >> > >> Best > >> > >> Etienne > >> > >> > >> > >> > >>
Re: [DISCUSS] Release flink-connector-parent v1.01
Thanks Sergey for your vote. Indeed I have listed only the PRs merged since last release but there are these 2 open PRs that could be worth reviewing/merging before release. https://github.com/apache/flink-connector-shared-utils/pull/25 https://github.com/apache/flink-connector-shared-utils/pull/20 Best Etienne Le 30/11/2023 à 11:12, Sergey Nuyanzin a écrit : thanks for volunteering Etienne +1 for releasing however there is one more PR to enable custom jvm flags for connectors in similar way it is done in Flink main repo for modules It will simplify a bit support for java 17 could we have this as well in the coming release? On Wed, Nov 29, 2023 at 11:40 AM Etienne Chauchot wrote: Hi all, I would like to discuss making a v1.0.1 release of flink-connector-parent. Since last release, there were only 2 changes: -https://github.com/apache/flink-connector-shared-utils/pull/19 (spotless addition) -https://github.com/apache/flink-connector-shared-utils/pull/26 (surefire configuration) The new release would bring the ability to skip some tests in the connectors and among other things skip the archunit tests. It is important for connectors to skip archunit tests when tested against a version of Flink that changes the archunit rules leading to a change of the violation store. As there is only one violation store and the connector needs to be tested against last 2 minor Flink versions, only the version the connector was built against needs to run the archunit tests and have them reflected in the violation store. I volunteer to make the release. As it would be my first ASF release, I might require the guidance of one of the PMC members. Best Etienne
Re: [DISCUSS] Release flink-connector-parent v1.01
thanks for volunteering Etienne +1 for releasing however there is one more PR to enable custom jvm flags for connectors in similar way it is done in Flink main repo for modules It will simplify a bit support for java 17 could we have this as well in the coming release? On Wed, Nov 29, 2023 at 11:40 AM Etienne Chauchot wrote: > Hi all, > > I would like to discuss making a v1.0.1 release of flink-connector-parent. > > Since last release, there were only 2 changes: > > - https://github.com/apache/flink-connector-shared-utils/pull/19 > (spotless addition) > > - https://github.com/apache/flink-connector-shared-utils/pull/26 > (surefire configuration) > > The new release would bring the ability to skip some tests in the > connectors and among other things skip the archunit tests. It is > important for connectors to skip archunit tests when tested against a > version of Flink that changes the archunit rules leading to a change of > the violation store. As there is only one violation store and the > connector needs to be tested against last 2 minor Flink versions, only > the version the connector was built against needs to run the archunit > tests and have them reflected in the violation store. > > > I volunteer to make the release. As it would be my first ASF release, I > might require the guidance of one of the PMC members. > > > Best > > Etienne > > > > > -- Best regards, Sergey
