Re: [DISCUSS] TableAPI renaming toTable

2015-06-05 Thread Stephan Ewen
Great!

On Fri, Jun 5, 2015 at 10:24 AM, Aljoscha Krettek aljos...@apache.org
wrote:

 Of course, everything that doesn't need windows is supported.

 On Fri, Jun 5, 2015 at 10:21 AM, Robert Metzger rmetz...@apache.org
 wrote:
  +1
 
  I didn't know that the Table API supports DataStreams as well.
 
  On Fri, Jun 5, 2015 at 10:18 AM, Aljoscha Krettek aljos...@apache.org
  wrote:
 
  +1, then we would of course also rename the other one to
 fromDataStream.
 
  On Fri, Jun 5, 2015 at 10:13 AM, Fabian Hueske fhue...@gmail.com
 wrote:
   Hi folks,
  
   I thought about renaming the TableEnvironment.toTable() method to
   TableEnvironment.fromDataSet().
   This would be closer to SQL FROM and allow to add other methods like
   fromCSV(), fromHCat(), fromParquet(), fromORC(), etc.
  
   If we decide for the renaming, we should do it before the release.
  
   Cheers, Fabian
 



Re: [DISCUSS] TableAPI renaming toTable

2015-06-05 Thread Aljoscha Krettek
Of course, everything that doesn't need windows is supported.

On Fri, Jun 5, 2015 at 10:21 AM, Robert Metzger rmetz...@apache.org wrote:
 +1

 I didn't know that the Table API supports DataStreams as well.

 On Fri, Jun 5, 2015 at 10:18 AM, Aljoscha Krettek aljos...@apache.org
 wrote:

 +1, then we would of course also rename the other one to fromDataStream.

 On Fri, Jun 5, 2015 at 10:13 AM, Fabian Hueske fhue...@gmail.com wrote:
  Hi folks,
 
  I thought about renaming the TableEnvironment.toTable() method to
  TableEnvironment.fromDataSet().
  This would be closer to SQL FROM and allow to add other methods like
  fromCSV(), fromHCat(), fromParquet(), fromORC(), etc.
 
  If we decide for the renaming, we should do it before the release.
 
  Cheers, Fabian