Re: [VOTE] FLIP-372: Allow TwoPhaseCommittingSink WithPreCommitTopology to alter the type of the Committable
+1 (binding) looks good to me overall thank you for revising the FLIP and continuing to drive the decision, Peter! On Wed, Dec 27, 2023 at 7:16 AM Martijn Visser wrote: > Hi Peter, > > It would be good if Gordon can take a look, but overall this looks good to > me +1 > > Best regards, > > Martijn > > On Fri, Dec 22, 2023 at 8:25 AM Péter Váry > wrote: > > > > We have enough votes for the decision, but given that this is an > important > > change, and for many of us it is a holiday season, I plan to keep this > vote > > open until the 3rd of January. This way, if anyone else has comments and > > suggestions then they have time to raise them. > > > > Thanks everyone for the votes, and Leonard for the useful suggestions! > > > > Happy holidays everyone! > > > > Peter > > > > On Thu, Dec 21, 2023, 11:23 Leonard Xu wrote: > > > > > Thanks Peter for quick response and update. > > > > > > I’ve no more comments on the updated FLIP, +1. > > > > > > For the PR process, you could alsouse draft PR[1] to leverage the > testing > > > infra during POC phase, > > > we usually create FLIP umbrella issue and subtask issues after the > FLIP is > > > accepted. > > > > > > > > > Best, > > > Leonard > > > [1]https://github.com/apache/flink/pulls?q=is%3Apr+is%3Aopen+draft > > > > > > > > > > > > > > > >> > > > >> > > > >> Best, > > > >> Leonard > > > >> > > > >> > > > >> > > > >>> 2023年12月21日 上午11:47，Jiabao Sun > 写道： > > > >>> > > > >>> Thanks Peter for driving this. > > > >>> > > > >>> +1 (non-binding) > > > >>> > > > >>> Best, > > > >>> Jiabao > > > >>> > > > >>> > > > >>> On 2023/12/18 12:06:05 Gyula Fóra wrote: > > > +1 (binding) > > > > > > Gyula > > > > > > On Mon, 18 Dec 2023 at 13:04, Márton Balassi > > > wrote: > > > > > > > +1 (binding) > > > > > > > > On Mon 18. Dec 2023 at 09:34, Péter Váry > > > > wrote: > > > > > > > >> Hi everyone, > > > >> > > > >> Since there were no further comments on the discussion thread > [1], I > > > > would > > > >> like to start the vote for FLIP-372 [2]. > > > >> > > > >> The FLIP started as a small new feature, but in the discussion > > > thread > > > >> and > > > >> in a similar parallel thread [3] we opted for a somewhat bigger > > > >> change in > > > >> the Sink V2 API. > > > >> > > > >> Please read the FLIP and cast your vote. > > > >> > > > >> The vote will remain open for at least 72 hours and only > concluded > > > if > > > > there > > > >> are no objections and enough (i.e. at least 3) binding votes. > > > >> > > > >> Thanks, > > > >> Peter > > > >> > > > >> [1] - > > > >> https://lists.apache.org/thread/344pzbrqbbb4w0sfj67km25msp7hxlyd > > > >> [2] - > > > >> > > > >> > > > > > > > >> > > > > https://cwiki.apache.org/confluence/display/FLINK/FLIP-372%3A+Allow+TwoPhaseCommittingSink+WithPreCommitTopology+to+alter+the+type+of+the+Committable > > > >> [3] - > > > >> https://lists.apache.org/thread/h6nkgth838dlh5s90sd95zd6hlsxwx57 > > > >> > > > > > > > >> > > > >> > > > > > > >
Re: [VOTE] FLIP-372: Allow TwoPhaseCommittingSink WithPreCommitTopology to alter the type of the Committable
Hi Peter, It would be good if Gordon can take a look, but overall this looks good to me +1 Best regards, Martijn On Fri, Dec 22, 2023 at 8:25 AM Péter Váry wrote: > > We have enough votes for the decision, but given that this is an important > change, and for many of us it is a holiday season, I plan to keep this vote > open until the 3rd of January. This way, if anyone else has comments and > suggestions then they have time to raise them. > > Thanks everyone for the votes, and Leonard for the useful suggestions! > > Happy holidays everyone! > > Peter > > On Thu, Dec 21, 2023, 11:23 Leonard Xu wrote: > > > Thanks Peter for quick response and update. > > > > I’ve no more comments on the updated FLIP, +1. > > > > For the PR process, you could alsouse draft PR[1] to leverage the testing > > infra during POC phase, > > we usually create FLIP umbrella issue and subtask issues after the FLIP is > > accepted. > > > > > > Best, > > Leonard > > [1]https://github.com/apache/flink/pulls?q=is%3Apr+is%3Aopen+draft > > > > > > > > > > >> > > >> > > >> Best, > > >> Leonard > > >> > > >> > > >> > > >>> 2023年12月21日 上午11:47，Jiabao Sun 写道： > > >>> > > >>> Thanks Peter for driving this. > > >>> > > >>> +1 (non-binding) > > >>> > > >>> Best, > > >>> Jiabao > > >>> > > >>> > > >>> On 2023/12/18 12:06:05 Gyula Fóra wrote: > > +1 (binding) > > > > Gyula > > > > On Mon, 18 Dec 2023 at 13:04, Márton Balassi > > wrote: > > > > > +1 (binding) > > > > > > On Mon 18. Dec 2023 at 09:34, Péter Váry > > > wrote: > > > > > >> Hi everyone, > > >> > > >> Since there were no further comments on the discussion thread [1], I > > > would > > >> like to start the vote for FLIP-372 [2]. > > >> > > >> The FLIP started as a small new feature, but in the discussion > > thread > > >> and > > >> in a similar parallel thread [3] we opted for a somewhat bigger > > >> change in > > >> the Sink V2 API. > > >> > > >> Please read the FLIP and cast your vote. > > >> > > >> The vote will remain open for at least 72 hours and only concluded > > if > > > there > > >> are no objections and enough (i.e. at least 3) binding votes. > > >> > > >> Thanks, > > >> Peter > > >> > > >> [1] - > > >> https://lists.apache.org/thread/344pzbrqbbb4w0sfj67km25msp7hxlyd > > >> [2] - > > >> > > >> > > > > > >> > > https://cwiki.apache.org/confluence/display/FLINK/FLIP-372%3A+Allow+TwoPhaseCommittingSink+WithPreCommitTopology+to+alter+the+type+of+the+Committable > > >> [3] - > > >> https://lists.apache.org/thread/h6nkgth838dlh5s90sd95zd6hlsxwx57 > > >> > > > > > >> > > >> > > > >
Re: [VOTE] FLIP-372: Allow TwoPhaseCommittingSink WithPreCommitTopology to alter the type of the Committable
We have enough votes for the decision, but given that this is an important change, and for many of us it is a holiday season, I plan to keep this vote open until the 3rd of January. This way, if anyone else has comments and suggestions then they have time to raise them. Thanks everyone for the votes, and Leonard for the useful suggestions! Happy holidays everyone! Peter On Thu, Dec 21, 2023, 11:23 Leonard Xu wrote: > Thanks Peter for quick response and update. > > I’ve no more comments on the updated FLIP, +1. > > For the PR process, you could alsouse draft PR[1] to leverage the testing > infra during POC phase, > we usually create FLIP umbrella issue and subtask issues after the FLIP is > accepted. > > > Best, > Leonard > [1]https://github.com/apache/flink/pulls?q=is%3Apr+is%3Aopen+draft > > > > > >> > >> > >> Best, > >> Leonard > >> > >> > >> > >>> 2023年12月21日 上午11:47，Jiabao Sun 写道： > >>> > >>> Thanks Peter for driving this. > >>> > >>> +1 (non-binding) > >>> > >>> Best, > >>> Jiabao > >>> > >>> > >>> On 2023/12/18 12:06:05 Gyula Fóra wrote: > +1 (binding) > > Gyula > > On Mon, 18 Dec 2023 at 13:04, Márton Balassi > wrote: > > > +1 (binding) > > > > On Mon 18. Dec 2023 at 09:34, Péter Váry > > wrote: > > > >> Hi everyone, > >> > >> Since there were no further comments on the discussion thread [1], I > > would > >> like to start the vote for FLIP-372 [2]. > >> > >> The FLIP started as a small new feature, but in the discussion > thread > >> and > >> in a similar parallel thread [3] we opted for a somewhat bigger > >> change in > >> the Sink V2 API. > >> > >> Please read the FLIP and cast your vote. > >> > >> The vote will remain open for at least 72 hours and only concluded > if > > there > >> are no objections and enough (i.e. at least 3) binding votes. > >> > >> Thanks, > >> Peter > >> > >> [1] - > >> https://lists.apache.org/thread/344pzbrqbbb4w0sfj67km25msp7hxlyd > >> [2] - > >> > >> > > > >> > https://cwiki.apache.org/confluence/display/FLINK/FLIP-372%3A+Allow+TwoPhaseCommittingSink+WithPreCommitTopology+to+alter+the+type+of+the+Committable > >> [3] - > >> https://lists.apache.org/thread/h6nkgth838dlh5s90sd95zd6hlsxwx57 > >> > > > >> > >> > >
Re: [VOTE] FLIP-372: Allow TwoPhaseCommittingSink WithPreCommitTopology to alter the type of the Committable
Thanks Peter for quick response and update. I’ve no more comments on the updated FLIP, +1. For the PR process, you could alsouse draft PR[1] to leverage the testing infra during POC phase, we usually create FLIP umbrella issue and subtask issues after the FLIP is accepted. Best, Leonard [1]https://github.com/apache/flink/pulls?q=is%3Apr+is%3Aopen+draft >> >> >> Best, >> Leonard >> >> >> >>> 2023年12月21日 上午11:47，Jiabao Sun 写道： >>> >>> Thanks Peter for driving this. >>> >>> +1 (non-binding) >>> >>> Best, >>> Jiabao >>> >>> >>> On 2023/12/18 12:06:05 Gyula Fóra wrote: +1 (binding) Gyula On Mon, 18 Dec 2023 at 13:04, Márton Balassi wrote: > +1 (binding) > > On Mon 18. Dec 2023 at 09:34, Péter Váry > wrote: > >> Hi everyone, >> >> Since there were no further comments on the discussion thread [1], I > would >> like to start the vote for FLIP-372 [2]. >> >> The FLIP started as a small new feature, but in the discussion thread >> and >> in a similar parallel thread [3] we opted for a somewhat bigger >> change in >> the Sink V2 API. >> >> Please read the FLIP and cast your vote. >> >> The vote will remain open for at least 72 hours and only concluded if > there >> are no objections and enough (i.e. at least 3) binding votes. >> >> Thanks, >> Peter >> >> [1] - >> https://lists.apache.org/thread/344pzbrqbbb4w0sfj67km25msp7hxlyd >> [2] - >> >> > >> https://cwiki.apache.org/confluence/display/FLINK/FLIP-372%3A+Allow+TwoPhaseCommittingSink+WithPreCommitTopology+to+alter+the+type+of+the+Committable >> [3] - >> https://lists.apache.org/thread/h6nkgth838dlh5s90sd95zd6hlsxwx57 >> > >> >>
Re: [VOTE] FLIP-372: Allow TwoPhaseCommittingSink WithPreCommitTopology to alter the type of the Committable
Thanks Leonard for the review! See my answers below: Leonard Xu ezt írta (időpont: 2023. dec. 21., Cs, 9:00): > Thanks Peter for driving this. > > The FLIP change is a big improvement of the existing sink v2 interfaces, > but the FLIP's overall API design taste and interface style looks good to > me. > > +1(binding) from my side. > > I also left a little minor comments we can improve later. > (1) The FLIP title dosen't cover the proposed change scope well, right? > Renamed to `Enhance and synchronize Sink API to match the Source API` > (2) The pseudocode filename of StatefulSinkWriter has a typo. > Fixed > (3) I’ve found you’ve open a PR in Github, we’d better create issue and > prepare a formal PR > until the FLIP passed instead of discussion status. > I used the PR to make sure that the implementation adds up. During my previous FLIP, I have found that while some of the ideas look good in a doc, the code disagrees. Flink has a quite good testing coverage, and helped me identify some of the issues. Also for this kind of changes for some developers it is easier to see the code than reading the doc. Definitely will start the review process of the PR without a proper jira and until the FLIP is accepted. > > > Best, > Leonard > > > > > 2023年12月21日 上午11:47，Jiabao Sun 写道： > > > > Thanks Peter for driving this. > > > > +1 (non-binding) > > > > Best, > > Jiabao > > > > > > On 2023/12/18 12:06:05 Gyula Fóra wrote: > >> +1 (binding) > >> > >> Gyula > >> > >> On Mon, 18 Dec 2023 at 13:04, Márton Balassi > >> wrote: > >> > >>> +1 (binding) > >>> > >>> On Mon 18. Dec 2023 at 09:34, Péter Váry > >>> wrote: > >>> > Hi everyone, > > Since there were no further comments on the discussion thread [1], I > >>> would > like to start the vote for FLIP-372 [2]. > > The FLIP started as a small new feature, but in the discussion thread > and > in a similar parallel thread [3] we opted for a somewhat bigger > change in > the Sink V2 API. > > Please read the FLIP and cast your vote. > > The vote will remain open for at least 72 hours and only concluded if > >>> there > are no objections and enough (i.e. at least 3) binding votes. > > Thanks, > Peter > > [1] - > https://lists.apache.org/thread/344pzbrqbbb4w0sfj67km25msp7hxlyd > [2] - > > > >>> > https://cwiki.apache.org/confluence/display/FLINK/FLIP-372%3A+Allow+TwoPhaseCommittingSink+WithPreCommitTopology+to+alter+the+type+of+the+Committable > [3] - > https://lists.apache.org/thread/h6nkgth838dlh5s90sd95zd6hlsxwx57 > > >>> > >
Re: [VOTE] FLIP-372: Allow TwoPhaseCommittingSink WithPreCommitTopology to alter the type of the Committable
Thanks Peter for driving this. The FLIP change is a big improvement of the existing sink v2 interfaces, but the FLIP's overall API design taste and interface style looks good to me. +1(binding) from my side. I also left a little minor comments we can improve later. (1) The FLIP title dosen't cover the proposed change scope well, right? (2) The pseudocode filename of StatefulSinkWriter has a typo. (3) I’ve found you’ve open a PR in Github, we’d better create issue and prepare a formal PR until the FLIP passed instead of discussion status. Best, Leonard > 2023年12月21日 上午11:47，Jiabao Sun 写道： > > Thanks Peter for driving this. > > +1 (non-binding) > > Best, > Jiabao > > > On 2023/12/18 12:06:05 Gyula Fóra wrote: >> +1 (binding) >> >> Gyula >> >> On Mon, 18 Dec 2023 at 13:04, Márton Balassi >> wrote: >> >>> +1 (binding) >>> >>> On Mon 18. Dec 2023 at 09:34, Péter Váry >>> wrote: >>> Hi everyone, Since there were no further comments on the discussion thread [1], I >>> would like to start the vote for FLIP-372 [2]. The FLIP started as a small new feature, but in the discussion thread and in a similar parallel thread [3] we opted for a somewhat bigger change in the Sink V2 API. Please read the FLIP and cast your vote. The vote will remain open for at least 72 hours and only concluded if >>> there are no objections and enough (i.e. at least 3) binding votes. Thanks, Peter [1] - https://lists.apache.org/thread/344pzbrqbbb4w0sfj67km25msp7hxlyd [2] - >>> https://cwiki.apache.org/confluence/display/FLINK/FLIP-372%3A+Allow+TwoPhaseCommittingSink+WithPreCommitTopology+to+alter+the+type+of+the+Committable [3] - https://lists.apache.org/thread/h6nkgth838dlh5s90sd95zd6hlsxwx57 >>>
Re: Re: [VOTE] FLIP-372: Allow TwoPhaseCommittingSink WithPreCommitTopology to alter the type of the Committable
Thanks for the FLIP. +1 (non-binding) Best, Hang Jiabao Sun 于2023年12月21日周四 11:48写道： > Thanks Peter for driving this. > > +1 (non-binding) > > Best, > Jiabao > > > On 2023/12/18 12:06:05 Gyula Fóra wrote: > > +1 (binding) > > > > Gyula > > > > On Mon, 18 Dec 2023 at 13:04, Márton Balassi > > wrote: > > > > > +1 (binding) > > > > > > On Mon 18. Dec 2023 at 09:34, Péter Váry > > > wrote: > > > > > > > Hi everyone, > > > > > > > > Since there were no further comments on the discussion thread [1], I > > > would > > > > like to start the vote for FLIP-372 [2]. > > > > > > > > The FLIP started as a small new feature, but in the discussion > thread and > > > > in a similar parallel thread [3] we opted for a somewhat bigger > change in > > > > the Sink V2 API. > > > > > > > > Please read the FLIP and cast your vote. > > > > > > > > The vote will remain open for at least 72 hours and only concluded if > > > there > > > > are no objections and enough (i.e. at least 3) binding votes. > > > > > > > > Thanks, > > > > Peter > > > > > > > > [1] - > https://lists.apache.org/thread/344pzbrqbbb4w0sfj67km25msp7hxlyd > > > > [2] - > > > > > > > > > > > > https://cwiki.apache.org/confluence/display/FLINK/FLIP-372%3A+Allow+TwoPhaseCommittingSink+WithPreCommitTopology+to+alter+the+type+of+the+Committable > > > > [3] - > https://lists.apache.org/thread/h6nkgth838dlh5s90sd95zd6hlsxwx57 > > > > > > > > >
RE: Re: [VOTE] FLIP-372: Allow TwoPhaseCommittingSink WithPreCommitTopology to alter the type of the Committable
Thanks Peter for driving this. +1 (non-binding) Best, Jiabao On 2023/12/18 12:06:05 Gyula Fóra wrote: > +1 (binding) > > Gyula > > On Mon, 18 Dec 2023 at 13:04, Márton Balassi > wrote: > > > +1 (binding) > > > > On Mon 18. Dec 2023 at 09:34, Péter Váry > > wrote: > > > > > Hi everyone, > > > > > > Since there were no further comments on the discussion thread [1], I > > would > > > like to start the vote for FLIP-372 [2]. > > > > > > The FLIP started as a small new feature, but in the discussion thread and > > > in a similar parallel thread [3] we opted for a somewhat bigger change in > > > the Sink V2 API. > > > > > > Please read the FLIP and cast your vote. > > > > > > The vote will remain open for at least 72 hours and only concluded if > > there > > > are no objections and enough (i.e. at least 3) binding votes. > > > > > > Thanks, > > > Peter > > > > > > [1] - https://lists.apache.org/thread/344pzbrqbbb4w0sfj67km25msp7hxlyd > > > [2] - > > > > > > > > https://cwiki.apache.org/confluence/display/FLINK/FLIP-372%3A+Allow+TwoPhaseCommittingSink+WithPreCommitTopology+to+alter+the+type+of+the+Committable > > > [3] - https://lists.apache.org/thread/h6nkgth838dlh5s90sd95zd6hlsxwx57 > > > > > >
Re: [VOTE] FLIP-372: Allow TwoPhaseCommittingSink WithPreCommitTopology to alter the type of the Committable
+1 (non-binding) Merging multiple write results into one submission is a common scenario we encounter. But in the process of implementing the addPreCommitTopology, I feel that the logic of regenerating CommittableSummary objects is a bit hidden. Best, Yanquan Lv. Péter Váry 于2023年12月18日周一 16:35写道： > Hi everyone, > > Since there were no further comments on the discussion thread [1], I would > like to start the vote for FLIP-372 [2]. > > The FLIP started as a small new feature, but in the discussion thread and > in a similar parallel thread [3] we opted for a somewhat bigger change in > the Sink V2 API. > > Please read the FLIP and cast your vote. > > The vote will remain open for at least 72 hours and only concluded if there > are no objections and enough (i.e. at least 3) binding votes. > > Thanks, > Peter > > [1] - https://lists.apache.org/thread/344pzbrqbbb4w0sfj67km25msp7hxlyd > [2] - > > https://cwiki.apache.org/confluence/display/FLINK/FLIP-372%3A+Allow+TwoPhaseCommittingSink+WithPreCommitTopology+to+alter+the+type+of+the+Committable > [3] - https://lists.apache.org/thread/h6nkgth838dlh5s90sd95zd6hlsxwx57 >
Re: [VOTE] FLIP-372: Allow TwoPhaseCommittingSink WithPreCommitTopology to alter the type of the Committable
+1 (binding) G On Mon, Dec 18, 2023 at 9:34 AM Péter Váry wrote: > Hi everyone, > > Since there were no further comments on the discussion thread [1], I would > like to start the vote for FLIP-372 [2]. > > The FLIP started as a small new feature, but in the discussion thread and > in a similar parallel thread [3] we opted for a somewhat bigger change in > the Sink V2 API. > > Please read the FLIP and cast your vote. > > The vote will remain open for at least 72 hours and only concluded if there > are no objections and enough (i.e. at least 3) binding votes. > > Thanks, > Peter > > [1] - https://lists.apache.org/thread/344pzbrqbbb4w0sfj67km25msp7hxlyd > [2] - > > https://cwiki.apache.org/confluence/display/FLINK/FLIP-372%3A+Allow+TwoPhaseCommittingSink+WithPreCommitTopology+to+alter+the+type+of+the+Committable > [3] - https://lists.apache.org/thread/h6nkgth838dlh5s90sd95zd6hlsxwx57 >
Re: [VOTE] FLIP-372: Allow TwoPhaseCommittingSink WithPreCommitTopology to alter the type of the Committable
+1 (binding) Gyula On Mon, 18 Dec 2023 at 13:04, Márton Balassi wrote: > +1 (binding) > > On Mon 18. Dec 2023 at 09:34, Péter Váry > wrote: > > > Hi everyone, > > > > Since there were no further comments on the discussion thread [1], I > would > > like to start the vote for FLIP-372 [2]. > > > > The FLIP started as a small new feature, but in the discussion thread and > > in a similar parallel thread [3] we opted for a somewhat bigger change in > > the Sink V2 API. > > > > Please read the FLIP and cast your vote. > > > > The vote will remain open for at least 72 hours and only concluded if > there > > are no objections and enough (i.e. at least 3) binding votes. > > > > Thanks, > > Peter > > > > [1] - https://lists.apache.org/thread/344pzbrqbbb4w0sfj67km25msp7hxlyd > > [2] - > > > > > https://cwiki.apache.org/confluence/display/FLINK/FLIP-372%3A+Allow+TwoPhaseCommittingSink+WithPreCommitTopology+to+alter+the+type+of+the+Committable > > [3] - https://lists.apache.org/thread/h6nkgth838dlh5s90sd95zd6hlsxwx57 > > >
Re: [VOTE] FLIP-372: Allow TwoPhaseCommittingSink WithPreCommitTopology to alter the type of the Committable
+1 (binding) On Mon 18. Dec 2023 at 09:34, Péter Váry wrote: > Hi everyone, > > Since there were no further comments on the discussion thread [1], I would > like to start the vote for FLIP-372 [2]. > > The FLIP started as a small new feature, but in the discussion thread and > in a similar parallel thread [3] we opted for a somewhat bigger change in > the Sink V2 API. > > Please read the FLIP and cast your vote. > > The vote will remain open for at least 72 hours and only concluded if there > are no objections and enough (i.e. at least 3) binding votes. > > Thanks, > Peter > > [1] - https://lists.apache.org/thread/344pzbrqbbb4w0sfj67km25msp7hxlyd > [2] - > > https://cwiki.apache.org/confluence/display/FLINK/FLIP-372%3A+Allow+TwoPhaseCommittingSink+WithPreCommitTopology+to+alter+the+type+of+the+Committable > [3] - https://lists.apache.org/thread/h6nkgth838dlh5s90sd95zd6hlsxwx57 >
